Evan Ramos wrote: > Would it be better to remove the inline keyword from the declaration > of FLAC__bitwriter_write_raw_uint32 (and by extension, remove inline > from FLAC__bitwriter_write_zeroes and add it to > FLAC__bitwriter_write_unary_unsigned)? I suspect that the cache misses > caused by code bloat from so much inlining would outweigh the > comparable function call overhead, but performance testing would be > necessary to confirm this.
I suspect that the main reason for inline attribute of FLAC__bitwriter_write_raw_uint32() is FLAC__bitwriter_write_raw_int32() function. Both of them are used in e.g. libFLAC/stream_encoder_framing.c, FLAC__subframe_add_(constant|fixed|lpc|verbatim) functions. _______________________________________________ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev
