Dagobert Michelsen wrote:
> Hi Erik,
>
> Am 07.04.2013 um 12:25 schrieb Erik de Castro Lopo :
> > Dagobert Michelsen wrote:
> >> Yes, C99 is on and according to B.2.18 from
> >> http://docs.oracle.com/cd/E19205-01/819-5265/bjapp/index.html
> >> also casual use. What does not work is the inclusio
Hi Erik,
Am 07.04.2013 um 12:25 schrieb Erik de Castro Lopo :
> Dagobert Michelsen wrote:
>> Yes, C99 is on and according to B.2.18 from
>> http://docs.oracle.com/cd/E19205-01/819-5265/bjapp/index.html
>> also casual use. What does not work is the inclusion of a static function
>> from extern inl
Janne Hyvärinen wrote:
> Either I sent a wrong patch or the last fix didn't make it in. Here's a
> patch to git version to fix old status print staying on the wrong line
> with certain filename length.
Applied, thanks.
Erik
--
--
On 21.4.2013 10:25, Erik de Castro Lopo wrote:
Janne Hyvärinen wrote:
Sorry for spamming but I noticed one more display glitch while doing
further testing. It could leave old status messages at the end of the
line while printing status messages if initial status fit on one line
and new status t
Janne Hyvärinen wrote:
> Sorry for spamming but I noticed one more display glitch while doing
> further testing. It could leave old status messages at the end of the
> line while printing status messages if initial status fit on one line
> and new status text required new line.
Patches applied
On 08-04-13 22:00, Janne Hyvärinen wrote:
>
> On 8.4.2013 21:38, Janne Hyvärinen wrote:
>> Friendly people on Hydrogenaudio found some bugs with the Unicode
>> printing code, so I was forced to make adjustments.
>> [...]
>
> The long line patch is broken and requires much more work, please
> igno
On 8.4.2013 21:38, Janne Hyvärinen wrote:
Friendly people on Hydrogenaudio found some bugs with the Unicode
printing code, so I was forced to make adjustments.
While doing testing I noticed that long filenames cause printing bugs
on Linux too. If line length on status printing exceeded consol
Dagobert Michelsen wrote:
> Yes, C99 is on and according to B.2.18 from
> http://docs.oracle.com/cd/E19205-01/819-5265/bjapp/index.html
> also casual use. What does not work is the inclusion of a static function
> from extern inline. It also does work if I declare bitwriter_grow_ also
> as "inli
Hi Erik,
Am 07.04.2013 um 04:19 schrieb Erik de Castro Lopo :
> Dagobert Michelsen wrote:
>> There compilation on Solaris 10 Sparc with Sun Studio 12 gives the following
>> compile errors:
>>
>>> CC bitreader.lo
>>> "bitreader.c", line 494: warning: implicit function declaration: MIN
>>> C
Janne Hyvärinen wrote:
> Here's one more try to solve the compilation problem when non-existing
> unistd.h is tried to include with MSVC. It now includes it like before
> the cleanup so it shouldn't do any harm to environments that have worked
> in the past.
Patch applied. Thanks.
Erik
--
--
On 2.4.2013 12:57, Erik de Castro Lopo wrote:
I noticed compat.h patch didn't make it into git. I know it may not be
perfect patch but unistd.h is in two different #ifdef checks. First one
is fine when it's excluded on _WIN32 but second check gives is for
everyone if __CYGWIN__ or __EMX__ isn't
Erik de Castro Lopo wrote:
> > > decode.c: In function ‘write_callback’:
> > > decode.c:965:28: warning: cast increases required alignment of target
> > > type [-Wcast-align]
> > > decode.c:966:28: warning: cast increases required alignment of target
> > > type [-Wcast-align]
> > > decode.c:967:
Janne Hyvärinen wrote:
> These patches change the UTF-8 mode into a runtime choice. The larger
> patch removes the now obsolete "Release (UTF8)" configuration options
> from the project files. The smaller patch makes the utf-8 library use
> ANSI codepage by default. When frontends call the "get
Dagobert Michelsen wrote:
> There compilation on Solaris 10 Sparc with Sun Studio 12 gives the following
> compile errors:
>
> > CC bitreader.lo
> > "bitreader.c", line 494: warning: implicit function declaration: MIN
> > CC bitwriter.lo
> > "bitwriter.c", line 273: reference to stat
Hi Erik,
Am 01.04.2013 um 12:40 schrieb Erik de Castro Lopo :
> The latest pre-release is here:
>
>http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz
>
> but there will probably need to be at least one more.
>
> I've tested this on
>
>x86_64-linux
>powerpc-linux
>
Martijn van Beurden wrote:
> I've tested this on x86_64-linux as well, but still no static building
> possible (see earlier post on this). Someone over at HydrogenAudio has
> successfully built statically linked, but gets all weird kinds of errors
> in the resulting binary
> (http://www.hydro
On 01-04-13 12:40, Erik de Castro Lopo wrote:
> I've tested this on
>
> x86_64-linux
> powerpc-linux
> i386-openbsd5.2
> i386-freebsd9
I've tested this on x86_64-linux as well, but still no static building
possible (see earlier post on this). Someone over at HydrogenAudio has
Janne Hyvärinen wrote:
> Surprisingly flac_mac had mistakenly gotten extra parameters for safe
> string functions requiring further patching.
> And here's patches for the changes in git for flactimer.
Applied, thanks.
> I noticed compat.h patch didn't make it into git. I know it may not be
> p
Janne Hyvärinen wrote:
> I ran the testset with my 32-bit MSYS compile (I use MSYS build from
> http://xhmikosr.1f0.de/tools/). All tests passed.
> I noticed a typo in a warning text while running them though, here's a
> patch for that.
Applied. thanks.
Erik
--
---
On 1.4.2013 22:37, Erik de Castro Lopo wrote:
Janne Hyvärinen wrote:
Zip with random patches:
flac_mac: fixes some missing parameters from safe string handling
changes in flac_mac's main.c
flac_mac_project: adds flac's include dir for the project so new
functions can be found
progress_display:
On 1.4.2013 13:40, Erik de Castro Lopo wrote:
I need people to test this with MSVC (I may have broken something)
and with MinGW (I can cross-compile but I can't run the tests).
Please report back successes and failures (hopefully with patches).
Cheers,
Erik
I ran the testset with my 32-bit M
Janne Hyvärinen wrote:
> Zip with random patches:
>
> flac_mac: fixes some missing parameters from safe string handling
> changes in flac_mac's main.c
> flac_mac_project: adds flac's include dir for the project so new
> functions can be found
> progress_display: flac testing progress display us
LRN wrote:
> Here are the patches. With these flac should compile with both
> mingw.org and mingw-w64 (tried both).
Applied thanks.
> I didn't run the testsuite though.
I would like to see someone run the testsuite with MinGS because
that is something I cannot do.
Cheers,
Erik
--
---
LRN wrote:
> flac-1.3.0pre3/include/share/compat.h:146:31: fatal error:
> share/win_utf8_io.h: No such file or directory
Add that to EXTRA_DIST in include/share/Makefile.am.
Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.me
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01.04.2013 16:26, LRN wrote:
> On 01.04.2013 14:40, Erik de Castro Lopo wrote:
>> Hi all,
>
>> The latest pre-release is here:
>
>> http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz
>
>>
> flac-1.3.0pre3/include/share/compat.h:14
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01.04.2013 16:55, Janne Hyvärinen wrote:
>
> On 1.4.2013 15:29, LRN wrote:
>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1
>>
>> On 01.04.2013 16:24, Janne Hyvärinen wrote:
>>> I'm worried about some of the modifications done to the UTF-8
>>> pa
On 1.4.2013 15:29, LRN wrote:
That's a valid point.
Alternative approach (something i saw in libxml2 recently) is to make
UTF-8-to-UTF-16 conversion a bit smarter:
First try the conversion, assuming the string to be UTF-8-encoded.
If that fails, assume the string is in native encoding, and run
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01.04.2013 16:24, Janne Hyvärinen wrote:
> I'm worried about some of the modifications done to the UTF-8
> patch. In commit 2199d086921eb37d249cae0731f334556ec6209d #ifdef
> checks were changed from specific FLAC__STRINGS_IN_UTF8 to generic
> _WIN32
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01.04.2013 14:40, Erik de Castro Lopo wrote:
> Hi all,
>
> The latest pre-release is here:
>
> http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz
>
flac-1.3.0pre3/include/share/compat.h:146:31: fatal error:
share/win_utf8_io.h: No
I'm worried about some of the modifications done to the UTF-8 patch. In
commit 2199d086921eb37d249cae0731f334556ec6209d #ifdef checks were
changed from specific FLAC__STRINGS_IN_UTF8 to generic _WIN32 and the
specific defines were later removed in commit
0cd2e9ed6918b782195d0024dd19dcfa39df8f82
Hi all,
The latest pre-release is here:
http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz
but there will probably need to be at least one more.
I've tested this on
x86_64-linux
powerpc-linux
i386-openbsd5.2
i386-freebsd9
The majority of changes since the l
31 matches
Mail list logo
