On 1.4.2013 13:40, Erik de Castro Lopo wrote:
I need people to test this with MSVC (I may have broken something)
and with MinGW (I can cross-compile but I can't run the tests).

Please report back successes and failures (hopefully with patches).

Cheers,
Erik

I ran the testset with my 32-bit MSYS compile (I use MSYS build from http://xhmikosr.1f0.de/tools/). All tests passed. I noticed a typo in a warning text while running them though, here's a patch for that.
diff --git a/src/metaflac/options.c b/src/metaflac/options.c
index 6aded4a..e8e6151 100644
--- a/src/metaflac/options.c
+++ b/src/metaflac/options.c
@@ -1084,5 +1084,5 @@ FLAC__bool parse_application_data_format(const char *in, 
FLAC__bool *out)
 
 void undocumented_warning(const char *opt)
 {
-       flac_fprintf(stderr, "WARNING: undocmented option --%s should be used 
with caution,\n         only for repairing a damaged STREAMINFO block\n", opt);
+       flac_fprintf(stderr, "WARNING: undocumented option --%s should be used 
with caution,\n         only for repairing a damaged STREAMINFO block\n", opt);
 }
_______________________________________________
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev

Reply via email to