[FFmpeg-devel] [PATCH 1/9] pthread_frame: use atomics for PerThreadContext.state

2017-03-18 Thread wm4
From: Anton Khirnov Merges Libav commit 64a31b28. Signed-off-by: wm4 --- libavcodec/pthread_frame.c | 84 ++ 1 file changed, 47 insertions(+), 37 deletions(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 272587f53c

[FFmpeg-devel] [PATCH 0/9] Merge Libav changes that allow frame theading with hwaccels

2017-03-18 Thread wm4
don't run simultaneously with hwaccel pthread_frame: do not run hwaccel decoding asynchronously unless it's safe Mark Thompson (1): pthread_frame: Unreference hw_frames_ctx on per-thread codec contexts Wan-Teh Chang (1): pthread_frame: use better memory orders for frame pro

[FFmpeg-devel] [PATCH 4/9] pthread_frame: Unreference hw_frames_ctx on per-thread codec contexts

2017-03-18 Thread wm4
then propagate to all of the other per-thread contexts for decoding. Once the decoder finishes, however, the per-thread contexts are not freed normally, so these references leak. Merges Libav commit fd0fae60. Signed-off-by: wm4 --- libavcodec/pthread_frame.c | 5 - 1 file changed, 4 insertions

[FFmpeg-devel] [PATCH 3/9] pthread_frame: properly propagate the hw frame context across frame threads

2017-03-18 Thread wm4
From: Anton Khirnov Merges Libav commit 84f22568. Signed-off-by: wm4 --- libavcodec/pthread_frame.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 2a5dfc6723..18f89ee73d 100644 --- a/libavcodec/pthread_frame.c

[FFmpeg-devel] [PATCH 6/9] pthread_frame: ensure the threads don't run simultaneously with hwaccel

2017-03-18 Thread wm4
From: Anton Khirnov Merges Libav commit 8dfba25c. Signed-off-by: wm4 --- libavcodec/h263dec.c | 2 +- libavcodec/h264dec.c | 2 +- libavcodec/pthread_frame.c | 34 ++ 3 files changed, 36 insertions(+), 2 deletions(-) diff --git a/libavcodec

[FFmpeg-devel] [PATCH 5/9] pthread_frame: use better memory orders for frame progress

2017-03-18 Thread wm4
igned-off-by: wm4 --- libavcodec/pthread_frame.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index b16c1b9928..2919e9546b 100644 --- a/libavcodec/pthread_frame.c +++ b/libavcodec/pthread_frame.c @@ -500,7 +

[FFmpeg-devel] [PATCH 8/9] pthread_frame: remove some dead code

2017-03-18 Thread wm4
Whatever it was supposed to do. --- libavcodec/pthread_frame.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 1b871c31d4..9de4016593 100644 --- a/libavcodec/pthread_frame.c +++ b/libavcodec/pthread_frame.c @@

[FFmpeg-devel] [PATCH 7/9] pthread_frame: do not run hwaccel decoding asynchronously unless it's safe

2017-03-18 Thread wm4
thread to run while the user is inside a lavc decode call (avcodec_send_packet/receive_frame). Merges Libav commit d4a91e65. Signed-off-by: wm4 --- libavcodec/avcodec.h | 5 + libavcodec/hwaccel.h | 24 + libavcodec/pthread_frame.c | 52

[FFmpeg-devel] [PATCH 9/9] avcodec: remove warning against using frame threading with hwaccels

2017-03-18 Thread wm4
libavcodec now automatically serializes decoding for hwaccels which are not thread-safe. This means API users, which rely on the libavcodec native software fallback mechanism, can now simply enable threading without running into problems. --- libavcodec/utils.c | 5 - 1 file changed, 5 deletio

Re: [FFmpeg-devel] [PATCH 0/9] Merge Libav changes that allow frame theading with hwaccels

2017-03-18 Thread wm4
On Sat, 18 Mar 2017 09:55:57 +0100 wm4 wrote: > Correctness of my merge questionable. Appears to merge. I meant: Appears to pass FATE with threads enabled. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffm

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP1 and MP2 as distinct containers from MP3

2017-03-18 Thread wm4
On Sat, 18 Mar 2017 04:38:03 -0500 Rodger Combs wrote: > This allows us to report the correct codec ID here > --- > libavformat/allformats.c | 3 ++- > libavformat/mp3dec.c | 66 > +++- > libavformat/rawenc.c | 13 ++ > libavformat/ut

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: add concat_seekable operation

2017-03-18 Thread wm4
On Sat, 18 Mar 2017 12:45:34 + Steven Liu wrote: > Nicolas George 于2017年3月18日 周六下午8:35写道: > > > L'octidi 28 ventôse, an CCXXV, Steven Liu a écrit : > > > you can try it: > > > echo "file 'inputfile1.mp4'" > concat input.concatfile > > > echo "file 'inputfile2.mp4'" >> concat input.concatfi

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: add dash demuxer base version

2017-03-19 Thread wm4
On Sun, 19 Mar 2017 10:57:21 +0100 Clément Bœsch wrote: > > If you want to have DASH enabled by default, make sure to have a native > XML parser, or discuss the policy about detecting all the external > libraries within the configure. > That's ridiculous. So NIH is encouraged because of a crap

Re: [FFmpeg-devel] [PATCH 2/3] ffplay: convert to new decode API

2017-03-19 Thread wm4
On Sun, 19 Mar 2017 11:51:28 -0700 Philip Langdale wrote: > On Fri, 17 Mar 2017 19:42:07 -0700 > Philip Langdale wrote: > > > On Sat, 18 Mar 2017 01:51:39 +0100 (CET) > > Marton Balint wrote: > > > > > On Sat, 18 Mar 2017, wal...@free.fr wrote: > > > > > > > The logs: http://pastebin.

Re: [FFmpeg-devel] [PATCH 7/9] pthread_frame: do not run hwaccel decoding asynchronously unless it's safe

2017-03-19 Thread wm4
On Sun, 19 Mar 2017 02:30:11 +0100 Michael Niedermayer wrote: > On Sat, Mar 18, 2017 at 09:56:04AM +0100, wm4 wrote: > > From: Anton Khirnov > > > > Certain hardware decoding APIs are not guaranteed to be thread-safe, so > > having the user access decoded hardware su

Re: [FFmpeg-devel] [PATCH 1/2] fate: add fate-sws-pixdesc-query

2017-03-20 Thread wm4
On Sun, 19 Mar 2017 15:00:55 +0100 Clément Bœsch wrote: > Test the pixel format querying within libswscale. > --- > libswscale/Makefile | 1 + > libswscale/tests/.gitignore | 1 + > libswscale/tests/pixdesc_query.c | 78 > tests/Makefile | 1 +

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '4fb311c804098d78e5ce5f527f9a9c37536d3a08'

2017-03-20 Thread wm4
On Mon, 20 Mar 2017 09:38:15 +0100 Carl Eugen Hoyos wrote: > 2017-03-20 9:35 GMT+01:00 Clément Bœsch : > > On Mon, Mar 20, 2017 at 09:17:36AM +0100, Carl Eugen Hoyos wrote: > >> 2017-03-20 8:57 GMT+01:00 Clément Bœsch : > >> > ffmpeg | branch: master | Clément Bœsch | Mon Mar 20 > >> > 08:5

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '4fb311c804098d78e5ce5f527f9a9c37536d3a08'

2017-03-20 Thread wm4
On Mon, 20 Mar 2017 09:59:24 +0100 Carl Eugen Hoyos wrote: > 2017-03-20 9:42 GMT+01:00 Clément Bœsch : > > On Mon, Mar 20, 2017 at 09:38:15AM +0100, Carl Eugen Hoyos wrote: > >> 2017-03-20 9:35 GMT+01:00 Clément Bœsch : > >> > On Mon, Mar 20, 2017 at 09:17:36AM +0100, Carl Eugen Hoyos wrote:

Re: [FFmpeg-devel] [PATCH 2/3] ffplay: convert to new decode API

2017-03-20 Thread wm4
On Mon, 20 Mar 2017 21:49:14 +0100 (CET) Marton Balint wrote: > On Mon, 20 Mar 2017, wm4 wrote: > > > On Sun, 19 Mar 2017 11:51:28 -0700 > > Philip Langdale wrote: > > > >> On Fri, 17 Mar 2017 19:42:07 -0700 > >> Philip Langdale wrote: > >>

Re: [FFmpeg-devel] [PATCH] swr/resample: free existing ResampleContext on reinit

2017-03-20 Thread wm4
On Mon, 20 Mar 2017 22:33:53 -0300 James Almer wrote: > Fixes memleak (See opus-testvector12 fate test). > > Signed-off-by: James Almer > --- > libswresample/resample.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/libswresample/resample.c b/libswres

Re: [FFmpeg-devel] [PATCH] examples/vaapi_dec: Add a VA-API hwaccel decoding example

2017-03-20 Thread wm4
On Tue, 21 Mar 2017 12:45:26 +0800 Jun Zhao wrote: > From 6b56c541ed7dd271ad0aa6eb6412a8427f009525 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Tue, 21 Mar 2017 11:04:41 +0800 > Subject: [PATCH] examples/vaapi_dec: Add a VA-API hwaccel decoding example. > > Add a VA-API hwaccel decoding ex

Re: [FFmpeg-devel] [PATCH 0/9] Merge Libav changes that allow frame theading with hwaccels

2017-03-20 Thread wm4
On Sat, 18 Mar 2017 09:55:57 +0100 wm4 wrote: > Correctness of my merge questionable. Appears to merge. > > Anton Khirnov (5): > pthread_frame: use atomics for PerThreadContext.state > pthread_frame: use atomics for frame progress > pthread_frame: properly propagate th

Re: [FFmpeg-devel] [PATCH 1/2] avcodec, avformat: deprecate anything related to side data merging

2017-03-20 Thread wm4
On Thu, 16 Mar 2017 05:20:51 +0100 wm4 wrote: > This patch deprecates anything that has to do with merging/splitting Review comments applied and pushed both patches. This doesn't change anything yet (other than adding deprecations) - bumping the ABI/API correctly is up to people in th

[FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-21 Thread wm4
The old "API" that signaled rotation as a metadata value has been replaced by DISPLAYMATRIX side data quite a while ago. There is no reason to make muxers/demuxers/API users support both. In addition, the metadata API is dangerous, as user tags could "leak" into it, creating unintended features or

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-21 Thread wm4
On Tue, 21 Mar 2017 14:09:49 +0100 Clément Bœsch wrote: > On Tue, Mar 21, 2017 at 08:42:58AM +0100, wm4 wrote: > > The old "API" that signaled rotation as a metadata value has been > > replaced by DISPLAYMATRIX side data quite a while ago. > > > > There is

Re: [FFmpeg-devel] [PATCHv2 2/3] ffplay: convert to new decode API

2017-03-21 Thread wm4
On Tue, 21 Mar 2017 07:34:32 -0700 Philip Langdale wrote: > On Mon, 20 Mar 2017 21:51:49 +0100 > Marton Balint wrote: > > > Since subtitles are not yet supported with the new API, > > CODEC_CAP_DELAY subtitle codecs (only libzvbi so far) may loose the > > last few buffered frames in the end of

Re: [FFmpeg-devel] [PATCH 1/4] Place attribute_deprecated in the right position for struct declarations

2017-03-21 Thread wm4
On Tue, 21 Mar 2017 22:43:55 + Mark Thompson wrote: > ... Patches 1-4 trivially LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] lavc: Add hwaccel_flags field to AVCodecContext

2017-03-21 Thread wm4
This "reuses" the flags introduced for the av_vdpau_bind_context() API function, and makes them available to all hwaccels. This does not affect the current vdpau API, as av_vdpau_bind_context() should obviously override the AVCodecContext.hwaccel_flags flags for the sake of compatibility. --- Libav

[FFmpeg-devel] [PATCH 2/2] lavc: vdpau: add support for new hw_frames_ctx and hw_device_ctx API

2017-03-21 Thread wm4
This supports retrieving the device from a provided hw_frames_ctx, and automatically creating a hw_frames_ctx if hw_device_ctx is set. The old API is not deprecated yet. The user can still use av_vdpau_bind_context() (with or without setting hw_frames_ctx), or use the API before that by allocating

Re: [FFmpeg-devel] [PATCH 0/7] convert most of the remaining files to stdatomic

2017-03-22 Thread wm4
On Thu, 23 Mar 2017 00:28:15 -0300 James Almer wrote: > From 3bf230d5f611ae5d1511e4629f742fc96b379b7f Mon Sep 17 00:00:00 2001 > From: James Almer > Date: Wed, 22 Mar 2017 23:43:54 -0300 > Subject: [PATCH] avformat/format: convert to stdatomic > > --- > libavformat/format.c | 9 ++--- > 1

Re: [FFmpeg-devel] [PATCH] ffmpeg: Remove hw_device_ctx output filter reinit hack

2017-03-22 Thread wm4
On Wed, 22 Mar 2017 21:26:27 + Mark Thompson wrote: > This was skipped in c17563c5d3c974a69709ebae0171534763b3051c because > it depended on the filter setup merge, but was forgotten after that > actually happened. > > Fixes hwaccel fate for stream size change tests. > --- > ffmpeg_filter.c

Re: [FFmpeg-devel] [PATCH 6/7] avutil/opencl: convert to stdatomic

2017-03-22 Thread wm4
On Wed, 22 Mar 2017 20:34:11 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavutil/opencl.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavutil/opencl.c b/libavutil/opencl.c > index af35770e06..9b6c8d10d8 100644 > --- a/libavutil/opencl.c >

Re: [FFmpeg-devel] [PATCH 6/7] avutil/opencl: convert to stdatomic

2017-03-22 Thread wm4
On Wed, 22 Mar 2017 20:34:11 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavutil/opencl.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavutil/opencl.c b/libavutil/opencl.c > index af35770e06..9b6c8d10d8 100644 > --- a/libavutil/opencl.c >

Re: [FFmpeg-devel] [PATCH 5/7] avfilter/avfilter: convert to stdatomic

2017-03-22 Thread wm4
On Wed, 22 Mar 2017 20:34:10 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/avfilter.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c > index b431990edc..049c5ff47c 100644 > --- a/libavfi

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/mediacodec: convert to stdatomic

2017-03-22 Thread wm4
On Wed, 22 Mar 2017 20:34:06 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > Untested. > > libavcodec/mediacodec.c | 5 ++--- > libavcodec/mediacodecdec.c| 1 - > libavcodec/mediacodecdec_common.c | 14 ++ > libavcodec/mediacodecdec_common.h | 5 +

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-22 Thread wm4
On Wed, 22 Mar 2017 19:32:11 +0100 Michael Niedermayer wrote: > On Tue, Mar 21, 2017 at 08:42:58AM +0100, wm4 wrote: > > The old "API" that signaled rotation as a metadata value has been > > replaced by DISPLAYMATRIX side data quite a while ago. > > > &

Re: [FFmpeg-devel] [PATCH 2/2] lavc: vdpau: add support for new hw_frames_ctx and hw_device_ctx API

2017-03-23 Thread wm4
On Wed, 22 Mar 2017 19:48:00 + Mark Thompson wrote: > On 22/03/17 06:47, wm4 wrote: > > This supports retrieving the device from a provided hw_frames_ctx, and > > automatically creating a hw_frames_ctx if hw_device_ctx is set. > > > > The old API is not depreca

Re: [FFmpeg-devel] [PATCH] Consistent use of user_agent in hls.c

2017-03-23 Thread wm4
On Fri, 17 Feb 2017 12:00:40 +0100 Jan Berkel wrote: > This came up while debugging a problem with mpv: > https://github.com/mpv-player/mpv/issues/4155 > --- > libavformat/hls.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

2017-03-24 Thread wm4
On Mon, 20 Mar 2017 14:39:07 -0700 Fredrik Hubinette wrote: > It looks like the value in s->error also comes from an earlier call to > avio_read(). > ogg_read_page tries to read 4439 bytes from the file. It has 524 bytes > already buffered. > fill_buffer() fails with an EIO, but because of the bu

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread wm4
On Fri, 24 Mar 2017 10:40:21 +0100 Carl Eugen Hoyos wrote: > From 1c249440c62271565be12112f321ad9aa6a922fb Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Fri, 24 Mar 2017 10:38:22 +0100 > Subject: [PATCH] lavc/h264_ps: Check that chroma_location is within limits. > > Fixes ticket #62

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread wm4
On Fri, 24 Mar 2017 11:23:44 +0100 Carl Eugen Hoyos wrote: > 2017-03-24 10:59 GMT+01:00 wm4 : > > On Fri, 24 Mar 2017 10:40:21 +0100 > > Carl Eugen Hoyos wrote: > > > >> From 1c249440c62271565be12112f321ad9aa6a922fb Mon Sep 17 00:00:00 2001 > >> From: C

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-24 Thread wm4
On Fri, 24 Mar 2017 07:48:53 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Fri, Mar 24, 2017 at 7:40 AM, Ronald S. Bultje > wrote: > > > Hi, > > > > On Fri, Mar 24, 2017 at 6:23 AM, Carl Eugen Hoyos > > wrote: > > > >> there are several similar cases there. > > > > > > That is classically

[FFmpeg-devel] [PATCH] pthread_frame: do not attempt to unlock a mutex on the wrong thread

2017-03-24 Thread wm4
async_mutex has is used in a very strange but intentional way: it is locked by default, and unlocked only in regions that can be run concurrently. If the user was calling API functions to the same context from different threads (in a safe way), this could unintentionally unlock the mutex on a diff

[FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-24 Thread wm4
The old "API" that signaled rotation as a metadata value has been replaced by DISPLAYMATRIX side data quite a while ago. There is no reason to make muxers/demuxers/API users support both. In addition, the metadata API is dangerous, as user tags could "leak" into it, creating unintended features or

Re: [FFmpeg-devel] [PATCH] pthread_frame: do not attempt to unlock a mutex on the wrong thread

2017-03-25 Thread wm4
On Fri, 24 Mar 2017 18:53:41 +0100 Michael Niedermayer wrote: > On Fri, Mar 24, 2017 at 01:47:10PM +0100, wm4 wrote: > > async_mutex has is used in a very strange but intentional way: it is > > locked by default, and unlocked only in regions that can be run > > concurrently.

Re: [FFmpeg-devel] [PATCH] pthread_frame: do not attempt to unlock a mutex on the wrong thread

2017-03-25 Thread wm4
On Fri, 24 Mar 2017 18:53:41 +0100 Michael Niedermayer wrote: > On Fri, Mar 24, 2017 at 01:47:10PM +0100, wm4 wrote: > > async_mutex has is used in a very strange but intentional way: it is > > locked by default, and unlocked only in regions that can be run > > concurrently.

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

2017-03-25 Thread wm4
On Fri, 24 Mar 2017 21:42:18 -0400 Micah Galizia wrote: > Signed-off-by: Micah Galizia > --- > libavformat/http.c | 41 + > 1 file changed, 37 insertions(+), 4 deletions(-) > > diff --git a/libavformat/http.c b/libavformat/http.c > index 293a8a7..37bdacf

Re: [FFmpeg-devel] [PATCH] clear s->error in avio_read

2017-03-25 Thread wm4
On Fri, 24 Mar 2017 10:47:53 -0700 Fredrik Hubinette wrote: > On Fri, Mar 24, 2017 at 12:47 AM, wm4 wrote: > > > On Mon, 20 Mar 2017 14:39:07 -0700 > > Fredrik Hubinette wrote: > > > > > It looks like the value in s->error also comes fro

[FFmpeg-devel] [PATCH v3] avformat, ffmpeg: deprecate old rotation API

2017-03-25 Thread wm4
The old "API" that signaled rotation as a metadata value has been replaced by DISPLAYMATRIX side data quite a while ago. There is no reason to make muxers/demuxers/API users support both. In addition, the metadata API is dangerous, as user tags could "leak" into it, creating unintended features or

Re: [FFmpeg-devel] [PATCH] pthread_frame: do not attempt to unlock a mutex on the wrong thread

2017-03-25 Thread wm4
On Sat, 25 Mar 2017 13:01:58 +0100 Michael Niedermayer wrote: > On Sat, Mar 25, 2017 at 12:03:23PM +0100, wm4 wrote: > > On Fri, 24 Mar 2017 18:53:41 +0100 > > Michael Niedermayer wrote: > > > > > On Fri, Mar 24, 2017 at 01:47:10PM +0100, wm4 wrote: > &

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

2017-03-25 Thread wm4
On Sat, 25 Mar 2017 10:31:00 -0400 Micah Galizia wrote: > Signed-off-by: Micah Galizia > --- > libavformat/http.c | 43 +++ > 1 file changed, 39 insertions(+), 4 deletions(-) > > diff --git a/libavformat/http.c b/libavformat/http.c > index 293a8a7..f7d19

Re: [FFmpeg-devel] [PATCH 7/9] pthread_frame: do not run hwaccel decoding asynchronously unless it's safe

2017-03-26 Thread wm4
On Sat, 25 Mar 2017 21:33:50 -0300 James Almer wrote: > On 3/25/2017 9:23 PM, Michael Niedermayer wrote: > > On Sat, Mar 18, 2017 at 09:56:04AM +0100, wm4 wrote: > >> From: Anton Khirnov > >> > >> Certain hardware decoding APIs are not guaranteed to be

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

2017-03-26 Thread wm4
On Sun, 26 Mar 2017 18:11:01 +0200 Michael Niedermayer wrote: > Fixes: 943/clusterfuzz-testcase-5114865297391616 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/mjpegdec.c | 3 ++-

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

2017-03-26 Thread wm4
On Sun, 26 Mar 2017 19:16:26 +0200 Michael Niedermayer wrote: > On Sun, Mar 26, 2017 at 06:51:11PM +0200, wm4 wrote: > > On Sun, 26 Mar 2017 18:11:01 +0200 > > Michael Niedermayer wrote: > > > > > Fixes: 943/clusterfuzz-testcase-5114865297391616 > > &

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Correct and make consistent AVERROR() in comments

2017-03-27 Thread wm4
On Sun, 26 Mar 2017 21:17:54 +0200 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index af327ff9ad..4f3303366f 100644 > -

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 09:31:39 +0200 Carl Eugen Hoyos wrote: > 2017-03-24 15:16 GMT+01:00 Ronald S. Bultje : > > There is also the risk with the initial patch that compiling libavcodec > > against a newer libavutil but then runtime linking it with another (older) > > one would lead to crashes. >

Re: [FFmpeg-devel] [PATCH] pthread_frame: do not attempt to unlock a mutex on the wrong thread

2017-03-27 Thread wm4
On Sat, 25 Mar 2017 13:25:32 +0100 Michael Niedermayer wrote: > On Sat, Mar 25, 2017 at 01:13:13PM +0100, wm4 wrote: > > On Sat, 25 Mar 2017 13:01:58 +0100 > > Michael Niedermayer wrote: > > > > > On Sat, Mar 25, 2017 at 12:03:23PM +0100, wm4 wrote: > &

Re: [FFmpeg-devel] [PATCH v3] avformat, ffmpeg: deprecate old rotation API

2017-03-27 Thread wm4
On Sat, 25 Mar 2017 12:28:26 +0100 wm4 wrote: > The old "API" that signaled rotation as a metadata value has been > replaced by DISPLAYMATRIX side data quite a while ago. > > There is no reason to make muxers/demuxers/API users support both. In > addition, the metadata

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 13:29:35 +0200 Carl Eugen Hoyos wrote: > 2017-03-27 11:40 GMT+02:00 wm4 : > > On Mon, 27 Mar 2017 09:31:39 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2017-03-24 15:16 GMT+01:00 Ronald S. Bultje : > > >> In addition, giving

[FFmpeg-devel] [PATCH] pthread_frame: minor simplification to error handling

2017-03-27 Thread wm4
Get rid of the "ret" variable, and always use err. Report the packet as consumed if err is unset. This should be equivalent to the old code, which obviously required err=0 for p->result>=0 (and otherwise, p->result must have had the value err was last set to). The code block added by commit 32a5b63

Re: [FFmpeg-devel] [PATCH] h264: revert 1189af429211ac650aac730368a6cf5b23756605.

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 09:39:32 -0400 "Ronald S. Bultje" wrote: > The patch introduces race conditions. > --- > libavcodec/h264_slice.c | 3 --- > libavcodec/h264dec.c| 20 > libavcodec/h264dec.h| 8 > 3 files changed, 31 deletions(-) > > diff --git a/libavc

Re: [FFmpeg-devel] [PATCH 02/10] lavc: deprecate av_get_codec_tag_string()

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 09:51:55 +0200 Clément Bœsch wrote: > --- > libavcodec/avcodec.h | 5 + > libavcodec/version.h | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 4f3303366f..5c891b531a 100644 > --- a/libavcodec/avcodec.h > ++

Re: [FFmpeg-devel] [PATCH] dirac: make initialization of arithmetic coder tables threadsafe.

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 10:09:05 -0400 "Ronald S. Bultje" wrote: > --- > libavcodec/dirac_arith.c | 17 +++-- > libavcodec/dirac_arith.h | 1 + > libavcodec/diracdec.c| 9 - > 3 files changed, 20 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/dirac_arith.c b/lib

Re: [FFmpeg-devel] [PATCH] h264: revert 1189af429211ac650aac730368a6cf5b23756605.

2017-03-27 Thread wm4
On Mon, 27 Mar 2017 21:54:49 +0200 Michael Niedermayer wrote: > On Mon, Mar 27, 2017 at 11:03:53AM -0400, Ronald S. Bultje wrote: > > The patch introduces race conditions. > > --- > > libavcodec/h264_slice.c | 3 --- > > libavcodec/h264dec.c| 24 > > libavcodec/h264

Re: [FFmpeg-devel] [PATCH] doc/examples/remuxing: switch to codecpar

2017-03-28 Thread wm4
On Tue, 28 Mar 2017 12:32:19 +0200 Matthieu Bouron wrote: > Also limits remuxing to audio, video and subtitle streams. > --- > doc/examples/remuxing.c | 48 +--- > 1 file changed, 41 insertions(+), 7 deletions(-) > > diff --git a/doc/examples/remuxing

Re: [FFmpeg-devel] [PATCH] doc/examples/remuxing: switch to codecpar

2017-03-28 Thread wm4
On Tue, 28 Mar 2017 13:09:54 +0200 Matthieu Bouron wrote: > On Tue, Mar 28, 2017 at 12:48 PM, wm4 wrote: > > > On Tue, 28 Mar 2017 12:32:19 +0200 > > Matthieu Bouron wrote: > > > > > Also limits remuxing to audio, video and subtitle streams. > > &g

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

2017-03-29 Thread wm4
On Mon, 27 Mar 2017 00:41:05 +0200 Michael Niedermayer wrote: > On Sun, Mar 26, 2017 at 05:30:05PM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Sun, Mar 26, 2017 at 3:31 PM, Michael Niedermayer > > > > wrote: > > > > > On

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

2017-03-29 Thread wm4
On Wed, 29 Mar 2017 09:54:27 +0200 Carl Eugen Hoyos wrote: > 2017-03-27 13:41 GMT+02:00 wm4 : > > On Mon, 27 Mar 2017 13:29:35 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2017-03-27 11:40 GMT+02:00 wm4 : > >> > On Mon, 27 Mar 2017 09:

Re: [FFmpeg-devel] [PATCH] new API usage example (adts-aac encoding from raw audio file)

2017-03-29 Thread wm4
On Tue, 28 Mar 2017 22:58:18 +0200 Paolo Prete wrote: > --- > doc/examples/Makefile | 1 + > doc/examples/encode_raw_audio_file_to_aac.c | 275 > > 2 files changed, 276 insertions(+) > create mode 100644 doc/examples/encode_raw_audio_file_to

Re: [FFmpeg-devel] [PATCH] pthread_frame: minor simplification to error handling

2017-03-29 Thread wm4
On Mon, 27 Mar 2017 14:28:17 +0200 wm4 wrote: > Get rid of the "ret" variable, and always use err. Report the packet as > consumed if err is unset. This should be equivalent to the old code, > which obviously required err=0 for p->result>=0 (and otherwise, > p->res

Re: [FFmpeg-devel] [PATCH] doc/examples/filtering_video: switch to new decoding API

2017-03-29 Thread wm4
On Wed, 29 Mar 2017 15:03:55 +0200 Matthieu Bouron wrote: > --- > doc/examples/filtering_video.c | 32 ++-- > 1 file changed, 26 insertions(+), 6 deletions(-) > > diff --git a/doc/examples/filtering_video.c b/doc/examples/filtering_video.c > index 15116d3881..b664c69

Re: [FFmpeg-devel] [PATCH 3/6] pthread_frame: call update_context_from_user() after acquiring lock.

2017-03-29 Thread wm4
On Wed, 29 Mar 2017 10:12:21 -0400 "Ronald S. Bultje" wrote: > Otherwise the thread may still be in the middle of decoding a previous > frame, which would effectively trigger a race condition on any field > concurrently read and written. > --- > libavcodec/pthread_frame.c | 14 +- >

Re: [FFmpeg-devel] [PATCH] compat/atomics: fix atomic_fetch_xor()

2017-03-29 Thread wm4
On Wed, 29 Mar 2017 15:57:45 -0300 James Almer wrote: > --- > compat/atomics/dummy/stdatomic.h | 2 +- > compat/atomics/gcc/stdatomic.h | 4 ++-- > compat/atomics/pthread/stdatomic.h | 2 +- > compat/atomics/suncc/stdatomic.h | 2 +- > compat/atomics/win32/stdatomic.h | 2 +- > 5 files

Re: [FFmpeg-devel] [PATCH] pthread_frame: minor simplification to error handling

2017-03-29 Thread wm4
On Wed, 29 Mar 2017 22:25:48 +0200 Alexander Strasser wrote: > Hi, > > I already saw this on -cvslog ml, so apparently I am too late... > > On 2017-03-29 12:19 +0200, wm4 wrote: > > On Mon, 27 Mar 2017 14:28:17 +0200 > > wm4 wrote: > > > > > Get

Re: [FFmpeg-devel] [PATCH v11] avformat/dashdec: add dash demuxer base version

2017-03-30 Thread wm4
On Thu, 30 Mar 2017 08:34:18 +0800 Steven Liu wrote: > v2 fixed: > 1. from autodetect to disabled > 2. from camelCase code style to ffmpeg code style > 3. from RepType to AVMediaType > 4. fix variable typo > 5. change time value from uint32_t to uint64_t > 6. removed be used once API > 7. change

Re: [FFmpeg-devel] [PATCH] doc/examples/filtering_video: switch to new decoding API

2017-03-30 Thread wm4
On Thu, 30 Mar 2017 13:35:47 +0200 Matthieu Bouron wrote: > From e9e5b3e679a12fdd9495c53177ade51c3dee7ba2 Mon Sep 17 00:00:00 2001 > From: Matthieu Bouron > Date: Wed, 29 Mar 2017 14:58:01 +0200 > Subject: [PATCH] doc/examples/filtering_video: switch to new decoding API > > --- > doc/examples/

[FFmpeg-devel] [PATCH] ffprobe: port to new decode API

2017-03-30 Thread wm4
Not sure if it behaves ideally in presence of decoding errors. --- The original version of this patch is actually 1 year old. --- ffprobe.c | 42 +- 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/ffprobe.c b/ffprobe.c index fa60894833..c35d4

Re: [FFmpeg-devel] [PATCH] ffprobe: port to new decode API

2017-03-31 Thread wm4
On Fri, 31 Mar 2017 03:49:16 +0200 Michael Niedermayer wrote: > On Thu, Mar 30, 2017 at 05:05:36PM +0200, wm4 wrote: > > Not sure if it behaves ideally in presence of decoding errors. > > --- > > The original version of this patch is actually 1 year old. > &

Re: [FFmpeg-devel] [PATCH] ffmpeg: make transcode_init_done atomic.

2017-03-31 Thread wm4
On Fri, 31 Mar 2017 11:45:44 -0400 "Ronald S. Bultje" wrote: > Should fix tsan warnings in fate-fifo-muxer-h264/wav: > > WARNING: ThreadSanitizer: data race (pid=26552) > Write of size 4 at 0x01e0d7c0 by main thread: > #0 transcode_init src/ffmpeg.c:3761 (ffmpeg+0x0050ca1c) > [..]

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-01 Thread wm4
On Sat, 1 Apr 2017 10:01:15 +0200 Nicolas George wrote: > Le primidi 11 germinal, an CCXXV, Steven Liu a écrit : > > I think just similar, not duplicating, and the simple functionality use > > BPrint maybe too complex. > > Well, I will say it unambiguously: > > Parts of this patch DO duplicat

[FFmpeg-devel] [PATCH] Add MediaFoundation wrapper

2017-04-01 Thread wm4
Can do audio decoding, audio encoding, video decoding, video encoding, video HW encoding. I also had video HW decoding, but removed it for now, as thw hwframes integration wasn't very sane. Some of the MS codecs aren't well tested, and might not work properly. --- configure | 34 +

Re: [FFmpeg-devel] [PATCH v12] avformat/dashdec: add dash demuxer base version

2017-04-01 Thread wm4
On Sat, 1 Apr 2017 15:20:22 +0200 Nicolas George wrote: > Le duodi 12 germinal, an CCXXV, Steven Liu a écrit : > > oops, sorry, the reviewer name add by the members who have reply mail, if > > you don't like to review this patch, i will remove your reviewed-by, sorry. > > > > I intend to revi

Re: [FFmpeg-devel] [PATCH] Add MediaFoundation wrapper

2017-04-01 Thread wm4
On Sat, 1 Apr 2017 12:13:45 -0300 James Almer wrote: > On 4/1/2017 8:28 AM, wm4 wrote: > > Can do audio decoding, audio encoding, video decoding, video encoding, > > video HW encoding. I also had video HW decoding, but removed it for now, > > as thw hwframes integra

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-01 Thread wm4
On Sat, 1 Apr 2017 22:34:26 +0200 Alexander Strasser wrote: > On 2017-04-01 13:12 +0200, wm4 wrote: > > On Sat, 1 Apr 2017 10:01:15 +0200 > > Nicolas George wrote: > [...] > > > Therefore, it was not acceptable as is and should not have been pushed. > > &g

Re: [FFmpeg-devel] [PATCH 1/3] libavformat: add "capture:" protocol

2017-04-03 Thread wm4
On Mon, 3 Apr 2017 11:25:39 +0200 Michael Niedermayer wrote: > On Mon, Apr 03, 2017 at 07:10:42PM +1000, Timothy Lee wrote: > > On 04/03/2017 06:35 PM, Nicolas George wrote: > > >Hi. Thanks for the patch. > > > > > >Le quartidi 14 germinal, an CCXXV, Timothy Lee a écrit : > > >>Capture is an

Re: [FFmpeg-devel] H.261 chroma motion vector rounding.

2017-04-03 Thread wm4
On Mon, 3 Apr 2017 10:31:15 +0100 Christina Brien wrote: > > For both positive and negative numbers. > > > > 3 / 2 = 1 > > -3 / 2 = -1 > > You’re right. I was confusing integer division by a power of two, with > right-shifting. The bug was in my code all along. > > I apologise for wasting y

Re: [FFmpeg-devel] [PATCH 1/3] libavformat: add "capture:" protocol

2017-04-03 Thread wm4
On Mon, 3 Apr 2017 18:20:35 +0800 Steven Liu wrote: > 2017-04-03 18:12 GMT+08:00 wm4 : > > > On Mon, 3 Apr 2017 11:25:39 +0200 > > Michael Niedermayer wrote: > > > > > On Mon, Apr 03, 2017 at 07:10:42PM +1000, Timothy Lee wrote: > > > >

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: use reordered duration for stream PTS.

2017-04-03 Thread wm4
On Mon, 3 Apr 2017 14:52:15 +0200 Nicolas George wrote: > Signed-off-by: Nicolas George > --- > ffmpeg.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > > Not sure if this is correct, the timestamp handling is awfully complicated. > But FATE succeeds and the result is a c

Re: [FFmpeg-devel] [PATCH] HDR Transcode VUI Info Copy

2017-04-03 Thread wm4
On Mon, 3 Apr 2017 19:50:07 + Ben Chang wrote: > From c8092bc538ba7ae32357ca166e67809eb3705f60 Mon Sep 17 00:00:00 2001 > From: Ben Chang > Date: Mon, 27 Mar 2017 17:00:19 -0700 > Subject: [PATCH] Allow transfer of HDR-required VUI info from dec ctx to enc > ctx > > --- > ffmpeg.c | 3 +++

[FFmpeg-devel] [PATCH v2] Add MediaFoundation wrapper

2017-04-03 Thread wm4
Can do audio decoding, audio encoding, video decoding, video encoding, video HW encoding. I also had video HW decoding, but removed it for now, as thw hwframes integration wasn't very sane. Some of the MS codecs aren't well tested, and might not work properly. --- Didn't actually test compilation

Re: [FFmpeg-devel] [PATCH] ffprobe: port to new decode API

2017-04-03 Thread wm4
On Fri, 31 Mar 2017 03:49:16 +0200 Michael Niedermayer wrote: > On Thu, Mar 30, 2017 at 05:05:36PM +0200, wm4 wrote: > > Not sure if it behaves ideally in presence of decoding errors. > > --- > > The original version of this patch is actually 1 year old. > &

Re: [FFmpeg-devel] [PATCH 2/2] lavc/mediacodecdec: set AV_CODEC_CAP_AVOID_PROBING capability

2017-04-04 Thread wm4
On Tue, 4 Apr 2017 09:21:00 +0200 Matthieu Bouron wrote: > --- > libavcodec/mediacodecdec.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > Both patches LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.o

Re: [FFmpeg-devel] [PATCH v2] Add MediaFoundation wrapper

2017-04-04 Thread wm4
On Tue, 4 Apr 2017 12:09:23 +0200 Carl Eugen Hoyos wrote: > 2017-04-04 7:45 GMT+02:00 wm4 : > > > + --enable-mf enable decoding via MediaFoundation [no] > > Why is it not autodetected? Do we want that? ___ ffmpeg-

Re: [FFmpeg-devel] [PATCH v2] Add MediaFoundation wrapper

2017-04-04 Thread wm4
On Tue, 4 Apr 2017 12:43:14 +0200 Carl Eugen Hoyos wrote: > 2017-04-04 12:41 GMT+02:00 wm4 : > > On Tue, 4 Apr 2017 12:09:23 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2017-04-04 7:45 GMT+02:00 wm4 : > >> > >> > + --enable-mf

Re: [FFmpeg-devel] [PATCH v2] Add MediaFoundation wrapper

2017-04-04 Thread wm4
On Tue, 4 Apr 2017 15:44:29 +0200 Carl Eugen Hoyos wrote: > 2017-04-04 12:45 GMT+02:00 wm4 : > > On Tue, 4 Apr 2017 12:43:14 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2017-04-04 12:41 GMT+02:00 wm4 : > >> > On Tue, 4 Apr 2017 12:

Re: [FFmpeg-devel] [PATCH v2] Add MediaFoundation wrapper

2017-04-04 Thread wm4
On Tue, 4 Apr 2017 16:30:58 +0200 Carl Eugen Hoyos wrote: > 2017-04-04 16:04 GMT+02:00 wm4 : > > On Tue, 4 Apr 2017 15:44:29 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2017-04-04 12:45 GMT+02:00 wm4 : > >> > On Tue, 4 Apr 2017 12:

Re: [FFmpeg-devel] [PATCH] HDR Transcode VUI Info Copy

2017-04-04 Thread wm4
On Tue, 4 Apr 2017 17:01:15 +0200 Michael Niedermayer wrote: > On Mon, Apr 03, 2017 at 07:50:07PM +, Ben Chang wrote: > > Hi, > > > > This patch adds copy of HDR VUI info from decode ctx to encode ctx. > > Currently, information under colour_description_present_flag (eg. colour > > primar

Re: [FFmpeg-devel] [PATCH v2] Add MediaFoundation wrapper

2017-04-04 Thread wm4
On Tue, 4 Apr 2017 12:34:56 -0300 James Almer wrote: > On 4/4/2017 2:45 AM, wm4 wrote: > > Can do audio decoding, audio encoding, video decoding, video encoding, > > video HW encoding. I also had video HW decoding, but removed it for now, > > as thw hwframes integra

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '5f102a9559099429826e84758b8b5182244c52db'

2017-04-05 Thread wm4
On Wed, 5 Apr 2017 10:54:38 +0200 Michael Niedermayer wrote: > On Wed, Apr 05, 2017 at 12:31:24AM -0300, James Almer wrote: > > On 4/4/2017 11:12 PM, Michael Niedermayer wrote: > > > On Tue, Apr 04, 2017 at 11:44:21AM +0200, Clément Bœsch wrote: > > >> ffmpeg | branch: master | Clément Bœsch

Re: [FFmpeg-devel] [PATCH] flvdec: option for dropping negative CTS frames Initial frames with negative pts can produce video/audio desynchronization when a decoder is not prepared to handle negative

2017-04-05 Thread wm4
On Wed, 5 Apr 2017 14:29:30 -0300 fel...@astroza.cl wrote: > From: Felipe Astroza > > Signed-off-by: Felipe Astroza > --- > libavformat/flvdec.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c > index 3959a3

  1   2   3   4   5   6   7   8   9   10   >