[FFmpeg-devel] [PATCH v6 10/13] fftools/resources: Add resource manager files

2025-04-23 Thread softworkz
From: softworkz Signed-off-by: softworkz --- ffbuild/common.mak | 28 ++- fftools/Makefile | 3 +- fftools/resources/.gitignore | 4 + fftools/resources/Makefile | 27 +++ fftools/resources/graph.css | 353 +++ fftools/resources

[FFmpeg-devel] [PATCH v6 13/13] fftools/graphprint: Now, make it a Killer-Feature!

2025-04-23 Thread softworkz
From: softworkz remember this: -sg <= show-graph Signed-off-by: softworkz --- doc/ffmpeg.texi | 4 + fftools/Makefile | 1 + fftools/ffmpeg.c | 2 +- fftools/ffmpeg.h | 1 + fftools/ffmpeg_filter.c | 2 +- fftools/ffmpeg_op

[FFmpeg-devel] [PATCH v6 01/13] fftools/textformat: Formatting and whitespace changes

2025-04-23 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 86 ++-- fftools/textformat/avtextformat.h | 16 +++--- fftools/textformat/avtextwriters.h | 11 ++-- fftools/textformat/tf_compact.c| 91

[FFmpeg-devel] [PATCH v6 03/13] fftools/avtextformat: Re-use BPrint in loop

2025-04-23 Thread softworkz
From: softworkz Instead of initializing a new BPrint in each iteration of the loop, re-use the same BPrint struct and just clear it for each iteration. Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions

[FFmpeg-devel] [PATCH v6 09/13] avfilter/avfilter: Add avfilter_link_get_hw_frames_ctx()

2025-04-23 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavfilter/avfilter.c | 9 + libavfilter/avfilter.h | 12 3 files changed, 24 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 75d66f87f3..d0869561f3 100644 --- a/doc

Re: [FFmpeg-devel] [PATCH v5 04/14] fftools/textformat: Introduce AVTextFormatOptions for avtext_context_open()

2025-04-23 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Donnerstag, 24. April 2025 00:49 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH v5 04/14] fftools/textformat: > Introduce

Re: [FFmpeg-devel] [PATCH v5 02/14] fftools/textformat: Apply quality improvements

2025-04-23 Thread softworkz .
gt; quality improvements > > softworkz . (HE12025-04-23): > > Despite its name, there's automatism for anything. > > Look for the word “automatic” in the C standard. > > -- > Nicolas George > ___ Ah, alright - this is alludin

Re: [FFmpeg-devel] [PATCH v5 02/14] fftools/textformat: Apply quality improvements

2025-04-23 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > softworkz . > Sent: Donnerstag, 24. April 2025 01:05 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v5 02/14] fftools/textformat: Apply &

Re: [FFmpeg-devel] [PATCH v2] avformat/dump: Stream start offsets: change precision and label

2025-04-25 Thread softworkz .
ange precision and label > > > > On Tue, 22 Apr 2025, softworkz wrote: > > > From: softworkz > > > > - Change precision to 6 digits to align with other printed times > > - Change label to just "Start" > > - Add 's' unit to format

Re: [FFmpeg-devel] On errors, asserts and crashing (was: Shaping the AVTextFormat API Surface)

2025-04-25 Thread softworkz .
AVTextFormat API Surface) > > softworkz . (HE12025-04-22): > > At the implementation level, I sensed that "you" ("FFmpeg") > > are following some principles which are somewhat contradictive to > > those that I'm usually adhering to (e.g. "parame

[FFmpeg-devel] [PATCH v7 04/13] fftools/textformat: Introduce AVTextFormatOptions for avtext_context_open()

2025-04-25 Thread softworkz
From: softworkz This allows future addition of options without changes to the signature of avtext_context_open(). Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/ffprobe.c | 13 + fftools/textformat/avtextformat.c | 21

[FFmpeg-devel] [PATCH v7 13/13] fftools/graphprint: Now, make it a Killer-Feature!

2025-04-25 Thread softworkz
From: softworkz remember this: -sg <= show-graph Signed-off-by: softworkz --- doc/ffmpeg.texi | 4 + fftools/Makefile | 1 + fftools/ffmpeg.c | 2 +- fftools/ffmpeg.h | 1 + fftools/ffmpeg_filter.c | 2 +- fftools/ffmpeg_op

[FFmpeg-devel] [PATCH v7 08/13] fftools/ffmpeg_filter: Move some declaration to new header file

2025-04-25 Thread softworkz
From: softworkz to allow filtergraph printing to access the information. Signed-off-by: softworkz --- fftools/ffmpeg_filter.c | 190 +--- fftools/ffmpeg_filter.h | 234 2 files changed, 235 insertions(+), 189 deletions

[FFmpeg-devel] [PATCH v7 03/13] fftools/avtextformat: Re-use BPrint in loop

2025-04-25 Thread softworkz
From: softworkz Instead of initializing a new BPrint in each iteration of the loop, re-use the same BPrint struct and just clear it for each iteration. Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions

[FFmpeg-devel] [PATCH v7 01/13] fftools/textformat: Formatting and whitespace changes

2025-04-25 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 86 ++-- fftools/textformat/avtextformat.h | 16 +++--- fftools/textformat/avtextwriters.h | 11 ++-- fftools/textformat/tf_compact.c| 91

[FFmpeg-devel] [PATCH v7 10/13] fftools/resources: Add resource manager files

2025-04-25 Thread softworkz
From: softworkz Signed-off-by: softworkz --- ffbuild/common.mak | 28 ++- fftools/Makefile | 3 +- fftools/resources/.gitignore | 4 + fftools/resources/Makefile | 27 +++ fftools/resources/graph.css | 353 +++ fftools/resources

[FFmpeg-devel] [PATCH v7 05/13] fftools/textformat: Introduce common header and deduplicate code

2025-04-25 Thread softworkz
From: softworkz Also change writer_printf signature in AVTextWriter to use va_list, so that it can be called by the new function writer_printf() in tf_internal.h. Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextwriters.h | 2 +- fftools/textformat

[FFmpeg-devel] [PATCH v7 07/13] fftools/textformat: Add function avtext_print_integer_flags()

2025-04-25 Thread softworkz
From: softworkz This function works analog to the avtext_print_string() which already has a flags parameter. Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 25 + fftools/textformat/avtextformat.h | 2 ++ 2 files changed, 23 insertions(+), 4 deletions

[FFmpeg-devel] [PATCH v7 06/13] fftools/tf_internal: Use av_default_item_name

2025-04-25 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/tf_internal.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fftools/textformat/tf_internal.h b/fftools/textformat/tf_internal.h index 362a4cbc38..484886b7a7 100644 --- a

[FFmpeg-devel] [PATCH v7 11/13] fftools/ffmpeg_mux: Make ms_from_ost() inline

2025-04-25 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/ffmpeg_mux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux.h b/fftools/ffmpeg_mux.h index f41f2c18fa..4ca8ab73a4 100644 --- a/fftools/ffmpeg_mux.h +++ b/fftools/ffmpeg_mux.h @@ -123,7 +123,7

[FFmpeg-devel] [PATCH v7 12/13] fftools/graphprint: Add execution graph printing

2025-04-25 Thread softworkz
From: softworkz The key benefits are: - Different to other graph printing methods, this is outputting: - all graphs with runtime state (including auto-inserted filters) - each graph with its inputs and outputs - all filters with their in- and output pads - all connections between

[FFmpeg-devel] [PATCH v7 09/13] avfilter/avfilter: Add avfilter_link_get_hw_frames_ctx()

2025-04-25 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavfilter/avfilter.c | 9 + libavfilter/avfilter.h | 12 3 files changed, 24 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 75d66f87f3..d0869561f3 100644 --- a/doc

Re: [FFmpeg-devel] [PATCH v6 12/13] fftools/graphprint: Add execution graph printing

2025-04-25 Thread softworkz .
execution graph printing > > On Thu, Apr 24, 2025 at 01:13:10AM +0000, softworkz wrote: > > From: softworkz > > > > The key benefits are: > > > > - Different to other graph printing methods, this is outputting: > > - all graphs with runtime state > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
decode_str() did advance > > On Mon, Apr 14, 2025 at 11:59:02PM +, softworkz . wrote: > > > > > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of > > > Michael Niedermayer > > > Sent: Dienstag, 15. April 2025 01:20 > > &

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Dienstag, 15. April 2025 21:03 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that > decode_str() did advance > > Michael

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
tr() did advance > > On Tue, Apr 15, 2025 at 12:17:32AM +, softworkz . wrote: > > > > > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of > > > Ridley Combs via ffmpeg-devel > > > Sent: Dienstag, 15. April 2025 02:03 &g

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
decode_str() did advance > > Hi > > On Tue, Apr 15, 2025 at 01:37:56AM +, softworkz . wrote: > [...] > > > > do you have a test file perhaps? > > > > > > Will email you one, but the loop with a function that doesnt > advance > > > is an issue

[FFmpeg-devel] [PATCH 2/9] fftools/textformat: Quality improvements

2025-04-15 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 121 +++--- fftools/textformat/avtextformat.h | 6 +- fftools/textformat/tf_default.c | 8 +- fftools/textformat/tf_ini.c | 2 +- fftools/textformat/tf_json.c | 8

[FFmpeg-devel] [PATCH 5/9] fftools/ffmpeg_filter: Move some declaration to new header file

2025-04-15 Thread softworkz
From: softworkz to allow filtergraph printing to access the information. Signed-off-by: softworkz --- fftools/ffmpeg_filter.c | 190 +--- fftools/ffmpeg_filter.h | 234 2 files changed, 235 insertions(+), 189 deletions

Re: [FFmpeg-devel] SW's Patchsets Overview

2025-04-10 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 9. April 2025 00:25 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] SW's Patchsets Overview > > Hi > > On Sun, Apr 06,

Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()

2025-04-14 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Dienstag, 15. April 2025 03:00 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: > Simplify avtext_print_rationa

[FFmpeg-devel] [PATCH 3/3] tests/dict2: Add tests and benchmark for AVDictionary2

2025-04-12 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavutil/tests/dict2.c| 185 + tests/api/Makefile | 1 + tests/api/api-dict2-test.c | 122 +++ tests/fate/api.mak | 15 +++ tools/Makefile | 2 +- tools

[FFmpeg-devel] [PATCH 1/3] avutil/dict2: Add AVDictionary2 with hash-based lookup

2025-04-12 Thread softworkz
From: softworkz see doc/dict2.md Signed-off-by: softworkz --- libavutil/Makefile | 3 + libavutil/dict2.c | 335 libavutil/dict2.h | 167 ++ libavutil/version.h | 2 +- 4 files changed, 506 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH 2/3] doc/dict2: Add doc and api change for AVDictionary2

2025-04-12 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 3 +++ doc/dict2.md | 44 2 files changed, 47 insertions(+) create mode 100644 doc/dict2.md diff --git a/doc/APIchanges b/doc/APIchanges index 65bf5a9419..1e0d47083b 100644 --- a/doc

Re: [FFmpeg-devel] [PATCH v3] [NOT for git] avutil/tests/map: benchmark code [BENCHMARK included]

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Dienstag, 15. April 2025 22:51 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: [FFmpeg-devel] [PATCH v3] [NOT for git] avutil/tests/map: > benchmark code [BENCHMARK includ

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
decode_str() did advance > > On Tue, Apr 15, 2025 at 10:59:07PM +, softworkz . wrote: > > > > > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of > > > Michael Niedermayer > > > Sent: Mittwoch, 16. April 2025 00:50 > > &

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
decode_str() did advance > > On Tue, Apr 15, 2025 at 11:01:14PM +, softworkz . wrote: > [...] > > Besides, the patch had been submitted 3 years ago, there hasn't been > > any review and the merge was totally unexpected. > > no reply for 1 week means commit must b

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
decode_str() did advance > > On Wed, Apr 16, 2025 at 01:29:02AM +, softworkz . wrote: > [...] > > > > This will cause deserialization errors for many people in the > world > > > > who are processing FFprobe data. > > > > > > As said, ffprobe sho

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
decode_str() did advance > > On Tue, Apr 15, 2025 at 11:01:14PM +, softworkz . wrote: > [...] > > Besides, the patch had been submitted 3 years ago, there hasn't been > > any review and the merge was totally unexpected. > > no reply for 1 week means commit must b

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
tr() did advance > > On Wed, Apr 16, 2025 at 01:29:02AM +, softworkz . wrote: > [...] > > > > This will cause deserialization errors for many people in the > world > > > > who are processing FFprobe data. > > > > > > As said, ffprobe should

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
decode_str() did advance > > On Wed, Apr 16, 2025 at 01:29:02AM +, softworkz . wrote: > [...] > > > > This will cause deserialization errors for many people in the > world > > > > who are processing FFprobe data. > > > > > > As said, ffprobe sho

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
decode_str() did advance > > On Tue, Apr 15, 2025 at 07:59:00PM +, softworkz . wrote: > [...] > > > - The representation of multi-values - both, internally and when > > outputting as probe data - is a de-facto standard > > The external handling in formats is

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > softworkz . > Sent: Mittwoch, 16. April 2025 00:59 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/id3v2: Check that decode_str() did advance

2025-04-15 Thread softworkz .
decode_str() did advance > > softworkz . (HE12025-04-15): > > but it would be a breaking change > > Please elaborate. You are suggesting to change to an array [..] which breaks all usages. sw ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational()

2025-04-15 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Dienstag, 15. April 2025 10:36 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 01/12] > fftools/textformat/avtextformat: Simplify avtext_print_rati

Re: [FFmpeg-devel] [TC] "Future Log Output Default"

2025-04-26 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Samstag, 26. April 2025 17:10 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: [FFmpeg-devel] [TC] "Future Log Output Default" > > Hi all > > This is just an announcement

Re: [FFmpeg-devel] [PATCH v7 02/13] fftools/textformat: Apply quality improvements

2025-04-28 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Montag, 28. April 2025 22:24 > To: softworkz . > Cc: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v7 02/13] fftools/textformat: Apply quality > improvements > > On d

Re: [FFmpeg-devel] [PATCH v7 02/13] fftools/textformat: Apply quality improvements

2025-04-28 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Montag, 28. April 2025 21:56 > To: FFmpeg development discussions and patches > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH v7 02/13] fftools/textformat: Apply quality > improvements > > On date

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-04-29 Thread softworkz .
d. We might want to factorize a > > few generic utilities (e.g. escaping) to avoid code duplication > > though. > > You are going at it backwards. > > The goal is not to cram this text writers API forcefully into libavutil > and then see if it might serve other purpo

Re: [FFmpeg-devel] [PATCH v8 14/15] fftools/graphprint: Add execution graph printing

2025-04-29 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Michael > Niedermayer > Sent: Dienstag, 29. April 2025 21:35 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v8 14/15] fftools/graphprint: Add execution > graph print

[FFmpeg-devel] [PATCH v3] avformat/dump: Stream start offsets: change precision and label

2025-04-29 Thread softworkz
From: softworkz - Change precision to 6 digits to align with other printed times - Change label to just "Start" - Add 's' unit to format 'start' value for consistency Signed-off-by: softworkz --- avformat/dump: Change precision of stream start offsets

[FFmpeg-devel] SW's Patchsets Heads-Up

2025-04-29 Thread softworkz .
Hello everybody, here's a list of patches that I'm intending to apply by the end of the week (Fr/Sa) unless there would any more comments: avformat/dump: Change precision of stream start offsets GitHub:https://github.com/ffstaging/FFmpeg/pull/72 Patchwork: (seems broken today) avutil/o

[FFmpeg-devel] [PATCH v9 01/15] fftools/textformat: Formatting and whitespace changes

2025-05-03 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 92 +++--- fftools/textformat/avtextformat.h | 20 +++ fftools/textformat/avtextwriters.h | 11 ++-- fftools/textformat/tf_compact.c| 91

[FFmpeg-devel] [PATCH v9 07/15] fftools/textformat: Introduce common header and deduplicate code

2025-05-03 Thread softworkz
From: softworkz Also change writer_printf signature in AVTextWriter to use va_list, so that it can be called by the new function writer_printf() in tf_internal.h. Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextwriters.h | 2 +- fftools/textformat

[FFmpeg-devel] [PATCH v9 02/15] fftools/textformat: Apply quality improvements

2025-05-03 Thread softworkz
From: softworkz Perform multiple improvements to increase code robustness. In particular: - favor unsigned counters for loops - add missing checks - avoid possible leaks - move variable declarations to inner scopes when feasible - provide explicit type-casting when needed Signed-off-by

[FFmpeg-devel] [PATCH v9 06/15] fftools/textformat: Introduce AVTextFormatOptions for avtext_context_open()

2025-05-03 Thread softworkz
From: softworkz This allows future addition of options without changes to the signature of avtext_context_open(). Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/ffprobe.c | 13 + fftools/textformat/avtextformat.c | 21

[FFmpeg-devel] [PATCH v9 03/15] fftools/textformat: Remove unused print_rational() pointer from AVTextFormatter

2025-05-03 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/textformat/avtextformat.h | 1 - fftools/textformat/avtextwriters.h | 5 - 2 files changed, 6 deletions(-) diff --git a/fftools/textformat/avtextformat.h b/fftools/textformat/avtextformat.h index 86feb9d09d..c61dca159f 100644 --- a

[FFmpeg-devel] [PATCH v9 04/15] fftools/textformat: Rename name param to key for API consistency

2025-05-03 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 14 +++--- fftools/textformat/avtextformat.h | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c index

[FFmpeg-devel] [PATCH v9 05/15] fftools/avtextformat: Re-use BPrint in loop

2025-05-03 Thread softworkz
From: softworkz Instead of initializing a new BPrint in each iteration of the loop, re-use the same BPrint struct and just clear it for each iteration. Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions

[FFmpeg-devel] [PATCH v9 12/15] fftools/resources: Add resource manager files with build-time compression

2025-05-03 Thread softworkz
From: softworkz Compression requires zlib to be available, otherwise resources will be included uncompressed - in either case via BIN2C. It can also be disabled via ./configure --disable-resource-compression Size figures: graph.css 7752 graph.css.min 6655 (css is always minified

[FFmpeg-devel] [PATCH v9 09/15] fftools/textformat: Add flags param to function avtext_print_integer()

2025-05-03 Thread softworkz
From: softworkz Make this function work analog to avtext_print_string() which already has a flags parameter. Signed-off-by: softworkz --- fftools/ffprobe.c | 2 +- fftools/textformat/avtextformat.c | 24 ++-- fftools/textformat/avtextformat.h | 2 +- 3

[FFmpeg-devel] [PATCH v9 10/15] fftools/ffmpeg_filter: Move some declaration to new header file

2025-05-03 Thread softworkz
From: softworkz to allow filtergraph printing to access the information. Signed-off-by: softworkz --- fftools/ffmpeg_filter.c | 190 +--- fftools/ffmpeg_filter.h | 234 2 files changed, 235 insertions(+), 189 deletions

[FFmpeg-devel] [PATCH v9 11/15] avfilter/avfilter: Add avfilter_link_get_hw_frames_ctx()

2025-05-03 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavfilter/avfilter.c | 9 + libavfilter/avfilter.h | 12 3 files changed, 24 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 75d66f87f3..d0869561f3 100644 --- a/doc

[FFmpeg-devel] [PATCH v9 08/15] fftools/tf_internal: Use av_default_item_name

2025-05-03 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/tf_internal.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fftools/textformat/tf_internal.h b/fftools/textformat/tf_internal.h index 362a4cbc38..484886b7a7 100644 --- a

[FFmpeg-devel] [PATCH v9 14/15] fftools/graphprint: Add execution graph printing

2025-05-03 Thread softworkz
From: softworkz The key benefits are: - Different to other graph printing methods, this is outputting: - all graphs with runtime state (including auto-inserted filters) - each graph with its inputs and outputs - all filters with their in- and output pads - all connections between

[FFmpeg-devel] [PATCH v9 13/15] fftools/ffmpeg_mux: Make ms_from_ost() inline

2025-05-03 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/ffmpeg_mux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux.h b/fftools/ffmpeg_mux.h index f41f2c18fa..4ca8ab73a4 100644 --- a/fftools/ffmpeg_mux.h +++ b/fftools/ffmpeg_mux.h @@ -123,7 +123,7

[FFmpeg-devel] [PATCH v9 15/15] fftools/graphprint: Now, make it a Killer-Feature!

2025-05-03 Thread softworkz
From: softworkz remember this: -sg <= show-graph Signed-off-by: softworkz --- doc/ffmpeg.texi | 4 + fftools/Makefile | 1 + fftools/ffmpeg.c | 2 +- fftools/ffmpeg.h | 1 + fftools/ffmpeg_filter.c | 2 +- fftools/ffmpeg_op

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-05-03 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of softworkz . > Sent: Dienstag, 29. April 2025 01:24 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface > > > > > -Original

[FFmpeg-devel] When to add 'Reviewed-by: xxx' in commit messages

2025-05-03 Thread softworkz .
Hello everybody, I have an organizational question that I cannot quite figure out how to do it right: Whether and when to add 'Reviewed-by: xxx' to a commit message? Specific example: The “execution graph printing” patchset: Andreas had reviewed the patchset initially. I addressed the mention

Re: [FFmpeg-devel] [PATCH v8 14/15] fftools/graphprint: Add execution graph printing

2025-05-02 Thread softworkz .
> On Tue, Apr 29, 2025 at 08:33:50PM +, softworkz . wrote: > > > > > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of Michael > > > Niedermayer > > > Sent: Dienstag, 29. April 2025 21:35 > > > To: FFmpeg de

[FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting and whitespace changes

2025-05-03 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 92 +++--- fftools/textformat/avtextformat.h | 20 +++ fftools/textformat/avtextwriters.h | 11 ++-- fftools/textformat/tf_compact.c| 91

[FFmpeg-devel] [PATCH v10 03/15] fftools/textformat: Remove unused print_rational() pointer from AVTextFormatter

2025-05-03 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/textformat/avtextformat.h | 1 - fftools/textformat/avtextwriters.h | 5 - 2 files changed, 6 deletions(-) diff --git a/fftools/textformat/avtextformat.h b/fftools/textformat/avtextformat.h index 86feb9d09d..c61dca159f 100644 --- a

[FFmpeg-devel] [PATCH v10 02/15] fftools/textformat: Apply quality improvements

2025-05-03 Thread softworkz
From: softworkz Perform multiple improvements to increase code robustness. In particular: - favor unsigned counters for loops - add missing checks - avoid possible leaks - move variable declarations to inner scopes when feasible - provide explicit type-casting when needed Signed-off-by

Re: [FFmpeg-devel] [PATCH v9 14/15] fftools/graphprint: Add execution graph printing

2025-05-03 Thread softworkz .
; > Hi > > On Sat, May 03, 2025 at 08:22:44AM +, softworkz wrote: > > From: softworkz > > > > The key benefits are: > > > > - Different to other graph printing methods, this is outputting: > > - all graphs with runtime state > > (incl

[FFmpeg-devel] [PATCH v10 07/15] fftools/textformat: Introduce common header and deduplicate code

2025-05-03 Thread softworkz
From: softworkz Also change writer_printf signature in AVTextWriter to use va_list, so that it can be called by the new function writer_printf() in tf_internal.h. Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextwriters.h | 2 +- fftools/textformat

[FFmpeg-devel] [PATCH v10 10/15] fftools/ffmpeg_filter: Move some declaration to new header file

2025-05-03 Thread softworkz
From: softworkz to allow filtergraph printing to access the information. Signed-off-by: softworkz --- fftools/ffmpeg_filter.c | 190 +--- fftools/ffmpeg_filter.h | 234 2 files changed, 235 insertions(+), 189 deletions

[FFmpeg-devel] [PATCH v10 06/15] fftools/textformat: Introduce AVTextFormatOptions for avtext_context_open()

2025-05-03 Thread softworkz
From: softworkz This allows future addition of options without changes to the signature of avtext_context_open(). Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/ffprobe.c | 13 + fftools/textformat/avtextformat.c | 21

[FFmpeg-devel] [PATCH v10 08/15] fftools/tf_internal: Use av_default_item_name

2025-05-03 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/tf_internal.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fftools/textformat/tf_internal.h b/fftools/textformat/tf_internal.h index 362a4cbc38..484886b7a7 100644 --- a

[FFmpeg-devel] [PATCH v10 09/15] fftools/textformat: Add flags param to function avtext_print_integer()

2025-05-03 Thread softworkz
From: softworkz Make this function work analog to avtext_print_string() which already has a flags parameter. Signed-off-by: softworkz --- fftools/ffprobe.c | 2 +- fftools/textformat/avtextformat.c | 24 ++-- fftools/textformat/avtextformat.h | 2 +- 3

[FFmpeg-devel] [PATCH v10 04/15] fftools/textformat: Rename name param to key for API consistency

2025-05-03 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 14 +++--- fftools/textformat/avtextformat.h | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c index

[FFmpeg-devel] [PATCH v10 11/15] avfilter/avfilter: Add avfilter_link_get_hw_frames_ctx()

2025-05-03 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavfilter/avfilter.c | 9 + libavfilter/avfilter.h | 12 3 files changed, 24 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 75d66f87f3..d0869561f3 100644 --- a/doc

[FFmpeg-devel] [PATCH v10 05/15] fftools/avtextformat: Re-use BPrint in loop

2025-05-03 Thread softworkz
From: softworkz Instead of initializing a new BPrint in each iteration of the loop, re-use the same BPrint struct and just clear it for each iteration. Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions

[FFmpeg-devel] [PATCH v10 14/15] fftools/graphprint: Add execution graph printing

2025-05-03 Thread softworkz
From: softworkz The key benefits are: - Different to other graph printing methods, this is outputting: - all graphs with runtime state (including auto-inserted filters) - each graph with its inputs and outputs - all filters with their in- and output pads - all connections between

[FFmpeg-devel] [PATCH v10 12/15] fftools/resources: Add resource manager files with build-time compression

2025-05-03 Thread softworkz
From: softworkz Compression requires zlib to be available, otherwise resources will be included uncompressed - in either case via BIN2C. It can also be disabled via ./configure --disable-resource-compression Size figures: graph.css 7752 graph.css.min 6655 (css is always minified

[FFmpeg-devel] [PATCH v10 15/15] fftools/graphprint: Now, make it a Killer-Feature!

2025-05-03 Thread softworkz
From: softworkz remember this: -sg <= means Show Graph Signed-off-by: softworkz --- doc/ffmpeg.texi | 4 + fftools/Makefile | 1 + fftools/ffmpeg.c | 2 +- fftools/ffmpeg.h | 1 + fftools/ffmpeg_filter.c | 2 +- ffto

[FFmpeg-devel] [PATCH v10 13/15] fftools/ffmpeg_mux: Make ms_from_ost() inline

2025-05-03 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/ffmpeg_mux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux.h b/fftools/ffmpeg_mux.h index f41f2c18fa..4ca8ab73a4 100644 --- a/fftools/ffmpeg_mux.h +++ b/fftools/ffmpeg_mux.h @@ -123,7 +123,7

Re: [FFmpeg-devel] [PATCH 2/3] doc/dict2: Add doc and api change for AVDictionary2

2025-04-19 Thread softworkz .
or AVDictionary2 > > Hi > > On Thu, Apr 17, 2025 at 10:38:32PM +, softworkz . wrote: > > > > > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of > [...] > > > the LLM would probably mix and confuse things and hallucin

Re: [FFmpeg-devel] [PATCH v3 0/2] Improve HWDeviceContext logging

2025-04-19 Thread softworkz .
> -Original Message- > From: ffmpegagent > Sent: Samstag, 19. April 2025 16:43 > To: ffmpeg-devel@ffmpeg.org > Cc: softworkz > Subject: [PATCH v3 0/2] Improve HWDeviceContext logging > > This changeset > > * adds an av class category for hw device co

[FFmpeg-devel] [PATCH v3 09/11] fftools/ffmpeg_mux: Make ms_from_ost() inline

2025-04-18 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/ffmpeg_mux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux.h b/fftools/ffmpeg_mux.h index f41f2c18fa..4ca8ab73a4 100644 --- a/fftools/ffmpeg_mux.h +++ b/fftools/ffmpeg_mux.h @@ -123,7 +123,7

Re: [FFmpeg-devel] [PATCH v3] fftools/ffprobe: Print size of attachments

2025-04-21 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Montag, 21. April 2025 18:14 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH v3] fftools/ffprobe: Print size of > attachments >

Re: [FFmpeg-devel] [PATCH 1/9] fftools/textformat: Formatting and whitespace changes

2025-04-21 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Montag, 21. April 2025 18:53 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH 1/9] fftools/textformat: Formatting > and whitespace cha

Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality improvements

2025-04-21 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Montag, 21. April 2025 19:17 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: > Quality improvements >

Re: [FFmpeg-devel] [PATCH v4 03/11] fftools/textformat: Introduce common header and deduplicate code

2025-04-21 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Montag, 21. April 2025 19:29 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH v4 03/11] fftools/textformat: > Introduce common hea

Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality improvements

2025-04-21 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Montag, 21. April 2025 19:21 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: > Quality improvements > > Stefano Sabatin

[FFmpeg-devel] [PATCH v3 1/2] avutil/log, hwcontext: Add AV_CLASS_CATEGORY_HWDEVICE

2025-04-19 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges| 3 +++ libavutil/hwcontext.c | 1 + libavutil/log.c | 1 + libavutil/log.h | 1 + libavutil/version.h | 2 +- 5 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index

[FFmpeg-devel] [PATCH v3 2/2] avutil/hwcontext: Add item_name function for AVHWDeviceContext

2025-04-19 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavutil/hwcontext.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext.c b/libavutil/hwcontext.c index 276dc9cee6..3111a44651 100644 --- a/libavutil/hwcontext.c +++ b/libavutil/hwcontext.c @@ -137,9

Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets

2025-04-21 Thread softworkz .
rt offsets > > > > On Mon, 21 Apr 2025, softworkz . wrote: > > > > > > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > >> Marton Balint > >> Sent: Montag, 21. April 2025 21:32 > >> To: FFmpeg development

Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets

2025-04-21 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Gyan > Doshi > Sent: Montag, 21. April 2025 06:51 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of > stream start offsets > > > > On 202

Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets

2025-04-21 Thread softworkz .
rt offsets > > > > On Mon, 21 Apr 2025, softworkz . wrote: > > > > > > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > Gyan > >> Doshi > >> Sent: Montag, 21. April 2025 06:51 > >> To: ffmpeg-devel@f

[FFmpeg-devel] [PATCH] [RFC] global/clang-format: Add .clang-format configuration for consistent formatting

2025-04-21 Thread softworkz
From: softworkz This is an attempt to create and establish a common definition for code formatting. Besides .clang-format, there don't seem to be many good candidates for C when looking for non-proprietary open-source solutions, so there's wasn't really much choice. I have tri

<    1   2   3   4   5   6   7   8   9   10   >