Hello everybody, I have an organizational question that I cannot quite figure out how to do it right:
Whether and when to add 'Reviewed-by: xxx' to a commit message? Specific example: The “execution graph printing” patchset: Andreas had reviewed the patchset initially. I addressed the mentioned issues. Is that the point to add 'Reviewed-by:’ already? And what about the commits without comments? Should I assume them to be reviewed as well? And how about later changes, do they invalidate it? From Stefano, I believe that he didn’t review the last two commits (due to being outside of the text formatting scope, I suppose). I added him as “reviewed by” only to those where he said “should be ok” or similar. Andreas didn’t say anything like that, yet I’m sure that he has carefully looked over everything. It might not be a big thing after all, but I don't want to be unjust to anybody and I'm unsure how to handle this, because I can imagine that someone might either say "Hey, why is he mentioning me, that's not the version that I have reviewed!" but also "Why doesn't he mention me, I've reviewed the whole thing in detail?". That's the circle by which I got trapped at the moment. 😉 I'd be glad if somebody could provide me some guidance in this regard. Thanks a lot, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
