Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

On Thu, Sep 23, 2021 at 09:45:48AM -0400, Christopher Degawa wrote: > On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa > wrote: > > > > > > > On Fri, Sep 17, 2021 at 9:28 PM wrote: > > > >> From: Limin Wang > >> > >> Signed-off-by: Limin Wang > >> > > As a note, I personally favor this patch

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/libsvtav1: Fix override setting of caps_internal

On Sat, Sep 25, 2021 at 01:00:20PM +0300, Jan Ekström wrote: > On Sat, Sep 18, 2021 at 4:27 AM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > I'd prefer the wording "fix duplicate definition of caps_internal", > but otherwise this patch is LGTM. No problem, will update w

Re: [FFmpeg-devel] [PATCH v2 3/6] doc: update for libsvtav1 encoder

On Sat, Sep 25, 2021 at 02:32:43PM +0300, Jan Ekström wrote: > On Sat, Sep 18, 2021 at 4:27 AM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > Hi, > > "doc/encoders: add available values for libsvtav1 options" > > would possibly be better as a commit message? Su

Re: [FFmpeg-devel] [PATCH v2 4/6] avcodec/libsvtav1: Fix CQP mode doesn't work as expection

On Sat, Sep 25, 2021 at 03:06:23PM +0300, Jan Ekström wrote: > On Sat, Sep 18, 2021 at 4:27 AM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > Commit message should probably be something along the lines of > > """ > avcodec/libsvtav1: properly enforce CQP mode whe

Re: [FFmpeg-devel] [PATCH v2 5/6] avcodec/libsvtav1: Fix the max range for rc_mode

On Sat, Sep 25, 2021 at 03:14:34PM +0300, Jan Ekström wrote: > On Sat, Sep 18, 2021 at 4:27 AM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > Probably something like "avcodec/libsvtav1: fix value range for > rc_mode" is a bit better as a commit message? OK, will

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/libsvtav1: Fix override setting of caps_internal

On Sat, Sep 25, 2021 at 03:59:20PM +0300, Jan Ekström wrote: > On Sat, Sep 25, 2021 at 3:49 PM wrote: > > > > On Sat, Sep 25, 2021 at 01:00:20PM +0300, Jan Ekström wrote: > > > On Sat, Sep 18, 2021 at 4:27 AM wrote: > > > > > > > > From: Limin Wang > > > > > > > > Signed-off-by: Limin Wang > >

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

On Sat, Sep 25, 2021 at 03:35:53PM +0300, Jan Ekström wrote: > On Thu, Sep 23, 2021 at 6:08 PM wrote: > > > > On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote: > > > On Thu, Sep 23, 2021 at 4:46 PM Christopher Degawa > > > wrote: > > > > > > > > On Sun, Sep 19, 2021 at 2:02 PM Christo

[FFmpeg-devel] [PATCH v3 1/2] doc/encoders: add available values for libsvtav1 options

From: Limin Wang Signed-off-by: Limin Wang --- doc/encoders.texi | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 8fccd73..8a7589c 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1750,12 +1750,30 @@ Y

[FFmpeg-devel] [PATCH v3 2/2] avcodec/libsvtav1: properly enforce CQP mode when set in wrapper

From: Limin Wang SVT-AV1 seems to have switched their default from CQP to CRF in February, so enforce the controlling option accordingly. Signed-off-by: Limin Wang --- libavcodec/libsvtav1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c ind

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

On Sat, Sep 25, 2021 at 04:51:58PM +0300, Jan Ekström wrote: > On Sat, Sep 25, 2021 at 4:35 PM wrote: > > > > On Sat, Sep 25, 2021 at 03:35:53PM +0300, Jan Ekström wrote: > > > On Thu, Sep 23, 2021 at 6:08 PM wrote: > > > > > > > > On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote: > >

Re: [FFmpeg-devel] [PATCH 2/5] avfilter/vf_codecview: added new options for block

On Tue, Sep 21, 2021 at 12:32:02PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/filters.texi | 3 +++ > libavfilter/version.h | 2 +- > libavfilter/vf_codecview.c | 35 +++ > 3 files changed, 3

[FFmpeg-devel] [PATCH 1/4] avutil/detection_bbox: fix the memory leak on error

From: Limin Wang Signed-off-by: Limin Wang --- libavutil/detection_bbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/detection_bbox.c b/libavutil/detection_bbox.c index 40711e6..d066567 100644 --- a/libavutil/detection_bbox.c +++ b/libavutil/detection_bbox.c @@ -61,6 +61,7 @@

[FFmpeg-devel] [PATCH 2/4] avutil/detection_bbox: use offsetof for bboxes_offset

From: Limin Wang Signed-off-by: Limin Wang --- libavutil/detection_bbox.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavutil/detection_bbox.c b/libavutil/detection_bbox.c index d066567..8bfdff7 100644 --- a/libavutil/detection_bbox.c +++ b/libavutil/detection_bbo

[FFmpeg-devel] [PATCH 3/4] avutil/detection_bbox: simplify code for better readability

From: Limin Wang Signed-off-by: Limin Wang --- libavutil/detection_bbox.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/libavutil/detection_bbox.c b/libavutil/detection_bbox.c index 8bfdff7..3de66ce 100644 --- a/libavutil/detection_bbox.c +++ b/l

[FFmpeg-devel] [PATCH 4/4] avcodec/hevcdec: set the film grain property if present

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevcdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 57a6175..b4edb3b 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -385,6 +385,9 @@ static int export_stream

Re: [FFmpeg-devel] [PATCH 1/4] avutil/detection_bbox: fix the memory leak on error

On Tue, Sep 28, 2021 at 03:45:03PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavutil/detection_bbox.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavutil/detection_bbox.c b/libavutil/dete

Re: [FFmpeg-devel] [PATCH 3/4] avutil/detection_bbox: simplify code for better readability

On Tue, Sep 28, 2021 at 03:57:27PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavutil/detection_bbox.c | 24 +--- > > 1 file changed, 13 insertions(+), 11 deletions(-) > > > > diff --git a/

[FFmpeg-devel] [PATCH 1/5] avfilter/vf_showinfo: minor adjustment for the dump format of ROI

From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_showinfo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 87c2bed..5d97ef6 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@

[FFmpeg-devel] [PATCH 2/5] avfilter/vf_addroi: realloc the buf and append new ROI

From: Limin Wang It is simpler and more efficient compared to the current code. Signed-off-by: Limin Wang --- libavfilter/vf_addroi.c | 98 +++-- 1 file changed, 37 insertions(+), 61 deletions(-) diff --git a/libavfilter/vf_addroi.c b/libavfilter/vf

[FFmpeg-devel] [PATCH 3/5] avformat/libsrt: use strtoll/strtol for int64_t/int

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/libsrt.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index a80f249..5aef0e7 100644 --- a/libavformat/libsrt.c +++ b/libavformat/libsrt.c @@ -397,10 +39

[FFmpeg-devel] [PATCH 4/5] avformat/libsrt: specify base of maxbw string to 10 instead of auto-detect

From: Limin Wang Make all options string conversion consistent. Signed-off-by: Limin Wang --- libavformat/libsrt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index 5aef0e7..c6308d1 100644 --- a/libavformat/libsrt.c +++ b/liba

[FFmpeg-devel] [PATCH 5/5] avformat/libsrt: add snddropdelay parameter for srt

From: Limin Wang Signed-off-by: Limin Wang --- doc/protocols.texi | 10 ++ libavformat/libsrt.c | 7 +++ 2 files changed, 17 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index 726e5f1..9c246f8 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -149

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/vf_showinfo: minor adjustment for the dump format of ROI

On Thu, Sep 30, 2021 at 03:19:39AM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_showinfo.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavfilter/vf_showinfo.

Re: [FFmpeg-devel] [PATCH 2/5] avfilter/vf_addroi: realloc the buf and append new ROI

On Thu, Sep 30, 2021 at 04:58:07AM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > It is simpler and more efficient compared to the current code. > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_addroi.c | 98 > > +++-

[FFmpeg-devel] [PATCH 1/8] avcodec/bitpacked: check av_buffer_ref result

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/bitpacked.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/bitpacked.c b/libavcodec/bitpacked.c index 8143151..0440df9 100644 --- a/libavcodec/bitpacked.c +++ b/libavcodec/bitpacked.c @@ -45,6 +45,10 @@ static int bit

[FFmpeg-devel] [PATCH 2/8] avformat/rtpdec_rfc4175: use av_get_bits_per_pixel()

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index 4daff4d..e1e1452 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/r

[FFmpeg-devel] [PATCH 3/8] avformat/rtpdec_rfc4175: Remove redundant initialization

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index e1e1452..97939b0 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtpd

[FFmpeg-devel] [PATCH 4/8] avformat/rtpdec_rfc4175: return the proper value

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index 97939b0..46d30ed 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtpdec_r

[FFmpeg-devel] [PATCH 5/8] avformat/rtpdec_rfc4175: add support for exactframerate

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index 46d30ed..367567d 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtpdec_r

[FFmpeg-devel] [PATCH 6/8] avformat/rtpdec_rfc4175: add support for TCS

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index 367567d..db6b9b8 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtp

[FFmpeg-devel] [PATCH 7/8] avformat/rtpdec_rfc4175: add support for colorimetry

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index db6b9b8..23a3f4f 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtpd

[FFmpeg-devel] [PATCH 8/8] avformat/rtpdec_rfc4175: add support for RANGE

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index 23a3f4f..86ffb38 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtpdec_rfc4

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/hevcdec: set the film grain property if present

On Tue, Sep 28, 2021 at 09:36:38PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/hevcdec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c > index 57a6175..b4edb3b 100644 > --- a/

[FFmpeg-devel] [PATCH 1/4] avcodec/audiotoolboxdec: Fix usage of init_get_bits() and use init_get_bits8()

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/audiotoolboxdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c index a222cde..9939fef 100644 --- a/libavcodec/audiotoolboxdec.c +++ b/libavcodec/audiotool

[FFmpeg-devel] [PATCH 2/4] avcodec/avs3_parser: Fix usage of init_get_bits() and use init_get_bits8()

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/avs3_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avs3_parser.c b/libavcodec/avs3_parser.c index 1a05ea0..d04d96a 100644 --- a/libavcodec/avs3_parser.c +++ b/libavcodec/avs3_parser.c @@ -73,7 +7

[FFmpeg-devel] [PATCH 3/4] avcodec/mpeg12dec: Fix usage of init_get_bits() and use init_get_bits8()

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpeg12dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index e6ada1c..09b2902 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -2265,7 +2265,7 @@

[FFmpeg-devel] [PATCH 4/4] avcodec/videotoolboxenc: use goto end for memory cleanup

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/videotoolboxenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 93c3898..bac36fd 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotool

Re: [FFmpeg-devel] [PATCH 5/5] avformat/libsrt: add snddropdelay parameter for srt

On Thu, Sep 30, 2021 at 09:14:00AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/protocols.texi | 10 ++ > libavformat/libsrt.c | 7 +++ > 2 files changed, 17 insertions(+) > > diff --git a/doc/protocols.texi b/doc/protocols.te

Re: [FFmpeg-devel] [PATCH 5/5] avformat/libsrt: add snddropdelay parameter for srt

On Sun, Oct 10, 2021 at 01:22:49AM +0800, "zhilizhao(赵志立)" wrote: > > > > On Sep 30, 2021, at 9:14 AM, lance.lmw...@gmail.com wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/protocols.texi | 10 ++ > > libavformat/libsrt.c | 7 +++ > > 2 files ch

[FFmpeg-devel] [PATCH v2] avformat/libsrt: add snddropdelay parameter for srt

From: Limin Wang Signed-off-by: Limin Wang --- doc/protocols.texi | 9 + libavformat/libsrt.c | 7 +++ 2 files changed, 16 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index 726e5f1..7951abb 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -1496,6

Re: [FFmpeg-devel] [PATCH v2] avformat/libsrt: add snddropdelay parameter for srt

On Sun, Oct 10, 2021 at 09:46:26PM +0800, "zhilizhao(赵志立)" wrote: > > > > On Oct 10, 2021, at 11:17 AM, lance.lmw...@gmail.com wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/protocols.texi | 9 + > > libavformat/libsrt.c | 7 +++ > > 2 files chan

[FFmpeg-devel] [PATCH v3] avformat/libsrt: add snddropdelay parameter for srt

From: Limin Wang Signed-off-by: Limin Wang --- doc/protocols.texi | 6 ++ libavformat/libsrt.c | 7 +++ 2 files changed, 13 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index 726e5f1..c100f23 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -1496,6 +1

[FFmpeg-devel] [PATCH 1/8] avformat: add raw avs3 muxer

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/rawenc.c | 14 ++ 3 files changed, 16 insertions(+) diff --git a/libavformat/Makefile b/libavformat/Makefile index c45caa3..66ebea5 100644 --- a/libavfor

[FFmpeg-devel] [PATCH 2/8] avcodec/extract_extradata_bsf: add support for AVS3

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/extract_extradata_bsf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/extract_extradata_bsf.c b/libavcodec/extract_extradata_bsf.c index 32c732f..dbcb850 100644 --- a/libavcodec/extract_extradata_bsf.c +++ b/libavcode

[FFmpeg-devel] [PATCH 3/8] avformat/mpegts: add support for stream_type 0xd2, which is AVS2

From: Limin Wang GB/T 17975.1 Information technology-Generic coding of moving pictures and associated audio information-Part 1:Systems Signed-off-by: Limin Wang --- libavformat/mpegts.h| 1 + libavformat/mpegtsenc.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/libavformat/mpegts

[FFmpeg-devel] [PATCH 4/8] avformat/mpegts: add support for stream_type 0xd4, which is AVS3

From: Limin Wang GB/T 17975.1 Information technology-Generic coding of moving pictures and associated audio information-Part 1:Systems Signed-off-by: Limin Wang --- libavformat/mpegts.c| 1 + libavformat/mpegts.h| 1 + libavformat/mpegtsenc.c | 3 +++ 3 files changed, 5 insertions(+)

[FFmpeg-devel] [PATCH 5/8] avformat/mpegtsenc: add AVSV format_identifier for AVS standard

From: Limin Wang Listing of Registered Identifiers: https://smpte-ra.org/registered-mpeg-ts-ids Signed-off-by: Limin Wang --- libavformat/mpegtsenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 26fb1f1..184bb52 100644 --- a/lib

[FFmpeg-devel] [PATCH 6/8] avcodec/hevcdec: remove unused code

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevcdec.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/hevcdec.h b/libavcodec/hevcdec.h index 482638a..2855342 100644 --- a/libavcodec/hevcdec.h +++ b/libavcodec/hevcdec.h @@ -45,9 +45,6 @@ #define SHIFT_CTB_WPP 2

[FFmpeg-devel] [PATCH 7/8] avcodec/hevc_filter: remove unneeded headers

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevc_filter.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/hevc_filter.c b/libavcodec/hevc_filter.c index 6b98240..7e9478c 100644 --- a/libavcodec/hevc_filter.c +++ b/libavcodec/hevc_filter.c @@ -25,11 +25,8 @@ #incl

[FFmpeg-devel] [PATCH 8/8] avcodec/hevc_filter: Correct indention

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevc_filter.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/hevc_filter.c b/libavcodec/hevc_filter.c index 7e9478c..3c45b5a 100644 --- a/libavcodec/hevc_filter.c +++ b/libavcode

Re: [FFmpeg-devel] [PATCH 8/8] avformat/rtpdec_rfc4175: add support for RANGE

On Wed, Oct 06, 2021 at 06:14:11PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/rtpdec_rfc4175.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c > inde

Re: [FFmpeg-devel] [PATCH 5/8] avformat/rtpdec_rfc4175: add support for exactframerate

On Mon, Oct 11, 2021 at 05:00:29PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/rtpdec_rfc4175.c | 14 ++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/libavformat/rtpdec_rfc417

Re: [FFmpeg-devel] [PATCH 6/8] avformat/rtpdec_rfc4175: add support for TCS

On Mon, Oct 11, 2021 at 05:01:54PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/rtpdec_rfc4175.c | 19 +++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/libavformat/rtpdec_r

[FFmpeg-devel] [PATCH v2 1/4] avformat/rtpdec_rfc4175: add support for exactframerate

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index 712c683..060f725 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtpdec_rfc4

[FFmpeg-devel] [PATCH v2 2/4] avformat/rtpdec_rfc4175: add support for TCS

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index 060f725..d45530e 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtpdec_rf

[FFmpeg-devel] [PATCH v2 3/4] avformat/rtpdec_rfc4175: add support for colorimetry

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index d45530e..93607d7 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtpdec_rfc4

[FFmpeg-devel] [PATCH v2 4/4] avformat/rtpdec_rfc4175: add support for RANGE

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index 93607d7..f50cad7 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtpdec_rfc4175.c @@

[FFmpeg-devel] [PATCH 1/8] avfilter/af_replaygain: use fabsf() instead of fabs()

From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/af_replaygain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_replaygain.c b/libavfilter/af_replaygain.c index 4bf2763..da5c196 100644 --- a/libavfilter/af_replaygain.c +++ b/libavfilter/af_repla

[FFmpeg-devel] [PATCH 2/8] avfilter/vf_showinfo: small adjustments for the HDR10+ dump

From: Limin Wang summary for the adjustments: 1, remove the extra "," in the ,} ...{0.2004,0.3001,0.4008,0.5005,0.6002,0.7009,0.8006,0.9013,} to ...{0.2004,0.3001,0.4008,0.5005,0.6002,0.7009,0.8006,0.9013} 2, add "," between the } and new field } fraction_bright_pixels to }, fraction_bright_pixe

[FFmpeg-devel] [PATCH 3/8] avcodec/hevc_sei: remove the duplicate check

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevc_sei.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c index 29d0346..7fd8226 100644 --- a/libavcodec/hevc_sei.c +++ b/libavcodec/hevc_sei.c @@ -181,9 +181,6 @@ static int decode_r

[FFmpeg-devel] [PATCH 4/8] avcodec/atsc_a53: use AVERROR_INVALIDDATA

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/atsc_a53.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/atsc_a53.c b/libavcodec/atsc_a53.c index 2d89ef5..29ec71b 100644 --- a/libavcodec/atsc_a53.c +++ b/libavcodec/atsc_a53.c @@ -73,7 +73,7 @@ in

[FFmpeg-devel] [PATCH 5/8] avformat/mov: support dvwC box for Dolby Vision

From: Limin Wang By <> Signed-off-by: Limin Wang --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 57c67e3..49a8c27 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -7074,7 +7074,7 @@ static int mov_

[FFmpeg-devel] [PATCH 6/8] avformat/movenc: support dvwC box for Dolby Vision

From: Limin Wang By <> Signed-off-by: Limin Wang --- libavformat/movenc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index d43a086..37d4403 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1912,7 +1912,9

[FFmpeg-devel] [PATCH 7/8] avformat/mpegts: Fix for the DOVI video stream descriptor

From: Limin Wang By <> Signed-off-by: Limin Wang --- libavformat/mpegts.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 44d9298..774964d 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -2178,6 +

[FFmpeg-devel] [PATCH 8/8] avformat/mpegts: return proper error codes

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegts.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 774964d..3157e3a 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -2270,22 +2270,

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegts: Fix for the DOVI video stream descriptor

On Thu, Oct 14, 2021 at 09:18:16AM -0400, f tcChlisop0 wrote: > On Thu, Oct 14, 2021 at 9:10 AM wrote: > > > From: Limin Wang > > > > By <> > > > > Signed-off-by: Limin Wang > > --- > > libavformat/mpegts.c | 11 +-- > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > diff --gi

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegts: Fix for the DOVI video stream descriptor

On Thu, Oct 14, 2021 at 09:45:45AM -0400, quietvoid wrote: > On Thu, Oct 14, 2021 at 9:36 AM wrote: > > > On Thu, Oct 14, 2021 at 09:18:16AM -0400, f tcChlisop0 wrote: > > > On Thu, Oct 14, 2021 at 9:10 AM wrote: > > > > > > > From: Limin Wang > > > > > > > > By < > v1.2>> > > > > > > > > Signe

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegts: Fix for the DOVI video stream descriptor

On Thu, Oct 14, 2021 at 10:12:05AM -0400, quietvoid wrote: > On Thu, Oct 14, 2021 at 9:52 AM wrote: > > > On Thu, Oct 14, 2021 at 09:45:45AM -0400, quietvoid wrote: > > > On Thu, Oct 14, 2021 at 9:36 AM wrote: > > > > > > > On Thu, Oct 14, 2021 at 09:18:16AM -0400, f tcChlisop0 wrote: > > > > >

Re: [FFmpeg-devel] [PATCH 8/8] avformat/mpegts: return proper error codes

On Thu, Oct 14, 2021 at 09:46:37PM +0200, Marton Balint wrote: > > > On Thu, 14 Oct 2021, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/mpegts.c | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > No, pars

Re: [FFmpeg-devel] [PATCH 5/8] avformat/mov: support dvwC box for Dolby Vision

On Fri, Oct 15, 2021 at 04:40:26PM +0800, myp...@gmail.com wrote: > On Thu, Oct 14, 2021 at 9:10 PM wrote: > > > > From: Limin Wang > > > > By < > 2.2>> > > > > Signed-off-by: Limin Wang > > --- > > libavformat/mov.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH 1/8] avfilter/af_replaygain: use fabsf() instead of fabs()

On Sat, Oct 16, 2021 at 10:06:35AM -0300, James Almer wrote: > On 10/14/2021 10:08 AM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/af_replaygain.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] libavformat/rtpdec_mpeg: handle bare ADTS packets with explicit decoder config

On Fri, Oct 01, 2021 at 06:53:23PM -0400, Jeff Mahoney wrote: > When SDP specifies a decoder config, there may not be any AU headers > provided by the sender. This can result in rtp_parse_mp4_au failing > and aac_parse_packet reporting "Error parsing AU headers." and no audio > is recovered from t

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavcodec/libx264: add user data unregistered SEI encoding

On Tue, Oct 19, 2021 at 12:05:19AM +0200, Michael Niedermayer wrote: > Hi > > On Mon, Oct 18, 2021 at 12:15:11PM +, Brad Hards wrote: > > ffmpeg | branch: master | Brad Hards | Fri Aug 6 > > 19:16:33 2021 +1000| [7c08cad280a16b346c0a5e0efdfd8333ec54f095] | > > committer: Derek Buitenhuis >

[FFmpeg-devel] [PATCH 1/2] configure: add hls demuxer link dependencies

From: Limin Wang Fixes building with --disable-everything --enable-demuxer=hls Signed-off-by: Limin Wang --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 92610c7..0fe3937 100755 --- a/configure +++ b/configure @@ -3363,6 +3363,7 @@ flac_demuxer_sele

[FFmpeg-devel] [PATCH 2/2] avutil/hwcontext_videotoolbox: fix use of unknown builtin '__builtin_available'

From: Limin Wang OSX version: 10.11.6 Apple LLVM version 8.0.0 (clang-800.0.42.1) Target: x86_64-apple-darwin15.6.0 Signed-off-by: Limin Wang --- libavutil/hwcontext_videotoolbox.c | 12 1 file changed, 12 insertions(+) diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil

Re: [FFmpeg-devel] [PATCH v2] libavformat/rtpdec_mpeg: handle bare ADTS packets with explicit decoder config

On Tue, Oct 19, 2021 at 05:02:44PM -0400, Jeff Mahoney wrote: The title should be "avformat/rtpdec_mpeg4: ..." > When SDP specifies a decoder config, there may not be any AU headers > provided by the sender. This can result in rtp_parse_mp4_au failing > and aac_parse_packet reporting "Error par

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegts: Fix for the DOVI video stream descriptor

On Thu, Oct 14, 2021 at 09:09:01PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > By <> > > Signed-off-by: Limin Wang > --- > libavformat/mpegts.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c > in

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegts: Fix for the DOVI video stream descriptor

On Wed, Oct 27, 2021 at 11:50:04AM +0300, Jan Ekström wrote: > On Thu, Oct 14, 2021 at 5:31 PM wrote: > > > > On Thu, Oct 14, 2021 at 10:12:05AM -0400, quietvoid wrote: > > > On Thu, Oct 14, 2021 at 9:52 AM wrote: > > > > > > > On Thu, Oct 14, 2021 at 09:45:45AM -0400, quietvoid wrote: > > > > >

[FFmpeg-devel] [PATCH 1/2] avutil/parseutils: add qhd(Quad HD) or wqhd(Wide Quad HD) for 1440p

From: Limin Wang Signed-off-by: Limin Wang --- libavutil/parseutils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/parseutils.c b/libavutil/parseutils.c index 7f678cd..19bbdde 100644 --- a/libavutil/parseutils.c +++ b/libavutil/parseutils.c @@ -102,6 +102,7 @@ static const Vi

[FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Fix comparing double with 0

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 06bbf36..94e77c7 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -551,7 +551,7 @@ static

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegts: Fix for the DOVI video stream descriptor

On Wed, Oct 27, 2021 at 10:54:31AM -0400, quietvoid wrote: > On Wed, Oct 27, 2021 at 10:26 AM wrote: > > > On Wed, Oct 27, 2021 at 11:50:04AM +0300, Jan Ekström wrote: > > > On Thu, Oct 14, 2021 at 5:31 PM wrote: > > > > > > > > On Thu, Oct 14, 2021 at 10:12:05AM -0400, quietvoid wrote: > > > >

[FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: fix use of unknown builtin '__builtin_available'

From: Limin Wang OSX version: 10.11.6 Apple LLVM version 8.0.0 (clang-800.0.42.1) Target: x86_64-apple-darwin15.6.0 Signed-off-by: Limin Wang --- configure | 8 ++ libavutil/hwcontext_videotoolbox.c | 54 +- 2 files changed, 38

Re: [FFmpeg-devel] [PATCH] Fix first_pcr initial update

On Tue, Nov 02, 2021 at 12:47:57PM +0200, Maksym Veremeyenko wrote: > One of latest commit > https://source.ffmpeg.org/?p=ffmpeg.git;a=commitdiff;h=6f36eb0da71d22aadf8f056f0966bd86656ea57e > claim it fixes endless loop on package generation if muxrate specified and > copyts used. But actually it d

Re: [FFmpeg-devel] [PATCH] Fix first_pcr initial update

On Tue, Nov 02, 2021 at 05:36:37PM +0200, Maksym Veremeyenko wrote: > On 02.11.2021 16:59, lance.lmw...@gmail.com wrote: > [...] > > > +if (!ts->first_dts_checked && dts != AV_NOPTS_VALUE) { > > > +ts->first_pcr += dts * 300; > > > +ts->first_dts_checked = 1; > > > +} > > >

Re: [FFmpeg-devel] [PATCH] Fix first_pcr initial update

On Wed, Nov 03, 2021 at 01:01:29PM +0200, Maksym Veremeyenko wrote: > On 02.11.2021 12:47, Maksym Veremeyenko wrote: > > One of latest commit > > https://source.ffmpeg.org/?p=ffmpeg.git;a=commitdiff;h=6f36eb0da71d22aadf8f056f0966bd86656ea57e > > claim it fixes endless loop on package generation if

[FFmpeg-devel] [PATCH 1/2] avfilter/af_atilt: use ff_filter_execute()

From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/af_atilt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_atilt.c b/libavfilter/af_atilt.c index a1ce030..a6f7782 100644 --- a/libavfilter/af_atilt.c +++ b/libavfilter/af_atilt.c @@ -196,7 +196,7 @@ s

[FFmpeg-devel] [PATCH 2/2] avutil/slicethread: Add a maximum constraint of 16 slice threads

From: Limin Wang Signed-off-by: Limin Wang --- libavutil/slicethread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/slicethread.c b/libavutil/slicethread.c index 867ce32..7b3a106 100644 --- a/libavutil/slicethread.c +++ b/libavutil/slicethread.c @@ -104,7 +104,7

Re: [FFmpeg-devel] [PATCH 2/2] avutil/slicethread: Add a maximum constraint of 16 slice threads

On Fri, Nov 05, 2021 at 10:00:41PM +0100, Michael Niedermayer wrote: > On Fri, Nov 05, 2021 at 08:32:16PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavutil/slicethread.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[FFmpeg-devel] [PATCH v2] avfilter/src_movie: Add a maximum constraint of 16 slice threads

From: Limin Wang It's configured the number of video decode thread, so use the same maximum constraint as MAX_AUTO_THREADS in libavcodec/pthread_internal.h Signed-off-by: Limin Wang --- libavfilter/src_movie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/src

Re: [FFmpeg-devel] [PATCH 2/2] avutil/slicethread: Add a maximum constraint of 16 slice threads

On Sat, Nov 06, 2021 at 08:42:38AM +0100, Hendrik Leppkes wrote: > On Sat, Nov 6, 2021 at 6:26 AM wrote: > > > > On Fri, Nov 05, 2021 at 10:00:41PM +0100, Michael Niedermayer wrote: > > > On Fri, Nov 05, 2021 at 08:32:16PM +0800, lance.lmw...@gmail.com wrote: > > > > From: Limin Wang > > > > > >

Re: [FFmpeg-devel] [PATCH v2] avfilter/src_movie: Add a maximum constraint of 16 slice threads

On Sat, Nov 06, 2021 at 11:44:08AM +0100, Paul B Mahol wrote: > NACK What's your suggestion? any objection if add a thread option for src_movie filter? -- Thanks, Limin Wang ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mail

[FFmpeg-devel] [PATCH v3] avfilter/src_movie: make the number of decode thread configurable

From: Limin Wang Please use threads option if you want the number of thread configurable. Signed-off-by: Limin Wang --- libavfilter/src_movie.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c index 573f363..5811675 100644

Re: [FFmpeg-devel] [PATCH v3] avfilter/src_movie: make the number of decode thread configurable

On Sat, Nov 06, 2021 at 02:59:06PM +0100, Paul B Mahol wrote: > On Sat, Nov 6, 2021 at 2:48 PM wrote: > > > From: Limin Wang > > > > Please use threads option if you want the number of thread configurable. > > > > > Generally bad idea to use number of filtering threads for decoding threads. I a

[FFmpeg-devel] [PATCH v4] avfilter/src_movie: make the number of decode thread configurable

From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi| 3 +++ libavfilter/src_movie.c | 10 +++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index b537e42..c9ef854 100644 --- a/doc/filters.texi +++ b/doc/filters.te

[FFmpeg-devel] [PATCH 01/11] avformat/rtpdec_rfc4175: use rawvideo for uyvy422

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index f50cad7..f13736b 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtpde

[FFmpeg-devel] [PATCH 02/11] avcodec/bitpacked: remove unneeded 8bit support

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/bitpacked.c | 44 +--- 1 file changed, 5 insertions(+), 39 deletions(-) diff --git a/libavcodec/bitpacked.c b/libavcodec/bitpacked.c index 0440df9..d239141 100644 --- a/libavcodec/bitpacked.c +++

[FFmpeg-devel] [PATCH 03/11] avformat/rtpdec_rfc4175: remove the unused tag

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index f13736b..fe0754f 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtpdec_rfc4175.c @@ -4

[FFmpeg-devel] [PATCH 04/11] avformat/rtpdec_rfc4175: support for yuv420p format

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/rtpdec_rfc4175.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavformat/rtpdec_rfc4175.c b/libavformat/rtpdec_rfc4175.c index fe0754f..81930ce 100644 --- a/libavformat/rtpdec_rfc4175.c +++ b/libavformat/rtpdec_rfc4

[FFmpeg-devel] [PATCH 05/11] avformat/rtpenc: adds partial support for the RFC 4175

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/Makefile | 1 + libavformat/rtpenc.c | 4 ++ libavformat/rtpenc.h | 1 + libavformat/rtpenc_rfc4175.c | 116 +++ libavformat/sdp.c| 25 ++ 5 file

[FFmpeg-devel] [PATCH 06/11] avcodec: use s210 fourcc for 10-bit 4:2:2 packed

From: Limin Wang s210 is used by AWS Elemental Live encoder so I prefer to use same to support 4:2:2 10-bit packed uncompressed video. Refer to: https://docs.aws.amazon.com/elemental-live/latest/ug/codec-vod-outputs.html I split the patch for better review, next patch will rename bitpacked.c to

  1   2   3   4   5   6   7   8   9   10   >