On Tue, Sep 28, 2021 at 03:45:03PM +0200, Andreas Rheinhardt wrote:
> lance.lmw...@gmail.com:
> > From: Limin Wang <lance.lmw...@gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmw...@gmail.com>
> > ---
> > libavutil/detection_bbox.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/libavutil/detection_bbox.c b/libavutil/detection_bbox.c
> > index 40711e6..d066567 100644
> > --- a/libavutil/detection_bbox.c
> > +++ b/libavutil/detection_bbox.c
> > @@ -61,6 +61,7 @@ AVDetectionBBoxHeader
> > *av_detection_bbox_create_side_data(AVFrame *frame, uint32
> > }
> >
> > if (!av_frame_new_side_data_from_buf(frame,
> > AV_FRAME_DATA_DETECTION_BBOXES, buf)) {
> > + av_freep(&header);
> > av_buffer_unref(&buf);
> > return NULL;
> > }
> >
>
> This is wrong: header is owned by buf (or rather by the underlying
> AVBuffer) and will automatically be freed when the last AVBufferRef gets
> unreferenced, which happens in the above av_buffer_unref() call. Your
> patch will just lead to a double-free.
Sorry, it's my fault, haven't notice that, please ignore the patch.
>
> - Andreas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
