little time.
Thanks.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ff
eprecated and ignored. Use
> @ref{sws_flags,,sws_flags,ffmpeg-scaler}
> +instead to specify swscale flags for those automatically inserted scalers.
It says what option to use, but it does not say HOW to use it. It seems
to be set on the filter graph itself, but IIRC there is a syntax to do
it.
myself find it inconvenient, and I would like to
propose something better.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
+/**
> + * Get a human-readable string describing the channel layout properties.
> + *
> + * @note The returned string is allocated with av_malloc(),
> + * and must be freed by the caller with av_free().
> + *
> + * @param channel_layout channel layout to be described
>
Signed-off-by: Nicolas George
---
fftools/ffmpeg_opt.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 71063cc443..5ce70db23e 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -34,6 +34,7 @@
#include
Signed-off-by: Nicolas George
---
libavformat/dump.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavformat/dump.c b/libavformat/dump.c
index 56814ff7d2..fcf8bad63a 100644
--- a/libavformat/dump.c
+++ b/libavformat/dump.c
@@ -479,12 +479,14 @@ static void dump_stream_format
annoying. Well, I think I will keep this patch in my tree for
working but not push it. Thanks.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/list
#define AV_WRITER_FALLBACK (1U << 16)
When this flag is set, the function writes a fall-back string for
unknown values ("unknown", "?", "invalid", depends on the type).
Otherwise, it prints nothing.
Before working more on integrating this, I would like a little
testing it.
In the above code, ch should be unsigned too. Or, if it has a good
reason to be signed (negative values meaning something else?), test them
first.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel
ike checking that an array index is small enough but
forgetting to check non-negative.
Considering the time you spent recently "fixing" signed integer
overflows, I suspect you may be receptive to the fact that unsigned
arithmetic is entirely specified.
Regards,
--
Nicola
VERROR(EIO) as a default error for some time because
we did not have the proper codes, but now we have.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/m
where parameters have a
constraint that cannot be expressed with the imperfect type system of
the C language. There are in the standard C library too: realloc() vs.
free(), pclose() vs. fclose(), etc.
Regards,
--
Nicolas George
signature.asc
Desc
Tomas Härdin (12019-12-15):
> Perhaps someone with more insight into lavfi wants to comment?
I intend to look at it, but it have been a hectic week here.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mail
Nicolas George (12019-12-08):
> [ TL;DR: a lightweight oo API for functions that need to return a
> string, designed to be as convenient as possible. ]
Ping?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg
determine whether the address should be printed. That way, if the
address is needed (to distinguish different objects of the same type, as
Michael pointed), it can be: it is treating the address part itself as
level debug.
Also, maybe verbose rather than debug. I am not sure.
Regards,
--
le ill at ease.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@f
Nicolas George (12019-12-02):
> The frame is immediately pushed, the fifo has never more than one.
>
> Signed-off-by: Nicolas George
> ---
> libavfilter/buffersrc.c | 45 ++---
> 1 file changed, 11 insertions(+), 34 deletions(-)
I wi
Nicolas George (12019-12-08):
> [ TL;DR: a lightweight oo API for functions that need to return a
> string, designed to be as convenient as possible. ]
Judging on the lack of reaction to this mail, there seems to be no
strong feeling against this. I therefore intend to move ahead.
R
Paul B Mahol (12019-12-21):
> I doubt that is very good idea or conclusion.
If you have technical or practical thoughts about my proposal, please
share them in reply to the first message.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-de
t;250 lines of quote for just 3
new lines is not a good signal/noise ratio, especially since your mailer
re-wraps quotes (which it should not).
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpe
Limin Wang (12019-12-23):
> But It's not my code, I'm a code reviewer.
Then review that ret needs to be returned ;-) It needs more change, not
less.
And the commit message needs to be explicit. CID may not be available
everywhere or everywhen.
Regards,
--
Nicolas George
TODO changelog and version bump
Signed-off-by: Nicolas George
---
doc/filters.texi | 48 +++
libavfilter/Makefile | 1 +
libavfilter/af_mbfequalizer.c | 567 ++
libavfilter/allfilters.c | 1 +
4 files changed, 617 insertions
Nicolas George (12019-12-17):
> I will push these five patches soon unless somebody object.
Pushed.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.
myp...@gmail.com (12019-12-12):
> LGTM, but need to wait next release cycle?
What do you mean? There is all the necessary code to let the option
disappear automatically at the next release.
I shall push soon, unless you point something I have missed.
Regards,
--
Nicolas Geo
Zhong Li (12019-12-23):
> > Then review that ret needs to be returned ;-) It needs more change, not
> > less.
>
> Could specify what "more change" is needed?
See above, I underlined it.
Regards,
--
Nicolas George
si
fore does
not allow direct rendering. Also, it unnecessarily copies the data. I
have already noted that this is a frequent pattern in filters that
should be factored soon.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg
le ((desc = ...))
count++;
ret->formats = av_malloc_array(count, sizeof(*ret->formats));
count = 0;
while ((desc = ...))
ret->formats[count] = ...;
What do other developers think about it, with these explanations?
Regards,
--
Nicolas Geor
d pushed.
Thanks.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-de
--
> libavfilter/buffersrc.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
Well spotted. Pushed. Thanks.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.o
ibav*
AV_SAMPLE_FMT_NB ///< Number of sample formats. DO NOT USE if linking
dynamically
you cannot use AV_PIX_FMT_NB or AV_SAMPLE_FMT_NB in lavfi, only in lavu.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
s also past histograms of number of frames
> defined
> +by @code{width} option.
Is there a reason to make it a separate filter rather than adding the
option "width" to the existing filter?
If it cannot be done, query_formats(), config_input() and a significant
part of filter_fram
It is no longer used in our code base and does not seem
to be used much in other projects.
Signed-off-by: Nicolas George
---
doc/APIchanges | 3 +++
libavutil/avstring.c | 2 ++
libavutil/avstring.h | 5 +
libavutil/tests/avstring.c | 4
libavutil/version.h
t user interface and features. This is terrible for
user experience.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link
will cause
more problems as the memory of computers, and therefore the task we give
them, grow. Let us not cultivate them.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
ht
> +s->thistogram = 1;
Could you not test if s->width == 1 and have just one filter:
histogram=... -> equivalent to current histogram
histogram=width=1080:... -> equivalent to new thistogram
? It would save you the task of using a macro for common options.
Reg
Signed-off-by: Nicolas George
---
libavutil/Makefile | 3 +-
libavutil/writer.c | 371
libavutil/writer.h | 418 +
3 files changed, 791 insertions(+), 1 deletion(-)
create mode 100644 libavutil/writer.c
Signed-off-by: Nicolas George
---
libavformat/avformat.h | 21 +++
libavformat/dump.c | 297 +
2 files changed, 175 insertions(+), 143 deletions(-)
Note: I chose flags instead of is_output because I intent do add new flags
later, in particular
Signed-off-by: Nicolas George
---
libavutil/Makefile | 1 +
libavutil/tests/.gitignore | 1 +
libavutil/tests/writer.c | 190 +
tests/fate/libavutil.mak | 4 +
tests/ref/fate/writer | 36 +++
5 files changed, 232 insertions
Paul B Mahol (12019-12-27):
> Will apply in 5 minutes.
Too soon. Let other people time to spot problems and voice objections.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-de
Paul B Mahol (12019-12-27):
> I disagree.
And yet in the meantime somebody found a bug. This is a big patch, and
we have a policy.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.
James Almer (12019-12-26):
> I guess we'll bumping in the coming months (it's been a long while since
> the last time, and some cleaning is in order), so might as well make
> this < 58 so we don't have to postpone it later.
Ok, locally changed to 58.
Reg
t; That is certainly possible (if "alter ptr the same way nb_allocated is
> altered" means: Via a pointer to a pointer.
Yes, altering the pointer by pointer instead of returning it: that frees
the return value for an error code.
Regards,
--
Nicolas George
signature.asc
Description
, they need to be fixed.
The rule is: only use AV_SOMEGHING_NB in the same library.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffm
use we are
> not always aware of the framerate.
I think the duration is already there: out_time(_us).
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mai
Andriy Gelman (12019-12-27):
> The 3/3 patch fails to apply with git:
> https://unofficial.patchwork-ffmpeg.org/project/FFmpeg/list/?series=68
It is on top of a patch to disable deprecation warnings that was not yet
pushed. It does not matter much right now.
Regards,
--
Nicolas
zhilizhao (12019-12-28):
> Could you help apply the patch?
Since mypopy does not explain themselves, I will apply. But the patch
needs to be rebased and conflicts resolved.
Regards,
--
Nicolas George
signature.asc
Description: PGP signat
refix please.
> } AVCodec;
>
> #if FF_API_CODEC_GET_SET
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubs
eletions(-)
Pushed, thanks.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-de
ew streams. I think a generic
solution would be preferable.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe,
dy noticed they were not taken into account, it was probably
not important.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
quinkbl...@foxmail.com (12019-12-04):
> From: Zhao Zhili
>
> The option is deprecated and ignored by buffersrc.
> ---
> fftools/ffmpeg_filter.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Pushed, thanks.
Regards,
--
Nicolas George
signature.as
ere an
optimizing compiler produces very unintuitive code because there is a
tiny UB in the middle.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/list
cenc, matroskaenc and mlpdec
> conversions. And of course can be potentially useful to the callers.
> Since we are not deprecating the AV_CH_FOO macros, I do not see a
> problem with having it public.
Ok.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
hould be the choice for all new code. I remember trouble
about that, let us not make some more.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/lis
d.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org w
Thierry Foucu (12020-01-03):
> So, right now, we cannot build ffmpeg with optimization on Mac Os 10.15.
Can't you pass the option as extra-cflags to configure? It should work,
until a proper fix is proposed.
Regards,
--
Nicolas George
signature.asc
Description: PGP s
ed, 1 insertions(+), 3 deletions(-)
Thanks for the fix. Pushed with a few amendments to the commit message.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/m
Fix CID 1457235.
Signed-off-by: Nicolas George
---
libavutil/buffer.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavutil/buffer.c b/libavutil/buffer.c
index 6d9cb7428e..2f33e5ebb6 100644
--- a/libavutil/buffer.c
+++ b/libavutil/buffer.c
@@ -171,6 +171,7 @@ int
Fix CID 1457229.
Signed-off-by: Nicolas George
---
libavcodec/avpacket.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c
index 858f827a0a..4da832c53c 100644
--- a/libavcodec/avpacket.c
+++ b/libavcodec/avpacket.c
@@ -170,7
Andreas Rheinhardt (12020-01-04):
> Shouldn't you check for (ret < 0) instead of (!new)? I am unsure
> whether Coverity will really count this as a fix.
I hesitated and went for the minimalist patch. New version.
Regards,
--
Nicolas George
From 8ef49a7c86e108ed9e6981d482ae89
way.
There is no complexity for the callee. If anything, using AVWriter makes
the callee code simpler.
I understand that you may be reluctant to embrace creative APIs, but
please try to go beyond that reluctance to see the actual benefits and
costs.
Regards,
--
Nicolas George
signature.asc
Descr
cause the compilers are allowed to shunt the
checks, and they do.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscri
r is perfectly well defined, but to give them a good user
interface requires channel names and duplication. It's too bad you
invested a lot of work while forgetting about them.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
at signed
with UB are more dangerous than unsigned with modular arithmetic.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Anton Khirnov (12020-01-13):
> You still did not say which filters those are, why do they need to
> create streams with duplicate channels, or for that matter how they can
> even do so when the current API does not support it.
The one that comes to mind immediately is amerge, which is meant to be
rror check are enough
to warrant the little bit of complication for the caller. And the
possibility to output to many kinds of strings comes on top of that.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing
channel layout API was done and the filter
was in the process of being written. But it is the other way around: the
filter exists, it has needs, the new API must adapt.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg
rheinha...@gmail.com> wrote:
Top-posting is not allowed on this mailing-list. If you do not know what
it means, look it up.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg
not optional, writing frames before
it is not supported.
For questions about the proper usage of the API, see this mailing-list:
https://ffmpeg.org/mailman/listinfo/libav-user
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffm
detected statically;
these need to be fixed, period.
This is not specific to FFmpeg: what do you get for calling fprintf() on
a NULL FILE pointer?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmp
Signed-off-by: Nicolas George
---
doc/fftools-common-opts.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi
index 1234de850e..31cf424823 100644
--- a/doc/fftools-common-opts.texi
+++ b/doc/fftools-common-opts.texi
Gyan (12020-01-20):
> LGTM.
Thanks, pushed.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit l
cal. What architecture
are giving this?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above,
Nicolas George (12020-01-22):
> Andreas Rheinhardt (12020-01-22):
> > Clang with UBSan. It of course works in practice, but we don't know whether
> > future compilers might exploit undefined behaviour in an unintended way, so
> > these theoretical issues should be fixe
n a better solution to handle I/O.
Unfortunately, seeing the cold feet reaction to something as benign as
AVWriter, I am not confident this project has what it takes to go in the
right direction.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_
like the best option, then, does it not?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above,
egards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with s
nk alignment is very useful here.
> int even_rows_fix;
> } DVDSubtitleContext;
>
> @@ -436,7 +438,11 @@ static int dvdsub_init(AVCodecContext *avctx)
> int i, ret;
>
> av_assert0(sizeof(dvdc->global_palette) == sizeof(default_palette));
> -
. With that information, syncing becomes easy.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above
eams have proper and
comparable timestamps.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above
Peter Ross (12020-01-29):
> > +for (int i = 0; i < p->buf_size; i++)
> > +cnt += !!isprint(p->buf[i]);
This depends on locale settings. Is it on purpose?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_
Paul B Mahol (12020-01-28):
> I certainly could write one which does not use locale, if that is ok with you?
You know better than me on this issue. I was just pointing something
that may have been forgotten.
Regards,
--
Nicolas George
signature.asc
Description: PGP signat
Steven Liu (12020-01-31):
> Signed-off-by: Steven Liu
> ---
> libavformat/protocols.c | 2 ++
> 1 file changed, 2 insertions(+)
In what situation is it useful for the caller?
Regards,
--
Nicolas George
signature.asc
Description: P
ons are strict, unless
when there is a significant benefit.
Also, it is abusing an undocumented behavior.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mail
hen the issue is they did not specify a
protocol is not a useful semantic.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
rawbacks and almost no benefit.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-de
so, since this change only affects the case with
equality, there is no loss of precision. I'll keep the code as is,
unless there's a better reason.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mail
ne does not lead to a loss of precision.
> Is there something wrong with my patch or you just prefer status quo?
The current code seems more logical to me. Large round denominators are
a sign that the time base was not really rational in the first place.
--
Nicolas George
signature.a
waste.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.o
Paul B Mahol (12020-02-02):
> I will repeat my last question once again, is it ok for you to check that all
> input time-bases are same and that not AV_TIME_BASE is used in such case?
Already told you: waste of time.
--
Nicolas George
signature.asc
Description: PGP sig
e that works, it is enough.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Michael Niedermayer (12020-02-09):
> any objections ?
> if not i will push this in a few days
Please fix the spelling mistake in the commit message:
To loose = to set free.
To lose = to not have it anymore accidentally.
Regards,
--
Nicolas George
signature.asc
Description: PGP sig
> { .off = OFFSET(autoscale) },
> +"automatically insert a scale filter at the end of the filter graph
> if a resolution "
> +"change is detected. This ensures all frames are the same resolution
> as the first frame &q
ext. Take example on the other
help texts. Take example on the help text for autorotate!
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmp
Marton Balint (12020-02-15):
> > +if (s->nb_streams)
> > for (i = s->nb_streams - 1; i >= 0; i--)
> Maybe rewrite the loop instead?
> for (i = s->nb_streams; i-- > 0;)
Or
for (i = s->nb_streams - 1; i < s->nb_streams; i--)
Rega
Log as [opengl @ 0xaddress] instead of [opengl outdev @ 0xaddress].
Signed-off-by: Nicolas George
---
libavdevice/opengl_enc.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c
index fd0bb177d9
Fix a segfault if OpenGL was not initialized before calling
write_header().
Signed-off-by: Nicolas George
---
libavdevice/opengl_enc.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c
index fa94345a7c..3d60f7d068 100644
--- a
Signed-off-by: Nicolas George
---
libavformat/http.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index c9415578aa..135b533203 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -903,11 +903,19 @@ static
Fu, Linjie (12020-02-17):
> After several reviews, ping for this patch.
I only had concerns with the length of the help, they were addressed. I
have no more remarks.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffm
issue.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.
901 - 1000 of 5032 matches
Mail list logo
