can proceed with this patch?
Best regards.
On Fri, Aug 17, 2018 at 5:24 PM, Thomas Mundt wrote:
> Hi,
>
> 2018-08-16 13:56 GMT+02:00 Vasile Toncu :
>
> > Hi,
> >
> > Thank you for the additional testing effort.
> > Fixed the issue.
> >
> >
> th
n Mon, Sep 17, 2018 at 8:28 AM, Vasile Toncu
wrote:
> Hello,
>
> Thank you Thomas for the reviews and support!
>
> The proposed actions, by Nicolas George in https://ffmpeg.org/pipermail/
> ffmpeg-devel/2017-December/223072.html, were taken.
>
> >* Can one simply change
at the moment. This two patches add new features and improvements
for the filter.
Thank you. Regards.
On Tue, Oct 16, 2018 at 6:40 PM Vasile Toncu
wrote:
> Hello,
>
> Still Baptiste Coudurier and Michael Zucchi could not be reached, however
> since the old GPL tinterlace was replace
Hello,
Happy New Year.
Any news about this patch? Maybe Carl Eugen Hoyos could help us with this?
Best regards.
On Thu, Dec 6, 2018 at 6:10 PM Vasile Toncu
wrote:
> Hi,
>
> Since this patch is passing all the current tests, all the modification
> required by Thomas were implemen
t a/libavfilter/reinterlace.h b/libavfilter/reinterlace.h
new file mode 100644
index 000..924f347
--- /dev/null
+++ b/libavfilter/reinterlace.h
@@ -0,0 +1,130 @@
+/*
+ * Copyright (c) 2017 Vasile Toncu
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/o
On 06.03.2018 20:38, Thomas Mundt wrote:
Hi,
2018-03-05 13:48 GMT+01:00 Carl Eugen Hoyos :
2018-03-05 12:37 GMT+01:00, Paul B Mahol :
On 3/5/18, Vasile Toncu wrote:
Hello,
Thanks for the review. I've made changes according to your guidance.
It would be great to know if the comm
On 14.03.2018 18:56, Thomas Mundt wrote:
2018-03-13 16:10 GMT+01:00 Vasile Toncu :
On 06.03.2018 20:38, Thomas Mundt wrote:
Hi,
2018-03-05 13:48 GMT+01:00 Carl Eugen Hoyos :
2018-03-05 12:37 GMT+01:00, Paul B Mahol :
On 3/5/18, Vasile Toncu wrote:
Hello,
Thanks for the review. I&#x
On 14.03.2018 18:56, Thomas Mundt wrote:
2018-03-13 16:10 GMT+01:00 Vasile Toncu :
On 06.03.2018 20:38, Thomas Mundt wrote:
Hi,
2018-03-05 13:48 GMT+01:00 Carl Eugen Hoyos :
2018-03-05 12:37 GMT+01:00, Paul B Mahol :
On 3/5/18, Vasile Toncu wrote:
Hello,
Thanks for the review. I&#x
Hello,
This is the first part of the first patch. I added interlace options to
tinterlace. On the next patch I will delete vf_interlace.
Thank you,
Vasile Toncu
From b2be4e949e071f9017d8a9d6fbd1fbb56505ac50 Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Tue, 10 Apr 2018 23:28:32 +0300
. The next patch will add vf_reinterlace.
Thank you,
Vasile
From b72b643201187bf5d31d7bec9b5064d1b01c8179 Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Tue, 17 Apr 2018 13:48:28 +0300
Subject: [PATCH] Removed vf_interlace.c
---
libavfilter/Makefile | 2 +-
libavfilter
b93c2bc52d1892ffc9dd3f22e409aeeebd4cc163 Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Tue, 17 Apr 2018 13:48:28 +0300
Subject: [PATCH] Remove interlace.h and x86/vf_interlace_init.c
---
libavfilter/Makefile | 2 +-
libavfilter/interlace.h | 68 ---
libavfilter
Signed-off-by: Vasile Toncu
---
libavfilter/Makefile | 2 +-
libavfilter/interlace.h | 68 ---
libavfilter/vf_interlace.c | 366
libavfilter/vf_tinterlace.c | 26 +++
libavfilter/x86/Makefile
o,
I have attached the patch. It's strange, my mailer shows the message
with no line breaks, but on the list it appears like that. I hope this
solves the problem.
Kind regards,
Vasile
>From b93c2bc52d1892ffc9dd3f22e409aeeebd4cc163 Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Tue,
Hello,
Here is patch 3. Please review.
Thank you,
Vasile
>From 180d0b61ca2d835bdc58a17db07d4c79532b1b1e Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Mon, 23 Apr 2018 18:59:52 +0300
Subject: [PATCH] Patch3
Signed-off-by: Vasile Toncu
---
configure |
Hello,
Here is patches 2. Please review.
Thank you,
Vasile Toncu
>From cb12fbb6de88acfb3f7f54bd83b91661063e92ff Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Mon, 23 Apr 2018 18:10:18 +0300
Subject: [PATCH] Patch2
Signed-off-by: Vasile Toncu
---
libavfilter/Makef
Hello,
Here is patch 3. I renamed reinterlace to tinterlace and replaced the
functionality of tinterlace with the one from reinterlace. Please review.
Thank you,
Vasile
>From ee33ed769207a99adb193eece32a5043ff0b6d94 Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Wed, 25 Apr 2018 11:02
Hello,
Here is patch 2. In this patch I added the reinterlace filter to ffmpeg.
Please review.
Thank you,
Vasile
>From 71458a6cba548c9d5a559cdadae7a85a7825e98d Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Tue, 24 Apr 2018 17:46:45 +0300
Subject: [PATCH] Patch2
Signed-off-by: Vas
Hello,
The reinterlace filter does various interlace/interleave/merge operations
between consecutive frames of a video. It tries too behave just like
tinterlace filter, including some new modes.
On Wed, Dec 27, 2017 at 2:50 PM, Paul B Mahol wrote:
> Hi,
>
> On 12/27/17, Vasile Ton
> > The reinterlace filter does various interlace/interleave/merge operations
> > between consecutive frames of a video. It tries too behave just like
> > tinterlace filter, including some new modes.
Why not add the new modes to the tinterlace filter, then?
>
It is because of licencing issues. I
+ b/libavfilter/vf_reinterlace.c
@@ -0,0 +1,711 @@
+/*
+ * Copyright (c) 2017 Vasile Toncu
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Fou
On 27.12.2017 15:31, Nicolas George wrote:
Vasile Toncu (2017-12-27):
It is because of licencing issues. I wanted the new filter to be LGPL.
Thanks for the explanation. That is a valid reason.
But as is, it would result would be duplicated code for people who do
not worry about licensing
On 28.12.2017 15:17, Nicolas George wrote:
Vasile Toncu (2017-12-28):
Are there any features that tinterlace has and this new filter has not?
If not, then I think it would be better to just replace tinterlace
entirely.
You did not answer the question. I asked if there are features in
On Thu, 28 Dec 2017 at 15:41, Nicolas George wrote:
> Vasile Toncu (2017-12-28):
> > There are some features that tinterlace has and reinterlace does not.
> >
> > Tinterlace has some more flags, reinterlace has only simple low pass
> filter.
> > Also, in a newer ve
On Thu, 28 Dec 2017 at 17:14, Nicolas George wrote:
> Vasile Toncu (2017-12-28):
> > Is there anything that I can do to the current version of reinterlace so
> > that the filter can be accepted?
>
> For me, yes: make it fully compatible with tinterlace and call it that.
12:14 AM, Carl Eugen Hoyos
wrote:
> 2017-12-28 16:12 GMT+01:00 Vasile Toncu :
>
> > Is there anything that I can do to the current version of reinterlace
> > so that the filter can be accepted?
>
> Wasn't this already explained?
> Add the existing (GPL'd) asm
being said, can the new tinterlace be released under LGPL? It is
important for me to confirm once again this, to avoid writing new code
that will have no future life.
On 28.12.2017 17:30, Nicolas George wrote:
Vasile Toncu (2017-12-28):
Is submision
nt to address the main copyright holders Thomas Mundt, Stefano
Sabatini, Baptiste Coudurier and other ffmpeg maintainers for their
approval.
Here is the path for the new changes:
From 6cd7a4c7a963baacd9bdcc1b5ded8eef78de521b Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Mon, 5 Feb 2018 12:
I'm looking forward to modify *tinterlace* filter from GPL to LGPL.
I was under the impression you had already written a new filter
licensed under LGPL: What happened to it?
Yes, I wrote one, reinterlace. It implements tinterlace functionality as
it was on version n3.0.2, without ASM opts.
Yes, I wrote one, reinterlace. It implements tinterlace functionality as it
was on version n3.0.2, without ASM opts.
Sorry if you have already answered this question:
Can the existing asm optimizations be used with the filter you wrote?
Yes, I can integrate them with my filter.
-Vasile
Hello,
Then the best solution - imo! - is that you send a patch that adds your
new filter that uses the existing asm optimizations if FFmpeg was
configured for GPL.
First send one patch only adding a new filter (with a new name) to
get some technical review
I'll send a patch with my new filte
all the
authors.
Yes, you are right.
It is Mr. Michael Zucchi who holds the authorship
for tinterlace in MPlayer. The ximian company is dead/acquired since 2003.
I'll try to get in touch with Michael.
Thanks,
-Vasile Toncu
___
ffmpeg-
Shall I start a new thread for the patch with the new filter, or can I
use this one?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
ly the same fps as
tinterlace does.
Here is the patch thats adds the filter. If everything goes well with
this patch, I'll add a new patch that changes current tinterlace with
reinterlace.
Thanks,
-Vasile Toncu
From 45010f4b4671edfe1318b84285d09dd28a882d63 Mon Sep 17 00:00:00 2001
From
On 2/21/2018 12:21 PM, Vasile Toncu wrote:
will be there any review for the reinterlace filter [1].
[1] http://ffmpeg.org/pipermail/ffmpeg-devel/2018-February/225257.html
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org
Hello,
will be there any review for the reinterlace filter [1].
Do you consider adding it to the next release of ffmpeg?
Thanks,
Vasile Toncu
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hello,
Thanks for the review. I've made changes according to your guidance.
It would be great to know if the community will go on with our intention
of adding reinterlace as a alternative for tinterlace.
That being said, here is the new patch.
Regards,
-Vasile Toncu
stuff. One can check thread starting at
[1].
[1] http://ffmpeg.org/pipermail/ffmpeg-devel/2018-February/224941.html
On 3/5/2018 2:53 PM, Paul B Mahol wrote:
On 3/5/18, Carl Eugen Hoyos wrote:
2018-03-05 12:37 GMT+01:00, Paul B Mahol :
On 3/5/18, Vasile Toncu wrote:
Hello,
Thanks for the r
Hello,
Here is patch 3 which renames reinterlace to tinterlace. Fate tests and
warnings should be ok now.
In patch 4 I will add the new options to the filter.
Thank you,
Vasile Toncu
>From 25d4f0154fe2a8bde3a47491f80ce131ebb20330 Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Tue, 29
k you,
Vasile Toncu
>From 5b19aaac81fd0f5a9d37a1585e2c814414542e2e Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Tue, 29 May 2018 15:54:19 +0300
Subject: [PATCH] Reint-Patch2
---
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/reint
Hello,
I've sent a wrong version in the previous email for patch 3. Please
ignore. This is the corect one.
Have a good day,
Vasile Toncu
>From 5898c531066f8e6c034eb1c882000f60ba4f0cb9 Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Tue, 29 May 2018 18:29:06 +0300
Subject: [PATC
Hello,
I have updated patch 2, it shall work now.
Thank you,
Vasile Toncu
On Mon, Jul 16, 2018 at 4:49 PM, Vasile Toncu
wrote:
> Hello,
>
> I have updated patch 2, it shall work now.
>
> Thank you,
> Vasile Toncu
>
> On Wed, May 30, 2018 at 2:00 PM, Vasile To
Hello,
I have updated patch 2, it shall work now.
Thank you,
Vasile Toncu
On Wed, May 30, 2018 at 2:00 PM, Vasile Toncu
wrote:
> Hello,
>
> Sorry for the late reply, I've been working on other projects.
> Here is patch 2, which adds vf_reinterlace filter. To my understandi
Hello,
I have updated patch 3, it shall work now.
Thank you,
Vasile Toncu
From 23bdcea190ccb801e3d5a0eb081fb28b17144452 Mon Sep 17 00:00:00 2001
From: Vasile Toncu
Date: Mon, 16 Jul 2018 16:13:10 +0200
Subject: [PATCH] Patch 3 - Move reinterlace to tinterlace
---
configure
Hi,
Did you have the time to take a look at patches 2 and 3? It's everything
fine?
Regards,
Vasile
On Mon, Jul 16, 2018 at 5:51 PM, Vasile Toncu
wrote:
> Hello,
>
> I have updated patch 3, it shall work now.
>
> Thank
Fixed tabs.
On Mon, Jul 16, 2018 at 4:50 PM, Vasile Toncu
wrote:
> Hello,
>
> I have updated patch 2, it shall work now.
>
> Thank you,
> Vasile Toncu
>
>
> On Mon, Jul 16, 2018 at 4:49 PM, Vasile Toncu
> wrote:
>
>> Hello,
>>
>> I have
Fixed tabs.
Thank you for the feedback.
On Fri, Jul 20, 2018 at 7:27 PM, Paul B Mahol wrote:
> On 7/20/18, Vasile Toncu wrote:
> > Hi,
> >
> > Did you have the time to take a look at patches 2 and 3? It's everything
> > fine?
>
> Yes and
What would be the next steps?
On Tue, Jul 24, 2018 at 12:17 PM, Vasile Toncu
wrote:
> Fixed tabs.
> Thank you for the feedback.
>
> On Fri, Jul 20, 2018 at 7:27 PM, Paul B Mahol wrote:
>
>> On 7/20/18, Vasile Toncu wrote:
>> > Hi,
>> >
>> > D
Hello,
I have updated patch 3 according to review, removed all code related to the
new flags (MERGE_TFF, MERGE_BFF) and threading functionality.
On Sat, Jul 28, 2018 at 5:04 PM, Thomas Mundt wrote:
> Hi,
>
> 2018-07-24 12:17 GMT+02:00 Vasile Toncu :
>
> > Fixed tabs.
>
Hi Thomas,
I added the log messages.
Thanks for the review.
On Tue, Aug 14, 2018 at 3:23 PM, Thomas Mundt wrote:
> Hi,
>
> 2018-08-13 0:02 GMT+02:00 Vasile Toncu :
>
> > Hello,
> >
> > I have updated patch 3 according to review, removed all code related to
Hi,
Thank you for the additional testing effort.
Fixed the issue.
On Tue, Aug 14, 2018 at 10:25 PM, Thomas Mundt wrote:
> Hi,
>
> 2018-08-14 18:53 GMT+02:00 Vasile Toncu :
>
> > Hi Thomas,
> >
> > I added the log messages.
> >
> > Thanks for the
50 matches
Mail list logo
