Hello,
The reinterlace behaves just like the tinterlace and in terms of fps is
basically the same.
The ASM Opts are used with reinterlace only in case of CONFIG_GPL enabled.
There are two new modes, MODE_MERGE_BFF and MODE_MERGE_TFF for which I
have documentation.
Also reinterlace processes the planes of a frame in separate threads.
I've tested it with diferent video formats, and the outputs are correct.
Previously there have been acceptance for using some methods form
tinterlace. Those methods have nothing to do with old, GPL licensed
code, and are doing some trivial stuff. One can check thread starting at
[1].
[1] http://ffmpeg.org/pipermail/ffmpeg-devel/2018-February/224941.html
On 3/5/2018 2:53 PM, Paul B Mahol wrote:
On 3/5/18, Carl Eugen Hoyos <ceffm...@gmail.com> wrote:
2018-03-05 12:37 GMT+01:00, Paul B Mahol <one...@gmail.com>:
On 3/5/18, Vasile Toncu <vasile.to...@tremend.com> wrote:
Hello,
Thanks for the review. I've made changes according to your guidance.
It would be great to know if the community will go on with our intention
of adding reinterlace as a alternative for tinterlace.
That being said, here is the new patch.
As already said, this is not acceptable.
There is no point in having 2 filters with near same funcionality.
If you consider the new filter ok, the existing filter will be removed
in the same push. I believe sending only the new filter makes
reviewing easier.
I'm ok with that, but next commits that do that and also do rename are
not available.
I'm also not sure can reinterlace filter be cosidered really safe from
standpoint that
it does not use any old GPL code.
Also bunch of stuff it does is trivial, both new and old GPL code so I
consider nobody
should care about its license.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
