[FFmpeg-devel] [PATCH] avcodec/aarch64: Access externs via GOT with PIC

2022-07-10 Thread Triang3l
owing dynamic relocations should apply to it. The testing device is running Android 11 (API level 30). The test was executed successfully, meaning that no relocations incompatible with PIC are required by libavcodec anymore. Signed-off-by: Triang3l ---  libavcodec/aarch64/fft_neo

Re: [FFmpeg-devel] [PATCH] avcodec/aarch64: Access externs via GOT with PIC

2022-07-10 Thread Triang3l
s, the original issue was likely a consequence of us using a completely different build process than FFmpeg is designed to be built with. We have our own Premake 5 scripts for FFmpeg components, that are used for generation of Android ndk-build files via my Premake generator, Triang3l/premak

Re: [FFmpeg-devel] [PATCH] avcodec/aarch64: Access externs via GOT with PIC

2022-07-10 Thread Triang3l
FFmpeg is designed to be built with. We have our own Premake 5 scripts for FFmpeg components, that are used for generation of Android ndk-build files via my Premake generator, Triang3l/premake-androidndk on GitHub. So yes, we don't have any link options imported from a file.I agree, it

Re: [FFmpeg-devel] [PATCH 1/2] libavutil: Add av_visibility_hidden for setting hidden symbol visibility

2022-07-11 Thread Triang3l
the convention is to rely on `git blame` for this purpose, that shouldn't be necessary. — Triang3l On 11/07/2022 15:12, Henrik Gramner wrote: On Mon, Jul 11, 2022 at 11:19 AM Martin Storsjö wrote: +#if (AV_GCC_VERSION_AT_LEAST(4,0) || defined(__clang__)) && (defined(__ELF_