Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2015-12-30 Thread Sasi Inguva
VPX_IMAGE_ABI_VERSION was not changed when the color_range enum was introduced so I am afraid I would have to drop libvpxdec changes. Sent the new patch On Wed, Dec 30, 2015 at 10:56 AM, James Almer wrote: > On 12/30/2015 3:47 PM, James Almer wrote: > > On 12/30/2015 3:23 PM, Sasi Ing

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-04 Thread Sasi Inguva
Ping! I could not find any other fields for version other than the IMAGE_ABI_VERSION , CODEC_ABI_VERSION, DECODER_ABI_VERSION which remain unchanged . On Wed, Dec 30, 2015 at 2:21 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Dec 30, 2015 at 3:46 PM, Sasi Ingu

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-04 Thread Sasi Inguva
Would it be a lot easier and correct if I just update the IMAGE_ABI_VERSION to 4 in libvpx HEAD and check here in the decoder IMAGE_ABI_VERSION > 3 ? On Mon, Jan 4, 2016 at 11:03 AM, Ronald S. Bultje wrote: > Hi, > > On Mon, Jan 4, 2016 at 1:48 PM, Sasi Inguva wrote: > > &

[FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-08 Thread Sasi Inguva
Pass through color range to vp9 encoder. Parse color range in libvpxdec.c. Signed-off-by: Sasi Inguva --- libavcodec/libvpxdec.c | 6 ++ libavcodec/libvpxenc.c | 26 ++ 2 files changed, 32 insertions(+) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-08 Thread Sasi Inguva
Sorry for the delay on this. Was waiting for https://chromium-review.googlesource.com/#/c/320116/ to be submitted. Sent the new patch with decoder changes. On Mon, Jan 4, 2016 at 12:26 PM, James Almer wrote: > On 1/4/2016 5:01 PM, Sasi Inguva wrote: > > Would it be a lot easier and cor

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-11 Thread Sasi Inguva
Thanks On Sat, Jan 9, 2016 at 7:53 AM, James Almer wrote: > On 1/9/2016 11:43 AM, Ronald S. Bultje wrote: > > Hi, > > > > On Fri, Jan 8, 2016 at 10:12 PM, Sasi Inguva wrote: > > > >> Pass through color range to vp9 encoder. Parse color range in > lib

[FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-28 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/matroska.h | 1 + libavformat/matroskadec.c| 21 +- libavformat/matroskaenc.c| 66 ++-- tests/fate/wavpack.mak | 4 +-- tests/ref/acodec/tta | 4 +-- tests/ref/fate

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-28 Thread Sasi Inguva
V,AVI all have specific header items to describe individual stream durations. On Tue, Jul 28, 2015 at 1:38 PM, Hendrik Leppkes wrote: > On Tue, Jul 28, 2015 at 9:39 PM, Sasi Inguva wrote: > > Signed-off-by: Sasi Inguva > > --- > > libavformat/matroska.h | 1 + >

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-29 Thread Sasi Inguva
=2d0d5f6bb1b4ae4f737419cb11379ccb13ad18f0;hb=refs/heads/master#l1445 On Wed, Jul 29, 2015 at 1:31 AM, wm4 wrote: > On Tue, 28 Jul 2015 12:39:59 -0700 > Sasi Inguva wrote: > > > Signed-off-by: Sasi Inguva > > --- > > libavformat/matroska.h | 1 + > >

Re: [FFmpeg-devel] [PATCH] Compute individual stream durations in matroska muxer. Write them as binary tags. Parse the binary tags in matroska demuxer, and write them to AVStream

2015-07-29 Thread Sasi Inguva
it : > >> > >> On Wed, Jul 29, 2015 at 8:15 PM, Sasi Inguva wrote: > >>> > >>> @Reimar: > >>> True about the stream duration being wrong if stream timestamp does not > >>> start at 0 . I just duplicated the logic to compute the tota

[FFmpeg-devel] [PATCH] libavformat/matroskadec.c: Parse stream durations set by mkvmerge and populate them in AVStream.

2015-07-31 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/matroskadec.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 1807cae..03b564e 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c

Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec.c: Parse stream durations set by mkvmerge and populate them in AVStream.

2015-07-31 Thread Sasi Inguva
Jul 2015 13:00:02 -0700 > Sasi Inguva wrote: > > > Signed-off-by: Sasi Inguva > > --- > > libavformat/matroskadec.c | 20 ++-- > > 1 file changed, 18 insertions(+), 2 deletions(-) > > > > diff --git a/libavformat/matroskadec.c b/libavfo

Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec.c: Parse stream durations set by mkvmerge and populate them in AVStream.

2015-08-01 Thread Sasi Inguva
Also I can check if the stream duration values are sane, by checking that they are less than the total duration of the file. On Fri, Jul 31, 2015 at 3:56 PM, Sasi Inguva wrote: > The syntax is the normal syntax HH:MM:SS used everywhere. > av_parse_time can parse both [-]HH:MM:SS[.m...]]

Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec.c: Parse stream durations set by mkvmerge and populate them in AVStream.

2015-08-03 Thread Sasi Inguva
> On Sat, 1 Aug 2015 11:11:14 -0700 > Sasi Inguva wrote: > > > Also I can check if the stream duration values are sane, by checking that > > they are less than the total duration of the file. > > Wouldn't change much - they could be too short too, and we couldn

[FFmpeg-devel] [PATCH] libavformat/matroska: Write stream durations in metadata, in the format of mkvmerge.

2015-08-04 Thread Sasi Inguva
Compute individual stream durations in matroska muxer. Write them as string tags in the same format as mkvmerge tool does. Signed-off-by: Sasi Inguva --- libavformat/matroskaenc.c| 75 +--- tests/fate/wavpack.mak | 4 +-- tests/ref/acodec/tta

[FFmpeg-devel] [PATCH] libavformat/matroska: Write stream durations in metadata, in the format of mkvmerge.

2015-08-04 Thread Sasi Inguva
Compute individual stream durations in matroska muxer. Write them as string tags in the same format as mkvmerge tool does. Signed-off-by: Sasi Inguva --- libavformat/matroskaenc.c| 79 +--- tests/fate/wavpack.mak | 4 +-- tests/ref/acodec/tta

Re: [FFmpeg-devel] [PATCH] libavformat/matroska: Write stream durations in metadata, in the format of mkvmerge.

2015-08-04 Thread Sasi Inguva
:51PM -0700, Sasi Inguva wrote: > > Compute individual stream durations in matroska muxer. > > Write them as string tags in the same format as mkvmerge tool does. > > > > Signed-off-by: Sasi Inguva > > --- > > libavformat/matroskaenc.c| 75 > ++

[FFmpeg-devel] (no subject)

2015-08-04 Thread Sasi Inguva
Nice catch. Changed the patch to initialize variables in mkv_write_header. Also checking for duration_offset > 0 before writing them as tags in the end, to ensure it won't be written for webm. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://

Re: [FFmpeg-devel] [PATCH] libavformat/matroska: Write stream durations in metadata, in the format of mkvmerge.

2015-08-05 Thread Sasi Inguva
; Sasi Inguva wrote: > > > Compute individual stream durations in matroska muxer. > > Write them as string tags in the same format as mkvmerge tool does. > > > > Signed-off-by: Sasi Inguva > > --- > > libavformat/matroskaenc.c| 79 >

Re: [FFmpeg-devel] [PATCH] libavformat/matroska: Write stream durations in metadata, in the format of mkvmerge.

2015-08-05 Thread Sasi Inguva
yes. it computes duration as max ( packet-timestamp + packet-duration) On Wed, Aug 5, 2015 at 10:08 AM, wm4 wrote: > On Wed, 5 Aug 2015 10:00:45 -0700 > Sasi Inguva wrote: > > > yes. it does . > > http://stackoverflow.com/questions/18688971/c-char-array-initialization >

Re: [FFmpeg-devel] [PATCH] libavformat/matroska: Write stream durations in metadata, in the format of mkvmerge.

2015-08-05 Thread Sasi Inguva
Thanks. On Wed, Aug 5, 2015 at 1:37 PM, wm4 wrote: > On Tue, 4 Aug 2015 22:09:57 -0700 > Sasi Inguva wrote: > > > Compute individual stream durations in matroska muxer. > > Write them as string tags in the same format as mkvmerge tool does. > > >

Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-05-29 Thread Sasi Inguva
Hi. sorry for the late reply. I sent a patch similar to this a while back https://patchwork.ffmpeg.org/patch/8227/ but it got lost in the sea. You also want to do, @@ -3579,7 +3579,8 @@ static void mov_fix_index(MOVContext *mov, AVStream *st) frame_duration_buffer[num_disc

[FFmpeg-devel] [PATCH] lavf/mov.c: Set st->start_time for video streams explicitly.

2018-05-29 Thread Sasi Inguva
If start_time is not set, ffmpeg takes the duration from the global movie instead of the per stream duration. Signed-off-by: Sasi Inguva --- libavformat/mov.c| 20 +--- tests/fate/mov.mak | 4 +++ tests/ref/fate/mov-neg-firstpts

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set st->start_time for video streams explicitly.

2018-05-31 Thread Sasi Inguva
Sorry. Forgot to attach the file. Pls find it attached. Also resending the patch signed with correct email address On Thu, May 31, 2018 at 2:14 PM Michael Niedermayer wrote: > On Tue, May 29, 2018 at 03:39:40PM -0700, Sasi Inguva wrote: > > If start_time is not set, ffmpeg takes the

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set st->start_time for video streams explicitly.

2018-05-31 Thread Sasi Inguva
Pls find attached, the correctly signed patch Thanks. On Thu, May 31, 2018 at 4:14 PM Sasi Inguva wrote: > Sorry. Forgot to attach the file. Pls find it attached. Also resending the > patch signed with correct email address > > On Thu, May 31, 2018 at 2:14 PM Michael Niederma

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set st->start_time for video streams explicitly.

2018-06-04 Thread Sasi Inguva
friendly ping. thx. On Thu, May 31, 2018 at 4:26 PM Sasi Inguva wrote: > Pls find attached, the correctly signed patch > Thanks. > > On Thu, May 31, 2018 at 4:14 PM Sasi Inguva wrote: > >> Sorry. Forgot to attach the file. Pls find it attached. Also resending >> th

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Only set pkt->duration to non negative values

2018-06-14 Thread Sasi Inguva
looks good to me On Wed, Jun 13, 2018 at 10:11 AM Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 5d9ffa69a3..0acf981aef 100644 >

Re: [FFmpeg-devel] [PATCH] libavformat/yuv4mpeg: Add color range support for Y4M Add color_range support in Y4M. Also set pixel format and color_range for YUVJ pixel formats.

2018-06-25 Thread Sasi Inguva
Friendly ping! Thx. On Fri, Jun 22, 2018 at 6:25 AM Carl Eugen Hoyos wrote: > 2018-06-22 9:29 GMT+02:00, Wang Cao : > >> > >> My question was which authority defined this metadata for > >> y4m? Or which (non-FFmpeg-based) other software > >> understands the metadata your patch adds to the files.

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mov: remove modulo operations from mov_estimate_video_delay()

2018-07-11 Thread Sasi Inguva
This one LGTM. Thanks for doing this. On Tue, Jul 10, 2018 at 5:18 PM Michael Niedermayer wrote: > 0.324 <-0.491 sec > > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/libavformat/mov.c b/libavfor

Re: [FFmpeg-devel] [PATCH 2/4] bavformat/mov: Eliminate variable buf_size from mov_estimate_video_delay()

2018-07-11 Thread Sasi Inguva
LGTM. thanks On Tue, Jul 10, 2018 at 5:18 PM Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 19 --- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index aabf06de12..67b3e11

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mov: Simplify last element computation in mov_estimate_video_delay()

2018-07-11 Thread Sasi Inguva
LGTM. On Tue, Jul 10, 2018 at 5:18 PM Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 67b3e11eb9..951a337cca 100644 > --- a/liba

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mov: Break out of inner loop early in mov_estimate_video_delay()

2018-07-11 Thread Sasi Inguva
LGTM. thanks On Tue, Jul 10, 2018 at 5:18 PM Michael Niedermayer wrote: > 0.266 <- 0.299 sec (this is time ffmpeg so containing alot other things) > > Sample for benchmark was: ffmpeg -f rawvideo -pix_fmt yuv420p -s 32x32 -i > /dev/zero -t 24:00:00.00 out.mp4 > > Signed-off-by: Michael Niedermaye

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set start_time for audio too (in case of edit lists).

2018-08-06 Thread Sasi Inguva
Attaching the fate file. On Mon, Aug 6, 2018 at 4:33 PM wrote: > From: Sasi Inguva > > Fixes vorbis mp4 audio files, with edit list specified. Since > st->skip_samples is not set in case of vorbis , ffmpeg computes the > start_time as negative. > > Si

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set start_time for audio too (in case of edit lists).

2018-08-08 Thread Sasi Inguva
i intended it only for audio, but i don't see any harm if it gets applied to subtitle tracks also . On Tue, Aug 7, 2018 at 3:23 PM Michael Niedermayer wrote: > On Mon, Aug 06, 2018 at 04:32:29PM -0700, isasi-at-google@ffmpeg.org > wrote: > > From: Sasi Inguva > > >

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set start_time for audio too (in case of edit lists).

2018-08-08 Thread Sasi Inguva
Ok. i'll correct the commit message. On Wed, Aug 8, 2018 at 4:25 PM Michael Niedermayer wrote: > On Wed, Aug 08, 2018 at 12:20:34PM -0700, Sasi Inguva wrote: > > i intended it only for audio, but i don't see any harm if it gets applied > > to subtitle tracks also . >

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set start_time for audio too (in case of edit lists).

2018-08-09 Thread Sasi Inguva
Pls find attached, the corrected patch. On Wed, Aug 8, 2018 at 5:24 PM Sasi Inguva wrote: > Ok. i'll correct the commit message. > > On Wed, Aug 8, 2018 at 4:25 PM Michael Niedermayer > wrote: > >> On Wed, Aug 08, 2018 at 12:20:34PM -0700, Sasi Inguva wrote: >>

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set start_time for all sterams (in case of edit lists).

2018-08-09 Thread Sasi Inguva
s > > Moritz > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > From a0da82579a1c9ebb81bd029750fa718fa5f1c152 Mon Sep 17 00:00:00 2001 From: Sasi Inguva Date: Mon, 6 Aug 2018 16:28:50 -0700 Subject: [PATCH] lavf/mov.c: Set st

<    1   2   3