[FFmpeg-devel] [PATCH 02/12] lavf: update auto-bsf to new BSF API

2016-04-27 Thread Rodger Combs
--- libavformat/internal.h | 5 +++-- libavformat/mux.c | 40 +- libavformat/segment.c | 6 +++-- libavformat/utils.c| 59 +- 4 files changed, 86 insertions(+), 24 deletions(-) diff --git a/libavformat/int

Re: [FFmpeg-devel] [PATCH 02/12] lavf: update auto-bsf to new BSF API

2016-04-28 Thread Rodger Combs
> On Apr 27, 2016, at 07:29, Nicolas George wrote: > > Le nonidi 9 floréal, an CCXXIV, Rodger Combs a écrit : >> --- >> libavformat/internal.h | 5 +++-- >> libavformat/mux.c | 40 +- >> libavformat/segment.c | 6 +++

[FFmpeg-devel] [PATCH] lavfi/drawutils: support NV12 and NV21

2016-05-09 Thread Rodger Combs
--- libavfilter/drawutils.c | 33 - tests/ref/fate/filter-pixfmts-pad | 2 ++ 2 files changed, 18 insertions(+), 17 deletions(-) diff --git a/libavfilter/drawutils.c b/libavfilter/drawutils.c index d37c83e..3146bfa 100644 --- a/libavfilter/drawutils.c ++

[FFmpeg-devel] [PATCH] ffmpeg: don't fail to explicitly set a decoder for an unknown stream type

2016-05-18 Thread Rodger Combs
--- ffmpeg_opt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c index c217462..84b312d 100644 --- a/ffmpeg_opt.c +++ b/ffmpeg_opt.c @@ -618,7 +618,7 @@ static AVCodec *find_codec_or_die(const char *name, enum AVMediaType type, int e av_l

[FFmpeg-devel] [PATCH 2/2] lavfi/vf_overlay: support NV12

2016-05-24 Thread Rodger Combs
--- libavfilter/vf_overlay.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c index 71f4db7..e01b924 100644 --- a/libavfilter/vf_overlay.c +++ b/libavfilter/vf_overlay.c @@ -125,6 +125,7 @@ typedef struct Overl

[FFmpeg-devel] [PATCH 1/2] lavfi/vf_overlay: change variable name to avoid shadowing

2016-05-24 Thread Rodger Combs
--- libavfilter/vf_overlay.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c index 37f19ea..71f4db7 100644 --- a/libavfilter/vf_overlay.c +++ b/libavfilter/vf_overlay.c @@ -401,7 +401,7 @@ st

[FFmpeg-devel] [PATCH] lavf/srtdec: fix probing files with negative first timestamps

2016-06-06 Thread Rodger Combs
--- libavformat/srtdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/srtdec.c b/libavformat/srtdec.c index 585aa6a..06061a8 100644 --- a/libavformat/srtdec.c +++ b/libavformat/srtdec.c @@ -52,7 +52,7 @@ static int srt_probe(AVProbeData *p) /* Check if the n

[FFmpeg-devel] [PATCH] lavf/srtdec: fix probing files with negative first timestamps

2016-06-09 Thread Rodger Combs
--- libavformat/srtdec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/srtdec.c b/libavformat/srtdec.c index 585aa6a..9ab7a4e 100644 --- a/libavformat/srtdec.c +++ b/libavformat/srtdec.c @@ -52,7 +52,10 @@ static int srt_probe(AVProbeData *p) /* Check if

Re: [FFmpeg-devel] [PATCH] lavc/audiotoolboxenc: fix dropped frames on iOS

2016-06-09 Thread Rodger Combs
One comment below; otherwise this LGTM. > On Jun 2, 2016, at 01:32, Rick Kern wrote: > > AudioConverterFillComplexBuffer() doesn't always call its callback. A frame > queue is used to prevent skipped audio samples. > > Signed-off-by: Rick Kern > --- > libavcodec/audiotoolboxenc.c | 78

[FFmpeg-devel] [PATCH] lavc/audiotoolbox: fix mappings for surround-direct and surround-center channels

2016-06-09 Thread Rodger Combs
--- libavcodec/audiotoolboxdec.c | 2 +- libavcodec/audiotoolboxenc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c index 2748e8d..3f12a46 100644 --- a/libavcodec/audiotoolboxdec.c +++ b/libavcodec/audiotoolboxdec

[FFmpeg-devel] [PATCH 10/14] lavf/movenc+dashenc: add automatic bitstream filtering

2016-06-12 Thread Rodger Combs
This is disabled by default when the empty_moov flag is enabled --- libavformat/dashenc.c | 43 - libavformat/movenc.c | 105 +++--- 2 files changed, 123 insertions(+), 25 deletions(-) diff --git a/libavformat/dashenc.c b/libavform

[FFmpeg-devel] [PATCH 07/14] lavf/segment: fix writing separate header with auto BSF

2016-06-12 Thread Rodger Combs
--- libavformat/segment.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index d22d550..d8877f0 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -89,6 +89,7 @@ typedef struct SegmentCo

[FFmpeg-devel] [PATCH 13/14] fate/vp9: add automatic bsf test

2016-06-12 Thread Rodger Combs
--- tests/fate/vpx.mak | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/fate/vpx.mak b/tests/fate/vpx.mak index f0bcfac..29cd2a7 100644 --- a/tests/fate/vpx.mak +++ b/tests/fate/vpx.mak @@ -133,5 +133,10 @@ FATE_VP9-$(CONFIG_IVF_DEMUXER) += fate-vp9-05-resize fate-vp9-05-resize: CMD

[FFmpeg-devel] [PATCH 14/14] fate/hevc: add automatic bsf test

2016-06-12 Thread Rodger Combs
--- tests/fate/hevc.mak | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index 05266cd..5ae5d3d 100644 --- a/tests/fate/hevc.mak +++ b/tests/fate/hevc.mak @@ -225,6 +225,17 @@ $(foreach N,$(HEVC_SAMPLES_444_12BIT),$(eval $(call FATE_HEVC_T

[FFmpeg-devel] [PATCH 12/14] fate/aac: add automatic bsf test

2016-06-12 Thread Rodger Combs
--- tests/fate/aac.mak | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak index 3d64031..b02b768 100644 --- a/tests/fate/aac.mak +++ b/tests/fate/aac.mak @@ -241,6 +241,10 @@ FATE_AAC_LATM += fate-aac-latm_stereo_to_51 fate-aac-l

[FFmpeg-devel] [PATCH 11/14] fate/h264: add automatic bsf test

2016-06-12 Thread Rodger Combs
--- tests/fate/h264.mak | 2 ++ tests/ref/fate/h264-autobsf-mp4toannexb | 1 + 2 files changed, 3 insertions(+) create mode 100644 tests/ref/fate/h264-autobsf-mp4toannexb diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak index e12263c..5307a29 100644 --- a/tests/fate/h26

[FFmpeg-devel] [PATCH 04/14] lavf/mux: run AVCodec::deinit if write_header fails

2016-06-12 Thread Rodger Combs
--- libavformat/mux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index dd3de24..071eac1 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -484,8 +484,11 @@ int avformat_write_header(AVFormatContext *s, AVDictionary **optio

[FFmpeg-devel] [PATCH 05/14] lavf/mux: add avformat_init_output

2016-06-12 Thread Rodger Combs
This allows a consumer to run the muxer's init function without actually writing the header, which is useful in chained muxers that support automatic bitstream filtering. --- libavformat/avformat.h | 34 +-- libavformat/internal.h | 10 libavformat/mux.c | 64

[FFmpeg-devel] [PATCH 03/14] lavf: add a flag to enable/disable automatic bitstream filtering

2016-06-12 Thread Rodger Combs
This is mostly useful for muxers that wrap other muxers, such as dashenc and segment. The actual duplicated bitstream filtering is largely harmless, but delaying the header can cause problems when the muxer intended the header to be written to a separate file. --- libavformat/avformat.h | 1 +

[FFmpeg-devel] [PATCH 08/14] lavf/movenc: add deinit function

2016-06-12 Thread Rodger Combs
--- libavformat/movenc.c | 65 ++-- 1 file changed, 28 insertions(+), 37 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 2f00091..acb0e25 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5284,21 +5284,18 @

[FFmpeg-devel] [PATCH 09/14] lavf/dashenc: add deinit function

2016-06-12 Thread Rodger Combs
--- libavformat/dashenc.c | 51 +-- 1 file changed, 17 insertions(+), 34 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 519f9c4..0848052 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -580,16 +580,12

[FFmpeg-devel] [PATCH 02/14] lavf: update auto-bsf to new BSF API

2016-06-12 Thread Rodger Combs
--- libavformat/internal.h | 5 +++-- libavformat/mux.c | 45 +- libavformat/segment.c | 6 +++-- libavformat/utils.c| 59 +- 4 files changed, 91 insertions(+), 24 deletions(-) diff --git a/libavformat

[FFmpeg-devel] [PATCH 01/14] lavf: deprecate av_apply_bitstream_filters

2016-06-12 Thread Rodger Combs
--- libavformat/avformat.h | 3 +++ libavformat/utils.c| 4 2 files changed, 7 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index f66c39b..b4fe626 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -2869,8 +2869,11 @@ int avformat_queue_atta

[FFmpeg-devel] [PATCH 06/14] lavf/segment: add deinit function

2016-06-12 Thread Rodger Combs
--- libavformat/segment.c | 47 --- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 4c6c6d4..d22d550 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -627,8 +627,9 @@ st

[FFmpeg-devel] [PATCH 01/13] lavf: deprecate av_apply_bitstream_filters

2016-06-12 Thread Rodger Combs
--- libavformat/avformat.h | 3 +++ libavformat/utils.c| 4 2 files changed, 7 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index f66c39b..b4fe626 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -2869,8 +2869,11 @@ int avformat_queue_atta

[FFmpeg-devel] [PATCH 03/13] lavf: add a flag to enable/disable automatic bitstream filtering

2016-06-12 Thread Rodger Combs
This is mostly useful for muxers that wrap other muxers, such as dashenc and segment. The actual duplicated bitstream filtering is largely harmless, but delaying the header can cause problems when the muxer intended the header to be written to a separate file. --- libavformat/avformat.h | 1 +

[FFmpeg-devel] [PATCH 06/13] lavf/segment: add deinit function

2016-06-12 Thread Rodger Combs
--- libavformat/segment.c | 47 --- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 4c6c6d4..d22d550 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -627,8 +627,9 @@ st

[FFmpeg-devel] [PATCH 02/13] lavf: update auto-bsf to new BSF API

2016-06-12 Thread Rodger Combs
--- libavformat/internal.h | 5 +++-- libavformat/mux.c | 45 +- libavformat/segment.c | 6 +++-- libavformat/utils.c| 59 +- 4 files changed, 91 insertions(+), 24 deletions(-) diff --git a/libavformat

[FFmpeg-devel] [PATCH 04/13] lavf/mux: run AVCodec::deinit if write_header fails

2016-06-12 Thread Rodger Combs
--- libavformat/mux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index dd3de24..071eac1 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -484,8 +484,11 @@ int avformat_write_header(AVFormatContext *s, AVDictionary **optio

[FFmpeg-devel] [PATCH 05/13] lavf/mux: add avformat_init_output

2016-06-12 Thread Rodger Combs
This allows a consumer to run the muxer's init function without actually writing the header, which is useful in chained muxers that support automatic bitstream filtering. --- libavformat/avformat.h | 34 +-- libavformat/internal.h | 10 libavformat/mux.c | 64

[FFmpeg-devel] [PATCH 08/13] lavf/movenc: add deinit function

2016-06-12 Thread Rodger Combs
--- libavformat/movenc.c | 67 +++- 1 file changed, 29 insertions(+), 38 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 2f00091..2f6f8bf 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5284,21 +5284,18 @

[FFmpeg-devel] [PATCH 10/13] lavf/movenc+dashenc: add automatic bitstream filtering

2016-06-12 Thread Rodger Combs
This is disabled by default when the empty_moov flag is enabled --- libavformat/dashenc.c | 43 +++- libavformat/movenc.c | 107 +++--- 2 files changed, 124 insertions(+), 26 deletions(-) diff --git a/libavformat/dashenc.c b/libavforma

[FFmpeg-devel] [PATCH 09/13] lavf/dashenc: add deinit function

2016-06-12 Thread Rodger Combs
--- libavformat/dashenc.c | 51 +-- 1 file changed, 17 insertions(+), 34 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 519f9c4..0848052 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -580,16 +580,12

[FFmpeg-devel] [PATCH 07/13] lavf/segment: fix writing separate header with auto BSF

2016-06-12 Thread Rodger Combs
--- libavformat/segment.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index d22d550..d8877f0 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -89,6 +89,7 @@ typedef struct SegmentCo

[FFmpeg-devel] [PATCH 13/13] fate/hevc: add automatic bsf test

2016-06-12 Thread Rodger Combs
--- tests/fate/hevc.mak | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index 05266cd..5ae5d3d 100644 --- a/tests/fate/hevc.mak +++ b/tests/fate/hevc.mak @@ -225,6 +225,17 @@ $(foreach N,$(HEVC_SAMPLES_444_12BIT),$(eval $(call FATE_HEVC_T

[FFmpeg-devel] [PATCH 11/13] fate/h264: add automatic bsf test

2016-06-12 Thread Rodger Combs
--- tests/fate/h264.mak | 2 ++ tests/ref/fate/h264-autobsf-mp4toannexb | 1 + 2 files changed, 3 insertions(+) create mode 100644 tests/ref/fate/h264-autobsf-mp4toannexb diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak index e12263c..5307a29 100644 --- a/tests/fate/h26

[FFmpeg-devel] [PATCH 12/13] fate/aac: add automatic bsf test

2016-06-12 Thread Rodger Combs
--- tests/fate/aac.mak | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak index 3d64031..b02b768 100644 --- a/tests/fate/aac.mak +++ b/tests/fate/aac.mak @@ -241,6 +241,10 @@ FATE_AAC_LATM += fate-aac-latm_stereo_to_51 fate-aac-l

Re: [FFmpeg-devel] [PATCH 04/14] lavf/mux: run AVCodec::deinit if write_header fails

2016-06-12 Thread Rodger Combs
> On Jun 12, 2016, at 16:24, Marton Balint wrote: > > > On Sun, 12 Jun 2016, Rodger Combs wrote: > >> --- >> libavformat/mux.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/mux.c b/libavformat/mu

[FFmpeg-devel] [PATCH 05/10] lavf/movenc: add deinit function

2016-06-25 Thread Rodger Combs
--- libavformat/movenc.c | 70 ++-- 1 file changed, 30 insertions(+), 40 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index d614933..9668b9c 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5475,21 +5475,18 @

[FFmpeg-devel] [PATCH 10/10] fate/hevc: add automatic bsf test

2016-06-25 Thread Rodger Combs
--- tests/fate/hevc.mak | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index 05266cd..fa63afd 100644 --- a/tests/fate/hevc.mak +++ b/tests/fate/hevc.mak @@ -225,6 +225,17 @@ $(foreach N,$(HEVC_SAMPLES_444_12BIT),$(eval $(call FATE_HEVC_T

[FFmpeg-devel] [PATCH 01/10] lavf: add a flag to enable/disable automatic bitstream filtering

2016-06-25 Thread Rodger Combs
This is mostly useful for muxers that wrap other muxers, such as dashenc and segment. The actual duplicated bitstream filtering is largely harmless, but delaying the header can cause problems when the muxer intended the header to be written to a separate file. --- libavformat/avformat.h | 1 +

[FFmpeg-devel] [PATCH 09/10] fate/aac: add automatic bsf test

2016-06-25 Thread Rodger Combs
--- tests/fate/aac.mak | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak index 3d64031..b02b768 100644 --- a/tests/fate/aac.mak +++ b/tests/fate/aac.mak @@ -241,6 +241,10 @@ FATE_AAC_LATM += fate-aac-latm_stereo_to_51 fate-aac-l

[FFmpeg-devel] [PATCH 08/10] fate/h264: add automatic bsf test

2016-06-25 Thread Rodger Combs
--- tests/fate/h264.mak | 2 ++ tests/ref/fate/h264-autobsf-mp4toannexb | 1 + 2 files changed, 3 insertions(+) create mode 100644 tests/ref/fate/h264-autobsf-mp4toannexb diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak index 4ae1305..e0a5446 100644 --- a/tests/fate/h26

[FFmpeg-devel] [PATCH 04/10] lavf/segment: fix writing separate header with auto BSF

2016-06-25 Thread Rodger Combs
--- libavformat/segment.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index d22d550..d8877f0 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -89,6 +89,7 @@ typedef struct SegmentCo

[FFmpeg-devel] [PATCH 03/10] lavf/segment: add deinit function

2016-06-25 Thread Rodger Combs
--- libavformat/segment.c | 47 --- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 4c6c6d4..d22d550 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -627,8 +627,9 @@ st

[FFmpeg-devel] [PATCH 06/10] lavf/dashenc: add deinit function

2016-06-25 Thread Rodger Combs
--- libavformat/dashenc.c | 51 +-- 1 file changed, 17 insertions(+), 34 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 519f9c4..0848052 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -580,16 +580,12

[FFmpeg-devel] [PATCH 07/10] lavf/movenc+dashenc: add automatic bitstream filtering

2016-06-25 Thread Rodger Combs
This is disabled by default when the empty_moov flag is enabled --- libavformat/dashenc.c | 43 +++- libavformat/movenc.c | 107 +++--- 2 files changed, 124 insertions(+), 26 deletions(-) diff --git a/libavformat/dashenc.c b/libavforma

[FFmpeg-devel] [PATCH 02/10] lavf/mux: add avformat_init_output

2016-06-25 Thread Rodger Combs
This allows a consumer to run the muxer's init function without actually writing the header, which is useful in chained muxers that support automatic bitstream filtering. --- libavformat/avformat.h | 34 +-- libavformat/internal.h | 10 libavformat/mux.c | 64

[FFmpeg-devel] [PATCH 1/5] lavf: add cue sheet demuxer

2016-07-04 Thread Rodger Combs
02110-1301 USA + */ + +/** + * @file + * Cue sheet demuxer + * @author Rodger Combs + */ + +#include "avformat.h" +#include "internal.h" +#include "subtitles.h" +#include "url.h" +#include "libavutil/intreadwrite.h" +#include "libavutil/av

[FFmpeg-devel] [PATCH 3/5] lavf/segment: add option to segment by chapter

2016-07-04 Thread Rodger Combs
--- doc/muxers.texi | 6 + libavformat/segment.c | 65 +++ libavformat/version.h | 2 +- 3 files changed, 67 insertions(+), 6 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index c2ca0ba..adf853e 100644 --- a/doc/muxers.texi

[FFmpeg-devel] [PATCH 5/5] lavf/segment: write attached pictures to all segments by default

2016-07-04 Thread Rodger Combs
--- doc/muxers.texi | 4 libavformat/segment.c | 33 + libavformat/version.h | 2 +- 3 files changed, 38 insertions(+), 1 deletion(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index adf853e..fe95cc6 100644 --- a/doc/muxers.texi +++ b/doc/muxers.te

[FFmpeg-devel] [PATCH 2/5] lavf/flacenc: support writing attached pictures

2016-07-04 Thread Rodger Combs
--- libavformat/flacenc.c | 253 +++--- 1 file changed, 218 insertions(+), 35 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 89b21e9..b7b3016 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -21,10 +21,13

[FFmpeg-devel] [PATCH 4/5] lavf/segment: copy stream dispositions in output

2016-07-04 Thread Rodger Combs
--- libavformat/segment.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 9c766a5..5aec018 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -184,6 +184,7 @@ static int segment_mux_init(AVFormatContext *s) }

Re: [FFmpeg-devel] [PATCH 1/9] avutil: add FF_RETURN_ON_OVERFLOW

2017-01-07 Thread Rodger Combs
> On Jan 7, 2017, at 02:36, Paul B Mahol wrote: > > On 1/7/17, Michael Niedermayer <mailto:mich...@niedermayer.cc>> wrote: >> On Fri, Jan 06, 2017 at 09:11:10PM -0300, James Almer wrote: >>> On 1/6/2017 4:46 PM, Andreas Cadhalpun wrote: >>>> S

[FFmpeg-devel] [PATCH] lavf/segment: fix crash when failing to open segment list

2017-01-20 Thread Rodger Combs
This happens because segment_end() returns an error, so seg_write_packet never proceeds to segment_start(), and seg->avf->pb is never re-set, so we crash with a null pb when av_write_trailer flushes the packet queue. This doesn't seem to be clearly recoverable, so I'm just failing more gracefully.

[FFmpeg-devel] [PATCH] lavf/movdec: downgrade "shifted frame pts" log line to trace

2017-03-08 Thread Rodger Combs
This gets pretty chatty in files that use edit lists, so it fits a bit better at the trace level with similar messages. --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d5c3949050..06f84f9f8e 100644 --- a/libavfor

[FFmpeg-devel] [PATCH 6/7] lavf/flacenc: avoid buffer overread with unexpected extradata sizes

2017-07-31 Thread Rodger Combs
--- libavformat/flacenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 9768b6a..1906aee 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -322,7 +322,7 @@ static int flac_write_trailer(struct AVFormatContext

[FFmpeg-devel] [PATCH 4/7] lavf/segment: write attached pictures to all segments by default

2017-07-31 Thread Rodger Combs
--- doc/muxers.texi | 4 libavformat/segment.c | 24 2 files changed, 28 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 23ef2e7..93147e1 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1576,6 +1576,10 @@ argument must be a time durat

[FFmpeg-devel] [PATCH 7/7] lavf/flacenc: generate timestamps internally

2017-07-31 Thread Rodger Combs
--- libavformat/flacenc.c | 88 +-- 1 file changed, 85 insertions(+), 3 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 1906aee..f569c14 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -30,6 +30,7 @@

[FFmpeg-devel] [PATCH 3/7] lavf/segment: copy stream dispositions in output

2017-07-31 Thread Rodger Combs
--- libavformat/segment.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 590f62b..ef0a915 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -182,6 +182,7 @@ static int segment_mux_init(AVFormatContext *s) }

[FFmpeg-devel] [PATCH 5/7] lavf/flacenc: support writing attached pictures

2017-07-31 Thread Rodger Combs
--- libavformat/flacenc.c | 285 +++--- 1 file changed, 250 insertions(+), 35 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index b894f9e..9768b6a 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -21,10 +21,13

[FFmpeg-devel] [PATCH 2/7] lavf/segment: add option to segment by chapter

2017-07-31 Thread Rodger Combs
--- doc/muxers.texi | 6 + libavformat/segment.c | 65 +++ libavformat/version.h | 2 +- 3 files changed, 67 insertions(+), 6 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 94472ce..23ef2e7 100644 --- a/doc/muxers.texi

[FFmpeg-devel] [PATCH 1/7] lavf: add cue sheet demuxer

2017-07-31 Thread Rodger Combs
Floor, Boston, MA 02110-1301 USA + */ + +/** + * @file + * Cue sheet demuxer + * @author Rodger Combs + */ + +#include "avformat.h" +#include "internal.h" +#include "subtitles.h" +#include "url.h" +#include "libavutil/intreadwrite.h" +#include

Re: [FFmpeg-devel] [PATCH 2/7] lavf/segment: add option to segment by chapter

2017-08-01 Thread Rodger Combs
This was pretty confusing whether it uses strlcpy or strncpy, so I'm switching it to AVBPrintf. > On Aug 1, 2017, at 01:54, Steven Liu wrote: > > 2017-08-01 14:33 GMT+08:00 Rodger Combs <mailto:rodger.co...@gmail.com>>: >> --- >> doc/muxers.texi | 6

Re: [FFmpeg-devel] [PATCH 4/7] lavf/segment: write attached pictures to all segments by default

2017-08-01 Thread Rodger Combs
Variables may be declared at the top of a scope block in ffmpeg. > On Aug 1, 2017, at 01:50, Steven Liu wrote: > > 2017-08-01 14:33 GMT+08:00 Rodger Combs <mailto:rodger.co...@gmail.com>>: >> --- >> doc/muxers.texi | 4 >> libavformat/segment.

Re: [FFmpeg-devel] [PATCH 6/7] lavf/flacenc: avoid buffer overread with unexpected extradata sizes

2017-08-01 Thread Rodger Combs
> On Aug 1, 2017, at 18:25, James Almer wrote: > > On 8/1/2017 3:33 AM, Rodger Combs wrote: >> --- >> libavformat/flacenc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c &g

Re: [FFmpeg-devel] [PATCH 1/7] lavf: add cue sheet demuxer

2017-08-01 Thread Rodger Combs
> On Aug 1, 2017, at 02:58, Nicolas George wrote: > > Le quartidi 14 thermidor, an CCXXV, Rodger Combs a écrit : >> --- >> Changelog| 2 + >> doc/demuxers.texi| 8 ++ >> libavformat/Makefile | 1 + >> libavformat/allfo

[FFmpeg-devel] [PATCH 1/7] lavf: add cue sheet demuxer

2017-08-02 Thread Rodger Combs
o the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +/** + * @file + * Cue sheet demuxer + * @author Rodger Combs + */ + +#include "avformat.h" +#include "internal.h" +#include "subtitles.h" +#include "url.h&qu

[FFmpeg-devel] [PATCH 4/7] lavf/segment: write attached pictures to all segments by default

2017-08-02 Thread Rodger Combs
--- doc/muxers.texi | 4 libavformat/segment.c | 40 +--- 2 files changed, 33 insertions(+), 11 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 23ef2e7..93147e1 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1576,6 +1576,10

[FFmpeg-devel] [PATCH 2/7] lavf/segment: add option to segment by chapter

2017-08-02 Thread Rodger Combs
--- doc/muxers.texi | 6 + libavformat/segment.c | 65 +++ libavformat/version.h | 2 +- 3 files changed, 67 insertions(+), 6 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 94472ce..23ef2e7 100644 --- a/doc/muxers.texi

[FFmpeg-devel] [PATCH 3/7] lavf/segment: copy stream dispositions in output

2017-08-02 Thread Rodger Combs
--- libavformat/segment.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 590f62b..ef0a915 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -182,6 +182,7 @@ static int segment_mux_init(AVFormatContext *s) }

[FFmpeg-devel] [PATCH 6/7] lavf/flacenc: avoid buffer overread with unexpected extradata sizes

2017-08-02 Thread Rodger Combs
--- libavformat/flacenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 9768b6a..1906aee 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -322,7 +322,7 @@ static int flac_write_trailer(struct AVFormatContext

[FFmpeg-devel] [PATCH 5/7] lavf/flacenc: support writing attached pictures

2017-08-02 Thread Rodger Combs
--- libavformat/flacenc.c | 285 +++--- 1 file changed, 250 insertions(+), 35 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index b894f9e..9768b6a 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -21,10 +21,13

[FFmpeg-devel] [PATCH 7/7] lavf/flacenc: generate timestamps internally

2017-08-02 Thread Rodger Combs
--- libavformat/flacenc.c| 87 ++-- tests/ref/acodec/flac| 4 +- tests/ref/acodec/flac-exact-rice | 4 +- tests/ref/seek/acodec-flac | 36 - 4 files changed, 106 insertions(+), 25 deletions(-) diff --git a/libavfo

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-04 Thread Rodger Combs
+sc->ctts_data = av_fast_realloc(sc->ctts_data, &sc->ctts_allocated_size, request_size); ^ this line is incorrect; setting realloc's first arg to its return value leaks the existing allocation in the OOM case. Since you're doing your own calculation for the desired new size here, you

[FFmpeg-devel] [PATCH] lavf/movdec: flag chapter streams as such, even when not reading them

2017-08-11 Thread Rodger Combs
This allows the use of the `ignore_chapters` option to avoid performing extra seeks at startup without producing "subtitle" chapter streams. --- libavformat/mov.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 63f84

[FFmpeg-devel] [PATCH 2/3] lavf/tls: use AV_OPT_TYPE_BOOL

2017-08-16 Thread Rodger Combs
--- libavformat/tls.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/tls.h b/libavformat/tls.h index 0326ef7924..53d0634f49 100644 --- a/libavformat/tls.h +++ b/libavformat/tls.h @@ -47,10 +47,10 @@ typedef struct TLSShared { #define TLS_COMMON_OPTIONS(pstruct

[FFmpeg-devel] [PATCH 1/3] lavf/tls_openssl: add support for verifying the server hostname on >=1.1.0

2017-08-16 Thread Rodger Combs
--- libavformat/tls_openssl.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 38af8a21c0..50361d30e2 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -256,8 +256,6 @@ static int

[FFmpeg-devel] [PATCH 3/3] lavf/tls: verify TLS connections by default whenever possible

2017-08-16 Thread Rodger Combs
This makes a reasonable effort to set the default configuration to behave securely, while maintaining the ability for consumers to produce builds using the old behavior without making changes to their runtime code. On Secure Transport and Secure Channel, we use a system-provided trust store, so we

Re: [FFmpeg-devel] [PATCH 3/3] lavf/tls: verify TLS connections by default whenever possible

2017-08-18 Thread Rodger Combs
> On Aug 16, 2017, at 06:29, wm4 wrote: > > On Wed, 16 Aug 2017 02:19:18 -0500 > Rodger Combs mailto:rodger.co...@gmail.com>> wrote: > >> This makes a reasonable effort to set the default configuration to behave >> securely, while maintaining the ability for

[FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2017-08-19 Thread Rodger Combs
There's a decent chance this doesn't work on [pretty much anything other than the samples I tested it with], but I haven't found very many samples, and don't want to implement the rest of the features blind with nothing but a spec, and most of it's pretty over-the-top anyway. For some reason my ph

Re: [FFmpeg-devel] [PATCH v15] avformat/dashdec: add dash demuxer base version

2017-08-27 Thread Rodger Combs
t; 1. play youtube link: ffmpeg -i $(youtube-dl -J > "https://www.youtube.com/watch?v=XmL19DOP_Ls"; | jq -r > ".requested_formats[0].manifest_url") > 2. code refine for timeline living stream > > Reviewed-by: Clément Bœsch > Reviewed-by: Michael Niedermayer

Re: [FFmpeg-devel] Odp: Re: [PATCH v15] avformat/dashdec: add dash demuxer base version

2017-08-27 Thread Rodger Combs
mp4 atoms missing checking > and there is quite easy to make segfault of the libavformat when try to > prepared mp4 file. > > I understand that you want to have maximum safety with new code but I hope > you know that ffmpeg at all is not safety. > > Regards, > SSS >

Re: [FFmpeg-devel] [PATCH v15] avformat/dashdec: add dash demuxer base version

2017-08-28 Thread Rodger Combs
e > `"%0*"PRId64`"? > > Dnia 28 sierpnia 2017 03:30 Rodger Combs napisał(a): > > If you know of such a vulnerability, report it to > <mailto:ffmpeg-secur...@ffmpeg.org>ffmpeg-secur...@ffmpeg.org > <mailto:ffmpeg-secur...@ffmpeg.org>. New code with

Re: [FFmpeg-devel] [PATCH v15] avformat/dashdec: add dash demuxer base version

2017-08-30 Thread Rodger Combs
+for(ptr=start + marker_len; ptr < (end - 1); ++ptr) { /*there is > need to check this condition :P */ > +if (*ptr != '0') { > + // Unknown format add log here > +goto finish; > +} > +} > f

Re: [FFmpeg-devel] [PATCH] mark null encoder as ts-nonstrict , avoids error messages for null output

2014-08-28 Thread Rodger Combs
.github.com/anonymous/0e26f490ec13d67996fd> > > > > > > commit e94a44543a96b13aa6a23efce2f0378a5479d530 > > > Author: Rodger Combs > > <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>> > > > Date: Wed Aug 20 15:38:12 2014 -0700 > >

[FFmpeg-devel] PATCH: Make -copyts a tri-state

2014-10-15 Thread Rodger Combs
Discussed this briefly on IRC; decided this was a good idea. I'm not sure if the commit message explains it well enough; please poke me here or on IRC if it doesn't. 0001-Make-copyts-a-tri-state-with-no-normalizing-input-ti.patch Description: Binary data

Re: [FFmpeg-devel] PATCH: Make -copyts a tri-state

2014-10-15 Thread Rodger Combs
> On Oct 15, 2014, at 05:34, Rodger Combs wrote: > > Discussed this briefly on IRC; decided this was a good idea. I'm not sure if > the commit message explains it well enough; please poke me here or on IRC if > it doesn't. > <0001-Make-copyts-a-tri-state-wit

Re: [FFmpeg-devel] PATCH: Make -copyts a tri-state

2014-10-15 Thread Rodger Combs
> On Oct 15, 2014, at 05:37, Nicolas George wrote: > > Le quartidi 24 vendémiaire, an CCXXIII, Rodger Combs a écrit : >> Discussed this briefly on IRC; decided this was a good idea. I'm not sure >> if the commit message explains it well enough; please poke me here

[FFmpeg-devel] [PATCH] matroskadec: execute seekheads recursively

2014-10-16 Thread Rodger Combs
This fixes https://trac.ffmpeg.org/ticket/3934 , but I'm not sure if there was a good reason for this to be here to begin with. Perhaps a protection against infinite recursion (though I believe EBML_MAX_DEPTH serves that purpose to some degree)? _

Re: [FFmpeg-devel] [PATCH] matroskadec: execute seekheads recursively

2014-10-16 Thread Rodger Combs
> On Oct 17, 2014, at 01:16, Rodger Combs wrote: > > This fixes https://trac.ffmpeg.org/ticket/3934 > <https://trac.ffmpeg.org/ticket/3934>, but I'm not sure if there was a good > reason for this to be here to begin with. Perhaps a protection against > infinit

Re: [FFmpeg-devel] [PATCH] matroskadec: execute seekheads recursively

2014-10-16 Thread Rodger Combs
> On Oct 17, 2014, at 01:52, Rodger Combs wrote: > > >> On Oct 17, 2014, at 01:16, Rodger Combs > <mailto:rodger.co...@gmail.com>> wrote: >> >> This fixes https://trac.ffmpeg.org/ticket/3934 >> <https://trac.ffmpeg.org/ticket/3934>, but I&#x

Re: [FFmpeg-devel] PATCH: Make -copyts a tri-state

2014-10-17 Thread Rodger Combs
> On Oct 15, 2014, at 06:00, Rodger Combs wrote: > > >> On Oct 15, 2014, at 05:37, Nicolas George wrote: >> >> Le quartidi 24 vendémiaire, an CCXXIII, Rodger Combs a écrit : >>> Discussed this briefly on IRC; decided this was a good idea. I'm not s

Re: [FFmpeg-devel] [PATCH] matroskadec: execute seekheads recursively

2014-10-19 Thread Rodger Combs
> On Oct 17, 2014, at 17:40, Michael Niedermayer wrote: > > On Fri, Oct 17, 2014 at 03:27:49PM +0200, Michael Niedermayer wrote: >> On Fri, Oct 17, 2014 at 01:55:35AM -0500, Rodger Combs wrote: >>> >>>> On Oct 17, 2014, at 01:52, Rodger Combs wrote: >>

Re: [FFmpeg-devel] PATCH: Make -copyts a tri-state

2014-10-20 Thread Rodger Combs
> On Oct 17, 2014, at 03:19, Rodger Combs wrote: > >> >> On Oct 15, 2014, at 06:00, Rodger Combs > <mailto:rodger.co...@gmail.com>> wrote: >> >> >>> On Oct 15, 2014, at 05:37, Nicolas George wrote: >>> >>> Le quartidi 2

Re: [FFmpeg-devel] PATCH: Make -copyts a tri-state

2014-10-20 Thread Rodger Combs
> On Oct 20, 2014, at 20:42, Michael Niedermayer wrote: > > On Mon, Oct 20, 2014 at 06:50:12PM -0500, Rodger Combs wrote: >> >>> On Oct 17, 2014, at 03:19, Rodger Combs wrote: >>> >>>> >>>> On Oct 15, 2014, at 06:00

Re: [FFmpeg-devel] [PATCH] matroskadec: execute seekheads recursively

2014-10-20 Thread Rodger Combs
> On Oct 19, 2014, at 23:34, Rodger Combs wrote: > > >> On Oct 17, 2014, at 17:40, Michael Niedermayer > <mailto:michae...@gmx.at>> wrote: >> >> On Fri, Oct 17, 2014 at 03:27:49PM +0200, Michael Niedermayer wrote: >>> On Fri, Oct

Re: [FFmpeg-devel] [PATCH] matroskadec: execute seekheads recursively

2014-10-22 Thread Rodger Combs
> On Oct 21, 2014, at 19:19, Carl Eugen Hoyos wrote: > > Rodger Combs gmail.com> writes: > >> This fixes https://trac.ffmpeg.org/ticket/3934 but I'm >> not sure if there was a good reason for this to be >> here to begin with. Perhaps a protection ag

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Fix cluster parsing loop which gathers seek information

2014-10-22 Thread Rodger Combs
> On Oct 21, 2014, at 21:38, Michael Niedermayer wrote: > > Fixes Ticket2263 > Fixes Ticket3934 > > Signed-off-by: Michael Niedermayer > --- > libavformat/matroskadec.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matro

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Fix cluster parsing loop which gathers seek information

2014-10-22 Thread Rodger Combs
> On Oct 22, 2014, at 08:01, wm4 wrote: > > On Wed, 22 Oct 2014 06:09:10 -0500 > Rodger Combs wrote: > >> >>> On Oct 21, 2014, at 21:38, Michael Niedermayer wrote: >>> >>> Fixes Ticket2263 >>> Fixes Ticket3934 >>>

<    1   2   3   4   5   6   7   8   >