Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-10-27 Thread Reynaldo H. Verdejo Pinochet
ith a commitment not break our own apps. The server will be fixed to work using public API in the process. I can work on this with whoever wants to help. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group - Samsung Research America ___ ffmpeg-

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-10-27 Thread Reynaldo H. Verdejo Pinochet
I understand you might be upset but please refrain from using bad language. The way I see it your removal will happen once there's a solution in place just not before. This is why the patch is not rejected. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group - Samsung Research Am

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-10-27 Thread Reynaldo H. Verdejo Pinochet
Hello On 10/27/2016 11:25 AM, James Almer wrote: [..] This is not how things were agreed. I haven't agreed to this. The patch fixes nothing while breaking master for ffserver users. There's a way forward, but the patch can't be applied before it happens. Bests, -- Reyn

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-10-28 Thread Reynaldo H. Verdejo Pinochet
release. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group - Samsung Research America ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] news: add final report for summer of code 2016

2016-10-30 Thread Reynaldo H. Verdejo Pinochet
Thanks for the comments and corrections. Fixed the typos and pushed as: commit f06598a8e1fcccef8c38a657162db309773d1515 Author: Reynaldo H. Verdejo Pinochet Date: Sun Oct 30 01:37:26 2016 -0700 news: add final report for summer of code 2016 Bests, -- Reynaldo H. Verdejo Pinochet Open

Re: [FFmpeg-devel] [PATCH 0/2] Move show_*() code from cmdutils to libs

2016-11-04 Thread Reynaldo H. Verdejo Pinochet
from me. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group - Samsung Research America ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] Move av_show_help_children() to avutil/opt

2016-11-07 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/07/2016 01:34 PM, Andreas Cadhalpun wrote: [...] Isn't the causality the other way around? Because ffserver uses internal API it was decided to remove it. If it gets fixed, there is no point in removing it, or is there? [..] I see no reason to remove it if it works properly. Bests,

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffserver: get time_base from AVStream in print_stream_params()

2016-11-08 Thread Reynaldo H. Verdejo Pinochet
On 11/08/2016 06:29 AM, James Almer wrote: [..] Right now it just returns st->codec->time_base, but after st->codec is deprecated it will be adapted to use st->internal->avctx->time_base. Perfect! Will do. Thanks for the hint James. Bests, -- Reynaldo H. Verdejo Pi

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-28 Thread Reynaldo H. Verdejo Pinochet
On 11/26/2016 01:00 PM, Rostislav Pehlivanov wrote: [..] Since a month has passed, reynaldo still hasn't responded, I think it's This is not correct. I have been working on weeding out it's private API usage problems. Last commit to this effect is from 3 weeks ago. Bests,

Re: [FFmpeg-devel] [PATCH 1/3] ffserver: drop FeedData, its unused

2016-11-28 Thread Reynaldo H. Verdejo Pinochet
Looks good. Thank you! Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group - Samsung Research America ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffserver: Remove last use of AVStream size

2016-11-28 Thread Reynaldo H. Verdejo Pinochet
Hi Michael Looks good too. Please feel free to push alongside the ones on the "Remove use of AVStream.." thread. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group - Samsung Research America ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] [PATCH 1/2] tests/ffserver-regression.sh: give wget a timeout and prevent retries

2016-11-29 Thread Reynaldo H. Verdejo Pinochet
Both OK. Thanks. -- Reynaldo H. Verdejo Pinochet Open Source Group - Samsung Research America ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] tests: print errors from ffserver

2016-11-29 Thread Reynaldo H. Verdejo Pinochet
/feed1.ffm -$target_exec ${target_path}/ffserver${PROGSUF} -d -f "$2" 2> /dev/null & +$target_exec ${target_path}/ffserver${PROGSUF} -d -f "$2" & FFSERVER_PID=$! echo "Waiting for feeds to startup..." sleep 2 -- Reynaldo H. Verdejo Pi

Re: [FFmpeg-devel] [PATCH] ffserver: Add client requested urls to the status page

2016-11-29 Thread Reynaldo H. Verdejo Pinochet
tat 2>/dev/null do_md5sum ff-stat >>ffserver.regression ) kill $FFSERVER_PID diff --git a/tests/ffserver.regression.ref b/tests/ffserver.regression.ref index ec7b37c..8629d52 100644 --- a/tests/ffserver.regression.ref +++ b/tests/ffserver.regressio

Re: [FFmpeg-devel] [PATCH] ffserver: set format bitexact flag, eliminate warnings about it not being set

2016-12-01 Thread Reynaldo H. Verdejo Pinochet
Looks good & works correctly Michael. Please feel free to push. Thank you. On 12/01/2016 09:02 AM, Michael Niedermayer wrote: if (src->codec->flags & AV_CODEC_FLAG_BITEXACT) +c->pfmt_ctx->flags |= AVFMT_FLAG_BITEXACT; -- Reynaldo H. Verdejo Pinochet Open So

Re: [FFmpeg-devel] [PATCH 1/6] tests/ffserver.regression.ref: Update ffserver checksums

2016-12-01 Thread Reynaldo H. Verdejo Pinochet
-test_h.avi +e28ba75853caf975e06d92955c9f7f73 *ff-test_l.avi a767dbdf5d1bded3450279f812f97b37 *ff-test.swf dc16f607e13328a832e73801cd21ec98 *ff-test_h.asf 69337d6c8cd7ac7e626338decdbf41d3 *ff-test_l.asf -- Reynaldo H. Verdejo Pinochet Open Source Group - Samsung Research America

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-12-04 Thread Reynaldo H. Verdejo Pinochet
I support the decision to keep ffserver Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group - Samsung Research America ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] GSoC 2017 MPEG-4 ALS codec project

2017-02-27 Thread Reynaldo H. Verdejo Pinochet
On 02/19/2017 09:30 AM, Thilo Borgmann wrote: [..] Although, be aware that the list of accepted organizations is yet to be published - we do not know yet if FFmpeg will be part of GSoC 2017. We can confirm this now. Participating orgs were announced today. Good luck with your quali George!

Re: [FFmpeg-devel] Google Summer of Code

2017-03-03 Thread Reynaldo H. Verdejo Pinochet
Hi Vidur. Please double check you got Paul's email as it might contain additional information. However, the generalities of the program are documented in the following webpage. Please do take a look at it if you haven't already: https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2017 Bests, -

Re: [FFmpeg-devel] [PATCH] ffserver: deprecate Port and BindAddress options in favor of HTTPPort and HTTPBindAddress

2014-08-14 Thread Reynaldo H. Verdejo Pinochet
On 08/02/2014 10:40 AM, Stefano Sabatini wrote: The new option names are more explicit. --- [..] Looks OK Bests, -- Reynaldo H. Verdejo Pinochet Sr. Multimedia Engineer, Open Source Group Samsung Research America - Silicon Valley ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffserver: deprecate Port and BindAddress options in favor of HTTPPort and HTTPBindAddress

2014-08-17 Thread Reynaldo H. Verdejo Pinochet
&p); if (resolve_host(&my_http_addr.sin_addr, arg) != 0) { ERROR("%s:%d: Invalid host/IP address: %s\n", arg); -- Reynaldo H. Verdejo Pinochet Sr. Multimedia Engineer, Open Source Group Samsung Research America - Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] web/contact: clarify mailing list descriptions

2014-09-13 Thread Reynaldo H. Verdejo Pinochet
On 09/12/2014 09:07 PM, Lou Logan wrote: > [..] > How should it be worded to be less confusing? > [..] No bug reports without patches? or "Not for bug reports unless you are including a patch that fixes the problem"? -- Reynaldo ___ ffmpeg-devel mail

[FFmpeg-devel] Please help update tasks and mentor/backups for OPW

2014-09-25 Thread Reynaldo H. Verdejo Pinochet
Hello As you might already know, Samsung has decided to back up our initiative with the required 6K USD (Thanks!) and as result, we have got at least one mentee covered for this round of the Outreach Program for Women (http://gnome.org/opw/). We couldn't be happier about this but there's quite som

[FFmpeg-devel] [PATCH 2/2] libavfilter/af_channelmap: avoid derreferencing possible null

2014-09-26 Thread Reynaldo H. Verdejo Pinochet
ff_all_channel_layouts() might return null on alloc failure. Fixes CID1241517 Signed-off-by: Reynaldo H. Verdejo Pinochet --- libavfilter/af_channelmap.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_channelmap.c b/libavfilter/af_channelmap.c index

[FFmpeg-devel] [PATCH 1/2] libavfilter/af_join: avoid derreferencing possible null

2014-09-26 Thread Reynaldo H. Verdejo Pinochet
ff_all_channel_layouts() might return null on alloc failure. Fixes CID1241518 Signed-off-by: Reynaldo H. Verdejo Pinochet --- libavfilter/af_join.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavfilter/af_join.c b/libavfilter/af_join.c index 560c5c8..a1717c6

[FFmpeg-devel] [PATCH] libavfilter/af_amix: avoid derreferencing possible null

2014-09-26 Thread Reynaldo H. Verdejo Pinochet
ff_all_channel_layouts() might return null on alloc failure. Fixes CID1241516 Signed-off-by: Reynaldo H. Verdejo Pinochet --- libavfilter/af_amix.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_amix.c b/libavfilter/af_amix.c index d8a6651..47cbb45

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/af_join: avoid derreferencing possible null

2014-09-26 Thread Reynaldo H. Verdejo Pinochet
Set pushed. Thanks for taking a look. -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavfilter/af_amix: avoid derreferencing possible null

2014-09-26 Thread Reynaldo H. Verdejo Pinochet
Pushed. Thanks for taking a look. -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Please help update tasks and mentor/backups for OPW

2014-09-27 Thread Reynaldo H. Verdejo Pinochet
Hello As you might already know, Samsung has decided to back up our initiative with the required 6K USD (Thanks!) and as result, we have got at least one mentee covered for this round of the Outreach Program for Women (http://gnome.org/opw/). We couldn't be happier about this but there's quite som

[FFmpeg-devel] [OPW 201412] Please help track ongoing qualification tasks

2014-10-06 Thread Reynaldo H. Verdejo Pinochet
forgot, it's the Qualification Mentor's task to suggest that number, Guess Michael can have a run at them latter and correct any wrongs. Please do reserve some time to keep the table updated. Thanks for all your help ppl! Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group S

Re: [FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-08 Thread Reynaldo H. Verdejo Pinochet
if (!s->refreshctx){ > +ff_thread_finish_setup(ctx); > +} Surrounding code does not use braces for single statement if()s, please drop them. CCing Clement so he can comment on the validity of the change otherwise. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group S

Re: [FFmpeg-devel] [PATCH] vp9:enable multi-thread decoding when refreshctx is equal to 0

2014-10-10 Thread Reynaldo H. Verdejo Pinochet
27;t meent the standards, I can change it again. The new patch is attached, please check if there is any point needs to be modified. Pushed. Thanks for your patch Di Wu Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Sili

Re: [FFmpeg-devel] [PATCH] mpegts: add the judgement if a new program is ctreated successfully

2014-10-16 Thread Reynaldo H. Verdejo Pinochet
Hello Di Wu On 10/15/2014 05:24 AM, di1028...@samsung.com wrote: From: Di Wu Add the judement after create a new program to avoid segment fault. [..] Thanks for your patch. Can you spell check your commit summary though?, you have at least two typos there. Thanks, -- Reynaldo H. Verdejo

Re: [FFmpeg-devel] [PATCH 1/4] ffserver: move configuration code to separate file

2014-10-22 Thread Reynaldo H. Verdejo Pinochet
Config parsing changeset LGTM. Feel free to push. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/4] ffserver_config: clean up variable initialization

2014-10-22 Thread Reynaldo H. Verdejo Pinochet
On 10/21/2014 07:10 AM, Stefano Sabatini wrote: > [..] > > LGTM. Agree. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://f

Re: [FFmpeg-devel] [PATCH 3/4] ffserver_conf: factorize parse function per config tag

2014-10-22 Thread Reynaldo H. Verdejo Pinochet
Feel free to push after removing the explicit/redundant initialization of FFServerConfig config as Reimar suggested. While you are at this though, can you remove braces on single statement ifs? appreciated. Thanks -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-22 Thread Reynaldo H. Verdejo Pinochet
.video_opts = NULL, > +.video_conf = NULL, > +.audio_opts = NULL, > +.audio_conf = NULL, > +.video_preset = NULL, > +.audio_preset = NULL, > }; > Guess you are already considered dropping the explicit initialization code as Reimaer suggested. Looks good othe

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-23 Thread Reynaldo H. Verdejo Pinochet
t3(avcodec_find_encoder(config->video_id)); > +if (config->video_preset && > +ffserver_opt_preset(arg, video_enc, > AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_ENCODING_PARAM, > +NULL, NULL) < 0) > +

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-10-30 Thread Reynaldo H. Verdejo Pinochet
emonize yes/no toggle should be enough but I'm OK either way in the context of this patch. Binathi: As an added bonus, try adding an -s to your commit command line so you get the Signed-off-by: line added, this is customary. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung

Re: [FFmpeg-devel] [PATCH 1/4] ffserver_config: drop requirement video size being multiple of 16

2014-11-01 Thread Reynaldo H. Verdejo Pinochet
f 16\n"); > [..] OK if always safe. Otherwise demote to WARNING() Feel free to push otherwise. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/4] ffserver_config: drop presets support

2014-11-01 Thread Reynaldo H. Verdejo Pinochet
Patch seems OK but I'm missing on the rationalle behind dropping the preset support. Can you elaborate? Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-

Re: [FFmpeg-devel] [PATCH 3/4] ffserver_config: improve error handling

2014-11-01 Thread Reynaldo H. Verdejo Pinochet
ax_size = (int64_t)fsize; > if (feed->feed_max_size < FFM_PACKET_SIZE*4) > @@ -876,11 +878,15 @@ static int ffserver_parse_config_stream(FFServerConfig > *config, const char *cmd, > stream->is_multicast = 1; > stream->loo

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: dont pass pointer to enum as pointer to int

2014-11-01 Thread Reynaldo H. Verdejo Pinochet
Looks OK. Feel free to push. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] ffserver_config: improve error handling

2014-11-01 Thread Reynaldo H. Verdejo Pinochet
its latter on. > > OK, will do that locally. > Thanks. Feel free to push afterward. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/4] ffserver_config: drop presets support

2014-11-01 Thread Reynaldo H. Verdejo Pinochet
Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffserver_config: improve AVOption handing

2014-11-02 Thread Reynaldo H. Verdejo Pinochet
/* Used internally to test AVOptions, not > to be used anywere else */ s/anywere/anywhere/g nit: . Not to be Looks OK, feel free to push after fixing ^ Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] FFserver bug?

2014-11-02 Thread Reynaldo H. Verdejo Pinochet
Hi. I'm afraid I don't understand what the problem is. Can someone elaborate? Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-03 Thread Reynaldo H. Verdejo Pinochet
rr on the above condition? Please double check. >> +close(fd); Above block needs to be re-indented. Also, check for failures in open and dup2() and react accordingly. I think Nicolas mentioned this already. >> + >> +} >> +} >>

Re: [FFmpeg-devel] [PATCH] ffserver_config: report not closed last tag

2014-11-08 Thread Reynaldo H. Verdejo Pinochet
Looks good. Thanks. Feel free to push. -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-11 Thread Reynaldo H. Verdejo Pinochet
recent checkout of master. For future reference, you need to do this every time you send a patch over. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 6/9] ffserver_config: handle codec private options

2014-11-11 Thread Reynaldo H. Verdejo Pinochet
gt;guessed_audio_codec_id : AV_CODEC_ID_AAC; +break; +case AVMEDIA_TYPE_VIDEO: +id = config->guessed_video_codec_id != AV_CODEC_ID_NONE ? config->guessed_video_codec_id : AV_CODEC_ID_H264; +break; + default: +

Re: [FFmpeg-devel] [PATCH 6/9] ffserver_config: handle codec private options

2014-11-16 Thread Reynaldo H. Verdejo Pinochet
Hi Lukasz. Sry for the delay at answering, been traveling the whole week. Patch looks OK, feel free to push. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffserver_config: do not store preset name

2014-11-16 Thread Reynaldo H. Verdejo Pinochet
Looks. OK. Feel free to push after some testing. Can't try it out right now but seems harmless. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpe

Re: [FFmpeg-devel] [PATCH] ffserver_config: fix possible crash

2014-11-16 Thread Reynaldo H. Verdejo Pinochet
OK to push. Thanks. -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 01/11] ffserver_config: cosmetic: simplify functions calls.

2014-11-17 Thread Reynaldo H. Verdejo Pinochet
Looks Good. Feel free to push. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 02/11] ffserver_config: cosmetic: move line_num into FFServerConfig

2014-11-17 Thread Reynaldo H. Verdejo Pinochet
OK to push too. -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-17 Thread Reynaldo H. Verdejo Pinochet
2 files changed, 69 insertions(+), 170 deletions(-) > > @Reynaldo, you may check the test I submitted, and the comments, you may > then have just high level review, not bother if mapping between options > is ok Will do. Thanks for the hint. I should be able to take a look at this and the re

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
_rate.num, 0) < 0 || > -av_dict_set_int(&config->video_conf, "VideoFrameRateDen", > frame_rate.den, 0) < 0) > +else { > +if ((w % 2) || (h % 2)) Drop the redundant () across %. Also, please make an effort to break lines at

Re: [FFmpeg-devel] [PATCH 04/11] ffserver_config: remove ffserver_apply_stream_config function

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
ckers. As a general comment, I would avoid the grammatical "!!!"s and such to denote severity. We have the log categories for that. This is also just a tip, not something you need to change. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley __

Re: [FFmpeg-devel] [PATCH 05/11] ffserver: allow skip setting defaults

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
d simplify the code a bit too, avoiding checking for the two and imposing a precedence, which is not always documented. What do you think? This happens twice on this patch IIRC. Otherwise seems OK to push. Bests, -- Reynaldo H. Verdejo Pinochet Open So

Re: [FFmpeg-devel] [PATCH 06/11] [WIP][RFC]tools: add ffserver_config_test

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
{ You seem to use an space before ( for if/while/for. Add it here. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 06/11] [WIP][RFC]tools: add ffserver_config_test

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
st > as these two *.o are not treated as dependencies. I don't know where to > place it in general, so I could use some help. > For build/test system integration, see my previous answer on this same thread. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Sa

Re: [FFmpeg-devel] [PATCH 08/11] ffserver: export recommented encoder configuration

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
t a blocker of course. Looks OK otherwise. Feel free to push after confirming ^ Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 05/11] ffserver: allow skip setting defaults

2014-11-18 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/18/2014 06:54 PM, Nicolas George wrote: > L'octidi 28 brumaire, an CCXXIII, Reynaldo H. Verdejo Pinochet a > écrit : >> I think I commented about this before but having yesvar & novar >> options seems redundant. Having var = yes or no if absent (or >>

Re: [FFmpeg-devel] [PATCH 05/11] ffserver: allow skip setting defaults

2014-11-21 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/20/2014 10:09 PM, Lukasz Marek wrote: > On 18.11.2014 23:25, Reynaldo H. Verdejo Pinochet wrote: >> [..] >> I do think undefined behavior should be avoided if possible >> without too much hassle, so if we go with the former I would >> appreciate doc ent

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-21 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/20/2014 10:14 PM, Lukasz Marek wrote: > On 18.11.2014 21:35, Reynaldo H. Verdejo Pinochet wrote: > [...] > Also, please make an effort >> to break lines at 80 chars as long as it doesn't make the >> code harder to read. This seems particularly possible on th

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-21 Thread Reynaldo H. Verdejo Pinochet
On 11/21/2014 07:17 PM, Reynaldo H. Verdejo Pinochet wrote: > [..] > suggestion many avid by. s/avid by/follow/g ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 05/11] ffserver: allow skip setting defaults

2014-11-23 Thread Reynaldo H. Verdejo Pinochet
g->stream_use_defaults = 2; > } else { > ERROR("Invalid entry '%s' inside \n", cmd); > } I think these should be WARNING()s. Patch looks good otherwise. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] ffserver: dont leak pb_buffer

2014-11-26 Thread Reynaldo H. Verdejo Pinochet
Feel free to push please. Thanks a lot -- Reynaldo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] ffserver: dont leak child arguments

2014-11-26 Thread Reynaldo H. Verdejo Pinochet
Hi On 11/20/2014 08:51 PM, Lukasz Marek wrote: > [..] >> } >> diff --git a/ffserver_config.c b/ffserver_config.c >> index 02c8431..a235142 100644 >> --- a/ffserver_config.c >> +++ b/ffserver_config.c >> @@ -31,6 +31,8 @@ >> #include "cmdutils.h" >> #include "ffserver_config.h" >> >> +#de

Re: [FFmpeg-devel] [PATCH 08/11] ffserver: export recommented encoder configuration

2014-11-26 Thread Reynaldo H. Verdejo Pinochet
Hi Lukasz. Sorry for the delay. Patch looks good. Feel free to push. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-26 Thread Reynaldo H. Verdejo Pinochet
har *opt, int64_t arg, > + int type, FFServerConfig *config) > +{ > +char buf[30]; char buf[20] should be plenty considering INT64_MAX. Feel free to push after this minor fix unless someone else holds you. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Res

Re: [FFmpeg-devel] [PATCH 04/11] ffserver_config: remove ffserver_apply_stream_config function

2014-11-26 Thread Reynaldo H. Verdejo Pinochet
Hi. LGTM, feel free to push please. -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 06/11] [WIP][RFC]tools: add ffserver_config_test

2014-11-26 Thread Reynaldo H. Verdejo Pinochet
Hi Lukasz. Are you sending an updated patch for this one or I missed it somehow? -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH 06/11] [WIP][RFC]tools: add ffserver_config_test

2014-11-26 Thread Reynaldo H. Verdejo Pinochet
nks a lot! Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

2014-11-26 Thread Reynaldo H. Verdejo Pinochet
On 11/26/2014 07:52 PM, Lukasz Marek wrote: > [..] > > In fact 20 is too small. INT64_MIN has 19 digits, '-' sign and > terminating 0. So 21 is a minimum. I put 22, the same as av_dict_set_int. True, forgot about the sign. Go ahead after fixing please. Thanks, -

Re: [FFmpeg-devel] [PATCH] ffserver: use avcodec_copy_context to copy context

2014-12-02 Thread Reynaldo H. Verdejo Pinochet
Should be OK. Thanks. -- Reynaldo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] ffserver_config: remove useless defaults

2014-12-02 Thread Reynaldo H. Verdejo Pinochet
Looks OK. Feel free to push. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/3] ffserver_config: set defaults basing on absence of set value

2014-12-02 Thread Reynaldo H. Verdejo Pinochet
Looks OK too. -- Reynaldo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/3] ffserver_config: print warning when using default value

2014-12-02 Thread Reynaldo H. Verdejo Pinochet
OK to push too. Thanks a lot. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffserver: Use av_malloc_array()

2015-01-09 Thread Reynaldo H. Verdejo Pinochet
;= INT_MAX/sizeof(*avs) || > -!(avs = av_malloc(avc->nb_streams * sizeof(*avs > +if (!(avs = av_malloc_array(avc->nb_streams, sizeof(*avs)))) > goto sdp_done; > > for(i = 0; i < stream->nb_streams; i++) { > -- Reynaldo H. Verdejo Pinochet Open Sourc

Re: [FFmpeg-devel] ffserver jpg patch

2015-05-06 Thread Reynaldo H. Verdejo Pinochet
, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffserver: Check allocations (likely not all)

2015-06-06 Thread Reynaldo H. Verdejo Pinochet
Hi On 06/06/2015 10:43 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > ffserver.c | 20 > 1 file changed, 20 insertions(+) > > [..] Looks good. Thanks! Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsun

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: Extend API with avio_move() and avio_delete()

2015-06-22 Thread Reynaldo H. Verdejo Pinochet
esigning a solution that would let us have this functionality available for internal use while being maintainable , have good platform coverage, and be as uncluttered (use-case wise) as it can possibly be. Humbly, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Sili

[FFmpeg-devel] [PATCH] af_pan: avoid null dereference on query_formats()

2015-10-08 Thread Reynaldo H. Verdejo Pinochet
Fixes Coverity CID 1325680 Signed-off-by: Reynaldo H. Verdejo Pinochet --- libavfilter/af_pan.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/af_pan.c b/libavfilter/af_pan.c index 9117cc0..91cc434 100644 --- a/libavfilter/af_pan.c +++ b/libavfilter/af_pan.c @@ -239,6

Re: [FFmpeg-devel] [PATCH] af_pan: avoid null dereference on query_formats()

2015-10-08 Thread Reynaldo H. Verdejo Pinochet
Totally missed it. Thanks & please ignore. Proly a good idea to update entry at coverity.com though. Bests. -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-d

[FFmpeg-devel] [PATCH] news: add thank you note for telepoint/mediahub

2015-10-12 Thread Reynaldo H. Verdejo Pinochet
Signed-off-by: Reynaldo H. Verdejo Pinochet --- src/index | 33 + 1 file changed, 33 insertions(+) diff --git a/src/index b/src/index index 77946a4..4dec768 100644 --- a/src/index +++ b/src/index @@ -37,6 +37,39 @@ News + Telepoint & MediaHub are

Re: [FFmpeg-devel] [PATCH] ffserver: Fix memory leak and uncheked av_strdup return

2015-11-23 Thread Reynaldo H. Verdejo Pinochet
_() twice while we are at this. The check and re-get seems racy although it might not matter much in this context. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] [PATCH 2/2] ffserver_config: replace strtod by av_strtod and correct undefined behavior

2015-11-30 Thread Reynaldo H. Verdejo Pinochet
This one looks OK (pending a final decision on av_clipd64()) Bests, -- Reynaldo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] ffserver: Clear avio context after closing it

2015-11-30 Thread Reynaldo H. Verdejo Pinochet
On 11/01/2015 09:34 AM, Michael Niedermayer wrote: > [...] > --- a/ffserver.c > +++ b/ffserver.c > @@ -2366,6 +2366,7 @@ static int http_prepare_data(HTTPContext *c) > > av_freep(&c->pb_buffer); > len = avio_close_dyn_buf(ctx->pb, &c->pb_buffer); > +

[FFmpeg-devel] [PATCH] libavtuil: add version component accessor macros

2015-12-05 Thread Reynaldo H. Verdejo Pinochet
Pretty standard macros, these should help libav* users avoid repeating ver.si.on parsing code, which aids in compatibility-checking tasks like identifying FFmpeg from Libav (_MICRO >= 100 check). Something many are doing since we are not intercompatible anymore. Signed-off-by: Reynaldo H. Verd

Re: [FFmpeg-devel] [PATCH] libavtuil: add version component accessor macros

2015-12-05 Thread Reynaldo H. Verdejo Pinochet
On 12/05/2015 10:31 AM, Reynaldo H. Verdejo Pinochet wrote: > Pretty standard macros, these should help libav* > users avoid repeating ver.si.on parsing code, > which aids in compatibility-checking tasks like > identifying FFmpeg from Libav (_MICRO >= 100 check). Actually ran

Re: [FFmpeg-devel] [PATCH] libavtuil: add version component accessor macros

2015-12-06 Thread Reynaldo H. Verdejo Pinochet
On 12/05/2015 11:36 AM, Ganesh Ajjanagadde wrote: > [...] > > minor nit: commit message typo (libavtuil -> libavutil). > True. Corrected. Thanks for taking a look -- Reynaldo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/m

Re: [FFmpeg-devel] [PATCH] libavtuil: add version component accessor macros

2015-12-06 Thread Reynaldo H. Verdejo Pinochet
Pushed as: commit 21c34cb26154a5eadd6e10df86c20e2df3a7bd55 Author: Reynaldo H. Verdejo Pinochet Date: Fri Dec 4 14:07:23 2015 -0800 libavutil: add version component accessor macros [..] Thanks -- Reynaldo ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH]ffserver: Cast time_t value when using it in a format string.

2015-12-27 Thread Reynaldo H. Verdejo Pinochet
; http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-12 Thread Reynaldo H. Verdejo Pinochet
; 13 LGTM Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [ANNOUNCE] Outreachy (former OPW) application deadline

2015-04-05 Thread Reynaldo H. Verdejo Pinochet
/Outreachy/2015-05 If you have any questions regarding the program please get in touch with us at o...@ffmpeg.org By all means, please consider forwarding this information among your circles. Bests, -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America / Silicon Valley

Re: [FFmpeg-devel] [ANNOUNCE] Outreachy (former OPW) application deadline

2015-04-05 Thread Reynaldo H. Verdejo Pinochet
On 04/05/2015 01:46 PM, Reynaldo H. Verdejo Pinochet wrote: > Hi everyone > > OPW/Outreachy internships for this round are starting > in May and we are about to hit the deadline for applications > set for Tuesday next week. > [..] Deadline for applications has just been ex

Re: [FFmpeg-devel] FFmpeg OPW

2014-07-28 Thread Reynaldo H. Verdejo Pinochet
rom 857556764e2c3c09437bac19da69dce48a0b147d Mon Sep 17 00:00:00 2001 From: "Reynaldo H. Verdejo Pinochet" Date: Mon, 28 Jul 2014 17:32:16 -0400 Subject: [PATCH] web/news: OPW 2014 fundraiser --- src/index | 16 1 file changed, 16 insertions(+) diff --git a/src/index b/src/index index c20