Re: [FFmpeg-devel] [PATCH 1/2] h261, h263 decoders: convert to RL_VLC.

On Sun, Aug 31, 2014 at 09:24:24AM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Aug 31, 2014 at 8:54 AM, Reimar Döffinger > wrote: > > > On Sun, Aug 31, 2014 at 08:37:56AM -0400, Ronald S. Bultje wrote: > > > On Sun, Aug 31, 2014 at 8:27 AM, Reimar Döffinger

[FFmpeg-devel] [PATCH 3/4] ituh263dec: Optimize new RL_VLC based decoding.

Signed-off-by: Reimar Döffinger --- libavcodec/ituh263dec.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/libavcodec/ituh263dec.c b/libavcodec/ituh263dec.c index 26f0ec5..083f5ae 100644 --- a/libavcodec/ituh263dec.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 2/4] h261dec: Optimize new RL_VLC decoding.

Signed-off-by: Reimar Döffinger --- libavcodec/h261dec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c index 5f0eb59..f286d23 100644 --- a/libavcodec/h261dec.c +++ b/libavcodec/h261dec.c @@ -318,27 +318,25 @@ static int

[FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

Some additional optimizations in following patch. Signed-off-by: Reimar Döffinger --- libavcodec/flv.h| 1 - libavcodec/flvdec.c | 12 -- libavcodec/h261dec.c| 27 ++- libavcodec/ituh263dec.c | 58 - 4

[FFmpeg-devel] [PATCH 4/4] rl.h: remove deprecated and now unused vlc member.

--- libavcodec/mpeg12.c| 13 +++-- libavcodec/mpegvideo.c | 8 libavcodec/rl.h| 8 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c index 27d680f..cb00baf 100644 --- a/libavcodec/mpeg12.c +++ b/libavc

Re: [FFmpeg-devel] [PATCH 1/2] h261, h263 decoders: convert to RL_VLC.

On Sun, Aug 31, 2014 at 03:38:21PM +0200, Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 09:24:24AM -0400, Ronald S. Bultje wrote: > > On Sun, Aug 31, 2014 at 8:54 AM, Reimar Döffinger > > wrote: > > > > > I forgot to say: this is the first time I use this

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

On Sun, Aug 31, 2014 at 04:15:51PM +0200, wm4 wrote: > Well yes, it would be possible to loop over the entire probe buffer, > until it ends on a packet boundary, or there's a partial cut-off > packet. How exactly would you suggest the probe score? > > Personally, I'd probably do the following: if

Re: [FFmpeg-devel] *** GMX Spamverdacht *** [PATCH] libavdevice/v4l2: fix of crash caused by assert

On Wed, Aug 13, 2014 at 07:04:01PM +0400, Dmitry Volyntsev wrote: > From: Dmitry Volyntsev > > s->buffers_queued constantly decremented and not incremented > in case of (s->frame_size > 0 && buf.bytesused != s->frame_size) > condition (caught on long run capture of Logitech C310) > --- > libavde

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

On Sun, Aug 31, 2014 at 03:06:08PM +, Carl Eugen Hoyos wrote: > > Other formats are also relatively lazy > > Please point me to such a format, I would like to > fix it. > EXTENSION is ok for 32 bit, MAX is ok for 64bit. Sorry, I missed that EXTENSION is actually MAX/2 nowadays! That's quite

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

On Sun, Aug 31, 2014 at 05:44:09PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > > Some additional optimizations in following patch. > > what effect on speed do these patches have ? No idea at this point. If someone

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

On Sun, Aug 31, 2014 at 05:44:09PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > > Some additional optimizations in following patch. > > what effect on speed do these patches have ? With high error bars, with vsynth1 fi

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

On Sun, Aug 31, 2014 at 06:28:24PM +0200, Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 05:44:09PM +0200, Michael Niedermayer wrote: > > On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > > > Some additional optimizations in following patch. > > >

Re: [FFmpeg-devel] [PATCH] intmath.h: Remove duplicated ARM include.

On Sun, Aug 31, 2014 at 06:18:14PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 12:29:04PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavutil/intmath.h | 4 > > 1 file changed, 4 del

Re: [FFmpeg-devel] [PATCH] aacps_tablegen: replace TABLE_CONST by const.

On Sun, Aug 31, 2014 at 06:19:37PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 12:42:15PM +0200, Reimar Döffinger wrote: > > Doesn't change generated code, just is more consistent > > and a bit less error-prone. > > > > Signed-off-by: Reimar Dö

Re: [FFmpeg-devel] [PATCH 3/4] ituh263dec: Optimize new RL_VLC based decoding.

On Sun, Aug 31, 2014 at 07:09:13PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 04:48:43PM +0200, Reimar Döffinger wrote: > > @@ -549,11 +549,8 @@ retry: > > av_log(s->avctx, AV_LOG_ERROR, "run overflow at %dx%d i:%d\n", >

Re: [FFmpeg-devel] [PATCH 3/4] ituh263dec: Optimize new RL_VLC based decoding.

On Sun, Aug 31, 2014 at 08:14:04PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 08:06:54PM +0200, Reimar Döffinger wrote: > > On Sun, Aug 31, 2014 at 07:09:13PM +0200, Michael Niedermayer wrote: > > > On Sun, Aug 31, 2014 at 04:48:43PM +0200, Reim

[FFmpeg-devel] [PATCH] rl.h: Allocate temporary VLC tables instead of having them static.

Signed-off-by: Reimar Döffinger --- libavcodec/mpeg12.c| 23 --- libavcodec/mpegvideo.c | 14 ++ libavcodec/rl.h| 8 ++-- 3 files changed, 24 insertions(+), 21 deletions(-) diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c index cb00baf

Re: [FFmpeg-devel] [PATCH] rl.h: Allocate temporary VLC tables instead of having them static.

On Sun, Aug 31, 2014 at 08:27:17PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger This was intended to come out under "rl.h: remove deprecated and now unused vlc member.", as that one needs to be applied first. I can merge them though if desired. I by accident ty

[FFmpeg-devel] [PATCH] h261dec, ituh263dec: Avoid unnecessary -1 inside inner loop.

3646 -> 3597 decicycles in inner loop when decoding vsynth1-flv. Signed-off-by: Reimar Döffinger --- libavcodec/h261dec.c| 7 --- libavcodec/ituh263dec.c | 9 + 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c in

Re: [FFmpeg-devel] [PATCH] h261dec, ituh263dec: Avoid unnecessary -1 inside inner loop.

On Sun, Aug 31, 2014 at 12:23:48PM -0700, Timothy Gu wrote: > On Aug 31, 2014 11:36 AM, "Reimar Döffinger" > wrote: > > > > 3646 -> 3597 decicycles in inner loop when decoding > > vsynth1-flv. > > Wow. Note sure what way you meant it, but unfortunat

[FFmpeg-devel] [PATCH] h261dec, ituh263dec: ensure CLOSE_READER is done on error paths, too.

Signed-off-by: Reimar Döffinger --- libavcodec/h261dec.c| 2 ++ libavcodec/ituh263dec.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c index c9470b1..9b95775 100644 --- a/libavcodec/h261dec.c +++ b/libavcodec/h261dec.c

[FFmpeg-devel] [PATCH] mpegaudiodec: share identical tables between float and fixed decoder.

ff_mpa_table_4_3_value alone saves over 128kB. Signed-off-by: Reimar Döffinger --- libavcodec/Makefile| 24 +++--- libavcodec/mpegaudio_tablegen.c| 13 +-- libavcodec/mpegaudio_tablegen.h| 26 +++--- libavcodec/mpegaudiodec_common.c | 135

Re: [FFmpeg-devel] [PATCH] h261dec, ituh263dec: ensure CLOSE_READER is done on error paths, too.

On Sun, Aug 31, 2014 at 09:56:03PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 09:40:05PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/h261dec.c| 2 ++ > > libavcodec/ituh263dec.c | 4 ++-- > > 2

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

On Sun, Aug 31, 2014 at 09:32:45PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > > -code = get_vlc2(&s->gb, rl->vlc.table, TCOEFF_VLC_BITS, 2); > > -if (code < 0) { > >

[FFmpeg-devel] [PATCH] h261dec, ituh263dec: Move condition.

Stops compiler from doing incredibly stupid things. With vsynth1-flv inner loop goes from 3501 to 3275 decicycles. Signed-off-by: Reimar Döffinger --- libavcodec/h261dec.c| 12 ++-- libavcodec/ituh263dec.c | 10 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

On Sun, Aug 31, 2014 at 10:51:40PM +0200, Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 09:32:45PM +0200, Michael Niedermayer wrote: > > On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > > > -code = get_vlc2(&s->gb, rl->v

[FFmpeg-devel] [PATCH] ac3dec: avoid duplicating symbols between fixed and float decoder.

Signed-off-by: Reimar Döffinger --- libavcodec/ac3.h | 4 +- libavcodec/ac3dec.c | 188 +++ libavcodec/ac3dec_data.c | 138 ++ libavcodec/ac3dec_data.h | 15 4 files changed, 182 insertions(+), 163

Re: [FFmpeg-devel] [PATCH 1/4] h261, h263 decoders: convert to RL_VLC.

On Sun, Aug 31, 2014 at 04:48:41PM +0200, Reimar Döffinger wrote: > Some additional optimizations in following patch. All pushed except for the last one (4/4). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listi

Re: [FFmpeg-devel] [PATCH v4] Add SUP/PGS subtitle demuxer

On Mon, Sep 01, 2014 at 12:05:23AM +0200, wm4 wrote: > +for (nb_packets = 0; nb_packets < 10; nb_packets++) { > +size_t full_packet_size; > +if (buf_size < 10 + 3) > +break; > +if (memcmp(buf, "PG", 2)) > +return 0; AV_RB16(buf) != SUP_PGS_MAGIC

Re: [FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

On 01.09.2014, at 00:34, wm4 wrote: > --- > Use AV_RB16 instead of memcpy. > Don't use AVPROBE_SCORE_EXTENSION. Looks good to me, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] mpegaudiodec: share identical tables between float and fixed decoder.

On 01.09.2014, at 02:01, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 10:47:09PM +0200, Reimar Döffinger wrote: >> ff_mpa_table_4_3_value alone saves over 128kB. > > i wonder if that table shouldnt be something different in the float > implementation. > Also i thin

Re: [FFmpeg-devel] [PATCH] rl.h: Allocate temporary VLC tables instead of having them static.

On 01.09.2014, at 02:35, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 08:27:17PM +0200, Reimar Döffinger wrote: >> >> { >> int i, q; >> +VLC vlc; > >> +init_vlc(&vlc, 9, rl->n + 1, &rl->table_vlc[0][1], 4, 2, >> &

Re: [FFmpeg-devel] [PATCH] rl.h: Allocate temporary VLC tables instead of having them static.

On 1 September 2014 12:05:00 CEST, Michael Niedermayer wrote: >On Mon, Sep 01, 2014 at 09:32:56AM +0200, Reimar Döffinger wrote: >> On 01.09.2014, at 02:35, Michael Niedermayer >wrote: >> > On Sun, Aug 31, 2014 at 08:27:17PM +0200, Reimar Döffinger wrote: >> >

Re: [FFmpeg-devel] [PATCH] h261dec, ituh263dec: Avoid unnecessary -1 inside inner loop.

On Mon, Sep 01, 2014 at 03:01:15PM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 08:36:01PM +0200, Reimar Döffinger wrote: > > 3646 -> 3597 decicycles in inner loop when decoding > > vsynth1-flv. > > > > Signed-off-by: Reimar Döffinger > >

Re: [FFmpeg-devel] [PATCH] h261dec, ituh263dec: Move condition.

On Mon, Sep 01, 2014 at 02:35:38AM +0200, Michael Niedermayer wrote: > On Sun, Aug 31, 2014 at 11:02:34PM +0200, Reimar Döffinger wrote: > > Stops compiler from doing incredibly stupid things. > > With vsynth1-flv inner loop goes from 3501 to 3275 > > decicycles. > >

Re: [FFmpeg-devel] [PATCH] mpegaudiodec: share identical tables between float and fixed decoder.

On Mon, Sep 01, 2014 at 11:50:18AM +0200, Michael Niedermayer wrote: > On Mon, Sep 01, 2014 at 09:30:04AM +0200, Reimar Döffinger wrote: > > On 01.09.2014, at 02:01, Michael Niedermayer wrote: > > > On Sun, Aug 31, 2014 at 10:47:09PM +0200, Reimar Döffinger wrote: > > &

Re: [FFmpeg-devel] [PATCH] h261dec, ituh263dec: ensure CLOSE_READER is done on error paths, too.

On Sun, Aug 31, 2014 at 10:50:16PM +0200, Reimar Döffinger wrote: > On Sun, Aug 31, 2014 at 09:56:03PM +0200, Michael Niedermayer wrote: > > On Sun, Aug 31, 2014 at 09:40:05PM +0200, Reimar Döffinger wrote: > > > Signed-off-by: Reimar Döffinger > > > --- > &g

Re: [FFmpeg-devel] Implementation od fixed point AAC decoder

On Mon, Sep 01, 2014 at 07:55:38PM +0200, Nedeljko Babic wrote: > > Hello, > > I am sending new patch set with the implementation of fixed point AAC decoder. > > Most of the requests from review of float emulation done by Reimar are > integrated in this patch set. That at least doesn't include

Re: [FFmpeg-devel] [PATCH 02/14] libavcodec: Implementation of AAC_fixed_decoder (LC-module) [2/5]

On Mon, Sep 01, 2014 at 07:55:40PM +0200, Nedeljko Babic wrote: > +/* Rounding to zero used for simplicity */ > +static av_always_inline aac_float_t float_add(aac_float_t a, aac_float_t b) > +{ > +int diff; > + > +if (a.mant == 0) > +return b; > + > +if (b.mant == 0) > +

[FFmpeg-devel] [PATCH] rl.h: Use on-stack temporary VLC tables instead of having them static.

Signed-off-by: Reimar Döffinger --- libavcodec/mpeg12.c| 21 ++--- libavcodec/mpegvideo.c | 12 libavcodec/rl.h| 8 ++-- 3 files changed, 20 insertions(+), 21 deletions(-) diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c index cb00baf..37f6fe4

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: fix of crash caused by assert

On Mon, Sep 01, 2014 at 10:33:15PM +0200, Giorgio Vazzana wrote: > +static int enqueue_buffer(struct video_data *s, struct v4l2_buffer *buf) > +{ > +int res = 0; > + > +if (v4l2_ioctl(s->fd, VIDIOC_QBUF, buf) < 0) { > +res = AVERROR(errno); > +av_log(NULL, AV_LOG_ERROR, "ioc

Re: [FFmpeg-devel] [PATCH] rl.h: Use on-stack temporary VLC tables instead of having them static.

On Mon, Sep 01, 2014 at 10:19:36PM +0200, Michael Niedermayer wrote: > On Mon, Sep 01, 2014 at 08:59:43PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/mpeg12.c| 21 ++--- > > libavcodec/mpegvideo.c | 12 +

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: fix of crash caused by assert

On Mon, Sep 01, 2014 at 11:00:14PM +0200, Giorgio Vazzana wrote: > 2014-09-01 22:46 GMT+02:00 Reimar Döffinger : > > On Mon, Sep 01, 2014 at 10:33:15PM +0200, Giorgio Vazzana wrote: > >> +static int enqueue_buffer(struct video_data *s, struct v4l2_buffer *buf) > >&g

Re: [FFmpeg-devel] [PATCH] rl.h: Use on-stack temporary VLC tables instead of having them static.

On Mon, Sep 01, 2014 at 10:59:51PM +0200, Reimar Döffinger wrote: > On Mon, Sep 01, 2014 at 10:19:36PM +0200, Michael Niedermayer wrote: > > On Mon, Sep 01, 2014 at 08:59:43PM +0200, Reimar Döffinger wrote: > > > Signed-off-by: Reimar Döffinger > > > --- > &g

[FFmpeg-devel] [PATCH] rangecoder-test: Allow running with small stack size.

Signed-off-by: Reimar Döffinger --- libavcodec/rangecoder.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/rangecoder.c b/libavcodec/rangecoder.c index 69150a5..29fb909 100644 --- a/libavcodec/rangecoder.c +++ b/libavcodec/rangecoder.c @@ -120,11 +120,12

[FFmpeg-devel] [PATCH] vf_deshake: reduce stack usage.

Signed-off-by: Reimar Döffinger --- libavfilter/deshake.h| 3 +++ libavfilter/vf_deshake.c | 13 + 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavfilter/deshake.h b/libavfilter/deshake.h index f61ed80..20df88f 100644 --- a/libavfilter/deshake.h +++ b

[FFmpeg-devel] [PATCH] vf_deshake: Avoid doing a malloc+free for every single frame.

Signed-off-by: Reimar Döffinger --- libavfilter/deshake.h| 2 ++ libavfilter/vf_deshake.c | 10 ++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/libavfilter/deshake.h b/libavfilter/deshake.h index 20df88f..62e81c3 100644 --- a/libavfilter/deshake.h +++ b/libavfilter

Re: [FFmpeg-devel] [PATCH] rangecoder-test: Allow running with small stack size.

On Tue, Sep 02, 2014 at 01:48:09AM +0200, Michael Niedermayer wrote: > On Mon, Sep 01, 2014 at 11:26:06PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/rangecoder.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 del

Re: [FFmpeg-devel] [PATCH] vf_deshake: reduce stack usage.

On Tue, Sep 02, 2014 at 01:54:38AM +0200, Michael Niedermayer wrote: > On Mon, Sep 01, 2014 at 11:36:52PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavfilter/deshake.h| 3 +++ > > libavfilter/vf_deshake.c | 13 +-

Re: [FFmpeg-devel] [PATCH] vf_deshake: Avoid doing a malloc+free for every single frame.

On Tue, Sep 02, 2014 at 01:55:20AM +0200, Michael Niedermayer wrote: > On Mon, Sep 01, 2014 at 11:49:28PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavfilter/deshake.h| 2 ++ > > libavfilter/vf_deshake.c | 10 ++-

Re: [FFmpeg-devel] [PATCH] rl.h: Use on-stack temporary VLC tables instead of having them static.

On Mon, Sep 01, 2014 at 08:59:43PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/mpeg12.c| 21 ++--- > libavcodec/mpegvideo.c | 12 > libavcodec/rl.h| 8 ++-- > 3 files changed, 20 insertion

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

On Tue, Sep 02, 2014 at 05:03:56PM +0200, Michael Niedermayer wrote: > On Tue, Sep 02, 2014 at 01:52:24PM +0200, Jörg Krause wrote: > > > > > > Am 02.09.2014 12:40 schrieb Michael Niedermayer: > > >On Tue, Sep 02, 2014 at 12:33:26PM +0200, Jörg Krause wrote: > > >>Add the feature test macro which

Re: [FFmpeg-devel] Redirecting MP4 muxed data to socket using movflags resets timestamp

On Tue, Sep 02, 2014 at 04:42:09PM +0530, Parth Shah wrote: > My question is why this timestamps gets changed? Is thereant method to send > MP4 file over socket without changing its timestamp? > > > Any help or advice? Thank you in advance. This belongs on ffmpeg-user. Plus, I'd suggest reconsid

[FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

A bit more complex than e.g. adding it to the context, but using the context for something that will be used only during initialization seemed a bit wasteful. Signed-off-by: Reimar Döffinger --- libavcodec/ffv1enc.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a

[FFmpeg-devel] [PATCH] ffv1dec: Avoid unnecessarily large stack usage and copies.

Ideally the compiler could figure this out on its own, but it seems it can't. An alternative that would avoid the messy explicit memcpy would be to use a sub-struct for the parts that should be preserved, which can then simply be assigned. Signed-off-by: Reimar Döffinger --- libav

Re: [FFmpeg-devel] [PATCH 1/4] avformat/assdec: UTF-16 support

On Tue, Sep 02, 2014 at 08:56:09PM +0200, wm4 wrote: > Use the UTF-16 BOM to detect UTF-16 encoding. Convert the file contents > to UTF-8 on the fly using FFTextReader, which acts as converting wrapper > around AVIOContext. It also can work on a static buffer, needed for > format probing. The FFTex

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

On Tue, Sep 02, 2014 at 08:58:50PM +0200, wm4 wrote: > On Tue, 2 Sep 2014 20:32:57 +0200 > Reimar Döffinger wrote: > > @@ -933,6 +938,7 @@ static av_cold int encode_init(AVCodecContext *avctx) > > } > > } > > } >

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

On Tue, Sep 02, 2014 at 09:28:27PM +0200, wm4 wrote: > On Tue, 2 Sep 2014 21:18:24 +0200 > Reimar Döffinger wrote: > > So I'd prefer to avoid it. However there is the question of which > > code mess/benefit ratio we want to accept. > > I don't see anything w

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

On Tue, Sep 02, 2014 at 09:28:27PM +0200, wm4 wrote: > I don't see anything wrong in the patch (well, maybe you should switch > the code to the "goto fail;" idiom). I was just wondering whether there > was a specific reason for this. Did it fail on a certain system? Btw. while I did not test it, a

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

On Tue, Sep 02, 2014 at 09:54:36PM +0200, Reimar Döffinger wrote: > On Tue, Sep 02, 2014 at 09:28:27PM +0200, wm4 wrote: > > I don't see anything wrong in the patch (well, maybe you should switch > > the code to the "goto fail;" idiom). I was just wondering whether t

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

On Tue, Sep 02, 2014 at 01:13:27PM -0700, Peter Kasting wrote: > On Sat, Aug 30, 2014 at 2:21 AM, wm4 wrote: > > I'd > > expect it rather to hide bugs than to expose them. For example, it > > could make a static analyzer with value range analysis stop working, > > because the casts will basically

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

On Tue, Sep 02, 2014 at 11:31:39PM +0200, Jörg Krause wrote: > The maintainers of the musl C library states that looking for __GLIBC__ or > __UCLIBC__ and making assumptions about the implemented feature set is not > the best way. Instead should be inspected for the specification > of the feature

[FFmpeg-devel] [PATCH 1/4] ffv1dec: Avoid unnecessarily large stack usage and copies.

Ideally the compiler could figure this out on its own, but it seems it can't. An alternative that would avoid the messy explicit memcpy would be to use a sub-struct for the parts that should be preserved, which can then simply be assigned. Signed-off-by: Reimar Döffinger --- libav

[FFmpeg-devel] [PATCH 2/4] huffyuvdec: avoid large stack use.

Signed-off-by: Reimar Döffinger --- libavcodec/huffyuvdec.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c index 1df77e0..d661328 100644 --- a/libavcodec/huffyuvdec.c +++ b/libavcodec/huffyuvdec.c @@ -115,9

[FFmpeg-devel] [PATCH 3/4] libswresample: Avoid needlessly large on-stack array.

We only actually use a tiny part of it. Signed-off-by: Reimar Döffinger --- libswresample/rematrix.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libswresample/rematrix.c b/libswresample/rematrix.c index bf2abcf..60b8caf 100644 --- a/libswresample/rematrix.c +++ b

[FFmpeg-devel] [PATCH 4/4] svq1enc: remove pointless array element.

Not sure it was meant to be used for something at some point though. Signed-off-by: Reimar Döffinger --- libavcodec/svq1enc.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c index af18d38..850630f 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH] vorbisenc: avoid large stack allocation.

Code is only used during initialization, so malloc/free should be fine to use. Signed-off-by: Reimar Döffinger --- libavcodec/vorbisenc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/vorbisenc.c b/libavcodec/vorbisenc.c index 0fb7190..0f78d95 100644

Re: [FFmpeg-devel] [PATCH 1/4] ffv1dec: Avoid unnecessarily large stack usage and copies.

On Wed, Sep 03, 2014 at 12:01:52AM +0200, Reimar Döffinger wrote: > Ideally the compiler could figure this out on its own, > but it seems it can't. > An alternative that would avoid the messy explicit memcpy > would be to use a sub-struct for the parts that should > be prese

Re: [FFmpeg-devel] [PATCH] SSE2 version of vf_idet's filter_line()

On 03.09.2014, at 00:49, Pascal Massimino wrote: > On Tue, Sep 2, 2014 at 9:39 AM, Michael Niedermayer > wrote: > > > [ahem: ffmpeg doesn't feel like using intrinsics, by chance?] I tried that about 5 months back, once more. It still results in code that is slower than the plain C version, eve

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

On 03.09.2014, at 02:16, Peter Kasting wrote: > On Tue, Sep 2, 2014 at 5:10 PM, wm4 wrote: > >>> In the end, if we do decide to enable this warning, we will have to >> insert >>> some casts that are clearly safe, e.g. >>> >>> if (x > INT_MAX) >>>return; >>> int y = (int)x; >>> >>> Indeed

Re: [FFmpeg-devel] [PATCH 2/4] huffyuvdec: avoid large stack use.

On 03.09.2014, at 00:49, wm4 wrote: > On Wed, 3 Sep 2014 00:01:53 +0200 > Reimar Döffinger wrote: > >> Signed-off-by: Reimar Döffinger >> --- >> libavcodec/huffyuvdec.c | 15 +-- >> 1 file changed, 9 insertions(+), 6 deletions(-) >> &g

Re: [FFmpeg-devel] [PATCH 3/4] libswresample: Avoid needlessly large on-stack array.

On 03.09.2014, at 06:28, Michael Niedermayer wrote: > On Wed, Sep 03, 2014 at 12:01:54AM +0200, Reimar Döffinger wrote: >> We only actually use a tiny part of it. >> >> Signed-off-by: Reimar Döffinger >> --- >> libswresample/rematrix.c | 7 --- >> 1 fil

Re: [FFmpeg-devel] [PATCH] SSE2 version of vf_idet's filter_line()

On 03.09.2014, at 08:38, Pascal Massimino wrote: > On Tue, Sep 2, 2014 at 10:26 PM, Reimar Döffinger > wrote: > >> On 03.09.2014, at 00:49, Pascal Massimino >> wrote: >>> On Tue, Sep 2, 2014 at 9:39 AM, Michael Niedermayer >>> wrote: >>>

Re: [FFmpeg-devel] patch for x32 for libpostproc

On Tue, Sep 02, 2014 at 10:06:10PM +, Thorsten Glaser wrote: > Hi, > > as discussed in IRC, I was trying to minimal-invasively port > libpostproc (the Debian source package) to x32¹. I could not > test it (for lack of a stand-alone test program) yet, but at > least I got it to build. > > As r

Re: [FFmpeg-devel] Intrinsics (and NEON in particular)

On Wed, Sep 03, 2014 at 02:06:39PM +0200, Pascal Massimino wrote: > On Wed, Sep 3, 2014 at 9:16 AM, Reimar Döffinger > wrote: > > > strange. I exclusively used intrinsics for libwebp (x86, but also > > > neon/aarch64) and was pretty > > > pleased with the result (

Re: [FFmpeg-devel] [PATCH] confgure: create quick access fate samples link

On 03.09.2014, at 18:49, Michael Niedermayer wrote: > This allows using fs/ from the directory where ffmpeg was > build > for example in bug reports. > > Alternatively this could be created from the Makefile > > This of course works only on OS and file-systems which support links Not sure what

Re: [FFmpeg-devel] [PATCH] vorbisenc: avoid large stack allocation.

On Wed, Sep 03, 2014 at 02:48:41AM +0200, Michael Niedermayer wrote: > On Wed, Sep 03, 2014 at 12:25:17AM +0200, Reimar Döffinger wrote: > > Code is only used during initialization, so malloc/free > > should be fine to use. > > > > Signed-off-by: Reimar Döffing

Re: [FFmpeg-devel] [PATCH 4/4] svq1enc: remove pointless array element.

On Wed, Sep 03, 2014 at 05:22:29PM +0200, Michael Niedermayer wrote: > On Wed, Sep 03, 2014 at 12:01:55AM +0200, Reimar Döffinger wrote: > > Not sure it was meant to be used for something at some point though. > > > > Signed-off-by: Reimar Döffinger > > --- &g

Re: [FFmpeg-devel] [PATCH] Make av_gettime use the monotonic clock when available

On Wed, Sep 03, 2014 at 02:49:44PM +0200, Michael Niedermayer wrote: > This also remove all use of av_gettime_relative() > and reduces the difference to ebef9f5a56d7df91e010a177a80cfc8dbe394305 It kind of is an API change though. Also, as far as I can tell it introduces quite a lot of bugs. As an

Re: [FFmpeg-devel] [PATCH] ffv1enc: reduce stack usage.

On Tue, Sep 02, 2014 at 09:44:05PM +0200, Michael Niedermayer wrote: > On Tue, Sep 02, 2014 at 08:32:57PM +0200, Reimar Döffinger wrote: > > A bit more complex than e.g. adding it to the context, but > > using the context for something that will be used only during > > initia

[FFmpeg-devel] [PATCH 2/2] huffyuvdec: avoid large stack use.

Signed-off-by: Reimar Döffinger --- libavcodec/huffyuvdec.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c index 1df77e0..3b2b0f7 100644 --- a/libavcodec/huffyuvdec.c +++ b/libavcodec/huffyuvdec.c

[FFmpeg-devel] [PATCH 1/2] libswresample: Avoid needlessly large on-stack array.

We only actually need to use a tiny part of it. Unfortunately we seem to have no real test coverage on the code, so this is a bit risky. Signed-off-by: Reimar Döffinger --- libswresample/rematrix.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH 2/4] huffyuvdec: avoid large stack use.

On Wed, Sep 03, 2014 at 07:34:37AM +0200, Reimar Döffinger wrote: > On 03.09.2014, at 00:49, wm4 wrote: > > On Wed, 3 Sep 2014 00:01:53 +0200 > > Reimar Döffinger wrote: > > > >> Signed-off-by: Reimar Döffinger > >> --- > >> libavcodec/huffyuvd

Re: [FFmpeg-devel] [PATCH 3/4] libswresample: Avoid needlessly large on-stack array.

On Wed, Sep 03, 2014 at 07:36:32AM +0200, Reimar Döffinger wrote: > On 03.09.2014, at 06:28, Michael Niedermayer wrote: > > On Wed, Sep 03, 2014 at 12:01:54AM +0200, Reimar Döffinger wrote: > >> We only actually use a tiny part of it. > >> > >

Re: [FFmpeg-devel] [PATCH] confgure: create quick access fate samples link

On 03.09.2014, at 22:09, Michael Niedermayer wrote: > On Wed, Sep 03, 2014 at 08:46:04PM +0200, Reimar Döffinger wrote: >> On 03.09.2014, at 18:49, Michael Niedermayer wrote: >>> This allows using fs/ from the directory where ffmpeg >>> was build >

Re: [FFmpeg-devel] patch for x32 for libpostproc

On 04.09.2014, at 05:33, Reinhard Tartler wrote: > On Wed, Sep 3, 2014 at 9:34 PM, Michael Niedermayer wrote: >> On Wed, Sep 03, 2014 at 08:22:43PM -0400, Reinhard Tartler wrote: >>> On Wed, Sep 3, 2014 at 9:39 AM, Michael Niedermayer >>> wrote: On Tue, Sep 02, 2014 at 10:06:10PM +, Th

Re: [FFmpeg-devel] [PATCH] Add SUP (raw BluRay PGS subtitle) muxer

On Thu, Sep 04, 2014 at 10:19:05AM +0200, Hendrik Leppkes wrote: > On Fri, Aug 29, 2014 at 12:31 PM, Petri Hintukainen > wrote: > > +static int sup_write_packet(AVFormatContext *s, AVPacket *pkt) > > +{ > > +/* header */ > > +avio_wb16(s->pb, SUP_PGS_MAGIC); > > +avio_wb32(s->pb, (uin

Re: [FFmpeg-devel] patch for x32 for libpostproc

On 05.09.2014, at 03:46, Reinhard Tartler wrote: > On Thu, Sep 4, 2014 at 9:32 PM, Michael Niedermayer wrote: >>> At the end of the day, I need a source tarball that contains >>> maintained sources of a stand-alone libpostproc. I don't care too much >>> how it is created, as long as it doesn't re

Re: [FFmpeg-devel] [PATCH v2 1/4] libavutil/error: fix build with musl toolchain

On Thu, Sep 04, 2014 at 11:27:49PM +0200, Jörg Krause wrote: > > On 09/04/2014 05:27 PM, Hendrik Leppkes wrote: > >On Wed, Sep 3, 2014 at 11:53 AM, Jörg Krause wrote: > >>Add the feature test macro which is required for building with the > >>musl toolchain. > >> > >>The feature test macro _XOPEN_

Re: [FFmpeg-devel] [PATCH v2 6/6] avformat/subtitles: guess UTF-16 if no BOM present

On 06.09.2014, at 00:23, wm4 wrote: > On Sat, 6 Sep 2014 00:00:10 +0200 > Michael Niedermayer wrote: > >> On Thu, Sep 04, 2014 at 10:40:27PM +0200, wm4 wrote: >>> --- >>> Follows reimar's suggestion for detecting UTF-16. If the detection goes >>> wrong, probing the format won't succeed, so this

Re: [FFmpeg-devel] [PATCH] fix two spelling errors

On Sat, Sep 06, 2014 at 12:13:30PM +0200, Andreas Cadhalpun wrote: > -Effectively this allows to add padding with zeros from the left. > +Effectively this allows one to add padding with zeros from the left. Huh? I don't think the second is more correct, and it sure sounds worse. What is this tryin

Re: [FFmpeg-devel] [PATCH 1/2] libswresample: Avoid needlessly large on-stack array.

On Wed, Sep 03, 2014 at 10:48:38PM +0200, Michael Niedermayer wrote: > On Wed, Sep 03, 2014 at 09:40:55PM +0200, Reimar Döffinger wrote: > > We only actually need to use a tiny part of it. > > Unfortunately we seem to have no real test coverage on > > the code, s

[FFmpeg-devel] [PATCH 2/3] Remove pointless if.

A branch to avoid some calculation seems unlikely to have any benefits. Signed-off-by: Reimar Döffinger --- libswresample/rematrix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libswresample/rematrix.c b/libswresample/rematrix.c index 62662f8..5da3056 100644 --- a

[FFmpeg-devel] [PATCH 1/3] libswresample: Avoid needlessly large on-stack array.

We only actually need to use a tiny part of it. Unfortunately we seem to have no real test coverage on the code, so this is a bit risky. Signed-off-by: Reimar Döffinger --- libswresample/rematrix.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libswresample

[FFmpeg-devel] [PATCH 3/3] libswresample: move condition to start of loop.

This avoids several issue like calculating sum/maxcoef incorrectly due to adding up matrix entries that will be overwritten, as well as out-of-range writes to s->matrix if the maximum allowed number of channels is used. Signed-off-by: Reimar Döffinger --- libswresample/rematrix.c |

Re: [FFmpeg-devel] [PATCH 2/2] huffyuvdec: avoid large stack use.

On Wed, Sep 03, 2014 at 10:49:38PM +0200, Michael Niedermayer wrote: > On Wed, Sep 03, 2014 at 09:40:56PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/huffyuvdec.c | 19 +-- > > 1 file changed, 13

Re: [FFmpeg-devel] [PATCH 1/3] libswresample: Avoid needlessly large on-stack array.

Patchset pushed, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] qdm2: Allow hard-coding VLC tables.

Also adds a lot of infrastructure necessary for it. Some of it is a bit ugly though. Increases binary size for hardcoded tables by about 12 kB, which is about 15 kB from qdm2_table minus data and code saved that was only used for creating it. Signed-off-by: Reimar Döffinger --- libavcodec/qdm2

[FFmpeg-devel] [PATCH] qdm2: Allow hard-coding VLC tables.

Also adds a lot of infrastructure necessary for it. Some of it is a bit ugly though. Increases binary size for hardcoded tables by about 12 kB, which is about 15 kB from qdm2_table minus data and code saved that was only used for creating it. Signed-off-by: Reimar Döffinger --- libavcodec/qdm2

Re: [FFmpeg-devel] [PATCH] qdm2: Allow hard-coding VLC tables.

On Sun, Sep 07, 2014 at 02:03:08PM +0200, Reimar Döffinger wrote: > Also adds a lot of infrastructure necessary for it. > Some of it is a bit ugly though. > Increases binary size for hardcoded tables by about 12 kB, > which is about 15 kB from qdm2_table minus data and code > save

<    1   2   3   4   5   6   7   8   >