Re: [FFmpeg-devel] [PATCH 9/9] avcodec/vp3: Replace check by assert

On Sat, May 18, 2024 at 05:57:43AM +0200, Michael Niedermayer wrote: > Fixes: CID1452425 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp3.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/

Re: [FFmpeg-devel] [PATCH 1/9] avcodec/vqcdec: Check init_get_bits8() for failure

On Sun, May 19, 2024 at 04:49:07AM +0200, Michael Niedermayer wrote: > Fixes: CID1516090 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/vqcdec.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib

[FFmpeg-devel] [PATCH 1/4] mm: set audio pts proportionally to audio offset

--- libavformat/mm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mm.c b/libavformat/mm.c index 23c025d852..a40b5c44bb 100644 --- a/libavformat/mm.c +++ b/libavformat/mm.c @@ -180,7 +180,8 @@ static int read_packet(AVFormatContext *s, if ((ret = av

[FFmpeg-devel] [PATCH 2/4] mm: decode partial palette

--- palette decoding now conforms to description at https://wiki.multimedia.cx/index.php/IBM_PhotoMotion libavcodec/mmvideo.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index 3038d9ea92..b5b6ffd25b 100644 --- a/libav

[FFmpeg-devel] [PATCH 3/4] mm: don't fail if x offset exceeds frame width

--- libavcodec/mmvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index b5b6ffd25b..3b6b9ed580 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -162,7 +162,7 @@ static int mm_decode_inter(MmContext * s, int half_

[FFmpeg-devel] [PATCH 4/4] mm: decode raw chunk type and skip unknown audio chunk type

--- libavcodec/mmvideo.c | 11 +++ libavformat/mm.c | 9 +++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index 3b6b9ed580..2d006d58ba 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -39,6 +39,7 @@

[FFmpeg-devel] [PATCHv2 1/4] avcodec/mm: set audio pts proportionally to audio offset

--- libavformat/mm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mm.c b/libavformat/mm.c index 23c025d852..a40b5c44bb 100644 --- a/libavformat/mm.c +++ b/libavformat/mm.c @@ -180,7 +180,8 @@ static int read_packet(AVFormatContext *s, if ((ret = av

[FFmpeg-devel] [PATCHv2 2/4] avcodec/mm: decode partial palette

Reviewed-by: Andreas Rheinhardt --- libavcodec/mmvideo.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index 3038d9ea92..933d895f96 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -78,13 +78,10 @@ static

[FFmpeg-devel] [PATCHv2 3/4] avcodec/mm: don't fail if x offset exceeds frame width

--- libavcodec/mmvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index 933d895f96..d339967702 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -161,7 +161,7 @@ static int mm_decode_inter(MmContext * s, int half_

[FFmpeg-devel] [PATCHv2 4/4] avcodec/mm: decode raw chunk type and skip unknown audio chunk type

--- libavcodec/mmvideo.c | 11 +++ libavformat/mm.c | 9 +++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index d339967702..7313507deb 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -39,6 +39,7 @@

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/siren: prevent getbitcontext overread

On Sat, Sep 18, 2021 at 08:01:38PM +1000, Peter Ross wrote: > --- > libavcodec/siren.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/siren.c b/libavcodec/siren.c > index 2161b29a2c..3b0ad7b642 100644 > --- a/libavcodec/siren.c >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/siren: Check available bits at frame start

On Tue, Sep 28, 2021 at 12:07:49AM -0300, James Almer wrote: > On 9/27/2021 7:37 PM, Michael Niedermayer wrote: > > Fixes: Timeout > > Fixes: > > 39089/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSNSIREN_fuzzer-6677219854909440 > > > > Found-by: continuous fuzzing process > > https://gith

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/gemdec: Use ff_set_dimensions()

On Sun, Oct 10, 2021 at 11:39:54PM +0200, Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 39798/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_GEM_fuzzer-5611636853964800 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-

Re: [FFmpeg-devel] [PATCH] avformat/scd: add demuxer

On Tue, Nov 23, 2021 at 03:58:29PM +1000, Zane van Iperen wrote: > Ping again? > > I'll merge in a few days if no objections. > > > On 13/11/21 04:22, Zane van Iperen wrote: > > Ping? > > > > Pretty sure most people didn't get this as I was making DMARC changes at > > the time. I can re-send i

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/vp3: Check version in all cases when VP4 code is not built

On Tue, Nov 30, 2021 at 08:59:34PM +0100, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 40284/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP3_fuzzer-4599568176644096 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/gemdec: Check tag & planes before image allocation

On Sun, Nov 28, 2021 at 07:55:14PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 41083/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_GEM_fuzzer-5843826518917120 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/mvdec: handle audio sample size

On Sat, Nov 27, 2021 at 04:45:51PM -0500, John-Paul Stewart wrote: > Adds support for reading audio sample size from the data instead of > assuming all audio is 16 bits per sample. > --- > libavformat/mvdec.c | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --g

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/mvdec: handle audio sample size

On Wed, Dec 01, 2021 at 04:18:42PM +1100, Peter Ross wrote: > On Sat, Nov 27, 2021 at 04:45:51PM -0500, John-Paul Stewart wrote: > > Adds support for reading audio sample size from the data instead of > > assuming all audio is 16 bits per sample. > > --- > >

[FFmpeg-devel] [PATCHv2 1/2] avcodec: LEAD MCMP decoder

Partially fixes ticket #798 Reviewed-by: James Almer Reviewed-by: Michael Niedermayer Signed-off-by: Peter Ross --- configure | 1 + doc/general_contents.texi | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/codec_desc.c | 7

[FFmpeg-devel] [PATCHv2 2/2] fate: LEAD MCMP test case

Signed-off-by: Peter Ross --- Files: https://trac.ffmpeg.org/raw-attachment/ticket/798/BeforeEmboss1.avi https://trac.ffmpeg.org/raw-attachment/ticket/798/DaDa_CMP1.avi https://trac.ffmpeg.org/raw-attachment/ticket/798/version320x240i1.avi tests/fate/video.mak | 9 + tests

[FFmpeg-devel] [PATCH 1/3] avformat/rmdec: support RMHD file format

--- libavformat/rmdec.c | 42 +- 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index 0f1534b582..8e2ef7cc41 100644 --- a/libavformat/rmdec.c +++ b/libavformat/rmdec.c @@ -428,7 +428,8 @@ skip: stat

[FFmpeg-devel] [PATCH 3/3] fate: rv60 test cases

--- samples: https://pross.sdf.org/sandpit/test72x72.rmhd (32 KiB) https://pross.sdf.org/sandpit/test512x512.rmhd (64 KiB) tests/fate/video.mak| 8 tests/ref/fate/rv60-512x512 | 9 + tests/ref/fate/rv60-72x72 | 40 + 3 files chang

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

On Wed, Oct 18, 2023 at 04:42:01PM +0200, Anton Khirnov wrote: > Quoting Peter Ross (2023-10-18 10:03:54) [..] > I think you can simplify this into: > if (s->last_frame[NEXT_PIC]->data[0]) { > av_frame_move_ref(frame, s->last_frame[NEXT_PIC]); >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

On Sun, Oct 22, 2023 at 03:37:34PM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > --- > > diff --git a/libavformat/matroska.c b/libavformat/matroska.c > > index 5878594e68..1674806f29 100644 > > --- a/libavformat/matroska.c > > +++ b/libavformat/matroska.c >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

On Mon, Oct 23, 2023 at 12:14:52PM +0200, Anton Khirnov wrote: > Quoting Peter Ross (2023-10-22 01:31:32) > > On Wed, Oct 18, 2023 at 04:42:01PM +0200, Anton Khirnov wrote: > > > Quoting Peter Ross (2023-10-18 10:03:54) > > [..] > > > I think you can simplify this

Re: [FFmpeg-devel] [PATCHv2 1/2] avcodec: LEAD MCMP decoder

On Mon, Oct 16, 2023 at 08:43:30AM +1100, Peter Ross wrote: > Partially fixes ticket #798 > > Reviewed-by: James Almer > Reviewed-by: Michael Niedermayer > Signed-off-by: Peter Ross + Paul will push later tonight. thanks everyone for helping out. -- Peter (A907 E02F A6E5 0CD2

[FFmpeg-devel] [PATCH] lead: support unaligned blocks

Fixed ticket #10656. --- libavcodec/leaddec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c index ede52fba5a..fd2018256d 100644 --- a/libavcodec/leaddec.c +++ b/libavcodec/leaddec.c @@ -192,8 +192,8 @@ static int lead_decode

[FFmpeg-devel] [PATCH] lead: support format 0x0

Fixes ticket #10660. --- thanks to the mysterious 'ami_stuff'. libavcodec/leaddec.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c index fd2018256d..4f2cc03e65 100644 --- a/libavcodec/leadde

Re: [FFmpeg-devel] [PATCH 1/2] avformat/bink: properly mark packets that are key frames

On Wed, Mar 27, 2019 at 09:21:46PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/bink.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > this patch lgtm tested on some bink b samples too. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC4

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add bink2 video decoder

On Wed, Mar 27, 2019 at 09:21:47PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > Missing deblocking. > --- > configure |1 + > libavcodec/Makefile |1 + > libavcodec/allcodecs.c |1 + > libavcodec/avcodec.h|1 + > libavcodec/bink2.c |

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add bink2 video decoder

On Sun, Apr 07, 2019 at 10:00:09AM +0200, Paul B Mahol wrote: > On 4/7/19, Peter Ross wrote: > > On Wed, Mar 27, 2019 at 09:21:47PM +0100, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> Missing deblocking. > >> --- > >&

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

On Fri, May 03, 2019 at 10:43:36AM -0700, Baptiste Coudurier wrote: > > > On May 3, 2019, at 1:15 AM, Paul B Mahol wrote: > > > > On 4/28/19, Marton Balint wrote: > >> Hi All, > >> > >> There has been discussion on the mailing list several times about the > >> inclusion of support for closed s

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jvdec: Use ff_get_buffer() when the content is not reused

On Sat, May 04, 2019 at 01:38:38AM +0200, Michael Niedermayer wrote: > Fixes: Timeout (11sec -> 5sec) > Fixes: > 14473/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JV_fuzzer-5761630857592832 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/f

Re: [FFmpeg-devel] [PATCH 3/6] lavc/bink: Remove the dead code block

On Sat, May 11, 2019 at 12:05:51AM +0800, Jun Zhao wrote: > From: Jun Zhao > > Remove the dead code block > > Signed-off-by: Jun Zhao > --- > libavcodec/bink.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/bink.c b/libavcodec/bink.c > index 6673afa.

[FFmpeg-devel] [PATCH 1/2] VP4 video decoder

_LOSSY, +}, { .id= AV_CODEC_ID_Y41P, .type = AVMEDIA_TYPE_VIDEO, diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index b248c90413..9084ff33e3 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -1,5 +1,6 @@ /* * Copyright (C) 2003-2004 The FFmpeg project + * Copyrig

[FFmpeg-devel] [PATCH 2/2] avformat/riff: add VP4 fourcc

--- libavformat/riff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/riff.c b/libavformat/riff.c index 0f5cd62547..56387916f2 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -307,6 +307,7 @@ const AVCodecTag ff_codec_bmp_tags[] = { { AV_CODEC_ID_INDEO5, MKT

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

On Sun, May 12, 2019 at 09:41:40AM +0200, Paul B Mahol wrote: > On 5/12/19, Peter Ross wrote: > > --- > > i have incorporated all suggestions from the first patch posted jan 2019. > > > > if there's nothing further to change, i will apply it a

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

On Sun, May 12, 2019 at 12:49:03PM +0200, Carl Eugen Hoyos wrote: > Am So., 12. Mai 2019 um 08:12 Uhr schrieb Peter Ross : > > > i have incorporated all suggestions from the first patch posted jan 2019. > > > > if there's nothing further to change, i wi

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

On Sun, May 12, 2019 at 10:20:19AM -0300, James Almer wrote: > On 5/12/2019 3:12 AM, Peter Ross wrote: > > --- > > i have incorporated all suggestions from the first patch posted jan 2019. > > > > if there's nothing further to change, i will apply it a

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

On Sun, May 12, 2019 at 01:24:56PM +0200, Reimar Döffinger wrote: > On 12.05.2019, at 08:12, Peter Ross wrote: > > +static int read_mb_value(GetBitContext *gb) > > +{ > > +int v = 1; > > +int size; > > + > > +do { > > +

[FFmpeg-devel] [PATCHv3] VP4 video decoder

ps = AV_CODEC_PROP_LOSSY, +}, /* various PCM "codecs" */ { diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index b248c90413..63920c60bd 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -1,5 +1,6 @@ /* * Copyright (C) 2003-2004 The FFmpeg project + * Copyright

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

On Thu, May 16, 2019 at 08:52:39PM +0200, Reimar Döffinger wrote: > On Thu, May 16, 2019 at 08:00:55PM +0200, Reimar Döffinger wrote: > > On Thu, May 16, 2019 at 09:35:00PM +1000, Peter Ross wrote: > > > +static int read_mb_value(GetBitContext *gb) > > > +{ > >

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

On Thu, May 16, 2019 at 10:49:41AM -0300, James Almer wrote: > On 5/16/2019 8:35 AM, Peter Ross wrote: > > --- > > > > what's changed: > > * reordered AV_CODEC_ID_VP4 > > * minor read_mb_values improvement (reproducible 0.5% speedup) > > * configure/Mak

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

On Fri, May 17, 2019 at 08:13:51PM +0200, Reimar Döffinger wrote: > On Fri, May 17, 2019 at 08:09:45PM +1000, Peter Ross wrote: > > ah, i see what you did there! it works perfectly, just missing > > UPDATE_CACHE at the start and in the loop. > > > > test results on i

[FFmpeg-devel] [PATCHv4] VP4 video decoder

c90413..5fe2c2477c 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -1,5 +1,6 @@ /* * Copyright (C) 2003-2004 The FFmpeg project + * Copyright (C) 2019 Peter Ross * * This file is part of FFmpeg. * @@ -20,7 +21,7 @@ /** * @file - * On2 VP3 Video Decoder + * On2 VP3/VP4 Vid

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

On Tue, May 21, 2019 at 08:39:59PM +0200, Carl Eugen Hoyos wrote: > Am Di., 21. Mai 2019 um 19:18 Uhr schrieb Lynne : > > > > May 21, 2019, 8:44 AM by pr...@xvid.org : > > > > > --- > > > > > > what's changed: > > > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

On Tue, May 21, 2019 at 08:42:17PM +0200, Carl Eugen Hoyos wrote: > Am Di., 21. Mai 2019 um 09:45 Uhr schrieb Peter Ross : > > > diff --git a/configure b/configure > > index 9b4305cf0d..61eb774116 100755 > > --- a/configure > > +++ b/configure > > @@ -2825,

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

On Tue, May 21, 2019 at 08:38:02PM +0200, Reimar Döffinger wrote: > On Tue, May 21, 2019 at 11:15:03AM -0300, James Almer wrote: > > > I have a feeling this loop should have a stop condition like v < > > > SOME_LARGE_VALUE, say INT_MAX-255 or yuv_macroblock_count, to reject > > > corrupt/malicious

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

On Wed, May 22, 2019 at 09:45:46PM +0200, Reimar Döffinger wrote: > On Tue, May 21, 2019 at 09:30:54PM +0200, Reimar Döffinger wrote: > > > +#define SHIFT(v, shift) ((v) >> (shift)) > > > +#define ABS_SHIFT(v, shift) ((v) > 0 ? SHIFT(v, shift) : -SHIFT(-v, > > > shift)) > > > > Don't we have somet

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

On Tue, May 21, 2019 at 11:34:34AM +0200, Tomas Härdin wrote: > tis 2019-05-21 klockan 17:44 +1000 skrev Peter Ross: > > --- > > > > what's changed: > > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks > > * improved vp4_read_mb_value thanks

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

On Tue, May 21, 2019 at 09:30:54PM +0200, Reimar Döffinger wrote: > On Tue, May 21, 2019 at 05:44:20PM +1000, Peter Ross wrote: > > +if (bits < 0x100) { > > +skip_bits(gb, 1); > > +} else if (bits < 0x180) { > > +skip

[FFmpeg-devel] [PATCH] avcodec/vp3data: combine eob_run_base and eob_run_get_bits tables

--- This provides a small readability improvement. I observe no performance change on x86_64 or arm6. libavcodec/vp3.c | 6 +++--- libavcodec/vp3data.h | 9 - 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index b248c90413..63f60c910

Re: [FFmpeg-devel] [PATCH v4] avformat/ifv: added support for ifv cctv files

On Sat, May 25, 2019 at 01:59:44PM +0200, Paul B Mahol wrote: > On 5/25/19, Swaraj Hota wrote: > > Fixes ticket #2956. > > > > Signed-off-by: Swaraj Hota > > --- > > Changes made based on previous discussions. > > > > Now the demuxer is working pretty much as the original dvr player does. > > Fra

Re: [FFmpeg-devel] [PATCH] avcodec/vp3data: combine eob_run_base and eob_run_get_bits tables

On Sun, May 26, 2019 at 09:27:55PM +0200, Reimar Döffinger wrote: > On Sat, May 25, 2019 at 12:04:49PM +1000, Peter Ross wrote: > > --- > > This provides a small readability improvement. > > I observe no performance change on x86_64 or arm6. > > Looks good to me,

[FFmpeg-devel] [PATCHv5 1/2] avcodec/vp3: spin off get_eob_run and get_coeff coeff functions

these routines are shared by vp3 and vp4. --- libavcodec/vp3.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 63f60c9109..65aa0f353c 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -931

[FFmpeg-devel] [PATCHv5 2/2] VP4 video decoder

ecs" */ { diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 65aa0f353c..08a2e0d5e9 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -1,5 +1,6 @@ /* * Copyright (C) 2003-2004 The FFmpeg project + * Copyright (C) 2019 Peter Ross * * This file is part of FFmpeg. * @@ -20,7

Re: [FFmpeg-devel] [PATCHv5 2/2] VP4 video decoder

On Sat, Jun 08, 2019 at 08:49:15AM +0200, Reimar Döffinger wrote: > > > On 08.06.2019, at 03:08, Peter Ross wrote: > > > --- > > comments against v4 patch addressed. thanks. > > > > +#if CONFIG_VP4_DECODER > > +static int vp4_get_mb_co

Re: [FFmpeg-devel] [PATCH v5] avformat/ifv: added support for ifv cctv files

On Mon, Jun 03, 2019 at 04:06:10AM +0530, Swaraj Hota wrote: > On Sun, May 26, 2019 at 01:46:32AM +0530, Swaraj Hota wrote: > > Fixes ticket #2956. > > > > Signed-off-by: Swaraj Hota > > --- > > Minor changes based on previous discussions. > > Seeking is fixed. > > --- > > Changelog

Re: [FFmpeg-devel] [PATCH v5] avformat/ifv: added support for ifv cctv files

On Sun, Jun 09, 2019 at 09:36:33PM +1000, Peter Ross wrote: > On Mon, Jun 03, 2019 at 04:06:10AM +0530, Swaraj Hota wrote: > > On Sun, May 26, 2019 at 01:46:32AM +0530, Swaraj Hota wrote: > > > Fixes ticket #2956. > > > > > > Signed-off-by: Swaraj Hota &g

[FFmpeg-devel] [PATCHv6] VP4 video decoder

b/libavcodec/vp3.c index 65aa0f353c..a6f759ebf5 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -1,5 +1,6 @@ /* * Copyright (C) 2003-2004 The FFmpeg project + * Copyright (C) 2019 Peter Ross * * This file is part of FFmpeg. * @@ -20,7 +21,7 @@ /** * @file - * On2 VP3 Video Decode

Re: [FFmpeg-devel] [PATCH 3/4] avformat/wtvdec: Avoid (32bit signed) sectors

On Thu, Jun 13, 2019 at 01:20:19AM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -14614752 > Fixes: > 15174/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5670543606415360 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/pr

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/bink: Reorder operations in init to avoid memleak on error

On Sun, Jun 16, 2019 at 12:00:55AM +0200, Michael Niedermayer wrote: > Fixes: Direct leak of 536 byte(s) in 1 object(s) > Fixes: > 15266/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-5629530426834944 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tr

Re: [FFmpeg-devel] [PATCH v6] avformat/ifv: added support for ifv cctv files

On Mon, Jun 10, 2019 at 09:25:27AM +0530, Swaraj Hota wrote: > Fixes ticket #2956. > > Signed-off-by: Swaraj Hota > --- > Added entry in "doc/general.texi". > --- > Changelog| 1 + > doc/general.texi | 2 + > libavformat/Makefile | 1 + > libavformat/allformats.

Re: [FFmpeg-devel] [PATCH v6] avformat/ifv: added support for ifv cctv files

On Sun, Jun 16, 2019 at 07:19:54PM +0530, Swaraj Hota wrote: > On Sun, Jun 16, 2019 at 2:12 PM Paul B Mahol wrote: > > > On 6/16/19, Swaraj Hota wrote: > > > On Sun 16 Jun, 2019, 8:24 AM Peter Ross, wrote: > > > > > >> On Mon, Jun 10, 2019 at 09:25:27A

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check bpp for validity

On Wed, Jun 19, 2019 at 01:53:02AM +0200, Michael Niedermayer wrote: > Fixes: shift exponent -100663046 is negative > Fixes: out of array access > Fixes: > 15270/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5727829913763840 > > Found-by: continuous fuzzing process > https://

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/binkdsp: Fix integer overflows in idct

On Tue, Jun 18, 2019 at 02:55:02PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 3784 * 682038 cannot be represented in type > 'int' > Fixes: > 15265/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-5088311799971840 > Fixes: > 15268/clusterfuzz-testcase-minimiz

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check bpp for validity

On Wed, Jun 19, 2019 at 11:44:36AM +0200, Michael Niedermayer wrote: > On Wed, Jun 19, 2019 at 07:34:19PM +1000, Peter Ross wrote: > > On Wed, Jun 19, 2019 at 01:53:02AM +0200, Michael Niedermayer wrote: > > > Fixes: shift exponent -100663046 is negative > > >

[FFmpeg-devel] [PATCH] vp4: prevent unaligned memory access in loop filter

VP4 applies a loop filter during motion compensation, causing the block offset will often by unaligned. This produces a bus error on some platforms, namely ARMv7 NEON. This patch adds a unaligned version of the loop filter function pointer to VP3DSPContext. Reported-by: Mike Melanson --- libavc

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check ham vs bpp

On Sun, Jun 23, 2019 at 12:30:54AM +0200, Michael Niedermayer wrote: > This checks the ham value much stricter and avoids hitting cases which cannot > be reached > with data from the libavformat demuxer. > > Fixes: out of array access > Fixes: > 15320/clusterfuzz-testcase-minimized-ffmpeg_AV_COD

[FFmpeg-devel] [PATCH] ifv: populate creation_time

--- Small patch, to extract timestamp from IFV file header. libavformat/ifv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/ifv.c b/libavformat/ifv.c index 03c682bb9d..6acbb29a75 100644 --- a/libavformat/ifv.c +++ b/libavformat/ifv.c @@ -90,7 +90,10 @@ static

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/iff: Add "else" to make code look prettier

On Sat, Jul 13, 2019 at 10:25:01PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/iff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/iff.c b/libavcodec/iff.c > index c6e2359b00..7f1c589d7c 100644 > --- a/libavcodec

Re: [FFmpeg-devel] [PATCH] avcodec: add IMM5 decoder

On Tue, Jul 16, 2019 at 11:57:36AM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure | 1 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 ++ > libavcodec/imm5.c

Re: [FFmpeg-devel] FFmpeg classification

On Wed, Jul 17, 2019 at 10:10:13AM +0900, Maaya Murakami (JP) wrote: > Hello > > Hope all is well. > Currently I am researching about the trends of FFmpeg and its supporting > codecs, and in order to do so I am trying to classify FFmpeg codecs into > different types. Are there meaningful categorie

Re: [FFmpeg-devel] [PATCH] avformat/ifv: Check for EOF in read_index()

On Thu, Jul 18, 2019 at 01:42:23AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 15567/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5758451487080448 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] vp3data, mpc8huff: Make some arrays unsigned to prevent overflow

On Sat, Jul 20, 2019 at 03:51:25PM +0200, Andreas Rheinhardt wrote: > Some of the VP3 arrays (namely vp31_intra_y_dequant, vp31_intra_c_dequant > and vp31_inter_dequant) are currently declared as array of (const) int8_t > despite them being only used to directly initialize an array of uint8_t. > vp

Re: [FFmpeg-devel] [PATCH] avcodec/dstdec: add slice threading support

On Sun, Jul 28, 2019 at 11:34:51PM +0200, Paul B Mahol wrote: > Hi, > > patch attached. > From b0d0e0e025fc696270ef59a451d9ee93e2ba27b5 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Sun, 28 Jul 2019 22:27:10 +0200 > Subject: [PATCH 1/2] avcodec/dstdec: add slice threading support > > --

Re: [FFmpeg-devel] [PATCH] avcodec/dsddec: add slice threading support

On Sun, Jul 28, 2019 at 11:35:45PM +0200, Paul B Mahol wrote: > Hi, > > patch attached. > From ddfb95d32213406bc68a2803c13c7cfb2d99ee6a Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Sun, 28 Jul 2019 22:27:34 +0200 > Subject: [PATCH 2/2] avcodec/dsddec: add slice threading support > > --

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vp8: do vp7_fade_frame() later

On Thu, Aug 01, 2019 at 11:44:39PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (100sec -> 5sec) > Fixes: > 15073/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5649257362620416 > > Untested as none of the vp7 samples i found executes this codepath see attached. its all i can

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vp8: do vp7_fade_frame() later

On Fri, Aug 02, 2019 at 07:19:11PM +0200, Michael Niedermayer wrote: > On Fri, Aug 02, 2019 at 10:46:04PM +1000, Peter Ross wrote: > > On Thu, Aug 01, 2019 at 11:44:39PM +0200, Michael Niedermayer wrote: > > > Fixes: Timeout (100sec -> 5sec) > > > Fixes: > > &g

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/vp3: Check for end of input in vp4_unpack_vlcs()

On Sat, Aug 03, 2019 at 01:49:52AM +0200, Michael Niedermayer wrote: > Fixes: Timeout (too long -> 1sec) > Fixes: > 15232/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP3_fuzzer-5769583086010368 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projec

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/pictordec: Optimize picmemset() for single plane full lines

On Sat, Aug 03, 2019 at 01:49:54AM +0200, Michael Niedermayer wrote: > Fixes: Timeout (72sec -> 1sec) > Fixes: > 15512/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PICTOR_fuzzer-5663942342344704 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projec

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vp56: Consider the alpha start as end of the prior header

On Tue, Aug 06, 2019 at 11:30:02PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (23sec -> 71ms) > Fixes: > 15661/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP6A_fuzzer-6257865947348992 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vp56: Consider the alpha start as end of the prior header

On Sun, Aug 11, 2019 at 05:02:47PM +0200, Michael Niedermayer wrote: > On Sun, Aug 11, 2019 at 09:29:14AM +1000, Peter Ross wrote: > > On Tue, Aug 06, 2019 at 11:30:02PM +0200, Michael Niedermayer wrote: > > > Fixes: Timeout (23sec -> 71ms) > > > Fixes: > > &g

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/anm: Check input size for a frame with just a stop code

On Thu, Aug 15, 2019 at 11:49:13PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (11sec -> 6sec) > Fixes: > 16344/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ANM_fuzzer-5673032000995328 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp5/6/8: use vpX_rac_is_end()

On Tue, Aug 20, 2019 at 11:51:48AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp5.c | 2 +- > libavcodec/vp6.c | 2 +- > libavcodec/vp8.c | 8 > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/vp5.c b/libavcodec

[FFmpeg-devel] [PATCH 1/2] configure: detect djgpp libc

--- DOS builds are currently broken. patch 1 adds djgpp libc detection. patch 2 adds float min/max functions just for djggp libc (these functions were removed from libm.h in 4436a8f44dedc83767b3d9da9beb85d1fae2ca30) configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 2/2] fmin/fmax/fminf/fmaxf implementation for djgpp libc

--- compat/djgpp/math.h | 22 ++ configure | 1 + 2 files changed, 23 insertions(+) create mode 100644 compat/djgpp/math.h diff --git a/compat/djgpp/math.h b/compat/djgpp/math.h new file mode 100644 index 00..28fae5212e --- /dev/null +++ b/compat/djgpp/math

[FFmpeg-devel] [PATCH] avfilter/graphmonitor: use %z when printing size_t

--- 32-bit target compiler warning. libavfilter/f_graphmonitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/f_graphmonitor.c b/libavfilter/f_graphmonitor.c index 7052c84d9b..3cb8f73dd3 100644 --- a/libavfilter/f_graphmonitor.c +++ b/libavfilter/f_graphmonitor.

[FFmpeg-devel] [PATCHv2] avfilter/graphmonitor: use SIZE_SPECIFIER for size_t type

--- libavfilter/f_graphmonitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/f_graphmonitor.c b/libavfilter/f_graphmonitor.c index 7052c84d9b..c001835364 100644 --- a/libavfilter/f_graphmonitor.c +++ b/libavfilter/f_graphmonitor.c @@ -211,7 +211,7 @@ static void

[FFmpeg-devel] [PATCH] api-h264-slice-test: use av_be2ne16 instead of ntohs

avformat/network.h is not required here. --- tests/api/api-h264-slice-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/api/api-h264-slice-test.c b/tests/api/api-h264-slice-test.c index be03e80049..c6614da34d 100644 --- a/tests/api/api-h264-slice-test.c +++ b/tes

[FFmpeg-devel] [PATCH 0/5] djgpp patch set v2

revised ffmpeg dos patch set. passes fate. Peter Ross (5): configure: detect djgpp libc additional math.h functions for djgpp configure: memalign is broken on djgpp 2.05 avpriv_tempfile: add djgpp fallback fate-api-h264-slice: use the heap for nal buffer compat/djgpp/math.c

[FFmpeg-devel] [PATCH 1/5] configure: detect djgpp libc

--- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index b4f944cfb0..9ceb4a0c76 100755 --- a/configure +++ b/configure @@ -5295,7 +5295,6 @@ case $target_os in network_extralibs="-lsocket" objformat="coff" enable do

[FFmpeg-devel] [PATCH 2/5] additional math.h functions for djgpp

--- compat/djgpp/math.c | 47 +++ compat/djgpp/math.h | 25 +++ configure | 2 ++ tests/ref/fate/source | 1 + 4 files changed, 75 insertions(+) create mode 100644 compat/djgpp/math.c create mode 100644 compat/djgpp/ma

[FFmpeg-devel] [PATCH 3/5] configure: memalign is broken on djgpp 2.05

djgpp 2.05 finally provides posix-compatible memalign, but it is broken, so use disable it if this version is detected. discussion: http://www.delorie.com/archives/browse.cgi?p=djgpp/2017/12/29/16:26:58 --- configure | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a

[FFmpeg-devel] [PATCH 4/5] avpriv_tempfile: add djgpp fallback

--- libavutil/file_open.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/file_open.c b/libavutil/file_open.c index a8da283583..cc302f2f76 100644 --- a/libavutil/file_open.c +++ b/libavutil/file_open.c @@ -138,7 +138,7 @@ int avpriv_tempfile(const char *prefix, char *

[FFmpeg-devel] [PATCH 5/5] fate-api-h264-slice: use the heap for nal buffer

nal buffer is 512 kilobytes --- tests/api/api-h264-slice-test.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/api/api-h264-slice-test.c b/tests/api/api-h264-slice-test.c index be03e80049..181bbe5a6f 100644 --- a/tests/api/api-h264-slice-test.c +++ b/tests/ap

Re: [FFmpeg-devel] patch for failing on WavPack DSD files

On Tue, Nov 20, 2018 at 09:23:03PM -0800, David Bryant wrote: > Hi, > > Was made aware of this problem on Kodi: > > https://github.com/xbmc/xbmc/issues/14771 > > I'm going to try to add full WavPack DSD support, but thought in the meantime > it would be a good idea to detect and error out early

Re: [FFmpeg-devel] [PATCH 3/5] configure: memalign is broken on djgpp 2.05

On Tue, Nov 20, 2018 at 11:26:31PM +0100, Michael Niedermayer wrote: > On Tue, Nov 20, 2018 at 11:24:10PM +0100, Michael Niedermayer wrote: > > On Wed, Nov 21, 2018 at 01:29:48AM +1100, Peter Ross wrote: > > > djgpp 2.05 finally provides posix-compatible memalign, but it is br

[FFmpeg-devel] [PATCH 1/2] os_support: djgpp: define socket shutdown SHUT_xxx macros

--- two more patches concerning networking. i will push the other existing djgpp patches soon. libavformat/os_support.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/os_support.h b/libavformat/os_support.h index 7a56dc9a7c..3c3e37fb7c 100644 --- a/libavformat/os

[FFmpeg-devel] [PATCH 2/2] configure: use watt socket library instead of libsocket library for djgpp builds

rational: libsocket development ceased in 2001. it only ever worked using windows virtual dos mode. http://rich.phekda.org/richdawe/lsck/lsck_lnk.htm watt-32 is maintained. it can work using dos or using windows virtual dos mode. http://www.watt-32.net/ --- configure | 2 +- 1 file changed, 1 i

  1   2   3   4   5   >