On Thu, May 16, 2019 at 10:49:41AM -0300, James Almer wrote: > On 5/16/2019 8:35 AM, Peter Ross wrote: > > --- > > > > what's changed: > > * reordered AV_CODEC_ID_VP4 > > * minor read_mb_values improvement (reproducible 0.5% speedup) > > * configure/Makefile fix > > * squished data tables to fill 80 columns. > > > > UNCHECKED_BITSTREAM_READER doesn't give any performance improvement > > on my i7, even with unrealisticly huge 4k vp4 video files. > > I hope that was a typo and you tested CACHED_BITSTREAM_READER, not > UNCHECKED_BITSTREAM_READER :p > > In any case, I wouldn't bother. Ricing a VP4 decoder is hardly worth > anyone's time.
oops, yes. and i agree. > > @@ -2825,6 +2825,7 @@ vc1image_decoder_select="vc1_decoder" > > vorbis_decoder_select="mdct" > > vorbis_encoder_select="audio_frame_queue mdct" > > vp3_decoder_select="hpeldsp vp3dsp videodsp" > > +vp4_decoder_select="hpeldsp vp3dsp videodsp" > > Theora enables the vp3 decoder instead of only the related modules > because by compiling vp3.c it's already compiling the entirety of the > vp3 decoder, so might as well have it enabled and available. IMO for vp4 > you should do the same. > > Also, big vp4 specific functions and big chunks of code within shared > functions should ideally be wrapped inside CONFIG_VP4_DECODER checks. thanks for spotting these. fixed and fixed. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
