>From c72344d2b1dc8b087e5da904724c959005f36f4b Mon Sep 17 00:00:00 2001
From: Peter Tissen
Date: Fri, 6 Mar 2015 19:39:27 +0100
Subject: [PATCH] Make compilable with VS2015
So Visual Studio 2015 has some breaking changes regarding the C
runtime. In short, they made C99 compatable runtime.
Re
i, Mar 06, 2015 at 02:59:43PM -0500, Ronald S. Bultje wrote:
>> >>> Hi,
>> >>>
>> >>> On Fri, Mar 6, 2015 at 2:42 PM, Peter wrote:
>> >>>
>> >>>> From c72344d2b1dc8b087e5da904724c959005f36f4b Mon Sep 17 00:00:00 2001
>&
I admit to being a serial rebaser and force-pusher to pull-requests. :P
Anyway, I can't run FATE on that setup, because although the ffmpeg libs compile
the ffmpeg command line tool doesn't compile.
The old "stdin->_cnt" hack no longer works since "FILE" in the new C runtime
is just a struct with
So trying to compile on VS2015 now works fine for the libraries.
However the command-line tool does not compile successfully.
The issue is this patch
https://github.com/FFmpeg/FFmpeg/commit/ca4d71b149ebe32aeaf617ffccf362624b9aafb1
which uses a member of the FILE struct which is not available in th
le and only then call one of the generic
read functions? (and let the kbhit and getch that come afterwards handle the
console)
2015-03-07 23:38 GMT+01:00 Reimar Döffinger :
> On 07.03.2015, at 16:51, Peter wrote:
>> The issue is this patch
>> https://
peg/commit/93864dd0373bc6561be8e45f14f835453c74e832
2015-03-08 0:22 GMT+01:00 Peter :
>>It checks if there is data in the buffer. The point is to do a non-blocking
>>read on stdin.
>
> I don't know how else to do that for stdin. Using WaitForSingleObject with
> generic functions like read() from
Sadly it seems WaitForSingleObject behavior with FILE handles is
not well defined behavior either, I think I've read the words "strongly
discouraged"
I'm probably still gonna do some more tests to see if it actually breaks
under some circumstances. But this is not the golden ticket solution
either
ion ?
2015-03-08 2:25 GMT+01:00 Peter :
> Sadly it seems WaitForSingleObject behavior with FILE handles is
> not well defined behavior either, I think I've read the words "strongly
> discouraged"
>
> I'm probably still gonna do some more tests to see if it actual
; stdin to CreateProcess
> or whether testing that is necessary)
>
> Also, very crucially, I just checked if any of these methods actually
> triggered either condition
> and none of the things I tried actually entered the body of the if-check.
>
> Is there anything that would
& 7) + 2;
> y_offset = (-(y + 2) & 7) + 2;
>
> -if (x_offset > 8 + x_subpel && y_offset > 8 + y_subpel)
> -return 0;
> + av_assert1(!(x_offset > 8 + x_subpel && y_offset > 8 + y_subpel));
>
ok
-- P
&gb, buf, size);
> +if (ret < 0)
> +return ret;
>
> for (int i = 0; i < 3 * width * height / 2 / 32; i++) {
> uint8_t * dst = vectors;
ok
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
= av_get_packet(s->pb, pkt, length)) < 0)
return ret;
pkt->stream_index = 1;
-pkt->pts = mm->audio_pts++;
+pkt->pts = mm->audio_pts;
+mm->audio_pts += length;
return 0;
default :
--
2.4
24 | (bytestream2_get_be24(&s->gb) <<
2);
}
/**
--
2.43.0
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubsc
if (replace) {
int color = bytestream2_get_byte(&data_ptr);
s->frame->data[0][y*s->frame->linesize[0] + x] = color;
--
2.43.0
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
___
ffmpeg-deve
av_log(s, AV_LOG_INFO, "unknown chunk type 0x%x\n", type);
+case MM_TYPE_AUDIO2 :
avio_skip(pb, length);
}
}
--
2.43.0
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
___
ffmpeg-devel mailing
= av_get_packet(s->pb, pkt, length)) < 0)
return ret;
pkt->stream_index = 1;
-pkt->pts = mm->audio_pts++;
+pkt->pts = mm->audio_pts;
+mm->audio_pts += length;
return 0;
default :
--
2.4
tte[i+128] = s->palette[i]<<2;
-}
+int start = bytestream2_get_le16(&s->gb);
+int count = bytestream2_get_le16(&s->gb);
+for (int i = 0; i < count; i++)
+s->palette[start+i] = 0xFFU << 24 | (bytestream2_get_be24(&s->gb) <<
2);
}
if (replace) {
int color = bytestream2_get_byte(&data_ptr);
s->frame->data[0][y*s->frame->linesize[0] + x] = color;
--
2.43.0
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
VFormatContext *s,
default :
av_log(s, AV_LOG_INFO, "unknown chunk type 0x%x\n", type);
+case MM_TYPE_AUDIO2 :
avio_skip(pb, length);
}
}
--
2.43.0
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Descript
On Sat, Sep 18, 2021 at 08:01:38PM +1000, Peter Ross wrote:
> ---
> libavcodec/siren.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/siren.c b/libavcodec/siren.c
> index 2161b29a2c..3b0ad7b642 100644
> --- a/libavcodec/siren.c
>
0 condition to the loop in
> decode_envelope().
> And there should be at least four bits left after decode_envelope() returns,
> so check for that too.
suggest increasing the threshold to include:
s->sample_rate_bits + s->number_of_regions + 4 + s->checksum_bits >
get_bits_le
t_be16(&gb);
> +height = bytestream2_get_be16(&gb);
> +ret = ff_set_dimensions(avctx, width, height);
> +if (ret < 0)
> +return ret;
>
> row_width = (avctx->width + 7) / 8;
> put_lines = put_lines_bits;
looks good. please apply.
-- Peter
i)) < 0)
> > > + return ret;
> > > + }
> > > +
> > > + if (ctx->hdr.table1.count == 0)
> > > + return 0;
> > > +
> > > + if ((ret = avio_seek(s->pb, ctx->
return AVERROR_DECODER_NOT_FOUND;
> +}
> +#endif
> +s->version = version;
> if (avctx->frame_number == 0)
> av_log(s->avctx, AV_LOG_DEBUG,
> "VP ver
put_lines_bytes;
> -} else {
> -avpriv_request_sample(avctx, "planes=%d", planes);
> -return AVERROR_PATCHWELCOME;
> }
>
> ret = av_reallocp_array(&avctx->priv_data, planes, row_width);
please apply
-- Peter
(A907 E02F A6E5 0CD2 34CD
ex_entry(vst, pos + asize, i, vsize, 0,
> AVINDEX_KEYFRAME);
> -timestamp += asize / (ast->codecpar->channels * 2LL);
> +timestamp += asize / (ast->codecpar->channels *
> bytes_per_sample);
> }
> } else if (!version && avio_rb16(pb) ==
On Wed, Dec 01, 2021 at 04:18:42PM +1100, Peter Ross wrote:
> On Sat, Nov 27, 2021 at 04:45:51PM -0500, John-Paul Stewart wrote:
> > Adds support for reading audio sample size from the data instead of
> > assuming all audio is 16 bits per sample.
> > ---
> >
Partially fixes ticket #798
Reviewed-by: James Almer
Reviewed-by: Michael Niedermayer
Signed-off-by: Peter Ross
---
configure | 1 +
doc/general_contents.texi | 1 +
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c| 1 +
libavcodec/codec_desc.c | 7
Signed-off-by: Peter Ross
---
Files:
https://trac.ffmpeg.org/raw-attachment/ticket/798/BeforeEmboss1.avi
https://trac.ffmpeg.org/raw-attachment/ticket/798/DaDa_CMP1.avi
https://trac.ffmpeg.org/raw-attachment/ticket/798/version320x240i1.avi
tests/fate/video.mak | 9 +
tests
+else if (ver == 2)
+expected_len = 24 + n_pkts * 18LL;
if (len == 20 && expected_len <= INT_MAX)
/* some files don't add index entries to chunk size... */
@@ -1078,7 +1094,7 @@ static int rm_probe(const
, 7776, 0xe1973be5
+0, 33, 33,1, 7776, 0x26283bde
+0, 36, 36,1, 7776, 0xbcda3aca
--
2.42.0
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
On Wed, Oct 18, 2023 at 04:42:01PM +0200, Anton Khirnov wrote:
> Quoting Peter Ross (2023-10-18 10:03:54)
[..]
> I think you can simplify this into:
> if (s->last_frame[NEXT_PIC]->data[0]) {
> av_frame_move_ref(frame, s->last_frame[NEXT_PIC]);
>
On Sun, Oct 22, 2023 at 03:37:34PM +0200, Andreas Rheinhardt wrote:
> Peter Ross:
> > ---
> > diff --git a/libavformat/matroska.c b/libavformat/matroska.c
> > index 5878594e68..1674806f29 100644
> > --- a/libavformat/matroska.c
> > +++ b/libavformat/matroska.c
>
On Mon, Oct 23, 2023 at 12:14:52PM +0200, Anton Khirnov wrote:
> Quoting Peter Ross (2023-10-22 01:31:32)
> > On Wed, Oct 18, 2023 at 04:42:01PM +0200, Anton Khirnov wrote:
> > > Quoting Peter Ross (2023-10-18 10:03:54)
> > [..]
> > > I think you can simplify this
On Mon, Oct 16, 2023 at 08:43:30AM +1100, Peter Ross wrote:
> Partially fixes ticket #798
>
> Reviewed-by: James Almer
> Reviewed-by: Michael Niedermayer
> Signed-off-by: Peter Ross
+ Paul
will push later tonight. thanks everyone for helping out.
-- Peter
(A907 E02F A6E5 0CD2
ane < 3; plane++) {
const VLCElem * dc_vlc = !plane ? luma_dc_vlc.table :
chroma_dc_vlc.table;
int dc_bits = !plane ? LUMA_DC_BITS :
CHROMA_DC_BITS;
--
2.42.0
-- Peter
(A907 E02F A6E5 0CD2 34C
;gb, dc_vlc, dc_bits, ac_vlc,
ac_bits,
+dc_pred + plane, dequant[!(b < 4)], tmp, 8);
+for (int yy = 0; yy < 8 && y + yy < avctx->height / 2;
yy++)
+memcpy(frame->data[plane] +
(y+yy)*frame->
On Wed, Mar 27, 2019 at 09:21:46PM +0100, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> libavformat/bink.c | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
this patch lgtm
tested on some bink b samples too.
-- Peter
(A907 E02F A6E5 0CD2 34CD
This patch does not improve or fix something instead it is meant for
easily reproducing issue 7827 (as requested, cf.
https://trac.ffmpeg.org/ticket/7827). I've to admit that I don't know
how to produce a patch by "git format-patch" instead it was made by "git
diff > muxing.patch".
diff --git
On 04.04.2019 08:49, myp...@gmail.com wrote:
On Thu, Apr 4, 2019 at 2:33 PM Peter Belkner wrote:
This patch does not improve or fix something instead it is meant for
easily reproducing issue 7827 (as requested, cf.
https://trac.ffmpeg.org/ticket/7827). I've to admit that I don't k
lru[0], lru[1]);
> +break;
> +case 2:
> +val = lru[3];
> +FFSWAP(int, lru[2], lru[3]);
> +break;
> +case 3:
> +val = lru[2];
> +FFSWAP(int, lru[1], lru[2]);
> +break;
> +}
cases 1-3 could be collapsed.
>
On Sun, Apr 07, 2019 at 10:00:09AM +0200, Paul B Mahol wrote:
> On 4/7/19, Peter Ross wrote:
> > On Wed, Mar 27, 2019 at 09:21:47PM +0100, Paul B Mahol wrote:
> >> Signed-off-by: Paul B Mahol
> >> ---
> >> Missing deblocking.
> >> ---
> >&
> format of any kind.
> Please elaborate what exactly this is trying to achieve.
Can you elaborate on how to use ffmpeg's API properly as a client to
decide if a decoder is a SW decoder and therefore howto properly setup
(multi-)threading, especially it cannot be changed once initial
Should patches using closed source libraries which are not considered
> >> "System Libraries" according to the GPL be rejected?
> >
> > Yes, yes, yes.
>
> Yes
Yes.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signa
/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/jvdec.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
looks good. please apply.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
sign
C_RUN])) < 0)
> return ret;
>
> -if (by == bh)
> -break;
> dst = frame->data[plane_idx] + 8*by*stride;
> prev = (c->last->data[plane_idx] ? c->last->data[plane_idx]
>
_LOSSY,
+},
{
.id= AV_CODEC_ID_Y41P,
.type = AVMEDIA_TYPE_VIDEO,
diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c
index b248c90413..9084ff33e3 100644
--- a/libavcodec/vp3.c
+++ b/libavcodec/vp3.c
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2003-2004 The FFmpeg project
+ * Copyrig
MKTAG('V', 'P', '4', '0') },
{ AV_CODEC_ID_VP5, MKTAG('V', 'P', '5', '0') },
{ AV_CODEC_ID_VP6, MKTAG('V', 'P', '6', '0') },
{ AV_CODEC_ID
On Sun, May 12, 2019 at 09:41:40AM +0200, Paul B Mahol wrote:
> On 5/12/19, Peter Ross wrote:
> > ---
> > i have incorporated all suggestions from the first patch posted jan 2019.
> >
> > if there's nothing further to change, i will apply it a
On Sun, May 12, 2019 at 12:49:03PM +0200, Carl Eugen Hoyos wrote:
> Am So., 12. Mai 2019 um 08:12 Uhr schrieb Peter Ross :
>
> > i have incorporated all suggestions from the first patch posted jan 2019.
> >
> > if there's nothing further to change, i wi
On Sun, May 12, 2019 at 10:20:19AM -0300, James Almer wrote:
> On 5/12/2019 3:12 AM, Peter Ross wrote:
> > ---
> > i have incorporated all suggestions from the first patch posted jan 2019.
> >
> > if there's nothing further to change, i will apply it a
On Sun, May 12, 2019 at 01:24:56PM +0200, Reimar Döffinger wrote:
> On 12.05.2019, at 08:12, Peter Ross wrote:
> > +static int read_mb_value(GetBitContext *gb)
> > +{
> > +int v = 1;
> > +int size;
> > +
> > +do {
> > +
ps = AV_CODEC_PROP_LOSSY,
+},
/* various PCM "codecs" */
{
diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c
index b248c90413..63920c60bd 100644
--- a/libavcodec/vp3.c
+++ b/libavcodec/vp3.c
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2003-2004 The FFmpeg project
+ * Copyright
On Thu, May 16, 2019 at 08:52:39PM +0200, Reimar Döffinger wrote:
> On Thu, May 16, 2019 at 08:00:55PM +0200, Reimar Döffinger wrote:
> > On Thu, May 16, 2019 at 09:35:00PM +1000, Peter Ross wrote:
> > > +static int read_mb_value(GetBitContext *gb)
> > > +{
> >
On Thu, May 16, 2019 at 10:49:41AM -0300, James Almer wrote:
> On 5/16/2019 8:35 AM, Peter Ross wrote:
> > ---
> >
> > what's changed:
> > * reordered AV_CODEC_ID_VP4
> > * minor read_mb_values improvement (reproducible 0.5% speedup)
> > * configure/Mak
On Fri, May 17, 2019 at 08:13:51PM +0200, Reimar Döffinger wrote:
> On Fri, May 17, 2019 at 08:09:45PM +1000, Peter Ross wrote:
> > ah, i see what you did there! it works perfectly, just missing
> > UPDATE_CACHE at the start and in the loop.
> >
> > test results on i
c90413..5fe2c2477c 100644
--- a/libavcodec/vp3.c
+++ b/libavcodec/vp3.c
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2003-2004 The FFmpeg project
+ * Copyright (C) 2019 Peter Ross
*
* This file is part of FFmpeg.
*
@@ -20,7 +21,7 @@
/**
* @file
- * On2 VP3 Video Decoder
+ * On2 VP3/VP4 Vid
IG_VP4_DECODER and make it part of the vp3 decoder.
>
> Wasn't this explicitly requested in an earlier review?
> (And it is common within FFmpeg)
i'll leave the ifdefs inplace.
lynne has a point though, disabling vp4 only reduces the final ffmpeg binary by
25 kilobytes.
-- Pete
On Tue, May 21, 2019 at 08:42:17PM +0200, Carl Eugen Hoyos wrote:
> Am Di., 21. Mai 2019 um 09:45 Uhr schrieb Peter Ross :
>
> > diff --git a/configure b/configure
> > index 9b4305cf0d..61eb774116 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2825,
ock_count never
exceeds (255 * 255 * 3/2 = 97537). i this kind of check will suffice
and speed up fuzzing tests.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-deve
ing is equivalent:
> ((a + (a >> 31)) >> b) - (a >> 31)
> Not certain it will be fewer instructions,
> but it is branchless.
> On some ISAs the simple
> a / (1 << b)
this is best, and the compiler can decode. thanks.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2
On Tue, May 21, 2019 at 11:34:34AM +0200, Tomas Härdin wrote:
> tis 2019-05-21 klockan 17:44 +1000 skrev Peter Ross:
> > ---
> >
> > what's changed:
> > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks
> > * improved vp4_read_mb_value thanks
On Tue, May 21, 2019 at 09:30:54PM +0200, Reimar Döffinger wrote:
> On Tue, May 21, 2019 at 05:44:20PM +1000, Peter Ross wrote:
> > +if (bits < 0x100) {
> > +skip_bits(gb, 1);
> > +} else if (bits < 0x180) {
> > +skip
, 0}, {4, 2}, {8, 3}, {16, 4}, {0, 12}
};
static const uint8_t zero_run_base[32] = {
--
2.20.1
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.
; +return 0;
> > +}
the audio-present and no-audio-present cases are almost identical.
could easily be combined.
this perhaps a style issue, but why have nb_new_a/vframes. the bits can be read
and incremented one line,
> > +}
> > +
> > +if (!e_next) return A
On Sun, May 26, 2019 at 09:27:55PM +0200, Reimar Döffinger wrote:
> On Sat, May 25, 2019 at 12:04:49PM +1000, Peter Ross wrote:
> > ---
> > This provides a small readability improvement.
> > I observe no performance change on x86_64 or arm6.
>
> Looks good to me,
eff, zero_run);
--
2.20.1
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, vis
ecs" */
{
diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c
index 65aa0f353c..08a2e0d5e9 100644
--- a/libavcodec/vp3.c
+++ b/libavcodec/vp3.c
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2003-2004 The FFmpeg project
+ * Copyright (C) 2019 Peter Ross
*
* This file is part of FFmpeg.
*
@@ -20,7
On Sat, Jun 08, 2019 at 08:49:15AM +0200, Reimar Döffinger wrote:
>
>
> On 08.06.2019, at 03:08, Peter Ross wrote:
>
> > ---
> > comments against v4 patch addressed. thanks.
> >
> > +#if CONFIG_VP4_DECODER
> > +static int vp4_get_mb_co
nged, 309 insertions(+), 2 deletions(-)
> > create mode 100644 libavformat/ifv.c
> >
>
> Is the patch okay now? Can it be merged?
i don't have any further comments. recommend commit.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Descripti
On Sun, Jun 09, 2019 at 09:36:33PM +1000, Peter Ross wrote:
> On Mon, Jun 03, 2019 at 04:06:10AM +0530, Swaraj Hota wrote:
> > On Sun, May 26, 2019 at 01:46:32AM +0530, Swaraj Hota wrote:
> > > Fixes ticket #2956.
> > >
> > > Signed-off-by: Swaraj Hota
&g
b/libavcodec/vp3.c
index 65aa0f353c..a6f759ebf5 100644
--- a/libavcodec/vp3.c
+++ b/libavcodec/vp3.c
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2003-2004 The FFmpeg project
+ * Copyright (C) 2019 Peter Ross
*
* This file is part of FFmpeg.
*
@@ -20,7 +21,7 @@
/**
* @file
- * On2 VP3 Video Decode
VFormatContext *s, int mode,
> int64_t seekts, int *len_p
> static int read_header(AVFormatContext *s)
> {
> WtvContext *wtv = s->priv_data;
> -int root_sector, root_size;
> +unsigned root_sector;
> +int root_size;
> uint8_t root[WTV_SECTOR_SIZE];
>
mt = c->has_alpha ? AV_PIX_FMT_YUVA420P : AV_PIX_FMT_YUV420P;
> avctx->color_range = c->version == 'k' ? AVCOL_RANGE_JPEG :
> AVCOL_RANGE_MPEG;
>
> --
> 2.21.0
lgtm. please apply.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description:
ush.
can you do that? if this for gsoc2019, does it first need blessing from mentor?
otherwise i will push in a couple of days.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
___
ffmpeg-devel mai
On Sun, Jun 16, 2019 at 07:19:54PM +0530, Swaraj Hota wrote:
> On Sun, Jun 16, 2019 at 2:12 PM Paul B Mahol wrote:
>
> > On 6/16/19, Swaraj Hota wrote:
> > > On Sun 16 Jun, 2019, 8:24 AM Peter Ross, wrote:
> > >
> > >> On Mon, Jun 10, 2019 at 09:25:27A
if (avctx->codec_tag == MKTAG('R', 'G', 'B', '8')) {
> avctx->pix_fmt = AV_PIX_FMT_RGB32;
> } else if (avctx->codec_tag == MKTAG('R', 'G', 'B', 'N')) {
> --
> 2.21.0
= ((A2*a7) >> 11) + b3 - b1; \
> +const int b1 = MUL(A3, a5 + a7); \
> +const int b2 = MUL(A4, a5) - b0 + b1; \
> +const int b3 = MUL(A1, a6 - a4) - b2; \
> +const int b4 = MUL(A2, a7) + b3 - b1; \
> (dest)[d0] = munge(a0+a2 +b0); \
> (dest)[d1] = munge(a1
On Wed, Jun 19, 2019 at 11:44:36AM +0200, Michael Niedermayer wrote:
> On Wed, Jun 19, 2019 at 07:34:19PM +1000, Peter Ross wrote:
> > On Wed, Jun 19, 2019 at 01:53:02AM +0200, Michael Niedermayer wrote:
> > > Fixes: shift exponent -100663046 is negative
> > >
mxext;
+c->h_loop_filter = c->v_loop_filter_unaligned =
ff_vp3_h_loop_filter_mmxext;
}
}
--
2.20.1
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
f
nvalid number of hold bits for
> HAM: %u, BPP: %u\n", s->ham, s->bpp);
> +s->ham = 0;
> +return AVERROR_INVALIDDATA;
> +}
> +}
i am curious why we need to reset ham = 0? otherwise patch okay.
patch 1 and 3 okay.
-- Pete
;pb, 0x24);
+
ifv->width = avio_rl16(s->pb);
ifv->height = avio_rl16(s->pb);
--
2.20.1
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpe
ts for
> HAM: %u, BPP: %u\n", s->ham, s->bpp);
> return AVERROR_INVALIDDATA;
> }
> --
> 2.22.0
well spotted. please push.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
___
> +} else {
> +memcpy(buf + off, IMM5_units[13].bits, IMM5_units[13].len);
> +}
this all looks pretty good.
without trying to nitpick it forever, i suggest replacing the (codec_type==2)
blocks.
index2 = codec_type2 == 2 ? 12 : 13;
offset += IMM5_units[i
gineered <- more of a numerical scale than
categorical variable
Whether these classifications are meaningful is entirely up to you.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
___
ffmpeg-devel m
68,8 @@ static int read_index(AVFormatContext *s,
> }
>
> for (i = start_index; i < end_index; i++) {
> +if (avio_feof(s->pb))
> +return AVERROR_EOF;
> pos = avio_rl32(s->pb);
> size = avio_rl32(s->pb);
>
i ap
t; * (note: same as JPEG) */
> -static const int8_t vp31_intra_c_dequant[64] = {
> +static const uint8_t vp31_intra_c_dequant[64] = {
> 17, 18, 24, 47, 99, 99, 99, 99,
> 18, 21, 26, 66, 99, 99, 99, 99,
> 24, 26, 56, 99, 99, 99, 99, 99,
> @@
ice threading support
>
> ---
> libavcodec/dstdec.c | 23 +++
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
approve.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
_
ice threading support
>
> ---
> libavcodec/dsddec.c | 47 ++---
> 1 file changed, 32 insertions(+), 15 deletions(-)
also approve.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signatu
fade_frame(s, alpha, beta)) < 0)
> +return ret;
> +
> return 0;
> }
>
> --
> 2.22.0
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/li
On Fri, Aug 02, 2019 at 07:19:11PM +0200, Michael Niedermayer wrote:
> On Fri, Aug 02, 2019 at 10:46:04PM +1000, Peter Ross wrote:
> > On Thu, Aug 01, 2019 at 11:44:39PM +0200, Michael Niedermayer wrote:
> > > Fixes: Timeout (100sec -> 5sec)
> > > Fixes:
> > &g
avcodec/vp3.c
> @@ -1403,6 +1403,8 @@ static int vp4_unpack_vlcs(Vp3DecodeContext *s,
> GetBitContext *gb,
> int eob_run;
>
> while (!eob_tracker[coeff_i]) {
> +if (get_bits_left(gb) < 1)
> +return AVERROR_INVALIDDATA;
>
> token =
s->width - xl);
> +run -= (s->width + pixels_per_value - 1) /
> pixels_per_value;
> +xl = s->width;
> +}
> }
> }
> run--;
> --
> 2.22.0
otherwise patch is good.
-- Peter
(A907
ze);
if (res < 0)
return res;
if the sample has alpha, remaining_buf_size is reduced in size.
can you post the sanple that takes 23s to decode?
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
_
On Sun, Aug 11, 2019 at 05:02:47PM +0200, Michael Niedermayer wrote:
> On Sun, Aug 11, 2019 at 09:29:14AM +1000, Peter Ross wrote:
> > On Tue, Aug 06, 2019 at 11:30:02PM +0200, Michael Niedermayer wrote:
> > > Fixes: Timeout (23sec -> 71ms)
> > > Fixes:
> > &g
As of LLVM r368102, Clang will set a pointer tag in bits 56-63 of the
address of a global when compiling with -fsanitize=hwaddress. This requires
an adjustment to assembly code that takes the address of such globals: the
code cannot use the regular R_AARCH64_ADR_PREL_PG_HI21 relocation to refer
to
ibavcodec/anm.c
> @@ -119,6 +119,9 @@ static int decode_frame(AVCodecContext *avctx,
> uint8_t *dst, *dst_end;
> int count, ret;
>
> +if (buf_size < 7)
> +return AVERROR_INVALIDDATA;
> +
> if ((ret = ff_reget_buffer(avctx, s->frame)) < 0)
>
row_no_filter(AVCodecContext *avctx, void
> td->mv_bounds.mv_max.x = ((s->mb_width - 1) << 6) + MARGIN;
>
> for (mb_x = 0; mb_x < s->mb_width; mb_x++, mb_xy++, mb++) {
> -if (c->end <= c->buffer && c->bits >= 0)
> +
On Thu, Aug 15, 2019 at 11:00 AM Peter Collingbourne wrote:
>
> As of LLVM r368102, Clang will set a pointer tag in bits 56-63 of the
> address of a global when compiling with -fsanitize=hwaddress. This requires
> an adjustment to assembly code that takes the address of such globals
-fsanitize=hwaddress.
Signed-off-by: Peter Collingbourne
---
libavutil/aarch64/asm.S | 8
1 file changed, 8 insertions(+)
diff --git a/libavutil/aarch64/asm.S b/libavutil/aarch64/asm.S
index 5c329430fd..3ac2ba0d52 100644
--- a/libavutil/aarch64/asm.S
+++ b/libavutil/aarch64/asm.S
1 - 100 of 622 matches
Mail list logo
