Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

On Sat, May 18, 2024 at 1:20 AM Cosmin Stejerean via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > > > > On May 14, 2024, at 9:28 AM, Lynne via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> wrote: > > > > On 14/05/2024 17:09, Christian Bartnik wrote: > >> From: Thomas Siedel > >> Add external deco

[FFmpeg-devel] [PATCH 01/18] avcodec/vvcdec: misc, inter, use is_chroma instead of is_luma

--- libavcodec/vvc/inter.c | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 4a8d1d866a..3f0718cb5a 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -31,33 +31,33

[FFmpeg-devel] [PATCH 02/18] avcodec/vvcdec: refact, unify {luma, chroma}_mc to mc

--- libavcodec/vvc/inter.c | 47 +- 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 3f0718cb5a..8657541eaf 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -142,6 +142,8

[FFmpeg-devel] [PATCH 05/18] avcodec/vvcdec: misc, remove unused EMULATED_EDGE_{LUMA, CHROMA}, EMULATED_EDGE_DMVR_{LUAM, CHROMA}

--- libavcodec/vvc/inter.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 9132bfaee2..cc93184ca0 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -142,25 +142,13 @@ static void e

[FFmpeg-devel] [PATCH 06/18] avcodec/vvcdec: refact, unify pred_regular_{luma, chroma} to pred_regular

--- libavcodec/vvc/ctu.h | 3 +- libavcodec/vvc/inter.c | 133 + 2 files changed, 41 insertions(+), 95 deletions(-) diff --git a/libavcodec/vvc/ctu.h b/libavcodec/vvc/ctu.h index 4e38ecf54a..337d0e7c28 100644 --- a/libavcodec/vvc/ctu.h +++ b/libavcodec/

[FFmpeg-devel] [PATCH 03/18] avcodec/vvcdec: refact, unify {luma, chroma}_mc_uni to mc_uni

--- libavcodec/vvc/inter.c | 80 +- 1 file changed, 25 insertions(+), 55 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 8657541eaf..6d866c1bad 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -236,33 +236,

[FFmpeg-devel] [PATCH 18/18] Changelog: add DVB compatible information for VVC decoder

see https://dvb.org/specifications/verification-validation/vvc-test-content/ --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index dd25715d6b..12770e4296 100644 --- a/Changelog +++ b/Changelog @@ -10,6 +10,7 @@ version : - vf_scale supports secondary ref in

[FFmpeg-devel] [PATCH 08/18] avcodec/vvcdec: refact, pred_get_refs return VVCRefPic instead of VVCFrame

--- libavcodec/vvc/inter.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index cd96707c02..23d9ac05e6 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -387,15 +387,15 @@ static

[FFmpeg-devel] [PATCH 04/18] avcodec/vvcdec: refact, unify {luma, chroma}_mc_bi to mc_bi

--- libavcodec/vvc/inter.c | 95 +- 1 file changed, 30 insertions(+), 65 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 6d866c1bad..9132bfaee2 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -151,6 +151,9

[FFmpeg-devel] [PATCH 10/18] avcodec/vvcdec: emulated_edge, use reference frame's sps and pps

a preparation for Reference Picture Resampling --- libavcodec/vvc/dec.c | 3 +++ libavcodec/vvc/dec.h | 2 ++ libavcodec/vvc/inter.c | 54 ++ libavcodec/vvc/refs.c | 5 4 files changed, 38 insertions(+), 26 deletions(-) diff --git a/libavcodec/

[FFmpeg-devel] [PATCH 09/18] avcodec/vvcdec: add vvc inter filters for RPR

--- libavcodec/vvc/data.c | 83 - libavcodec/vvc/data.h | 10 +++-- libavcodec/vvc/inter.c | 8 ++-- tests/checkasm/vvc_mc.c | 12 +++--- 4 files changed, 98 insertions(+), 15 deletions(-) diff --git a/libavcodec/vvc/data.c b/libavcodec/vvc/data.c ind

[FFmpeg-devel] [PATCH 12/18] avcodec/vvcdec: inter, wait reference with a diffrent resolution

For RPR, the current frame may reference a frame with a different resolution. Therefore, we need to consider frame scaling when we wait for reference pixels. --- libavcodec/vvc/dec.c| 5 + libavcodec/vvc/dec.h| 17 + libavcodec/vvc/refs.c | 39 +++

[FFmpeg-devel] [PATCH 11/18] avcodec/vvcdec: add RPR dsp

--- libavcodec/vvc/ctu.h| 2 + libavcodec/vvc/dsp.h| 13 +++ libavcodec/vvc/inter_template.c | 168 3 files changed, 183 insertions(+) diff --git a/libavcodec/vvc/ctu.h b/libavcodec/vvc/ctu.h index 337d0e7c28..50109154aa 100644 --- a/lib

[FFmpeg-devel] [PATCH 14/18] avcodec/vvcdec: refact out luma_prof from luma_prof_bi

--- libavcodec/vvc/inter.c | 52 -- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index f432a2dc3c..23b9a8af6b 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -347,40 +347,

[FFmpeg-devel] [PATCH 13/18] avcodec/vvcdec: fix dmvr, bdof, cb_prof for RPR

--- libavcodec/vvc/ctu.c | 18 +- libavcodec/vvc/mvs.c | 3 ++- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/libavcodec/vvc/ctu.c b/libavcodec/vvc/ctu.c index 242caa58f7..809510b93d 100644 --- a/libavcodec/vvc/ctu.c +++ b/libavcodec/vvc/ctu.c @@ -1689,25 +1689,

[FFmpeg-devel] [PATCH 16/18] avcodec/vvcdec: increase edge_emu_buffer for RPR

--- libavcodec/vvc/ctu.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/vvc/ctu.h b/libavcodec/vvc/ctu.h index 50109154aa..a987328d81 100644 --- a/libavcodec/vvc/ctu.h +++ b/libavcodec/vvc/ctu.h @@ -46,7 +46,8 @@ #define MAX_QP 63 #defi

[FFmpeg-devel] [PATCH 15/18] avcodec/vvcdec: refact, remove hf_idx and vf_idx from mc_xxx's param list

--- libavcodec/vvc/inter.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 23b9a8af6b..5d553708d9 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -208,6 +208,7 @@ static void

[FFmpeg-devel] [PATCH 17/18] avcodec/vvcdec: support Reference Picture Resampling

passed clips: RPR_A_Alibaba_4.bit RPR_B_Alibaba_3.bit RPR_C_Alibaba_3.bit RPR_D_Qualcomm_1.bit VVC_HDR_UHDTV1_OpenGOP_Max3840x2160_50fps_HLG10_res_change_with_RPR.ts --- libavcodec/vvc/inter.c | 190 + 1 file changed, 173 insertions(+), 1

[FFmpeg-devel] [PATCH 07/18] avcodec/vvcdec: refact out VVCRefPic from RefPicList

--- libavcodec/vvc/ctu.c| 10 +- libavcodec/vvc/dec.c| 4 ++-- libavcodec/vvc/dec.h| 10 +++--- libavcodec/vvc/filter.c | 22 +++--- libavcodec/vvc/inter.c | 4 ++-- libavcodec/vvc/mvs.c| 36 ++-- libavcodec/vvc/refs.c

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h266: read vps_ptl_max_tid before using it

On Sun, May 19, 2024 at 9:28 PM James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs_h266_syntax_template.c | 28 ++- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/libavcodec/cbs_h266_syntax_template.c > b/libavcodec/cbs_h266_synt

Re: [FFmpeg-devel] [PATCH 7/9] avcodec/vvc/mvs: Initialize mvf

On Sun, May 19, 2024 at 10:50 AM Michael Niedermayer wrote: > This might not be needed for correctness but it could > help general reproducability of issues > > Related to: CID1560037 Uninitialized scalar variable > Related to: CID1560044 Uninitialized scalar variable > > Sponsored-by: Sovereign

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/vvc/dec: Check init_get_bits8() for failure

On Sun, May 19, 2024 at 10:50 AM Michael Niedermayer wrote: > Fixes: CID1560042 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/vvc/dec.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/

Re: [FFmpeg-devel] [PATCH 3/9] avcodec/vvc/ctu: Simplify pred_mode_plt_flag

On Sun, May 19, 2024 at 10:49 AM Michael Niedermayer wrote: > Fixes: CID1560039 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/vvc/ctu.c | 23 ++- > 1 file changed, 6 insertions(+), 17 deletions(-) > > diff -

Re: [FFmpeg-devel] [PATCH 12/18] avcodec/vvcdec: inter, wait reference with a diffrent resolution

On Sun, May 19, 2024 at 11:21 PM Jean-Baptiste Kempf wrote: > Careful about the typo on "different" on the title of the patch. > Changed locally. Thank you, jb > > On Sun, 19 May 2024, at 13:27, Nuo Mi wrote: > > For RPR, the current frame may reference a frame w

Re: [FFmpeg-devel] [PATCH] checkasm: vvc_alf: Limit benchmarking to a reasonable subset of functions

On Tue, May 21, 2024 at 7:11 PM Rémi Denis-Courmont wrote: > > > Le 21 mai 2024 13:04:29 GMT+03:00, "Martin Storsjö" a > écrit : > >Don't benchmark every single combination of widths and heights; > >only benchmark cases which are squares (like in vvc_mc.c). > > > >Contrary to vvc_mc, which incre

Re: [FFmpeg-devel] [PATCH 18/18] Changelog: add DVB compatible information for VVC decoder

On Sun, May 19, 2024 at 9:39 PM Nuo Mi wrote: > see > https://dvb.org/specifications/verification-validation/vvc-test-content/ > --- > Changelog | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Changelog b/Changelog > index dd25715d6b..12770e4296 100644 &

Re: [FFmpeg-devel] [PATCH] checkasm: vvc_alf: Limit benchmarking to a reasonable subset of functions

On Tue, May 21, 2024 at 6:16 PM Martin Storsjö wrote: > On Tue, 21 May 2024, Martin Storsjö wrote: > > > Don't benchmark every single combination of widths and heights; > > only benchmark cases which are squares (like in vvc_mc.c). > > > > Contrary to vvc_mc, which increases sizes by doubling dim

Re: [FFmpeg-devel] 回复: [PATCH] x86/vvc_alf: use the x86inc instruction macros

On Wed, May 22, 2024 at 12:29 AM Wu Jianhua wrote: > > 发件人: ffmpeg-devel 代表 James Almer < > jamr...@gmail.com> > > 发送时间: 2024年5月21日 6:52 > > 收件人: ffmpeg-devel@ffmpeg.org > > 主题: [FFmpeg-devel] [PATCH] x86/vvc_alf: use the x86inc instruction macros > > > > Let its magic figure out the correct mne

Re: [FFmpeg-devel] [PATCH v5 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

On Thu, May 23, 2024 at 7:38 AM James Almer wrote: > On 5/21/2024 10:01 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, May 21, 2024 at 8:01 PM Stone Chen > wrote: > > > >> Implements AVX2 DMVR (decoder-side motion vector refinement) SAD > >> functions. DMVR SAD is only calculated if w >= 8,

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add external enc libvvenc for H266/VVC

Hi @Andreas, Thank you for the review. Seems Christian still needs some guidance from you, see 1, 2, 3 On Thu, May 16, 2024 at 11:22 PM Christian wrote: > > > > On 14. May 2024, at 18:49, Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > > > > Christian Bartnik: > >> From: Thomas Si

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Validate temporal MVP references

ecoding some fuzzed bitstreams. > > Additionally, only set up the collocated reference picture if it is > actually going to be used (i.e. if ph_temporal_mvp_enabled_flag is 1), > else legal RPR bitstreams will fail the new checks. > Applied, thank you, Frank. > > Co-authored-b

Re: [FFmpeg-devel] [PATCH v1 2/2][GSoC 2024] tests/checkasm/vvc_mc: for SAD, only test valid subblock sizes

On Wed, May 29, 2024 at 3:10 AM Stone Chen wrote: > According to the VVC specification (section 8.5.1), the maximum > width/height of a subblock passed for DMVR SAD is 16. This along with > previous constraint requiring width * height >= 128 means that 8x16, 16x8, > and 16x16 are the only allowe

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvc_alf: fix integer overflow

On Fri, May 31, 2024 at 4:49 AM Ronald S. Bultje wrote: > Hi Andreas, > > On Thu, May 30, 2024 at 2:33 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > > > toq...@outlook.com: > > > From: Wu Jianhua > > > > > > Some tests fails with certain seeds > > > > > > tests/checkasm/chec

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvc_alf: fix integer overflow

On Fri, May 31, 2024 at 2:29 AM Ronald S. Bultje wrote: > Hi, > > On Thu, May 30, 2024 at 12:28 PM wrote: > > > From: Wu Jianhua > > > > Some tests fails with certain seeds > > > > tests/checkasm/checkasm 2325607578 --test=vvc_alf > > checkasm: using random seed 2325607578 > > AVX2: > > vvc

Re: [FFmpeg-devel] [PATCH 2/2] tests/checkasm/vvc_mc: don't zero the SAD buffers

On Wed, May 29, 2024 at 10:03 PM James Almer wrote: > They will be filled immediately after. > Pushed. thank you, James > > Signed-off-by: James Almer > --- > tests/checkasm/vvc_mc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/checkasm/vvc_mc.c b/tests/checkasm/vvc_mc.c >

[FFmpeg-devel] [PATCH 3/5] avcodec/vvcdec: refact out emulated_edge_no_wrap

prepare for refrence wraparound --- libavcodec/vvc/inter.c | 91 -- 1 file changed, 61 insertions(+), 30 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 07b55c4bac..aacd5d8da0 100644 --- a/libavcodec/vvc/inter.c +++ b/libavco

[FFmpeg-devel] [PATCH 4/5] avcodec/vvcdec: misc, reindent inter.c

--- libavcodec/vvc/inter.c | 278 - 1 file changed, 139 insertions(+), 139 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index aacd5d8da0..09575eb2b4 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -127,14 +12

[FFmpeg-devel] [PATCH 5/5] avcodec/vvcdec: support mv wraparound

A 360 video specific tool see https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9503377 passed files: DMVR_A_Huawei_3.bit WRAP_D_InterDigital_4.bit WRAP_A_InterDigital_4.bit WRAP_B_InterDigital_4.bit WRAP_C_InterDigital_4.bit ERP_A_MediaTek_3.bit --- libavcodec/vvc/inte

[FFmpeg-devel] [PATCH 1/5] avcodec/vvcdec: refact, remove emulated_edge_dmvr and emulated_edge_bilinear to simplify code

--- libavcodec/vvc/inter.c | 146 + 1 file changed, 46 insertions(+), 100 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index e1011b4fa1..0843c99eb6 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -44,112 +44,

[FFmpeg-devel] [PATCH 2/5] avcodec/vvcdec: misc, move src offset inside emulated_edge

--- libavcodec/vvc/inter.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 0843c99eb6..07b55c4bac 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -57,6 +57,8 @@ static void emulated_edge

Re: [FFmpeg-devel] [PATCH v4 1/1] avcodec: add external enc libvvenc for H266/VVC

Hi all, Tested with ./ffmpeg -f lavfi -i testsrc=duration=10:size=1280x720:rate=30 -c:v libvvenc test.mp4 && ./ffplay -strict -2 -i test.mp4 I will merge in 3 days if there are no objections. thank you On Wed, May 29, 2024 at 12:27 AM Christian Bartnik wrote: > From: Thomas Siedel > > Add ext

[FFmpeg-devel] [PATCH v2 1/5] avcodec/vvcdec: refact, remove emulated_edge_dmvr and emulated_edge_bilinear to simplify code

--- libavcodec/vvc/inter.c | 146 + 1 file changed, 46 insertions(+), 100 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index e1011b4fa1..0843c99eb6 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -44,112 +44,

[FFmpeg-devel] [PATCH v2 2/5] avcodec/vvcdec: misc, move src offset inside emulated_edge

--- libavcodec/vvc/inter.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 0843c99eb6..07b55c4bac 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -57,6 +57,8 @@ static void emulated_edge

[FFmpeg-devel] [PATCH v2 3/5] avcodec/vvcdec: refact out emulated_edge_no_wrap

prepare for refrence wraparound --- libavcodec/vvc/inter.c | 91 -- 1 file changed, 61 insertions(+), 30 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 07b55c4bac..aacd5d8da0 100644 --- a/libavcodec/vvc/inter.c +++ b/libavco

[FFmpeg-devel] [PATCH v2 4/5] avcodec/vvcdec: misc, reindent inter.c

--- libavcodec/vvc/inter.c | 278 - 1 file changed, 139 insertions(+), 139 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index aacd5d8da0..09575eb2b4 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -127,14 +12

[FFmpeg-devel] [PATCH v2 5/5] avcodec/vvcdec: support mv wraparound

A 360 video specific tool see https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9503377 passed files: DMVR_A_Huawei_3.bit WRAP_D_InterDigital_4.bit WRAP_A_InterDigital_4.bit WRAP_B_InterDigital_4.bit WRAP_C_InterDigital_4.bit ERP_A_MediaTek_3.bit --- libavcodec/vvc/inte

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vvcdec: support mv wraparound

On Tue, Jun 4, 2024 at 8:41 AM Michael Niedermayer wrote: > On Mon, Jun 03, 2024 at 08:51:16PM +0800, Nuo Mi wrote: > > A 360 video specific tool > > see https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9503377 > > > > passed files: > > DMVR_A_Huawei_3.

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Reallocate pixel buffers if pixel shift changes

On Mon, Jun 3, 2024 at 9:06 PM Frank Plowman wrote: > Allocations in the following lines depend on the pixel shift, and so > these buffers must be reallocated if the pixel shift changes. Patch > fixes segmentation faults in fuzzed bitstreams. > > Signed-off-by: Frank Plowman > --- > libavcodec

Re: [FFmpeg-devel] [PATCH v2 2/2] lavc/vvc: Prevent overflow in chroma QP derivation

Hi Frank, Thank you for the patch On Wed, Jun 5, 2024 at 5:24 PM Frank Plowman wrote: > On the top of p. 112 in VVC (09/2023): > > It is a requirement of bitstream conformance that the values of > qpInVal[ i ][ j ] and qpOutVal[ i ][ j ] shall be in the range > of −QpBdOffset to 63, inclusive fo

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/vvc: Use sps_chroma_qp_table return code

this code is simple, you can combine it with the next one On Wed, Jun 5, 2024 at 5:24 PM Frank Plowman wrote: > Signed-off-by: Frank Plowman > --- > libavcodec/vvc/ps.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vvc/ps.c b/libavcodec/vvc/ps.c > i

Re: [FFmpeg-devel] [PATCH 4/7] avformat/vvc: Fix crash on allocation failure, avoid allocations

On Wed, Jun 5, 2024 at 7:53 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Andreas Rheinhardt: > > This is the VVC version of 8b5d15530127fea54e934043a64653859de07353. > > > > (Hint: This ensures that the order of NALU arrays is OPI-VPS-SPS-PPS- > > Prefix-SEI-Suffix-SEI, regardl

Re: [FFmpeg-devel] [PATCH 4/7] avformat/vvc: Fix crash on allocation failure, avoid allocations

On Wed, Jun 5, 2024 at 7:41 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > This is the VVC version of 8b5d15530127fea54e934043a64653859de07353. > > (Hint: This ensures that the order of NALU arrays is OPI-VPS-SPS-PPS- > Prefix-SEI-Suffix-SEI, regardless of the order in the origin

Re: [FFmpeg-devel] [PATCH v2 5/5] avcodec/vvcdec: support mv wraparound

On Tue, Jun 4, 2024 at 8:04 PM Nuo Mi wrote: > A 360 video specific tool > see https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9503377 > > passed files: > DMVR_A_Huawei_3.bit > WRAP_D_InterDigital_4.bit > WRAP_A_InterDigital_4.bit > W

Re: [FFmpeg-devel] [PATCH 4/7] avformat/vvc: Fix crash on allocation failure, avoid allocations

On Sun, Jun 9, 2024 at 5:14 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Nuo Mi: > > On Wed, Jun 5, 2024 at 7:41 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> This is the VVC version of 8b5d15530127fea

Re: [FFmpeg-devel] [PATCH] avcodec/vvc/inter: Don't return void

LGTM. Thank you, Andreas On Mon, Jun 10, 2024 at 1:37 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Returning a void is not allowed by the spec. Just return instead. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vvc/inter.c | 9 ++--- > 1 file changed, 6 insert

Re: [FFmpeg-devel] [PATCH] fate/vvc: add vvc-conformance-RPR_A_Alibaba_4

Hi Frank, Thank you for the patch. Could we follow the naming conventions used for other clips? On Mon, Jun 10, 2024 at 2:45 AM Frank Plowman wrote: > BeforeAfter > - > make fate-vvc CPU Time (No ASM) 131.52s

Re: [FFmpeg-devel] [PATCH v1] lavc/qsvdec: Add VVC decoder

Hi Fei, Thank you for the patch. Which hardware supports this? Could you provide the link? On Wed, Jun 12, 2024 at 9:03 AM wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- > Changelog | 1 + > configure | 1 + > doc/decoders.texi | 2 +- > libavcodec/al

Re: [FFmpeg-devel] [PATCH v4] lavc/vvc: Prevent overflow in chroma QP derivation

On Sun, Jun 9, 2024 at 7:18 PM Frank Plowman wrote: > On the top of p. 112 in VVC (09/2023): > > It is a requirement of bitstream conformance that the values of > qpInVal[ i ][ j ] and qpOutVal[ i ][ j ] shall be in the range > of −QpBdOffset to 63, inclusive for i in the range of 0 to > numQpTab

Re: [FFmpeg-devel] [PATCH v5 1/1] avcodec: add external enc libvvenc for H266/VVC

Hi all, If there are no objections, I will push it in 3 days. Thank you, Christian On Thu, Jun 6, 2024 at 3:52 AM Christian Bartnik wrote: > From: Thomas Siedel > > Add external encoder VVenC for H266/VVC encoding. > Register new encoder libvvenc. > Add libvvenc to wrap the vvenc interface.

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Invalidate PPSs which refer to a changed SPS

On Sat, Jun 15, 2024 at 2:35 PM Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > Le ven. 14 juin 2024, 11:39, Frank Plowman a > écrit : > > > When the SPS associated with a particular SPS ID changes, invalidate all > > the PPSs which use that SPS ID. Fixes crashes with illegal bitstre

Re: [FFmpeg-devel] [PATCH v5 1/1] avcodec: add external enc libvvenc for H266/VVC

On Wed, Jun 12, 2024 at 9:36 PM Nuo Mi wrote: > Hi all, > If there are no objections, I will push it in 3 days. > > Thank you, Christian > > > On Thu, Jun 6, 2024 at 3:52 AM Christian Bartnik > wrote: > >> From: Thomas Siedel >> >> Add external enc

Re: [FFmpeg-devel] [PATCH] rtp enc/dec update for vvc

On Sat, Jun 15, 2024 at 2:38 AM Frank Plowman wrote: > Hi, > > Thanks for the patch. Unfortunately it looks to be corrupted and does > not apply. Also, it looks as though you submitted five near-identical > patches. I would suggest you try directing patches to your own mailbox > and re-applyin

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Invalidate PPSs which refer to a changed SPS

On Sun, Jun 16, 2024 at 12:38 AM Frank Plowman wrote: > n 15/06/2024 13:24, Nuo Mi wrote: > > On Sat, Jun 15, 2024 at 2:35 PM Christophe Gisquet < > > christophe.gisq...@gmail.com> wrote: > > > >> Le ven. 14 juin 2024, 11:39, Frank Plowman a > >> éc

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Invalidate PPSs which refer to a changed SPS

On Sun, Jun 16, 2024 at 11:26 PM Mark Thompson wrote: > On 15/06/2024 17:37, Frank Plowman wrote: > > n 15/06/2024 13:24, Nuo Mi wrote: > >> On Sat, Jun 15, 2024 at 2:35 PM Christophe Gisquet < > >> christophe.gisq...@gmail.com> wrote: > >> > >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

On Mon, Jun 17, 2024 at 5:28 PM Zhao Zhili wrote: > > > > On Jun 17, 2024, at 16:45, Hendrik Leppkes wrote: > > > > On Mon, Jun 17, 2024 at 10:03 AM Zhao Zhili > wrote: > >> > >> > >> > >>> On Jun 17, 2024, at 15:05, Anton Khirnov wrote: > >>> > >>> Quoting Zhao Zhili (2024-06-17 07:19:26) > >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

On Tue, Jun 18, 2024 at 8:06 PM Steven Liu wrote: > Nuo Mi 于2024年6月18日周二 19:51写道： > > > > On Mon, Jun 17, 2024 at 5:28 PM Zhao Zhili > wrote: > > > > > > > > > > > > On Jun 17, 2024, at 16:45, Hendrik Leppkes > wrote: > > >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

On Tue, Jun 18, 2024 at 10:24 PM Zhao Zhili wrote: > > > > On Jun 18, 2024, at 19:50, Nuo Mi wrote: > > > > On Mon, Jun 17, 2024 at 5:28 PM Zhao Zhili > wrote: > > > >> > >> > >>> On Jun 17, 2024, at 16:45, Hendrik Leppkes &

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Invalidate PPSs which refer to a changed SPS

Hi all, I will merge this tomorrow if there are no objections. Thank you. On Mon, Jun 17, 2024 at 9:23 PM Nuo Mi wrote: > > > On Sun, Jun 16, 2024 at 11:26 PM Mark Thompson wrote: > >> On 15/06/2024 17:37, Frank Plowman wrote: >> > n 15/06/2024 13:24, Nuo Mi wrote:

Re: [FFmpeg-devel] [PATCH v2] fate/vvc: add vvc-conformance-RPR_A_4

Sorry for missing this. Merged by James as https://github.com/FFmpeg/FFmpeg/commit/0eacad6921c6835d0432f02b1aa5ec9b492a3572 Thank you, James and Frank On Thu, Jun 20, 2024 at 6:13 PM Frank Plowman wrote: > On 10/06/2024 18:46, Frank Plowman wrote: > > Before

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Invalidate PPSs which refer to a changed SPS

On Wed, Jun 19, 2024 at 4:53 PM Nuo Mi wrote: > Hi all, > I will merge this tomorrow if there are no objections. > >> >>> Applied. Thank you, Frank, Christophe, Mark, and Anton, for a good discussion. ___ ffmpeg-devel m

[FFmpeg-devel] [PATCH 3/4] x86/vvc_alf: avoid overwriting for non-16 aligned widths

Previously, the code allowed overwriting on 16-aligned blocks, which was suitable when there were no picture's virtual boundaries because both CTU sizes and strides were 16-aligned. However, with picture's virtual boundaries, each CTU is divided into four ALF blocks, leading to potential issues

[FFmpeg-devel] [PATCH 4/4] checkasm/vvc_alf: ensure right and bottom boundaries are not overwritten by asm

--- tests/checkasm/vvc_alf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c index be8b930810..15e79289cd 100644 --- a/tests/checkasm/vvc_alf.c +++ b/tests/checkasm/vvc_alf.c @@ -108,8 +108,8 @@ static void check_alf_f

[FFmpeg-devel] [PATCH 1/4] checkasm/vvc_alf: only check the valid filter and classify sizes

--- tests/checkasm/vvc_alf.c | 61 ++-- 1 file changed, 34 insertions(+), 27 deletions(-) diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c index 84b0f9da15..902757aff1 100644 --- a/tests/checkasm/vvc_alf.c +++ b/tests/checkasm/vvc_alf.c @@ -90,3

[FFmpeg-devel] [PATCH 2/4] checkasm/vvc_alf: random select alf virtual boundaries position

A picture's virtual boundaries will split a CTU into 4 ALF blocks. The ALF virtual boundary may cross or not cross a ALF block. --- tests/checkasm/vvc_alf.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c inde

[FFmpeg-devel] [PATCH 01/18] avcodec/vvcdec: refact, unify vvc_deblock_subblock_bs_{horizontal, vertical}

--- libavcodec/vvc/filter.c | 93 ++--- 1 file changed, 32 insertions(+), 61 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 7844d34eac..d4c09b69f3 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -406,30 +

[FFmpeg-devel] [PATCH 03/18] avcodec/vvcdec: refact, unify vvc_deblock_bs_chroma_{horizontal, vertical}

--- libavcodec/vvc/filter.c | 62 + 1 file changed, 19 insertions(+), 43 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 996e58dc3e..06e1717b13 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -586,56 +

[FFmpeg-devel] [PATCH 02/18] avcodec/vvcdec: refact, unify vvc_deblock_bs_luma_{horizontal, vertical}

--- libavcodec/vvc/filter.c | 108 ++-- 1 file changed, 36 insertions(+), 72 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index d4c09b69f3..996e58dc3e 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -538,100

[FFmpeg-devel] [PATCH 15/18] avcodec/vvcdec: ps, derive virtual boundaries

--- libavcodec/vvc/ps.c | 45 + libavcodec/vvc/ps.h | 6 ++ 2 files changed, 51 insertions(+) diff --git a/libavcodec/vvc/ps.c b/libavcodec/vvc/ps.c index 92368eafc2..58496c9fba 100644 --- a/libavcodec/vvc/ps.c +++ b/libavcodec/vvc/ps.c @@ -796,8 +

[FFmpeg-devel] [PATCH 04/18] avcodec/vvcdec: refact, unify {horizontal, vertical}_bs, {horizontal, vertical}_p, {horizontal, vertical}_q

--- libavcodec/vvc/dec.c| 14 +++--- libavcodec/vvc/dec.h| 9 +++-- libavcodec/vvc/filter.c | 32 +++- 3 files changed, 21 insertions(+), 34 deletions(-) diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c index f5603306f3..356ed58e37 100644 -

[FFmpeg-devel] [PATCH 05/18] avcodec/vvcdec: misc, use POS to simplify filter code

--- libavcodec/vvc/filter.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 7ae36b2344..82a58a7ea8 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -34,6 +34,10 @@ #define

[FFmpeg-devel] [PATCH 07/18] avcodec/vvcdec: refact out sao_get_edges

--- libavcodec/vvc/filter.c | 119 ++-- 1 file changed, 65 insertions(+), 54 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 89b794195e..1326d2c82e 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -155,70 +

[FFmpeg-devel] [PATCH 06/18] avcodec/vvcdec: refact, unify ff_vvc_deblock_{horizontal, vertical}

--- libavcodec/vvc/filter.c | 153 1 file changed, 44 insertions(+), 109 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 82a58a7ea8..89b794195e 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -712,144

[FFmpeg-devel] [PATCH 09/18] avcodec/vvcdec: refact, fix naming convention of x0, y0 for sao

it's mismatched with the ff_vvc_sao_filter function declaration --- libavcodec/vvc/filter.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 534ba57205..10d11ce31f 100644 --- a/libavcodec/vvc/filt

[FFmpeg-devel] [PATCH 08/18] avcodec/vvcdec: refact out sao_extends_edges

--- libavcodec/vvc/filter.c | 108 +++- 1 file changed, 50 insertions(+), 58 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 1326d2c82e..534ba57205 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -214,6 +2

[FFmpeg-devel] [PATCH 10/18] avcodec/vvcdec: misc, reformat ff_vvc_sao_filter

--- libavcodec/vvc/filter.c | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 10d11ce31f..3aa241ad90 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -266,44 +

[FFmpeg-devel] [PATCH 11/18] avcodec/vvcdec: refact out alf_get_edges

--- libavcodec/vvc/filter.c | 53 - 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 3aa241ad90..671e599dab 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -1036,6 +

[FFmpeg-devel] [PATCH 12/18] avcodec/vvcdec: misc, remove unused ALFParams.applied

--- libavcodec/vvc/ctu.h| 2 -- libavcodec/vvc/filter.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/libavcodec/vvc/ctu.h b/libavcodec/vvc/ctu.h index a987328d81..432dbc5ade 100644 --- a/libavcodec/vvc/ctu.h +++ b/libavcodec/vvc/ctu.h @@ -461,8 +461,6 @@ typedef struct ALFParams {

[FFmpeg-devel] [PATCH 13/18] avcodec/vvcdec: misc, constify ALFParams

--- libavcodec/vvc/filter.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 457e2b99c2..a5635c60df 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -926,7 +926,7 @@ static void alf_prepare_b

[FFmpeg-devel] [PATCH 14/18] cbs_h266: add VVC_MAX_VBS for max num of virtual boundaries

--- libavcodec/cbs_h266.h | 8 libavcodec/cbs_h266_syntax_template.c | 8 libavcodec/vvc.h | 3 +++ 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h index 21b9a4196c..5f12915b65 1006

[FFmpeg-devel] [PATCH 17/18] avcodec/vvcdec: sao, support virtual boundaries

--- libavcodec/vvc/filter.c | 46 + 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 69d67cb7f6..44dd895d7d 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -20,6 +20,

[FFmpeg-devel] [PATCH 16/18] avcodec/vvcdec: deblock, support virtual boundaries

--- libavcodec/vvc/filter.c | 34 ++ 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index a5635c60df..69d67cb7f6 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -55,6 +55,29 @@ s

[FFmpeg-devel] [PATCH 18/18] avcodec/vvcdec: alf, support virtual boundaries

see https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=9503377 passed files: GDR_A_ERICSSON_2.bit GDR_B_NOKIA_2.bit GDR_C_NOKIA_2.bit VIRTUAL_A_MediaTek_3.bit VIRTUAL_B_MediaTek_3.bit --- libavcodec/vvc/ctu.h| 7 +++ libavcodec/vvc/filter.c | 134 ++

Re: [FFmpeg-devel] [PATCH 18/18] avcodec/vvcdec: alf, support virtual boundaries

On Sat, Jun 22, 2024 at 2:24 PM Nuo Mi wrote: > see https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=9503377 > > passed files: > GDR_A_ERICSSON_2.bit > GDR_B_NOKIA_2.bit > GDR_C_NOKIA_2.bit > VIRTUAL_A_MediaTek_3.bit > VIRTUAL_B_MediaTek

Re: [FFmpeg-devel] [PATCH 4/4] checkasm/vvc_alf: ensure right and bottom boundaries are not overwritten by asm

Applied. Thank you Ben for reviewing. On Sat, Jun 22, 2024 at 12:21 PM Nuo Mi wrote: > --- > tests/checkasm/vvc_alf.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c > index be8b930810.

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

On Mon, Jun 24, 2024 at 12:48 PM Zhao Zhili wrote: > From: Zhao Zhili > > Before the patch, disable threads support at configure/build time > was the only method to force zero thread in executor. However, > it's common practice for libavcodec to run on caller's thread when > user specify thread

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Validate IBC block vector

On Mon, Jun 24, 2024 at 9:31 PM Frank Plowman wrote: > From H.266 (V3) (09/2023) p. 321: > > It is a requirement of bitstream conformance that the luma block > vector bvL shall obey the following constraints: > - CtbSizeY is greater than or equal to > ((yCb + (bvL[ 1 ] >> 4)) & (CtbSizeY − 1)) +

Re: [FFmpeg-devel] [PATCH 18/18] avcodec/vvcdec: alf, support virtual boundaries

On Tue, Jun 25, 2024 at 8:48 PM James Almer wrote: > On 6/25/2024 8:53 AM, Nuo Mi wrote: > > On Sat, Jun 22, 2024 at 2:24 PM Nuo Mi wrote: > > > >> see https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=9503377 > >> > >> passed files: > >

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Validate IBC block vector

On Wed, Jun 26, 2024 at 1:04 AM Frank Plowman wrote: > From H.266 (V3) (09/2023) p. 321: > > It is a requirement of bitstream conformance that the luma block > vector bvL shall obey the following constraints: > - CtbSizeY is greater than or equal to > ((yCb + (bvL[ 1 ] >> 4)) & (CtbSizeY − 1)) +

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Don't discard return codes

Merged. On Wed, Jun 26, 2024 at 1:06 AM Frank Plowman wrote: > Signed-off-by: Frank Plowman > --- > libavcodec/vvc/thread.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/vvc/thread.c b/libavcodec/vvc/thread.c > index c90c316661..118d56b67e 100644

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Always set flags for the current picture

On Mon, Jun 24, 2024 at 11:30 PM Frank Plowman wrote: > ff_vvc_frame_rpl uses the flags to detect whether a frame is in use. > Therefore, in the case of a CVSS AU (RASL/GDR with > NoOutputBeforeRecoveryFlag) with ph_non_ref_pic_flag = 1, the frame > would be freed before it is used. Fix this by

  1   2   3   4   5   6   7   8   9   10   >