upport later or around the time of the API bump.
Ok, no objection from me.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmp
ng the functionality to patchwork to check
> whether a patch introduces new compiler warnings. This has been found
> this way.
It is useful indeed. But I should have spotted it. Thanks.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
Signed-off-by: Nicolas George
---
doc/filters.texi | 34 ++
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/vf_untile.c | 198 +++
tests/fate/filter-video.mak | 3 +
tests/ref/fate/filter-untile
to catch user mistakes.
It can be changed later easily anyway if an actual use case becomes
known.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinf
ormation that it was checked
externally. For example by checking the output of ffprobe on the
produced files before and after the patch. Seems like an obvious step.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel
or the movenc test to be that
kind of abomination?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link
Paul B Mahol (12020-04-17):
> trival patch, apply at will.
It is not a trivial patch when it has required a v3.
Let's stop applying at will.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmp
rame);
>
> +/**
> + * Peek samples from the link's FIFO.
> + *
> + * @return >0 if a samples are available,
> + * 0 and set rframe to NULL if no samples are available,
> + * or AVERROR code
> + */
> +int ff_inlink_peek_samples(AVFilterLink
ed to make it, run it, note
carefully the results, and the go back to your work and consign the
results in the relevant commit message.
I mean, I do not know how you work, but personally I frequently add tons
of av_log() everywhere to track an issue. But they never get to the
mailing list.
Regar
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with
t message.
A commit that changes tests reference files should explain what changed.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ff
ults. For example, did you
re-run the tests with -w, as suggested in
https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/260837.html
to examine the files before and after the change?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
-empty-moov.mp4 > non-empty-moov.hex
> [lmwang@vpn ffmpeg]$ hexdump -C non-empty-moov1.mp4 > non-empty-moov1.hex
> [lmwang@vpn ffmpeg]$ diff non-empty-moov.hex non-empty-moov1.hex
As a side note, never use diff without the -u option, it is annoying to
read.
Regards,
--
Nicolas G
s. Find the exact cause of the crash. The value 1 is
allowed by the option system, it is therefore a priori supposed to work,
rejecting it somewhere else is not a proper fix.
> +av_log(s, AV_LOG_ERROR, "pad should smaller than 1.0\n");
Also a missing verb.
Regards,
--
Nic
e RESULTING FILE with a DIFFERENT TOOL.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or e
quot;movenc API", I thought our muxers where mostly
interchangeable.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To uns
gt; 2020-04-15 - xx - lavc 58.79.100 - avcodec.h
>Add formal support for calling avcodec_flush_buffers() on encoders.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-
*/
>
> #define LIBAVUTIL_VERSION_MAJOR 56
> -#define LIBAVUTIL_VERSION_MINOR 42
> +#define LIBAVUTIL_VERSION_MINOR 43
> #define LIBAVUTIL_VERSION_MICRO 102
The micro is supposed to be reset after a minor bump.
Sorry for not having spotted it last time.
>
> #
VDD 2019 and FOSDEM 2020.
> There is probably a better way to do this, but the aim is just to
> 'bootstrap' and kickstart the process and commitees.
Since it is only useful once, is there a point in having it in the tree?
Regards,
--
Nicolas George
pdate doc/ffprobe.xsd if you add a field. And the
updates to the ref files belong in the same commit.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/
) / s->maxval;
> for (j = 0; j < n; j++)
> -ptr[j] = (s->bytestream[j] * f + 64) >> 7;
> +ptr[j] = ((s->bytestream[j] - (s->maxval / 2 - 1) *
> s->jasper_signed) * f + 64) >> 7;
> } else if (upgra
Steven Liu (12020-04-27):
> and add testcase into url for double dot corner case
Did you run FATE?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.
Steven Liu (12020-04-27):
> Haha, Patchwork returned it, will fix that.
Please run FATE yourself before submitting patches.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.
Nicolas George (12020-04-27):
> Please run FATE yourself before submitting patches.
And please heed reply-to headers. It's already annoying enough to have
you twice in Cc, it's REALLY annoying to get CCed when I explicitly
asked not to in the proper technical way.
(Seriously, people
Steven Liu (12020-04-27):
> Do you mean you don’t want in the cc list?
> I think can remove you from cc list if you don’t want in it.
I want you to do exactly as the headers direct you to do.
Regards,
--
Nicolas George
signature.asc
Description: PGP sig
server/foo/baz
> http://server/foo/bar baz =>
> http://server/foo/baz
> http://server/foo/ ../baz =>
> http://server/baz
> @@ -12,6 +13,8 @@ Testing ff_make_absolute_url:
> h
you know,
absolute.
It can even be considered a security issue, since other parts of the
code could assume that the output of ff_make_absolute_url() is actually
absolute.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
f
rds,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subj
Steven Liu (12020-04-27):
> Command line?
There is none.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit l
tiny unforeseen detail.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-r
Paul B Mahol (12021-02-05):
> Signed-off-by: Paul B Mahol
> ---
> libavfilter/vf_tile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing
er correcly enough.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-
ourse of action is to generalize what was done with v4l: make
it an option.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
e, except for a single
function name.
Please try to merge it to avoid duplication.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/f
fferent computers?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ..
ense. The accuracy of a PC wall time clock with NTP is
plenty accurate enough for most practical purposes.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.or
am not a driver developer. All I know is
that the kernel can give me a timestamp based on the NTP-synchronized
wall time clock, and that it has better than 1/100 second accuracy,
which is plenty enough for must use cases.
Regards,
--
Nicolas George
signature.asc
Description: PGP
pplication that captures the two
cameras can detect that one is faster than the other and duplicate or
skip frames as necessary. Without a common timestamp, it is not
possible.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpe
pveyor.com/project/mcmtroffaes/ffmpeg-msvc-build/builds/37633531/job/x19boq3c5qi4u132#L414
>
> The attached patch fixes this.
Should be ok, thanks.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel m
> user supplied enable option for filter(s).
>
> Signed-off-by: Paul B Mahol
> ---
> libavfilter/avfilter.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
LGTM, thanks.
Regards,
--
Nicolas George
signatu
igured system, the wall time clock is
monotonic.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link
as not, this is why we need both as
options. Because YOU do not know if the user's computers are correctly
synchronized, YOU do not know if the user needs to synchronise between
different computers. But the users knows. Hence the option. For the
user, because the user knows.
Regards,
--
Nic
sequences better than you, since you did
not even realize why the wall time clock was needed.
I think this should be the end of the discussion.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg
t matter. What matters is that in practice it
works, full stop.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, vi
Kieran Kunhya (12021-02-07):
> It doesn't work in practice.
> It's why every Android phone captures video at 29.970fps ± jitter instead
> of the correct 3/1001
Good enough for most uses. Let the user decide.
Regards,
--
Nicolas George
signature.asc
Descrip
f seconds, if that.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpe
ent
if we realize in the middle of the project that it is actually not
wanted.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-dev
gle key-value.
> +av_log(avf, AV_LOG_ERROR,
> + "Line %d: failed to parse input options string\n",
> + line);
> +av_freep(&input_options);
> +FAIL(AVERROR_IN
talking about the precedence order in which you added it.
> Yes. This just matches the rest of the documentation strings etc for
> such things.
Again, the lack of care for anything that is not directly related to the
core functionality makes our work harder and less good
James Almer (12021-02-07):
> Signed-off-by: James Almer
> ---
> libavfilter/buffersrc.c | 38 --
> 1 file changed, 8 insertions(+), 30 deletions(-)
Sorry, forgot to look at it.
Looks ok, thanks.
Regards,
--
Nicolas George
signature.asc
t should not be
using a dictionary in the first place, even less a dictionary stored in
the context. Just iterate over the key=value pairs of the string without
allocating all of them longer than necessary.
Regards,
--
Nicolas George
signature.asc
Description
Nicolas George (12020-11-30):
> Good idea, thanks.
Pushed.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscr
Otherwise I shall start the code
proper.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or e
libuv would be a better
choice than libev?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or em
de will be similar, but instead
of av_dict_set(), you do the libvpx stuff.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To
l, just passing
the string and using the values immediately.
> }
>
> +av_dict_free(&vpx_ref_frame_config);
> codecctl_intp(avctx, VP9E_SET_SVC_REF_FRAME_CONFIG, (int
> *)&ctx->ref_frame_config);
>
ill do the same, and
be exactly as portable as things are now.
But it will be modular: if somebody later wants to write specific code
for Windows, it will be possible and I will make sure it is as easy as
possible.
Does that sound acceptable?
Regards,
--
Nicolas George
signature.asc
Descriptio
his project makes
it possible to have code that works on Windows, unlike now. It just will
not be me who write specific code.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
hat respect?
The fact that it is designed to run the interpreter of a language with a
garbage collector worries me.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https:/
t = vpx_parse_ref_frame_config(&ctx->ref_frame_config,
> +
> enccfg->ss_number_layers, en->value, "=", ":");
> +if (ret != 0) {
ret < 0 here too.
> +av_log(avc
hanks.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@
ted to the event library so that it can
> deal with asynchronous calls internally, especially send()/recv()
> calls.)
Using non-standard IO code and tying to the library is completely out of
the question.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
; I think this means that integration with most external libraries (and
> non-network things) will not be possible, then.
I am sure this is entirely the opposite.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-d
here is no problem.
If it comes from another thread, that means your application either
requires a libavutil with a thread-capable event loop backend or must
provide one.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmp
r frame timestamps too.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
onous single-threaded
> implementation seems like somewhat behind with the times.
Yes, that is a terrible trend. Throw memory and CPU at I/O performance
instead of writing optimized code. POSIX threads never were a solution
for parallel I/O.
Regards,
--
Nicolas George
signature.asc
Description
to escape
".
> Mild pereference for "attr" here
> Besides, doesn't everyone use auto-completion for identifiers?
Thanks you for your input. Typing the identifiers is not the only issue:
overly long lines are annoying to read the code too.
Regards,
--
Nicolas Ge
r solution: throw efficient programming at
the problem.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit l
code
is needlessly slow and not optimized, because they chose the easy
solution.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
big.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org
d it half a dozen times.
And that is the core of the problem. We may be able to use libuv if we
sacrifice devices, but we would be able to use ONLY libuv. Nor our own
lightweight implementation, nor a completely different event loop
provided by the application.
This is not what we want.
Regards,
more precise?
The portability arguments have been compelling for libuv over libev, so
if we find a way of getting libuv to work for our needs, it would be
best.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel
0, but NULL+x is a different kind of bug, more
serious, but the macro hides it. Maybe add an av_assert2()?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.or
e the branch away (GCC does
> it).
Oh, I had read the macro the wrong way. This version is cleverer.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mai
Guo, Yejun (12021-02-22):
> ---
> libavfilter/buffersink.c | 1 +
> 1 file changed, 1 insertion(+)
This does not seem correct: the ref count is not raised by buffersink,
it probably should not lower it.
What circumstances are you trying to fix exactly?
Regards,
--
Nicol
bal timestamp (gts) metatdata to AVPacket and AVFrame
> * Support gts for image2 filename
> * Support gts for segment filename
Please make one patch per functional change.
No field can be added to AVPacket, as applications are currently allowed
to allocate it themselves.
Regards,
--
Nicola
earer and removes any aggression that may
have seeped into the discussion.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
etween the various places that use it. Making it a proper API if
relevant.
Ideally, all the writers of ffprobe should be turned into a single
libavutil API for use in all components that need to output data.
Regards,
--
Nicolas George
signature.asc
Description: PGP sig
rds,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org w
.
Still duplicating code from ffprobe.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link abo
Parsing the standard output of any program is bad design and bound to
break at some point.
Also, I wonder why you chose CSV, which is one of the worse possible
formats.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmp
; There are at least two such functions already in the code base.
We should not have accepted the second one like that. It does not
constitute a precedent.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel maili
JSON) soon.
Please comment.
Regards,
--
Nicolas George
Nicolas George (12020-12-31):
> This mail is about a project I have to make FFmpeg's API and
> infrastructure more convenient. For a common introduction, see this thread:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2020-D
alstats.YLOW=16,…
I doubt ffprobe did output an ellipsis character on its own.
For simpler parsing, use a different writer than csv. I would recommend
flat.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel ma
fprobe.
This is why I re-started the following discussion:
https://ffmpeg.org/pipermail/ffmpeg-devel/2021-February/276855.html
You can weigh in.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
f common sense. This instance is not one, because even with
a billion webcams, /dev/video9 fits in 256 chars.
>
> if (!v4l2_is_v4l_dev(entry->d_name))
> continue;
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
__
rsion. Thank you very much.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-d
ee, and maybe we can just let this build warning there.
In the long run, better disable it. We have check_disable_warning in
configure, so it is probably a one line patch.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmp
Marton Balint (12021-02-21):
> Constant frame size is not guaranteed if the read call interrupted by a
> signal,
> or if non-blocking mode is used.
>
> Signed-off-by: Marton Balint
> ---
> libavdevice/alsa_dec.c | 1 -
> 1 file changed, 1 deletion(-)
Should be ok.
e changed, 18 insertions(+)
Looping snd_pcm_readi() seems like a more robust solution to this issue.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/l
ions like snd_pcm_avail() (I have observed bugs with this kind of
functions and some of the infrastructure plugins), and it does not
require starting the PCM manually at seemingly random places in the
code.
Regards,
--
Nicolas George
signature.asc
Description: PGP
Guo, Yejun (12021-03-01):
> thanks for the advice, we might don't disable it, because the disabling will
> no longer
> remind the developers of this issue existing, this is another comment. thanks.
What "issue"? The only issue here is a useless warning.
Regard
find who put it there, because they are
responsible for freeing it.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To uns
this is true, we can work around it with an extra
pointer or a cast, possibly wrapped in a macro. Saving a few dynamic
allocation is well worth the unusual code; we should shoo away the
people who oppose to go work on GStreamer or something.
Regards,
--
missed it.
What this is basically saying is that private_ref in libavfilter will be
appropriated for the only use of bounding boxes. I think it is a
significantly worse solution than using side data as you originally
considered.
Regards,
--
Nicolas George
signa
the code.
The third choice would be something like:
#define BOX(p, i) (((BoundingBox *)&(p)->boxes)[i])
or similar. But best try to make the best choice work.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-deve
, even though we do not have a better use in sight.
> As Paul mentioned, I think AVFrame.metadata is a better choice.
If you can express it as a string or set of strings with a clear syntax
that can easily be parsed, then possibly, yes.
Regards,
--
Nicolas George
signature.asc
Descrip
good long-term API where the
information is eventually available outside.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To
can define
things properly exactly like we need.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg
xtra parameter to the function.
> + *
> + * @param externalAlloc The function that will be called when a new buffer
> is required. This function can return
> + *NULL if it does not take care of allocating
> buffers of the provided size. In this case
501 - 600 of 4940 matches
Mail list logo
