Re: [FFmpeg-devel] Patch question

2015-12-15 Thread Moritz Barsnick
Hi Mats, On Tue, Dec 15, 2015 at 16:58:41 +0100, Mats Peterson wrote: > Sorry if this may sound idiotic, but if I provide a unified patch for a > file that is newer/different from the one I have here, it won't work, right? "It depends." ;-) By the way, git handles this kind of stuff nicely. It

Re: [FFmpeg-devel] [PATCH] ffmpeg: add progress speed to status line and report

2015-12-16 Thread Moritz Barsnick
On Fri, Dec 11, 2015 at 16:49:14 +0100, Moritz Barsnick wrote: > This adds a computation of the progress speed versus realtime ("Nx") > to the status line and to the report log. It uses the progress time > as already calculated for total output time as a base. >

Re: [FFmpeg-devel] [PATCH] ffmpeg: add progress speed to status line and report

2015-12-16 Thread Moritz Barsnick
On Wed, Dec 16, 2015 at 15:28:31 +0100, Nicolas George wrote: > > BTW, these two are used quite often in this function and sort of beg > > for macros, but I don't go around macro-ifying code just for the fun of > > it. ;-) > > No need for macros, there is the av_bprint() API for that. *shrug* OT

Re: [FFmpeg-devel] [PATCH] lavc: add text encoder

2015-12-17 Thread Moritz Barsnick
On Thu, Dec 17, 2015 at 12:30:27 +0100, Clément Bœsch wrote: > --- > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 2 +- > libavcodec/srtenc.c| 37 +++- > libavcodec/version.h | 2 +- > tests/fate/subtitles.mak | 3 + > tests/ref/fate/sub-textenc | 2

Re: [FFmpeg-devel] Add "xmv" extension to the xmv codec

2015-12-17 Thread Moritz Barsnick
On Thu, Dec 17, 2015 at 12:31:20 +, Carl Eugen Hoyos wrote: > > I just submitted a pull request, #166, to > This is not the preferred way of contributing, please > consider to send the patch here. Which shows that it's time to push this change of the docs: http://ffmpeg.org/pipermail/ffmpeg-

Re: [FFmpeg-devel] [PATCH] lavc: add text encoder

2015-12-17 Thread Moritz Barsnick
On Thu, Dec 17, 2015 at 13:56:57 +0100, Clément Bœsch wrote: > It's not actually "srt"/subrip at all since the packet payload will only > contain a text string with no markup, while subrip contains the text > string with the html tag markup. Ah, that's the part about SRT ("formally" vs. text vs. A

Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

2016-01-05 Thread Moritz Barsnick
On Tue, Jan 05, 2016 at 21:19:12 +0100, Paul B Mahol wrote: > +It accepts the following values: > +@table @samp > +@item replace > +logarithmic ^^^ This description is a copy/paste error. > +@item pheight > +Set histogram percentage of window height. [...] > +{ "pheight", "set histogram pe

Re: [FFmpeg-devel] [WIP] SDL2 in ffplay

2016-01-05 Thread Moritz Barsnick
On Tue, Jan 05, 2016 at 21:49:58 +0100, wm4 wrote: > AFAIK SDL 1 is unmaintained now. I'm not sure why anyone would > explicitly want SDL 1 over 2. And trying to support both would be an > unholy mess. For the output device, sdl2 could be created as a copy of sdl (so that git can follow), then mod

Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

2016-01-06 Thread Moritz Barsnick
On Tue, Jan 05, 2016 at 21:36:20 +0100, Moritz Barsnick wrote: > This is not the first of your filters where you describe a parameter as > a "percentage", but expect a float value [0, 1]. That is extremely > confusing, if not even wrong. To me, a percentage covers [0, 100]. Y

Re: [FFmpeg-devel] [PATCH 1/3] libavcodec/ccaption_dec: rename to screen_changed to screen_reaped

2016-01-06 Thread Moritz Barsnick
On Wed, Jan 06, 2016 at 11:35:10 -0800, Aman Gupta wrote: > Subject: [FFmpeg-devel] [PATCH 1/3] libavcodec/ccaption_dec: rename to > screen_changed to screen_reaped There's a "to" too many in the commit message (the first one). Moritz ___ ffmpe

Re: [FFmpeg-devel] [PATCH v6] lavf/matroskadec: A_QUICKTIME and fourcc 0x00000000

2016-01-08 Thread Moritz Barsnick
On Fri, Jan 08, 2016 at 14:51:53 +0100, Mats Peterson wrote: > I can't see the applied patches at GitHub yet. Is a delay normal? Sorry > for a stupid question. Yes, that is normal. videolan.org hosts the "original". There was an explanation in this thread: http://lists.ffmpeg.org/pipermail/ffmpe

Re: [FFmpeg-devel] [PATCH v4] lavf/matroskadec: Normalize noncompliant A_QUICKTIME/V_QUICKTIME private data

2016-01-10 Thread Moritz Barsnick
On Sun, Jan 10, 2016 at 03:05:49 +0100, Mats Peterson wrote: > OK, but I thought an AVERROR(ENOMEM) eventually causes FFmpeg to exit? Even if so, this code is in libavformat, and may be called by any other application than ffmpeg. Moritz ___ ffmpeg-deve

[FFmpeg-devel] [PATCH] lavf: add automatic bitstream filtering

2016-01-14 Thread Moritz Barsnick
libavformat/movenc.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) libavformat/flvenc.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) In the spirit of commits 1b5bd4051d1e394f0429cbf6cf6c137f55857478 and b287d7ea17f404a51eb

[FFmpeg-devel] [PATCH] lavf/flvenc: add automatic bitstream filtering

2016-01-14 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- libavformat/flvenc.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index 3925768..8d10ef8 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flvenc.c @@ -597,15 +597,6

[FFmpeg-devel] [PATCH] lavf/movenc: add automatic bitstream filtering

2016-01-14 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- libavformat/movenc.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 1aff5c5..608bf69 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -4426,16

Re: [FFmpeg-devel] [PATCH] avfilter/vf_crop: make it possible to use frame metadata when cropping

2016-01-17 Thread Moritz Barsnick
On Sun, Jan 17, 2016 at 20:15:45 +0100, Paul B Mahol wrote: Nice feature. > +@item metadata > +If set to 1 it will use frame metadata instead to obtain all parameters. > +To make use of this feature you need to start @ref{cropdetect} filter before > +this filter. I would probably put it in other

Re: [FFmpeg-devel] [PATCH] lavf: add automatic bitstream filtering

2016-01-18 Thread Moritz Barsnick
On Thu, Jan 14, 2016 at 18:29:42 -0600, Rodger Combs wrote: > > Rodger's commits also introduced *_init() functions for each format. > > I don't understand whether that is necessary. These patches work > > for me just as they are. > The init functions are required because avpriv_set_pts_info is cal

Re: [FFmpeg-devel] [PATCH] lavu: add ff_pthread_setname() and use it in various places

2016-01-21 Thread Moritz Barsnick
On Wed, Jan 20, 2016 at 23:46:02 +0100, Clément Bœsch wrote: > Subject: [PATCH] lavu: add ff_pthread_setname() and use it in various places [...] > +static inline void ff_thread_setname(const char *name) The commit message is out of line with the adapted function name. Shouldn't the introduction

Re: [FFmpeg-devel] [PATCH v2 16/16] avcodec/dca: add new decoder based on libdcadec

2016-01-21 Thread Moritz Barsnick
On Thu, Jan 21, 2016 at 21:50:13 +0300, foo86 wrote: > --- > configure | 1 + > libavcodec/Makefile| 3 + > libavcodec/allcodecs.c | 2 +- > libavcodec/dcadec.c| 417 > + > libavcodec/dcadec.h| 80 ++ > 5 file

Re: [FFmpeg-devel] [PATCH v2 01/16] avcodec/dca: remove old decoder

2016-01-21 Thread Moritz Barsnick
On Thu, Jan 21, 2016 at 21:44:33 +0300, foo86 wrote: > This temporary unregisters DCA decoder from allcodecs.c and removes old temporarily ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat: Document urls a bit

2016-01-24 Thread Moritz Barsnick
On Sat, Jan 23, 2016 at 00:36:51 +0100, Michael Niedermayer wrote: > libavformat/avformat.h |9 + > 1 file changed, 9 insertions(+) This will at least need some spelling fixes and commas. ;-) > + * @section urls > + * URLs in libavformat are made of a protocol a ':' and a protocol sp

Re: [FFmpeg-devel] [PATCH 2/4] mmaldec: print the MMAL format FourCC automatically

2016-01-27 Thread Moritz Barsnick
On Wed, Jan 27, 2016 at 17:17:54 +0100, wm4 wrote: > +av_log(avctx, AV_LOG_DEBUG, "Use MMAL %s encoding\n", tmp); That sounds like an imperative. I would print "Using ...". Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.o

Re: [FFmpeg-devel] [PATCH] msvc: Fix libx264 linking

2016-01-28 Thread Moritz Barsnick
On Thu, Jan 28, 2016 at 17:18:47 +0100, Henrik Gramner wrote: > +-lx264) echo libx264.lib ;; Is this related to this issue?: http://ffmpeg.org/pipermail/ffmpeg-user/2016-January/030408.html http://ffmpeg.org/pipermail/ffmpeg-user/2016-January/030422.html Moritz _

Re: [FFmpeg-devel] [PATCH v4] avcodec: Cineform HD Decoder

2016-01-28 Thread Moritz Barsnick
Cosmetic nerd nit: > +av_log(avctx, AV_LOG_DEBUG, "large len %x \n", ((tagu & 0xff) << > 16) | data); > +} else if (tag == 20) { > +av_log(avctx, AV_LOG_DEBUG, "Width %"PRIu16" \n", data); ^ You're logging

Re: [FFmpeg-devel] [PATCH v3] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video in AVI

2016-02-02 Thread Moritz Barsnick
On Mon, Feb 01, 2016 at 19:15:37 +0100, wm4 wrote: > Can you just try to wait with your reply 30-60mins, instead of > constantly spamming the mailing list with follow ups? I think people are starting/continuing to ignore him, due to the constant monologs. I look at my mailbox in threaded view in t

Re: [FFmpeg-devel] [PATCH] configure: remove the mixed declarations and code warning flag

2016-02-04 Thread Moritz Barsnick
On Thu, Feb 04, 2016 at 17:04:20 +0100, ffmpeg-...@c-14.de wrote: > Just being pedantic, but -Wdeclaration-after-statement does not warn on > any of those, see attached test file which compiles without errors with > -Wall -Wpedantic -Werror -Wdeclaration-after-statement (at least on > modern clang

Re: [FFmpeg-devel] [PATCH] avfilter: add metadata filters

2016-02-06 Thread Moritz Barsnick
On Sat, Feb 06, 2016 at 12:47:25 +0100, Paul B Mahol wrote: > patch attached. Nice. (Untested.) > +Manipulate frames metadata. Either: frame metadata [using this as a generic term] or: frames' metadata I prefer the former. > +If both @code{value} and @code{key} is set, select fram

[FFmpeg-devel] Sample (libavcodec/h264_sei.c): Subtitles with data type 0x06

2015-09-03 Thread Moritz Barsnick
Hi, I have uploaded ffmpeg.sample.subtitles_with_data_type_0x06.ts to ftp://upload.ffmpeg.org/incoming/. It exposes the request "[h264 @ 0xb25bb60] Subtitles with data type 0x06 is not implemented.", as issued in libavcodec/h264_sei.c: http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/h264_

Re: [FFmpeg-devel] [WIP][RFC][PATCH] avfilter: add zscale filter

2015-09-22 Thread Moritz Barsnick
On Mon, Sep 21, 2015 at 23:53:26 +0200, Paul B Mahol wrote: > On 9/21/15, Carl Eugen Hoyos wrote: > > Paul B Mahol gmail.com> writes: > >> www://github.com/sekrit-twc/zimg > > I fear that a working link is needed in the > > documentation of the filter. > This link works fine. My browsers are ext

Re: [FFmpeg-devel] [PATCH] avfilter: add zscale filter

2015-09-22 Thread Moritz Barsnick
"I'm only here for the nitpicking." I noticed quite a lot of errors in the various documentation recently, and joined the list to submit patches. Let me start though by noting my observations here: > + --enable-libzimg enable zimg, needed for zscale filter [no] So, is it "z.img" or "zimg

Re: [FFmpeg-devel] [PATCH] avfilter: add maskedmerge filter

2015-09-26 Thread Moritz Barsnick
On Sat, Sep 26, 2015 at 10:29:15 +0200, Paul B Mahol wrote: > +Merge first input stream with second input stream using per pixel weights in > +the third input stream. 0 means that pixel component from first stream is > +returned unchanged while 255 for 8-bit videos means that pixel component from

Re: [FFmpeg-devel] [PATCH] ffmpeg/web/index: add news describing GSoC 2015 program outcome

2015-09-27 Thread Moritz Barsnick
In addition to the others: > +effort. We're looking forward participating to the next GSoC looking forward to participating in the next > +At the end of the program, Mariusz provided a sketch of implementation of an implementation > +with overlapping formatting (which other formats

Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors

2015-09-29 Thread Moritz Barsnick
On Tue, Sep 29, 2015 at 20:34:09 +0200, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > doc/encoders.texi | 2 +- > doc/filters.texi | 14 +++--- > libavcodec/g726.c | 2 +- > libavcodec/vaapi_hevc.c| 2

Re: [FFmpeg-devel] [PATCH] avfilter/af_rubberband: add process_command()

2015-10-01 Thread Moritz Barsnick
On Thu, Oct 01, 2015 at 09:29:10 +0200, Paul B Mahol wrote: > On 10/1/15, Michael Niedermayer wrote: > > also af_rubberband seems to fail to build with 1.3-1.2 from ubuntu > You sure have latest version of rubberband? 1.3 is certainly not the latest version. If that's a dependency, you'll have

Re: [FFmpeg-devel] [PATCH]select attribute of tee pseudo demuxer may contain multiple stream specifiers

2015-10-01 Thread Moritz Barsnick
> -all the input streams. > +all the input streams. You may use multiple stream specifiers > +separated by commas (,) eg.: a:0,v eg. -> e.g. (and you have double spaces there, " "). And I prefer "(@code{,})" and "@code{a:0,v}", but perhaps that's a matter of preference, not sure about this yet

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-02 Thread Moritz Barsnick
On Tue, Sep 29, 2015 at 23:39:10 +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_setfps.c | 119 > +++ > 3 files changed, 121 insertions(+) > crea

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-02 Thread Moritz Barsnick
On Fri, Oct 02, 2015 at 19:47:12 +0200, Paul B Mahol wrote: > fps filter duplicated or removes frames to produce cfr output. > This filter changes fps and do not remove or duplicate single > frame so output becomes faster or slower when played when > fps increase or decrease. Ah! So, in other word

Re: [FFmpeg-devel] [PATCH v3] avdevice/xcbgrab: Add select_region option

2020-07-04 Thread Moritz Barsnick
On Wed, Jul 01, 2020 at 11:30:33 +0200, Omar Emara wrote: > { "region_border", "Set the region border thickness.", > OFFSET(region_border), AV_OPT_TYPE_INT, { .i64 = 3 }, 1, 128, D }, > +{ "select_region", "Select the grabbing region graphically using the > pointer.", OFFSET(select_regio

Re: [FFmpeg-devel] [PATCH] [GSoC 1/6] avformat/abr: Adaptive Bitrate support

2020-07-06 Thread Moritz Barsnick
On Sun, Jul 05, 2020 at 19:34:54 +0800, Hongcheng Zhong wrote: > +static int abr_rule(ABRContext *c, float bw_estimate) > +{ > +int ret = -1; > + > +if (c->n_throughputs > 6) { > +if (bw_estimate < c->variants_bitrate[c->cur_pls].value / 1000 * 1.2 > && > +bw_estimate >

Re: [FFmpeg-devel] Project orientation

2020-07-07 Thread Moritz Barsnick
On Tue, Jul 07, 2020 at 10:03:34 -0300, James Almer wrote: > On 7/7/2020 8:33 AM, Steinar H. Gunderson wrote: > > FWIW, the “less secure” part is about not supporting 2FA (POP/IMAP has no > > OAuth-like authentication methods). > > This is not true. Thunderbird and i assume any modern IMAP/SMTP cli

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix missing line break in messages

2020-07-10 Thread Moritz Barsnick
On Thu, Jun 25, 2020 at 18:59:58 +0800, myp...@gmail.com wrote: > On Thu, Jun 25, 2020 at 6:46 PM Moritz Barsnick wrote: > > > > One of them can be triggered by > > https://samples.ffmpeg.org/F4V/H263_NM_f.mp4. > > > > Signed-off-by: Moritz Barsnick &

[FFmpeg-devel] [PATCH v4] avdevice/xcbgrab: check return values of xcb query functions

2020-07-10 Thread Moritz Barsnick
while ffmpeg is running. Cheers, Moritz From 3bbf40dd08bb67e993cca97880aec032644fd02b Mon Sep 17 00:00:00 2001 From: Moritz Barsnick Date: Fri, 10 Jul 2020 13:26:55 +0200 Subject: [PATCH] avdevice/xcbgrab: check return values of xcb query functions Fixes #7312, segmentation fault on close of X11

Re: [FFmpeg-devel] [PATCH] lavf/srt: fix build fail when used the libsrt 1.4.1

2020-07-12 Thread Moritz Barsnick
On Sun, Jul 12, 2020 at 14:03:03 +0800, Jun Zhao wrote: > From: Jun Zhao (Which thread are you replying to?) > libsrt 1.4.1 changed the: > SRTO_SMOOTHER -> SRTO_CONGESTION AFAICT, this was changed in 1.3.3 (even though the commit doesn't change the doc/API.md where it states 1.3.0): https://g

Re: [FFmpeg-devel] [PATCH v08 2/3] fbtile tile/detile, hwcontext_drm detile NonLinear

2020-07-12 Thread Moritz Barsnick
On Sat, Jul 11, 2020 at 20:31:40 +0530, C Hanish Menon wrote: > > Also fix the changelog. > > Sorry I didn't understand this fully. Can I assume that you don't want to > mention about the fbtile helpers as an entry in the changelog, because its > not a public api? I believe what Lynne meant is: C

[FFmpeg-devel] [PATCH v5] avdevice/xcbgrab: check return values of xcb query functions

2020-07-14 Thread Moritz Barsnick
On Sun, Jul 12, 2020 at 10:54:45 -0400, Andriy Gelman wrote: > On Fri, 10. Jul 21:13, Moritz Barsnick wrote: > > Since xcbgrab is getting some attention recently... > > > > Fixes a segfault, as reported in #7312. > > > > To reproduce: > > Terminal 1

Re: [FFmpeg-devel] [PATCH 1/2] mpeg2: Renaming functions around init_uni_ac_vlc

2020-07-14 Thread Moritz Barsnick
On Mon, Jul 13, 2020 at 13:16:18 +0200, Jean-Baptiste Kempf wrote: > We need to export init_uni_ac_vlc to init_uni_ac_vlc and therefore need "to ff_init_uni_ac_vlc"? Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH] lavf/srt: fix build fail when used the libsrt 1.4.1

2020-07-14 Thread Moritz Barsnick
On Sun, Jul 12, 2020 at 22:44:46 +0800, myp...@gmail.com wrote: > Maybe I give an inaccurate description in the commit message, in fact, > libsrt 1.4.1 remove the SRTO_STRICTENC/SRTO_SMOOTHER option, it's will > lead to FFmpeg build fail when using libsrt version >= 1.4.1 I don't mind you descrip

Re: [FFmpeg-devel] Ticket 5012

2020-07-16 Thread Moritz Barsnick
On Thu, Jul 16, 2020 at 17:10:06 +0530, Gautam Ramakrishnan wrote: > I was going through the bug tracker for a list of bugs associated with > jpeg2000. Looking at issue 5012, is there a good utility for solving > this issue? What do you mean with utility? I suppose you just need to implement JPEG2

[FFmpeg-devel] [PATCH v6] avdevice/xcbgrab: check return values of xcb query functions

2020-08-05 Thread Moritz Barsnick
in this patch. Okay, so I "fixed" dead code. You guys can remove the dead code yourselves then, if you like. ;-) New patch for the original issue attached, not touching the dead code. Thanks, Moritz From e44b7f03354add2272a2739e04aafb38b7ce027f Mon Sep 17 00:00:00 2001 From: Moritz Bars

Re: [FFmpeg-devel] [PATCH v2 3/5] avformat/dump: dump AV_PKT_DATA_MPEGTS_6A_DESC side data

2020-08-06 Thread Moritz Barsnick
On Thu, Jul 30, 2020 at 22:58:56 +0800, lance.lmw...@gmail.com wrote: > #include "libavutil/dovi_meta.h" > +#include "libavutil//mpegts_audio_desc_metadata.h" ^^ A duplicate slash slipped in there. > +av_log(ctx, AV_LOG_INFO, "component_type_flag: %u, bsid_flag: %u, " >

Re: [FFmpeg-devel] [PATCH v2 5/5] avformat/mpegtsenc: support 0x6a descriptor for AC-3 by side data if have

2020-08-06 Thread Moritz Barsnick
On Thu, Jul 30, 2020 at 22:58:58 +0800, lance.lmw...@gmail.com wrote: > if (codec_id == AV_CODEC_ID_AC3) { > +int len = 1; > + > +if (ts_st->desc6a.component_type_flag) len++; > +if (ts_st->desc6a.bsid_flag) len+

Re: [FFmpeg-devel] how to use http proxy in ffmpeg-devel

2020-08-07 Thread Moritz Barsnick
On Wed, Aug 05, 2020 at 20:48:20 +0800, 486179 wrote: > for example > avformat_alloc_output_context2(&putFmtCtx, NULL, "rtmp", > "rtmp://1.1.1.1/live"); > or  > avformat_open_input(&InputFmtCtx, "rtmp://1.1.1.1/live", 0, 0) Wrong mailing list. For questions regarding the development with the ffmp

Re: [FFmpeg-devel] [PATCH] avcodec: deprecate thread_safe_callbacks

2020-08-10 Thread Moritz Barsnick
On Tue, Aug 04, 2020 at 13:59:42 +0200, Anton Khirnov wrote: > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -2883,7 +2883,9 @@ static int init_input_stream(int ist_index, char > *error, int error_len) > ist->dec_ctx->opaque= ist; > ist->dec_ctx->get_format

Re: [FFmpeg-devel] [PATCH v5 3/5] lavc/avs3_parser: add avs3 parser

2020-08-19 Thread Moritz Barsnick
On Wed, Aug 19, 2020 at 14:25:54 +0800, hwr...@126.com wrote: > +for (; cur < buf_size; ++cur) { > +state = (state << 8) | buf[cur]; > +if (ISPIC(buf[cur])){ > +++cur; ffmpeg prefers the "cur++" style (twice in this block, and elsewhere). > +

Re: [FFmpeg-devel] [PATCH v5 2/5] lavc/avs3: add AVS3 related definitions

2020-08-19 Thread Moritz Barsnick
On Wed, Aug 19, 2020 at 14:25:53 +0800, hwr...@126.com wrote: > + * AVS3 related definition definitions? > +}; > \ No newline at end of file Please amend a carriage return to the last line. > + * AVS3 related definition definitions? Moritz ___ ffmpe

Re: [FFmpeg-devel] [PATCH v5 5/5] lavc, doc: add libuavs3d video decoder wrapper

2020-08-19 Thread Moritz Barsnick
On Wed, Aug 19, 2020 at 14:25:56 +0800, hwr...@126.com wrote: > - AV1 Low overhead bitstream format demuxer > +- AVS3 video decoder via libuavs3d I wonder whether the raw demuxer should have been mentioned in its respective patch. Moritz ___ ffmpeg-dev

Re: [FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

2020-08-20 Thread Moritz Barsnick
On Wed, Aug 19, 2020 at 17:51:01 +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch makes the ff_jpeg2000_cleanup > function take in an extra parameter which > indicates whether it is called from the > encoder or decoder. I fail to see an explanation why, ... > -void f

Re: [FFmpeg-devel] [RFC PATCH 4/4] libavcodec/j2kenc: Support for multiple layers

2020-08-20 Thread Moritz Barsnick
On Wed, Aug 19, 2020 at 17:51:02 +0530, gautamr...@gmail.com wrote: Minor nits: > +static void compute_rates(Jpeg2000EncoderContext* s) > +{ > +int i, j; > +int layno, compno; > +for (i = 0; i < s->numYtiles; i++) { > +for (j = 0; j < s->numXtiles; j++) { > +Jpeg20

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-20 Thread Moritz Barsnick
On Sun, Aug 16, 2020 at 18:25:12 +0200, Paul B Mahol wrote: > On 8/16/20, Paul B Mahol wrote: > > Please help porting this to linux and 64bit calling convention. > > New patch attached. > > This one does not allocate stack on x32. I wanted to benchmark on several machines (newest I have is a Hasw

Re: [FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

2020-08-20 Thread Moritz Barsnick
On Thu, Aug 20, 2020 at 20:02:32 +0530, Gautam Ramakrishnan wrote: > On Thu, Aug 20, 2020 at 3:02 PM Moritz Barsnick wrote: > > ... and what it does with this change. Looks like an NOP from the patch > > file alone. > It was done to provide functionality for the next patch in t

[FFmpeg-devel] [PATCH] libavformat/http, tls: honor http_proxy command line variable for HTTPS

2020-08-20 Thread Moritz Barsnick
ocal installation of tinyproxy. Please review. Thanks, Moritz From 095bb727b2400a75d6bf8c74ab90831aaefbc5aa Mon Sep 17 00:00:00 2001 From: Moritz Barsnick Date: Thu, 20 Aug 2020 17:49:14 +0200 Subject: [PATCH] libavformat/http,tls: honor http_proxy command line variable for HTTPS Add the "htt

Re: [FFmpeg-devel] [PATCH] libavformat/http, tls: honor http_proxy command line variable for HTTPS

2020-08-20 Thread Moritz Barsnick
Hej Martin, On Thu, Aug 20, 2020 at 22:05:39 +0300, Martin Storsjö wrote: > Even if you do e.g. a plain tls socket (or rtmps, or whatever), you may > want to do the tls connection through a proxy server (be that a socks > proxy or http proxy). Actually, I forget that an HTTP proxy with CONNECT s

Re: [FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

2020-08-20 Thread Moritz Barsnick
On Thu, Aug 20, 2020 at 22:49:16 +0100, Mark Thompson wrote: > With this patch, -disable_auto_conversion_filters does what you want. [...] > +if (!po->name) { > +/* Try to match a boolean option with a negative prefix. */ > +for (int i = 0; i < FF_ARRAY_ELEMS(negative_prefixes)

[FFmpeg-devel] [PATCH v2] avformat/http, tls: honor http_proxy command line variable for HTTPS

2020-08-21 Thread Moritz Barsnick
Patch version 2 attached, with added documentation. Moritz From 2f2a43e4c684cd4bfda420bbedf5125dd78b3b34 Mon Sep 17 00:00:00 2001 From: Moritz Barsnick Date: Thu, 20 Aug 2020 17:49:14 +0200 Subject: [PATCH] avformat/http,tls: honor http_proxy command line variable for HTTPS Add the "http_

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-21 Thread Moritz Barsnick
On Thu, Aug 20, 2020 at 12:53:05 +0200, Moritz Barsnick wrote: > Alas, with the patchset, the following command quickly terminates with > Illegal instruction in ff_cfhd_horiz_filter_clip10_sse2 (): The same on this CPU, obviously, because it also doesn't support SSE4.1: [barsni

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-21 Thread Moritz Barsnick
On Fri, Aug 21, 2020 at 13:13:29 +0200, Paul B Mahol wrote: > Overall speed changes for 1920x1080, yuv422p10le, 60fps from: 0.19x to 0.343x Let me add my promised benchmarks. I have nothing modern here (these CPUs are 10, 18 and 6 years old), but I can confirm the impressive improvements:

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-21 Thread Moritz Barsnick
On Fri, Aug 21, 2020 at 15:10:09 +0200, Moritz Barsnick wrote: > Let me add my promised benchmarks. I have nothing modern here (these > CPUs are 10, 18 and 6 years old), but I can confirm the impressive > improvements: > > Intel Atom D525 Intel Pentium 4

[FFmpeg-devel] [PATCH v3] avformat/http, tls: honor http_proxy command line variable for HTTPS

2020-08-23 Thread Moritz Barsnick
, as "verifyhost" is related to the certificate options (and should thus perhaps even be above "listen"). I have come to realize that the httpproxy protocol could apply to any protocol with underlying tcp, but that's a different story. Thanks, Moritz From e2d93c4f5ad186a5277c8ae3

Re: [FFmpeg-devel] [PATCH] configure: Add additional glslang libraries to make linking work

2020-08-23 Thread Moritz Barsnick
On Mon, Aug 17, 2020 at 16:21:23 -0700, Philip Langdale wrote: > The latest builds of glslang introduce new libraries that need to be > linked for all symbols to be fully resolved. > > Presumably, requiring these new libraries breaks building against > older glslang releases? What range are we comm

Re: [FFmpeg-devel] [PATCH v5 2/5] lavc/avs3: add AVS3 related definitions

2020-08-26 Thread Moritz Barsnick
On Thu, Aug 20, 2020 at 13:24:44 +0800, hwren wrote: > At 2020-08-19 22:18:52, "Moritz Barsnick" wrote: > >On Wed, Aug 19, 2020 at 14:25:53 +0800, hwr...@126.com wrote: > >> + * AVS3 related definition > > > >definitions? > >> +}; > >>

Re: [FFmpeg-devel] [PATCH v5 3/5] lavc/avs3_parser: add avs3 parser

2020-08-26 Thread Moritz Barsnick
On Thu, Aug 20, 2020 at 13:31:12 +0800, hwren wrote: > At 2020-08-19 22:14:04, "Moritz Barsnick" wrote: > >ffmpeg prefers the "cur++" style (twice in this block, and elsewhere). > > Will be corrected. Thanks. > >Is "low_delay" part of the skip

Re: [FFmpeg-devel] [PATCH v6 2/4] lavfmt: add FLIF demuxing support

2020-08-26 Thread Moritz Barsnick
On Sun, Aug 23, 2020 at 00:09:33 +0530, Anamitra Ghorui wrote: > Subject: Re: [FFmpeg-devel] [PATCH v6 2/4] lavfmt: add FLIF demuxing support ffmpeg usually uses "lavf" (or "avformat"). Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH v6 3/4] configure: add FLIF dependencies

2020-08-26 Thread Moritz Barsnick
On Sun, Aug 23, 2020 at 00:09:34 +0530, Anamitra Ghorui wrote: > --- a/configure > +++ b/configure > @@ -3307,6 +3307,7 @@ fifo_muxer_deps="threads" > flac_demuxer_select="flac_parser" > flv_muxer_select="aac_adtstoasc_bsf" > gxf_muxer_select="pcm_rechunk_bsf" > +flif_demuxer_select="zlib exif"

Re: [FFmpeg-devel] [PATCH v6 4/4] doc: add documentation entries for FLIF

2020-08-26 Thread Moritz Barsnick
On Sun, Aug 23, 2020 at 00:09:35 +0530, Anamitra Ghorui wrote: > - RPZA video encoder > - > +- FLIF16 decoder > +- FLIF16 demuxer This should be part of the corresponding commits. And don't drop the empty line. > @tab Sorenson H.263 used in Flash > +@item FLIF (Free Lossless Image Format @t

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

2020-08-26 Thread Moritz Barsnick
On Sun, Aug 23, 2020 at 00:09:32 +0530, Anamitra Ghorui wrote: > v2: Fix faulty patch > v3: Fix addressed errors, Add interlaced decoding support > v4: Fix Further cosmetics, C.Bucket Transform reading errors, Atomise patch > v5: Fix faulty patch > v6: Address pointed out errors, use av_freep every

Re: [FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

2020-08-26 Thread Moritz Barsnick
On Sat, Aug 22, 2020 at 21:55:21 +0100, Mark Thompson wrote: > > Without checking in more detail: Wouldn't this break the > > "-noise_reduction", "-non_deterministic" and "-non_linear_quant" > > options? > > The intent is to extend what already happens - given an argument like > "-nougat", it first

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

2020-08-27 Thread Moritz Barsnick
On Wed, Aug 26, 2020 at 16:31:46 +, Anamitra Ghorui wrote: > >> +uint8_t ff_flif16_rac_read_bit(FLIF16RangeCoder *rc, > >> + uint8_t *target) > >> +{ > >> +return ff_flif16_rac_get(rc, rc->range >> 1, target); > >> +} > > > > If this is called often, you may wa

Re: [FFmpeg-devel] [RFC PATCH v6 3/4] libavcodec/j2kenc: Support for multiple layers

2020-08-27 Thread Moritz Barsnick
On Wed, Aug 26, 2020 at 21:28:17 +0530, gautamr...@gmail.com wrote: > +@item layer_rates @var{string} > +By default, compression is done using the quality metric. This option allows > for > +compression using compression ratio. The compression ratio for each level > could > +be specified. The co

Re: [FFmpeg-devel] Forward frame wall clock time from avdevice to HLS muxer

2020-08-28 Thread Moritz Barsnick
On Wed, Aug 26, 2020 at 23:52:58 -0700, Jim DeLaHunt wrote: > Earlier this year, there were patches[3] which aimed to put linear > timecodes in a format related to SMPTE 12M into a structure marked by a > `AV_FRAME_DATA_S12M_TIMECODE` value. Maybe that refers to a location > where you could store t

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/allfilters: Don't cast const away

2020-08-28 Thread Moritz Barsnick
On Sun, Aug 23, 2020 at 23:31:45 +0800, Zhao Zhili wrote: > >> I have a same patch long time ago. > >> > >> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-October/252193.html > >> > >>

Re: [FFmpeg-devel] [PATCH v3 3/4] lavfi: check the validity of formats lists.

2020-08-28 Thread Moritz Barsnick
On Mon, Aug 24, 2020 at 13:36:50 +0200, Nicolas George wrote: > +switch (link->type) { > + > +case AVMEDIA_TYPE_VIDEO: > +if ((ret = ff_formats_check_pixel_formats(log, cfg->formats)) < > 0) > +return ret; > +break; > + > +case AVMEDIA_TY

Re: [FFmpeg-devel] [FFmpeg-devel, RFC] lavfi: add opencl tonemap filter.

2018-05-11 Thread Moritz Barsnick
On Fri, May 11, 2018 at 10:10:42 +0200, Niklas Haas wrote: > Thinking about this logic again, I came to realize that a different > strategy might be to check instead for a minimum threshold brightness > difference in a critical number of different areas of the screen. This > way, a very bright ligh

Re: [FFmpeg-devel] [PATCH 3/5] ffserver: Implement http interface and implementation

2018-05-11 Thread Moritz Barsnick
On Thu, May 10, 2018 at 17:41:24 +0200, Stephan Holljes wrote: > +while ((handshake = avio_handshake(client_ctx)) > 0) { > +av_opt_get(client_ctx, "method", AV_OPT_SEARCH_CHILDREN, &method); > +av_opt_get(client_ctx, "resource", AV_OPT_SEARCH_CHILDREN, > &resource); Cast the l

Re: [FFmpeg-devel] [PATCH 4/5] ffserver: Implement ffserver and add Makefile

2018-05-11 Thread Moritz Barsnick
On Thu, May 10, 2018 at 17:41:25 +0200, Stephan Holljes wrote: > +ffserver: segment.o publisher.o lavfhttpd.o ffserver.c > + cc -g -Wall $(LAV_FLAGS) -lpthread -o ffserver segment.o publisher.o > lavfhttpd.o ffserver.c ^ $(CC) $(CFLAGS) to be more generic and allow overriding. The LDF

Re: [FFmpeg-devel] [PATCH 5/5] ffserver: Add basic documentation of the architecture

2018-05-11 Thread Moritz Barsnick
On Thu, May 10, 2018 at 17:41:26 +0200, Stephan Holljes wrote: > +In its current for this is a HTTP live-streaming server. A media file can be ^ form^ an > +streamed to a number of clients with the correct media file being muxed on- > +the-fly for each client starting at th

Re: [FFmpeg-devel] [PATCH 4/5] ffserver: Implement ffserver and add Makefile

2018-05-11 Thread Moritz Barsnick
On Fri, May 11, 2018 at 14:49:53 +0200, Moritz Barsnick wrote: > [matroska,webm @ 0xa166580] Finding video stream. > [AVIOContext @ 0xb441e5c0] Shutting down http server. > > "Shutting down"??? And I can't connect and play. Forget this part, my static video was too sho

Re: [FFmpeg-devel] [PATCH] avfilter: add declick and declip audio filters

2018-05-17 Thread Moritz Barsnick
On Thu, May 17, 2018 at 19:19:06 +0200, Paul B Mahol wrote: Valuable filters. I had compiled your previous separate patches, but didn't have any samples for testing. > +Setting this to very high value increases impulsive noise removal but makes > whole ^ a very high ...

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-05-19 Thread Moritz Barsnick
On Fri, May 18, 2018 at 16:54:25 -0700, Wang Cao wrote: Apart from the functional changes: > data_size += ost->data_size; > -if ( (ost->enc_ctx->flags & (AV_CODEC_FLAG_PASS1 | > AV_CODEC_FLAG_PASS2)) > + > +if ((ost->enc_ctx->flags & (AV_CODEC_FLAG_PASS1 | > AV_CODEC

Re: [FFmpeg-devel] [PATCH] lavc,lavf: add libxavs2 encoder

2018-05-26 Thread Moritz Barsnick
On Sat, May 26, 2018 at 14:08:56 +0800, hwren wrote: > Add Chinese AVS2 video encoder, FFmpeg can make use of the libxavs2 library > for AVS2 encoding. [...] > +.long_name = NULL_IF_CONFIG_SMALL("raw Chinese AVS2 (2nd Audio > Video Standard)"), Is that really the name of the codec? O

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg - rewrite Stream Selection chapter

2018-05-27 Thread Moritz Barsnick
On Sun, May 27, 2018 at 09:46:46 +0530, Gyan Doshi wrote: > +The @code{-vn}, @code{-an}, @code{-sn} options can be used to skip automatic > stream selection > +for video, audio, and subtitle streams respectively. This is incorrect, as it already was before. It doesn't disable *automatic* stream

Re: [FFmpeg-devel] [PATCH] lavc,lavf: add libxavs2 encoder

2018-05-28 Thread Moritz Barsnick
On Mon, May 28, 2018 at 19:16:49 +0800, hwren wrote: > >Is that really the name of the codec? Otherwise, "Chinese" seems > >awkward to me. (Same for the decoder.) > > Changed. I still see it in your newly pushlished patches. > >Proper documentation of the encoder's options would be appreciated!

Re: [FFmpeg-devel] [PATCH 1/3] doc,lavc,lavf: add avs2 codec

2018-05-28 Thread Moritz Barsnick
On Mon, May 28, 2018 at 18:14:55 +0800, hwren wrote: > --- a/libavcodec/allcodecs.c > +++ b/libavcodec/allcodecs.c > @@ -705,6 +705,7 @@ extern AVCodec ff_libx264_encoder; > extern AVCodec ff_libx264rgb_encoder; > extern AVCodec ff_libx265_encoder; > extern AVCodec ff_libxavs_encoder; > +extern

Re: [FFmpeg-devel] [PATCH 2/3] lavc, configure: add avs2 video decoder via libdavs2

2018-05-28 Thread Moritz Barsnick
On Mon, May 28, 2018 at 18:14:56 +0800, hwren wrote: > +.name = "avs2", > +.long_name = NULL_IF_CONFIG_SMALL("Chinese AVS2 (Audio Video > Standar) (AVS2-P2, JiZhun profile)"), > +.props = AV_CODEC_PROP_LOSSY, So, does "Chinese" belong to the name or description of

Re: [FFmpeg-devel] [PATCH 3/3] Changelog, doc/general: add libdavs2 entry

2018-05-28 Thread Moritz Barsnick
On Mon, May 28, 2018 at 18:14:57 +0800, hwren wrote: > Signed-off-by: hwren > --- > Changelog| 1 + > doc/general.texi | 8 > 2 files changed, 9 insertions(+) This should be in the same commit as patch 2, separation is not desired. And, as previously mentioned, listing and even

Re: [FFmpeg-devel] [PATCH 3/3] Changelog, doc/general: add libdavs2 entry

2018-05-28 Thread Moritz Barsnick
On Mon, May 28, 2018 at 15:00:18 +0200, Moritz Barsnick wrote: > And, as previously mentioned, listing and even describing the encoder's > options is desired. This is the decoder, and it has no options. Sorry for this remark of mine, it does not fit at all he

Re: [FFmpeg-devel] Convert Raw RTP dump to H.264

2018-06-04 Thread Moritz Barsnick
[Fixed the reply order for you, please try to avoid top-posting.] On Mon, Jun 04, 2018 at 15:26:11 +0530, Robert Clove wrote: > On Mon, Jun 4, 2018 at 2:22 PM, Steinar H. Gunderson < > steinar+ffm...@gunderson.no> wrote: > > Maybe you can replay the raw packets with tcpreplay? > Thats what i cant

Re: [FFmpeg-devel] [PATCH v4 1/4] lavu/hwcontext_opecl: fix the build warning

2018-06-07 Thread Moritz Barsnick
On Tue, Jun 05, 2018 at 22:21:23 +0800, Jun Zhao wrote: > Subject: [FFmpeg-devel] [PATCH v4 1/4] lavu/hwcontext_opecl: fix the build > warning >

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: raise max tempo limit

2018-06-07 Thread Moritz Barsnick
On Tue, Jun 05, 2018 at 20:59:16 -0600, Pavel Koshevoy wrote: > --- > libavfilter/af_atempo.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) Please have a look at doc/filters.texi and adapt the atempo section in the same commit. Moritz ___

Re: [FFmpeg-devel] [RFC] libfdk_aac license

2018-06-09 Thread Moritz Barsnick
On Sat, Jun 09, 2018 at 22:00:40 +0200, Carl Eugen Hoyos wrote: > > To the best of our knowledge, it is compatible with the LGPL" ? > > I am curious because of your follow-up in another thread: > Why do you think it is compatible? That's a bit of a mis-quote. That sentence is part of what is curr

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-06-15 Thread Moritz Barsnick
On Fri, Jun 15, 2018 at 13:37:31 +0800, Wang Cao wrote: > Make ffmpeg to output stats for each video/audio streams and each > ouptut file ffmpeg output log in print_report. The report of > video/audio sizes is clear now as previously all output video/audio > sizes were combined to report and it is

<    5   6   7   8   9   10   11   >