Re: [FFmpeg-devel] [PATCH] os_support, network: Fix build failure on Windows with BZIP2

Aug 2023, Martin Storsjö wrote: > >> On Thu, 27 Jul 2023, L. E. Segovia wrote: >> >>> Including winsock2.h without WIN32_LEAN_AND_MEAN causes bzlib.h to parse >>> as nonsense, due to an instance of #define char small in rpcndr.h >>> (include

[FFmpeg-devel] [PATCH v3 0/1] configure: Set WIN32_LEAN_AND_MEAN at configure time

Thanks Martin for the suggestion, I've implemented it in this version. As for the changes to os_support.c, the removal was intended to avoid duplicating the logic that already exists in os_support.h. I've kept it in this version for consistency. L. E. Segovia (1): conf

[FFmpeg-devel] [PATCH v3 1/1] configure: Set WIN32_LEAN_AND_MEAN at configure time

Including winsock2.h or windows.h without WIN32_LEAN_AND_MEAN cause bzlib.h to parse as nonsense, due to an instance of #define char small in rpcndr.h. See: https://stackoverflow.com/a/27794577 Signed-off-by: L. E. Segovia --- compat/atomics/win32/stdatomic.h | 1 - compat/w32pthreads.h

Re: [FFmpeg-devel] [PATCH v2] avdevice: Fix disabling audiotoolbox_outdev build on iOS

Ping for review. amyspark On 29/07/2023 16:00, L. E. Segovia wrote: > audiotoolbox.m uses CoreAudio APIs that are only available in macOS. > The existing CoreAudio framework check is already enough for this case > (as CoreAudio.h does not exist for the iDevices), however, it was never

[FFmpeg-devel] [PATCH v4 0/1] configure: Set WIN32_LEAN_AND_MEAN at configure time

Now adapted to insert WIN32_LEAN_AND_MEAN for MinGW and Cygwin too. L. E. Segovia (1): configure: Set WIN32_LEAN_AND_MEAN at configure time compat/atomics/win32/stdatomic.h | 1 - compat/w32pthreads.h | 1 - configure| 3 +++ libavdevice/dshow_capture.h

[FFmpeg-devel] [PATCH v4 1/1] configure: Set WIN32_LEAN_AND_MEAN at configure time

Including winsock2.h or windows.h without WIN32_LEAN_AND_MEAN cause bzlib.h to parse as nonsense, due to an instance of #define char small in rpcndr.h. See: https://stackoverflow.com/a/27794577 Reviewed-by: Martin Storsjö Signed-off-by: L. E. Segovia --- compat/atomics/win32/stdatomic.h | 1

[FFmpeg-devel] [PATCH 0/4] Fix FFmpeg compilation without DCE

unresolved externals make: *** [/c/Users/Amalia/Desktop/ffmpeg/ffbuild/library.mak:119: libavformat/avformat-59.dll] Error 96 The proposed patchset comprehensively converts all instances of ARCH_FOO, CONFIG_FOO, INLINE_FOO and EXTERNAL_FOO to the equivalent preprocessor guards. L. E. Segovia (4

[FFmpeg-devel] [PATCH 2/4] all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO

Continuation of e42aaaf92a4b0c88d60acc12df64c81d0887c26f Signed-off-by: L. E. Segovia --- fftools/ffprobe.c | 22 ++ fftools/opt_common.c| 18 +- libavformat/rtmpproto.c | 24 ++-- 3 files changed, 53 insertions(+), 11 deletions

[FFmpeg-devel] [PATCH 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Co-authored-by: Nirbheek Chauhan Signed-off-by: L. E. Segovia --- libavcodec/x86/dcadsp_init.c | 2 + libavcodec/x86/fdctdsp_init.c| 2 + libavcodec/x86/flacdsp_init.c| 8 +- libavcodec/x86/hevcdsp_init.c

[FFmpeg-devel] [PATCH 3/4] all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Signed-off-by: L. E. Segovia --- libavcodec/x86/vc1dsp_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/vc1dsp_init.c b/libavcodec/x86/vc1dsp_init.c index bc63933e83..65fc28ea35 100644 --- a

[FFmpeg-devel] [PATCH 4/4] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Signed-off-by: L. E. Segovia --- libavcodec/x86/aacencdsp_init.c| 2 ++ libavcodec/x86/aacpsdsp_init.c | 2 ++ libavcodec/x86/ac3dsp_init.c | 4 libavcodec/x86/audiodsp_init.c | 2

Re: [FFmpeg-devel] [PATCH 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2

c/x86/dcadsp_init.c#L40-L41 [2]: https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/x86/flacdsp.asm#L315-L318 [3]: https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/x86/flacdsp.asm#L323-L326 On 01/11/2022 19:28, andreas.rheinhardt at outlook.com (Andreas Rheinhardt) wrote: > L. E.

[FFmpeg-devel] [PATCH v2 0/5] Fix FFmpeg compilation without DCE

mlpdsp_init and vf_convolution_init L. E. Segovia (5): all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2 avcodec/x86/hevcdsp_init: Fix indentation after the ARCH_FOO changes all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM

[FFmpeg-devel] [PATCH v2 1/5] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Co-authored-by: Nirbheek Chauhan Signed-off-by: L. E. Segovia --- libavcodec/x86/fdctdsp_init.c| 2 ++ libavcodec/x86/flacdsp_init.c| 8 +++-- libavcodec/x86/hevcdsp_init.c| 53

[FFmpeg-devel] [PATCH v2 2/5] avcodec/x86/hevcdsp_init: Fix indentation after the ARCH_FOO changes

--- libavcodec/x86/hevcdsp_init.c | 454 +- 1 file changed, 227 insertions(+), 227 deletions(-) diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c index 40a295430d..c7060085a2 100644 --- a/libavcodec/x86/hevcdsp_init.c +++ b/libavcodec/x86/h

[FFmpeg-devel] [PATCH v2 3/5] all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO

Continuation of e42aaaf92a4b0c88d60acc12df64c81d0887c26f Signed-off-by: L. E. Segovia --- fftools/ffprobe.c | 16 +++- fftools/opt_common.c| 12 ++-- libavformat/rtmpproto.c | 24 ++-- 3 files changed, 39 insertions(+), 13 deletions(-) diff

[FFmpeg-devel] [PATCH v2 4/5] all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Signed-off-by: L. E. Segovia --- libavcodec/x86/hpeldsp_init.c | 2 ++ libavcodec/x86/vc1dsp_init.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/hpeldsp_init.c b/libavcodec/x86/hpeldsp_init.c index

[FFmpeg-devel] [PATCH v2 5/5] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Signed-off-by: L. E. Segovia --- libavcodec/x86/aacencdsp_init.c| 2 ++ libavcodec/x86/aacpsdsp_init.c | 2 ++ libavcodec/x86/ac3dsp_init.c | 4 libavcodec/x86/audiodsp_init.c | 2

[FFmpeg-devel] [PATCH v3 0/5] Fix FFmpeg compilation without DCE

d the duplicate HAVE_X86ASM check in me_cmp_init - Inlined the HAVE_X86ASM and ARCH_X86_64 checks in mlpdsp_init and vf_convolution_init L. E. Segovia (5): all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2 avcodec/x86/hevcdsp_init: Fix indentation after the ARCH_FOO changes all: Repla

[FFmpeg-devel] [PATCH v3 1/5] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Co-authored-by: Nirbheek Chauhan Signed-off-by: L. E. Segovia --- libavcodec/x86/fdctdsp_init.c| 2 ++ libavcodec/x86/flacdsp_init.c| 8 +++-- libavcodec/x86/hevcdsp_init.c| 53

[FFmpeg-devel] [PATCH v3 2/5] avcodec/x86/hevcdsp_init: Fix indentation after the ARCH_FOO changes

--- libavcodec/x86/hevcdsp_init.c | 454 +- 1 file changed, 227 insertions(+), 227 deletions(-) diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c index 40a295430d..c7060085a2 100644 --- a/libavcodec/x86/hevcdsp_init.c +++ b/libavcodec/x86/h

[FFmpeg-devel] [PATCH v3 3/5] all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO

Continuation of e42aaaf92a4b0c88d60acc12df64c81d0887c26f Signed-off-by: L. E. Segovia --- fftools/ffprobe.c | 16 +++- fftools/opt_common.c| 12 ++-- libavformat/rtmpproto.c | 24 ++-- 3 files changed, 39 insertions(+), 13 deletions(-) diff

[FFmpeg-devel] [PATCH v3 5/5] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Signed-off-by: L. E. Segovia --- libavcodec/x86/aacencdsp_init.c| 2 ++ libavcodec/x86/aacpsdsp_init.c | 2 ++ libavcodec/x86/ac3dsp_init.c | 4 libavcodec/x86/audiodsp_init.c | 2

[FFmpeg-devel] [PATCH v3 4/5] all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Signed-off-by: L. E. Segovia --- libavcodec/x86/hpeldsp_init.c | 2 ++ libavcodec/x86/vc1dsp_init.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/hpeldsp_init.c b/libavcodec/x86/hpeldsp_init.c index

Re: [FFmpeg-devel] [PATCH v3 0/5] Fix FFmpeg compilation without DCE

Ping for review. amyspark On 03/11/2022 13:36, L. E. Segovia wrote: > Hi all, > > This new version is intended to make Patchwork log the set correctly. > (My apologies there, I'm not used to send patches through the command line.) > > v3 changes (same as v2): > >

Re: [FFmpeg-devel] [PATCH v2 5/5] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM

I move forward anyway with it? On 03/11/2022 12:55, dev at lynne.ee (Lynne) wrote: > Nov 3, 2022, 16:30 by amy at amyspark.me: > >> Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a >> >> Signed-off-by: L. E. Segovia <> amy at amyspark.me> > >> >

Re: [FFmpeg-devel] [PATCH v3 0/5] Fix FFmpeg compilation without DCE

Renewing ping. CC Andreas and Lynne since they were interested previously. amyspark On 07/11/2022 11:48, L. E. Segovia wrote: > Ping for review. > > amyspark > > On 03/11/2022 13:36, L. E. Segovia wrote: >> Hi all, >> >> This new version is intended to mak

Re: [FFmpeg-devel] [PATCH v3 0/5] Fix FFmpeg compilation without DCE

Hi again, Pinging again for review. I've asked for clarification about how should the EXTERNAL_ checks be dealt with, but I've not received any response here. Best, amyspark On 07/11/2022 11:48, L. E. Segovia wrote: > Ping for review. > > amyspark > > On 03/11/2022 1

[FFmpeg-devel] [PATCH] os_support, network: Fix build failure on Windows with BZIP2

Including winsock2.h without WIN32_LEAN_AND_MEAN causes bzlib.h to parse as nonsense, due to an instance of #define char small in rpcndr.h (included transitively from windows.h). See: https://stackoverflow.com/a/27794577 Signed-off-by: L. E. Segovia --- libavformat/network.h| 1

[FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations

Updated for 6.0, any constructive feedback will be appreciated. L. E. Segovia (4): all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2 all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM all: Guard if (EXTERNAL*) checks with

[FFmpeg-devel] [PATCH v4 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Co-authored-by: Nirbheek Chauhan Signed-off-by: L. E. Segovia --- libavcodec/x86/fdctdsp_init.c| 2 + libavcodec/x86/flacdsp_init.c| 8 +- libavcodec/x86/hevcdsp_init.c| 547

[FFmpeg-devel] [PATCH v4 2/4] all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO

Continuation of e42aaaf92a4b0c88d60acc12df64c81d0887c26f Signed-off-by: L. E. Segovia --- fftools/ffprobe.c | 16 +++- fftools/opt_common.c| 12 ++-- libavformat/rtmpproto.c | 24 ++-- 3 files changed, 39 insertions(+), 13 deletions(-) diff

[FFmpeg-devel] [PATCH v4 3/4] all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Signed-off-by: L. E. Segovia --- libavcodec/x86/hpeldsp_init.c | 2 ++ libavcodec/x86/vc1dsp_init.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/hpeldsp_init.c b/libavcodec/x86/hpeldsp_init.c index

[FFmpeg-devel] [PATCH v4 4/4] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Signed-off-by: L. E. Segovia --- libavcodec/x86/aacencdsp_init.c| 2 ++ libavcodec/x86/aacpsdsp_init.c | 2 ++ libavcodec/x86/ac3dsp_init.c | 4 libavcodec/x86/audiodsp_init.c | 2

[FFmpeg-devel] [PATCH] avdevice: Fix disabling audiotoolbox_outdev build on iOS

that output device into the targets. Signed-off-by: L. E. Segovia --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 99388e7664..ccb9d7be7a 100755 --- a/configure +++ b/configure @@ -3577,7 +3577,7 @@ alsa_outdev_deps="

[FFmpeg-devel] [PATCH v2] os_support, network: Fix build failure on Windows with BZIP2

Including winsock2.h without WIN32_LEAN_AND_MEAN causes bzlib.h to parse as nonsense, due to an instance of #define char small in rpcndr.h (included transitively from windows.h). See: https://stackoverflow.com/a/27794577 Signed-off-by: L. E. Segovia --- libavformat/network.h| 1

Re: [FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations

Hi all, Yes, the linking step bails out with optimizations disabled under MSVC. The rest of the compilers perform DCE even at -O0, but under Windows, the /FORCE:UNRESOLVED linker flag is needed to work around this. As for the stub generation -- given the amount of places that these patches touch

[FFmpeg-devel] [PATCH v2] avdevice: Fix disabling audiotoolbox_outdev build on iOS

that output device into the targets. Signed-off-by: L. E. Segovia --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 99388e7664..ccb9d7be7a 100755 --- a/configure +++ b/configure @@ -3577,7 +3577,7 @@ alsa_outdev_deps="

[FFmpeg-devel] [PATCH v5 0/4] Fix MSVC build without optimizations

Sending again to fix the format=flowed mishap. L. E. Segovia (4): all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2 all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM

[FFmpeg-devel] [PATCH v5 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Co-authored-by: Nirbheek Chauhan Signed-off-by: L. E. Segovia --- libavcodec/x86/fdctdsp_init.c| 2 + libavcodec/x86/flacdsp_init.c| 8 +- libavcodec/x86/hevcdsp_init.c| 547

[FFmpeg-devel] [PATCH v5 2/4] all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO

Continuation of e42aaaf92a4b0c88d60acc12df64c81d0887c26f Signed-off-by: L. E. Segovia --- fftools/ffprobe.c | 16 +++- fftools/opt_common.c| 12 ++-- libavformat/rtmpproto.c | 24 ++-- 3 files changed, 39 insertions(+), 13 deletions(-) diff

[FFmpeg-devel] [PATCH v5 3/4] all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Signed-off-by: L. E. Segovia --- libavcodec/x86/hpeldsp_init.c | 2 ++ libavcodec/x86/vc1dsp_init.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/hpeldsp_init.c b/libavcodec/x86/hpeldsp_init.c index

[FFmpeg-devel] [PATCH v5 4/4] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM

Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Signed-off-by: L. E. Segovia --- libavcodec/x86/aacencdsp_init.c| 2 ++ libavcodec/x86/aacpsdsp_init.c | 2 ++ libavcodec/x86/ac3dsp_init.c | 4 libavcodec/x86/audiodsp_init.c | 2

Re: [FFmpeg-devel] [PATCH v2] avdevice: Fix disabling audiotoolbox_outdev build on iOS

Ping again for review. amyspark On 29/07/2023 16:00, L. E. Segovia wrote: > audiotoolbox.m uses CoreAudio APIs that are only available in macOS. > The existing CoreAudio framework check is already enough for this case > (as CoreAudio.h does not exist for the iDevices), however, it