[FFmpeg-devel] [PATCH] avformat/matroskaenc: return error if aac extradata changes

2020-05-02 Thread John Stebbins
extradata changing would result in an invalid stream. also, as the code was written, rewriting extradata was corrupting the track header resulting in an invalid file. --- libavformat/matroskaenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/matroskaenc.c b/libavformat/m

[FFmpeg-devel] [PATCH] avformat/matroskaenc: return error if aac extradata changes

2020-05-02 Thread John Stebbins
extradata changing would result in an invalid and undecodable stream. Also, as the code was written, rewriting extradata was corrupting the track header resulting in an invalid file. --- libavformat/matroskaenc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavformat/matroskae

Re: [FFmpeg-devel] [PATCH 1/4] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-05-03 Thread John Stebbins
On Sat, 2020-05-02 at 22:30 +0200, Andreas Rheinhardt wrote: > John Stebbins: > > Required to remux m2ts to mkv > > --- > > Changelog| 1 + > > doc/bitstream_filters.texi | 8 ++ > > libavcodec/Makefile | 1 + &g

Re: [FFmpeg-devel] [PATCH 2/4] lavf/matroskaenc: add PGS merge to auto bsf list

2020-05-03 Thread John Stebbins
On Sat, 2020-05-02 at 22:40 +0200, Andreas Rheinhardt wrote: > John Stebbins: > > PGS segments must be merged to one packet for muxing to mkv > > --- > > libavformat/matroskaenc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/

Re: [FFmpeg-devel] [PATCH 3/4] lavc/pgs_frame_split_bsf: add bsf to split PGS segments

2020-05-03 Thread John Stebbins
On Sat, 2020-05-02 at 23:05 +0200, Andreas Rheinhardt wrote: > John Stebbins: > > Requried to remux mkv to m2ts > > --- > > Changelog| 1 + > > doc/bitstream_filters.texi | 8 ++ > > libavcodec/Makefile | 1 + &g

Re: [FFmpeg-devel] [PATCH 1/4] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-05-04 Thread John Stebbins
On Mon, 2020-05-04 at 08:29 +0200, Andreas Rheinhardt wrote: > John Stebbins: > > On Sat, 2020-05-02 at 22:30 +0200, Andreas Rheinhardt wrote: > > > John Stebbins: > > > > Required to remux m2ts to mkv > > > > --- > > > >

[FFmpeg-devel] PGS bsfs

2020-05-08 Thread John Stebbins
Addresses review comments Rebased on master Adds split bsf to mpegtsenc patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.o

[FFmpeg-devel] [PATCH 1/5] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-05-08 Thread John Stebbins
libavcodec/pgs_frame_merge_bsf.c new file mode 100644 index 00..b064febe13 --- /dev/null +++ b/libavcodec/pgs_frame_merge_bsf.c @@ -0,0 +1,183 @@ +/* + * Copyright (c) 2020 John Stebbins + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it

[FFmpeg-devel] [PATCH 3/5] lavc/version: Bump minor-version for new PGS bsfs

2020-05-08 Thread John Stebbins
--- libavcodec/version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/version.h b/libavcodec/version.h index 691320b63c..82255d7f38 100644 --- a/libavcodec/version.h +++ b/libavcodec/version.h @@ -28,7 +28,7 @@ #include "libavutil/version.h" #define LIBAVCODEC

[FFmpeg-devel] [PATCH 2/5] lavc/pgs_frame_split_bsf: add bsf to split PGS segments

2020-05-08 Thread John Stebbins
/pgs_frame_split_bsf.c b/libavcodec/pgs_frame_split_bsf.c new file mode 100644 index 00..cb60f59a87 --- /dev/null +++ b/libavcodec/pgs_frame_split_bsf.c @@ -0,0 +1,179 @@ +/* + * Copyright (c) 2020 John Stebbins + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it

[FFmpeg-devel] [PATCH 4/5] lavf/matroskaenc: enable PGS merge auto bsf

2020-05-08 Thread John Stebbins
PGS segments must be merged to one packet for muxing to mkv --- libavformat/matroskaenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 99b549ecc4..7f2cda41b9 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c

[FFmpeg-devel] [PATCH 5/5] lavf/mpegtsenc: enable PGS split auto bsf

2020-05-08 Thread John Stebbins
PGS segments must be one per packet for muxing to m2ts --- libavformat/mpegtsenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index f2be6c6632..5b86dffd0e 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -1984,6 +198

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-02-01 Thread John Stebbins
On 1/30/19 1:18 PM, Carl Eugen Hoyos wrote: 2019-01-30 19:44 GMT+01:00, no pls : From: mptcultist fixes an issue where if the video size was very specific, ffmpeg would hang from not filling the sidx_pts for all streams, due to not reading the last sidx lump. for #7572 Please wait for a revie

[FFmpeg-devel] [PATCH] avformat/utils: preserve AV_PKT_FLAG_DISCARD in parse_packet

2017-11-10 Thread John Stebbins
--- libavformat/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 2b2411ffe7..93a5a00105 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -1457,6 +1457,7 @@ static int parse_packet(AVFormatContext *s, AVPacket *pkt, int stream

[FFmpeg-devel] fate/mov overlapping fragments

2017-11-13 Thread John Stebbins
The sample required by the following patch cand be downloaded here: https://john.stebbins.name/owncloud/index.php/s/Tyw7MM6WdRBcljA/download ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] fate/mov: add test for overlapping fragments

2017-11-13 Thread John Stebbins
--- tests/fate/mov.mak | 4 ++ tests/ref/fate/mov-frag-overlap | 105 2 files changed, 109 insertions(+) create mode 100644 tests/ref/fate/mov-frag-overlap diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak index 01893a0767..1d20892e2f 10

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not write 0 duration for subtitles

2017-11-15 Thread John Stebbins
On 11/14/2017 02:18 PM, Carl Eugen Hoyos wrote: > 2017-11-14 19:02 GMT+01:00 Jerome Martinez : >> On 12/11/2017 03:12, Carl Eugen Hoyos wrote: >>> -put_ebml_uint(pb, MATROSKA_ID_BLOCKDURATION, duration); >>> +if (duration > 0) >>> +put_ebml_uint(pb, MATROSKA

[FFmpeg-devel] [PATCH] lavf/movenc: allow writing avc3 sample entry type

2017-11-15 Thread John Stebbins
The avc3 sample entry type is useful for adaptive streaming. It permits parameter sets to be written inline in the video stream. --- libavformat/movenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index cc3fc19d9b..01ae467fa1 100644 --- a/libav

[FFmpeg-devel] [PATCH] lavf/mov: don't read outside frag_index bounds

2017-11-17 Thread John Stebbins
Potentially fixes: https://bugs.chromium.org/p/chromium/issues/detail?id=786269#c1 In theory, the crash can be triggered by an invalid stream that has either tfdt or trun outside of the moof --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mov.c b/libavfor

[FFmpeg-devel] mp4 sdtp (sample dependency) box

2017-11-19 Thread John Stebbins
Patch 4 & 5 should be squashed before commit. Patch 4 "works" on it's own, but doesn't account for edit list fix-ups. I seperated them to make reviewing easier. Patch 5 merges ctts_data into the new mov_index_entries struct I created, so it touches quite a lot, but results in a fair amount of cod

[FFmpeg-devel] [PATCH 3/6] lavc/libx265: mark disposable frames

2017-11-19 Thread John Stebbins
Used by movenc to fill sdtp box --- libavcodec/libx265.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 4456e300f2..8279a99ddd 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -329,6 +329,10 @@ FF_DISABLE_DEPRECATION_WARNING

[FFmpeg-devel] [PATCH 1/6] lavf/movenc: add sdtp (sample dependency) box

2017-11-19 Thread John Stebbins
The sdtp is required by the AppleTV 4K in order to play 2160p60 video. --- libavcodec/avcodec.h | 6 ++ libavformat/isom.h | 5 + libavformat/movenc.c | 30 ++ libavformat/movenc.h | 2 ++ 4 files changed, 43 insertions(+) diff --git a/libavcodec/avcodec.h

[FFmpeg-devel] [PATCH 2/6] lavc/libx264: mark disposable frames

2017-11-19 Thread John Stebbins
Used by movenc to fill sdtp box --- libavcodec/libx264.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 9c67c91f33..1831f9b30e 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -116,6 +116,7 @@ static int encode_nals(AVCodec

[FFmpeg-devel] [PATCH 4/6] lavf/mov: set AV_PKT_FLAG_DISPOSABLE from sdtp box

2017-11-19 Thread John Stebbins
--- libavformat/isom.h | 10 ++ libavformat/mov.c | 92 ++--- libavformat/utils.c | 3 +- 3 files changed, 99 insertions(+), 6 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 65676fb0f5..646b31ccc7 100644 --- a/libavf

[FFmpeg-devel] [PATCH 5/6] lavf/mov: fix disposable flags in mov_fix_index

2017-11-19 Thread John Stebbins
Merges ctts_data into mov_index_entries. This allows a considerable amount of code simplification. --- libavformat/isom.h | 1 + libavformat/mov.c | 254 +++-- 2 files changed, 93 insertions(+), 162 deletions(-) diff --git a/libavformat/isom.h b

[FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-19 Thread John Stebbins
--- fftools/ffplay.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..97555d5047 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -257,6 +257,7 @@ typedef struct VideoState { struct SwrContext *swr_ctx; int frame

[FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-19 Thread John Stebbins
--- fftools/ffplay.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..97555d5047 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -257,6 +257,7 @@ typedef struct VideoState { struct SwrContext *swr_ctx; int frame

[FFmpeg-devel] [PATCH 5/6] lavf/mov: fix disposable flags in mov_fix_index

2017-11-19 Thread John Stebbins
Merges ctts_data into mov_index_entries. This allows a considerable amount of code simplification. --- libavformat/isom.h | 1 + libavformat/mov.c | 254 +++-- 2 files changed, 93 insertions(+), 162 deletions(-) diff --git a/libavformat/isom.h b

Re: [FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-19 Thread John Stebbins
On 11/19/2017 01:28 PM, Marton Balint wrote: > On Sun, 19 Nov 2017, John Stebbins wrote: > >> --- >> fftools/ffplay.c | 10 ++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/fftools/ffplay.c b/fftools/ffplay.c >> index 10a917194d..97555d5047

Re: [FFmpeg-devel] [PATCH 1/6] lavf/movenc: add sdtp (sample dependency) box

2017-11-19 Thread John Stebbins
On 11/19/2017 02:12 PM, Carl Eugen Hoyos wrote: > 2017-11-19 21:46 GMT+01:00 John Stebbins : >> The sdtp is required by the AppleTV 4K in order to play 2160p60 video. >> +/** >> + * Flag is used to indicate packets that contain frames that can >> + * be discarde

Re: [FFmpeg-devel] [PATCH 1/6] lavf/movenc: add sdtp (sample dependency) box

2017-11-20 Thread John Stebbins
On 11/19/2017 02:29 PM, Carl Eugen Hoyos wrote: > 2017-11-19 23:25 GMT+01:00 John Stebbins : >> On 11/19/2017 02:12 PM, Carl Eugen Hoyos wrote: >>> 2017-11-19 21:46 GMT+01:00 John Stebbins : >>>> The sdtp is required by the AppleTV 4K in order to play 2160p60 vid

[FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-20 Thread John Stebbins
--- fftools/ffplay.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..f1e0522528 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -198,6 +198,8 @@ typedef struct Decoder { int64_t next_pts;

[FFmpeg-devel] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-20 Thread John Stebbins
This update to the patch incorporates Marton's suggestion to eliminate the effects of buffering on the selection of frames to drop. It ties the decision to start dropping disposable frames to the "early" frame drop logic that happens immediately after avcodec_receive_frame. And disposable frames

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-11-22 Thread John Stebbins
On 11/22/2017 02:36 PM, Carl Eugen Hoyos wrote: > 2017-08-24 0:39 GMT+02:00 Dale Curtis : > >> -sc->ctts_data[ctts_count].count= count; >> -sc->ctts_data[ctts_count].duration = duration; >> -ctts_count++; >> +/* Expand entries such that we have a 1-1 mapping with

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-11-23 Thread John Stebbins
On 11/22/2017 05:26 PM, Carl Eugen Hoyos wrote: > 2017-11-23 1:30 GMT+01:00 John Stebbins : >> On 11/22/2017 02:36 PM, Carl Eugen Hoyos wrote: >>> 2017-08-24 0:39 GMT+02:00 Dale Curtis : >>> >>>> -sc->ctts_data[ctts_count].count= count; >&g

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not write 0 duration for subtitles

2017-11-23 Thread John Stebbins
On 11/23/2017 03:04 AM, Jerome Martinez wrote: > On 12/11/2017 03:12, Carl Eugen Hoyos wrote: >> The matroska spec says blockduration == 0 means the frame is not a >> keyframe. Since all subtitles are "keyframes", 0 blockduration should >> not be written. > As I understand from discussion on CELLA

[FFmpeg-devel] [PATCH] lavf/mov: fix crash in mov_read_sidx

2017-11-24 Thread John Stebbins
Use correct index into streams --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index f3e86dfc6d..ddb1e59b85 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4816,7 +4816,7 @@ static int mov_read_sidx(MOVConte

[FFmpeg-devel] [PATCH] lavf/mov: fix huge alloc in mov_read_ctts

2017-11-25 Thread John Stebbins
An invalid file may cause huge alloc. Delay expansion of ctts entries until the number of samples is known in mov_build_index. --- libavformat/mov.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index ddb

Re: [FFmpeg-devel] [PATCH] lavf/mov: fix huge alloc in mov_read_ctts

2017-11-25 Thread John Stebbins
On 11/25/2017 04:03 PM, Carl Eugen Hoyos wrote: > 2017-11-25 21:11 GMT+01:00 John Stebbins : >> An invalid file may cause huge alloc. Delay expansion of ctts entries >> until the number of samples is known in mov_build_index. > Please mention zhao dongzhuo from ADlab of Venust

Re: [FFmpeg-devel] [PATCH] lavf/mov: fix huge alloc in mov_read_ctts

2017-11-26 Thread John Stebbins
On 11/25/2017 05:03 PM, James Almer wrote: > On 11/25/2017 10:00 PM, John Stebbins wrote: >> On 11/25/2017 04:03 PM, Carl Eugen Hoyos wrote: >>> 2017-11-25 21:11 GMT+01:00 John Stebbins : >>>> An invalid file may cause huge alloc. Delay expansion of ctts entries &g

[FFmpeg-devel] [PATCH] lavf/mov: fix huge alloc in mov_read_ctts

2017-11-26 Thread John Stebbins
An invalid file may cause huge alloc. Delay expansion of ctts entries until the number of samples is known in mov_build_index. Found-by: zhao dongzhuo, AD-lab of Venustech --- libavformat/mov.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/l

Re: [FFmpeg-devel] [mov] Remove concept of ctts entries with count > 1.

2017-11-27 Thread John Stebbins
signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 3/6] lavc/libx265: mark disposable frames

2017-11-30 Thread John Stebbins
Used by movenc to fill sdtp box --- libavcodec/libx265.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 4456e300f2..c137fe4ae1 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -329,6 +329,9 @@ FF_DISABLE_DEPRECATION_WARNINGS

[FFmpeg-devel] lavc/libx265: mark disposable frames

2017-11-30 Thread John Stebbins
Remove redundant sliceType check. It is only needed if using x265 2.4 or below where sliceType BREF is never set. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] lavf/mov: set AV_PKT_FLAG_DISPOSABLE from sdtp box

2017-11-30 Thread John Stebbins
Rebase to resolve conflicts. These 2 patches should be merged before commit. They are separated to make reviewing easier. Patch 4 alone does not account for edit list fix-ups. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mail

[FFmpeg-devel] [PATCH 4/6] lavf/mov: set AV_PKT_FLAG_DISPOSABLE from sdtp box

2017-11-30 Thread John Stebbins
--- libavformat/isom.h | 10 ++ libavformat/mov.c | 92 ++--- libavformat/utils.c | 3 +- 3 files changed, 99 insertions(+), 6 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 65676fb0f5..646b31ccc7 100644 --- a/libavf

[FFmpeg-devel] [PATCH 5/6] lavf/mov: fix disposable flags in mov_fix_index

2017-11-30 Thread John Stebbins
Merges ctts_data into mov_index_entries. This allows a considerable amount of code simplification. --- libavformat/isom.h | 1 + libavformat/mov.c | 312 ++--- 2 files changed, 130 insertions(+), 183 deletions(-) diff --git a/libavformat/isom.h

[FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-30 Thread John Stebbins
--- fftools/ffplay.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..152d220cdb 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -198,6 +198,8 @@ typedef struct Decoder { int64_t next_pts;

[FFmpeg-devel] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-30 Thread John Stebbins
Fix parenthesis in conditional ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-12-01 Thread John Stebbins
On 12/01/2017 08:25 AM, wm4 wrote: > On Thu, 30 Nov 2017 16:27:01 -0800 > John Stebbins wrote: > >> --- >> fftools/ffplay.c | 21 - >> 1 file changed, 16 insertions(+), 5 deletions(-) >> >> diff --git a/fftools/ffplay.c b/fftools/f

Re: [FFmpeg-devel] [PATCH 3/6] lavc/libx265: mark disposable frames

2017-12-02 Thread John Stebbins
On 12/02/2017 01:40 AM, Marton Balint wrote: > On Thu, 30 Nov 2017, John Stebbins wrote: > >> Used by movenc to fill sdtp box >> --- >> libavcodec/libx265.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavcodec/libx265.c b/libavcodec

Re: [FFmpeg-devel] [PATCH 3/6] lavc/libx265: mark disposable frames

2017-12-02 Thread John Stebbins
On 12/02/2017 09:25 AM, James Almer wrote: > On 12/2/2017 1:52 PM, John Stebbins wrote: >> On 12/02/2017 01:40 AM, Marton Balint wrote: >>> On Thu, 30 Nov 2017, John Stebbins wrote: >>> >>>> Used by movenc to fill sdtp box >>>> --- >&

Re: [FFmpeg-devel] [PATCH 3/6] lavc/libx265: mark disposable frames

2017-12-03 Thread John Stebbins
>>> On 12/2/2017 2:40 PM, Carl Eugen Hoyos wrote: >>>>>> 2017-12-02 18:37 GMT+01:00 John Stebbins : >>>>>>> That should be done, or I should add back support for earlier versions. >>>>>>> Is there any desire by anyone to keep support f

Re: [FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-12-04 Thread John Stebbins
On 12/03/2017 01:12 PM, Marton Balint wrote: > On Thu, 30 Nov 2017, John Stebbins wrote: > >> --- >> fftools/ffplay.c | 21 - >> 1 file changed, 16 insertions(+), 5 deletions(-) >> >> diff --git a/fftools/ffplay.c b/fftools/ffplay.c &g

[FFmpeg-devel] lavc/libx265: mark disposable frames

2017-12-05 Thread John Stebbins
Add ifdef to support versions of x265 <= 2.4 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 3/6] lavc/libx265: mark disposable frames

2017-12-05 Thread John Stebbins
Used by movenc to fill sdtp box --- libavcodec/libx265.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 4456e300f2..69bfc4fdaa 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -329,6 +329,13 @@ FF_DISABLE_DEPRECATION_WARN

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: flag discardable packets as such

2017-12-15 Thread John Stebbins
On 12/13/2017 07:14 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/matroskaenc.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > This only has an effect when muxing h265 streams originating from the > libx265 wrapper atm, as no other encoder or demuxer

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: flag discardable packets as such

2017-12-15 Thread John Stebbins
On 12/15/2017 10:00 AM, James Almer wrote: > On 12/15/2017 2:56 PM, John Stebbins wrote: >> On 12/13/2017 07:14 PM, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> libavformat/matroskaenc.c | 8 ++-- >>> 1 file changed, 6 insertion

[FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. Append new "trun" index entries to the end of the index instead of sorting by timestamp. Sorting by timestamp causes packets to be read out of decode order and results in decode errors.

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
On 09/25/2017 10:12 AM, Carl Eugen Hoyos wrote: > 2017-09-25 19:10 GMT+02:00 John Stebbins : >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. Append new "trun" index >> entries to the end of

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
On 09/25/2017 10:31 AM, wm4 wrote: > On Mon, 25 Sep 2017 10:10:58 -0700 > John Stebbins wrote: > >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. Append new "trun" index >> entries to the e

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
On 09/25/2017 01:12 PM, Carl Eugen Hoyos wrote: > 2017-09-25 19:10 GMT+02:00 John Stebbins : >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. Append new "trun" index >> entries to the end of

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
On 09/25/2017 02:27 PM, Carl Eugen Hoyos wrote: > 2017-09-25 23:12 GMT+02:00 John Stebbins : >> FYI, such a facility for marking frames to drop would also >> be useful for frame accurate playback of MP4 edit lists. > Do you have samples with edit lists that do not play > c

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-28 Thread John Stebbins
On 09/26/2017 05:12 PM, Michael Niedermayer wrote: Hi On Mon, Sep 25, 2017 at 02:12:26PM -0700, John Stebbins wrote: On 09/25/2017 01:12 PM, Carl Eugen Hoyos wrote: 2017-09-25 19:10 GMT+02:00 John Stebbins : When keyframe intervals of dash segments are not perfectly aligned, fragments in

[FFmpeg-devel] [PATCH 2/2] mov: fix non-monotonous DTS when fragments overlap in time

2017-09-29 Thread John Stebbins
--- libavformat/mov.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index c7422cd9ed..871f10b240 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4267,6 +4267,7 @@ static int mov_read_trun(MOVContext *c, AVIOCo

[FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-09-29 Thread John Stebbins
When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. Append new "trun" index entries to the end of the index instead of sorting by timestamp. Sorting by timestamp causes packets to be read out of decode order and results in decode errors.

[FFmpeg-devel] [PATCH 2/2] mov: fix non-monotonous DTS when fragments overlap in time

2017-10-01 Thread John Stebbins
--- libavformat/mov.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index c7422cd9ed..bc3c9cb35b 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4267,6 +4267,7 @@ static int mov_read_trun(MOVContext *c, AVIOCo

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-04 Thread John Stebbins
On 10/04/2017 03:50 AM, Michael Niedermayer wrote: > On Fri, Sep 29, 2017 at 08:54:08AM -0700, John Stebbins wrote: >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. Append new "trun" index >>

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-04 Thread John Stebbins
On 10/04/2017 10:13 AM, Michael Niedermayer wrote: > On Wed, Oct 04, 2017 at 08:18:59AM -0700, John Stebbins wrote: >> On 10/04/2017 03:50 AM, Michael Niedermayer wrote: >>> On Fri, Sep 29, 2017 at 08:54:08AM -0700, John Stebbins wrote: >>>> When keyframe inte

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-05 Thread John Stebbins
On 10/04/2017 03:21 PM, Michael Niedermayer wrote: > On Wed, Oct 04, 2017 at 10:58:19AM -0700, John Stebbins wrote: >> On 10/04/2017 10:13 AM, Michael Niedermayer wrote: >>> On Wed, Oct 04, 2017 at 08:18:59AM -0700, John Stebbins wrote: >>>> On 10/04/2017 03:50

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-05 Thread John Stebbins
On 10/05/2017 09:45 AM, John Stebbins wrote: > On 10/04/2017 03:21 PM, Michael Niedermayer wrote: >> On Wed, Oct 04, 2017 at 10:58:19AM -0700, John Stebbins wrote: >>> On 10/04/2017 10:13 AM, Michael Niedermayer wrote: >>>> On Wed, Oct 04, 2017 at 08:18:59AM -0700, Jo

[FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-09 Thread John Stebbins
When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. The previous sorting by timestamp causes packets to be read out of decode order and results in decode errors. Insert new "trun" index entries into index_entries in the order that the tr

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-09 Thread John Stebbins
On 10/06/2017 04:20 PM, Michael Niedermayer wrote: > On Thu, Oct 05, 2017 at 02:38:48PM -0700, John Stebbins wrote: >> On 10/05/2017 09:45 AM, John Stebbins wrote: >>> On 10/04/2017 03:21 PM, Michael Niedermayer wrote: >>>> On Wed, Oct 04, 2017 at 10:58:19AM -0700, Jo

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-09 Thread John Stebbins
On 10/09/2017 02:40 PM, Carl Eugen Hoyos wrote: > 2017-10-09 22:09 GMT+02:00 John Stebbins : > >> +// This shouldn't happen >> +return NULL; > As in: This cannot happen and should be an assert() > or this does not happen for valid files and should print > a

[FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-10 Thread John Stebbins
When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. The previous sorting by timestamp causes packets to be read out of decode order and results in decode errors. Insert new "trun" index entries into index_entries in the order that the tr

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-10 Thread John Stebbins
On 10/10/2017 09:57 AM, Michael Niedermayer wrote: > On Mon, Oct 09, 2017 at 01:09:11PM -0700, John Stebbins wrote: >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. The previous sorting by >> timestamp caus

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-11 Thread John Stebbins
On 10/11/2017 06:25 PM, Michael Niedermayer wrote: > On Tue, Oct 10, 2017 at 06:11:08PM -0700, John Stebbins wrote: >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. The previous sorting by >> timestamp caus

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-11 Thread John Stebbins
On 10/11/2017 06:25 PM, Michael Niedermayer wrote: On Tue, Oct 10, 2017 at 06:11:08PM -0700, John Stebbins wrote: When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. The previous sorting by timestamp causes packets to be read out of

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-12 Thread John Stebbins
On 10/12/2017 10:22 AM, Michael Niedermayer wrote: > On Wed, Oct 11, 2017 at 10:56:41PM -0700, John Stebbins wrote: >> On 10/11/2017 06:25 PM, Michael Niedermayer wrote: >>> On Tue, Oct 10, 2017 at 06:11:08PM -0700, John Stebbins wrote: >>>> When keyframe inte

[FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-12 Thread John Stebbins
When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. The previous sorting by timestamp causes packets to be read out of decode order and results in decode errors. Insert new "trun" index entries into index_entries in the order that the tr

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-22 Thread John Stebbins
On 10/12/2017 10:59 AM, John Stebbins wrote: > When keyframe intervals of dash segments are not perfectly aligned, > fragments in the stream can overlap in time. The previous sorting by > timestamp causes packets to be read out of decode order and results > in decode errors. > >

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-23 Thread John Stebbins
On 10/23/2017 03:24 AM, Michael Niedermayer wrote: > On Thu, Oct 12, 2017 at 10:59:23AM -0700, John Stebbins wrote: >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. The previous sorting by >> timestamp caus

Re: [FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-16 Thread John Stebbins
On 06/16/2018 03:49 AM, Gyan Doshi wrote: > Activates functionality added a few years ago. > > Regards, > Gyan > FYI, HandBrake has been using the "handler" metadata key since 2014 when I added this code.  And it was completely self-consistent (since it was the only occurrence of usage of this k

Re: [FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-18 Thread John Stebbins
On 06/18/2018 07:30 AM, Gyan Doshi wrote: > > On 17-06-2018 10:07 AM, Gyan Doshi wrote: > >>> Just need to make a note to myself to fix HandBrake when we >>> update to a version of ffmpeg with the change. >> I can just use an if-else to check for both, giving priority to 'handler'. > When I wrote

[FFmpeg-devel] [PATCH] h264_slice: Fix return of incomplete frames from decoder

2018-06-27 Thread John Stebbins
When not using libavformat for demuxing, AVCodecContext.has_b_frames gets set too late causing the recovery frame heuristic in h264_refs to incorrectly flag an early frame as recovered. This patch sets has_b_frames earlier to prevent improperly flagging the frame as recovered. --- libavcodec/h264

Re: [FFmpeg-devel] [PATCH 81/87] avcodec: Move all AVCodecParser.split functions to remove_extradata_bsf

2022-05-12 Thread John Stebbins
Hi all, I know this happened quite some time ago, but we just noticed the change. This effectively disables the public API AVCodecParser.split for these codecs. HandBrake uses this API to split out extradata for a few codecs. Any chance we can bring these back? Otherwise, we will have to replica

Re: [FFmpeg-devel] [PATCH 81/87] avcodec: Move all AVCodecParser.split functions to remove_extradata_bsf

2022-05-12 Thread John Stebbins
Thanks for the pointer. Much appreciated. On Thu, 2022-05-12 at 17:43 +0200, Andreas Rheinhardt wrote: > John Stebbins: > > Hi all, > > > > I know this happened quite some time ago, but we just noticed the > > change. > > > > This effectively disables

<    1   2