[FFmpeg-devel] [PATCH 5/8] avcodec/get_bits: add get_leb()

Signed-off-by: James Almer --- libavcodec/bitstream.h | 2 ++ libavcodec/bitstream_template.h | 23 +++ libavcodec/get_bits.h | 24 3 files changed, 49 insertions(+) diff --git a/libavcodec/bitstream.h b/libavcodec/bitstream.h

[FFmpeg-devel] [PATCH 6/8] avformat/aviobuf: add ffio_read_leb() and ffio_write_leb()

Signed-off-by: James Almer --- libavformat/avio_internal.h | 10 ++ libavformat/aviobuf.c | 33 + 2 files changed, 43 insertions(+) diff --git a/libavformat/avio_internal.h b/libavformat/avio_internal.h index bd58499b64..f2e4ff30cb 100644 --- a

[FFmpeg-devel] [PATCH 8/8] avformat: Immersive Audio Model and Formats muxer

Signed-off-by: James Almer --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/iamf_writer.c | 860 ++ libavformat/iamf_writer.h | 51 +++ libavformat/iamfenc.c | 387 + 5 files changed, 1300 insertions

[FFmpeg-devel] [PATCH 7/8] avformat: Immersive Audio Model and Formats demuxer

Signed-off-by: James Almer --- libavformat/Makefile |1 + libavformat/allformats.c |1 + libavformat/iamf.c | 125 + libavformat/iamf.h | 163 ++ libavformat/iamf_parse.c | 1106 ++ libavformat/iamf_parse.h | 38

Re: [FFmpeg-devel] [PATCH] riscv: Tweak names of cpu flags, print flags in libavutil/tests/cpu

On 12/15/2023 10:05 AM, Martin Storsjö wrote: The names of the cpu flags are pased by the libavutil eval functions - names with dashes are parsed as a subtraction. Replace dashes with underscores. Add these cpu flags to libavutil/tests/cpu, so that the detected cpu flags also get printed when ru

[FFmpeg-devel] [PATCH 3/8] ffmpeg: add support for muxing AVStreamGroups

Starting with IAMF support. Signed-off-by: James Almer --- doc/ffmpeg.texi | 200 ++ fftools/ffmpeg.h | 2 + fftools/ffmpeg_mux_init.c | 342 ++ fftools/ffmpeg_opt.c | 2 + 4 files changed, 546 insertions

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/cbs_vp8: Do not use assert to check for end

On 12/16/2023 9:16 AM, Michael Niedermayer wrote: Fixes: abort() Fixes: 64232/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5417957987319808 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] web: remove myself from FFmpeg consulting page

On 12/16/2023 11:34 AM, Paul B Mahol wrote: Can someone commit this already? You still have commit rights. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or ema

Re: [FFmpeg-devel] [PATCH] web: remove myself from FFmpeg consulting page

On 12/16/2023 11:43 AM, Paul B Mahol wrote: On Sat, Dec 16, 2023 at 3:41 PM James Almer wrote: On 12/16/2023 11:34 AM, Paul B Mahol wrote: Can someone commit this already? You still have commit rights. For web? Yes, The ssh key you use for ffmpeg.git should work for ffmpeg-web.git too

Re: [FFmpeg-devel] [PATCH] web: remove myself from FFmpeg consulting page

On 12/16/2023 11:47 AM, Paul B Mahol wrote: On Sat, Dec 16, 2023 at 3:45 PM James Almer wrote: On 12/16/2023 11:43 AM, Paul B Mahol wrote: On Sat, Dec 16, 2023 at 3:41 PM James Almer wrote: On 12/16/2023 11:34 AM, Paul B Mahol wrote: Can someone commit this already? You still have

Re: [FFmpeg-devel] [PATCH] web: remove myself from FFmpeg consulting page

On 12/16/2023 11:52 AM, Paul B Mahol wrote: On Sat, Dec 16, 2023 at 3:49 PM James Almer wrote: On 12/16/2023 11:47 AM, Paul B Mahol wrote: On Sat, Dec 16, 2023 at 3:45 PM James Almer wrote: On 12/16/2023 11:43 AM, Paul B Mahol wrote: On Sat, Dec 16, 2023 at 3:41 PM James Almer wrote

Re: [FFmpeg-devel] [PATCH v3] riscv: Tweak names of cpu flags, print flags in libavutil/tests/cpu

On 12/17/2023 9:36 AM, Martin Storsjö wrote: The names of the cpu flags, when parsed from a string with av_parse_cpu_caps, are parsed by the libavutil eval functions. These interpret dashes as subtractions. Therefore, these previous cpu flag names haven't been possible to set. Use the official n

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup

On 12/17/2023 10:18 AM, Michael Niedermayer wrote: Fixes: abort() Fixes: 64232/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5417957987319808 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCHv2 1/1] checkasm/lpc: test compute_autocorr

On 12/17/2023 6:13 AM, Rémi Denis-Courmont wrote: --- tests/checkasm/lpc.c | 47 ++-- 1 file changed, 45 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c index 592e34c03d..9b33f8a3b0 100644 --- a/tests/checkasm/lpc.

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/flvenc: support enhanced flv PacketTypeMetadata

On 12/17/2023 1:24 PM, zhupengfei via ffmpeg-devel wrote: From: Zhu Pengfei <411294...@qq.com> Signed-off-by: Zhu Pengfei <411294...@qq.com> --- libavformat/flvenc.c | 155 +++ 1 file changed, 155 insertions(+) diff --git a/libavformat/flvenc.c b/libav

[FFmpeg-devel] [PATCH] avformat/matroskadec: disable parsing for AV1 streams

Keyframes are signaled at the container level on Matroska/Webm files, so bitstream parsing for that purpose is unnecessary. Should speed up demuxing a bit. Signed-off-by: James Almer --- libavformat/matroskadec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat

[FFmpeg-devel] [PATCH v3] avcodec: add AV1 frame split bitstream filter

This will be needed by the eventual native AV1 decoder. Signed-off-by: James Almer --- Now propagating the Temporal Unit unchanged if splitting can't be performed. configure| 1 + libavcodec/Makefile | 1 + libavcodec/av1_frame_split_bsf.c

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hevcdec: Avoid only partly skiping duplicate first slices

On 3/26/2019 9:17 PM, Michael Niedermayer wrote: > Fixes: NULL pointer dereference and out of array access > Fixes: > 13871/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5746167087890432 > Fixes: > 13845/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-565037072803430

[FFmpeg-devel] [PATCH] avformat/movenc: free eac3 private data only when closing the stream

This makes sure the data is available when writing the moov atom during the second pass triggered by the faststart movflag. Fixes ticket #7780 Signed-off-by: James Almer --- This is why errors should always be propagated, or at least a warning printed even if they are ignored. libavformat

Re: [FFmpeg-devel] [PATCH] Added more commandline options for libaom encoder.

On 3/29/2019 1:58 PM, Sam John via ffmpeg-devel wrote: > The following are the newly added options: > arnr_max_frames, arnr_strength, aq_mode, denoise_noise_level, > denoise_block_size, > rc_undershoot_pct, rc_overshoot_pct, minsection_pct, maxsection_pct, > frame_parallel, > enable_cdef, enable_

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/libaomenc: fix default value for row-mt option

On 3/30/2019 8:20 AM, Gyan wrote: > > > On 29-03-2019 11:26 PM, James Almer wrote: >> ffmpeg | branch: master | James Almer | Fri Mar 29 >> 14:55:00 2019 -0300| [0856c5da0716e9c461d4f73339a2c2390d0a1162] | >> committer: James Almer >> >> avcodec/libaome

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: add support for Padding OBUs

On 3/25/2019 11:22 AM, James Almer wrote: > Based on itut_t35 Matadata OBU parsing code. > > Signed-off-by: James Almer > --- > libavcodec/cbs_av1.c | 20 + > libavcodec/cbs_av1.h | 7 ++ > libavcodec/cbs_av1_s

Re: [FFmpeg-devel] [PATCH] avcodec: add Amuse Graphics decoder

On 3/28/2019 6:12 PM, Paul B Mahol wrote: > This work is sponsored by VideoLAN. > > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/agm.c| 701 > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 +

Re: [FFmpeg-devel] [PATCH] avformat/movenc: free eac3 private data only when closing the stream

On 3/28/2019 10:41 PM, James Almer wrote: > This makes sure the data is available when writing the moov atom during the > second pass triggered by the faststart movflag. > > Fixes ticket #7780 Will push soon. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v3] avcodec: add AV1 frame split bitstream filter

On 3/26/2019 9:25 PM, James Almer wrote: > This will be needed by the eventual native AV1 decoder. > > Signed-off-by: James Almer > --- > Now propagating the Temporal Unit unchanged if splitting can't be performed. Ping. ___ ffmpe

Re: [FFmpeg-devel] [PATCH 4/5] x86/opusdsp: implement FMA3 accelerated postfilter and deemphasis

On 3/31/2019 7:26 PM, Carl Eugen Hoyos wrote: > 2019-03-29 19:05 GMT+01:00, Lynne : >> Mar 16, 2019, 4:33 PM by d...@lynne.ee : >> >>> 58893 decicycles in deemphasis_c, 130548 runs,524 skips >>> 9475 decicycles in deemphasis_fma3, 130686 runs,386 skips -> 6.21x >>> s

Re: [FFmpeg-devel] [PATCH 4/5] x86/opusdsp: implement FMA3 accelerated postfilter and deemphasis

On 3/16/2019 1:33 PM, Lynne wrote: > diff --git a/libavcodec/x86/opusdsp.asm b/libavcodec/x86/opusdsp.asm > new file mode 100644 > index 00..ed65614e06 > --- /dev/null > +++ b/libavcodec/x86/opusdsp.asm > @@ -0,0 +1,114 @@ > +;

Re: [FFmpeg-devel] [PATCH 4/5] x86/opusdsp: implement FMA3 accelerated postfilter and deemphasis

On 4/1/2019 9:13 AM, Lynne wrote: > Mar 31, 2019, 11:49 PM by jamr...@gmail.com: > >> A float ret value needs to be in xmm0, and you swapped m0 with m2 on >> Win64. This is the source of the fate failure. >> > Attached a patch to fix this. > >> %if WIN64 >> -    SWAP 0, 2 >> -%endif >> +    shufp

Re: [FFmpeg-devel] [PATCH] lavc/hevc_ps: parse constraint flags for HEVC REXT

On 4/1/2019 6:43 AM, Linjie Fu wrote: > Parse all the constraint flags. > > It can be passed to hw decoders to detemine the exact profile for Range > Extension HEVC. > > Signed-off-by: Linjie Fu > --- > libavcodec/hevc_ps.c | 18 +++--- > libavcodec/hevc_ps.h | 10 ++ > 2 fi

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: add support for Padding OBUs

On 4/1/2019 7:47 PM, Mark Thompson wrote: > On 25/03/2019 14:22, James Almer wrote: >> Based on itut_t35 Matadata OBU parsing code. >> >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_av1.c | 20 + >> li

Re: [FFmpeg-devel] [PATCH 4/5] x86/opusdsp: implement FMA3 accelerated postfilter and deemphasis

On 4/2/2019 9:16 AM, Hendrik Leppkes wrote: > On Mon, Apr 1, 2019 at 4:59 PM James Almer wrote: >> >> On 4/1/2019 9:13 AM, Lynne wrote: >>> Mar 31, 2019, 11:49 PM by jamr...@gmail.com: >>> >>>> A float ret value needs to be in xmm0, and you swapped m0

Re: [FFmpeg-devel] [PATCH 10/15] avformat/matroskaenc: Avoid seeking when writing level 1 elements

On 4/2/2019 1:23 PM, Hendrik Leppkes wrote: > On Tue, Apr 2, 2019 at 5:55 PM Andreas Rheinhardt via ffmpeg-devel > wrote: >> >> Hello, >> >> thanks for taking a look at this. >> >> Hendrik Leppkes: >>> On Tue, Apr 2, 2019 at 3:36 PM Andreas Rheinhardt via ffmpeg-devel >>> wrote: Up unti

Re: [FFmpeg-devel] [PATCH v2 6/9] cbs_av1: Implement parser entrypoint

On 4/1/2019 8:39 PM, Mark Thompson wrote: > --- > Unsure about this one - while the patch is short, it's rather invasive in a > pretty ugly way with how it abuses the read call. It will still do > allocations for the decomposition because of that, even though we don't > really want them. > > A

Re: [FFmpeg-devel] [PATCH v2 6/9] cbs_av1: Implement parser entrypoint

On 4/2/2019 3:36 PM, James Almer wrote: > On 4/1/2019 8:39 PM, Mark Thompson wrote: >> --- >> Unsure about this one - while the patch is short, it's rather invasive in a >> pretty ugly way with how it abuses the read call. It will still do >> allocations for t

Re: [FFmpeg-devel] [PATCH v2 6/9] cbs_av1: Implement parser entrypoint

On 4/1/2019 8:39 PM, Mark Thompson wrote: > +static int cbs_av1_parse_obu(CodedBitstreamContext *ctx, > + void *priv, int obu_type, > + const uint8_t *data, size_t data_size) > +{ > +CodedBitstreamUnit unit; > +int err; > + > +// T

Re: [FFmpeg-devel] [PATCH v2 8/9] av1_parser: Use CBS parser interface

On 4/1/2019 8:39 PM, Mark Thompson wrote: > This simplifies the parser and improves performance by reducing the number > of allocations and eliminating redundant copies. > --- > libavcodec/av1_parser.c | 63 + > 1 file changed, 13 insertions(+), 50 deletions

Re: [FFmpeg-devel] [PATCH v2 7/9] cbs_av1: Fill context information for show-existing-frame

On 4/1/2019 8:39 PM, Mark Thompson wrote: > --- > libavcodec/cbs_av1_syntax_template.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/libavcodec/cbs_av1_syntax_template.c > b/libavcodec/cbs_av1_syntax_template.c > index 76eb90b279..a9bf78e4ad 100644 > --- a/libavcodec

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_parse: change prefix to avpriv for usage in avformat mxf muxer

On 4/3/2019 9:25 AM, Baptiste Coudurier wrote: > Hey Hendrik > >> On Apr 3, 2019, at 11:37 AM, Hendrik Leppkes wrote: >> >> On Wed, Apr 3, 2019 at 11:22 AM Baptiste Coudurier >> wrote: >>> >>> --- >>> libavcodec/cbs_h2645.c | 28 ++-- >>> libavcodec/extract_ext

Re: [FFmpeg-devel] [PATCH] Updated the documentation about the encoding options for libaom-av1 encoder.

On 4/2/2019 9:49 PM, Sam John via ffmpeg-devel wrote: > --- > doc/encoders.texi | 46 ++ > 1 file changed, 46 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 94337d009c..a669ac3739 100644 > --- a/doc/encoders.texi > +++ b/do

Re: [FFmpeg-devel] [PATCH] tests: don't include TARGET_PATH in the sample path needlessly

On 4/3/2019 7:17 PM, Hendrik Leppkes wrote: > The transcode() helper function will already prepend the TARGET_PATH to > the sample path, if its a relative path. This avoids an issue on > Windows, where the relative path check could fail. > --- > tests/fate/ffmpeg.mak | 2 +- > 1 file changed, 1 in

Re: [FFmpeg-devel] Is it possible to run just a single FATE test?

On 4/4/2019 9:45 PM, Allan Cady via ffmpeg-devel wrote: > Is it possible to run just a single FATE test against local code while doing > development, rather than running the entire test suite, to speed up the > iteration cycle? I expect it is, but I don't see how explained in the > documentation

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add bink2 video decoder

On 3/27/2019 5:21 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > Missing deblocking. > --- > configure |1 + > libavcodec/Makefile |1 + > libavcodec/allcodecs.c |1 + > libavcodec/avcodec.h|1 + > libavcodec/bink2.c | 787 ++

Re: [FFmpeg-devel] [PATCH] libavutil/timestamp.h: Fix loss of precision in timestamps for silencedetect on long files

On 4/7/2019 4:47 AM, Allan Cady via ffmpeg-devel wrote: > [Second try submitting to the list. This patch now passes fate.] > > When the silencedetect filter is run against long files, the output > timestamps gradually lose precision as the scan proceeds further into > the file. This is because the

Re: [FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: factorize frame threading

On 4/7/2019 3:47 PM, Marton Balint wrote: > framethread.c is put into libavutil, but is has to be included directly to > avoid creating avpriv functions. If the reason behind this factorization is sharing the code between modules across several libraries and the function signatures are unlikely to

Re: [FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: factorize frame threading

On 4/7/2019 4:22 PM, Marton Balint wrote: > > > On Sun, 7 Apr 2019, James Almer wrote: > >> On 4/7/2019 3:47 PM, Marton Balint wrote: >>> framethread.c is put into libavutil, but is has to be included >>> directly to >>> avoid creating avpr

Re: [FFmpeg-devel] [PATCH v3] avcodec: add AV1 frame split bitstream filter

On 3/31/2019 6:05 PM, James Almer wrote: > On 3/26/2019 9:25 PM, James Almer wrote: >> This will be needed by the eventual native AV1 decoder. >> >> Signed-off-by: James Almer >> --- >> Now propagating the Temporal Unit unchanged if splitting can't be perf

Re: [FFmpeg-devel] [PATCH] avformat/av1: Initialize padding in ff_isom_write_av1c

On 4/8/2019 9:14 AM, Jeremy Dorfman via ffmpeg-devel wrote: > Otherwise, AV1 encodes with FFmpeg trigger use-of-uninitialized-value > warnings under MemorySanitizer, and the output buffer potentially > changes from run to run. > --- > libavformat/av1.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [FFmpeg-devel] [PATCH, v3 RFC 2/2] lavc/vaapi_decode: find exact va_profile for HEVC_REXT

On 4/7/2019 11:02 PM, Fu, Linjie wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Michael Niedermayer >> Sent: Friday, April 5, 2019 00:52 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg

Re: [FFmpeg-devel] [PATCH] avformat/av1: Initialize padding in ff_isom_write_av1c

he explanation. Pushed. > > On Mon, Apr 8, 2019 at 9:33 AM James Almer wrote: > >> On 4/8/2019 9:14 AM, Jeremy Dorfman via ffmpeg-devel wrote: >>> Otherwise, AV1 encodes with FFmpeg trigger use-of-uninitialized-value >>> warnings under MemorySanitizer, and

Re: [FFmpeg-devel] [PATCH] avcodec/agm: add support for higher compression

On 4/8/2019 12:42 PM, Paul B Mahol wrote: >>> +static int decode_huffman2(AVCodecContext *avctx, int header, int size) >>> +{ >>> +AGMContext *s = avctx->priv_data; >>> +GetBitContext *gb = &s->gb; >>> +uint8_t lens[256]; >>> +uint32_t output_size; >>> +int ret, x, len; >>> + >>

Re: [FFmpeg-devel] [RFC 1/6] avutil: add av_buffer_pool_reclaim()

On 4/8/2019 5:12 PM, Jonas Karlman wrote: > Signed-off-by: Jonas Karlman > --- > libavutil/buffer.c | 13 + > libavutil/buffer.h | 5 + > 2 files changed, 18 insertions(+) > > diff --git a/libavutil/buffer.c b/libavutil/buffer.c > index 8d1aa5fa84..9c5d530c7a 100644 > --- a/liba

Re: [FFmpeg-devel] [RFC 2/6] Add common V4L2 request API code

On 4/8/2019 5:12 PM, Jonas Karlman wrote: > Signed-off-by: Jonas Karlman > --- > configure | 8 + > libavcodec/Makefile | 1 + > libavcodec/hwaccel.h | 2 + > libavcodec/v4l2_request.c | 885 ++ > libavcodec/v4l2_request.h | 65

Re: [FFmpeg-devel] [PATCH] matroskaenc: fix leak on error

On 4/9/2019 10:28 AM, Tristan Matthews wrote: > On Thu, Apr 4, 2019 at 12:56 PM Tristan Matthews wrote: >> >> --- >> libavformat/matroskaenc.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c >> index b9f99c4463..

[FFmpeg-devel] [PATCH 1/3] avcodec/h264_parse: clear invalid luma weights in ff_h264_pred_weight_table()

Based on commit 85c85f3f9c75301db3eba1bd5f2fb1e6285d. Signed-off-by: James Almer --- libavcodec/h264_parse.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c index a075443d17..8bdd886000 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

Fixes ticket #7174. Signed-off-by: James Almer --- This makes what's essentially a non spec compliant stream decodable again with no visual artifacts, and without reintroducing the risk of overflows. Alternatively, we could clip the luma and chroma values to the -128..127 range inste

[FFmpeg-devel] [PATCH 3/3] avcodec/h264dec: don't ignore ff_h264_queue_decode_slice() return values

Signed-off-by: James Almer --- libavcodec/h264dec.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 837c3b7538..85a57fc124 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -637,7 +637,7 @@ static

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

On 4/9/2019 7:14 PM, Baptiste Coudurier wrote: > --- > libavformat/Makefile | 2 +- > libavformat/avc.c| 32 +++ > libavformat/avc.h| 2 + > libavformat/hevc.c | 36 +--- > libavformat/mxf.h| 1 + > libavformat/mxfenc.c | 201 +-

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

On 4/9/2019 8:22 PM, Baptiste Coudurier wrote: > Hi James, > >> On Apr 9, 2019, at 4:09 PM, James Almer wrote: >> >>> […] >> >> Ok so, the only fields you need from the sps are constraint_set_flags, >> frame_mbs_only_flag, bit_depth_luma, profile_idc,

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

On 4/9/2019 8:59 PM, Baptiste Coudurier wrote: > >> On Apr 9, 2019, at 4:51 PM, James Almer wrote: >> >> On 4/9/2019 8:22 PM, Baptiste Coudurier wrote: >>> Hi James, >>> >>>> On Apr 9, 2019, at 4:09 PM, James Almer wrote: >>>> >&

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

On 4/9/2019 9:40 PM, Baptiste Coudurier wrote: > >> On Apr 9, 2019, at 5:24 PM, James Almer wrote: >> >> On 4/9/2019 8:59 PM, Baptiste Coudurier wrote: >>> >>>> On Apr 9, 2019, at 4:51 PM, James Almer wrote: >>>> >>>

[FFmpeg-devel] [PATCH 2/2 v2] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

Fixes ticket #7174. Signed-off-by: James Almer --- Now using avpriv_request_sample() libavcodec/h264_parse.c | 15 +-- libavcodec/h264_slice.c | 2 +- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c index 8bdd886000

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

On 4/10/2019 5:24 AM, Michael Niedermayer wrote: > On Tue, Apr 09, 2019 at 03:32:26PM -0300, James Almer wrote: >> Fixes ticket #7174. >> >> Signed-off-by: James Almer >> --- >> This makes what's essentially a non spec compliant stream decodable again >&

[FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

The spec defines the valid range of values to be INT32_MIN + 1 to INT32_MAX, inclusive. Signed-off-by: James Almer --- A good example of why making offsets and sizes of structs like this tied to the ABI is not a good idea. libavcodec/h264_ps.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

On 4/10/2019 2:22 AM, Hendrik Leppkes wrote: > On Wed, Apr 10, 2019 at 3:28 AM James Almer wrote: >>> >>>> Two thirds of SPS is not hard to implement, so i really don't understand >>>> why you're so adamantly against it. >>> >>> I’

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

On 4/10/2019 6:26 PM, Baptiste Coudurier wrote: >> On Apr 9, 2019, at 6:27 PM, James Almer wrote: >> >> On 4/9/2019 9:40 PM, Baptiste Coudurier wrote: >>> >>>> On Apr 9, 2019, at 5:24 PM, James Almer wrote: >>>> >>>> On 4/9/2019 8:5

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

On 4/10/2019 6:23 PM, Baptiste Coudurier wrote: > --- > libavformat/Makefile | 2 +- > libavformat/avc.c| 173 +++ > libavformat/avc.h| 15 +++ > libavformat/hevc.c | 36 +--- > libavformat/mxf.h| 1 + > libavformat/mxfenc.c | 213 +++

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

On 4/10/2019 3:30 PM, James Almer wrote: > The spec defines the valid range of values to be INT32_MIN + 1 to INT32_MAX, > inclusive. > > Signed-off-by: James Almer > --- > A good example of why making offsets and sizes of structs like this tied to > the >

Re: [FFmpeg-devel] [PATCH v3] avcodec: add AV1 frame split bitstream filter

On 4/7/2019 6:45 PM, James Almer wrote: > On 3/31/2019 6:05 PM, James Almer wrote: >> On 3/26/2019 9:25 PM, James Almer wrote: >>> This will be needed by the eventual native AV1 decoder. >>> >>> Signed-off-by: James Almer >>> --- >>> Now prop

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

On 4/13/2019 5:44 AM, Carl Eugen Hoyos wrote: > 2019-04-10 21:47 GMT+02:00, Carl Eugen Hoyos : >> 2019-04-09 20:32 GMT+02:00, James Almer : >>> Fixes ticket #7174. >>> >>> Signed-off-by: James Almer >>> --- >>> This makes what's essentia

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

On 4/13/2019 10:28 AM, James Almer wrote: > On 4/13/2019 5:44 AM, Carl Eugen Hoyos wrote: >> 2019-04-10 21:47 GMT+02:00, Carl Eugen Hoyos : >>> 2019-04-09 20:32 GMT+02:00, James Almer : >>>> Fixes ticket #7174. >>>> >>>> Signed-off-by: James Al

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264: error out on ff_h264_pred_weight_table() only if strict spec compliance is requested

On 4/13/2019 10:46 AM, Carl Eugen Hoyos wrote: > 2019-04-13 15:28 GMT+02:00, James Almer : > >> It would be nice to know what the reference decoder does > > That's why I told you;-) I must have missed it. Outside of saying its output is bitexact for the first sample as f

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: add support for Padding OBUs

On 4/13/2019 4:21 PM, James Almer wrote: > Based on itut_t35 Matadata OBU parsing code. > > Signed-off-by: James Almer > --- > libavcodec/cbs_av1.c | 20 + > libavcodec/cbs_av1.h | 7 ++ > libavcodec/cbs_av1_s

[FFmpeg-devel] [PATCH 2/2 v2] avcodec/cbs_av1: add support for Padding OBUs

Based on itut_t35 Matadata OBU parsing code. Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 20 libavcodec/cbs_av1.h | 7 +++ libavcodec/cbs_av1_syntax_template.c | 24 3 files changed, 51 insertions

[FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: add support for Padding OBUs

Based on itut_t35 Matadata OBU parsing code. Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 20 + libavcodec/cbs_av1.h | 7 ++ libavcodec/cbs_av1_syntax_template.c | 32 3 files changed, 59 insertions

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs_av1: add a function to get a payload size without trailing zero bytes

Factor it out from cbs_av1_read_metadata_itut_t35() Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 11 +++ libavcodec/cbs_av1_syntax_template.c | 10 +- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/libavcodec/cbs_av1.c b/libavcodec

Re: [FFmpeg-devel] [PATCH]lavfi/fspp: Add a cast to silence a clang warning

On 4/13/2019 7:04 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch silences two warnings shown when compiling with clang: > libavfilter/vf_fspp.h:51:42: warning: implicit conversion from 'int' > to 'int16_t' (aka 'short') changes value from 44130 to -21406 > > Please comment, Carl Eugen > >

Re: [FFmpeg-devel] [DECISION] Include more developers in the voting committee [#4]

pporting this, 0 > against. > > So from now on, the voting committe consists of these people: > > Aman Gupta > Andreas Cadhalpun Andreas hasn't been around for a long time. > Carl Eugen Hoyos > Christophe Gisquet > Clément Bœsch > Ganesh Ajjanagadde Same with Gane

Re: [FFmpeg-devel] [PATCH] avcodec: add drop_changed_frames

On 4/14/2019 3:29 PM, Hendrik Leppkes wrote: > On Sun, Apr 14, 2019 at 6:50 PM Gyan wrote: >> >> Implemented this patch >> http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241733.html >> >> >> in libavcodec as suggested by Michael >> > > This sure adds a lot of additional fields to the m

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_av1: add a function to get a payload size without trailing zero bytes

On 4/14/2019 2:17 PM, Mark Thompson wrote: > On 13/04/2019 20:21, James Almer wrote: >> Factor it out from cbs_av1_read_metadata_itut_t35() >> >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_av1.c | 11 +++ >> li

Re: [FFmpeg-devel] [PATCH 2/2 v2] avcodec/cbs_av1: add support for Padding OBUs

On 4/14/2019 2:22 PM, Mark Thompson wrote: > On 13/04/2019 20:25, James Almer wrote: >> Based on itut_t35 Matadata OBU parsing code. >> >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_av1.c | 20 >> li

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: add support for Scalability Metadata

Signed-off-by: James Almer --- This will make the AV1RawObu struct weigh about ~3kb instead of ~1kb. libavcodec/av1.h | 33 libavcodec/cbs_av1.h | 15 +- libavcodec/cbs_av1_syntax_template.c | 45 ++-- 3

[FFmpeg-devel] [PATCH 3/5] avcodec/cbs_h264: fix storage type for time_offset in Pic Timing SEI

The spec defines it as a signed value. Signed-off-by: James Almer --- The only sample i could find with time_offset values it's in the fate suite, and in all cases it's 0. libavcodec/cbs_h264.h | 2 +- libavcodec/cbs_h264_syntax_template.c | 5 +++-- 2 files

[FFmpeg-devel] [PATCH 4/5] avcodec/cbs_h265: fix storage type for time_offset_value in Time Code SEI

The spec defines it as an array of signed values, inferred to 0 when not present. Signed-off-by: James Almer --- Couldn't find any sample using it. libavcodec/cbs_h265.h | 2 +- libavcodec/cbs_h265_syntax_template.c | 7 +-- 2 files changed, 6 insertions(+), 3 dele

[FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

Signed-off-by: James Almer --- libavcodec/cbs.c | 79 +++ libavcodec/cbs_internal.h | 20 +- 2 files changed, 98 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs.c b/libavcodec/cbs.c index c388be896b..726bd582f5 100644 --- a

[FFmpeg-devel] [PATCH 5/5] avcodec/cbs_av1: use the new signed value read/write functions

Signed-off-by: James Almer --- The sample https://0x0.st/sljR.webm appears to be parsed the exact same way after this patch. libavcodec/cbs_av1.c | 68 ++-- 1 file changed, 8 insertions(+), 60 deletions(-) diff --git a/libavcodec/cbs_av1.c b/libavcodec

[FFmpeg-devel] [PATCH 2/5] avcodec/cbs_h2645: add helper macros for signed values

Signed-off-by: James Almer --- libavcodec/cbs_h2645.c | 20 1 file changed, 20 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index e74f8dce81..a205293b3c 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -255,6 +255,8 @@ static

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

On 4/11/2019 12:10 AM, James Almer wrote: > On 4/10/2019 3:30 PM, James Almer wrote: >> The spec defines the valid range of values to be INT32_MIN + 1 to INT32_MAX, >> inclusive. >> >> Signed-off-by: James Almer >> --- >> A good example of why making offs

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

On 4/16/2019 6:48 PM, Mark Thompson wrote: > On 11/04/2019 04:10, James Almer wrote: >> On 4/10/2019 3:30 PM, James Almer wrote: >>> The spec defines the valid range of values to be INT32_MIN + 1 to >>> INT32_MAX, inclusive. >>> >>> Signed-off-by: J

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: add support for Scalability Metadata

On 4/16/2019 7:05 PM, Mark Thompson wrote: > On 14/04/2019 23:04, James Almer wrote: >> Signed-off-by: James Almer >> --- >> This will make the AV1RawObu struct weigh about ~3kb instead of ~1kb. >> >> libavcodec/av1.h | 33

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

On 4/16/2019 7:45 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/cbs.c | 79 +++ >> libavcodec/cbs_internal.h | 20 +- >> 2 files chan

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cbs_h2645: add helper macros for signed values

On 4/16/2019 7:57 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_h2645.c | 20 >> 1 file changed, 20 insertions(+) >> >> diff --git a/libavcodec/cbs_h2

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/cbs_h264: fix storage type for time_offset in Pic Timing SEI

On 4/16/2019 8:00 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> The spec defines it as a signed value. >> >> Signed-off-by: James Almer >> --- >> The only sample i could find with time_offset values it's in the fate suite, >>

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cbs_h2645: add helper macros for signed values

On 4/16/2019 8:24 PM, Mark Thompson wrote: > On 17/04/2019 00:01, James Almer wrote: >> On 4/16/2019 7:57 PM, Mark Thompson wrote: >>> On 15/04/2019 22:17, James Almer wrote: >>>> Signed-off-by: James Almer >>>> --- >>>> libavcodec/cbs_h264

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

On 4/16/2019 8:27 PM, Mark Thompson wrote: > On 16/04/2019 23:54, James Almer wrote: >> On 4/16/2019 7:45 PM, Mark Thompson wrote: >>> On 15/04/2019 22:17, James Almer wrote: >>>> Signed-off-by: James Almer >>>>

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/cbs_h265: fix storage type for time_offset_value in Time Code SEI

On 4/16/2019 8:03 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> The spec defines it as an array of signed values, inferred to 0 when not >> present. >> >> Signed-off-by: James Almer >> --- >> Couldn't find any s

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/cbs_av1: use the new signed value read/write functions

On 4/16/2019 8:10 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> The sample https://0x0.st/sljR.webm appears to be parsed the exact same way >> after this patch. >&

[FFmpeg-devel] [PATCH 1/3] avcodec/cbs_h2645: add macros to read and write fields with no custom range of values

Signed-off-by: James Almer --- Better macro names welcome. I used the same convention as in cbs_av1. fate-cbs passes, but i'm sure a bunch of these are not tested by it, so help double checking i didn't screw up is welcome. libavcodec/cbs_h2645.c| 10 +-

[FFmpeg-devel] [PATCH 2/3] avcodec/cbs_h2645: use the fixed() macro for forbidden_zero_bit

This follows the spec definition, and removes a field from the relevant structs. Signed-off-by: James Almer --- libavcodec/cbs_h264.h | 1 - libavcodec/cbs_h264_syntax_template.c | 2 +- libavcodec/cbs_h265.h | 1 - libavcodec/cbs_h265_syntax_template.c | 2 +- 4

[FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h2645: rename macros to read and write fields with custom range of values

These are more in line with the new ones introduced in the previous commit. Signed-off-by: James Almer --- No more i() macro :p Figured I'd leave all the byte and checksum fields using the custom range macro, to have the explicit hex values visible. That's why they were not changed in

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: add missing value range constrains to timecode Metadata OBU

Also infer the value time_offset_length as 0 when it's not present. Signed-off-by: James Almer --- Fun thing, this metadata OBU is clearly based on the H264/5 timecode SEI, yet time_offset_length is unsigned here :p libavcodec/cbs_av1_syntax_template.c | 14 -- 1 file chang

<    1   2   3   4   5   6   7   8   9   10   >