On 3/30/2019 8:20 AM, Gyan wrote:
>
>
> On 29-03-2019 11:26 PM, James Almer wrote:
>> ffmpeg | branch: master | James Almer <jamr...@gmail.com> | Fri Mar 29
>> 14:55:00 2019 -0300| [0856c5da0716e9c461d4f73339a2c2390d0a1162] |
>> committer: James Almer
>>
>> avcodec/libaomenc: fix default value for row-mt option
>>
>> Signed-off-by: James Almer <jamr...@gmail.com>
>>
>>
>> - { "row-mt", "Enable row based multi-threading",
>> OFFSET(row_mt), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, VE},
>> + { "row-mt", "Enable row based multi-threading",
>> OFFSET(row_mt), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE},
>> { "enable-cdef", "Enable CDEF filtering",
>> OFFSET(enable_cdef), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE},
>> { "enable-global-motion", "Enable global motion",
>> OFFSET(enable_global_motion), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE},
>> { "enable-intrabc", "Enable intra block copy prediction mode",
>> OFFSET(enable_intrabc), AV_OPT_TYPE_BOOL, {.i64 = -1}, 0, 1, VE},
>
> Shouldn't 'enable-intrabc ' follow the same pattern?
Yes, the range is wrong. Should be -1 to 1.
Will fix it, thanks for pointing it out.
>
> And what are the semantics of the user setting row_mt or enable-intrabc
> as -1?
Moritz and Hendrik already explained what's the meaning and use of -1 here.
>
> Gyan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
