[FFmpeg-devel] [PATCH] checkasm: add sample argument to adjust during bench

2024-05-16 Thread J. Dekker
to increase or adjust the sample count for more reliable results. Signed-off-by: J. Dekker --- This could also be implemented as a compile time define or a configure argument. tests/checkasm/checkasm.c | 12 +++- tests/checkasm/checkasm.h | 4 ++-- 2 files changed, 13 insertions

[FFmpeg-devel] [PATCH v2] checkasm: add sample argument to adjust during bench

2024-05-21 Thread J. Dekker
to increase or adjust the sample count for more reliable results. Signed-off-by: J. Dekker --- Auto-detection can be added later when either a count is omitted or a specific value or term such as '0' or 'auto' is provided. This is a development tool, the users will be

[FFmpeg-devel] [PATCH v3] checkasm: add sample argument to adjust during bench

2024-05-21 Thread J. Dekker
developers to increase the sample count for more reliable results. Signed-off-by: J. Dekker --- tests/checkasm/checkasm.c | 16 +++- tests/checkasm/checkasm.h | 7 --- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm

Re: [FFmpeg-devel] [PATCH v3] checkasm: add sample argument to adjust during bench

2024-05-21 Thread J. Dekker
Lynne via ffmpeg-devel writes: > [[PGP Signed Part:Undecided]] > On 21/05/2024 15:51, J. Dekker wrote: >> Some timers on certain device and test combinations can produce noisy >> results, affecting the reliability of performance measurements. One >> notable example of

Re: [FFmpeg-devel] [PATCH] checkasm: print bench runs when benchmarking

2024-05-21 Thread J. Dekker
Lynne via ffmpeg-devel writes: > Helps make sense of the possible noise in the results. > --- > tests/checkasm/checkasm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c > index 669f2be9c1..b1c175b95d 100644 > --- a/tests/checka

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: update current segment reference before use

2024-05-26 Thread J. Dekker
Kacper Michajłow writes: > It may be invalidated by the time it is used. > > Fixes use after free when accessing current segment. > > Fixes: #10825 > Signed-off-by: Kacper Michajłow > --- > libavformat/hls.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/hls.c b/libavfo

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: update current segment reference before use

2024-05-28 Thread J. Dekker
"J. Dekker" writes: > Kacper Michajłow writes: > >> It may be invalidated by the time it is used. >> >> Fixes use after free when accessing current segment. >> >> Fixes: #10825 >> Signed-off-by: Kacper Michajłow >> --- >

[FFmpeg-devel] [PATCH] avcodec/riscv: add h264 dc idct rvv

2024-06-09 Thread J. Dekker
4: 1.2 h264_idct8_add_dc_12bpp_c: 4.2 h264_idct8_add_dc_12bpp_rvv_i64: 1.2 h264_idct8_add_dc_14bpp_c: 4.2 h264_idct8_add_dc_14bpp_rvv_i64: 1.2 Signed-off-by: J. Dekker --- libavcodec/riscv/Makefile | 1 + libavcodec/riscv/h264dsp_init.c | 40 +- libavcodec/riscv/h264dsp_rvv.S

Re: [FFmpeg-devel] [PATCH 2/2] avutil/macos_kperf: Fix assert which makes kperf failed to run

2024-06-17 Thread J. Dekker
On Mon, Jun 17, 2024, at 13:10, Martin Storsjö wrote: > On Wed, 12 Jun 2024, Zhao Zhili wrote: > >> From: Zhao Zhili >> >> On m1, kpc_get_counter_count(KPC_MASK) return 8. The exact value >> doesn't matter in our case. > > This is somewhat unexpected, I had expected that this API was originally >

[FFmpeg-devel] [PATCH] avutil/riscv/cpu: fix __riscv_v_min_vlen typo

2024-06-25 Thread J. Dekker
Signed-off-by: J. Dekker --- libavutil/riscv/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/riscv/cpu.h b/libavutil/riscv/cpu.h index bb8e08aa14..191e4478c5 100644 --- a/libavutil/riscv/cpu.h +++ b/libavutil/riscv/cpu.h @@ -65,7 +65,7 @@ static inline size_t

Re: [FFmpeg-devel] [PATCH] README.md: fix typo

2021-10-07 Thread J. Dekker
On 7 Oct 2021, at 12:40, Arif Driessen wrote: Hi, I think this is a typo... --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 447347c700..f54299d340 100644 --- a/README.md +++ b/README.md @@ -9,7 +9,7 @@ such as audio, video, subtitl

Re: [FFmpeg-devel] next release

2021-10-07 Thread J. Dekker
0 ? 5.0 Should it be made in december 2021 ? (as was suggested in jbs release mail) This seems reasonable. -- J. Dekker ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit lin

[FFmpeg-devel] [PATCH 2/4] lavc/aarch64: add hevc sao edge 8x8

2021-10-07 Thread J. Dekker
--bench on AWS Graviton: hevc_sao_edge_8x8_8_c: 516.0 hevc_sao_edge_8x8_8_neon: 81.0 Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 3 ++ libavcodec/aarch64/hevcdsp_sao_neon.S | 52 +++ 2 files changed, 55 insertions(+) diff --git a

[FFmpeg-devel] [PATCH 1/4] lavc/aarch64: add hevc sao edge 16x16

2021-10-07 Thread J. Dekker
Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 8 ++- libavcodec/aarch64/hevcdsp_sao_neon.S | 66 +++ 2 files changed, 72 insertions(+), 2 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_init_aarch64.c b/libavcodec/aarch64/hevcdsp_init_aarch64

[FFmpeg-devel] [PATCH 3/4] lavc/aarch64: add hevc sao band 8x8 tiling

2021-10-07 Thread J. Dekker
hevc_sao_band_64x64_8_c: 17635.0 hevc_sao_band_64x64_8_neon: 4875.7 Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 6 +- libavcodec/aarch64/hevcdsp_sao_neon.S | 9 ++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/libavcodec/aarch64

[FFmpeg-devel] [PATCH 4/4] lavc/aarch64: clean-up sao band 8x8 function formatting

2021-10-07 Thread J. Dekker
Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_sao_neon.S | 103 +++--- 1 file changed, 44 insertions(+), 59 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_sao_neon.S b/libavcodec/aarch64/hevcdsp_sao_neon.S index 263747149f..c2519da7f5 100644 --- a/libavcodec

[FFmpeg-devel] ARM Hardware Request

2021-10-07 Thread J. Dekker
ike it would be the most reasonable to test (unlocked boot-loader, etc). I am preemptively requesting reimbursement for these devices, suggestions welcome. -- J. Dekker ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/

Re: [FFmpeg-devel] ARM Hardware Request

2021-10-08 Thread J. Dekker
kit is ~1600 EUR, obviously the phone form factor is not ideal for automated testing but it is significantly cheaper. But yes, if anyone can find a Snapdragon 888 in a devkit form (i.e. something I can plug into a network easily) then that would be preferred. Or if someone is able to find one or mult

[FFmpeg-devel] [PATCH 2/2] Revert "arm: hevc_qpel: Fix the assembly to work with non-multiple of 8 widths"

2021-10-16 Thread J. Dekker
This reverts commit 2589060b92eeeb944c6e2b50e38412c0c5fabcf4. Signed-off-by: J. Dekker --- libavcodec/arm/hevcdsp_qpel_neon.S | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/arm/hevcdsp_qpel_neon.S b/libavcodec/arm/hevcdsp_qpel_neon.S index

[FFmpeg-devel] [PATCH 1/2] lavc/arm: dont assign hevc_qpel non-multiple of 8 width stubs

2021-10-16 Thread J. Dekker
Signed-off-by: J. Dekker --- libavcodec/arm/hevcdsp_init_neon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/arm/hevcdsp_init_neon.c b/libavcodec/arm/hevcdsp_init_neon.c index 201a088dac..112edb5edd 100644 --- a/libavcodec/arm/hevcdsp_init_neon.c +++ b

Re: [FFmpeg-devel] [PATCH 4/4] lavc/aarch64: clean-up sao band 8x8 function formatting

2021-10-26 Thread J. Dekker
On 19 Oct 2021, at 10:40, Martin Storsjö wrote: > On Thu, 7 Oct 2021, J. Dekker wrote: > >> Signed-off-by: J. Dekker >> --- >> libavcodec/aarch64/hevcdsp_sao_neon.S | 103 +++--- >> 1 file changed, 44 insertions(+), 59 deletions(-) >>

[FFmpeg-devel] [PATCH v2 1/6] lavc/arm: dont assign hevc_qpel functions for non-multiple of 8 widths

2021-11-16 Thread J. Dekker
This relies on the mappings in ff_hevc_pel_weight[]. Signed-off-by: J. Dekker --- libavcodec/arm/hevcdsp_init_neon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Updated commit message. diff --git a/libavcodec/arm/hevcdsp_init_neon.c b/libavcodec/arm/hevcdsp_init_neon.c index 201a08

[FFmpeg-devel] [PATCH v2 2/6] Revert "arm: hevc_qpel: Fix the assembly to work with non-multiple of 8 widths"

2021-11-16 Thread J. Dekker
This reverts commit 2589060b92eeeb944c6e2b50e38412c0c5fabcf4 which was originally to fix the FATE test. The real cause of the test breakage was fixed in 8dc8f04036eb27c8ad419839d4ed3bc67c44fe7a. Signed-off-by: J. Dekker --- libavcodec/arm/hevcdsp_qpel_neon.S | 18 +- 1 file

[FFmpeg-devel] [PATCH v2 3/6] lavc/aarch64: add hevc sao edge 16x16

2021-11-16 Thread J. Dekker
Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 8 ++- libavcodec/aarch64/hevcdsp_sao_neon.S | 65 +++ 2 files changed, 71 insertions(+), 2 deletions(-) Used inline shift for ldr & escheduled uxtl/uxtl2 before zip/zip2. diff --git a/libavc

[FFmpeg-devel] [PATCH v2 4/6] lavc/aarch64: add hevc sao edge 8x8

2021-11-16 Thread J. Dekker
--bench on AWS Graviton: hevc_sao_edge_8x8_8_c: 516.0 hevc_sao_edge_8x8_8_neon: 81.0 Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 3 ++ libavcodec/aarch64/hevcdsp_sao_neon.S | 51 +++ 2 files changed, 54 insertions(+) Used inline shift for

[FFmpeg-devel] [PATCH 5/6] lavc/aarch64: add hevc sao band 8x8 tiling

2021-11-16 Thread J. Dekker
hevc_sao_band_64x64_8_c: 17635.0 hevc_sao_band_64x64_8_neon: 4875.7 Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_init_aarch64.c | 6 +- libavcodec/aarch64/hevcdsp_sao_neon.S | 9 ++--- 2 files changed, 11 insertions(+), 4 deletions(-) No change since previous patch which was ACK&#

[FFmpeg-devel] [PATCH v2 6/6] lavc/aarch64: clean-up sao band 8x8 function formatting

2021-11-16 Thread J. Dekker
Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_sao_neon.S | 195 -- 1 file changed, 90 insertions(+), 105 deletions(-) Now matches the 9,25 indentation like other ASM. diff --git a/libavcodec/aarch64/hevcdsp_sao_neon.S b/libavcodec/aarch64/hevcdsp_sao_neon.S

Re: [FFmpeg-devel] Fwd: Poll: Repeat vote: GA voters list updates

2023-11-12 Thread J. Dekker
In my eyes, the matter of how we should update the voters list was already resolved. > https://vote.ffmpeg.org/cgi-bin/civs/vote.pl?id=E_07e9c717f7820201&key=240812a0c2e373ac > This is your private URL. Do not give it to anyone else, because they could > use it to vote for you. This vote seems

Re: [FFmpeg-devel] [ANNOUNCE] Repeat vote: GA voters list updates

2023-11-12 Thread J. Dekker
On Sun, Nov 12, 2023, at 18:31, Michael Niedermayer wrote: > On Sun, Nov 12, 2023 at 11:03:21AM -0300, James Almer wrote: >> On 11/12/2023 10:59 AM, Thilo Borgmann via ffmpeg-devel wrote: >> > I will also start the repeat vote now and everybody can hold their >> > horses before going to flamewar. D

Re: [FFmpeg-devel] [ANNOUNCE] Repeat vote: GA voters list updates

2023-11-20 Thread J. Dekker
Derek Buitenhuis writes: > On 11/20/2023 3:44 PM, Thilo Borgmann via ffmpeg-devel wrote: >> the results are available at [1]. As they confirm the just updated GA list >> as >> well as the update procedure twice a year on Jan 1st & Jul 1st, I think the >> upcoming votes (extra GA members, TC/

Re: [FFmpeg-devel] [PATCH] doc/git-howto: use less weird username for git URL

2023-11-22 Thread J. Dekker
Michael Niedermayer writes: > Signed-off-by: Michael Niedermayer > --- > doc/git-howto.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Most people probably use git@ already, seems to be more common practice in general. Both users map to the same id on the server so would make s

[FFmpeg-devel] [PATCH] checkasm/hevc_deblock: add luma test

2023-12-05 Thread J. Dekker
Signed-off-by: J. Dekker --- tests/checkasm/hevc_deblock.c | 110 -- 1 file changed, 106 insertions(+), 4 deletions(-) Yes, this only supports 8bit. 10/12bit should be trivial, will add if this looks reasonable (I checked code paths using gdb, and as far as I

Re: [FFmpeg-devel] [PATCH] doc: mention that for RISC-V, we prefer .S files

2023-12-05 Thread J. Dekker
"Jean-Baptiste Kempf" writes: > $subject > > See attachment. Pushed with slight commit rewording for clarity. -- jd ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link a

Re: [FFmpeg-devel] [PATCH 00/21] aarch64: hevc: Add missing hevc_pel NEON functions

2024-03-25 Thread J. Dekker
> On Mon, 25 Mar 2024, Martin Storsjö wrote: > >> Since some time, we have pretty complete AArch64 NEON coverage >> for the hevc decoder. >> >> However, some of these functions require the I8MM instruction set >> extension, and many of them (but not all) lack a plain NEON >> version. >> >> Thi

[FFmpeg-devel] [PATCH 1/2] configure,etc: unify shebang usage

2024-03-28 Thread J. Dekker
Signed-off-by: J. Dekker --- configure | 3 ++- doc/texidep.pl| 2 +- ffbuild/libversion.sh | 1 + tests/fate-run.sh | 2 +- tests/fate.sh | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 2d46ef0b9c..d332f18e3d

[FFmpeg-devel] [PATCH 2/2] configure: simplify bigendian check

2024-03-28 Thread J. Dekker
Signed-off-by: J. Dekker --- configure | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/configure b/configure index d332f18e3d..0ff1ff0335 100755 --- a/configure +++ b/configure @@ -6108,11 +6108,7 @@ extern_prefix=${sym%%ff_extern*} check_cc pragma_deprecated

[FFmpeg-devel] [PATCH v2 1/2] configure,etc: unify shebang usage

2024-04-08 Thread J. Dekker
In some cases, these scripts can be called directly by packagers, and some systems require the interpreter to be explicit. Signed-off-by: J. Dekker --- configure | 3 ++- doc/texidep.pl| 2 +- ffbuild/libversion.sh | 1 + tests/fate-run.sh | 2 +- tests/fate.sh

[FFmpeg-devel] [PATCH v2 2/2] configure: simplify bigendian check

2024-04-08 Thread J. Dekker
fail silently. This patch changes the check to a more commonly used define for big-endian systems. More checks may need to be added in the future to cover legacy machines. Signed-off-by: J. Dekker --- configure | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/configure b

[FFmpeg-devel] [PATCH v3 1/5] configure: simplify bigendian check

2024-04-09 Thread J. Dekker
formats can fail silently. This patch changes the check to a more commonly used define for GCC style compilers. More checks may be needed to cover other potential compilers that don't use the __BYTE_ORDER__ define. Signed-off-by: J. Dekker --- configure | 6 +- 1 file changed, 1 insertion(

[FFmpeg-devel] [PATCH v3 2/5] ffbuild/libversion.sh: add shebang

2024-04-09 Thread J. Dekker
ses we add the interpreter explicitly. Signed-off-by: J. Dekker --- ffbuild/libversion.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/ffbuild/libversion.sh b/ffbuild/libversion.sh index a94ab58057..ecaa90cde6 100755 --- a/ffbuild/libversion.sh +++ b/ffbuild/libversion.sh @@ -1,3 +1,4 @@

[FFmpeg-devel] [PATCH v3 3/5] configure: switch to shebang without space

2024-04-09 Thread J. Dekker
Note that the config.sh file is left without a shebang, this file is supposed to be sourced into the current environment. This commit is purely cosmetic. Signed-off-by: J. Dekker --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

[FFmpeg-devel] [PATCH v3 4/5] tests/fate.sh: switch to shebang without space

2024-04-09 Thread J. Dekker
This commit is purely cosmetic. Signed-off-by: J. Dekker --- tests/fate-run.sh | 2 +- tests/fate.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 9863e4f2d9..6ae0320c60 100755 --- a/tests/fate-run.sh +++ b/tests/fate

[FFmpeg-devel] [PATCH v3 5/5] doc/texidep: switch to shebang without space

2024-04-09 Thread J. Dekker
This commit is purely cosmetic. Signed-off-by: J. Dekker --- doc/texidep.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/texidep.pl b/doc/texidep.pl index 099690378e..33e6c7c53e 100644 --- a/doc/texidep.pl +++ b/doc/texidep.pl @@ -1,4 +1,4 @@ -#! /usr/bin/env perl

Re: [FFmpeg-devel] [PATCH v3 3/5] configure: switch to shebang without space

2024-04-09 Thread J. Dekker
Martin Storsjö writes: > On Tue, 9 Apr 2024, J. Dekker wrote: > >> Note that the config.sh file is left without a shebang, this file is >> supposed to be sourced into the current environment. >> >> This commit is purely cosmetic. >> >> Signed-off-by:

[FFmpeg-devel] [PATCH] tests/checkasm: add exclude_guest for non-x86 linux perf

2024-04-09 Thread J. Dekker
exclude_guest is currently only supported on x86. However, not specifying 'exclude_guest' implies that you can count guest events should you run one. This creates an ABI issue whereby some non-x86 kernels require specifying exclude_guest = 1 explicitly. Signed-off-by: J. Dekker

Re: [FFmpeg-devel] [PATCH] aarch64: ac3dsp: Simplify the end of ff_ac3_sum_square_butterfly_float_neon

2024-04-09 Thread J. Dekker
Martin Storsjö writes: > Before: Cortex A53 A72 A78 > ac3_sum_square_bufferfly_float_neon: 1005.7 516.5 224.5 > After: > ac3_sum_square_bufferfly_float_neon: 981.7 504.5 223.2 > --- > libavcodec/aarch64/ac3dsp_neon.S | 16 > 1 file c

[FFmpeg-devel] [PATCH v2] tests/checkasm: add exclude_guest for non-x86 linux perf

2024-04-10 Thread J. Dekker
to 1, i.e. the only behaviour that makes sense when counting guest events isn't supported. Signed-off-by: J. Dekker --- Made commit message clearer, no functional change since v1. tests/checkasm/checkasm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/checkasm/checkasm.c b

Re: [FFmpeg-devel] [PATCH v2] tests/checkasm: add exclude_guest for non-x86 linux perf

2024-04-10 Thread J. Dekker
Martin Storsjö writes: > On Wed, 10 Apr 2024, J. Dekker wrote: > >> The exclude_guest option only has an effect on x86. Omitting >> 'exclude_guest' defaults to zero which implies that you can count guest >> events should you run one. Some non-x86 kernels ju

[FFmpeg-devel] [PATCH 1/2] avfilter/riscv: build afir only if required

2024-04-24 Thread J. Dekker
Signed-off-by: J. Dekker --- libavfilter/riscv/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/riscv/Makefile b/libavfilter/riscv/Makefile index 0b968a9c0d..277dde2aed 100644 --- a/libavfilter/riscv/Makefile +++ b/libavfilter/riscv/Makefile @@ -1,2

[FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths

2024-04-24 Thread J. Dekker
Signed-off-by: J. Dekker --- tests/checkasm/h264dsp.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c index 0f484e3f43..5cb646ae49 100644 --- a/tests/checkasm/h264dsp.c +++ b/tests/checkasm/h264dsp.c @@ -173,6 +173,7

Re: [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths

2024-05-14 Thread J. Dekker
Devin Heitmueller writes: > On Wed, Apr 24, 2024 at 10:10 AM J. Dekker wrote: >> >> Signed-off-by: J. Dekker >> --- >> tests/checkasm/h264dsp.c | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/tests/checkasm/

Re: [FFmpeg-devel] [PATCH] web: add a news entry about STF sponsorship

2024-05-14 Thread J. Dekker
Thilo Borgmann via ffmpeg-devel writes: > --- > This text including the link is also meant to be published via our socal > media. > > src/index | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/index b/src/index > index d035ffa..83cc9bf 100644 > --- a/src/index > +++ b/src/

[FFmpeg-devel] [PATCH 1/2] avdevice: deprecate opengl outdev

2024-02-12 Thread J. Dekker
Signed-off-by: J. Dekker --- These devices are fundamentally broken and usecases should be switched away from output devices in general. Discussion in the thread tended towards deprecation rather than immediate removal to give time for users to figure out the best alternatives for their usecase

[FFmpeg-devel] [PATCH 2/2] avdevice: deprecate sdl outdev

2024-02-12 Thread J. Dekker
Signed-off-by: J. Dekker --- libavdevice/sdl2.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavdevice/sdl2.c b/libavdevice/sdl2.c index 342a253dc0..6a6751e40f 100644 --- a/libavdevice/sdl2.c +++ b/libavdevice/sdl2.c @@ -51,6 +51,7 @@ typedef struct { SDL_Rect texture_rect

[FFmpeg-devel] [PATCH 1/3] checkasm/hevc_deblock: add luma and chroma full

2024-02-21 Thread J. Dekker
Signed-off-by: J. Dekker --- tests/checkasm/hevc_deblock.c | 246 +- 1 file changed, 215 insertions(+), 31 deletions(-) diff --git a/tests/checkasm/hevc_deblock.c b/tests/checkasm/hevc_deblock.c index 66fc8d5646..91e57f5cf5 100644 --- a/tests/checkasm

[FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock

2024-02-21 Thread J. Dekker
Over/underflow in some cases. Signed-off-by: J. Dekker --- libavcodec/x86/hevcdsp_init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c index 31e81eb11f..11cb1b3bfd 100644 --- a/libavcodec/x86

[FFmpeg-devel] [PATCH 3/3] avcodec/aarch64: add hevc deblock NEON

2024-02-21 Thread J. Dekker
Benched using single-threaded full decode on an Ampere Altra. Bpp Before After Speedup 8 73,3s 65,2s 1.124x 10 114,2s 104,0s 1.098x 12 125,8s 115,7s 1.087x Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_deblock_neon.S | 421 ++ libavcodec/aarch64

[FFmpeg-devel] [PATCH v2 1/2] avdevice: deprecate opengl outdev

2024-02-21 Thread J. Dekker
Signed-off-by: J. Dekker --- doc/outdevs.texi| 2 +- libavdevice/opengl_enc.c| 11 +++ libavdevice/version_major.h | 2 ++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/doc/outdevs.texi b/doc/outdevs.texi index f0484bbf8f..941429a8c8 100644 --- a/doc

[FFmpeg-devel] [PATCH v2 2/2] avdevice: deprecate sdl outdev

2024-02-21 Thread J. Dekker
Signed-off-by: J. Dekker --- doc/outdevs.texi| 8 +++- libavdevice/sdl2.c | 10 ++ libavdevice/version_major.h | 2 ++ 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/doc/outdevs.texi b/doc/outdevs.texi index 941429a8c8..9ee857528e 100644 --- a

[FFmpeg-devel] [PATCH v2 1/3] checkasm/hevc_deblock: add luma and chroma full

2024-02-22 Thread J. Dekker
Signed-off-by: J. Dekker --- tests/checkasm/hevc_deblock.c | 246 +- 1 file changed, 215 insertions(+), 31 deletions(-) diff --git a/tests/checkasm/hevc_deblock.c b/tests/checkasm/hevc_deblock.c index 66fc8d5646..91e57f5cf5 100644 --- a/tests/checkasm

[FFmpeg-devel] [PATCH v2 2/3] avcodec/x86: disable hevc 12b luma deblock

2024-02-22 Thread J. Dekker
Over/underflow in some cases. Signed-off-by: J. Dekker --- libavcodec/x86/hevcdsp_init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c index f5bc342cd5..8831ba957a 100644 --- a/libavcodec/x86

[FFmpeg-devel] [PATCH v2 3/3] avcodec/aarch64: add hevc deblock NEON

2024-02-22 Thread J. Dekker
Benched using single-threaded full decode on an Ampere Altra. Bpp Before After Speedup 8 73,3s 65,2s 1.124x 10 114,2s 104,0s 1.098x 12 125,8s 115,7s 1.087x Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_deblock_neon.S | 421 ++ libavcodec/aarch64

Re: [FFmpeg-devel] [GASPP PATCH] Don't mangle .L local labels for ELF targets

2024-02-22 Thread J. Dekker
Martin Storsjö writes: > This fixes building FFmpeg's libavcodec/aarch64/h264idct_neon.S > for a Linux target. (It's not necessary to use gas-preprocessor for > such a target for a very long time, but it can be useful to be able > to test gas-preprocessor there still.) > --- > gas-preprocessor.p

[FFmpeg-devel] [REFUND-REQUEST] FOSDEM 2024

2024-02-23 Thread J. Dekker
Hi, I attended FOSDEM for ffmpeg and would like to request travel reimbursement. Flight | 162,46 EUR === Total | 162,46 EUR -- jd ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To u

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock

2024-02-24 Thread J. Dekker
Nuo Mi writes: > On Wed, Feb 21, 2024 at 7:10 PM J. Dekker wrote: > >> Over/underflow in some cases. >> >> Signed-off-by: J. Dekker >> --- >> libavcodec/x86/hevcdsp_init.c | 9 + >> 1 file changed, 5 insertions(+), 4 deletions(-) >>

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock

2024-02-24 Thread J. Dekker
Andreas Rheinhardt writes: > J. Dekker: >> SAO_BAND_INIT(12, sse2); >> SAO_EDGE_INIT(12, sse2); >> > > If you disable them here, you should also ensure that they are not > assembled at all. > > - Andreas Sure, will do on push

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock

2024-02-24 Thread J. Dekker
Martin Storsjö writes: > [...] > > Are you sure the input is within valid range? It's always possible that > checkasm produces inputs that the real decoder wouldn't - but it's also > possible that this is a real decoder bug that just hasn't been triggered by > any > other test yet. > > // Martin

[FFmpeg-devel] [PATCH] avcodec/x86/hevc: fix luma 12b overflow

2024-02-25 Thread J. Dekker
Weak filter can overflow in delta0 calculation before >> 4 in int16. Signed-off-by: J. Dekker --- I do not know x86 simd at all, so this is just an attempt to fix the implementation rather than write extremely performant code. Suggestions welcome. libavcodec/x86/hevc_deblock.as

Re: [FFmpeg-devel] [PATCH] avcodec/x86/hevc: fix luma 12b overflow

2024-02-26 Thread J. Dekker
"Ronald S. Bultje" writes: > > New version attached. > Thanks for the help, pushed this along with the test. -- jd ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link abov

Re: [FFmpeg-devel] [PATCH v2 1/3] checkasm/hevc_deblock: add luma and chroma full

2024-02-26 Thread J. Dekker
"J. Dekker" writes: > Signed-off-by: J. Dekker > --- > tests/checkasm/hevc_deblock.c | 246 +- > 1 file changed, 215 insertions(+), 31 deletions(-) Pushed this along with Ronald's patch to fix x86. Have some minor improvements

[FFmpeg-devel] [PATCH v4] avcodec/aarch64/hevc: add luma deblock NEON

2024-02-27 Thread J. Dekker
Benched using single-threaded full decode on an Ampere Altra. Bpp Before After Speedup 8 73,3s 65,2s 1.124x 10 114,2s 104,0s 1.098x 12 125,8s 115,7s 1.087x Signed-off-by: J. Dekker --- Slightly improved 12bit version. libavcodec/aarch64/hevcdsp_deblock_neon.S | 417

Re: [FFmpeg-devel] [PATCH v4] avcodec/aarch64/hevc: add luma deblock NEON

2024-02-28 Thread J. Dekker
Martin Storsjö writes: > On Tue, 27 Feb 2024, J. Dekker wrote: > >> Benched using single-threaded full decode on an Ampere Altra. >> >> Bpp Before After Speedup >> 8 73,3s 65,2s 1.124x >> 10 114,2s 104,0s 1.098x >> 12 125,8s 11

Re: [FFmpeg-devel] [PATCH v4] avcodec/aarch64/hevc: add luma deblock NEON

2024-02-28 Thread J. Dekker
Martin Storsjö writes: > On Wed, 28 Feb 2024, J. Dekker wrote: > >> >> Martin Storsjö writes: >> >>> On Tue, 27 Feb 2024, J. Dekker wrote: >>> >>>> Benched using single-threaded full decode on an Ampere Altra. >>>> >>>

Re: [FFmpeg-devel] [PATCH v4] avcodec/aarch64/hevc: add luma deblock NEON

2024-02-28 Thread J. Dekker
Martin Storsjö writes: > On Wed, 28 Feb 2024, J. Dekker wrote: > >> >> Martin Storsjö writes: >> >>> On Wed, 28 Feb 2024, J. Dekker wrote: >>> >>>> >>>> Martin Storsjö writes: >>>> >>>>> On Tue, 27 F

Re: [FFmpeg-devel] [PATCH v2 1/2] avdevice: deprecate opengl outdev

2024-02-28 Thread J. Dekker
Anton Khirnov writes: > Quoting Lynne (2024-02-21 13:32:19) >> Feb 21, 2024, 12:34 by j...@itanimul.li: >> >> > Signed-off-by: J. Dekker >> > --- >> > doc/outdevs.texi| 2 +- >> > libavdevice/opengl_enc.c| 11 ++

[FFmpeg-devel] [PATCH 1/2] MAINTAINERS: remove inactive developer

2024-02-28 Thread J. Dekker
Inactive since 2007. Signed-off-by: J. Dekker --- MAINTAINERS | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index cc7f564f48..ace58f02a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -148,7 +148,6 @@ Codecs: cinepak.c

[FFmpeg-devel] [PATCH 2/2] avcodec: remove sonic lossy/lossless audio

2024-02-28 Thread J. Dekker
This was an experimental/research codec of which ffmpeg is the only encoder and decoder, development has stalled and these files don't exist in the wild. Signed-off-by: J. Dekker --- Changelog |1 + configure |3 - libavcodec/Makefile |3 - libav

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove sonic lossy/lossless audio

2024-02-28 Thread J. Dekker
Michael Niedermayer writes: > [[PGP Signed Part:Undecided]] > On Wed, Feb 28, 2024 at 01:56:10PM +0100, J. Dekker wrote: >> This was an experimental/research codec of which ffmpeg is the only >> encoder and decoder, > > >> development has stalled > > Thats n

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: remove sonic lossy/lossless audio

2024-02-28 Thread J. Dekker
Vittorio Giovara writes: > On Wed, Feb 28, 2024 at 2:38 PM J. Dekker wrote: > >> >> Michael Niedermayer writes: >> >> > [[PGP Signed Part:Undecided]] >> > On Wed, Feb 28, 2024 at 01:56:10PM +0100, J. Dekker wrote: >> >> This was an e

[FFmpeg-devel] [PATCH] avcodec: deprecate sonic

2024-02-29 Thread J. Dekker
e the encoders by default in configure, the decoders should be disabled by default next bump. Signed-off-by: J. Dekker --- Since this codec was added in 2004, there has only been one major non-maintenance, non-bugfix commit in 2013 (6026a5ad4f). That's 1 out of 107 total commits touching this fi

Re: [FFmpeg-devel] [ infra] Does main server hang?

2024-02-29 Thread J. Dekker
On Thu, Feb 29, 2024, at 16:27, Zhao Zhili wrote: > Hi, I can't pull from main developer git server. Patchwork is slow to loading. > I have tried two ISP. Anything happened? All seem okay for me. -- jd ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH 1/4] aarch64: Fix ff_hevc_put_hevc_epel_h48_8_neon_i8mm

2024-03-14 Thread J. Dekker
Martin Storsjö writes: > The first 32 elements of each row were correct, while the > last 16 were scrambled. > > This hasn't been noticed, because the checkasm test erroneously > only checked half of the output (for 8 bit functions), and > apparently none of the samples as part of "fate-hevc" se

[FFmpeg-devel] [PATCH v3] lavc/aarch64: add hevc horizontal qpel/uni/bi

2022-10-11 Thread J. Dekker
: 42958.7 put_hevc_qpel_uni_h64_8_neon: 8366.5 Signed-off-by: J. Dekker --- Summary of changes since last iteration: - Interleaved stores - Changed tiling to loop more naturally - Increased code reuse (.text reduction by ~60%) - Simplified function variations through .req libavcodec/aarch64

Re: [FFmpeg-devel] [PATCH] avcodec/svq1enc: Workaround GCC bug 102513

2022-10-25 Thread J. Dekker
On 25 Oct 2022, at 14:48, Andreas Rheinhardt wrote: > GCC 11 has a bug: When it creates clones of recursive functions > (to inline some parameters), it clones a recursive function > eight times by default, even when this exceeds the recursion > depth. This happens with encode_block() in libavcodec

Re: [FFmpeg-devel] [PATCH v3] lavc/aarch64: add hevc horizontal qpel/uni/bi

2022-10-25 Thread J. Dekker
On 24 Oct 2022, at 14:01, Martin Storsjö wrote: > On Tue, 11 Oct 2022, J. Dekker wrote: > >> [...] >> diff --git a/libavcodec/aarch64/hevcdsp_init_aarch64.c >> b/libavcodec/aarch64/hevcdsp_init_aarch64.c >> index 644cc17715..44399b05d8 100644 >> --- a/libav

[FFmpeg-devel] [PATCH v2] avcodec/riscv: add h264 dc idct rvv

2024-07-03 Thread J. Dekker
4: 1.2 h264_idct8_add_dc_12bpp_c: 4.2 h264_idct8_add_dc_12bpp_rvv_i64: 1.2 h264_idct8_add_dc_14bpp_c: 4.2 h264_idct8_add_dc_14bpp_rvv_i64: 1.2 Signed-off-by: J. Dekker --- rdcycle always returns 0 on my board, clock_gettime() seems as noisy as rdtime (just with bigger numbers). libavcodec/riscv/Makefile

[FFmpeg-devel] [PATCH v3] avcodec/riscv: add h264 dc idct rvv

2024-07-14 Thread J. Dekker
4: 1.2 h264_idct8_add_dc_12bpp_c: 4.2 h264_idct8_add_dc_12bpp_rvv_i64: 1.2 h264_idct8_add_dc_14bpp_c: 4.2 h264_idct8_add_dc_14bpp_rvv_i64: 1.2 Signed-off-by: J. Dekker --- libavcodec/riscv/Makefile | 1 + libavcodec/riscv/h264dsp_init.c | 44 ++- libavcodec/riscv/h264dsp_rvv.S

[FFmpeg-devel] [PATCH 1/7] checkasm: add csv/tsv bench output

2024-08-13 Thread J. Dekker
When collecting performance information from checkasm it is common to parse the output for use in graphs to compare vs different architectures. Signed-off-by: J. Dekker --- tests/checkasm/checkasm.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a

[FFmpeg-devel] [PATCH 2/7] checkasm: improve print format

2024-08-13 Thread J. Dekker
Port dav1d's checkasm output format to FFmpeg's checkasm, includes relative speedups and aligns results. Signed-off-by: J. Dekker --- tests/checkasm/checkasm.c | 53 +++ 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/tests/checkasm/

[FFmpeg-devel] [PATCH 3/7] checkasm: add wildcompares for test & functions

2024-08-13 Thread J. Dekker
:1471.5 ( 1.71x) yuva420p_bgr24_1920_c:4462.6 ( 1.00x) yuva420p_bgr24_1920_ssse3:2331.1 ( 1.91x) [...] Ported from dav1d. Signed-off-by: J. Dekker --- tests/checkasm/checkasm.c | 37

[FFmpeg-devel] [PATCH 4/7] avutil/riscv/asm: add stack pushing helpers

2024-08-13 Thread J. Dekker
From: Niklas Haas Instead of duplicating these common macros in every file, add them to the shared utility file. Also add a base case for sanity. --- libavcodec/riscv/h264addpx_rvv.S | 10 -- libavcodec/riscv/h264idct_rvv.S | 10 -- libavcodec/riscv/startcode_rvb.S | 10

[FFmpeg-devel] [PATCH 5/7] avutil/riscv/asm: add helper macro to count varargs

2024-08-13 Thread J. Dekker
From: Niklas Haas (Ab)using nested macros to get the number of arguments passed to a variadic macro. Useful for stack manipulation. --- libavutil/riscv/asm.S | 17 + 1 file changed, 17 insertions(+) diff --git a/libavutil/riscv/asm.S b/libavutil/riscv/asm.S index 175f2a8672..db1

[FFmpeg-devel] [PATCH 7/7] avcodec/riscv: add h264 qpel

2024-08-13 Thread J. Dekker
6.57x) Signed-off-by: Niklas Haas Signed-off-by: J. Dekker --- libavcodec/h264qpel.c| 2 + libavcodec/h264qpel.h| 1 + libavcodec/riscv/Makefile| 2 + libavcodec/riscv/h264qpel_init.c | 113 +++ libavcodec/riscv/h264qpel_rvv.S

[FFmpeg-devel] [PATCH 6/7] avutil/riscv/asm: add generic push/pop helpers

2024-08-13 Thread J. Dekker
From: Niklas Haas Generic helper macros to push/pop multiple registers at once. Expands to a single `addi` plus a sequence of XLEN-sized stores/loads. --- libavutil/riscv/asm.S | 37 + 1 file changed, 37 insertions(+) diff --git a/libavutil/riscv/asm.S b/liba

Re: [FFmpeg-devel] [PATCH 2/7] checkasm: improve print format

2024-08-16 Thread J. Dekker
Lynne via ffmpeg-devel writes: > On 13/08/2024 16:03, J. Dekker wrote: >> Port dav1d's checkasm output format to FFmpeg's checkasm, includes >> relative speedups and aligns results. >> Signed-off-by: J. Dekker >> --

Re: [FFmpeg-devel] [PATCH 6/7] avutil/riscv/asm: add generic push/pop helpers

2024-08-16 Thread J. Dekker
Rémi Denis-Courmont writes: > Le 13 août 2024 17:03:35 GMT+03:00, "J. Dekker" a écrit : >>From: Niklas Haas >> >>Generic helper macros to push/pop multiple registers at once. Expands to >>a single `addi` plus a sequence of XLEN-sized stores/loads

Re: [FFmpeg-devel] [PATCH 1/7] checkasm: add csv/tsv bench output

2024-08-16 Thread J. Dekker
On Fri, Aug 16, 2024, at 13:03, Anton Khirnov wrote: > Quoting J. Dekker (2024-08-13 16:03:30) >> When collecting performance information from checkasm it is common >> to parse the output for use in graphs to compare vs different >> architectures. >> >> Signed-of

[FFmpeg-devel] [PATCH v2 1/4] checkasm: add csv/tsv bench output

2024-08-21 Thread J. Dekker
When collecting performance information from checkasm it is common to parse the output for use in graphs to compare vs different architectures. Signed-off-by: J. Dekker --- tests/checkasm/checkasm.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a

[FFmpeg-devel] [PATCH v2 2/4] checkasm: print only results to stdout

2024-08-21 Thread J. Dekker
Signed-off-by: J. Dekker --- tests/checkasm/checkasm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index d9b5c94faa..c5c1eeb07a 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -775,7

[FFmpeg-devel] [PATCH v2 3/4] checkasm: improve print format

2024-08-21 Thread J. Dekker
Port dav1d's checkasm output format to FFmpeg's checkasm, includes relative speedups and aligns results. Signed-off-by: J. Dekker --- tests/checkasm/checkasm.c | 53 +++ 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/tests/checkasm/

  1   2   >