Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

gt;signal_loss_action = SIGNAL_LOSS_NONE" Even though the option is deprecated, it should still continue to work until it is completely removed. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC/CC elections

t out a few hours ago, to tell everyone the first vote is being thrown away (without revealing the voting results), and give everyone the opportunity to vote again now that it's been made clear how the weighting works. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communicati

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

On Tue, Nov 28, 2023 at 4:22 AM Michael Riedl wrote: > > Ping My apologies, I saw your remarks that this didn't change backward compatibility but failed to reply. I have no further issues with this patch. Thanks, Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Com

Re: [FFmpeg-devel] There may be a bug for .mp4 reader.

50. Libavcodec doesn’t have any support for delivering individual fields. Decoders are expected to reassemble fields into frames before providing them back to callers. Presumably this is some sort of PAFF encoded stream? Does it decode properly when using the software h.264 decoder?

Re: [FFmpeg-devel] Using copyts with mpegts output fails after 26, 5 hours

having TS streams longer than 26.5 hours and expecting seeking to work properly seem like they are not compatible concepts. Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: fix checking video mode in SDK version 11

we don’t know what the effects are on other cards. Regards, Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

Hello Paul, On Fri, May 17, 2019 at 4:44 AM Paul B Mahol wrote: > > On 5/17/19, Mathieu Duponchelle wrote: > > There isn't one, as I said the added indentation is because of the new loop! > > To get this committed to tree you need to comply to review requests. I think Mathieu's point is that th

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

Hello Phillip, On Thu, May 16, 2019 at 9:32 AM Phillip Burr wrote: > > Minimal support for ATSC PSIP tables. Does not support STT or > EIT tables and so is not compliant with terrestrial ATSC. > ATSC tables are not created by default, and will only be transmitted > if either "atsc_name" or "atsc

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

On Mon, May 20, 2019 at 8:36 AM Phil Burr wrote: > > Thank you for the feedback. I will look into adding documentation for the > atsc metadata. ATSC requires in addition to the tables I've added, the STT > and EIT0-EIT3 tables. I'm thinking of adding support for STT and at least > producing emp

Re: [FFmpeg-devel] [PATCH v4] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

On Wed, Jul 3, 2019 at 9:34 AM Romane Lafon wrote: > > I've added documentation for the extension of aphasemeter filter. > Also, I'm not sure that "phasing" is the right word to describe the > detection. In some commercial analyzers I've also seen audio phase presented using the term "lissajous"

Re: [FFmpeg-devel] [PATCH]Support for Frame Doubling/ Tripling in FFMPEG's HEVC Decoder by parsing the picture_struct SEI value (Support for http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.h

HEVC encoder I’ve seen which puts out modes 11/12 and hence that would be useful as well. I suspect supporting that would be a relatively small incremental step from making modes 1/2 work. Reach out to me privately if anybody is interested in doing such a project. De

Re: [FFmpeg-devel] [CALL] New FFmpeg developers meeting

On Sat, Aug 17, 2019 at 4:18 PM James Almer wrote: > Start by drafting a list of subjects to discuss, and proposing a date > (at least two weeks from now) or asking for suggestions. Then wait to > see how many developers agree with it and confirm they will be there. Indeed, having some form of go

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: adjust for timecode lag

> A couple of follow-up Qs: > > Is auto-detection available for all Decklink devices? No, but AFAIK it is for all devices which support SDI. Generally it's the older analog capture devices which don't support it. > For those for which it is available, are there any edge cases in which > it sets

[FFmpeg-devel] [PATCH] Support 64-bit integers for av_get_frame_filename2()

s -vsync 0 -i foo.ts -frame_pts 1 -enc_time_base -1 foo_%d.png Signed-off-by: Devin Heitmueller --- libavformat/avformat.h | 2 ++ libavformat/img2enc.c | 2 +- libavformat/utils.c| 9 +++-- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/libavformat/avformat.h b/l

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

Hello Vittorio, Thanks for the feedback. > > I think you should add an entry in ff_decode_frame_props() so that pkt side > data can propagate to frame side data > -- > Vittorio I’ve got a whole patch series related to capture of AFD from decklink and getting it through the pipeline (to be e

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

> On Aug 26, 2018, at 11:34 AM, Marton Balint wrote: > > Hello Marton, Ok, I’ll take another pass and send an updated patch. Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing li

[FFmpeg-devel] [PATCH 0/5] Support for Decklink output of EIA-708 and AFD

would bail out if there was a problem with any VANC data, even if all the other VANC data was perfectly valid). Devin Heitmueller (5): v210enc: Pass through A53 CC data libavdevice/decklink: Add support for EIA-708 output over SDI Allow AFD data to be embedded in AVPacket v210enc: Pass th

[FFmpeg-devel] [PATCH 1/5] v210enc: Pass through A53 CC data

When encoding to V210, make sure the CC side data makes it through in the resulting AVPacket. This is needed so the decklink output module can put out captions when in 10-bit mode. Signed-off-by: Devin Heitmueller --- libavcodec/v210enc.c | 9 + 1 file changed, 9 insertions(+) diff

[FFmpeg-devel] [PATCH 3/5] Allow AFD data to be embedded in AVPacket

Create a new AVPacket side data type for Active Format Description, which mirrors the side data type found in AVFrame. The primary use case for this is ensuring AFD gets preserved in the V210 encoder, so that the decklink libavdevice can output AFD. Signed-off-by: Devin Heitmueller

[FFmpeg-devel] [PATCH 2/5] libavdevice/decklink: Add support for EIA-708 output over SDI

: https://github.com/stoth68000/libklvanc Updated to reflect feedback from Marton Balint , Carl Eugen Hoyos , Aaron Levinson , and Moritz Barsnick Signed-off-by: Devin Heitmueller --- configure | 4 + libavdevice/decklink_common.cpp | 16 +++- libavdevice/decklink_common.h

[FFmpeg-devel] [PATCH 5/5] decklink: Add support for output of Active Format Description (AFD)

Implement support for including AFD in decklink output when putting out 10-bit VANC data. Updated to reflect feedback from Marton Balint , Carl Eugen Hoyos and Aaron Levinson . Signed-off-by: Devin Heitmueller --- libavdevice/decklink_enc.cpp | 54

[FFmpeg-devel] [PATCH 4/5] v210enc: Pass through Active Format Description (AFD) data

When encoding to V210, make sure the AFD side data makes it through in the resulting AVPacket. This is needed so the decklink output module can put out AFD when in 10-bit mode. Signed-off-by: Devin Heitmueller --- libavcodec/v210enc.c | 8 1 file changed, 8 insertions(+) diff --git a

Re: [FFmpeg-devel] [PATCH 0/5] Support for Decklink output of EIA-708 and AFD

On Sun, Sep 9, 2018 at 4:59 PM, Marton Balint wrote: > Thanks, I applied patches 1-4. > >> decklink: Add support for output of Active Format Description (AFD) > > > Regarding this one, I noticed you always set the AFD in line 12. Are you > sure that it is OK to use line 12 for all resolutions?

Re: [FFmpeg-devel] [PATCH 0/5] Support for Decklink output of EIA-708 and AFD

Hi James, > Shouldn't this new packet side data be handled in libavcodec/decode.c > ff_decode_frame_props() as well? I have a patch which does this as part of a patch series which adds AFD parsing to decklink capture, ensures it gets preserved in ff_decode_frame_props, and encodes the resulting A

Re: [FFmpeg-devel] [PATCH 0/5] Support for Decklink output of EIA-708 and AFD

On Mon, Sep 10, 2018 at 8:00 PM, Marton Balint wrote: > Yes, just put the same value to both line 12 (or whichever line the user > selects) and its pair line in the other field. Ok, will take care of this today. Thanks for reviewing. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kern

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Add option to align Capture start time

multimedia filter or a BSF). Does anyone else have an suggestions as to a better place to do this? Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Add option to align Capture start time

to that and it seems like a good bit more trouble than it’s worth. I withdrawal any objections I had to the original patch. Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec: libdav1d AV1 decoder wrapper

On Sat, Sep 29, 2018 at 6:04 AM Rostislav Pehlivanov wrote: > I'd much rather go with the original intent which was to merge the decoder > into lavc. Ronald can correct me if I'm wrong, but I suspect a key goal behind the decoder was to have a standalone library which could be shared across a var

Re: [FFmpeg-devel] [PATCH 2/3] lavf/timecode: document SMPTE struct

> On Oct 9, 2018, at 4:07 PM, Carl Eugen Hoyos wrote: > > 2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com : >> From: Devin Heitmueller >> >> There are a number of different binary representations in which >> SMPTE timecodes can use. Make clear that th

Re: [FFmpeg-devel] [PATCH 1/3] lavc/h264: create AVFrame side data from H.264 timecodes

> On Oct 9, 2018, at 4:02 PM, Carl Eugen Hoyos wrote: > > 2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com : >> From: Devin Heitmueller >> >> Create SMPTE ST 12-1 timecodes based on H.264 SEI picture timing >> info. >> >> For framerates > 30

[FFmpeg-devel] [PATCH] decklink: Fix compile breakage on OSX

Make the function static, or else Clang complains with: error: no previous prototype for function 'decklink_get_attr_string' [-Werror,-Wmissing-prototypes] Signed-off-by: Devin Heitmueller --- libavdevice/decklink_common.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [FFmpeg-devel] [PATCH]lavc/mpeg12dec: Read Closed Captions from second field

On Thu, Nov 29, 2018 at 12:55 PM Michael Niedermayer wrote: > > +if (s1->a53_caption) { > > +AVFrameSideData *sd; > > +av_frame_remove_side_data(s->current_picture_ptr->f, > > AV_FRAME_DATA_A53_CC); > > +sd = av_frame_new_side_data( > > +

Re: [FFmpeg-devel] [PATCH] pthread_frame: attempt to get frame to reduce latency

On Wed, Mar 11, 2020 at 10:28 AM Derek Buitenhuis wrote: > > E.g. in FF_THREAD_FRAME 4320x2160 30fps video streaming, 4 threads, the > > frame caching is 99ms (33ms x 3frames) > > If the cpu-decoding-execution-time is 80ms ~ 120ms (dependent on video > > frame content). > > Also aside: It is no

[FFmpeg-devel] Test message

Please ignore -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH] lavdevice: Add VideoToolbox output device.

While not yet upstream, my version of the decklink output module provides a single avdevice that supports multiple formats, including AC-3 for passthrough. https://github.com/LTNGlobal-opensource/FFmpeg-ltn/blob/lted1/libavdevice/decklink_enc.cpp Devin -- Devin Heitmueller, Senior

Re: [FFmpeg-devel] [PATCH 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

goto error; > } > > if (ost->source_index >= 0) In general do we really think this is a safe thing to do? Does something also need to be propagated to the output as well? I know that this would break use cases like the decklink output where the frame resolution

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

+if (ctx->output_klv) { > > +st = avformat_new_stream(avctx, NULL); > > +if (!st) { > > +av_log(avctx, AV_LOG_ERROR, "Cannot add KLV stream\n"); > > Lose the error message for ENOMEM. > > > +ret = AVERROR(ENOMEM); > > +

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

Hello Michael, > On Sep 20, 2019, at 12:10 PM, Michael Niedermayer > wrote: > > On Fri, Sep 20, 2019 at 11:55:17PM +0800, lance.lmw...@gmail.com wrote: >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavcodec/v210_template.c | 20 >> libavcodec/v210enc.c

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

> On Sep 21, 2019, at 4:44 PM, Michael Niedermayer > wrote: > >> The patch just expands 4:2:0 to 4:2:2 while properly supporting interlaced >> chroma. > > 4:2:0 and 4:2:2 have a chroma plane with different resolution. > converting between planes of different resolution is what i called scal

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

On Mon, Jan 14, 2019 at 3:31 AM Michael Niedermayer wrote: > Thus a new function should be added which does all this, and that then > be used For what it's worth, the fix is actually incorrect both here and in vf_vps. When doubling the framerate, the correct behavior is to split the content acro

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

> > In short, a centralized function would be good, but we probably need > > to think through what the API looks like so we don't have to introduce > > a new API in libavutil and then deprecate it once we want to make the > > splitting/combining logic work according to the spec. > > I fear that no

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

On Mon, Jan 14, 2019 at 12:45 PM Michael Niedermayer wrote: > well, there are other types of side data too. for example motion > vectors would need to be updated on crop depending on which rectangle > is croped out Ah, yes, of course. I thought we were just discussing captions. So are you propo

Re: [FFmpeg-devel] Decklink Output Problem

king anything else. Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

On Tue, Feb 5, 2019 at 6:29 AM Carl Eugen Hoyos wrote: > How would this be better than printing a warning if the feature > could not be enabled as it is already done in some situations? In most systems I've worked with, if I say "enable something" and it cannot be enabled I want the ./configure t

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

7;); > +put_bits(&s->pb, 8, '4'); > +put_bits(&s->pb, 8, 3); // > user_data_type_code > +put_bits(&s->pb, 8, > +((side_data->size / 3) & 0x1f) | 0x40); // flags, > cc_count > +

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

> On Feb 7, 2019, at 1:22 PM, Mathieu Duponchelle > wrote: > > > > On 2/7/19 7:21 PM, Devin Heitmueller wrote: >> Isn’t this calculation incorrect? The max cc_count possible is 31 (0x1F), >> hence the max size should be 93. >> > > True that, upda

Re: [FFmpeg-devel] [PATCH v4] mpeg12enc: Use Closed Captions if available

quick length check is reasonable to avoid a possible buffer overflow, so I would just write a log message and throw the entire array on the floor. Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

> It would be better to test against a decoder from a unrelated codebase > Otherwise its a bit like testing your new language skills by talking with > yourself. It should be pretty easy to just play the resulting TS in VLC and confirm the captions are present and play correctly. Devin -- Devin

Re: [FFmpeg-devel] AVPixelFormat for YUYV 10 bit.

we use it regularly with the Blackmagic cards (i.e. you can look at libavdevice/decklink_enc.cpp, decklink_dec.cpp for usage). Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH] Add A53 Closed Captions to MPEG header if they are available.

Hello Marton, On Tue, Jun 6, 2017 at 5:45 PM, Marton Balint wrote: > As far as I remember multiple side data of the same type is not something we > wanted to support. Why do you need it? Can't a single AV_FRAME_DATA_A53_CC > side data packet contain many CC entries? Could you please expand on w

[FFmpeg-devel] [PATCHv2 0/2] Add support for EIA-708/AFD on decklink output

This patch series hooks in the libklvanc library to provide support of output for EIA-708 and AFD packets over SDI output. Patch 1 reflects feedback from Marton Balint Devin Heitmueller (2): libavdevice/decklink: Add support for EIA-708 output over SDI decklink: Add support for output of

[FFmpeg-devel] [PATCH 1/2] libavdevice/decklink: Add support for EIA-708 output over SDI

: https://github.com/stoth68000/libklvanc Updated to reflect feedback from Marton Balint Signed-off-by: Devin Heitmueller --- configure | 4 ++ libavcodec/v210enc.c| 12 libavdevice/decklink_common.cpp | 17 +++-- libavdevice/decklink_common.h | 10

[FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

Implement support for including AFD in decklink output. This includes making sure the AFD data is preserved when going from an AVFrame to a V210 packet (needed for 10-bit support). Signed-off-by: Devin Heitmueller --- libavcodec/avcodec.h | 6 ++ libavcodec/v210enc.c | 11

[FFmpeg-devel] [RFC PATCH 0/6] Decklink capture VANC improvements and AFD in libx264

Format Description if present as side-data. This was needed in order to capture AFD on the decklink interface and have it end up in the final TS (assuming an encoding use case). Devin Heitmueller (6): decklink: Fix case where return value wasn't being set before checked for errors dec

[FFmpeg-devel] [PATCH 1/6] decklink: Fix case where return value wasn't being set before checked for errors

I missed an assignement which cauesd the error case to not ever be properly checked. Signed-off-by: Devin Heitmueller --- libavdevice/decklink_enc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp index 070bfad

[FFmpeg-devel] [PATCH 3/6] Preserve AFD side data when going from AVPacket to AVFrame

This is needed to ensure that AFD data continues to work when capturing V210 video with the Decklink libavdevice input. Signed-off-by: Devin Heitmueller --- libavcodec/decode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index a7f1e23..e981651

[FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

use case where multi-channel audio can be captured (i.e. 7.1), we introduced a new configuration option, which defaults to the existing behavior. Signed-off-by: Devin Heitmueller --- libavdevice/decklink_common.cpp | 9 +++ libavdevice/decklink_common.h | 8 ++- libavdevice

[FFmpeg-devel] [PATCH 6/6] decklink: Add support for SCTE-104 to decklink capture

citly enabled by the user through the "-enable_scte_104" option, since we cannot autodetect the presence of SCTE-104 (because unlike with 708/AFD messages are not set except when trigger occurs, thus the stream wouldn't get created during the read_header phase). Signed-off-b

[FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

Make use of libklvanc from within the decklink capture module, initially for EIA-708 and AFD. Support for other VANC types will come in subsequent patches. Signed-off-by: Devin Heitmueller --- libavdevice/decklink_dec.cpp | 135 +++ 1 file changed, 135

[FFmpeg-devel] [PATCH 4/6] Support encoding of Active Format Description (AFD) in libx264

types (i.e. videotoolbox, etc). Signed-off-by: Devin Heitmueller --- libavcodec/internal.h | 3 +++ libavcodec/libx264.c | 38 ++ libavcodec/utils.c| 36 3 files changed, 73 insertions(+), 4 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

> On Nov 16, 2017, at 7:22 PM, Derek Buitenhuis > wrote: > > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: >> +uint8_t *audio_in = ((uint8_t *) audioFrameBytes) + >> audio_offset; >> +for (int x = 0; x < pkt.size; x += sample

Re: [FFmpeg-devel] [PATCH 4/6] Support encoding of Active Format Description (AFD) in libx264

Hello Derek, Thanks for taking the time to review these patches. Comments below. > On Nov 16, 2017, at 7:20 PM, Derek Buitenhuis > wrote: > > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > >> +/* Active Format Description */ >> +if (x4-&

Re: [FFmpeg-devel] [PATCH 6/6] decklink: Add support for SCTE-104 to decklink capture

> On Nov 16, 2017, at 7:35 PM, Derek Buitenhuis > wrote: > > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: >> --- >> libavcodec/avcodec.h| 1 + >> libavcodec/codec_desc.c | 6 >> libavdevice/decklink_common.h | 6 >

Re: [FFmpeg-devel] [PATCH 1/2] libavdevice/decklink: Add support for EIA-708 output over SDI

Hello Marton, Thanks for taking the time to review. Most of the comments you’ve raised will be fixed and I’ll resubmit an updated patch. Comments on other issues inline below. >> >>/* Options */ >>int list_devices; >> @@ -88,6 +93,7 @@ struct decklink_ctx { >>DecklinkPtsSource aud

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

Hi Marton, Comments inline. >> +data = av_packet_get_side_data(pkt, AV_PKT_DATA_AFD, &size); >> +if (data) { >> +struct klvanc_packet_afd_s *pkt; >> +uint16_t *afd; >> +uint16_t len; >> + >> +ret = klvanc_create_AFD(&pkt); >> +if (ret != 0) >> +

Re: [FFmpeg-devel] [PATCH 1/2] libavdevice/decklink: Add support for EIA-708 output over SDI

Hello Marton, > SDK says: > > When capturing ancillary data with a 4K DeckLink device, the ancillary > data will always be in the 10-bit YUV pixel format. > > This also applies to 8 bit YUV captures according to my experience. > Thanks for refreshing my memory. I remember reading that text, b

Re: [FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

Hello Derek, Comments inline. >> >> +afd[0] = pkt->hdr.payload[0] >> 3; >> +if (av_packet_add_side_data(cb_ctx->pkt, AV_PKT_DATA_AFD, afd, 1) < 0) >> +av_free(afd); > > Is there a reason we shouldn't fail hard here? Not really. The parser will log an error if the callback retu

Re: [FFmpeg-devel] [PATCH 5/6] Add suppoort for using libklvanc from within decklink capture module

Hello James, Thanks for reviewing. >> +afd[0] = pkt->hdr.payload[0] >> 3; >> +if (av_packet_add_side_data(cb_ctx->pkt, AV_PKT_DATA_AFD, afd, 1) < 0) >> +av_free(afd); > > For this, av_packet_new_side_data() seems more adequate than av_malloc() > + av_packet_add_side_data(). > >

[FFmpeg-devel] Recent regression in VA-API compatibility (assertion in H.264 encode)

4_vaapi out.mp4 Any suggestions that could be offered would be greatly appreciated. Likewise please let me know if there is any other information I can provide that would assist in getting this resolved. Thanks, Devin Heitmueller ___ ffmpeg-dev

Re: [FFmpeg-devel] Recent regression in VA-API compatibility (assertion in H.264 encode)

Hi Mark, >> >> Here’s the vainfo output which provides the version info for the driver, >> va-api version, etc. This is on a Haswell system running Centos 7. >> >> libva info: VA-API version 0.34.0 >> libva info: va_getDriverName() returns 0 >> libva info: Trying to open /usr/lib64/dri/i965_dr

Re: [FFmpeg-devel] Recent regression in VA-API compatibility (assertion in H.264 encode)

>> Try this? (Not tested, hardware which can run a version that old isn't >> immediately to hand.) >> >> --- a/libavcodec/vaapi_encode_h264.c >> +++ b/libavcodec/vaapi_encode_h264.c >> @@ -261,7 +261,8 @@ static int >> vaapi_encode_h264_write_extra_header(AVCodecContext *avctx, >>retur

[FFmpeg-devel] [PATCH 0/4] avdevice/decklink: 10-bit video out and sources/sinks support

Hello all, Below please find several patches which fix a couple of bugs as well as adding support for 10-bit video on output and the "-sources" and "-sinks" argument when specified by ffmpeg.c. If you have any question/concerns, please don't hesitate to reply. Thanks,

[FFmpeg-devel] [PATCH 1/4] avdevice/decklink: Fix segfault when running -list_devices on OSX

The string is allocated with CFStringGetCString but was being deallocated with free(), which would intermittently result in a segmentation fault. Use the correct function for freeing the allocated CFString. Signed-off-by: Devin Heitmueller --- libavdevice/decklink_common.cpp | 2 +- 1 file

[FFmpeg-devel] [PATCH 4/4] livavdevice/decklink: Don't allow any codecs but V210 and UYVY422

Make sure that codecs other than V210 or wrapped avframes with uyvy422 video are passed to decklink output (which would result in undefined behavior). Signed-off-by: Devin Heitmueller --- libavdevice/decklink_enc.cpp | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice

[FFmpeg-devel] [PATCH 2/4] libavdevice/decklink: add support for -sources and -sinks arguments

tion, but now shares common code for the actual enumeration. Signed-off-by: Devin Heitmueller --- libavdevice/decklink_common.cpp | 52 + libavdevice/decklink_common.h | 2 +- libavdevice/decklink_dec.cpp| 22 - libavdevice/deck

[FFmpeg-devel] [PATCH 3/4] Add support for 10-bit output for Decklink SDI

From: Devin Heitmueller Can be tested via the following command: ./ffmpeg -i foo.ts -f decklink -vcodec v210 'DeckLink Duo (1)' Note that the 8-bit support works as it did before, and setting the pix_fmt isn't required for 10-bit mode. The code defaults to operating in 8-b

Re: [FFmpeg-devel] [PATCH 2/4] libavdevice/decklink: add support for -sources and -sinks arguments

> On Sep 30, 2017, at 4:02 PM, Marton Balint wrote: > > > > On Tue, 26 Sep 2017, Devin Heitmueller wrote: > >> Add support for enumerating the sources/sinks via the ffmpeg >> command line options, as opposed to having to create a real pipeline >> and use t

Re: [FFmpeg-devel] [PATCH 3/4] Add support for 10-bit output for Decklink SDI

Hello Marton, Thanks for taking the time to provide feedback. >> + } else { >> +*buffer = (void *)(_avpacket->data); > > The DeckLink SDK requires a 128 byte alignment for data. I am thinking > AVPacket does not always provides that. Maybe we should simply ignore the SDK > req

[FFmpeg-devel] [PATCH 1/2] libavdevice/decklink: add support for -sources and -sinks arguments

tion, but now shares common code for the actual enumeration. Updated to reflect feedback from Marton Balink . Signed-off-by: Devin Heitmueller --- libavdevice/decklink_common.cpp | 89 ++--- libavdevice/decklink_common.h | 3 +- libavdevice/deck

[FFmpeg-devel] [PATCH 2/2] libavdevice/decklink: add support for 10-bit output for Decklink SDI

specified, for backward compatibility. Updated to reflect feedback from Marton Balink Signed-off-by: Devin Heitmueller --- libavdevice/decklink_enc.cpp | 112 --- 1 file changed, 83 insertions(+), 29 deletions(-) diff --git a/libavdevice/decklink_enc.cp

[FFmpeg-devel] [PATCHv2 0/2] avdevice/decklink: 10-bit video out and sources/sinks support

ies was consolidated into patch 3 per Marton's suggestion. If you have any question/concerns, please don't hesitate to reply. Thanks, Devin Heitmueller Devin Heitmueller (2): libavdevice/decklink: add support for -sources and -sinks arguments libavdevice/decklink: add support for

Re: [FFmpeg-devel] [PATCHv2 0/2] avdevice/decklink: 10-bit video out and sources/sinks support

> On Oct 6, 2017, at 5:13 AM, Moritz Barsnick wrote: > > On Thu, Oct 05, 2017 at 15:32:04 -0400, Devin Heitmueller wrote: >> This patch series incorporates feedback provided from Marton Balint. >> Note that patch 4 in the previous patch series was consolidated into &g

[FFmpeg-devel] [PATCHv3 0/2] avdevice/decklink: 10-bit video out and sources/sinks support

as consolidated into patch 3 per Marton's suggestion. Patch series V3 corrects a misspelling in Marton's name in the commit. If you have any question/concerns, please don't hesitate to reply. Thanks, Devin Heitmueller Devin Heitmueller (2): libavdevice/decklink: add suppor

[FFmpeg-devel] [PATCHv3 2/2] libavdevice/decklink: add support for 10-bit output for Decklink SDI

specified, for backward compatibility. Updated to reflect feedback from Marton Balint Signed-off-by: Devin Heitmueller --- libavdevice/decklink_enc.cpp | 112 --- 1 file changed, 83 insertions(+), 29 deletions(-) diff --git a/libavdevice/decklink_enc.cp

[FFmpeg-devel] [PATCHv3 1/2] libavdevice/decklink: add support for -sources and -sinks arguments

tion, but now shares common code for the actual enumeration. Updated to reflect feedback from Marton Balint . Signed-off-by: Devin Heitmueller --- libavdevice/decklink_common.cpp | 89 ++--- libavdevice/decklink_common.h | 3 +- libavdevice/deck

[FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

From: Devin Heitmueller Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general support for ancillary data for the Decklink SDI module - the real work for construction of the EIA-708 CDP and VANC line construction is done by libklvanc

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

Hello Carl, > On Oct 6, 2017, at 5:07 PM, Carl Eugen Hoyos wrote: > > 2017-10-06 18:56 GMT+02:00 Devin Heitmueller : >> From: Devin Heitmueller >> >> Hook in libklvanc and use it for output of EIA-708 captions over >> SDI. The bulk of this patch is just gene

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

> > Sorry, what I meant was: > Nothing inside FFmpeg except the decklink device could use > VANC? Ah, I understand now. Yes, the decklink device is currently the only SDI device which is supported by libavdevice. I’ve got a whole pile of patches coming which add support for a variety of prot

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Added SCTE104 message decode from VANC

t’s see where we can divide/conquer rather than re-implementing work the other may have already done. Cheers, Devin Heitmueller LTN Global Communications ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Added SCTE104 message decode from VANC

> On Oct 15, 2017, at 6:36 PM, Moritz Barsnick wrote: > > On Fri, Oct 13, 2017 at 09:10:30 -0400, Devin Heitmueller wrote: >> Video filters cannot create new streams > > No? I thought they could. > I couldn’t find a single filter which calls avformat_new_str

Re: [FFmpeg-devel] decklink 24/32 bit question

> > The decklink sdk only defines two BMDAudioSampleType values: > bmdAudioSampleType16bitInteger and bmdAudioSampleType32bitInteger. I don't > think there's an easy way to support a 24 bit input here. Generally in this > case I've used bmdAudioSampleType32bitInteger and then encode it at pcm_s

Re: [FFmpeg-devel] decklink 24/32 bit question

Hello Marton, > On Oct 18, 2017, at 3:02 PM, Marton Balint wrote: > > > > On Tue, 17 Oct 2017, Devin Heitmueller wrote: > >>> > The decklink sdk only defines two BMDAudioSampleType values: >>> > bmdAudioSampleType16bitInteger and bmdAudioSampleType

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

> On Oct 6, 2017, at 12:56 PM, Devin Heitmueller > wrote: > > From: Devin Heitmueller > > Hook in libklvanc and use it for output of EIA-708 captions over > SDI. The bulk of this patch is just general support for ancillary > data for the Decklink SDI module - the re

Re: [FFmpeg-devel] decklink 24/32 bit question

Hi Doug, > On Oct 18, 2017, at 4:15 PM, Douglas Marsh wrote: > > I am not really sure I follow. I am not sure supporting 24-bit is a big > issue. A sample size of 32-bit should work fine for most folks. I can only > think of people (in the output stream) converting to 24-bits (via truncate or

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

Hi Deron, > I was going to actually test this with some old broadcast equipment I have > just dying for a purpose, but I don't see how to generate AV_PKT_DATA_A53_CC > side packet data except using the Decklink capture. I have A53 documentation, > but it just refers to CEA-708 (or SMPTE 334, or

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

Hi Dave, > > The President of AJA has publicly stated an intent to add an open license to > their SDK, https://twitter.com/ajaprez/status/910100436224499713 > . This is certainly good news. Looking at AJA’s offering is on my TODO list but

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

> On Oct 25, 2017, at 2:23 PM, Marton Balint wrote: > > > On Fri, 6 Oct 2017, Devin Heitmueller wrote: > >> From: Devin Heitmueller > <mailto:dheitmuel...@kernellabs.com>> >> >> Hook in libklvanc and use it for output of EIA-708 captions over &g

[FFmpeg-devel] [PATCH 0/1] Add ETC1 encoder/decoder

allow fixes to compile in C90 mode (cases where variables were being declared in-line with code). Devin Heitmueller (1): Add support for Ericsson Texture Compression 1 (ETC1) libavcodec/Makefile | 2 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c

[FFmpeg-devel] [PATCH 1/1] Add support for Ericsson Texture Compression 1 (ETC1)

This patch adds support for encoding/decoding ETC1 compressed textures. This includes support for the PKM file format. Example usage: ./ffmpeg -i input_image.jpg new.pkm ./ffmpeg -i new.pkm foo.jpg Signed-off-by: Devin Heitmueller --- libavcodec/Makefile | 2 + libavcodec/allcodecs.c

[FFmpeg-devel] FFmpeg table at NAB

nsidered to be a competitor to ffmpeg. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:/

  1   2   3   4   >