> On Oct 9, 2018, at 4:02 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com <jos...@ob-encoder.com>: >> From: Devin Heitmueller <dheitmuel...@ltnglobal.com> >> >> Create SMPTE ST 12-1 timecodes based on H.264 SEI picture timing >> info. >> >> For framerates > 30 FPS, the field flag is used in conjunction with >> pairs of frames which contain the same frame timestamp in S12M. >> Ensure the field is properly set per the spec. > > I understand why you split the patches like this and I am slightly in > favour of doing it this way but I believe most developers disagree > and would prefer one patch "based on a patch by Devin" so give them > a little time to comment. >
If Josh had written both patches I would agree with the sentiment that the patches should be compacted to a single patch. However since they come from two different authors I would argue they should be separate. That’s just my opinion though, and I may appear biased since I was the author of the first patch. Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
