Re: [FFmpeg-devel] [PATCH] mpegpicture: use coded_width/coded_height to allocate frame

2016-11-24 Thread Andreas Cadhalpun
ction in that case works, though. Attached is a patch for that. Best regards, Andreas >From df9241d8b575cc0fbf570e714c586ff37a4821fd Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Thu, 24 Nov 2016 23:57:46 +0100 Subject: [PATCH] mss2: only use error correction for matching block coun

Re: [FFmpeg-devel] [PATCH] aacsbr_fixed: prevent sbr gain from being zero

2016-11-24 Thread Andreas Cadhalpun
On 24.11.2016 18:29, Michael Niedermayer wrote: > On Thu, Nov 24, 2016 at 01:15:54AM +0100, Andreas Cadhalpun wrote: >> On 23.11.2016 03:22, Michael Niedermayer wrote: >>> On Sun, Nov 13, 2016 at 09:29:11PM +0100, Andreas Cadhalpun wrote: >>>> It causes division by

Re: [FFmpeg-devel] [PATCH] flvdec: set need_context_update when changing codec id

2016-11-24 Thread Andreas Cadhalpun
On 24.11.2016 16:31, Michael Niedermayer wrote: > On Thu, Nov 24, 2016 at 01:37:17AM +0100, Andreas Cadhalpun wrote: >> On 23.11.2016 03:26, Michael Niedermayer wrote: >>> On Fri, Nov 04, 2016 at 10:28:20PM +0100, Andreas Cadhalpun wrote: >>>> Otherwise the co

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-24 Thread Andreas Cadhalpun
On 24.11.2016 16:38, Michael Niedermayer wrote: > On Thu, Nov 24, 2016 at 01:06:35AM +0100, Andreas Cadhalpun wrote: >> libopusdec.c |7 +++ >> 1 file changed, 7 insertions(+) >> bc2908b04551bef5476493cb7bbf0df4979f92f6 >> 0001-libopusdec-default-to-stereo-fo

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-24 Thread Andreas Cadhalpun
On 24.11.2016 10:53, Josh de Kock wrote: > There's no benefit in waiting for this to occur before ffserver is > removed as it will always be in git history. Removing ffserver from > master may even speed up the "resurrection of ffserver". I think this > shouldn't be delayed any further. Similarly

Re: [FFmpeg-devel] libavcodec/exr : add support for uint32 channel decoding with pxr24

2016-11-24 Thread Andreas Cadhalpun
On 17.11.2016 21:30, Martin Vignali wrote: > From c70a83c38cd9a9434e6434d60dadf0a1c809e074 Mon Sep 17 00:00:00 2001 > From: Martin Vignali > Date: Thu, 17 Nov 2016 21:24:42 +0100 > Subject: [PATCH 2/3] libavcodec/exr : add support for uint32 channel decoding > with pxr24 > > Doesn't decode the u

Re: [FFmpeg-devel] Fate/exr : add test for PXR24 with half and uint32

2016-11-24 Thread Andreas Cadhalpun
On 17.11.2016 21:35, Martin Vignali wrote: > From 50d523d579cd8303aaab3bd7105b28359d81d13f Mon Sep 17 00:00:00 2001 > From: Martin Vignali > Date: Thu, 17 Nov 2016 21:25:19 +0100 > Subject: [PATCH 3/3] fate/exr : add test for prx24 with half and uint32 > channel > > --- > tests/fate/image.mak

Re: [FFmpeg-devel] [PATCH] aacsbr_fixed: prevent sbr gain from being zero

2016-11-24 Thread Andreas Cadhalpun
On 25.11.2016 01:12, Michael Niedermayer wrote: > On Fri, Nov 25, 2016 at 12:31:28AM +0100, Andreas Cadhalpun wrote: >> softfloat.h |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> 17b9929a3b2f3b064cc1f96c7ed48dfe377f191a >> 0001-softfloat-decrease-

Re: [FFmpeg-devel] [PATCH] mpegpicture: use coded_width/coded_height to allocate frame

2016-11-24 Thread Andreas Cadhalpun
On 25.11.2016 01:38, Michael Niedermayer wrote: > On Fri, Nov 25, 2016 at 12:03:30AM +0100, Andreas Cadhalpun wrote: >> mss2.c | 13 ++--- >> 1 file changed, 10 insertions(+), 3 deletions(-) >> 884b912643244a4205bac63faedfa0c048bcc97a >> 0001-mss2-on

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-11-24 Thread Andreas Cadhalpun
On 24.11.2016 12:36, Stefano Sabatini wrote: > I think the most important controversy points revolve around these facts: > > * developers do not want to add support for an internal only format, > which adds to the maintainance burden with no clear benefit, since > there are no clear use cases

Re: [FFmpeg-devel] [PATCH] mpegpicture: use coded_width/coded_height to allocate frame

2016-11-25 Thread Andreas Cadhalpun
On 25.11.2016 02:59, Michael Niedermayer wrote: > On Fri, Nov 25, 2016 at 02:26:24AM +0100, Andreas Cadhalpun wrote: >> mss2.c |8 +++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> 958ee0811485404a0662a1540fcb8b131423947b >> 0001-mss2-only-use-error-co

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-25 Thread Andreas Cadhalpun
On 25.11.2016 10:36, wm4 wrote: > I'd like to add that removing the ffserver support from the libs, and > all deprecated stuff it depends on, will make it actually easier to > readd ffserver in a cleaner way. It reduces the risk that the new > ffserver accidentally depends on mechanisms that were s

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Prevent access of elements after freeing by set nb_elem to zero.

2016-11-25 Thread Andreas Cadhalpun
On 25.11.2016 11:04, Schenk, Michael wrote: > From 9d2d5127a3113b6581b0a562776c3ec92c547bdb Mon Sep 17 00:00:00 2001 > From: Michael Schenk > Date: Fri, 25 Nov 2016 09:36:20 +0100 > Subject: [PATCH] set nb_elem to 0 after freeing to avoid further access which > may causing SEGV due to access to t

[FFmpeg-devel] [PATCH] lavf: always forward codec_whitelist in avformat_find_stream_info

2016-11-25 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavformat/utils.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 2634317..b1d0a0a 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -3695,9 +3695,13

[FFmpeg-devel] [PATCH] pngdec: check if previous frame exists instead of trusting sequence_number

2016-11-25 Thread Andreas Cadhalpun
This fixes a segmentation fault caused by calling memcpy with NULL as second argument in handle_p_frame_apng. Signed-off-by: Andreas Cadhalpun --- libavcodec/pngdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 36275ae

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-25 Thread Andreas Cadhalpun
On 25.11.2016 22:22, wm4 wrote: > On Fri, 25 Nov 2016 21:13:54 +0100 > Andreas Cadhalpun wrote: > >> On 25.11.2016 10:36, wm4 wrote: >>> I'd like to add that removing the ffserver support from the libs, and >>> all deprecated stuff it depends on, wil

Re: [FFmpeg-devel] [PATCH] pngdec: check if previous frame exists instead of trusting sequence_number

2016-11-26 Thread Andreas Cadhalpun
On 26.11.2016 01:53, Michael Niedermayer wrote: > On Fri, Nov 25, 2016 at 10:13:06PM +0100, Andreas Cadhalpun wrote: >> This fixes a segmentation fault caused by calling memcpy with NULL as >> second argument in handle_p_frame_apng. >> >> Signed-off-by: Andreas Cadha

Re: [FFmpeg-devel] [PATCH] lavf: always forward codec_whitelist in avformat_find_stream_info

2016-11-26 Thread Andreas Cadhalpun
On 26.11.2016 01:54, Michael Niedermayer wrote: > On Fri, Nov 25, 2016 at 09:57:57PM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/utils.c | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(-) > > LGT

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-27 Thread Andreas Cadhalpun
On 27.11.2016 19:36, Michael Niedermayer wrote: > If somethig critical remains, please someone list exactly what that is. > so reynaldo, i or others can go over the list and look into the issues As far as I'm aware the following points are most problematic: * ffserver uses internal functions, see

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-27 Thread Andreas Cadhalpun
On 26.11.2016 22:00, Rostislav Pehlivanov wrote: > Since a month has passed, reynaldo still hasn't responded, I think it's > long overdue to push this patch. I've attached a new version of the patch > which only removes the ffserver program (without touching anything else), > which had been OK'd by

Re: [FFmpeg-devel] [PATCH] pngdec: check if previous frame exists instead of trusting sequence_number

2016-11-27 Thread Andreas Cadhalpun
On 27.11.2016 04:07, Michael Niedermayer wrote: > On Sat, Nov 26, 2016 at 11:36:48PM +0100, Andreas Cadhalpun wrote: >> pngdec.c |3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> 141d5230c97dbc47e0b291f660544cfe57abbf7c >> 0001-pngdec-check-if-previ

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-11-27 Thread Andreas Cadhalpun
On 27.11.2016 17:08, Nicolas George wrote: > Changed the private fields: directly in avfilter.h with discreet ifdef > (preferred by Clément) with guarding reserved field (must urgent > countermeasure). Thanks. > I made a few tests and it seems making AVFilterLink completely opaque would > be real

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-11-27 Thread Andreas Cadhalpun
On 28.11.2016 00:11, Nicolas George wrote: > L'octidi 8 frimaire, an CCXXV, Andreas Cadhalpun a écrit : >> How would it conflict with this patch? >> Unless I misunderstood something the deprecation should only affect the >> public API, while this change should only affect

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-27 Thread Andreas Cadhalpun
On 28.11.2016 00:14, James Almer wrote: > On 11/27/2016 7:32 PM, Andreas Cadhalpun wrote: >> On 26.11.2016 22:00, Rostislav Pehlivanov wrote: >>> Since a month has passed, reynaldo still hasn't responded, I think it's >>> long overdue to push this patch. I&#

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-11-27 Thread Andreas Cadhalpun
On 28.11.2016 00:23, Nicolas George wrote: > L'octidi 8 frimaire, an CCXXV, Andreas Cadhalpun a écrit : >> Sure, but that conflict should be easy to resolve. > > Easy, yes. But it must be done at each rebase, that is annoying. Wasted > time that can be better used. I&

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-27 Thread Andreas Cadhalpun
On 28.11.2016 00:37, James Almer wrote: > On 11/27/2016 8:23 PM, Andreas Cadhalpun wrote: >> This can't happen while ffserver still uses internal API, and when it doesn't >> making it standalone isn't really useful, in particular because a standalone >> versio

Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-11-28 Thread Andreas Cadhalpun
On 28.11.2016 13:18, James Almer wrote: > [...] shit [...] shit [...] shit [...] shit. It's extremely disrespectful. Everyone reading your mail gets a clear picture of who is disrespectful. Please re-read our code of conduct and follow it in the future. I don't know why you are so enraged about

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

2016-11-28 Thread Andreas Cadhalpun
On 28.11.2016 11:48, Nicolas George wrote: > L'octidi 8 frimaire, an CCXXV, Andreas Cadhalpun a écrit : >> I'm not sure I understand. Just do the rebase once, commit the deprecation >> to git master and happily work on the other changes. > > Except that kind o

[FFmpeg-devel] [PATCH] avidec: fix leaking extradata

2016-11-28 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavformat/avidec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index e5a292e..97dbeae 100644 --- a/libavformat/avidec.c +++ b/libavformat/avidec.c @@ -770,6 +770,7 @@ FF_ENABLE_DEPRECATION_WARNINGS

[FFmpeg-devel] [PATCH] idroqdec: fix leaking pkt on failure

2016-11-28 Thread Andreas Cadhalpun
The code calls av_new_packet a few lines above and the allocated memory has to be freed in case of an error. Signed-off-by: Andreas Cadhalpun --- libavformat/idroqdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/idroqdec.c b/libavformat/idroqdec.c index

Re: [FFmpeg-devel] [PATCH] avidec: fix leaking extradata

2016-11-29 Thread Andreas Cadhalpun
On 29.11.2016 02:49, Michael Niedermayer wrote: > On Tue, Nov 29, 2016 at 12:33:17AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/avidec.c | 2 ++ >> 1 file changed, 2 insertions(+) > > If previous extradata is

Re: [FFmpeg-devel] [PATCH] idroqdec: fix leaking pkt on failure

2016-11-29 Thread Andreas Cadhalpun
On 29.11.2016 02:57, Michael Niedermayer wrote: > On Tue, Nov 29, 2016 at 12:46:11AM +0100, Andreas Cadhalpun wrote: >> The code calls av_new_packet a few lines above and the allocated memory >> has to be freed in case of an error. > > should be ok Pushed.

Re: [FFmpeg-devel] matroskadec: prevent access of elements after freeing

2016-11-29 Thread Andreas Cadhalpun
On 28.11.2016 07:40, Schenk, Michael wrote: > When using the decode interrupt feature of ffmpeg may causing crashes by > accessing previous freed pointers in matroska_read_close. > > The attached patch will reset nb_elem to zero after freeing the elements > because ffmpeg normally tests for nb_ele

Re: [FFmpeg-devel] [PATCH] avidec: fix leaking extradata

2016-11-29 Thread Andreas Cadhalpun
On 30.11.2016 01:29, Michael Niedermayer wrote: > On Wed, Nov 30, 2016 at 12:21:41AM +0100, Andreas Cadhalpun wrote: >> avidec.c |8 >> 1 file changed, 8 insertions(+) >> 88b8c27a72e7ec4519e92eee5a3a2764a657a823 >> 0001-avidec-fix-leak

[FFmpeg-devel] [PATCH 2/3] tests: drop -d option from ffserver invocation

2016-11-29 Thread Andreas Cadhalpun
It randomly causes failures with an error like: "Failed to set value '-f' for option 'd': Error number -920332800 occurred" (The error number is different every time.) Signed-off-by: Andreas Cadhalpun --- tests/ffserver-regression.sh | 2 +- 1 file changed, 1 ins

[FFmpeg-devel] [PATCH 3/3] ffserver: use codec time_base for stream

2016-11-29 Thread Andreas Cadhalpun
This fixes producing swf and rm files as done by ffservertest. Signed-off-by: Andreas Cadhalpun --- ffserver.c| 2 +- tests/ffserver.regression.ref | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ffserver.c b/ffserver.c index 20f5995..ffd75d4

[FFmpeg-devel] [PATCH 1/3] tests: print errors from ffserver

2016-11-29 Thread Andreas Cadhalpun
Not doing so makes debugging unnecessarily hard. Signed-off-by: Andreas Cadhalpun --- tests/ffserver-regression.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ffserver-regression.sh b/tests/ffserver-regression.sh index b776bad..47d6016 100755 --- a/tests/ffserver

Re: [FFmpeg-devel] [PATCH 1/3] tests: print errors from ffserver

2016-11-30 Thread Andreas Cadhalpun
On 30.11.2016 08:22, Reynaldo H. Verdejo Pinochet wrote: > The entire set looks good to go. Please feel free to push. Pushed. > Thank you! You're welcome. ;) Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.or

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

2016-11-30 Thread Andreas Cadhalpun
On 30.11.2016 19:16, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > Please CC. > Vittorio > > libavutil/pixdesc.c | 1 + > libavutil/pixfmt.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c > index 3b9c45d..04eab0b 100644

Re: [FFmpeg-devel] [PATCH 1/2] lavu: Add JEDEC P22 color primaries

2016-11-30 Thread Andreas Cadhalpun
On 30.11.2016 22:55, Ronald S. Bultje wrote: > On Wed, Nov 30, 2016 at 4:51 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> On 30.11.2016 19:16, Vittorio Giovara wrote: >> You can't just add a gap like that. >> The current code as

[FFmpeg-devel] [PATCH 1/3] configure: enable sdl if sdl2 is enabled

2016-11-30 Thread Andreas Cadhalpun
sdl is supposed to be an alias, so it should have the same value. Signed-off-by: Andreas Cadhalpun --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 6345fc2..2ce7555 100755 --- a/configure +++ b/configure @@ -5893,7 +5893,7 @@ if

[FFmpeg-devel] [PATCH 2/3] configure: enable autodetected libraries after option parsing

2016-11-30 Thread Andreas Cadhalpun
This is needed for the following patch. Signed-off-by: Andreas Cadhalpun --- configure | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/configure b/configure index 2ce7555..28c78ef 100755 --- a/configure +++ b/configure @@ -3237,15 +3237,6 @@ enable

[FFmpeg-devel] [PATCH 3/3] configure: fail if autodetect-libraries are requested but not found

2016-11-30 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- configure | 72 ++- 1 file changed, 53 insertions(+), 19 deletions(-) diff --git a/configure b/configure index 28c78ef..0e9695b 100755 --- a/configure +++ b/configure @@ -597,6 +597,13 @@ popvar

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-30 Thread Andreas Cadhalpun
On 23.11.2016 00:23, Josh de Kock wrote: > On 22/11/2016 23:11, Andreas Cadhalpun wrote: >> On 22.11.2016 23:43, Josh de Kock wrote: >>> On 22/11/2016 22:33, Andreas Cadhalpun wrote: >>>> Because it avoids confusing users. And the checks for other system >

Re: [FFmpeg-devel] [PATCH 2/3] configure: enable autodetected libraries after option parsing

2016-12-01 Thread Andreas Cadhalpun
, Andreas >From 88b3c4ffc2b02ca7dad1febda7cd6e3e02b8cf5f Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Wed, 30 Nov 2016 23:49:35 +0100 Subject: [PATCH 2/3] configure: enable autodetected libraries after option parsing And only enable them, if they haven't been disabled. This is needed for the followi

Re: [FFmpeg-devel] [PATCH 3/3] configure: fail if autodetect-libraries are requested but not found

2016-12-01 Thread Andreas Cadhalpun
On 01.12.2016 01:34, Michael Niedermayer wrote: > On Thu, Dec 01, 2016 at 12:22:50AM +0100, Andreas Cadhalpun wrote: >> @@ -6381,6 +6410,11 @@ for thread in $THREADS_LIST; do >> fi >> done >> >> +# Check if requested libraries were found. &g

Re: [FFmpeg-devel] [PATCH 1/6] tests/ffserver.regression.ref: Update ffserver checksums

2016-12-01 Thread Andreas Cadhalpun
On 01.12.2016 17:37, Michael Niedermayer wrote: > They have changed due to 122190392b297b7cd9783641d880df887fd80d07 > > Signed-off-by: Michael Niedermayer > --- > tests/ffserver.regression.ref | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/ffserver.regression

Re: [FFmpeg-devel] [PATCH 2/3] configure: enable autodetected libraries after option parsing

2016-12-01 Thread Andreas Cadhalpun
On 02.12.2016 01:05, Hendrik Leppkes wrote: > On Fri, Dec 2, 2016 at 12:27 AM, Andreas Cadhalpun > wrote: >> On 01.12.2016 11:01, Hendrik Leppkes wrote: >>> If those are enabled after option parsing, doesn't this then prevent >>> me from turning them off? &g

Re: [FFmpeg-devel] [PATCH 1/6] tests/ffserver.regression.ref: Update ffserver checksums

2016-12-02 Thread Andreas Cadhalpun
On 02.12.2016 04:27, Michael Niedermayer wrote: > On Fri, Dec 02, 2016 at 12:59:41AM +0100, Andreas Cadhalpun wrote: >> The test is unfortunately not very reproducible. >> Right now I'm getting varying values like on one run: >> -0c9639f09decbc54c9f09

Re: [FFmpeg-devel] [PATCH 3/3] configure: fail if autodetect-libraries are requested but not found

2016-12-02 Thread Andreas Cadhalpun
On 02.12.2016 19:20, Michael Niedermayer wrote: > On Fri, Dec 02, 2016 at 12:44:41AM +0100, Andreas Cadhalpun wrote: >> There is already va_va_h in vaapi_deps and I'm not sure, what else >> you'd like to have there. > > i see a "disable vaapi" here but t

Re: [FFmpeg-devel] [PATCH 1/5] avformat/ffmdec: Remove some st->codec uses which set encoder parameters

2016-12-02 Thread Andreas Cadhalpun
On 03.12.2016 00:52, Michael Niedermayer wrote: > Modern ffserver should not need these > > Signed-off-by: Michael Niedermayer > --- > libavformat/ffmdec.c | 148 > +-- > 1 file changed, 74 insertions(+), 74 deletions(-) > > diff --git a/libavfor

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-02 Thread Andreas Cadhalpun
On 03.12.2016 00:52, Michael Niedermayer wrote: > This is a bit messy as codecar does not support AVOptions so we need > to use AVCodecContext where AVOptions are required and copy back and forth. > > Signed-off-by: Michael Niedermayer > --- > libavformat/ffmdec.c | 159 > ++

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 00:52, Michael Niedermayer wrote: > @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) > ret = AVERROR_INVALIDDATA; > goto fail; > } > -codec->width = avio_rb16(pb); > -codec->height = avio_rb16(

Re: [FFmpeg-devel] [PATCH 3/5] avformat/ffmdec: Drop flags2, debug and codec->time_base setting

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 00:52, Michael Niedermayer wrote: > It should still be possible to set these through > recommended_encoder_configuration > > Signed-off-by: Michael Niedermayer > --- > libavformat/ffmdec.c | 27 --- > 1 file changed, 8 insertions(+), 19 deletions(-) > > di

Re: [FFmpeg-devel] [PATCH 4/5] ffserver: remove one avcodec_context_copy()

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 00:52, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > ffserver.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ffserver.c b/ffserver.c > index 19c3ceda1a..3ff761f68f 100644 > --- a/ffserver.c > +++ b/ffserver.c > @@ -2854,7 +285

Re: [FFmpeg-devel] [PATCH 5/5] avformat/ffmdec: remove last use of st->codec

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 00:52, Michael Niedermayer wrote: > @@ -364,14 +364,19 @@ static int ffm2_read_header(AVFormatContext *s) > } > codecpar->bit_rate = avio_rb32(pb); > if (codecpar->bit_rate < 0) { > -av_log(codec, AV_LOG_ERROR, "Invalid bit rate %

Re: [FFmpeg-devel] [PATCH 5/5] avformat/ffmdec: remove last use of st->codec

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:14, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 12:51:12PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2016 00:52, Michael Niedermayer wrote: >>> @@ -364,14 +364,19 @@ static int ffm2_read_header(AVFormatContext *s) >>> } >>

Re: [FFmpeg-devel] [PATCH 1/5] avformat/ffmdec: Remove some st->codec uses which set encoder parameters

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:23, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 01:14:19AM +0100, Andreas Cadhalpun wrote: >> On 03.12.2016 00:52, Michael Niedermayer wrote: >>> Modern ffserver should not need these >>> >>> Signed-off-by: Michael Niedermayer >

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:31, Michael Niedermayer wrote: > all done locally, Thanks, patch is OK then. > some of this code is btw not tested by fate Yes, the FFM1 code path is not tested by FATE. Personally I think it would make more sense to remove support for FFM1 than adding a FATE test for it. The c

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:37, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 12:47:45PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2016 00:52, Michael Niedermayer wrote: >>> @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) >>>

Re: [FFmpeg-devel] [PATCH 2/5] avformat/ffmdec: replace most codec uses by codecpar

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:39, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 12:47:45PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2016 00:52, Michael Niedermayer wrote: >>> @@ -400,16 +398,16 @@ static int ffm2_read_header(AVFormatContext *s) >>>

Re: [FFmpeg-devel] [PATCH 3/5] avformat/ffmdec: Drop flags2, debug and codec->time_base setting

2016-12-03 Thread Andreas Cadhalpun
On 03.12.2016 13:43, Michael Niedermayer wrote: > On Sat, Dec 03, 2016 at 12:48:43PM +0100, Andreas Cadhalpun wrote: >> On 03.12.2016 00:52, Michael Niedermayer wrote: >>> It should still be possible to set these through >>> recommended_encoder_configuration >

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-12-04 Thread Andreas Cadhalpun
On 31.10.2016 09:51, Stefano Sabatini wrote: > From 7f209e27aa33e8f43444e5cfc44c68f664b69e06 Mon Sep 17 00:00:00 2001 > From: Nicolas George > Date: Sat, 11 Jan 2014 19:42:41 +0100 > Subject: [PATCH] lavf: add ffprobe demuxer > > With several modifications and documentation by Stefano Sabatini >

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-12-04 Thread Andreas Cadhalpun
On 28.11.2016 19:15, Nicolas George wrote: > Deadline: 2016-12-06 00:00 UTC. > > I propose, and put to the discussion, that the decision to drop ffserver > is revoked, conditioned to the fixing of the technical issues that lead > to it. > > In other words, if the technical problems that require d

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-12-04 Thread Andreas Cadhalpun
On 04.12.2016 23:42, Rostislav Pehlivanov wrote: > On 4 December 2016 at 21:54, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: >> As I already wrote elsewhere, I don't think disabling this by default is >> good, >> as it will likely cause it

[FFmpeg-devel] [PATCH] truemotion1: fix leaking frame on init failure

2016-12-05 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavcodec/truemotion1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/truemotion1.c b/libavcodec/truemotion1.c index da843c4..c2022fb 100644 --- a/libavcodec/truemotion1.c +++ b/libavcodec/truemotion1.c @@ -489,8 +489,10

Re: [FFmpeg-devel] [PATCH] omx: Fix OOM check

2016-12-05 Thread Andreas Cadhalpun
On 05.12.2016 18:49, Timothy Gu wrote: > Also use av_mallocz_array(). > > Fixes CID1396839. > --- > libavcodec/omx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/omx.c b/libavcodec/omx.c > index c1b6fb9..b5093f4 100644 > --- a/libavcodec/omx.c > +++ b/l

Re: [FFmpeg-devel] [PATCH] truemotion1: fix leaking frame on init failure

2016-12-05 Thread Andreas Cadhalpun
On 05.12.2016 22:33, Michael Niedermayer wrote: > On Mon, Dec 05, 2016 at 09:51:31PM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/truemotion1.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > > LGT

[FFmpeg-devel] [PATCH] yuv4mpegdec: fix leaking pkt in yuv4_read_packet

2016-12-05 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavformat/yuv4mpegdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/yuv4mpegdec.c b/libavformat/yuv4mpegdec.c index a91645f..462b823 100644 --- a/libavformat/yuv4mpegdec.c +++ b/libavformat/yuv4mpegdec.c @@ -295,9

Re: [FFmpeg-devel] [PATCH] yuv4mpegdec: fix leaking pkt in yuv4_read_packet

2016-12-07 Thread Andreas Cadhalpun
On 07.12.2016 03:18, Michael Niedermayer wrote: > On Mon, Dec 05, 2016 at 11:08:44PM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/yuv4mpegdec.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >>

[FFmpeg-devel] [PATCH 2/2] opus_parser: replace ff_parse_close with opus_parse_close

2016-12-08 Thread Andreas Cadhalpun
The former expects priv_data to be the ParseContext directly, so using it does not work. Signed-off-by: Andreas Cadhalpun --- libavcodec/opus_parser.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/opus_parser.c b/libavcodec/opus_parser.c index 21a73ee

[FFmpeg-devel] [PATCH 1/2] opus_parser: fix leaking channel_maps on error

2016-12-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavcodec/opus_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/opus_parser.c b/libavcodec/opus_parser.c index c30fd7b..21a73ee 100644 --- a/libavcodec/opus_parser.c +++ b/libavcodec/opus_parser.c @@ -116,11 +116,11

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-12-08 Thread Andreas Cadhalpun
On 08.12.2016 15:53, wm4 wrote: > (I'm still waiting for related work to be merged from Libav). Why don't you merge it yourself instead of waiting for others? > So yes, removing things can mean progress. However, removing ffserver now doesn't, because the libraries have to keep backwards-compati

Re: [FFmpeg-devel] [PATCH] Support limiting the number of pixels per image

2016-12-08 Thread Andreas Cadhalpun
On 08.12.2016 19:30, Michael Niedermayer wrote: > TODO: split into 2 patches (one per lib), docs & bump > > This allows preventing some OOM and "slow decoding" cases by limiting the > maximum resolution > this may be useful to avoid fuzzers getting stuck in boring cases > > Signed-off-by: Michae

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-08 Thread Andreas Cadhalpun
On 08.12.2016 20:57, Michael Niedermayer wrote: > This is something the community must decide. > A. Is a heap limit for av_*alloc*() acceptable ? I'm not sure that's a good idea, because it can't limit what other libraries called by libavcodec etc. allocate. > B. Are case based limits acceptable

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: Add FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM

2016-12-08 Thread Andreas Cadhalpun
On 08.12.2016 22:53, Michael Niedermayer wrote: > This decreases the amount of computations and memory needed for analysing > mpeg1/2 streams > > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg12dec.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/liba

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-08 Thread Andreas Cadhalpun
On 08.12.2016 22:59, Carl Eugen Hoyos wrote: > 2016-12-08 18:37 GMT+01:00 Michael Niedermayer : > >> -{"max_streams", "maximum number of streams", OFFSET(max_streams), >> AV_OPT_TYPE_INT, { .i64 = INT_MAX }, 0, INT_MAX, D }, >> +{"max_streams", "maximum number of streams", OFFSET(max_streams), >

Re: [FFmpeg-devel] [PATCH 1/2] opus_parser: fix leaking channel_maps on error

2016-12-09 Thread Andreas Cadhalpun
On 09.12.2016 15:23, Michael Niedermayer wrote: > On Fri, Dec 09, 2016 at 12:08:10AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/opus_parser.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>

Re: [FFmpeg-devel] [PATCH 2/2] opus_parser: replace ff_parse_close with opus_parse_close

2016-12-09 Thread Andreas Cadhalpun
On 09.12.2016 15:02, Hendrik Leppkes wrote: > On Fri, Dec 9, 2016 at 12:09 AM, Andreas Cadhalpun > wrote: >> The former expects priv_data to be the ParseContext directly, so using >> it does not work. >> > > As an alternative re-order the OpusParseContext so that

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: Add FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM

2016-12-09 Thread Andreas Cadhalpun
On 09.12.2016 02:50, Michael Niedermayer wrote: > On Fri, Dec 09, 2016 at 01:02:08AM +0100, Andreas Cadhalpun wrote: >> On 08.12.2016 22:53, Michael Niedermayer wrote: >>> This decreases the amount of computations and memory needed for analysing >>> mpeg1/2 streams >

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-12-09 Thread Andreas Cadhalpun
On 09.12.2016 10:26, wm4 wrote: > On Fri, 9 Dec 2016 00:30:24 +0100 > Andreas Cadhalpun wrote: > >> On 08.12.2016 15:53, wm4 wrote: >>> (I'm still waiting for related work to be merged from Libav). >> >> Why don't you merge it yourself instea

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-12-09 Thread Andreas Cadhalpun
On 09.12.2016 15:55, Stefano Sabatini wrote: > On date Friday 2016-11-25 11:58:42 +0100, Nicolas George encoded: >> Le quintidi 5 frimaire, an CCXXV, Andreas Cadhalpun a écrit : >>> I think a better idea would be to require '-strict experimental', >>> as code

Re: [FFmpeg-devel] [PATCH] Support limiting the number of pixels per image

2016-12-10 Thread Andreas Cadhalpun
On 09.12.2016 20:31, Michael Niedermayer wrote: > Adds av_image_check_size2() with max_pixels and pix_fmt parameters. > pix_fmt is unused and is added to avoid a 2nd API change later > > The old function uses AVOptions to obtain the max_pixels value to simplify > the transition. > > TODO: split i

Re: [FFmpeg-devel] [PATCH 2/2] opus_parser: replace ff_parse_close with opus_parse_close

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 01:17, Hendrik Leppkes wrote: > On Fri, Dec 9, 2016 at 11:46 PM, Andreas Cadhalpun > wrote: >> On 09.12.2016 15:02, Hendrik Leppkes wrote: >>> On Fri, Dec 9, 2016 at 12:09 AM, Andreas Cadhalpun >>> wrote: >>>> The former expects priv_data

Re: [FFmpeg-devel] [PATCH 1/2] opus_parser: fix leaking channel_maps on error

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 04:19, Michael Niedermayer wrote: > On Fri, Dec 09, 2016 at 11:42:59PM +0100, Andreas Cadhalpun wrote: >> opus.c|1 + >> opusdec.c |1 - >> 2 files changed, 1 insertion(+), 1 deletion(-) >> 3e534ddbb39e05f8c7a5cfeba4b65ed587c3a519 >

[FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavutil/opt.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index f855ccb..f713d3f 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -32,6 +32,7 @@ #include "common.h" #inclu

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 16:19, Carl Eugen Hoyos wrote: > 2016-12-10 16:11 GMT+01:00 Andreas Cadhalpun > : >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/opt.c | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/libavuti

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 16:26, wm4 wrote: > On Sat, 10 Dec 2016 16:11:15 +0100 > Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/opt.c | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 17:29, Hendrik Leppkes wrote: > On Sat, Dec 10, 2016 at 4:55 PM, Andreas Cadhalpun > wrote: >> If that is done, the hard limit in av_image_check_size should check for >> the maximum allowed value of any pixel format. >> But a check here is needed to make

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 18:40, Hendrik Leppkes wrote: > On Sat, Dec 10, 2016 at 6:20 PM, Andreas Cadhalpun > wrote: >> On 10.12.2016 17:29, Hendrik Leppkes wrote: >>> On Sat, Dec 10, 2016 at 4:55 PM, Andreas Cadhalpun >>> wrote: >>>> If that is done, the hard lim

Re: [FFmpeg-devel] [PATCH 3/3] configure: fail if autodetect-libraries are requested but not found

2016-12-10 Thread Andreas Cadhalpun
On 03.12.2016 01:25, Michael Niedermayer wrote: > On Fri, Dec 02, 2016 at 11:24:12PM +0100, Andreas Cadhalpun wrote: >> On 02.12.2016 19:20, Michael Niedermayer wrote: >>> iam ok with the patch if other are and its tested >> >> I've tested for all AUTODETECT_LI

[FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Andreas Cadhalpun
Suggested-by: Carl Eugen Hoyos Signed-off-by: Andreas Cadhalpun --- src/index | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/index b/src/index index c203676..8f533f5 100644 --- a/src/index +++ b/src/index @@ -37,6 +37,13 @@ News + December 10th, 2016, stricter

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 19:49, James Almer wrote: > On 12/10/2016 3:47 PM, Andreas Cadhalpun wrote: >> Suggested-by: Carl Eugen Hoyos >> Signed-off-by: Andreas Cadhalpun >> --- >> src/index | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/sr

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-11 Thread Andreas Cadhalpun
On 10.12.2016 23:22, Carl Eugen Hoyos wrote: > 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun > : >> Suggested-by: Carl Eugen Hoyos >> Signed-off-by: Andreas Cadhalpun >> --- >> src/index | 7 +++ >> 1 file changed, 7 insertions(+) >> >> dif

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-11 Thread Andreas Cadhalpun
On 11.12.2016 10:04, Hendrik Leppkes wrote: > On Sat, Dec 10, 2016 at 6:53 PM, Andreas Cadhalpun > wrote: >> On 10.12.2016 18:40, Hendrik Leppkes wrote: >>> and just adds extra burden when these limits are >>> changed/improved (say by making them pixfmt aware as d

Re: [FFmpeg-devel] [PATCH 1/3] Revert "avcodec: Add max_pixels options"

2016-12-11 Thread Andreas Cadhalpun
On 11.12.2016 17:39, Nicolas George wrote: > This reverts commit 2f07830e69bd14eaba348eb739b9503e7eb7cd4b. I'm against reverting this. > It was rushed and not properly designed. It was tested and works well for its purpose. Best regards, Andreas ___ f

Re: [FFmpeg-devel] [PATCH 1/3] Revert "avcodec: Add max_pixels options"

2016-12-11 Thread Andreas Cadhalpun
On 11.12.2016 19:27, Nicolas George wrote: > Le primidi 21 frimaire, an CCXXV, Michael Niedermayer a écrit : >> Fuzzers search and find issues like out of array accesses but also >> hangs and oom conditions. >> Fuzzers find hangs and OOM conditions by executing code until it runs >> out of memory o

Re: [FFmpeg-devel] [PATCH 1/3] Revert "avcodec: Add max_pixels options"

2016-12-11 Thread Andreas Cadhalpun
On 11.12.2016 20:19, Nicolas George wrote: > Le primidi 21 frimaire, an CCXXV, Andreas Cadhalpun a écrit : >> No, that doesn't solve the problem. It takes much more time until the >> address space limit is reached than checking the resolution before >> starting to al

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-11 Thread Andreas Cadhalpun
On 11.12.2016 21:03, Hendrik Leppkes wrote: > On Sun, Dec 11, 2016 at 7:48 PM, Andreas Cadhalpun > wrote: >> On 11.12.2016 10:04, Hendrik Leppkes wrote: >>> I still see the problem that this option code does not know which >>> pix_fmt the numbers relate to and as su

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-11 Thread Andreas Cadhalpun
On 11.12.2016 22:03, Ronald S. Bultje wrote: > On Sun, Dec 11, 2016 at 1:41 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: >> This trivial news patch already got way more comments than the original >> patch series, which gives me the impression tha

<    1   2   3   4   5   6   7   8   9   10   >