Re: [FFmpeg-devel] [PATCH] avformat/hls: release mem resource to fix memleak

On Sat, Dec 30, 2017 at 8:34 AM Derek Buitenhuis wrote: > On 12/30/2017 4:31 PM, Nicolas George wrote: > > Does it really matter? If av_opt_get() fails for any reason, > > http_multiple will just be false, which would let the processing > > continue, only in a slightly degraded manner that was th

Re: [FFmpeg-devel] [PATCH 1/2] avformat/http: return EINVAL if ff_http_do_new_request is called with non-http URLContext

On Sat, Dec 30, 2017 at 10:11 AM wm4 wrote: > On Fri, 29 Dec 2017 15:41:57 -0800 > Aman Gupta wrote: > > > From: Aman Gupta > > > > Signed-off-by: Aman Gupta > > --- > > libavformat/http.c | 5 + > > 1 file changed, 5 insertions(+) > >

Re: [FFmpeg-devel] [PATCH] avformat/hls: release mem resource to fix memleak

On Sat, Dec 30, 2017 at 2:14 PM Derek Buitenhuis wrote: > On 12/30/2017 5:50 PM, Aman Gupta wrote: > > There is already a check in place to prevent strncmp from being called > with > > NULL. > > The point before still holds. > > Are people really arguing against co

[FFmpeg-devel] [PATCH v2] avformat/hls: release mem resource to fix memleak

From: Steven Liu fix CID: 1426991 Signed-off-by: Steven Liu Signed-off-by: Aman Gupta --- libavformat/hls.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index d9f7c6de4d..950cc4c3bd 100644 --- a/libavformat/hls.c +++ b

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix seek accuracy problem

On Tue, Jan 2, 2018 at 3:05 AM Steven Liu wrote: > 2018-01-02 18:28 GMT+08:00 : > > From: Wu Zhiqiang > > > > HLS demuxer seeking use dts instead of pts. > > Demuxer skip some frame when dts is before pts in special case. > > And it is impossible to re-seek back to start time after playing. > >

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix seek accuracy problem

On Tue, Jan 2, 2018 at 7:27 PM Wu Zhiqiang wrote: > On Wed, Jan 3, 2018 at 2:03 AM, Aman Gupta wrote: > > > On Tue, Jan 2, 2018 at 3:05 AM Steven Liu > wrote: > > > > > 2018-01-02 18:28 GMT+08:00 : > > > > From: Wu Zhiqiang > > > &

Re: [FFmpeg-devel] [PATCH] lavc/mediacodecdec: remove mediacodec_process_data() indirection

On Wed, Jan 3, 2018 at 4:17 AM, Matthieu Bouron wrote: > --- > libavcodec/mediacodecdec.c | 11 +-- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c > index b698ceaef9..c0e91c9429 100644 > --- a/libavcodec/mediacod

Re: [FFmpeg-devel] [PATCH] lavc/mediacodec_wrapper: allocate MediaCodec.BufferInfo once

On Wed, Jan 3, 2018 at 6:05 AM, Matthieu Bouron wrote: > --- > libavcodec/mediacodec_wrapper.c | 61 +++--- > --- > 1 file changed, 34 insertions(+), 27 deletions(-) > > diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_ > wrapper.c > index d9f0

Re: [FFmpeg-devel] [PATCH v2] libavcodec/mediacodecdec: switch to new decoder api

On Wed, Jan 3, 2018 at 3:25 AM, Matthieu Bouron wrote: > On Thu, Dec 28, 2017 at 05:33:14PM -0800, Aman Gupta wrote: > > From: Aman Gupta > > > > Using the new API gives the decoder the ability to produce > > N frames per input packet. This is particularly useful with

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: fix threaded decoding

On Fri, Feb 2, 2018 at 6:50 PM, Rodger Combs wrote: > AVHWAccel.end_frame can run on a worker thread. The assumption of the > frame threading code is that the worker thread will change the AVFrame > image data, not the AVFrame fields. So the AVFrame fields are not synced > back to the main thread

Re: [FFmpeg-devel] First Post

On Thu, Feb 1, 2018 at 3:40 PM, grady player wrote: > Probably a good place to start would be: > https://ffmpeg.org/developer.html > especially: > https://ffmpeg.org/developer.html#Submitting-patches < > https://ffmpeg.org/developer.html#Submitting-patches> > >

Re: [FFmpeg-devel] [PATCH] lavf/mpegts: add supplementary audio descriptor

On Thu, Feb 15, 2018 at 4:12 AM Stefan Pöschel wrote: > The supplementary audio descriptor is defined in ETSI EN 300 468 and > provides more details regarding accessibility audio tracks, especially > the normative annex J contains a detailed description of its use. > > Its language code (if prese

[FFmpeg-devel] [PATCH] avcodec/mediacodecdec: refactor to take advantage of new decoding api

From: Aman Gupta This refactor splits up the main mediacodec decode loop into two send/receive helpers, which are then used to rewrite the receive_frame callback and take full advantage of the new decoding api. Since we can now request packets on demand with ff_decode_get_packet(), the fifo

Re: [FFmpeg-devel] [PATCH] lavf/mpegts: add supplementary audio descriptor

On Thu, Feb 15, 2018 at 12:33 PM, Stefan Pöschel wrote: > Am 15.02.2018 um 20:52 schrieb Aman Gupta: > > Patch looks reasonable to me. > > Great! > > > It might also be worth surfacing when the audio descriptor flags contain > > mix_type=0, as this indicates a de

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: refactor to take advantage of new decoding api

On Fri, Feb 16, 2018 at 4:01 AM Matthieu Bouron wrote: > On Thu, Feb 15, 2018 at 07:52:14PM -0800, Aman Gupta wrote: > > From: Aman Gupta > > Hi, > > > > > This refactor splits up the main mediacodec decode loop into two > > send/receive helpers, which are th

Re: [FFmpeg-devel] [PATCH] lavf/mpegts: add supplementary audio descriptor

On Thu, Feb 15, 2018 at 4:11 AM, Stefan Pöschel wrote: > The supplementary audio descriptor is defined in ETSI EN 300 468 and > provides more details regarding accessibility audio tracks, especially > the normative annex J contains a detailed description of its use. > > Its language code (if pres

[FFmpeg-devel] [PATCH] avformat/mpegts: set AV_DISPOSITION_DEPENDENT for mix_type=0 supplementary audio

From: Aman Gupta --- fftools/ffmpeg.c | 1 + libavformat/avformat.h | 1 + libavformat/dump.c | 2 ++ libavformat/mpegts.c | 3 +++ 4 files changed, 7 insertions(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index a37de2ff98..bea922b0aa 100644 --- a/fftools/ffmpeg.c +++ b

Re: [FFmpeg-devel] [PATCH v2] lavf/mpegts: add supplementary audio descriptor

On Fri, Feb 16, 2018 at 11:22 AM, Stefan Pöschel wrote: > The supplementary audio descriptor is defined in ETSI EN 300 468 and > provides more details regarding accessibility audio tracks, especially > the normative annex J contains a detailed description of its use. > > Its language code (if pre

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: set AV_DISPOSITION_DEPENDENT for mix_type=0 supplementary audio

On Fri, Feb 16, 2018 at 11:06 AM, Aman Gupta wrote: > From: Aman Gupta > > --- > fftools/ffmpeg.c | 1 + > libavformat/avformat.h | 1 + > libavformat/dump.c | 2 ++ > libavformat/mpegts.c | 3 +++ > 4 files changed, 7 insertions(+) > > diff --gi

Re: [FFmpeg-devel] [PATCH v3] lavf/mpegts: add supplementary audio descriptor

On Tue, Feb 20, 2018 at 9:15 AM, Stefan Pöschel wrote: > The supplementary audio descriptor is defined in ETSI EN 300 468 and > provides more details regarding accessibility audio tracks, especially > the normative annex J contains a detailed description of its use. > > Its language code (if pres

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/mediacodecdec: factorize codec declarations

On Fri, Mar 2, 2018 at 4:13 PM, Matthieu Bouron wrote: > --- > libavcodec/mediacodecdec.c | 116 ++ > --- > 1 file changed, 24 insertions(+), 92 deletions(-) > > diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c > index 4579da1fa5..5e971

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/mediacodecdec: factorize codec declarations

On Fri, Mar 2, 2018 at 4:24 PM, Aman Gupta wrote: > > > On Fri, Mar 2, 2018 at 4:13 PM, Matthieu Bouron > wrote: > >> --- >> libavcodec/mediacodecdec.c | 116 ++ >> --- >> 1 file changed, 24 insertions(+), 92 del

[FFmpeg-devel] [PATCH] avcodec/aacdec: log configuration change details

From: Aman Gupta --- libavcodec/aacdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 44352764a7..d394700cdc 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -318,8 +318,8 @@ static int

[FFmpeg-devel] [PATCH 2/2] avcodec/mediacodecdec: add more trace logging of input/output buffers

From: Aman Gupta --- libavcodec/mediacodec.c | 1 + libavcodec/mediacodecdec_common.c | 4 libavcodec/mediacodecdec_common.h | 1 + 3 files changed, 6 insertions(+) diff --git a/libavcodec/mediacodec.c b/libavcodec/mediacodec.c index bf1b7477f1..5cb96d2b65 100644 --- a

[FFmpeg-devel] [PATCH 1/2] avcodec/mediacodecdec: add delay_flush option

From: Aman Gupta The default behavior of the mediacodec decoder before this commit was to delay flushes until all pending hardware frames were returned to the decoder. This was useful for certain types of applications, but was unexpected behavior for others. The new default behavior with this

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec_wrapper: blacklist more software decoders

On Tue, Mar 6, 2018 at 10:00 AM, Stefan _ wrote: > Hi, > > for hwdec on Android the wrapper attempts to blacklist known software > decoders also provided through the mediacodec API. The list isn't complete > however and ffmpeg might e.g. prefer slower "external" HEVC software > decoding over its

[FFmpeg-devel] [PATCH 1/2] avcodec/mediacodec: reduce loglevel for per-frame logging

From: Aman Gupta --- libavcodec/mediacodecdec_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_common.c index 929db78361..0bd660f7c9 100644 --- a/libavcodec/mediacodecdec_common.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 2/2] MAINTAINERS: add myself to mediacodec

From: Aman Gupta --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cc4c23df6f..3c54ad6781 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -268,7 +268,7 @@ Hardware acceleration: crystalhd.c Philip

[FFmpeg-devel] [PATCH] avcodec/mpeg12dec: ignore scte20 captions when a53 data is also present

From: Aman Gupta Some streams include both a53 and scte20 data. Before this commit, the scte20 data would be used instead of the a53 data. See https://s3.amazonaws.com/tmm1/ccaptions/scte20plusa53.ts, which produced garbage captions since 3f1a540204a8c187f77b3805d. --- libavcodec/mpeg12dec.c

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: ignore scte20 captions when a53 data is also present

On Wed, Mar 7, 2018 at 9:49 AM Michael Niedermayer wrote: > On Tue, Mar 06, 2018 at 02:25:12PM -0800, Aman Gupta wrote: > > From: Aman Gupta > > > > Some streams include both a53 and scte20 data. Before this commit, > > the scte20 data would be used instead of the

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: ignore scte20 captions when a53 data is also present

On Wed, Mar 7, 2018 at 10:35 AM Devin Heitmueller < dheitmuel...@ltnglobal.com> wrote: > > > From what I've seen in US broadcast television, scte20 is only used on > > standard-def content and everything else uses normal a53. > > A53 is definitely the more popular standard, and all that is approve

Re: [FFmpeg-devel] [PATCH] avformat: add mpegtsraw muxer

On Mon, Dec 21, 2020 at 4:58 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Aman Karmani: > > From: Aman Karmani > > > > Allows easier writing of a AV_CODEC_ID_MPEG2TS stream out to disk. > > > > Signed-off-by: Aman Karmani > > --- > > libavformat/Makefile | 1 + > > libavf

[FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

From: Aman Gupta CC data is fed to in small chunks (usually 60 bytes at a time) and is parsed fully by the eia608 decoder. There is no reason to copy it into a secondary buffer first. --- libavcodec/ccaption_dec.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions

[FFmpeg-devel] [PATCH 1/3] libavcodec/ccaption_dec: remove unnecessary include

From: Aman Gupta --- libavcodec/ccaption_dec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 9f67caa..4e478e0 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -21,7 +21,6 @@ #include "avco

[FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: clean up and standardize white space

From: Aman Gupta --- libavcodec/ccaption_dec.c | 98 ++- 1 file changed, 45 insertions(+), 53 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 4e478e0..96f0ccf 100644 --- a/libavcodec/ccaption_dec.c +++ b

[FFmpeg-devel] [PATCH 3/3] libavcodec/ccaption_dec: rewrite packet handler as case statement; remove COR3 macro

From: Aman Gupta --- libavcodec/ccaption_dec.c | 92 +++ 1 file changed, 53 insertions(+), 39 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 96f0ccf..788e96a 100644 --- a/libavcodec/ccaption_dec.c +++ b

[FFmpeg-devel] [PATCH 1/6] libavcodec/ccaption_dec: remove unused return value from internal functions

From: Aman Gupta --- libavcodec/ccaption_dec.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 788e96a..bc26e4e 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -395,24

[FFmpeg-devel] [PATCH 2/6] libavcodec/ccaption_dec: reap_screen() is responsible for clearing output buffer and signaling screen_changed

From: Aman Gupta --- libavcodec/ccaption_dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index bc26e4e..c5aace7 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -316,6 +316,7

[FFmpeg-devel] [PATCH 4/6] libavcodec/ccaption_dec: reap_screen is not necessary when clearing screen or buffer

From: Aman Gupta --- libavcodec/ccaption_dec.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 6f1e70d..8373a0c 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -395,17 +395,15

[FFmpeg-devel] [PATCH 5/6] libavcodec/ccaption_dec: clean up whitespace

From: Aman Gupta --- libavcodec/ccaption_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 8373a0c..fbf23d0 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -506,7 +506,7 @@ static void

[FFmpeg-devel] [PATCH 6/6] libavcodec/ccaption_dec: prevent debug logging about tab offset commands

From: Aman Gupta this can be filled in if/when the decoder adds positioning support --- libavcodec/ccaption_dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index fbf23d0..34a7208 100644 --- a/libavcodec/ccaption_dec.c +++ b

[FFmpeg-devel] [PATCH 3/6] libavcodec/ccaption_dec: implement "erase non displayed memory"

From: Aman Gupta --- libavcodec/ccaption_dec.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index c5aace7..6f1e70d 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -395,12

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

On Tue, Jan 5, 2016 at 12:25 PM, Clément Bœsch wrote: > On Sun, Jan 03, 2016 at 01:07:15PM +0100, Clément Bœsch wrote: > [...] > > This indeed LGTM, but I'm not the maintainer. > > > > OK I finally understood why it's done that way: validate_cc_data_pair() > alters the pkt data, but the decoder i

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: clean up and standardize white space

On Tue, Jan 5, 2016 at 6:24 PM, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 09:34:35PM +0100, Clément Bœsch wrote: > > On Mon, Jan 04, 2016 at 07:28:02PM -0800, Aman Gupta wrote: > > > From: Aman Gupta > > > > > > --- &

[FFmpeg-devel] [PATCH 01/10] libavcodec/ccaption_dec: fix whitespace

From: Aman Gupta --- libavcodec/ccaption_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 34a7208..12e8f1d 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -159,7 +159,7 @@ typedef

[FFmpeg-devel] [PATCH 02/10] libavcodec/ccaption_dec: fix timestamps on generated subtitles by buffering after EOC/newline commands

From: Aman Gupta before: Dialogue: 0,0:00:00.03,0:00:00.67,Default,,0,0,0,,EVERYBODY, TONIGHT WE'LL COVER Dialogue: 0,0:00:00.67,0:00:02.30,Default,,0,0,0,,EVERYBODY, TONIGHT WE'LL COVER\NTHE NEWS WE MISSED OVER THE Dialogue: 0,0:00:02.30,0:00:03.57,Default,,0,0,0,,THE NEWS

[FFmpeg-devel] [PATCH 09/10] libavcodec/ccaption_dec: default to simpler POPON mode

From: Aman Gupta the default value does not really have any effect in normal operation, as the mode command is repeated before every new caption. after seeking, it makes more sense to default to POPON since that is the more common mode. --- libavcodec/ccaption_dec.c | 5 ++--- 1 file changed, 2

[FFmpeg-devel] [PATCH 07/10] libavcodec/ass.c: increase hardcoded timestamp for infinite duration

From: Aman Gupta before this change, ffmpeg would sometimes generate invalid ASS events when dealing with mpegts streams that had a large start_time: Dialogue: 0,20:57:07.37,9:59:59.99,Default,,0,0,0,,(upbeat music playing) --- libavcodec/ass.c | 2 +- 1 file changed, 1 insertion(+), 1

[FFmpeg-devel] [PATCH 03/10] libavcodec/ccaption_dec: add calculate_duration option

From: Aman Gupta new option defaults to true, to preserve existing behavior. by flipping the option to false, subtitle events are emitted as soon as they are received and have an infinite duration. this new mode is useful for realtime decoding of closed captions so they can be display along

[FFmpeg-devel] [PATCH 06/10] libavcodec/ccaption_dec: flush screen buffer on seek

From: Aman Gupta --- libavcodec/ccaption_dec.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 424b434..423c576 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -196,6 +196,15 @@ static av_cold

[FFmpeg-devel] [PATCH 08/10] libavcodec/ccaption_dec.c: fix more whitespace

From: Aman Gupta --- libavcodec/ccaption_dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 423c576..3de16bf 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -220,7 +220,7

[FFmpeg-devel] [PATCH 04/10] libavcodec/ccaption_dec: reap_screen after flipping on EOC

From: Aman Gupta --- libavcodec/ccaption_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 9f17e77..5d4c568 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -399,9 +399,9 @@ static void

[FFmpeg-devel] [PATCH 05/10] libavcodec/ccaption_dec: combine ROLLUP modes as they are identical

From: Aman Gupta --- libavcodec/ccaption_dec.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 5d4c568..424b434 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -37,9 +37,7

[FFmpeg-devel] [PATCH 10/10] libavcodec/ccaption_dec: extract ass time base into constant

From: Aman Gupta --- libavcodec/ccaption_dec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 56b2b52..6dff761 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -30,6 +30,8

[FFmpeg-devel] [PATCH 1/3] libavcodec/ccaption_dec: rename to screen_changed to screen_reaped

From: Aman Gupta --- libavcodec/ccaption_dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 6dff761..706da16 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -158,7 +158,7

[FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: in realtime mode, emit new ASS events every 200ms

From: Aman Gupta --- libavcodec/ccaption_dec.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 706da16..737c3f6 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -159,6 +159,7 @@ typedef

[FFmpeg-devel] [PATCH 3/3] libavcodec/ccaption_dec: emit blank ASS events only in realtime mode

From: Aman Gupta --- libavcodec/ccaption_dec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 737c3f6..8e3008d 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -345,7 +345,9 @@ static

Re: [FFmpeg-devel] [PATCH 03/10] libavcodec/ccaption_dec: add calculate_duration option

0,0,0,,EVERYBODY, TONIGHT WE'LL COVER\NTHE NEWS WE MISSED OVER THE On Wed, Jan 6, 2016 at 2:37 AM, wm4 wrote: > On Tue, 5 Jan 2016 23:41:35 -0800 > Aman Gupta wrote: > > > From: Aman Gupta > > > > new option defaults to true, to preserve existing behavior. by f

Re: [FFmpeg-devel] [PATCH 04/10] libavcodec/ccaption_dec: reap_screen after flipping on EOC

. Thus, it makes sense to reap the screen *after* flipping the active screen, not *before*. The previous behavior was simply wrong, but masked by other bugs also fixed in this patchset. Aman On Tue, Jan 5, 2016 at 11:41 PM, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/cc

Re: [FFmpeg-devel] [PATCH 04/10] libavcodec/ccaption_dec: reap_screen after flipping on EOC

On Fri, Jan 8, 2016 at 2:50 AM, Anshul Maheshwari wrote: > > > On Thu, Jan 7, 2016 at 6:14 AM, Aman Gupta wrote: > >> Probably should have written a longer commit message here. The EOC >> command stands for "end of caption" aka "display buffer". It

[FFmpeg-devel] [PATCH 1/2] lavc/ccaption_dec: flush context on seek

From: Aman Gupta --- libavcodec/ccaption_dec.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index fc6431b..8bef771 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -165,6 +165,24 @@ static

[FFmpeg-devel] [PATCH 2/2] lavc/ccaption_dec: implement real_time option

From: Aman Gupta This new mode is useful for realtime decoding of closed captions so they can be display along with mpeg2 frames. Closed caption streams contain two major types of captions: - POPON captions, which are buffered off-screen and displayed only after EOC (end of caption, aka

[FFmpeg-devel] [PATCH v2 2/9] lavc/ccaption_dec: implement real_time option

From: Aman Gupta This new mode is useful for realtime decoding of closed captions so they can be display along with mpeg2 frames. Closed caption streams contain two major types of captions: - POPON captions, which are buffered off-screen and displayed only after EOC (end of caption, aka

[FFmpeg-devel] [PATCH v2 1/9] lavc/ccaption_dec: flush context on seek

From: Aman Gupta --- libavcodec/ccaption_dec.c | 21 + 1 file changed, 21 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index ca497e5..a9dfc94 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -173,6 +173,26

[FFmpeg-devel] [PATCH v2 4/9] lavc/ccaption_dec: default rollup to row 10

From: Aman Gupta This ensures that captions are written towards the bottom of the screen when tuning into mid-stream. The row will be reset on the receipt of the next PAC command. Row 10 was chosen as it corresponds to the value of "0" in a PAC (see row_map in handle_pac()). ---

[FFmpeg-devel] [PATCH v2 7/9] lavc/ccaption_dec: implement musical glyph

From: Aman Gupta This is the most commonly used character from the special north-american character set. All the non-standard charsets are "optional" according to the spec, and we currently implement none of them. This commit adds support for "♪" which very popular (and h

[FFmpeg-devel] [PATCH v2 6/9] lavc/ccaption_dec: clear all unused rows during rollup

From: Aman Gupta Sometimes rollup captions can move around the screen. This fixes "ghost" captions from below the current rollup area from continuing to be captured when a rollup moves higher up on the screen. --- libavcodec/ccaption_dec.c | 8 +--- 1 file changed, 5 insert

[FFmpeg-devel] [PATCH v2 8/9] lavc/ccaption_dec: implement positioning for closed captions

From: Aman Gupta Positioning math is based on the guidelines in https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-608 --- libavcodec/ccaption_dec.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a

[FFmpeg-devel] [PATCH v2 5/9] lavc/ccaption_dec: implement tab offset commands

From: Aman Gupta --- libavcodec/ccaption_dec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 8c913fe..50625df 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -558,6 +558,11 @@ static void

[FFmpeg-devel] [PATCH v2 3/9] fate: add test for realtime ccaption decoder

From: Aman Gupta --- tests/fate/subtitles.mak | 3 +++ tests/ref/fate/sub-cc-realtime | 42 ++ 2 files changed, 45 insertions(+) create mode 100644 tests/ref/fate/sub-cc-realtime diff --git a/tests/fate/subtitles.mak b/tests/fate/subtitles.mak

[FFmpeg-devel] [PATCH v2 9/9] fate: update sub-cc tests for subtitle positioning

From: Aman Gupta --- tests/ref/fate/sub-cc | 4 +-- tests/ref/fate/sub-cc-realtime | 60 +- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/tests/ref/fate/sub-cc b/tests/ref/fate/sub-cc index 0d5bc77..4cc02d1 100644 --- a/tests

Re: [FFmpeg-devel] [PATCH v2 1/9] lavc/ccaption_dec: flush context on seek

On Tue, Jan 12, 2016 at 5:42 PM, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/ccaption_dec.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c > index ca497e5..a9dfc94 1

Re: [FFmpeg-devel] DVB Teletext to HLS Wbvtt Subtitles

ffmpeg has a webvtt encoder and decoder already. You can use this command to convert mpeg2 closed captions into webvtt: ffmpeg -f lavfi -i 'movie=input.mpg[out0+subcc]' -map s out.vtt Aman On Mon, Jan 18, 2016 at 7:25 AM, Sébastien Cramatte wrote: > Hi, > > We are working on an IPTv project

Re: [FFmpeg-devel] [PATCH 3/9] avcodec/videotoolbox: h264 decoder on iOS is unable to decode interlaced video

On Tue, Sep 26, 2017 at 4:20 AM Carl Eugen Hoyos wrote: > 2017-09-26 2:36 GMT+02:00 Aman Gupta : > > > > > + case kCMVideoCodecType_H264 : { > > > + H264Context *h = avctx->priv_data; > > > + if (TARGET_OS_IPHONE && h->ps.sps->f

[FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pids option

From: Aman Gupta Allows the user to skip streams that are not advertised in the PMT. --- libavformat/mpegts.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 629631f60a..5464f48a8d 100644 --- a/libavformat/mpegts.c

[FFmpeg-devel] [PATCH] ffprobe: fix SEGV when new streams are added

From: Aman Gupta --- fftools/ffprobe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 8b2a18b6b1..544786ec72 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2371,11 +2371,11 @@ static int read_interval_packets

[FFmpeg-devel] [PATCH] avformat/mpegts: skip non-PMT tids earlier

From: Aman Gupta This mimics the logic flow in all the other callbacks (pat_cb, sdt_cb, m4sl_cb), and avoids calling skip_identical() for non PMT_TID packets. Since skip_identical modifies internal state like MpegTSSectionFilter.last_ver, this change prevents unnecessary reprocessing on some

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pids option

On Tue, May 8, 2018 at 12:54 PM, Aman Gupta wrote: > From: Aman Gupta > > Allows the user to skip streams that are not advertised in the PMT. > Disregard this patch. It combines two different things (skip pmt, skip streams without pmt) into one badly named option. Aman > ---

[FFmpeg-devel] [PATCH 2/2] avformat/mpegts: reindent after last change

From: Aman Gupta Signed-off-by: Aman Gupta --- libavformat/mpegts.c | 70 ++-- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 3c9f9421cb..9c09819531 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 1/2] avformat/mpegts: parse sections with multiple tables

From: Aman Gupta Fixes PMT parsing in some mpegts streams which contain multiple tables within the PMT pid. Previously, the parser assumed only one table was present in each packet, and discarded the rest of the section data after attempting to parse the first table. A similar issue was

[FFmpeg-devel] [PATCH 1/2] avformat/mpegtsenc: set AVFMT_NODIMENSIONS

From: Aman Gupta This allows remuxing streams from one mpegts container to another, without requiring avformat_find_stream_info() (or using `ffmpeg -probesize 32` on the cli). --- libavformat/mpegtsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpegtsenc.c

[FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: set AVFMT_NODIMENSIONS

From: Aman Gupta Same as previous commit but for mpegts inside HLS. --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index c27a66ea79..9c06551ea6 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c

Re: [FFmpeg-devel] avformat/mpegts: set AV_DISPOSITION_DESCRIPTIONS for OIPF cases

On Thu, May 10, 2018 at 1:46 AM Łukasz Krzciuk wrote: > Lets skip a testcase. It will be not easy to me to prepare it. It should be simple to extract a small sample containing the PMT. If you link some larger samples I can help extract the relevant bytes for test case. Aman > > Regards, > >

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mp3dec: require 90% of a file to be mp3 if only 1 mp3 frame is found in sequence

On Sat, May 12, 2018 at 9:33 AM, Michael Niedermayer wrote: > This eliminates several low score detections of non mp3 files > Thanks for working on this. Spurious mp3 detection has been a real headache. Aman > > Signed-off-by: Michael Niedermayer > --- > libavformat/mp3dec.c | 2 +- > 1 fil

[FFmpeg-devel] [PATCH] avformat/mpegts: add merge_pmt_versions option

From: Aman Gupta This new optional flag makes it easier to deal with mpegts samples where the PMT is updated and elementary streams move to different PIDs in the middle of playback. Previously, new AVStreams were created per PID, and it was up to the user to figure out which streams had

[FFmpeg-devel] [PATCH] avformat/mpegts: tag video streams with still images

From: Aman Gupta Parses the video_stream_descriptor (H.222 2.6.2) to look for the still_picture_flag. This is exposed to the user via a new AV_DISPOSITION_STILL_IMAGE. See for example https://tmm1.s3.amazonaws.com/music-choice.ts, whose video stream only updates every ~6 seconds. Signed-off-by

[FFmpeg-devel] [PATCH v2] avformat/mpegts: add merge_pmt_versions option

From: Aman Gupta This new optional flag makes it easier to deal with mpegts samples where the PMT is updated and elementary streams move to different PIDs in the middle of playback. Previously, new AVStreams were created per PID, and it was up to the user to figure out which streams had

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add merge_pmt_versions option

On Tue, May 15, 2018 at 5:12 AM, Michael Niedermayer wrote: > On Mon, May 14, 2018 at 03:54:01PM -0700, Aman Gupta wrote: > > From: Aman Gupta > > > > This new optional flag makes it easier to deal with mpegts > > samples where the PMT is updated and elementary st

[FFmpeg-devel] [PATCH] ffprobe: add missing AV_DISPOSITION flags

From: Aman Gupta --- fftools/ffprobe.c | 2 ++ tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +- tests/ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +- tests/ref/fate/concat-demuxer-simple1-lavf-mxf| 4 ++-- tests

[FFmpeg-devel] [PATCH] avformat: add skip_estimate_duration_from_pts

From: Aman Gupta For seekable mpegts streams, duration is calculated from pts by seeking to the end of the file for a pts and subtracting the initial pts to compute a duration. This can be expensive in terms of added latency during probe, especially when streaming over a network. This new

Re: [FFmpeg-devel] [PATCH v2] avformat/mpegts: add merge_pmt_versions option

On Tue, May 15, 2018 at 12:23 PM, Aman Gupta wrote: > From: Aman Gupta > > This new optional flag makes it easier to deal with mpegts > samples where the PMT is updated and elementary streams move > to different PIDs in the middle of playback. > > Previously, new AVStreams

Re: [FFmpeg-devel] FIX: HLS Discontinuity / Non-Monotonous DTS

On Tue, Mar 20, 2018 at 7:46 AM, Joe Koberg wrote: > On Fri, Mar 16, 2018 at 11:14 AM, Carl Eugen Hoyos > wrote: > > 2018-03-16 16:07 GMT+01:00, Joe Koberg : > >> On Fri, Mar 16, 2018 at 10:48 AM, Carl Eugen Hoyos > >> wrote: > >>> > >>> Is the issue only reproducible if you use hls input or is

[FFmpeg-devel] [PATCH] avformat/hls: tag as AVFMT_TS_DISCONT

From: Aman Gupta HLS streams can contain discontinuities. Mark the format as such. This triggers various discontinuity fixes in lavf/utils.c and fftools Signed-off-by: Aman Gupta --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b

Re: [FFmpeg-devel] [PATCH] avformat/hls: tag as AVFMT_TS_DISCONT

On Wed, May 16, 2018 at 11:14 AM, wm4 wrote: > On Wed, 16 May 2018 10:17:58 -0700 > Aman Gupta wrote: > > > From: Aman Gupta > > > > HLS streams can contain discontinuities. Mark the format as such. > > > > This triggers various discontinuity fixes in

[FFmpeg-devel] [PATCH v2] avcodec/videotoolbox: fix decoding of some hevc videos

From: Aman Gupta See https://s3.amazonaws.com/tmm1/videotoolbox/germany-hevc-zdf.ts This moves the hw_frames_ctx reference from the AVFrame to a new VTHWFrame which now holds both the CVPixelBufferRef and the AVBuffer. Previously we would set the hw_frames_context on the AVFrame directly, but

[FFmpeg-devel] [PATCH v3 3/3] avformat/mpegts: add merge_pmt_versions option

From: Aman Gupta This new optional flag makes it easier to deal with mpegts samples where the PMT is updated and elementary streams move to different PIDs in the middle of playback. Previously, new AVStreams were created per PID, and it was up to the user to figure out which streams had

[FFmpeg-devel] [PATCH v3 1/3] avformat: update AVProgram to keep track of version and changes

From: Aman Gupta Signed-off-by: Aman Gupta --- doc/APIchanges | 5 + libavformat/avformat.h | 3 ++- libavformat/utils.c| 1 + libavformat/version.h | 2 +- 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index befa58c84a

[FFmpeg-devel] [PATCH v3 2/3] avformat/mpegts: keep track of AVProgram.pmt_version and set AV_PROGRAM_CHANGED on version updates

From: Aman Gupta This can be used to detect changes to the streams in an AVProgram Signed-off-by: Aman Gupta --- libavformat/mpegts.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index fc9bb3940e

[FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

From: Aman Gupta Some filtered mpegts streams may erroneously include PMTs for programs that are not advertised in the PAT. This confuses ffmpeg and most players because multiple audio/video streams are created and it is unclear which ones actually contain data. See for example https://tmm1.s3

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

On Thu, May 17, 2018 at 5:04 PM, Aman Gupta wrote: > From: Aman Gupta > > Some filtered mpegts streams may erroneously include PMTs for programs > that are not advertised in the PAT. This confuses ffmpeg and most > players because multiple audio/video streams are created and

<    1   2   3   4   5   6   >