On Thu, Feb 15, 2018 at 12:33 PM, Stefan Pöschel <basic.mas...@gmx.de> wrote:
> Am 15.02.2018 um 20:52 schrieb Aman Gupta: > > Patch looks reasonable to me. > > Great! > > > It might also be worth surfacing when the audio descriptor flags contain > > mix_type=0, as this indicates a dependent stream which cannot be played > > standalone. > > Yes, this seems to be useful, as both mixing types are in real-world use > by broadcasters. Though to be precise, also with mix_type 0, the stream > can be played standalone. It just will contain only the audio > description itself, not mixed with the original soundtrack. > > I would however welcome if adding the flag could be done by someone > else, as I don't have deep knowledge in FFmpeg's internals and any > implications of adding a new field (which seems to be necessary here). > One option would be to re-use an existing flag. AV_DISPOSITION_CLEAN_EFFECTS seems to have a similar meaning, but is already used for a different purpose in mpegts.c Another option is AV_DISPOSITION_DESCRIPTIONS which has a similar meaning as well. Or, maybe it's best to create a new AV_DISPOSITION_* for this purpose. I'm happy to write a patch for this if we can decide on whether using AV_DISPOSITION_DESCRIPTIONS makes sense, or come up with a good name for a new flag. Thanks, Aman > > Regards, > Stefan > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
