From: softworkz
Reviewed-by: Stefano Sabatini
Signed-off-by: softworkz
---
fftools/textformat/avtextformat.c | 92 +++---
fftools/textformat/avtextformat.h | 20 +++
fftools/textformat/avtextwriters.h | 11 ++--
fftools/textformat/tf_compact.c| 91
Shortest cover letter for my longest-running FFmpeg patchset:
* Apply
* Build
* Add the "-sg" switch to any FFmpeg command line
* Press 'q' when you don't want to wait
SG = Show Graph
Documentation and examples can be found here:
https://github.com/softworkz/ffmpeg_output_apis/wiki
Versio
From: softworkz
Also change writer_printf signature in AVTextWriter to use va_list,
so that it can be called by the new function writer_printf()
in tf_internal.h.
Reviewed-by: Stefano Sabatini
Signed-off-by: softworkz
---
fftools/textformat/avtextwriters.h | 2 +-
fftools/textformat/tf_compa
From: softworkz
Perform multiple improvements to increase code robustness.
In particular:
- favor unsigned counters for loops
- add missing checks
- avoid possible leaks
- move variable declarations to inner scopes when feasible
- provide explicit type-casting when needed
Signed-off-by: softwork
From: softworkz
This allows future addition of options without
changes to the signature of avtext_context_open().
Reviewed-by: Stefano Sabatini
Signed-off-by: softworkz
---
fftools/ffprobe.c | 13 +
fftools/textformat/avtextformat.c | 21 -
ffto
From: softworkz
Signed-off-by: softworkz
---
fftools/textformat/avtextformat.h | 1 -
fftools/textformat/avtextwriters.h | 5 -
2 files changed, 6 deletions(-)
diff --git a/fftools/textformat/avtextformat.h
b/fftools/textformat/avtextformat.h
index 86feb9d09d..c61dca159f 100644
--- a/fft
From: softworkz
Signed-off-by: softworkz
---
fftools/textformat/avtextformat.c | 14 +++---
fftools/textformat/avtextformat.h | 6 +++---
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/fftools/textformat/avtextformat.c
b/fftools/textformat/avtextformat.c
index 32cec9
From: softworkz
Instead of initializing a new BPrint in each iteration of
the loop, re-use the same BPrint struct and just clear it
for each iteration.
Signed-off-by: softworkz
---
fftools/textformat/avtextformat.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
From: softworkz
Compression requires zlib to be available, otherwise resources will
be included uncompressed - in either case via BIN2C.
It can also be disabled via
./configure --disable-resource-compression
Size figures:
graph.css 7752
graph.css.min 6655 (css is always minified)
From: softworkz
Make this function work analog to avtext_print_string() which already
has a flags parameter.
Signed-off-by: softworkz
---
fftools/ffprobe.c | 2 +-
fftools/textformat/avtextformat.c | 24 ++--
fftools/textformat/avtextformat.h | 2 +-
3 fil
From: softworkz
to allow filtergraph printing to access the information.
Signed-off-by: softworkz
---
fftools/ffmpeg_filter.c | 190 +---
fftools/ffmpeg_filter.h | 234
2 files changed, 235 insertions(+), 189 deletions(-)
cr
From: softworkz
Signed-off-by: softworkz
---
doc/APIchanges | 3 +++
libavfilter/avfilter.c | 9 +
libavfilter/avfilter.h | 12
3 files changed, 24 insertions(+)
diff --git a/doc/APIchanges b/doc/APIchanges
index 75d66f87f3..d0869561f3 100644
--- a/doc/APIchanges
From: softworkz
Reviewed-by: Stefano Sabatini
Signed-off-by: softworkz
---
fftools/textformat/tf_internal.h | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/fftools/textformat/tf_internal.h b/fftools/textformat/tf_internal.h
index 362a4cbc38..484886b7a7 100644
--- a/fft
From: softworkz
The key benefits are:
- Different to other graph printing methods, this is outputting:
- all graphs with runtime state
(including auto-inserted filters)
- each graph with its inputs and outputs
- all filters with their in- and output pads
- all connections between all
From: softworkz
Signed-off-by: softworkz
---
fftools/ffmpeg_mux.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fftools/ffmpeg_mux.h b/fftools/ffmpeg_mux.h
index f41f2c18fa..4ca8ab73a4 100644
--- a/fftools/ffmpeg_mux.h
+++ b/fftools/ffmpeg_mux.h
@@ -123,7 +123,7 @@ typedef
From: softworkz
remember this: -sg <= show-graph
Signed-off-by: softworkz
---
doc/ffmpeg.texi | 4 +
fftools/Makefile | 1 +
fftools/ffmpeg.c | 2 +-
fftools/ffmpeg.h | 1 +
fftools/ffmpeg_filter.c | 2 +-
fftools/ffmpeg_opt.c
> -Original Message-
> From: ffmpeg-devel On Behalf Of softworkz .
> Sent: Dienstag, 29. April 2025 01:24
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface
>
>
>
> > -Original Message-
> > From: ffmpeg-d
From: Shaun Loo
This is a part of Google Summer of Code 2023
Co-authored-by: Nuo Mi
---
libavcodec/x86/h26x/h2656_sao.asm | 301
libavcodec/x86/h26x/h2656_sao_10bit.asm | 301
libavcodec/x86/hevc/sao.asm | 278 +---
---
libavcodec/x86/vvc/dsp_init.c | 48 +--
1 file changed, 29 insertions(+), 19 deletions(-)
diff --git a/libavcodec/x86/vvc/dsp_init.c b/libavcodec/x86/vvc/dsp_init.c
index dc833bb0f1..bb68ba0b1e 100644
--- a/libavcodec/x86/vvc/dsp_init.c
+++ b/libavcodec/x86/vvc
From: Shaun Loo
This is a part of Google Summer of Code 2023
Co-authored-by: Nuo Mi
---
libavcodec/x86/h26x/h2656_sao.asm | 301
libavcodec/x86/h26x/h2656_sao_10bit.asm | 301
libavcodec/x86/hevc/sao.asm | 278 +---
From: Shaun Loo
This is a part of Google Summer of Code 2023
Co-authored-by: Nuo Mi
---
libavcodec/x86/h26x/h2656_sao.asm | 8 +--
libavcodec/x86/vvc/Makefile | 2 +
libavcodec/x86/vvc/dsp_init.c | 41 +++
libavcodec/x86/vvc/sao.asm| 73 +++
liba
---
libavcodec/x86/vvc/dsp_init.c | 48 +--
1 file changed, 29 insertions(+), 19 deletions(-)
diff --git a/libavcodec/x86/vvc/dsp_init.c b/libavcodec/x86/vvc/dsp_init.c
index dc833bb0f1..bb68ba0b1e 100644
--- a/libavcodec/x86/vvc/dsp_init.c
+++ b/libavcodec/x86/vvc
From: Shaun Loo
This is a part of Google Summer of Code 2023
Co-authored-by: Nuo Mi
---
libavcodec/x86/hevc/sao_10bit.asm | 100 ++
1 file changed, 48 insertions(+), 52 deletions(-)
diff --git a/libavcodec/x86/hevc/sao_10bit.asm
b/libavcodec/x86/hevc/sao_10bit.asm
From: Shaun Loo
This is a part of Google Summer of Code 2023
AVX2:
- vvc_sao.sao_band [OK]
- vvc_sao.sao_edge [OK]
checkasm: all 54 tests passed
vvc_sao_band_8_8_c:157.4 ( 1.00x)
vvc_sao_band_8_8_avx2: 30.7 ( 5.12x)
vvc_sao_b
Hi Martin,
Great, it works!
HEVC is included in v2.
Thank you!
On Sat, May 3, 2025 at 4:45 AM Martin Storsjö wrote:
> On Fri, 2 May 2025, Nuo Mi wrote:
>
> > On Fri, May 2, 2025 at 3:49 PM Martin Storsjö wrote:
> > On Fri, 2 May 2025, Nuo Mi wrote:
> >
> > > From: Shaun Loo
> >
---
tests/checkasm/hevc_sao.c | 45 +--
1 file changed, 20 insertions(+), 25 deletions(-)
diff --git a/tests/checkasm/hevc_sao.c b/tests/checkasm/hevc_sao.c
index f597eb5254..37f6ba8c5c 100644
--- a/tests/checkasm/hevc_sao.c
+++ b/tests/checkasm/hevc_sao.c
@@ -
---
tests/checkasm/hevc_sao.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/checkasm/hevc_sao.c b/tests/checkasm/hevc_sao.c
index ad47423f10..f597eb5254 100644
--- a/tests/checkasm/hevc_sao.c
+++ b/tests/checkasm/hevc_sao.c
@@ -119,21 +119,21 @@ static vo
Hello everybody,
I have an organizational question that I cannot quite figure out how to do it
right:
Whether and when to add 'Reviewed-by: xxx' to a commit message?
Specific example: The “execution graph printing” patchset:
Andreas had reviewed the patchset initially. I addressed the mention
On 03/05/2025 04:39, Russell Greene wrote:
Is this documented anywhere? Should I maybe have a fixed sized stack
buffer and fallback to an allocation if it's just a rule of thumb that
it'll be less than some known small number. I just somehow doubt this
is in the vulkan spec or any sort of guarant
> vkGetPhysicalDeviceToolPropertiesEXT(dev, nb, array)
> If pToolProperties is NULL, then the number of tools currently active on
> physicalDevice is returned in pToolCount. Otherwise, pToolCount must
> point to a variable set by the application to the number of elements in
> the pToolProperties ar
> > If we're OK with a practical "we don't support drivers with more than
> > X modifiers because we doubt it'll ever exist" then that's a valid
> > answer as well.
> If that's your concern, just fetch all info for all modifiers in the
> init function.
Works for me. I'm new to ffmpeg devel, I assu
Now realizing that there's not really a way to just query all
modifiers, you'd actually need to query all formats for their
modifiers...
Options as I see it are:
1. in init(), create a table of all (vk_format, modifier) pairs and
the `VkDrmFormatModifierPropertiesEXT` information about the pair fo
---
libavformat/oggdec.c | 4
libavformat/oggparseflac.c | 28 --
libavformat/oggparseopus.c | 11 +
libavformat/oggparsevorbis.c | 11 +++--
tests/ref/fate/ogg-flac-chained-meta.txt | 2 --
---
libavformat/oggdec.c | 22 ++
libavformat/oggdec.h | 6 ++
2 files changed, 20 insertions(+), 8 deletions(-)
diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c
index 5339fdd32c..9baf8040a9 100644
--- a/libavformat/oggdec.c
+++ b/libavformat/oggdec.c
@@ -605,20 +
These patches remove the ogg header packets from secondary chained ogg
streams from the demuxer.
To do so, the packet demuxing function is modified to explicitely tell
the demuxer when skip header packets
Also, the opus packet demuxing function is adapted to properly copy extra
data from the new
The maximum number of tile columns/rows adds an extra constraint on
the minimum tile width/height for large frames (over 5120 width or
2560 height).
---
libavcodec/apv_decode.c | 2 +-
libavcodec/cbs_apv_syntax_template.c | 14 ++
2 files changed, 11 insertions(+), 5 dele
Halt tile component decoding at the first entropy error (this will be a
desync and is not recoverable). If any tile components contain errors
then discard the frame unless the output-corrupt flag is set.
Also fixes CID 1646764, which is the error case where the tile component
is too large for get
Fixes CID 1646769.
---
libavcodec/cbs_apv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/cbs_apv.c b/libavcodec/cbs_apv.c
index e7dd04825c..ebf57d3bbb 100644
--- a/libavcodec/cbs_apv.c
+++ b/libavcodec/cbs_apv.c
@@ -230,14 +230,14 @@ static int cbs_apv_split_f
It was possible for the buffer pointers for the last tile to go over the
end of the unit buffer leading to a read overflow during decode of the
macroblock layer. Check all tile component sizes to prevent this case
and also catch related tile size mismatch errors earlier.
---
libavcodec/cbs_apv_sy
---
libavcodec/apv_entropy.c | 16
1 file changed, 16 insertions(+)
diff --git a/libavcodec/apv_entropy.c b/libavcodec/apv_entropy.c
index 00e0b4fbdf..a5648c09b4 100644
--- a/libavcodec/apv_entropy.c
+++ b/libavcodec/apv_entropy.c
@@ -84,6 +84,14 @@ static unsigned int apv_read_v
---
libavcodec/apv_decode.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavcodec/apv_decode.c b/libavcodec/apv_decode.c
index b1e1db7d64..2a59c9b25d 100644
--- a/libavcodec/apv_decode.c
+++ b/libavcodec/apv_decode.c
@@ -377,7 +377,7 @@ static int apv_decode_frame(A
On 5/3/2025 2:55 PM, Mark Thompson wrote:
---
libavcodec/apv_decode.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavcodec/apv_decode.c b/libavcodec/apv_decode.c
index b1e1db7d64..2a59c9b25d 100644
--- a/libavcodec/apv_decode.c
+++ b/libavcodec/apv_decode.c
@@
On 5/3/2025 2:55 PM, Mark Thompson wrote:
+fail:
+av_log(avctx, AV_LOG_VERBOSE,
+ "Decode error in tile %d component %d.\n",
+ tile_index, comp_index);
+atomic_fetch_add(&apv->tile_errors, 1);
atomic_fetch_add_explicit(&apv->tile_errors, 1, memory_order_relaxed);
Yo
On 03/05/2025 17:01, Russell Greene wrote:
vkGetPhysicalDeviceToolPropertiesEXT(dev, nb, array)
If pToolProperties is NULL, then the number of tools currently active on
physicalDevice is returned in pToolCount. Otherwise, pToolCount must
point to a variable set by the application to the number of
Hi
On Sat, May 03, 2025 at 08:22:44AM +, softworkz wrote:
> From: softworkz
>
> The key benefits are:
>
> - Different to other graph printing methods, this is outputting:
> - all graphs with runtime state
> (including auto-inserted filters)
> - each graph with its inputs and outputs
From: softworkz
Reviewed-by: Stefano Sabatini
Signed-off-by: softworkz
---
fftools/textformat/avtextformat.c | 92 +++---
fftools/textformat/avtextformat.h | 20 +++
fftools/textformat/avtextwriters.h | 11 ++--
fftools/textformat/tf_compact.c| 91
From: softworkz
Signed-off-by: softworkz
---
fftools/textformat/avtextformat.h | 1 -
fftools/textformat/avtextwriters.h | 5 -
2 files changed, 6 deletions(-)
diff --git a/fftools/textformat/avtextformat.h
b/fftools/textformat/avtextformat.h
index 86feb9d09d..c61dca159f 100644
--- a/fft
From: softworkz
Perform multiple improvements to increase code robustness.
In particular:
- favor unsigned counters for loops
- add missing checks
- avoid possible leaks
- move variable declarations to inner scopes when feasible
- provide explicit type-casting when needed
Signed-off-by: softwork
Shortest cover letter for my longest-running FFmpeg patchset:
* Apply
* Build
* Add the "-sg" switch to any FFmpeg command line
* Press 'q' when you don't want to wait
SG = Show Graph
Documentation and examples can be found here:
https://github.com/softworkz/ffmpeg_output_apis/wiki
Versio
> -Original Message-
> From: ffmpeg-devel On Behalf Of Michael
> Niedermayer
> Sent: Sonntag, 4. Mai 2025 01:58
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v9 14/15] fftools/graphprint: Add execution
> graph printing
>
> Hi
>
> On Sat, May 03
From: softworkz
Also change writer_printf signature in AVTextWriter to use va_list,
so that it can be called by the new function writer_printf()
in tf_internal.h.
Reviewed-by: Stefano Sabatini
Signed-off-by: softworkz
---
fftools/textformat/avtextwriters.h | 2 +-
fftools/textformat/tf_compa
From: softworkz
to allow filtergraph printing to access the information.
Signed-off-by: softworkz
---
fftools/ffmpeg_filter.c | 190 +---
fftools/ffmpeg_filter.h | 234
2 files changed, 235 insertions(+), 189 deletions(-)
cr
From: softworkz
This allows future addition of options without
changes to the signature of avtext_context_open().
Reviewed-by: Stefano Sabatini
Signed-off-by: softworkz
---
fftools/ffprobe.c | 13 +
fftools/textformat/avtextformat.c | 21 -
ffto
From: softworkz
Reviewed-by: Stefano Sabatini
Signed-off-by: softworkz
---
fftools/textformat/tf_internal.h | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/fftools/textformat/tf_internal.h b/fftools/textformat/tf_internal.h
index 362a4cbc38..484886b7a7 100644
--- a/fft
From: softworkz
Make this function work analog to avtext_print_string() which already
has a flags parameter.
Signed-off-by: softworkz
---
fftools/ffprobe.c | 2 +-
fftools/textformat/avtextformat.c | 24 ++--
fftools/textformat/avtextformat.h | 2 +-
3 fil
From: softworkz
Signed-off-by: softworkz
---
fftools/textformat/avtextformat.c | 14 +++---
fftools/textformat/avtextformat.h | 6 +++---
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/fftools/textformat/avtextformat.c
b/fftools/textformat/avtextformat.c
index 32cec9
From: softworkz
Signed-off-by: softworkz
---
doc/APIchanges | 3 +++
libavfilter/avfilter.c | 9 +
libavfilter/avfilter.h | 12
3 files changed, 24 insertions(+)
diff --git a/doc/APIchanges b/doc/APIchanges
index 75d66f87f3..d0869561f3 100644
--- a/doc/APIchanges
From: softworkz
Instead of initializing a new BPrint in each iteration of
the loop, re-use the same BPrint struct and just clear it
for each iteration.
Signed-off-by: softworkz
---
fftools/textformat/avtextformat.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
From: softworkz
The key benefits are:
- Different to other graph printing methods, this is outputting:
- all graphs with runtime state
(including auto-inserted filters)
- each graph with its inputs and outputs
- all filters with their in- and output pads
- all connections between all
From: softworkz
Compression requires zlib to be available, otherwise resources will
be included uncompressed - in either case via BIN2C.
It can also be disabled via
./configure --disable-resource-compression
Size figures:
graph.css 7752
graph.css.min 6655 (css is always minified)
From: softworkz
remember this: -sg <= means Show Graph
Signed-off-by: softworkz
---
doc/ffmpeg.texi | 4 +
fftools/Makefile | 1 +
fftools/ffmpeg.c | 2 +-
fftools/ffmpeg.h | 1 +
fftools/ffmpeg_filter.c | 2 +-
fftools/ffmpeg_o
From: softworkz
Signed-off-by: softworkz
---
fftools/ffmpeg_mux.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fftools/ffmpeg_mux.h b/fftools/ffmpeg_mux.h
index f41f2c18fa..4ca8ab73a4 100644
--- a/fftools/ffmpeg_mux.h
+++ b/fftools/ffmpeg_mux.h
@@ -123,7 +123,7 @@ typedef
No reason to build the exact same table once per decoding thread.
Signed-off-by: James Almer
---
libavcodec/apv_decode.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/libavcodec/apv_decode.c b/libavcodec/apv_decode.c
index b1e1db7d64..b1c59fc873 100644
-
63 matches
Mail list logo
