Re: [FFmpeg-devel] APV codec with OpenAPV support

2025-04-22 Thread Kieran Kunhya via ffmpeg-devel
On Tue, 22 Apr 2025, 09:44 , wrote: > Hi, > > > > I'm Dariusz from Samsung Electronics, you can know me from last VDD in > Korea, I was presenting APV. > > > > I'm glad that Mark created native APV decoder. As you might know we're also > working on APV implementation for FFmpeg. > > Our approach

[FFmpeg-devel] [PATCH v4 1/3] lavc/hashtable: create generic robin hood hash table

2025-04-22 Thread Emma Worley
Adds a generic hash table with the DXV encoder as an initial use case. Signed-off-by: Emma Worley --- libavcodec/Makefile | 2 + libavcodec/hashtable.c | 192 +++ libavcodec/hashtable.h | 91 + libavcodec/tests/hashtable.c |

[FFmpeg-devel] [PATCH v4 3/3] lavc/dxvenc: improve compatibility with Resolume products

2025-04-22 Thread Emma Worley
Improves compatibility with Resolume products by adding an additional hashtable for DXT color+LUT combinations, and padding the DXT texture dimensions to the next largest multiple of 16. Produces identical packets to Resolume Alley in manual tests. Signed-off-by: Emma Worley --- libavcodec/dxven

[FFmpeg-devel] [PATCH v4 2/3] lavc/dxvenc: migrate DXT1 encoder to lavc hashtable

2025-04-22 Thread Emma Worley
Offers a modest performance gain due to the switch from naive linear probling to robin hood. Signed-off-by: Emma Worley --- libavcodec/dxvenc.c | 121 1 file changed, 33 insertions(+), 88 deletions(-) diff --git a/libavcodec/dxvenc.c b/libavcodec/dxv

Re: [FFmpeg-devel] [PATCH v4 3/3] lavc/dxvenc: improve compatibility with Resolume products

2025-04-22 Thread Andreas Rheinhardt
Emma Worley: > Improves compatibility with Resolume products by adding an additional > hashtable for DXT color+LUT combinations, and padding the DXT texture > dimensions to the next largest multiple of 16. Produces identical > packets to Resolume Alley in manual tests. > > Signed-off-by: Emma Worl

[FFmpeg-devel] APV codec with OpenAPV support

2025-04-22 Thread d.frankiewic
Hi, I'm Dariusz from Samsung Electronics, you can know me from last VDD in Korea, I was presenting APV. I'm glad that Mark created native APV decoder. As you might know we're also working on APV implementation for FFmpeg. Our approach is different from yours but they can exist in FFmpeg

Re: [FFmpeg-devel] [PATCH v4 3/3] lavc/dxvenc: improve compatibility with Resolume products

2025-04-22 Thread Emma Worley
On Tue, Apr 22, 2025 at 1:00 AM Andreas Rheinhardt wrote: > Did you try to avoid the above by modifying > ff_texturedsp_exec_compress_threads()? I considered it but adding support to substitute in padding seemed like a rather large refactor. ___ ffmpeg-

Re: [FFmpeg-devel] [PATCH v4 1/3] lavc/hashtable: create generic robin hood hash table

2025-04-22 Thread Nicolas George
Emma Worley (HE12025-04-22): > Adds a generic hash table with the DXV encoder as an initial use case. Hi. This code is already really good. I have some local remarks that will not require a lot of work from you and make it better. And I have some global remarks that would require a lot of work fr

[FFmpeg-devel] [PATCH] aarch64/h26x: Add put_hevc_pel_bi_w_pixels

2025-04-22 Thread Zhao Zhili
From: Zhao Zhili On rpi5 (A76): put_hevc_pel_bi_w_pixels4_8_c: 90.0 ( 1.00x) put_hevc_pel_bi_w_pixels4_8_neon: 34.1 ( 2.64x) put_hevc_pel_bi_w_pixels6_8_c: 188.3 ( 1.00x) put_hevc_pel_bi_w_pixels6_8_neon:

Re: [FFmpeg-devel] [RFC PATCH 2/2] ffmpeg_demux: make readrate stall warning input-specific

2025-04-22 Thread Gyan Doshi
On 2025-04-23 02:26 am, Marvin Scholz wrote: Given the readrate catchup is input-specific, it seems to make sense to also warn on a per-input demux basis. We want to warn once each time reading is resumed but only for the first stream resumption. That's the case right now. With this change,

[FFmpeg-devel] [PATCH] avfilter: add PCM dumping between filters for audio debugging

2025-04-22 Thread 一只大 肥猫
This patch introduces PCM dumping support between AVFilter links, intended for audio debugging. It adds a configure-time option `--dumpdir=PATH` to specify the output directory for raw PCM data (default: /tmp/). Two commands are exposed to control dumping: - dump_raw_start - dump_raw_stop

[FFmpeg-devel] Unable to register on trac.ffmpeg.org

2025-04-22 Thread Rafael Laboissière
Hi, I apologize if this is not the appropriate mailing list for my question, but I am having trouble in registering on trac.ffmpeg.org. I filled out the form but never received the email with the verification token. Does anyone know how to fix this? Best, Rafael Laboissière

Re: [FFmpeg-devel] [PATCH v4 1/3] lavc/hashtable: create generic robin hood hash table

2025-04-22 Thread Emma Worley
Perhaps I can add a `mode` enum parameter to the FFHashtableContext to control behavior? Then we can benchmark different behaviors on a per-use-case basis. On Tue, Apr 22, 2025 at 10:24 AM Nicolas George wrote: > > Emma Worley (HE12025-04-22): > > Adds a generic hash table with the DXV encoder as

[FFmpeg-devel] [PATCH 1/2] ffmpeg_demux: init resume_warn variable

2025-04-22 Thread Marvin Scholz
Fixes an uninitialized read introduced with 6232f416b172358c9dd82462037953f02743df27 Fix CID1643162 Uninitialized scalar variable --- fftools/ffmpeg_demux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index cb4318c75b..6e01ef

[FFmpeg-devel] [RFC PATCH 2/2] ffmpeg_demux: make readrate stall warning input-specific

2025-04-22 Thread Marvin Scholz
Given the readrate catchup is input-specific, it seems to make sense to also warn on a per-input demux basis. --- fftools/ffmpeg_demux.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 6e01efc420..1f7ec20a43 100644 --

[FFmpeg-devel] [PATCH 1/2] tests: Add stream dump test API util, use it to dump stream data for chained ogg/{vorbis, opus, flac} streams.

2025-04-22 Thread Romain Beauxis
--- tests/Makefile | 4 + tests/api/Makefile | 2 +- tests/api/api-dump-stream-meta-test.c | 177 + tests/fate/ogg-flac.mak| 11 ++ tests/fate/ogg-opus.mak| 11 ++ tests/fate/

[FFmpeg-devel] [PATCH 0/2] Remove chained ogg stream header packets from demuxer.

2025-04-22 Thread Romain Beauxis
These patches remove the ogg header packets from secondary chainged ogg streams from the demuxer. First, a test utility is added to track what is currently happening with chained streams. Then the changes are introduced: the packet demuxing function is used to explicitely tell the demuxer to skip

[FFmpeg-devel] [PATCH 2/2] ogg/{vorbis, flac, opus}: Remove header packets from subsequent ogg streams from the demuxer output.

2025-04-22 Thread Romain Beauxis
--- libavformat/oggdec.c | 26 ++-- libavformat/oggdec.h | 6 + libavformat/oggparseflac.c | 28 -- libavformat/oggparseopus.c | 12 ++ libavformat/oggparsevorbis.c

[FFmpeg-devel] [PATCH] avformat/iamfdec: Check side_substream_id before use

2025-04-22 Thread Michael Niedermayer
Fixes: poc-iamf-2025-04 Found-by: 苏童 <220235...@seu.edu.cn> Signed-off-by: Michael Niedermayer --- libavformat/iamfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/iamfdec.c b/libavformat/iamfdec.c index 0f273bdd438..3a6276dcdea 100644 --- a/libavformat/iamfd

[FFmpeg-devel] [PATCH 1/2] postproc/postprocess_template: Fix reading uninitialized pixels in dering_C()

2025-04-22 Thread Michael Niedermayer
This issue was found through the new blocktest Signed-off-by: Michael Niedermayer --- libpostproc/postprocess_altivec_template.c | 2 +- libpostproc/postprocess_template.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libpostproc/postprocess_altivec

Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets

2025-04-22 Thread Marton Balint
On Tue, 22 Apr 2025, Gyan Doshi wrote: On 2025-04-22 02:22 am, softworkz . wrote: -Original Message- From: ffmpeg-devel On Behalf Of Marton Balint Sent: Montag, 21. April 2025 22:18 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avforma

Re: [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_internal: Use ac_default_item_name

2025-04-22 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Montag, 21. April 2025 19:31 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_internal: Use > ac_default_item_name > > On date Sunday 2025

Re: [FFmpeg-devel] [PATCH v4 1/3] lavc/hashtable: create generic robin hood hash table

2025-04-22 Thread Nicolas George
Emma Worley (HE12025-04-22): > Adds a generic hash table with the DXV encoder as an initial use case. > > Signed-off-by: Emma Worley > --- > libavcodec/Makefile | 2 + > libavcodec/hashtable.c | 192 +++ > libavcodec/hashtable.h | 91 +

Re: [FFmpeg-devel] [PATCH v4 1/3] lavc/hashtable: create generic robin hood hash table

2025-04-22 Thread Nicolas George
Emma Worley (HE12025-04-22): > Perhaps I can add a `mode` enum parameter to the FFHashtableContext to > control behavior? Then we can benchmark different behaviors on a > per-use-case basis. For benchmarks, I think #ifdef might be less hassle. Anyway, I repeat: I do not consider it mandatory, and

[FFmpeg-devel] [PATCH v5 01/14] fftools/textformat: Formatting and whitespace changes

2025-04-22 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 86 ++-- fftools/textformat/avtextformat.h | 16 +++--- fftools/textformat/avtextwriters.h | 11 ++-- fftools/textformat/tf_compact.c| 91 +- fftools/textfo

[FFmpeg-devel] [PATCH v5 00/14] Execution Graph Printing

2025-04-22 Thread ffmpegagent
Shortest cover letter for my longest-running FFmpeg patchset: * Apply * Build * Add the "-sg" switch to any FFmpeg command line * Press 'q' when you don't want to wait SG = Show Graph Documentation and examples can be found here: https://github.com/softworkz/ffmpeg_output_apis/wiki Versio

[FFmpeg-devel] [PATCH v5 03/14] fftools/avtextformat: Re-use BPrint in loop

2025-04-22 Thread softworkz
From: softworkz Instead of initializing a new BPrint in each iteration of the loop, re-use the same BPrint struct and just clear it for each iteration. Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-)

[FFmpeg-devel] [PATCH v5 02/14] fftools/textformat: Apply quality improvements

2025-04-22 Thread softworkz
From: softworkz Perform multiple improvements to increase code robustness. In particular: - favor unsigned counters for loops - add missing checks - avoid possibly leaks - move variable declarations to inner scopes when feasible - provide explicit type-casting when needed Signed-off-by: softwork

[FFmpeg-devel] [PATCH v5 04/14] fftools/textformat: Introduce AVTextFormatOptions for avtext_context_open()

2025-04-22 Thread softworkz
From: softworkz This allows future addition of options without changes to the signature of avtext_context_open(). Signed-off-by: softworkz --- fftools/ffprobe.c | 13 + fftools/textformat/avtextformat.c | 21 - fftools/textformat/avtextformat.h |

[FFmpeg-devel] [PATCH v5 13/14] fftools/graphprint: Add execution graph printing

2025-04-22 Thread softworkz
From: softworkz The key benefits are: - Different to other graph printing methods, this is outputting: - all graphs with runtime state (including auto-inserted filters) - each graph with its inputs and outputs - all filters with their in- and output pads - all connections between all

[FFmpeg-devel] [PATCH v5 14/14] fftools/graphprint: Now, make it a Killer-Feature!

2025-04-22 Thread softworkz
From: softworkz remember this: -sg <= show-graph Signed-off-by: softworkz --- doc/ffmpeg.texi | 4 + fftools/Makefile | 1 + fftools/ffmpeg.c | 2 +- fftools/ffmpeg.h | 1 + fftools/ffmpeg_filter.c | 2 +- fftools/ffmpeg_opt.c

[FFmpeg-devel] [PATCH v5 12/14] fftools/ffmpeg_mux: Make ms_from_ost() inline

2025-04-22 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/ffmpeg_mux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux.h b/fftools/ffmpeg_mux.h index f41f2c18fa..4ca8ab73a4 100644 --- a/fftools/ffmpeg_mux.h +++ b/fftools/ffmpeg_mux.h @@ -123,7 +123,7 @@ typedef

[FFmpeg-devel] [PATCH v5 11/14] fftools/resources: Add resource manager files

2025-04-22 Thread softworkz
From: softworkz Signed-off-by: softworkz --- ffbuild/common.mak | 28 ++- fftools/Makefile | 3 +- fftools/resources/.gitignore | 4 + fftools/resources/Makefile | 27 +++ fftools/resources/graph.css | 353 +++ fftools/resources/gra

[FFmpeg-devel] [PATCH v5 05/14] fftools/textformat: Introduce common header and deduplicate code

2025-04-22 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/textformat/tf_compact.c | 32 +--- fftools/textformat/tf_default.c | 27 +++--- fftools/textformat/tf_flat.c | 25 +++--- fftools/textformat/tf_ini.c | 24 +++-- fftools/textformat/tf_internal.h | 85 +++

[FFmpeg-devel] [PATCH v5 09/14] fftools/ffmpeg_filter: Move some declaration to new header file

2025-04-22 Thread softworkz
From: softworkz to allow filtergraph printing to access the information. Signed-off-by: softworkz --- fftools/ffmpeg_filter.c | 190 +--- fftools/ffmpeg_filter.h | 234 2 files changed, 235 insertions(+), 189 deletions(-) cr

[FFmpeg-devel] [PATCH v5 10/14] avfilter/avfilter: Add avfilter_link_get_hw_frames_ctx()

2025-04-22 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavfilter/avfilter.c | 9 + libavfilter/avfilter.h | 12 3 files changed, 24 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 75d66f87f3..d0869561f3 100644 --- a/doc/APIchanges

[FFmpeg-devel] [PATCH v5 08/14] fftools/textformat: Add function avtext_print_integer_flags()

2025-04-22 Thread softworkz
From: softworkz This function works analog to the avtext_print_string() which already has a flags parameter. Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 21 + fftools/textformat/avtextformat.h | 2 ++ 2 files changed, 23 insertions(+) diff --git a/fft

[FFmpeg-devel] [PATCH v5 06/14] fftools/textformat: AVTextWriter change writer_printf signature

2025-04-22 Thread softworkz
From: softworkz Using va_list provides greater flebility Signed-off-by: softworkz --- fftools/textformat/avtextwriters.h | 2 +- fftools/textformat/tw_avio.c | 7 ++- fftools/textformat/tw_buffer.c | 7 ++- fftools/textformat/tw_stdout.c | 8 ++-- 4 files changed, 7 i

[FFmpeg-devel] [PATCH v5 07/14] fftools/tf_internal: Use av_default_item_name

2025-04-22 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/textformat/tf_internal.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fftools/textformat/tf_internal.h b/fftools/textformat/tf_internal.h index 7b326328cb..e145bc83bb 100644 --- a/fftools/textformat/tf_internal.h +

Re: [FFmpeg-devel] [PATCH] avutil/map: [WIP] Introduction

2025-04-22 Thread Michael Niedermayer
Hi On Mon, Apr 21, 2025 at 09:55:33PM +0200, Marton Balint wrote: > > > On Sun, 20 Apr 2025, Michael Niedermayer wrote: > > > Note, help is welcome. > > Time i spend on this, i cannot spend on other things > > > > Note2: i intend to push AVMap after the release unless the release > > ends up d

[FFmpeg-devel] [PATCH] libavformat/mov: FMp4 Fixes duration calculation for individual streams on videos where crash occurs.

2025-04-22 Thread Anthony Bajoua via ffmpeg-devel
Both the audio and video sidx boxes at the end point to a range corresponding to the final mdat atom. Since there is no mfra following the final mdat when recording crashes, current logic sets the flag frag_index.complete flag on the penultimate sidx atom since it points to the end of the file.

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: update stream info when PMT ES stream_type changes

2025-04-22 Thread Pavel Koshevoy
On Mon, Apr 21, 2025 at 2:58 PM Michael Niedermayer wrote: > Hi Pavel > > On Sat, Apr 19, 2025 at 10:18:29AM -0600, Pavel Koshevoy wrote: > > I have a couple of .ts captures where video and audio codec changes > > even though the PMT version does not change and the PIDs stay the same. > > --- > >

[FFmpeg-devel] [PATCH] avformat/mpegts: update stream info when PMT ES stream_type changes

2025-04-22 Thread Pavel Koshevoy
I have a couple of .ts captures where video and audio codec changes even though the PMT version does not change and the PIDs stay the same. I've updated fate ts-demux expected results. --- libavformat/mpegts.c| 2 +- tests/ref/fate/ts-demux | 4 ++-- 2 files changed, 3 insertions(+), 3 deleti

[FFmpeg-devel] [PATCH 2/2] postproc/postprocess_template: fix handling of first row of dering_C

2025-04-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libpostproc/postprocess_altivec_template.c | 5 - libpostproc/postprocess_template.c | 12 +++- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/libpostproc/postprocess_altivec_template.c b/libpostproc/postprocess_altivec

[FFmpeg-devel] [PATCH 1/2] fate: add stripetest

2025-04-22 Thread Michael Niedermayer
Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libpostproc/Makefile | 3 +- libpostproc/tests/stripetest.c | 129 tests/fate/libpostproc.mak | 4 + tests/ref/fate/stripetest | 360 + 4 files changed, 495

[FFmpeg-devel] [PATCH 2/2] avcodec/ffv1enc: Eliminate fabs()

2025-04-22 Thread Michael Niedermayer
Fixes: warning: using floating point absolute value function 'fabs' when argument is of integer type No change in output Changing variables to float worsens compression significantly Found-by: ePirat Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c | 2 +- 1 file changed, 1 insertion

Re: [FFmpeg-devel] [RFC] STF 2025

2025-04-22 Thread Kieran Kunhya via ffmpeg-devel
On Fri, 15 Nov 2024, 18:12 Thilo Borgmann via ffmpeg-devel, < ffmpeg-devel@ffmpeg.org> wrote: > Hi, > > Am 17.05.24 um 15:49 schrieb Michael Niedermayer: > > Hi all > > > > Before this is forgotten again, better start some dicsussion too early > than too late > > > > I propose that if we have the

[FFmpeg-devel] [PATCH v2] avformat/dump: Stream start offsets: change precision and label

2025-04-22 Thread softworkz
From: softworkz - Change precision to 6 digits to align with other printed times - Change label to just "Start" - Add 's' unit to format 'start' value for consistency Signed-off-by: softworkz --- avformat/dump: Change precision of stream start offsets Changing this to 6 digits to a

Re: [FFmpeg-devel] [PATCH v2 5/6] lavc/apv: AVX2 transquant for x86-64

2025-04-22 Thread James Almer
On 4/21/2025 4:50 PM, Mark Thompson wrote: On 21/04/2025 17:53, James Almer wrote: On 4/21/2025 12:24 PM, Mark Thompson wrote: Typical checkasm result on Alder Lake: decode_transquant_8_c: 461.1 ( 1.00x) decode_transquant_8_avx2:   97

Re: [FFmpeg-devel] [PATCH] postproc/postprocess_template: Fix reading uninitialized pixels in dering_C()

2025-04-22 Thread Michael Niedermayer
Hi Kieran On Tue, Apr 22, 2025 at 01:23:19AM -0100, Kieran Kunhya via ffmpeg-devel wrote: > On Tue, 22 Apr 2025, 00:44 Michael Niedermayer, > wrote: > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > > > I thought we decided postproc work in STF wasn't going to

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/f_sendcmd: clear Command on alloc failure

2025-04-22 Thread Marvin Scholz
On 30 Jan 2025, at 1:25, Marvin Scholz wrote: > If the command array failed to allocate, the current parsed > Command has to be cleared, else memory allocated for it > would be leaked. > > Fix CID 1638635 > --- I intend to push the set in a few days, if no one has comments or objections. > liba