> -----Original Message-----
> From: Stefano Sabatini <stefa...@gmail.com>
> Sent: Montag, 21. April 2025 19:31
> To: FFmpeg development discussions and patches <ffmpeg-
> de...@ffmpeg.org>
> Cc: softworkz <softwo...@hotmail.com>
> Subject: Re: [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_internal: Use
> ac_default_item_name
>
> On date Sunday 2025-04-20 22:59:07 +0000, softworkz wrote:
> > From: softworkz <softwo...@hotmail.com>
> >
> > Signed-off-by: softworkz <softwo...@hotmail.com>
> > ---
> > fftools/textformat/tf_internal.h | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
>
> Typo in commit headling: ac_default... -> av_default...
>
> >
> > diff --git a/fftools/textformat/tf_internal.h
> b/fftools/textformat/tf_internal.h
> > index 7b326328cb..e145bc83bb 100644
> > --- a/fftools/textformat/tf_internal.h
> > +++ b/fftools/textformat/tf_internal.h
> > @@ -29,13 +29,9 @@
> > #include "avtextformat.h"
> >
> > #define DEFINE_FORMATTER_CLASS(name) \
> > -static const char *name##_get_name(void *ctx) \
> > -{ \
> > - return #name ; \
> > -} \
> > static const AVClass name##_class = { \
> > .class_name = #name, \
> > - .item_name = name##_get_name, \
> > + .item_name = av_default_item_name, \
> > .option = name##_options \
> > }
>
> Looks good to me.
Hi Stefano,
thanks a lot for the review.
I have applied all the suggested changes (including those where I didn't
explicitly say I would).
For the avtext_context_open() function, I have introduced a new structure
AVTextFormatOptions to achieve a stable function signature that doesn't
need to be changed when adding new options.
This is done in a separate commit. The other two changes where you mentioned
have been moved into their own commits as well.
(V5 patchset coming)
Thanks again,
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
