Re: [FFmpeg-devel] [PATCH] avdevice/alsa: simplify passing ff_alsa_open a channel layout

2025-02-10 Thread Nicolas George
James Almer (12025-02-07): > This also ensures the layout set during the indev init is used instead of the > blank one in st->codecpar. No objection to the patch, but you were the one who added the access to st->codecpar, so that needs an explanation in the commit message. -- Nicolas George __

Re: [FFmpeg-devel] [PATCH v2] avfilter/scale*: add option reset_sar

2025-02-10 Thread Gyan Doshi
On 2025-02-09 03:41 pm, Gyan Doshi wrote: For anamorphic videos, enabling this option leads to adjustment of output dimensions to obtain square pixels when the user requests proportional scaling through either of the w/h expressions or force_original_aspect_ratio. Output SAR is always reset t

[FFmpeg-devel] H.261 patch to detect Iframe in H.261 decoder

2025-02-10 Thread Jerome GORIN
It's enclosed ! 0001-Fix-h261-I-frame-detection.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg

Re: [FFmpeg-devel] [PATCH] checkasm/v210enc.c: Use checkasm_check_type

2025-02-10 Thread Kieran Kunhya via ffmpeg-devel
On Mon, Feb 10, 2025 at 12:40 PM Martin Storsjö wrote: > > On Sat, 8 Feb 2025, Kieran Kunhya via ffmpeg-devel wrote: > > > $subj > > > -if (memcmp(y0, y1, BUF_SIZE * sizeof(type)) > > \ > > -|| memcmp(u0, u1, BUF_SIZE * sizeof(type) / 2)

Re: [FFmpeg-devel] [PATCH] avdevice/alsa: simplify passing ff_alsa_open a channel layout

2025-02-10 Thread James Almer
On 2/10/2025 6:20 AM, Nicolas George wrote: James Almer (12025-02-07): This also ensures the layout set during the indev init is used instead of the blank one in st->codecpar. No objection to the patch, but you were the one who added the access to st->codecpar, so that needs an explanation in

Re: [FFmpeg-devel] [PATCH] avcodec/aarch64/opusdsp_neon: Simplify opus_postfilter_neon

2025-02-10 Thread Martin Storsjö
On Sat, 8 Feb 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote: On Sat, Feb 08, 2025 at 01:59:32AM +0100, Lynne wrote: On 07/02/2025 20:42, Krzysztof Pyrkosz via ffmpeg-devel wrote: This change removes one extra floating point operation and simplifies load operations at the beginning of the loop

[FFmpeg-devel] [PATCH] avfilter/vf_amf_common: implement reset_sar options

2025-02-10 Thread Timo Rothenpieler
Implements the new reset_sar option from a28dc06869fe1f98c07e42f9b0a411d2744ff7d7. While at it, this also moves assigning the output sar on the outlink from the filter frame function to config props. --- libavfilter/vf_amf_common.c | 18 -- libavfilter/vf_amf_common.h | 1 + lib

Re: [FFmpeg-devel] [PATCH] avfilter/vpp_amf: add option reset_sar

2025-02-10 Thread Gyan Doshi
On 2025-02-10 05:53 pm, Gyan Doshi wrote: 4b77a0a681 added a new consumer of ff_scale_adjust_dimensions which was recently modified to allow for square pixel output. This commit extends the new option to vpp_amf, and unbreaks the building of vf_amf_common.c Pushed as 7ee4936e0a61ad81c40d7a1

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: DX12 Reference-only feature support

2025-02-10 Thread Tong Wu
Araz Iusubov: >Subject: [FFmpeg-devel] [PATCH] avcodec/amfenc: DX12 Reference-only feature >support > >The Reference-Only feature in DirectX 12 is a memory optimization technique >designed for video decoding scenarios. >This feature requires that reference resources must be allocated with the >D3D1

Re: [FFmpeg-devel] [PATCH v2 2/2] checkasm: aacencdsp: Actually test nonzero values in quant_bands

2025-02-10 Thread Martin Storsjö
On Fri, 7 Feb 2025, Martin Storsjö wrote: On Wed, 5 Feb 2025, Martin Storsjö wrote: Previously, we read elements from ff_aac_pow34sf_tab; however that table is initialized to zero; one needs to call ff_aac_float_common_init() to make sure that the table is initialized. However, given the rang

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-10 Thread Ronald S. Bultje
Hi, On Sat, Feb 8, 2025 at 2:31 PM Ronald S. Bultje wrote: > Hi, > > On Fri, Feb 7, 2025 at 10:50 PM Zhao Zhili < > quinkblack-at-foxmail@ffmpeg.org> wrote: > >> >> >> > On Feb 8, 2025, at 00:05, Ronald S. Bultje wrote: >> > >> > Hi, >> > >> > On Fri, Feb 7, 2025 at 8:44 AM Zhao Zhili < >>

Re: [FFmpeg-devel] H.261 patch to detect Iframe in H.261 decoder

2025-02-10 Thread Andreas Rheinhardt
Jerome GORIN: > -skip_bits1(&s->gb); /* freeze picture release off */ > +intra_flag = get_bits1(&s->gb); /* Intra 1 = I-frame, 0 = P-frame */ > > +if (intra_flag){ > +s->pict_type = AV_PICTURE_TYPE_I; > +}else{ > +s->pict_type = AV_PICTURE_TYPE_P; > +} > +

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: DX12 Reference-only feature support

2025-02-10 Thread Lynne
On 30/01/2025 15:09, Araz Iusubov wrote: The Reference-Only feature in DirectX 12 is a memory optimization technique designed for video decoding scenarios. This feature requires that reference resources must be allocated with the D3D12_RESOURCE_FLAG_VIDEO_DECODE_REFERENCE_ONLY resource flag. Re

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/aac/aacdec_usac: Fix memory deallocation of pl_data

2025-02-10 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: double free > Fixes: > 393523547/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-6740617236905984 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > ---

[FFmpeg-devel] [REFUND-REQUEST] FOSDEM '25 Expenses

2025-02-10 Thread Lynne
Hi, I am requesting reimbursement for the following expenses made attending FOSDEM 2025, where I attended the meeting and discussed development topics with fellow developers. Eurostar tickets: 178.33 GBP Hotel: 97.04 GBP Thanks ___ ffmpeg-devel mai

[FFmpeg-devel] [PATCH] avfilter/vpp_amf: add option reset_sar

2025-02-10 Thread Gyan Doshi
4b77a0a681 added a new consumer of ff_scale_adjust_dimensions which was recently modified to allow for square pixel output. This commit extends the new option to vpp_amf, and unbreaks the building of vf_amf_common.c --- doc/filters.texi| 3 +++ libavfilter/vf_amf_common.c | 10 ++

Re: [FFmpeg-devel] [PATCH] checkasm/v210enc.c: Use checkasm_check_type

2025-02-10 Thread Martin Storsjö
On Sat, 8 Feb 2025, Kieran Kunhya via ffmpeg-devel wrote: $subj -if (memcmp(y0, y1, BUF_SIZE * sizeof(type)) \ -|| memcmp(u0, u1, BUF_SIZE * sizeof(type) / 2) \ -|| memcmp(v0, v1, BUF_SIZE * sizeo

Re: [FFmpeg-devel] [PATCH] swscale/aarch64/rgb2rgb_neon: Implemented uyvytoyuv422

2025-02-10 Thread Martin Storsjö
On Fri, 7 Feb 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote: The patch contains NEON code that splits the uyvy input array into 3 separate buffers. The existing test cases are covering scenarios with odd height and odd stride, but width is even in every instance. Is it safe to make that assump

Re: [FFmpeg-devel] [PATCH] avfilter/vf_amf_common: implement reset_sar options

2025-02-10 Thread Gyan Doshi
On 2025-02-10 07:04 pm, Timo Rothenpieler wrote: Implements the new reset_sar option from a28dc06869fe1f98c07e42f9b0a411d2744ff7d7. Already posted a patch. Will push soon. Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH] avfilter/vf_amf_common: implement reset_sar options

2025-02-10 Thread Timo Rothenpieler
On 10/02/2025 14:44, Gyan Doshi wrote: On 2025-02-10 07:04 pm, Timo Rothenpieler wrote: Implements the new reset_sar option from a28dc06869fe1f98c07e42f9b0a411d2744ff7d7. Already posted a patch. Will push soon. Ah, you might wanna look into moving the sar assignment as well then, cause as

Re: [FFmpeg-devel] [PATCH v2 2/2] random_seed: Improve behaviour with small timer increments with high precision timers

2025-02-10 Thread Martin Storsjö
On Sun, 9 Feb 2025, Michael Niedermayer wrote: Hi Martin On Fri, Feb 07, 2025 at 12:04:53AM +0200, Martin Storsjö wrote: On Thu, 6 Feb 2025, Michael Niedermayer wrote: On Thu, Feb 06, 2025 at 02:38:48PM +0200, Martin Storsjö wrote: On Thu, 6 Feb 2025, Michael Niedermayer wrote: +

[FFmpeg-devel] [PATCH 2/3] avcodec/sanm: fobj left/top are signed

2025-02-10 Thread Manuel Lauss
The left and top parameters of an FOBJ are signed values. Signed-off-by: Manuel Lauss --- libavcodec/sanm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/sanm.c b/libavcodec/sanm.c index 37d2c915d4..0e7cd292d0 100644 --- a/libavcodec/sanm.c +++ b/libavcodec/s

[FFmpeg-devel] [PATCH 1/3] avcodec/sanm: ignore unknown codecs in FOBJs

2025-02-10 Thread Manuel Lauss
Don't error out, just ignore unknown codec numbers and pretend decode succeeded. This is useful for older LucasArts titles which stack a lot of different FOBJs with different codecs into a single frame. Signed-off-by: Manuel Lauss --- libavcodec/sanm.c | 2 +- 1 file changed, 1 insertion(+), 1

[FFmpeg-devel] [PATCH 3/3] avcodec/sanm: add smush codec23 decoder

2025-02-10 Thread Manuel Lauss
This codec alternatingly skips and changes existing pixels. A second 16bit parameter in the FOBJ header indicates how to do the pixel changes: either by specifying a LUT in the codec datastream or by adding a constant value to the pixel. Signed-off-by: Manuel Lauss --- Videos showing the before/a

[FFmpeg-devel] Trac accounts cleanup

2025-02-10 Thread Michael Niedermayer
Hi everyone Iam deleting half opened accounts that have never verified their email address. (this is limited to accounts unused since 2 years so it should affect noone) thx -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unr

[FFmpeg-devel] Calling avformat_find_stream_info() more than once

2025-02-10 Thread Scott Theisen
Hello all, avformat_find_stream_info() calls av_freep() on FFStream::info, which will cause a segmentation fault if it is called more than once on the same AVFormatContext (assuming it still has at least one of the AVStreams from when it was called previously). Is this intentional and should

[FFmpeg-devel] [PATCH v4 6/6] tests: Add chained ogg/flac stream dump test.

2025-02-10 Thread Romain Beauxis
Same test as for ogg/opus. Samples and output for both tests are available here: https://www.dropbox.com/scl/fo/xrtrna2rxr1j354hrtymq/AGwemlxHYecBLNmQ8Fsy--4?rlkey=lzilr4m9w4gfdqygoe172vvy8&dl=0 In this case, the secondary chained ogg/flac header packets are already visible before the changes.

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/sanm: ignore unknown codecs in FOBJs

2025-02-10 Thread Marton Balint
On Mon, 10 Feb 2025, Manuel Lauss wrote: Don't error out, just ignore unknown codec numbers and pretend decode succeeded. This is useful for older LucasArts titles which stack a lot of different FOBJs with different codecs into a single frame. Signed-off-by: Manuel Lauss --- libavcodec/san

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/sanm: ignore unknown codecs in FOBJs

2025-02-10 Thread Manuel Lauss
Hi Marton! Marton Balint schrieb am Mo., 10. Feb. 2025, 20:42: > > > On Mon, 10 Feb 2025, Manuel Lauss wrote: > > > Don't error out, just ignore unknown codec numbers and pretend > > decode succeeded. This is useful for older LucasArts titles > > which stack a lot of different FOBJs with diffe

[FFmpeg-devel] [PATCH v4 2/6] tests: Add stream dump test API util.

2025-02-10 Thread Romain Beauxis
This is the code for the main utility used to dump chained streams and test for decoded metadata in subsequent patches. --- tests/Makefile| 1 + tests/api/Makefile| 2 +- tests/api/api-dump-stream-meta-test.c | 169 ++ 3 file

[FFmpeg-devel] [PATCH v4 3/6] Pass secondary ogg/opus chained streams metadata.

2025-02-10 Thread Romain Beauxis
These changes parse ogg/opus comment in secondary chained ogg/opus streams and attach them as extradata to the corresponding packet. They can then be decoded in the opus decoder and attached to the next decoded frame. libavformat/oggparseopus.c: Parse comments from secondary chained ogg/opus str

[FFmpeg-devel] [PATCH v4 5/6] Parse secondary chained ogg/flac stream comments.

2025-02-10 Thread Romain Beauxis
This the same changes as done with ogg/opus: parse comments in secondary chained ogg/flac streams, attach them as packed extradata, decode and attach them to the next decoded stream in the flac decoder. libavformat/oggparseflac.c: Parse ogg/flac comments in new ogg packets, add them to ogg stream

[FFmpeg-devel] [PATCH v4 1/6] Pass ogg/opus secondary header packets to the

2025-02-10 Thread Romain Beauxis
These changes make it possible to access the initial header packets of secondary chained ogg/opus bitstreams. libavformat/oggparseopus.c: Parse extradata from secondary chained streams header packet. libavformat/oggdec.c: Do not force ogg stream header parsing on secondary ogg/opus chained strea

[FFmpeg-devel] [PATCH v4 4/6] tests: Add chained ogg/opus stream dump test.

2025-02-10 Thread Romain Beauxis
This adds the test to confirm that secondary chained ogg/opus streams are properly decoded. Using the test output, we can confirm that secondary stream header packets are properly passed down and that the new metadata are properly parsed. Output before the changes: Stream ID: 0, codec name: opus,

Re: [FFmpeg-devel] 10bit MV-HEVC decoding support

2025-02-10 Thread Danny Hong
On 2/7/2025 5:39 PM, James Almer wrote: > The existing code should be able > to handle 10bit streams for both base and second layers Thank you, James! I just went through verification with a 10bit encoded MV-HEVC and it seems to be decoding as expected. I compared the ffmpeg decoded with the HTM

[FFmpeg-devel] [PATCH v2 1/3] avcodec/sanm: ignore unknown codecs in FOBJs

2025-02-10 Thread Manuel Lauss
Don't error out, just ignore unknown codec numbers and pretend decode succeeded. This is useful for older LucasArts titles which stack a lot of different FOBJs with different codecs into a single frame. Mark the frame as corrupt though since we werent' able to decode everything that is supposed t

[FFmpeg-devel] [PATCH v2 2/3] avcodec/sanm: fobj left/top are signed

2025-02-10 Thread Manuel Lauss
The left and top parameters of an FOBJ are signed values. Signed-off-by: Manuel Lauss --- v2: no changes. libavcodec/sanm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/sanm.c b/libavcodec/sanm.c index a4f0a28c7c..71dbac4320 100644 --- a/libavcodec/sanm.c

[FFmpeg-devel] [PATCH v2 3/3] avcodec/sanm: add smush codec23 decoder

2025-02-10 Thread Manuel Lauss
This codec alternatingly skips and changes existing pixels. A second 16bit parameter in the FOBJ header indicates how to do the pixel changes: either by specifying a LUT in the codec datastream or by adding a constant value to the pixel. Signed-off-by: Manuel Lauss --- v2: no changes. Videos sho

Re: [FFmpeg-devel] Calling avformat_find_stream_info() more than once

2025-02-10 Thread Andreas Rheinhardt
Scott Theisen: > Hello all, > > avformat_find_stream_info() calls av_freep() on FFStream::info, which > will cause a segmentation fault if it is called more than once on the > same AVFormatContext (assuming it still has at least one of the > AVStreams from when it was called previously). > > Is t

[FFmpeg-devel] [PATCH v4 0/5] Properly decode ogg metadata in ogg/flac and ogg/opus chained bitstreams

2025-02-10 Thread Romain Beauxis
This is a series of patches to allow proper decoding of ogg metadata in chained ogg/flac and ogg/opus streams. Changes since v3: * Added opus implementation * Cleaned up, separated patches in a more logical way. Summary of code changes: The changes in this patch series allow proper decoding of m