Re: [FFmpeg-devel] [PATCH] avformat/mov: fix eof check after avio_skip()

2025-02-02 Thread Kacper Michajlow
On Mon, 3 Feb 2025 at 06:24, Kacper Michajłow wrote: > > This fix ensures that the loop stops early on EOF. The issue occurs > because mov_read_infe() performs a version check and skips unsupported > versions. The problem is that seeking within the stream clears the EOF > flag, causing avio_feof()

[FFmpeg-devel] [PATCH] avformat/mov: fix eof check after avio_skip()

2025-02-02 Thread Kacper Michajłow
This fix ensures that the loop stops early on EOF. The issue occurs because mov_read_infe() performs a version check and skips unsupported versions. The problem is that seeking within the stream clears the EOF flag, causing avio_feof() to not function as expected. This is resolved by moving the EOF

[FFmpeg-devel] [PATCH v2] avformat/mov: fix eof check in mov_read_iinf()

2025-02-02 Thread Kacper Michajłow
This fix ensures that the loop stops early on EOF. The issue occurs because mov_read_infe() performs a version check and skips unsupported versions. The problem is that seeking within the stream clears the EOF flag, causing avio_feof() to not function as expected. This is resolved by moving the EOF

[FFmpeg-devel] [PATCH] doc/filters: Add CUDA Video Filters section for CUDA-based and CUDA+NPP based filters.

2025-02-02 Thread Danil Iashchenko
--- doc/filters.texi | 1323 -- 1 file changed, 700 insertions(+), 623 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index c2817b2661..7460b7ef18 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -8619,45 +8619,6 @@ Set planes to f

Re: [FFmpeg-devel] libswresample/rematrix.c sane_layout

2025-02-02 Thread James Almer
On 1/30/2025 12:29 AM, Pavel Koshevoy wrote: Hi, I have a file which I can't down-mix to stereo due to AV_CHANNEL_ORDER_NATIVE requirement in sane_layout. Can you share that file? Or any other that reproduces this? ``` $ ffmpeg -i COMMUNITY_HERO_2.mov -vn -af 'aformat=sample_rates=48000:cha

[FFmpeg-devel] [PATCH v2] avfilter/xpsnr: avoid division by zero

2025-02-02 Thread Gyan Doshi
The ref input may have its frame rate unset, which would then lead to SIGFPE. So fall back to the main link frame rate. If that too is unset, default to 0. Related to #11428 --- libavfilter/vf_xpsnr.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_xpsnr.c b

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-02-02 Thread James Almer
On 2/1/2025 6:53 PM, Michael Niedermayer wrote: Hi James On Sat, Feb 01, 2025 at 10:30:21AM -0300, James Almer wrote: On 1/31/2025 9:49 PM, Michael Niedermayer wrote: Hi James On Fri, Jan 31, 2025 at 12:44:50PM -0300, James Almer wrote: On 1/31/2025 11:58 AM, Nicolas George wrote: Niklas Ha

[FFmpeg-devel] [PATCH v2] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-02-02 Thread Scott Theisen
The format is used by at least Dish Network, but is not defined in any DVB standard, so remove references to DVB. This is a simple rename, no functional change. --- libavcodec/mpeg12dec.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavcodec

[FFmpeg-devel] [PATCH] avformat/mov: add an offset to IAMF streams

2025-02-02 Thread James Almer
Using audio_substream_id for AVStream ids is not ideal give that in containers like mp4, the IAMF structure is opaque to the outside and other streams may share such id values. Signed-off-by: James Almer --- libavformat/iamf_reader.c| 12 +++--- libavformat/iamf_reader.h

Re: [FFmpeg-devel] [PATCH 0/9] Nvidia Video Codec SDK 13.0 support

2025-02-02 Thread Timo Rothenpieler
On 01.02.2025 22:15, Timo Rothenpieler wrote: On 30.01.2025 20:40, Timo Rothenpieler wrote: This series adds support for new features and capabilities added in todays release of the Video Codec SDK 13.0. Diego de Souza (7):    avutil/hwcontext_cuda: add 4:2:2 pixel format support    avcodec/nvd

[FFmpeg-devel] [PATCH 2/2] avcodec/vvc/refs: Check content_ref in set_pict_type()

2025-02-02 Thread Michael Niedermayer
Fixes: 390565846/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-4990028521996288 Fixes: Null pointer dereference Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vvc/refs.c | 2 +-

[FFmpeg-devel] [PATCH 1/2] avcodec/vvc/refs: fix negative pps_scaling_win offsets

2025-02-02 Thread Michael Niedermayer
The spec seems to allow these to be negative Fixes: left shift of negative value -15 Fixes: 392687035/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-6559804532785152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-02-02 Thread James Almer
On 2/1/2025 7:27 PM, Michael Niedermayer wrote: Hi James On Sat, Feb 01, 2025 at 10:30:21AM -0300, James Almer wrote: On 1/31/2025 9:49 PM, Michael Niedermayer wrote: [...] has worked. Changing it now because one person was unhappy with a CC (That This is a false statement. Iam not sugge

Re: [FFmpeg-devel] [PATCH 2/2] swresample/rematrix: add support for custom order channel layouts

2025-02-02 Thread James Almer
On 2/2/2025 6:46 PM, James Almer wrote: Limited to the same channels as a native layout, but not constrained by channel ordering. Signed-off-by: James Almer --- Untested, as i don't have a sample from which we export a custom layout (Like PCM in mp4). Tried with one such sample and it appea

Re: [FFmpeg-devel] [PATCH v2] libavcodec/mpeg12dec.c: rename 0x0502 CC format

2025-02-02 Thread Marth64
Will push ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/2] swresample/rematrix: split filling the matrix array into its own function

2025-02-02 Thread James Almer
Signed-off-by: James Almer --- libswresample/rematrix.c | 202 --- 1 file changed, 106 insertions(+), 96 deletions(-) diff --git a/libswresample/rematrix.c b/libswresample/rematrix.c index b9bf4dcac0..8b6e8ae1c5 100644 --- a/libswresample/rematrix.c +++ b/libs

[FFmpeg-devel] [PATCH 2/2] swresample/rematrix: add support for custom order channel layouts

2025-02-02 Thread James Almer
Limited to the same channels as a native layout, but not constrained by channel ordering. Signed-off-by: James Almer --- Untested, as i don't have a sample from which we export a custom layout (Like PCM in mp4). libswresample/rematrix.c | 28 +--- 1 file changed, 17 in

Re: [FFmpeg-devel] libswresample/rematrix.c sane_layout

2025-02-02 Thread Pavel Koshevoy
On Sun, Feb 2, 2025 at 9:04 AM James Almer wrote: > On 1/30/2025 12:29 AM, Pavel Koshevoy wrote: > > Hi, > > > > I have a file which I can't down-mix to stereo due to > > AV_CHANNEL_ORDER_NATIVE requirement in sane_layout. > > Can you share that file? Or any other that reproduces this? > > I will

[FFmpeg-devel] [PATCH 1/2] avcodec/ffv1: split off and share frame header parsing code

2025-02-02 Thread James Almer
Signed-off-by: James Almer --- libavcodec/Makefile | 4 +- libavcodec/ffv1.c | 14 +- libavcodec/ffv1.h | 35 ++- libavcodec/ffv1_parse.c | 410 +++ libavcodec/ffv1dec.c| 459 +++- libavcodec/ffv1enc.c

[FFmpeg-devel] [PATCH v2 2/2] avcodec: add a ffv1 parser

2025-02-02 Thread James Almer
Only setting frame and stream properties. No packetization is performed. Signed-off-by: James Almer --- configure| 1 + libavcodec/Makefile | 1 + libavcodec/ffv1_parser.c | 86 libavcodec/parsers.c | 1 + 4 files changed, 89 i

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-02-02 Thread Ronald S. Bultje
Michael, On Sat, Feb 1, 2025 at 4:53 PM Michael Niedermayer wrote: > The system is absurd, the text points this out in a mocking/ironic way. > If you want me to reword this in a dry formal way, i can submit such a > patch? > Every system is absurd. "If everyone just agreed with me, then ..." Th

Re: [FFmpeg-devel] [PATCH v4 1/2] avformat/riffdec: change declaration of ff_get_wav_header()

2025-02-02 Thread Viraaj Raulgaonkar
On Mon, Feb 3, 2025 at 12:56 AM Andreas Rheinhardt wrote: > > Viraaj Raulgaonkar: > > Change the type of logctx from void* to AVFormatContext*, since all > > calls to ff_get_wav_header() pass an AVFormatContext* anyway. > > This change makes it appear as if it were better to always pass an > AVFor

Re: [FFmpeg-devel] [PATCH] [h264] Make slice header parse errors fatal under AV_EF_EXPLODE

2025-02-02 Thread Marth64
Pushing shortly ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] swresample/rematrix: add support for custom order channel layouts

2025-02-02 Thread Pavel Koshevoy
On Sun, Feb 2, 2025 at 4:04 PM James Almer wrote: > On 2/2/2025 6:46 PM, James Almer wrote: > > Limited to the same channels as a native layout, but not constrained by > channel ordering. > > > > Signed-off-by: James Almer > > --- > > Untested, as i don't have a sample from which we export a cus

Re: [FFmpeg-devel] [PATCH v4 1/2] avformat/riffdec: change declaration of ff_get_wav_header()

2025-02-02 Thread Andreas Rheinhardt
Viraaj Raulgaonkar: > Change the type of logctx from void* to AVFormatContext*, since all > calls to ff_get_wav_header() pass an AVFormatContext* anyway. This change makes it appear as if it were better to always pass an AVFormatContext* in such cases. But it is not so. Better commit message would

[FFmpeg-devel] [PATCH v5 1/2] avformat/riffdec: change declaration of ff_get_wav_header()

2025-02-02 Thread Viraaj Raulgaonkar
Change the type of logctx from void* to AVFormatContext*. This is in preparation for the next commit. --- libavformat/riff.h| 2 +- libavformat/riffdec.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/riff.h b/libavformat/riff.h index a93eadfec

[FFmpeg-devel] [PATCH v5 2/2] avformat/riffdec: warn on invalid sample rate

2025-02-02 Thread Viraaj Raulgaonkar
If strict_std_compliance < FF_COMPLIANCE_STRICT, warn the user of the invalid sample rate instead of returning an error. In certain cases the sample rate can get decoded later on. Fixes Trac Ticket #11361. --- libavformat/riffdec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) dif

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec: add a ffv1 parser

2025-02-02 Thread Lynne
On 03/02/2025 03:16, James Almer wrote: Only setting frame and stream properties. No packetization is performed. Signed-off-by: James Almer --- configure| 1 + libavcodec/Makefile | 1 + libavcodec/ffv1_parser.c | 86 libavcod

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-02-02 Thread Michael Niedermayer
Hi On Sat, Feb 01, 2025 at 02:45:26PM +0800, Zhao Zhili wrote: > > > > On Feb 1, 2025, at 08:49, Michael Niedermayer > > wrote: > > > > Hi James > > > > On Fri, Jan 31, 2025 at 12:44:50PM -0300, James Almer wrote: > >> On 1/31/2025 11:58 AM, Nicolas George wrote: > >>> Niklas Haas (12025-01-

[FFmpeg-devel] [PATCH] lavc/vvc: Fix derivation of inverse LMCS idx

2025-02-02 Thread Frank Plowman
The clamping of idxYInv from H.266(V3) section 8.8.2.3 was missing. This could lead to OOB reads from lmcs->pivot or input_pivot. I also changed the derivation of the forward LMCS idx to use a shift rather than a division for speed and as this is actually how the variable is declared in the specif