Re: [FFmpeg-devel] [PATCH 3/3] avformat/hls: Be more picky on extensions

2025-01-16 Thread Michael Niedermayer
On Thu, Jan 16, 2025 at 04:39:51AM +0100, Michael Niedermayer wrote: > This blocks disallowed extensions from probing > It also requires segments to have matching extensions to the format > > It is recommended to set the whitelists correctly > instead of depending on extensions, but this should he

Re: [FFmpeg-devel] lavfi: fix undefined ff_vk_shader_print if vulkan filters are disabled

2025-01-16 Thread Wang Bin
Lynne 于2025年1月16日周四 16:19写道: > On 16/01/2025 15:24, Wang Bin wrote: > > > > > > ___ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffm

[FFmpeg-devel] [PATCH v2] avformat/hls: Be more picky on extensions

2025-01-16 Thread Michael Niedermayer
This blocks disallowed extensions from probing It also requires all available segments to have matching extensions to the format It is recommended to set the whitelists correctly instead of depending on extensions, but this should help a bit, and this is easier to backport Fixes: CVE-2023-6602 I

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: Be more picky on extensions

2025-01-16 Thread Michael Niedermayer
Hi all On Thu, Jan 16, 2025 at 02:23:07PM +0100, Michael Niedermayer wrote: > This blocks disallowed extensions from probing > It also requires all available segments to have matching extensions to the > format > > It is recommended to set the whitelists correctly > instead of depending on exten

[FFmpeg-devel] [PATCH] Makefile: only compile SPIR-V support if Vulkan is enabled

2025-01-16 Thread Lynne
--- libavcodec/Makefile | 2 ++ libavfilter/Makefile | 2 ++ 2 files changed, 4 insertions(+) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index a3ef11a258..40971d2afd 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -1265,8 +1265,10 @@ OBJS-$(HAVE_THREADS)

Re: [FFmpeg-devel] lavfi: fix undefined ff_vk_shader_print if vulkan filters are disabled

2025-01-16 Thread Lynne
On 16/01/2025 15:24, Wang Bin wrote: ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". The b

[FFmpeg-devel] [PATCH] avcodec/amfenc: Fix max rate control log message

2025-01-16 Thread Araz Iusubov
--- libavcodec/amfenc_av1.c | 2 +- libavcodec/amfenc_h264.c | 2 +- libavcodec/amfenc_hevc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index bc6ad3d7fb..b21011ef23 100644 --- a/libavcodec/amfenc_av1.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
UBSAN by default is just prints a mesage and moves on. This hides a few UBs in fate-suite. Signed-off-by: Vitaly Buka --- configure | 4 ++-- libavcodec/aacenc_pred.c | 1 + libavcodec/ffv1dec.c | 1 + libavcodec/ffv1enc_template.c | 1 + libavcodec/get_bits.h

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-16 Thread James Almer
On 1/16/2025 4:12 PM, Vitaly Buka via ffmpeg-devel wrote: UBSAN by default is just prints a mesage and moves on. This hides a few UBs in fate-suite. Signed-off-by: Vitaly Buka --- configure | 4 ++-- libavcodec/aacenc_pred.c | 1 + libavcodec/ffv1dec.c | 1

[FFmpeg-devel] [PATCH 1/2] .gitignore: ignore fate-suite

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
Signed-off-by: Vitaly Buka --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 9cfc78b414..6fcbddad3c 100644 --- a/.gitignore +++ b/.gitignore @@ -43,3 +43,4 @@ /tools/python/__pycache__/ /libavcodec/vulkan/*.c /libavfilter/vulkan/*.c +/fate-suite/

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
I assume "recover" mode is there unintentionally. "-fno-sanitize-recover" helps to keep the code clean. On Thu, Jan 16, 2025 at 11:13 AM Vitaly Buka wrote: > UBSAN by default is just prints a mesage and > moves on. This hides a few UBs in fate-suite. > > Signed-off-by: Vitaly Buka > --- > conf

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mpegvideo_enc: fix qmat value comments

2025-01-16 Thread Ramiro Polla
Hi Marton, On Tue, Jan 7, 2025 at 12:09 AM Marton Balint wrote: > > The comments supposed to track the possible value of the qmat and qmat16 > matrices, but they were not updated properly in the long history of the > mpegvideo encoder. Also they wrongly assumed the usage of built-in quantizer > m

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/sanm: implement codec37 subcodec1

2025-01-16 Thread Manuel Lauss
Servus Michael, On Fri, Jan 17, 2025 at 2:32 AM Michael Niedermayer wrote: > > Hi > > On Wed, Jan 15, 2025 at 06:24:44PM +0100, Manuel Lauss wrote: > > Ping? > > > > > Incidentally this also closes trac ticket #5753; while commit > > will apply with that > > > > b22ce90d ("avcodec/sanm: SMUSH co

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpegvideo_enc: use 64bit multiplication in dct_quantize_trellis_c and dct_quantize_c

2025-01-16 Thread Ramiro Polla
Hi Marton, On Thu, Jan 16, 2025 at 8:52 PM Marton Balint wrote: > On Tue, 7 Jan 2025, Marton Balint wrote: > > Fixes corruption with: > > > > ffmpeg -t 1 -filter_complex > > "sine=f=21,showwaves=scale=cbrt:mode=line:colors=white:draw=full" -c:v > > mpeg2video -non_linear_quant 1 -qmin 1 -qmax 1

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-16 Thread Christophe Gisquet
Hello, Le jeu. 16 janv. 2025 à 21:15, Romain Beauxis a écrit : > --- a/libavformat/prompeg.c > +++ b/libavformat/prompeg.c > @@ -25,78 +25,16 @@ > * @author Vlad Tarca > */ [...] > --- /dev/null > +++ b/libavformat/prompeg_utils.c > @@ -0,0 +1,226 @@ > +/* > + * Pro-MPEG Code of Practice #

[FFmpeg-devel] [PATCH] avformat/avformat: also clear packet queues when closing a muxer

2025-01-16 Thread James Almer
FFFormatContext.packet_buffer is used in mux.c, and if a muxing process fails at a point where packets remained in said queue, they will leak. Fixes ticket #11419 Signed-off-by: James Almer --- libavformat/avformat.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfo

Re: [FFmpeg-devel] [PATCH] avcodec/svq1enc: restrict Altivec acceleration to big-endian POWER configurations

2025-01-16 Thread Sean McGovern
On Thu, Jan 16, 2025 at 4:30 PM Sean McGovern wrote: > > This was disabled in da60b99a8857d5ca236f32c1799a066e0135a866 and then > accidentally re-enabled in 172b0e2e88832822632841e8e0d3794f974cbc93. > > The code in question was never properly adapted for litte-endian mode. Woops! "little-endian".

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpegvideo_enc: use 64bit multiplication in dct_quantize_trellis_c and dct_quantize_c

2025-01-16 Thread Marton Balint
On Tue, 7 Jan 2025, Marton Balint wrote: Fixes corruption with: ffmpeg -t 1 -filter_complex "sine=f=21,showwaves=scale=cbrt:mode=line:colors=white:draw=full" -c:v mpeg2video -non_linear_quant 1 -qmin 1 -qmax 1 -cpuflags 0 out.mpg or ffmpeg -t 1 -filter_complex "sine=f=21,showwaves=scale

Re: [FFmpeg-devel] [PATCH] avcodec/svq1enc: restrict Altivec acceleration to big-endian POWER configurations

2025-01-16 Thread Michael Niedermayer
Hi On Thu, Jan 16, 2025 at 04:57:13PM -0500, Sean McGovern wrote: > On Thu, Jan 16, 2025 at 4:30 PM Sean McGovern wrote: > > > > This was disabled in da60b99a8857d5ca236f32c1799a066e0135a866 and then > > accidentally re-enabled in 172b0e2e88832822632841e8e0d3794f974cbc93. > > > > The code in ques

[FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-16 Thread Romain Beauxis
This patch implements the decoding logic for the FEC error- correction method described in the Pro-MPEG CoP #3-R2 FEC[1] We are still in the process of testing this patch with our encoders but I wanted to send it now in case it could use some early review. The code seems clean enough and straight

[FFmpeg-devel] [PATCH] tests/checkasm: prevent a segmentation fault when calling strncmp()

2025-01-16 Thread Sean McGovern
The POSIX specification for strncmp()[1] leaves this behaviour as undefined if either pointer argument is NULL. Prevent a segmentation fault by ensuring 'arg' is non-NULL. [1] https://pubs.opengroup.org/onlinepubs/9799919799/functions/strncmp.html --- tests/checkasm/checkasm.c | 2 +- 1 file cha

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-16 Thread Kieran Kunhya via ffmpeg-devel
On Thu, 16 Jan 2025, 20:48 Kieran Kunhya, wrote: > On Thu, 16 Jan 2025, 20:15 Romain Beauxis, > wrote: > >> This patch implements the decoding logic for the FEC error- >> correction method described in the Pro-MPEG CoP #3-R2 FEC[1] >> >> We are still in the process of testing this patch with our

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-16 Thread Kieran Kunhya via ffmpeg-devel
On Thu, Jan 16, 2025 at 9:35 PM Romain Beauxis wrote: > > Le jeu. 16 janv. 2025 à 14:48, Kieran Kunhya > a écrit : > > > > On Thu, 16 Jan 2025, 20:15 Romain Beauxis, wrote: > >> > >> This patch implements the decoding logic for the FEC error- > >> correction method described in the Pro-MPEG CoP

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/sanm: implement codec37 subcodec1

2025-01-16 Thread Michael Niedermayer
Hi On Wed, Jan 15, 2025 at 06:24:44PM +0100, Manuel Lauss wrote: > Ping? > > Incidentally this also closes trac ticket #5753; while commit will apply with that > b22ce90d ("avcodec/sanm: SMUSH codec48 decoder") fixes #5746. I cant amend a past commit. thx [...] -- Michael GnuPG finge

Re: [FFmpeg-devel] [PATCH] tests/checkasm: prevent a segmentation fault when calling strncmp()

2025-01-16 Thread Martin Storsjö
On Thu, 16 Jan 2025, Sean McGovern wrote: The POSIX specification for strncmp()[1] leaves this behaviour as undefined if either pointer argument is NULL. Prevent a segmentation fault by ensuring 'arg' is non-NULL. [1] https://pubs.opengroup.org/onlinepubs/9799919799/functions/strncmp.html ---

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-16 Thread Kieran Kunhya via ffmpeg-devel
On Thu, 16 Jan 2025, 20:15 Romain Beauxis, wrote: > This patch implements the decoding logic for the FEC error- > correction method described in the Pro-MPEG CoP #3-R2 FEC[1] > > We are still in the process of testing this patch with our encoders but > I wanted to send it now in case it could use

Re: [FFmpeg-devel] [PATCH 1/2] .gitignore: ignore fate-suite

2025-01-16 Thread Timo Rothenpieler
On 16.01.2025 20:12, Vitaly Buka via ffmpeg-devel wrote: Signed-off-by: Vitaly Buka --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 9cfc78b414..6fcbddad3c 100644 --- a/.gitignore +++ b/.gitignore @@ -43,3 +43,4 @@ /tools/python/__pycache__/

Re: [FFmpeg-devel] [PATCH] tests/checkasm: prevent a segmentation fault when calling strncmp()

2025-01-16 Thread Martin Storsjö
On Thu, 16 Jan 2025, Sean McGovern wrote: This feels like less of an issue with strncmp, and more of an issue with the spec for main() and argc/argv; how do you do to end up with a NULL entry in argv[i] for 0 <= i < argc? If 'checkasm' is run without arguments, argv[i] would be NULL since argc

[FFmpeg-devel] [PATCH] avcodec/svq1enc: restrict Altivec acceleration to big-endian POWER configurations

2025-01-16 Thread Sean McGovern
This was disabled in da60b99a8857d5ca236f32c1799a066e0135a866 and then accidentally re-enabled in 172b0e2e88832822632841e8e0d3794f974cbc93. The code in question was never properly adapted for litte-endian mode. refs: trac/10955 --- libavcodec/ppc/svq1enc_altivec.c | 8 1 file changed, 4

Re: [FFmpeg-devel] [PATCH] avutil/vulkan_glslang: windows build improvements

2025-01-16 Thread Timo Rothenpieler
On 16.01.2025 02:53, Lynne wrote: On 16/01/2025 09:38, Koushik Dutta wrote: For my use case I ended up creating a custom pkgconfig file. My platform and compiler is windows and msvc. I was unable to get the existing configure to work correctly with this environment and opted for pkgconfig as th

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-16 Thread Romain Beauxis
Le jeu. 16 janv. 2025 à 14:48, Kieran Kunhya a écrit : > > On Thu, 16 Jan 2025, 20:15 Romain Beauxis, wrote: >> >> This patch implements the decoding logic for the FEC error- >> correction method described in the Pro-MPEG CoP #3-R2 FEC[1] >> >> We are still in the process of testing this patch wi

Re: [FFmpeg-devel] [PATCH] tests/checkasm: prevent a segmentation fault when calling strncmp()

2025-01-16 Thread Sean McGovern
On Thu, Jan 16, 2025 at 4:04 PM Martin Storsjö wrote: > > On Thu, 16 Jan 2025, Sean McGovern wrote: > > >> This feels like less of an issue with strncmp, and more of an issue with > >> the spec for main() and argc/argv; how do you do to end up with a NULL > >> entry in argv[i] for 0 <= i < argc? >

[FFmpeg-devel] [PATCH] avcodec/hevc/hevcdec: Don't add to null pointer

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
`POS(1,` and `POS(2,` may trigger UBSAN report: "runtime error: applying non-zero offset 304 to null pointer" Looks like values are not used without `chroma_format_idc`, so maybe there is no other issues than the UB. Can't reproduce with "fate". Signed-off-by: Vitaly Buka --- libavcodec/hevc/h

Re: [FFmpeg-devel] [PATCH 1/2] .gitignore: ignore fate-suite

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
Sorry, I messed up my subscription, so will reply slightly off-thread. Timo Rothenpieler via ffmpeg-devel wrote: > I don't think the fate-suite should be sitting in the source tree. > Also, there is no guarantee every user/developer will name it that exact > name? Or is that where it gets synce

Re: [FFmpeg-devel] [PATCH] doc/protocols: fix/improve RTP documentation

2025-01-16 Thread Michael Niedermayer
On Wed, Jan 15, 2025 at 05:27:39PM +0100, Stefan Pöschel via ffmpeg-devel wrote: > Signed-off-by: Stefan Pöschel > --- > doc/protocols.texi | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/doc/protocols.texi b/doc/protocols.texi > index ed70af4b33..969f4bf0

Re: [FFmpeg-devel] [PATCH] tests/checkasm: prevent a segmentation fault when calling strncmp()

2025-01-16 Thread Sean McGovern
Hi Martin, On Thu, Jan 16, 2025 at 3:44 PM Martin Storsjö wrote: > > On Thu, 16 Jan 2025, Sean McGovern wrote: > > > The POSIX specification for strncmp()[1] leaves this behaviour as > > undefined if either pointer argument is NULL. > > > > Prevent a segmentation fault by ensuring 'arg' is non-NU

Re: [FFmpeg-devel] [PATCH] doc/protocols: fix/improve RTP documentation

2025-01-16 Thread Stefan Pöschel via ffmpeg-devel
Sorry, I tried git send-email the first time and didn't check the wrapping before sending. Please find the patch attached as file. Am 16.01.25 um 20:47 schrieb Michael Niedermayer: On Wed, Jan 15, 2025 at 05:27:39PM +0100, Stefan Pöschel via ffmpeg-devel wrote: Signed-off-by: Stefan Pöschel --

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/flvdec: implement support for parsing ModEx data

2025-01-16 Thread Leo Izen
On 1/15/25 5:41 PM, Timo Rothenpieler wrote: --- libavformat/flv.h| 5 libavformat/flvdec.c | 68 2 files changed, 73 insertions(+) diff --git a/libavformat/flv.h b/libavformat/flv.h index 74d3b8de8b..d8f7980f2e 100644 --- a/libavformat/

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/flvdec: implement support for parsing ModEx data

2025-01-16 Thread Timo Rothenpieler
On 17.01.2025 00:16, Leo Izen wrote: On 1/15/25 5:41 PM, Timo Rothenpieler wrote: ---   libavformat/flv.h    |  5   libavformat/flvdec.c | 68   2 files changed, 73 insertions(+) diff --git a/libavformat/flv.h b/libavformat/flv.h index 74d3b8de8b

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/flvdec: implement support for parsing ModEx data

2025-01-16 Thread Leo Izen
On 1/16/25 6:32 PM, Timo Rothenpieler wrote: On 17.01.2025 00:16, Leo Izen wrote: On 1/15/25 5:41 PM, Timo Rothenpieler wrote: ---   libavformat/flv.h    |  5   libavformat/flvdec.c | 68   2 files changed, 73 insertions(+) diff --git a/libavfor