[FFmpeg-devel] [PATCH 1/4] lavc/riscv: Move VVC macro to h26x

2024-11-17 Thread uk7b
From: sunyuechi --- libavcodec/riscv/h26x/asm.S | 127 ++ libavcodec/riscv/vvc/vvc_mc_rvv.S | 117 ++- 2 files changed, 132 insertions(+), 112 deletions(-) create mode 100644 libavcodec/riscv/h26x/asm.S diff --git a/libavcodec/riscv/h26

[FFmpeg-devel] [PATCH 3/4] lavc/hevc: R-V V put_pixels(pow2)

2024-11-17 Thread uk7b
From: sunyuechi k230 banana_f3 put_hevc_pel_pixels4_8_c: 61.6 ( 1.00x)69.5 ( 1.00x) put_hevc_pel_pixels4_8_rvv_i32: 24.6 ( 2.50x)28.0 ( 2.48x) put_hevc_pel_pixels8_8_c: 209.8 ( 1.00x)215.5 ( 1.00x)

Re: [FFmpeg-devel] [PATCH] Fix incorrect enum type used for a local variable

2024-11-17 Thread Marth64
Will push 12-24 hrs ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 4/4] lavc/vvc_mc R-V V sad

2024-11-17 Thread uk7b
From: sunyuechi k230 banana_f3 sad_8x16_c: 385.9 ( 1.00x)403.1 ( 1.00x) sad_8x16_rvv_i32:108.1 ( 3.57x)100.8 ( 4.00x) sad_16x8_c: 376.6 ( 1.00x)392.6 ( 1.00x) sad_16x8_rvv_i32: 89.3 ( 4

Re: [FFmpeg-devel] [PATCH 4/4] lavc/vvc_mc R-V V sad

2024-11-17 Thread Rémi Denis-Courmont
Le sunnuntaina 17. marraskuuta 2024, 15.16.23 EET u...@foxmail.com a écrit : > From: sunyuechi > > k230 banana_f3 > sad_8x16_c: 385.9 ( 1.00x)403.1 ( 1.00x) > sad_8x16_rvv_i32:108.1 ( 3.57x)100.8 ( 4.00x) > sad_16x8_c:

[FFmpeg-devel] [PATCH] lavu/riscv: fix compilation without Vector support

2024-11-17 Thread Rémi Denis-Courmont
The half-baked assembler in Clang 16 and earlier can't process our RISC-V assembler. This adds yet another work around that. If you must use Clang, please use version 17 or later. --- libavutil/riscv/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/riscv/cpu.h b

[FFmpeg-devel] [PATCH 03/11] avformat/test/movenc: set audio packets as key frames

2024-11-17 Thread James Almer
Don't depend on the generic code setting this. This is in preparation for a following change. Signed-off-by: James Almer --- libavformat/tests/movenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/tests/movenc.c b/libavformat/tests/movenc.c index 2fd5c67e76..23a827e97c 100644

Re: [FFmpeg-devel] [PATCH] lavu/riscv: fix compilation without Vector support

2024-11-17 Thread Brad Smith
On 2024-11-17 4:17 a.m., Rémi Denis-Courmont wrote: The half-baked assembler in Clang 16 and earlier can't process our RISC-V assembler. This adds yet another work around that. If you must use Clang, please use version 17 or later. LGTM. Fixes build with 16. --- libavutil/riscv/cpu.h | 2

Re: [FFmpeg-devel] [PATCH 01/11] avformat/spdifenc: parse headers for audio codecs

2024-11-17 Thread James Almer
On 11/18/2024 12:06 AM, Peter Ross wrote: On Sun, Nov 17, 2024 at 11:04:13PM -0300, James Almer wrote: Signed-off-by: James Almer --- libavformat/spdifdec.c |2 + subject line says avformat/spdifENC, but changes are only to the decoder. Ah, thanks for spotting it. F

Re: [FFmpeg-devel] [PATCH 01/11] avformat/spdifenc: parse headers for audio codecs

2024-11-17 Thread Peter Ross
On Sun, Nov 17, 2024 at 11:04:13PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/spdifdec.c |2 + subject line says avformat/spdifENC, but changes are only to the decoder. > tests/ref/fate/spdif-dca-core-remux| 14 +- > tests/ref/fa

[FFmpeg-devel] [PATCH 07/11] avcodec/aac/aacdec: set key frame flag in output frames

2024-11-17 Thread James Almer
Don't depend on the generic code setting this. This is in preparation for a following change. Signed-off-by: James Almer --- libavcodec/aac/aacdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index f6e79700d5..717ad8aa90 100644 --- a/l

[FFmpeg-devel] [PATCH 02/11] avformat/movenc: write stss boxes for xHE-AAC

2024-11-17 Thread James Almer
This is in preparation for a following change. Signed-off-by: James Almer --- libavformat/movenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 4152149ec1..7563ff2628 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -3201,6

[FFmpeg-devel] [PATCH 01/11] avformat/spdifenc: parse headers for audio codecs

2024-11-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/spdifdec.c |2 + tests/ref/fate/spdif-dca-core-remux| 14 +- tests/ref/fate/spdif-dca-master-core-remux | 2344 ++-- 3 files changed, 1181 insertions(+), 1179 deletions(-) diff --git a/libavformat/spdifd

[FFmpeg-devel] [PATCH] libavutil/riscv: Make use of elf_aux_info() on FreeBSD / OpenBSD riscv

2024-11-17 Thread Brad Smith
libavutil/riscv: Make use of elf_aux_info() on FreeBSD / OpenBSD riscv FreeBSD/OpenBSD riscv have elf_aux_info(). Signed-off-by: Brad Smith --- libavutil/riscv/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/riscv/cpu.c b/libavutil/riscv/cpu.c index 4ec6d

[FFmpeg-devel] [PATCH 2/2] avcodec/libfdk-aacenc: export CPB properties

2024-11-17 Thread James Almer
Needed to signal the muxer that the stream is VBR. Finishes fixing ticket #11303. Signed-off-by: James Almer --- libavcodec/libfdk-aacenc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/libfdk-aacenc.c b/libavcodec/libfdk-aacenc.c index 1a9df88c13..4dcfb25db7 100644 --

[FFmpeg-devel] [PATCH 1/2] avformat/movenc: don't write a calculated avgBitrate when the provided one is unset

2024-11-17 Thread James Almer
avgBitrate == 0 is used to signal a VBR track, so if that value is propagated by an encoder, don't overwrite it with a calculated value based on track size. Part of a fix for ticket #11303. Signed-off-by: James Almer --- libavformat/movenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[FFmpeg-devel] [PATCH 05/11] avformat/mov: don't unconditionally set all audio packets in fragments as key frames

2024-11-17 Thread James Almer
Some audio codecs, like TrueHD, have non key frames. Signed-off-by: James Almer --- libavformat/mov.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 954ff657a9..0bc5327d10 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c

[FFmpeg-devel] [PATCH 09/11] avcodec/libfdk-aacdec: set key frame flag and profile in output frames

2024-11-17 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libfdk-aacdec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/libfdk-aacdec.c b/libavcodec/libfdk-aacdec.c index 1324377fb4..ac221645f0 100644 --- a/libavcodec/libfdk-aacdec.c +++ b/libavcodec/libfdk-aacdec.c @@ -11

[FFmpeg-devel] [PATCH 08/11] avcodec/aacenc: set key frame flag in output packets

2024-11-17 Thread James Almer
Don't depend on the generic code setting this. This is in preparation for a following change. Signed-off-by: James Almer --- libavcodec/aacenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index 88037c7f87..3ff61f788b 100644 --- a/libavcodec/aa

[FFmpeg-devel] [PATCH 06/11] avcodec/aac_parser: set key_frame and profile

2024-11-17 Thread James Almer
This is in preparation for a following change. Signed-off-by: James Almer --- libavcodec/aac_ac3_parser.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/libavcodec/aac_ac3_parser.c b/libavcodec/aac_ac3_parser.c index f45631d09f..2b4f92dd18 100644 --- a/libav

[FFmpeg-devel] [PATCH 10/11] avcodec/libfdk-aacenc: set keyframe in output packets

2024-11-17 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libfdk-aacenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/libfdk-aacenc.c b/libavcodec/libfdk-aacenc.c index 0f33cdb8c9..1a9df88c13 100644 --- a/libavcodec/libfdk-aacenc.c +++ b/libavcodec/libfdk-aacenc.c @@ -540,6 +540,7 @@ static in

[FFmpeg-devel] [PATCH 1/2] avcodec/h2645_parse: Ignore NAL with nuh_layer_id == 63

2024-11-17 Thread Michael Niedermayer
Comply with "For purposes other than determining the amount of data in the decoding units of the bitstream, decoders shall ignore all data that follow the value 63 for nuh_layer_id in a NAL unit" Rec. ITU-T H.265 v8 (08/2021) Page 67 Fixes: index 63 out of bounds for type 'const int8_t[63]' (a

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add missing ISO/IEC 15444-4 conformance tests

2024-11-17 Thread Pierre-Anthony Lemieux
On Mon, Nov 11, 2024 at 12:19 AM WATANABE Osamu wrote: > > I have confirmed that these failures in FATE were due to the insufficient > floating point precision of a 32-bit environment. > > The commit 82467b635efced67c1767cb810af1f3c31a2e493 introduces the improved > dequantization in FF_DWT97_IN

Re: [FFmpeg-devel] [PATCH 2/2] avformat/rpl: Fix check for negative values

2024-11-17 Thread Rémi Denis-Courmont
Hi, Le 18 novembre 2024 05:09:11 GMT+02:00, Michael Niedermayer a écrit : >Fixes: signed integer overflow: 10 * -192326792533340 cannot be >represented in type 'int64_t' (aka 'long') >Fixes: >378891963/clusterfuzz-testcase-minimized-fuzzer_loadfile_direct-5714338935013376 >Found-by: ossfuz

Re: [FFmpeg-devel] [PATCH 2/3] doc/developer: Document how disagreements should be handled

2024-11-17 Thread Kieran Kunhya via ffmpeg-devel
On Sun, 17 Nov 2024, 10:03 Anton Khirnov, wrote: > Quoting Michael Niedermayer (2024-11-17 01:42:20) > > I think this would work better than TC or nothing process. > > > > Signed-off-by: Michael Niedermayer > > --- > > doc/developer.texi | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff

Re: [FFmpeg-devel] [RFC] dormant git accounts

2024-11-17 Thread Michael Niedermayer
On Wed, Nov 13, 2024 at 12:58:40PM +0100, Michael Niedermayer wrote: > Hi > > On Sun, Nov 10, 2024 at 07:44:11PM +0100, Michael Niedermayer wrote: > > Hi all > > > > On Sat, Nov 09, 2024 at 05:18:08PM +0100, Michael Niedermayer wrote: > > > Hi all > > > > > > Should we disable git accounts for d

[FFmpeg-devel] [PATCH] Revert "lavc/rv40dsp: R-V V chroma_mc"

2024-11-17 Thread Rémi Denis-Courmont
This reverts commit 5bc3b7f51308b8027e5468ef60d8336a960193e2. put_chroma_mc4, put_chroma_mc8 and avg_chroma_mc8 are confirmed to break `fate-rv40`. It is probably just luck that avg_chroma_mc4 does not also fail. Fixes #11306. --- libavcodec/riscv/Makefile | 2 - libavcodec/riscv/rv40dsp

[FFmpeg-devel] [PATCH] lavc/h264dsp: fix R-V V weight_pixels pointer arithmetic

2024-11-17 Thread Rémi Denis-Courmont
As of 459a1512f13ae1fdd404ff9281b02d225ac70a09, the code is unrolled to process two rows per iteration. The output cursor thus needs to be incremented by twice the stride, which is taken care of with SH1ADD. However the original ADD from the original implemetation was incorrectly left over. --- li

[FFmpeg-devel] [PATCH 3/3] doc/developer: Duties of a maintainer

2024-11-17 Thread Michael Niedermayer
Not sure we have such a list elsewhere, i failed to find it Signed-off-by: Michael Niedermayer --- doc/developer.texi | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index 2af71ed749a..3a942b19627 100644 --- a/doc/developer.texi +++

Re: [FFmpeg-devel] [PATCH v3 10/10] ffv1enc: add a Vulkan encoder

2024-11-17 Thread Lynne via ffmpeg-devel
On 11/17/24 13:38, Jerome Martinez wrote: Le 17/11/2024 à 01:19, Lynne via ffmpeg-devel a écrit : I'll push the patchset tomorrow if there are no more comments to fix. As it silently creates bad streams with some pix_fmts, please mandate -strict -2 for the moment. I would like to point ou

Re: [FFmpeg-devel] [PATCH 2/3] doc/developer: Document how disagreements should be handled

2024-11-17 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-11-17 01:42:20) > I think this would work better than TC or nothing process. > > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 78053a4623

Re: [FFmpeg-devel] [PATCH 2/3] doc/developer: Document how disagreements should be handled

2024-11-17 Thread Rémi Denis-Courmont
Le sunnuntaina 17. marraskuuta 2024, 2.42.20 EET Michael Niedermayer a écrit : > I think this would work better than TC or nothing process. > > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/developer.texi b/doc/deve

[FFmpeg-devel] [PATCH] lavc/vvc: Add missing bounds for first subpic size

2024-11-17 Thread Frank Plowman
Add missing upper bounds for the width and height of the first subpicture. Corresponding bounds were added for all other subpictures in 01701bd, but were not included for the first subpicture (which has slightly different syntax). Signed-off-by: Frank Plowman --- libavcodec/cbs_h266_syntax_temp

Re: [FFmpeg-devel] [PATCH v3 10/10] ffv1enc: add a Vulkan encoder

2024-11-17 Thread Jerome Martinez
Le 17/11/2024 à 01:19, Lynne via ffmpeg-devel a écrit : I'll push the patchset tomorrow if there are no more comments to fix. As it silently creates bad streams with some pix_fmts, please mandate -strict -2 for the moment. ___ ffmpeg-devel mailing l

[FFmpeg-devel] [PATCH 04/11] avformat/matroskadec: set all frames in a key frame simple box as key frames

2024-11-17 Thread James Almer
And not just the first, as it was being done for lacing. The spec states that the flag applies to everything inside the simple box. Signed-off-by: James Almer --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavforma

Re: [FFmpeg-devel] [RFC] dormant git accounts

2024-11-17 Thread compn
On Wed, 13 Nov 2024 12:58:40 +0100 Michael Niedermayer wrote: > So heres the list of people who will have git write access after > dormant accounts are disabled. All the ones here where active in the > last 10 years as a committer in FFmpeg. Noone is added, everyone from > this list had access be