Re: [FFmpeg-devel] [PATCH v3] libavutil/ppc: Make use of getauxval() and elf_aux_info() on ppc

On Fri, 20 Sep 2024, Brad Smith wrote: ping. On 2024-09-15 1:40 a.m., Brad Smith wrote: libavutil/ppc: Make use of getauxval() and elf_aux_info() on ppc Modern Linux has getauxval() and FreeBSD/OpenBSD ppc have elf_aux_info(). Signed-off-by: Brad Smith --- v2: adjust to build with older g

[FFmpeg-devel] [PATCH] doc: Add email URLs for Fate samples-request

v2 adds the address as a second (L: ...)-entry to the Fate info in MAINTAINERS. I'm not sure if this is correct because I couldn't find other lines, where the same kind of entry gets used twice. Btw.: the fate info and the "webserver"-entry one line above use (S:...)-entries, which aren't menti

[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: ensure that the inserted filters exist

If not, report it as a bug. avfilter_graph_create_filter() will return ENOMEM if the passed filter argument is NULL, which is misleading. Signed-off-by: James Almer --- fftools/ffmpeg_filter.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_filter.c b/fft

[FFmpeg-devel] [PATCH 1/2] configure: add missing filter dependencies to ffmpeg

Signed-off-by: James Almer --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index d568739bf9..f07f6c7c46 100755 --- a/configure +++ b/configure @@ -4055,8 +4055,8 @@ avutil_extralibs="d3d11va_extralibs d3d12va_extralibs mediacodec_extral

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: ensure that the inserted filters exist

On 9/20/2024 10:30 AM, James Almer wrote: If not, report it as a bug. avfilter_graph_create_filter() will return ENOMEM if the passed filter argument is NULL, which is misleading. Signed-off-by: James Almer --- fftools/ffmpeg_filter.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(

[FFmpeg-devel] [PATCH v3] avcodec/vvc: Don't use large array on stack

From: Zhao Zhili tmp_array in dmvr_hv takes 33024 bytes on stack, which can be dangerous. --- libavcodec/vvc/inter_template.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/libavcodec/vvc/inter_template.c b/libavcodec/vvc/inter_template.c index

Re: [FFmpeg-devel] [PATCH v2] avcodec/vvc: Don't use large array on stack

> On Sep 20, 2024, at 11:43, Zhao Zhili wrote: > > From: Zhao Zhili > > tmp_array in dmvr_hv takes 33024 bytes on stack, which can be > dangerous. I prefer version 3 personally https://ffmpeg.org/pipermail/ffmpeg-devel/2024-September/333709.html > --- > libavcodec/vvc/ctu.h |

Re: [FFmpeg-devel] [PATCH 2/3] - libavcodec/aom_film_grain: Add apply_grain flag

Hello. Disclaimer: I'm not the owner/maintainer of any of that code, nor do I know who is. Le ven. 20 sept. 2024 à 02:44, Segall, Andrew via ffmpeg-devel a écrit : > case AV_FILM_GRAIN_PARAMS_AV1: > - ret = ff_aom_apply_film_grain(out->frame_grain, out->f, fgp); > + if(fgp->apply_grain) > + ret

Re: [FFmpeg-devel] [PATCH 2/3] - libavcodec/aom_film_grain: Add apply_grain flag

On 9/20/24, 12:15 AM, "ffmpeg-devel on behalf of Lynne via ffmpeg-devel" mailto:ffmpeg-devel-boun...@ffmpeg.org> on behalf of ffmpeg-devel@ffmpeg.org > wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachme

Re: [FFmpeg-devel] [PATCH 2/3] - libavcodec/aom_film_grain: Add apply_grain flag

On 20/09/2024 02:44, Segall, Andrew via ffmpeg-devel wrote: Details: Add support for the apply_grain_flag. This allows the film grain process to be enabled/disabled for different display properties. On 9/8/24, 12:06 AM, "Andrew Segall" mailto:aseg...@amazon.com>> wrote: Signed-off-by: Andre

Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

Were there any more comments for this patch? - dale On Tue, Aug 13, 2024 at 11:30 PM Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > Hi, > > Le mar. 13 août 2024 à 23:39, Dale Curtis a > écrit : > > > > On Tue, Aug 13, 2024 at 1:11 PM Hendrik Leppkes > wrote: > > > > > Disabling ra

[FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg: auto insert enhancement filters when available

This is an alternative to https://ffmpeg.org//pipermail/ffmpeg-devel/2024-September/96.html where things are left to the caller and we don't rely on lavc applying the LCEVC metadata at the end of the decoding process. Signed-off-by: James Almer --- configure | 2 +- fftools/

Re: [FFmpeg-devel] [RFC] [PATCH] avcodec/cbs_h266: Fix copy paste mistake

Hi Marvin, Thanks for this patch and sorry for not getting around to it sooner. Patch LGTM, yes it is a mistake I made when copy-pasting the logic for the width -- sorry about that! Thanks again, Frank On 31/08/2024 22:25, Marvin Scholz wrote: > The us macro expect the range_max here, which see

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/cbs_h266_syntax_template: Check bit depth with range extension

On 20/09/2024 01:54, James Almer wrote: > On 9/19/2024 9:34 PM, Michael Niedermayer wrote: >> On Thu, Sep 19, 2024 at 08:53:07PM -0300, James Almer wrote: >>> On 9/19/2024 7:56 PM, Michael Niedermayer wrote: Fixes: shift exponent 62 is too large for 32-bit type 'int' Fixes: 71020/clu

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: Add handling HDR10+ sidedata on cuviddec.

> It's just that the cuviddec decoder is more of a relic, from before the > native hwaccel existed. > The only reason it's not straight up deprecated is that it's sometimes > nice to have a "second opinion" when issues crop up, and there are a few > specific features like hardware-deinterlacing tha

[FFmpeg-devel] [PATCH] avcodec/videotoolbox: add AV1 hardware acceleration

From: Jan Ekström Co-authored-by: Ruslan Chernenko Co-authored-by: Martin Storsjö --- This is a touched up version of Jan and Ruslan's patches for AV1 hwaccel via videotoolbox; I tried to polish the code a little by not overwriting avctx->extradata in ff_videotoolbox_av1c_extradata_create, and

Re: [FFmpeg-devel] [PATCH v3] libavutil/ppc: Make use of getauxval() and elf_aux_info() on ppc

ping. On 2024-09-15 1:40 a.m., Brad Smith wrote: libavutil/ppc: Make use of getauxval() and elf_aux_info() on ppc Modern Linux has getauxval() and FreeBSD/OpenBSD ppc have elf_aux_info(). Signed-off-by: Brad Smith --- v2: adjust to build with older glibc. v3: freebsd/ppc requires machine/cpu.

Re: [FFmpeg-devel] [PATCH] vulkan_encode: set the quality level in session parameters

On 20/09/2024 13:33, Víctor Manuel Jáquez Leal wrote: While running this command ./ffmpeg_g -loglevel debug -hwaccel vulkan -init_hw_device vulkan=vk:0,debug=1 -hwaccel_output_format vulkan -i input.y4m -vf 'format=nv12,hwupload' -c:v h264_vulkan -quality 2 output.mp4 -y It hit this validatio

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: Add handling HDR10+ sidedata on cuviddec.

Le 20/09/2024 à 20:41, Carlos Ruiz a écrit :> The native hevc codec doesn't > support resizing, so you decode video at full 4k on the gpu, which means > allocating > something like 5-10 surfaces at 3840x2160 which becomes 250MB of GPU memory, > and then you have immediately take all of those frames

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: Add handling HDR10+ sidedata on cuviddec.

On 20/09/2024 20:41, Carlos Ruiz wrote: It's just that the cuviddec decoder is more of a relic, from before the native hwaccel existed. The only reason it's not straight up deprecated is that it's sometimes nice to have a "second opinion" when issues crop up, and there are a few specific features

Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

On 20/09/2024 20:51, Dale Curtis wrote: Were there any more comments for this patch? - dale On Tue, Aug 13, 2024 at 11:30 PM Christophe Gisquet < christophe.gisq...@gmail.com> wrote: Hi, Le mar. 13 août 2024 à 23:39, Dale Curtis a écrit : On Tue, Aug 13, 2024 at 1:11 PM Hendrik Leppkes

Re: [FFmpeg-devel] [PATCH] doc: Add email URLs for Fate sample-request

On Fri, Sep 20, 2024 at 02:50:18AM +0200, Martin Schitter wrote: > Because I'm now waiting for one week that someone finally puts my > contributed DNxUncompressed sample files to the Fate sample repo > (see: > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2024-September/333471.html), > I frequen

Re: [FFmpeg-devel] [PATCH 2/3] - libavcodec/aom_film_grain: Add apply_grain flag

On 20/09/2024 09:42, Segall, Andrew wrote: On 9/20/24, 12:15 AM, "ffmpeg-devel on behalf of Lynne via ffmpeg-devel" mailto:ffmpeg-devel-boun...@ffmpeg.org> on behalf of ffmpeg-devel@ffmpeg.org > wrote: CAUTION: This email originated from outside of the organ

Re: [FFmpeg-devel] [PATCH 1/3] - libavcodec/aom_film_grain: Handle byte alignment when multiple film grain parameters sets are present in the bitstream

On Fri, Sep 20, 2024 at 12:42:47AM +, Segall, Andrew via ffmpeg-devel wrote: > More info: Series of patches to align the implementation of aom_film_grain.c > with the AOM specification. > > First time committing. Suggestions very welcome. > > Signed-off-by: Andrew Segall mailto:aseg...@amaz

Re: [FFmpeg-devel] [PATCH 1/7] avformat/mov_chan: Check for FF_SANE_NB_CHANNELS

Quoting Michael Niedermayer (2024-09-17 19:59:53) > On Sun, Sep 15, 2024 at 09:09:39PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-09-13 19:48:46) > [...] > > > > > > > > > +#include "libavcodec/internal.h" > > > > > > > > I dislike this as well. > > > > > > I am fine with

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: Add handling HDR10+ sidedata on cuviddec.

On 20/09/2024 04:08, 김윤주 wrote: Does native decoder refer to hevc (hevcdec.c)? I tried using hevc and in environments with low CPU performance, hevc_cuvid was much faster. So, I used hevc_cuvid for decoding but encountered an issue where HDR10+ sidedata did not exist. That's why I wrote this patc

[FFmpeg-devel] [PATCH] vulkan_encode: set the quality level in session parameters

While running this command ./ffmpeg_g -loglevel debug -hwaccel vulkan -init_hw_device vulkan=vk:0,debug=1 -hwaccel_output_format vulkan -i input.y4m -vf 'format=nv12,hwupload' -c:v h264_vulkan -quality 2 output.mp4 -y It hit this validation error: Validation Error: [ VUID-vkCmdEncodeVideoKHR-N