On 20/09/2024 20:51, Dale Curtis wrote:
Were there any more comments for this patch?- dale On Tue, Aug 13, 2024 at 11:30 PM Christophe Gisquet < christophe.gisq...@gmail.com> wrote:Hi, Le mar. 13 août 2024 à 23:39, Dale Curtis <dalecur...@chromium.org> a écrit :On Tue, Aug 13, 2024 at 1:11 PM Hendrik Leppkes <h.lepp...@gmail.com>wrote:Disabling random codec features seems like an anti-feature to me, in the future it'll make every feature be questioned and compile-time conditional, and make everything terrible. If the context size is the major concern, maybe large structures should be allocated when in use, rather than always?I agree with that, so here's a version which allocates dynamicallyinstead.It passes FATE, but I didn't try with valgrind/msan in case I missed a cleanup path.(not an author) Probably there is remaining work pending on external dependencies, but H274FilmGrainDatabase sounds a bit adhoc. The 8KB of slice_tmp for one could just be a local variable in init_slice(). The 676KB (!) of the noise database are a bit more puzzling and could be the one that needs allocating only when the noise is generated. It may simplify a bit some of the conditions in this patch. -- Christophe
I agree with Hendrik and Dale.
OpenPGP_0xA2FEA5F03F034464.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
