Re: [FFmpeg-devel] [PATCH 3/3] scale_qsv frame crop support

2024-09-12 Thread Wang, Fei W
On Tue, 2024-09-10 at 11:10 -0700, Koushik Dutta wrote: > The crop filter has no effect on scale_qsv: > > -vf crop=100:100,scale_qsv=300x300 > How about to use vpp_qsv filter directly? It support both scale and crop via its options which is much more easy to use. Thanks Fei > Hardware frames (

[FFmpeg-devel] Procedure to enable the Windows on ARM64 FFMPEG Libraries

2024-09-12 Thread Niranjan Kshatriya (QUIC)
Hi team, I am working on Windows on ARM application development and wants to execute FFMPEG on my device. On FFMPEG download page (Releases * BtbN/FFmpeg-Builds (github.com)) "windows on Arm" binary is not available (Other binaries(x64 and linux A

[FFmpeg-devel] [PATCH] lavc: Fix epirats suggestions

2024-09-12 Thread Petro Mozil
Thanks for the review! Sorry about the mistakes, fixed them Signed-off-by: Petro Mozil --- libavcodec/diracdec.c | 1275 +++-- libavcodec/vulkan_dirac.c | 52 +- 2 files changed, 687 insertions(+), 640 deletions(-) diff --git a/libavcodec/diracdec.c b/libav

Re: [FFmpeg-devel] [PATCH 2/2] lavc: Add dirac vulkan hwaccel

2024-09-12 Thread Petro Mozil
Thanks for the review! Sorry about those mistakes, fixed them here --- libavcodec/diracdec.c | 1275 +++-- libavcodec/vulkan_dirac.c | 52 +- 2 files changed, 687 insertions(+), 640 deletions(-) diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c inde

Re: [FFmpeg-devel] [PATCH] tests/checkasm/sw_rgb: don't write random data past the end of the buffer

2024-09-12 Thread Ramiro Polla
On Thu, Sep 12, 2024 at 8:44 AM James Almer wrote: > > Should fix fate-checkasm-sw_rgb under gcc-ubsan. > > Signed-off-by: James Almer > --- > tests/checkasm/sw_rgb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c > inde

[FFmpeg-devel] [PATCH 3/3] lavc: add hevc_vulkan hardware encoder

2024-09-12 Thread Lynne via ffmpeg-devel
This commit adds a Vulkan hardware HEVC encoder, with full support of the spec - I, P, and B-frames. --- configure |1 + libavcodec/Makefile |3 + libavcodec/allcodecs.c |1 + libavcodec/vulkan_encode_h264.c | 14 +- libavcodec/vulkan_encode

[FFmpeg-devel] [PATCH 1/3] cbs_h265: add raw filler encoding

2024-09-12 Thread Lynne via ffmpeg-devel
From: Dave Airlie --- libavcodec/cbs_h2645.c| 17 libavcodec/cbs_h265.h | 6 ++ libavcodec/cbs_h265_syntax_template.c | 29 +++ 3 files changed, 52 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2

[FFmpeg-devel] [PATCH 2/3] hw_base_encode_h265: split off SPS/PPS/VPS generation from VAAPI

2024-09-12 Thread Lynne via ffmpeg-devel
--- libavcodec/hw_base_encode_h265.c | 351 +++ libavcodec/hw_base_encode_h265.h | 56 + 2 files changed, 407 insertions(+) create mode 100644 libavcodec/hw_base_encode_h265.c create mode 100644 libavcodec/hw_base_encode_h265.h diff --git a/libavcodec/hw_base_en

Re: [FFmpeg-devel] [PATCH] tests/checkasm/sw_rgb: don't write random data past the end of the buffer

2024-09-12 Thread Martin Storsjö
On Thu, 12 Sep 2024, Ramiro Polla wrote: On Thu, Sep 12, 2024 at 8:44 AM James Almer wrote: Should fix fate-checkasm-sw_rgb under gcc-ubsan. Signed-off-by: James Almer --- tests/checkasm/sw_rgb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/sw_rgb.c b/

Re: [FFmpeg-devel] Procedure to enable the Windows on ARM64 FFMPEG Libraries

2024-09-12 Thread Martin Storsjö
On Thu, 12 Sep 2024, Niranjan Kshatriya (QUIC) wrote: and compiled locally ( on ARM using WSL ) for Arm with tool chain : GitHub - Windows-on-ARM-Experiments/mingw-woarm64-build: Workflows and build scripts for Windows on Arm64 GNU cross-compiler for `aarch64-w64-mingw32` target.

[FFmpeg-devel] [PATCH v5] avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4

2024-09-12 Thread Osamu Watanabe
Fix for the integer version of the inverse 9-7 DWT processing (FF_DWT97_INT, https://trac.ffmpeg.org/ticket/10123), which is activated with `-flags +bitexact`. I went through the code path for the DWT 9-7 transform (integer) and improved precision to match conformance codestream. As a result, the

Re: [FFmpeg-devel] [PATCH v2 00/14] aarch64/vvc: Add SIMD

2024-09-12 Thread Martin Storsjö
On Thu, 12 Sep 2024, Zhao Zhili wrote: From: Zhao Zhili Patches 1~9 has been updated according to Martin's review. Patches 10~14 are new. I have created a PR on github: https://github.com/quink-black/FFmpeg/pull/2 Thanks for testing it through that set of tests! No further comments from m

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: Recognize and Ignore MXF fill boxes

2024-09-12 Thread Nicolas Gaullier
>De : ffmpeg-devel De la part de martin >schitter >Envoyé : jeudi 12 septembre 2024 02:36 > >But an elementary feature like 'fill' should be simply supported by any MXF >demuxer in a suitable manner, otherwise it's IMHO a grave defect. >If you don't see any further objections, please just merge

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: Recognize and Ignore MXF fill boxes

2024-09-12 Thread martin schitter
On 12.09.24 13:14, Nicolas Gaullier wrote: The message "Recognize and Ignore" does not make it clear what issue or grave defect is solved here. I see in the code that fill items are currently recognized as dark metadata and ignored likewise, but I don't see any issue here. Maybe could you co

Re: [FFmpeg-devel] [PATCH] tests/checkasm/sw_rgb: don't write random data past the end of the buffer

2024-09-12 Thread James Almer
On 9/12/2024 5:16 AM, Ramiro Polla wrote: On Thu, Sep 12, 2024 at 8:44 AM James Almer wrote: Should fix fate-checkasm-sw_rgb under gcc-ubsan. Signed-off-by: James Almer --- tests/checkasm/sw_rgb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/sw_rgb.c

Re: [FFmpeg-devel] [PATCH 1/2] lavc: add Vulkan video encoding base code

2024-09-12 Thread Benjamin Cheng via ffmpeg-devel
On Wed Sep 11, 2024 at 12:03 AM EDT, Lynne wrote: > On 10/09/2024 15:29, Benjamin Cheng wrote: > > On Mon Sep 9, 2024 at 6:37 AM EDT, Lynne via ffmpeg-devel wrote: > >> This commit adds the common Vulkan video encoding framework. > >> It makes full use of the asynchronous features of our new common

Re: [FFmpeg-devel] is libswscale maintained?

2024-09-12 Thread Ramiro Polla
Hi, On Wed, Sep 11, 2024 at 2:21 AM Michael Niedermayer wrote: > On Wed, Sep 11, 2024 at 02:45:59AM +0300, Andrew Randrianasulu wrote: > > https://trac.ffmpeg.org/ticket/3345 > > https://trac.ffmpeg.org/ticket/7978 > > I was not aware of these and ATM i dont have time but > these smell like some

Re: [FFmpeg-devel] is libswscale maintained?

2024-09-12 Thread Rémi Denis-Courmont
Le 12 septembre 2024 16:43:29 GMT+03:00, Ramiro Polla a écrit : >Hi, > >On Wed, Sep 11, 2024 at 2:21 AM Michael Niedermayer > wrote: >> On Wed, Sep 11, 2024 at 02:45:59AM +0300, Andrew Randrianasulu wrote: >> > https://trac.ffmpeg.org/ticket/3345 >> > https://trac.ffmpeg.org/ticket/7978 >> >> I

Re: [FFmpeg-devel] [PATCH] lavc/vvc_mc: R-V V avg w_avg

2024-09-12 Thread flow gg
ping flow gg 于2024年8月28日周三 14:38写道: > Updated: zve32x -> zve32x, zbb, zba > > 于2024年8月28日周三 14:37写道: > >> From: sunyuechi >> >> C908 X60 >> avg_8_2x2_c:1.21.0 >> avg_8_2x2_rvv_i32

[FFmpeg-devel] [PATCH 11/11] avfilter: add an LCEVC decoding filter via LCEVCdec

2024-09-12 Thread James Almer
Signed-off-by: James Almer --- configure| 1 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h| 4 +- libavfilter/vf_lcevc.c | 434 +++ 5 files changed, 439 insertions(+), 2 deletions(-) creat

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/decode: Check progress before dereferencing

2024-09-12 Thread Michael Niedermayer
On Tue, Jun 25, 2024 at 09:51:32PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Sat, Apr 27, 2024 at 01:13:54PM +0200, Andreas Rheinhardt wrote: > >> Michael Niedermayer: > >>> Fixes: NULL pointer dereference > >>> Fixes: > >>> 68192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC

[FFmpeg-devel] [PATCH v3 1/2] configure: fix symbol prefix detection

2024-09-12 Thread Marvin Scholz
The symbol prefix check would incorrectly detect a bogus prefix in circumstances where sanitizers instrument the build, like when configuring with the clang-asan toolchain where it would detect the prefix as __odr_asan_gen_, which is obviously wrong. To fix this, adjust the prefix detection to onl

[FFmpeg-devel] [PATCH v3 2/2] configure: correctly set sanitizer toolchain compilers

2024-09-12 Thread Marvin Scholz
Previously only the C compiler was set, which would lead to confusing situations where even though clang-asan was selected, it would still use g++ for C++ code, failing because configure does not support mixing compilers in this way (which is a separate issue not addressed by this commit). --- con

Re: [FFmpeg-devel] [PATCH v2] configure: fix symbol prefix detection

2024-09-12 Thread epirat07
On 12 Sep 2024, at 8:03, Martin Storsjö wrote: > On Wed, 11 Sep 2024, Marvin Scholz wrote: > >> The symbol prefix check would incorrectly detect a bogus prefix in >> circumstances where sanitizers >> instrument the build, like when configuring with the clang-asan toolchain >> where it would de

[FFmpeg-devel] [PATCH 1/7] avformat/mov_chan: Check for FF_SANE_NB_CHANNELS

2024-09-12 Thread Michael Niedermayer
We do not support more channels. For example avcodec_open2() limits channels this way too The example file contains multiple chunks with over 16 million channels Fixes: Timeout / DOS Fixes: 67143/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-4858720481771520 Found-by: continuous fuzzing

[FFmpeg-devel] [PATCH 2/7] avcodec/vc2enc: basic sanity check on slice_max_bytes

2024-09-12 Thread Michael Niedermayer
Fixes: left shift of 896021632 by 3 places cannot be represented in type 'int' Fixes: 70544/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC2_fuzzer-6685593652756480 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nie

[FFmpeg-devel] [PATCH 3/7] swscale/swscale: Use unsigned operation to avoid undefined behavior

2024-09-12 Thread Michael Niedermayer
I have not checked that the constant is correct, this just fixes the undefined behavior Fixes: signed integer overflow: -646656 * 3517 cannot be represented in type 'int Fixes: 70559/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-5209368631508992 Found-by: continuous fuzzing process https://

[FFmpeg-devel] [PATCH 4/7] avformat/mxfdec: Check timecode for overflow

2024-09-12 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036840103968 + 538976288 cannot be represented in type 'long' Fixes: 70604/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-4844090340999168 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-

[FFmpeg-devel] [PATCH 5/7] avformat/mxfdec: More offset_temp checks

2024-09-12 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036854775807 - -1927491430256034080 cannot be represented in type 'long' Fixes: 70607/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-5282235077951488 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 6/7] swscale/output: Fix undefined integer overflow in yuv2rgba64_2_c_template()

2024-09-12 Thread Michael Niedermayer
Fixes: signed integer overflow: -1082982400 + -1083218484 cannot be represented in type 'int' Fixes: 70657/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-6707819712675840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 7/7] avformat/flvdec: Free metaVideoColor

2024-09-12 Thread Michael Niedermayer
Fixes: memeleak Fixes: 70659/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-4539872627458048 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/flvdec.c | 1 + 1 file changed, 1 insertion(

Re: [FFmpeg-devel] [PATCH] lavc: Fix epirats suggestions

2024-09-12 Thread Marvin Scholz
On 12 Sep 2024, at 9:35, Petro Mozil wrote: The subject of the email will become the commit message, clearly lavc: Fix epirats suggestions is not a proper one. Also please do not send patches of patches, instead do the changes, squash/amend it with the previous one and re-send a new version (

Re: [FFmpeg-devel] [PATCH v5] avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4

2024-09-12 Thread Pierre-Anthony Lemieux
Looks like a nice improvement. It looks like the size of the codestreams obtained when running `-q: 20` are larger after the patch -- maybe related to the change in the step size calculation, which is now the same for both bitexact and non-bit-exact. Is that expected? I realize `-q` is arbitrary bu

Re: [FFmpeg-devel] [PATCH 7/7] avformat/flvdec: Free metaVideoColor

2024-09-12 Thread Steven Liu
Michael Niedermayer 于2024年9月13日周五 07:44写道: > > Fixes: memeleak > Fixes: > 70659/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-4539872627458048 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer >

[FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Fix encode fail since 9db68ed0

2024-09-12 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/vaapi_encode_av1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_av1.c b/libavcodec/vaapi_encode_av1.c index 6d1be9fc07..1b350cd936 100644 --- a/libavcodec/vaapi_encode_av1.c +++ b/libavcodec/vaa

[FFmpeg-devel] [PATCH] avcodec/vvc: Fix output and unref a frame which isn't decoding yet

2024-09-12 Thread Zhao Zhili
From: Zhao Zhili ff_vvc_output_frame is called before actually decoding. It's possible for ff_vvc_output_frame to select current frame to output. If current frame is nonref frame, it will be released by ff_vvc_unref_frame. Fix this by always marking the current frame with VVC_FRAME_FLAG_SHORT_RE

[FFmpeg-devel] [PATCH] avformat/dvdvideodec: implement seeking

2024-09-12 Thread Marth64
Player applications can now enjoy seeking while playing back a title. Accuracy is at the mercy of what libdvdnav exposes, which is currently dvdnav_time_search(). Signed-off-by: Marth64 --- libavformat/dvdvideodec.c | 77 --- 1 file changed, 72 insertions(+),

[FFmpeg-devel] [PATCH] avcodec/h264: ignore POC when flag is set

2024-09-12 Thread kevmo314
From: Kevin Wang When the flag AV_CODEC_FLAG_OUTPUT_CORRUPT or AV_CODEC_FLAG2_SHOW_ALL is set, ignore any out of order POC's as they may still be valid frames. Fixes https://trac.ffmpeg.org/ticket/11190. Signed-off-by: Kevin Wang --- libavcodec/h264_slice.c | 3 ++- 1 file changed, 2 insertio

[FFmpeg-devel] [PATCH v2] avcodec/vvc: Fix output and unref a frame which isn't decoding yet

2024-09-12 Thread Zhao Zhili
From: Zhao Zhili ff_vvc_output_frame is called before actually decoding. It's possible for ff_vvc_output_frame to select current frame to output. If current frame is nonref frame, it will be released by ff_vvc_unref_frame. Fix this by always marking the current frame with VVC_FRAME_FLAG_SHORT_RE