[FFmpeg-devel] [PATCH] ffmpeg: don't truncate getmaxrss value

Can lead to printing of nonsensical negative memory usage --- fftools/ffmpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 00ab1cce51..3aa2e12780 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -309,8 +309,8 @@ const AVI

[FFmpeg-devel] [PATCH] avformat/avio: avio_tell() only errors if the context is NULL

Found by code review related to coverity Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/avio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/avio.h b/libavformat/avio.h index ebf611187dc..3be91e4b8a7 100644 --- a/libavformat

[FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: Add HEVC 4:2:2 10-bit encoding profile

--- libavcodec/defs.h| 1 + libavcodec/videotoolboxenc.c | 16 ++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/libavcodec/defs.h b/libavcodec/defs.h index 7ddfdcad0b..d7bf5aa00f 100644 --- a/libavcodec/defs.h +++ b/libavcodec/defs.h @@ -160,6 +160,7 @@

Re: [FFmpeg-devel] [PATCH 2/2] avutil/executor: Fix stack overflow due to recursive call

On Wed, Jul 10, 2024 at 5:14 PM Anton Khirnov wrote: > Quoting Nuo Mi (2024-07-09 13:36:09) > > On Tue, Jul 9, 2024 at 6:35 AM Timo Rothenpieler > > wrote: > > > > > On 08.07.2024 17:32, Zhao Zhili wrote: > > > > > > > > > > > >> On Jul 8, 2024, at 22:07, Timo Rothenpieler > > > wrote: > > > >>

Re: [FFmpeg-devel] [PATCH 2/2] avutil/executor: Fix stack overflow due to recursive call

On Thu, Jul 11, 2024 at 8:21 PM Nuo Mi wrote: > > > On Wed, Jul 10, 2024 at 5:14 PM Anton Khirnov wrote: > >> Quoting Nuo Mi (2024-07-09 13:36:09) >> > On Tue, Jul 9, 2024 at 6:35 AM Timo Rothenpieler > > >> > wrote: >> > >> > > On 08.07.2024 17:32, Zhao Zhili wrote: >> > > > >> > > > >> > > >>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vvc: Use static const for function table

applied, thx On Mon, Jul 8, 2024 at 9:24 PM Nuo Mi wrote: > LGTM > thank you, Zhili. > > On Mon, Jul 8, 2024 at 3:40 PM Zhao Zhili wrote: > >> From: Zhao Zhili >> >> --- >> libavcodec/vvc/thread.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/vvc/threa

Re: [FFmpeg-devel] [PATCH] avutil/executor: Fix missing check before using mutex

On Mon, Jul 1, 2024 at 10:13 PM Nuo Mi wrote: > > > On Mon, Jul 1, 2024 at 10:00 PM Zhao Zhili wrote: > >> >> >> > On Jul 1, 2024, at 21:14, Nuo Mi wrote: >> > >> > On Sun, Jun 30, 2024 at 6:45 PM Zhao Zhili >> wrote: >> > >> >> From: Zhao Zhili >> >> >> >> --- >> >> The code can be simplifie

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: export cropping values from clap boxes

On 7/8/2024 10:55 PM, James Almer wrote: Addresses part of ticket #7437. Signed-off-by: James Almer --- libavformat/mov.c | 78 + tests/ref/fate/aic | 32 +- tests/ref/fate/prores-transparency | 4 +- tests/re

Re: [FFmpeg-devel] [PATCH] avformat/mov: ensure pasp box derived SAR is used if present

On 7/9/2024 2:21 PM, James Almer wrote: It's meant to override any codec specific (but container level) information, but its position is not guaranteed, so apply the values after the entire trak structure has been parsed. Also, replace the ugly roundabout int -> double -> int method to set SAR fr

Re: [FFmpeg-devel] [PATCH] avfilter/vf_crop: prevent integer overflows when calculating SAR

On 7/9/2024 5:32 PM, James Almer wrote: Signed-off-by: James Almer --- libavfilter/vf_crop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c index 6361209941..d4966323f5 100644 --- a/libavfilter/vf_crop.c +++ b/libavfilter/vf_c

[FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: Add P210 to hevc_pix_fmts

--- libavcodec/videotoolboxenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 8e2a66ee4a..e9c4482b47 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c @@ -2827,6 +2827,7 @@ static const enum AVPixel

Re: [FFmpeg-devel] [FFmpeg-cvslog] x86/intreadwrite: use intrinsics instead of inline asm for AV_COPY128

On Wed, 10 Jul 2024, James Almer wrote: ffmpeg | branch: master | James Almer | Wed Jul 10 13:00:20 2024 -0300| [bd1bcb07e0f29c135103a402d71b343a09ad1690] | committer: James Almer x86/intreadwrite: use intrinsics instead of inline asm for AV_COPY128 This has the benefit of removing any SSE -

Re: [FFmpeg-devel] [FFmpeg-cvslog] x86/intreadwrite: use intrinsics instead of inline asm for AV_COPY128

On 7/11/2024 10:08 AM, Martin Storsjö wrote: On Wed, 10 Jul 2024, James Almer wrote: ffmpeg | branch: master | James Almer | Wed Jul 10 13:00:20 2024 -0300| [bd1bcb07e0f29c135103a402d71b343a09ad1690] | committer: James Almer x86/intreadwrite: use intrinsics instead of inline asm for AV_COPY

Re: [FFmpeg-devel] [FFmpeg-cvslog] x86/intreadwrite: use intrinsics instead of inline asm for AV_COPY128

On Thu, 11 Jul 2024, James Almer wrote: On 7/11/2024 10:08 AM, Martin Storsjö wrote: On Wed, 10 Jul 2024, James Almer wrote: ffmpeg | branch: master | James Almer | Wed Jul 10 13:00:20 2024 -0300| [bd1bcb07e0f29c135103a402d71b343a09ad1690] | committer: James Almer x86/intreadwrite: use in

Re: [FFmpeg-devel] [FFmpeg-cvslog] x86/intreadwrite: use intrinsics instead of inline asm for AV_COPY128

On Thu, 11 Jul 2024, Martin Storsjö wrote: On Thu, 11 Jul 2024, James Almer wrote: On 7/11/2024 10:08 AM, Martin Storsjö wrote: On Wed, 10 Jul 2024, James Almer wrote: ffmpeg | branch: master | James Almer | Wed Jul 10 13:00:20 2024 -0300| [bd1bcb07e0f29c135103a402d71b343a09ad1690] | comm

[FFmpeg-devel] [PATCH] x86/intreadwrite: add missing casts to pointer arguments

Should make strict compilers happy. Also, make AV_COPY128 use integer operations while at it. Signed-off-by: James Almer --- libavutil/x86/intreadwrite.h | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavutil/x86/intreadwrite.h b/libavutil/x86/intreadwrite

Re: [FFmpeg-devel] [FFmpeg-cvslog] x86/intreadwrite: use intrinsics instead of inline asm for AV_COPY128

On 7/11/2024 10:54 AM, Martin Storsjö wrote: On Thu, 11 Jul 2024, Martin Storsjö wrote: On Thu, 11 Jul 2024, James Almer wrote: On 7/11/2024 10:08 AM, Martin Storsjö wrote: On Wed, 10 Jul 2024, James Almer wrote: ffmpeg | branch: master | James Almer | Wed Jul 10 13:00:20 2024 -0300| [bd1

[FFmpeg-devel] [PATCH] lavc/h264dsp: R-V V high-depth h264_idct8_add

Unlike the 8-bit version, we need two iterations to process this within 128-bit vectors. This adds some extra complexity for pointer arithmetic and counting down which is unnecessary in the 8-bit variant. Accordingly the gain relative to C are just slight better than half as good with 128-bit vect

Re: [FFmpeg-devel] [FFmpeg-cvslog] x86/intreadwrite: use intrinsics instead of inline asm for AV_COPY128

On Thu, 11 Jul 2024, James Almer wrote: On 7/11/2024 10:54 AM, Martin Storsjö wrote: On Thu, 11 Jul 2024, Martin Storsjö wrote: On Thu, 11 Jul 2024, James Almer wrote: On 7/11/2024 10:08 AM, Martin Storsjö wrote: On Wed, 10 Jul 2024, James Almer wrote: ffmpeg | branch: master | James Alme

Re: [FFmpeg-devel] [PATCH] x86/intreadwrite: add missing casts to pointer arguments

On Thu, 11 Jul 2024, James Almer wrote: Should make strict compilers happy. Also, make AV_COPY128 use integer operations while at it. Signed-off-by: James Almer --- libavutil/x86/intreadwrite.h | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavutil/x86/in

Re: [FFmpeg-devel] [FFmpeg-cvslog] x86/intreadwrite: use intrinsics instead of inline asm for AV_COPY128

On 7/11/2024 6:00 PM, Martin Storsjö wrote: On Thu, 11 Jul 2024, James Almer wrote: On 7/11/2024 10:54 AM, Martin Storsjö wrote: On Thu, 11 Jul 2024, Martin Storsjö wrote: On Thu, 11 Jul 2024, James Almer wrote: On 7/11/2024 10:08 AM, Martin Storsjö wrote: On Wed, 10 Jul 2024, James Almer

Re: [FFmpeg-devel] [PATCH 1/6] avfilter/vf_tiltandshift: Free dst on error

On Thu, Jul 11, 2024 at 12:50 AM Michael Niedermayer wrote: > Fixes: CID1559901 Resource leak > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_tiltandshift.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/

[FFmpeg-devel] [PATCH 01/22] avformat/asfdec_o: Check size of index object

We subtract 24 so it must be at least 24 Fixes: CID1604482 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/asfdec_o.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/asfdec_o.c b/libavformat/asfdec_o.c index dfe448e9f7e

[FFmpeg-devel] [PATCH 02/22] avformat/bintext: Check avio_size() return

Fixes: CID1604503 Overflowed constant Fixes: CID1604566 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/bintext.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/libavformat/bintext.c b/libav

[FFmpeg-devel] [PATCH 03/22] avformat/hlsenc: Check ret

Fixes: CID1609624 Unused value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/hlsenc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 274de00f9a9..6d6ede1b6ff 100644 --- a/libavf

[FFmpeg-devel] [PATCH 04/22] avformat/hnm: Check *chunk_size

Fixes: CID1604419 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/hnm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/hnm.c b/libavformat/hnm.c index 42efaaa3e8b..425dadc5e31 100644 --- a/libavformat/hn

[FFmpeg-devel] [PATCH 05/22] avformat/matroskadec: Use int64_t size

The length is 64bit that is passed into the functions. Alternatively the values can be checked before cast Fixes: CID1604572 Overflowed return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/matroskadec.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[FFmpeg-devel] [PATCH 06/22] avformat/mm: Check length

Fixes: CID1220824 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mm.c b/libavformat/mm.c index 23c025d8525..e377ed4fbb9 100644 --- a/libavformat/mm.c +++

[FFmpeg-devel] [PATCH 11/22] avformat/sapdec: Check ffurl_get_file_handle() for error

Fixes: CID1604506 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/sapdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/sapdec.c b/libavformat/sapdec.c index 357c0dd5147..d5b5d71c020 100644 --- a/libavformat/sapdec.c

[FFmpeg-devel] [PATCH 12/22] avformat/sauce: Check avio_size() for failure

Fixes: CID1604592 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/sauce.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/sauce.c b/libavformat/sauce.c index 150be4705b5..55d288d3aea 100644 --- a/libav

[FFmpeg-devel] [PATCH 07/22] avformat/mov: Use 64bit for str_size

We assign a 64bit variable to it before checking Fixes: CID1604544 Overflowed integer argument Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c i

[FFmpeg-devel] [PATCH 13/22] avformat/siff: Basic pkt_size check

Fixes: half of CID1258461 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/siff.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/siff.c b/libavformat/siff.c index 5aad03d870f..b33746d51d2 100644 --- a/li

[FFmpeg-devel] [PATCH 08/22] avformat/mp3dec; Check for avio_size() failure

Fixes: CID1608710 Improper use of negative value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/mp3dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index f421e03926f..6443b80596c 100644 -

[FFmpeg-devel] [PATCH 14/22] avformat/tty: Check avio_size()

Fixes: CID1220824 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/tty.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavformat/tty.c b/libavformat/tty.c index 95b72005278..c3956ccf34e 100644 --- a/lib

[FFmpeg-devel] [PATCH 15/22] avformat/ty: rec_size seems to only need 32bit

May help CID1604560 Overflowed integer argument Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/ty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/ty.c b/libavformat/ty.c index ac3b9071fca..f524b74badc 100644 --- a/libavforma

[FFmpeg-devel] [PATCH 09/22] avformat/mp3dec: Check header_filesize

Fixes: CID1608714 Division or modulo by float zero Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/mp3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 6443b80596c..0029ba63aa3 100644 -

[FFmpeg-devel] [PATCH 16/22] avformat/webpenc: Check filesize in trailer

not sure this is possible Fixes: CID1604446 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/webpenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/webpenc.c b/libavformat/webpenc.c index 1c5b93e0abf..ce0

[FFmpeg-devel] [PATCH 10/22] avformat/nsvdec: Check asize for PCM

Fixes: CID1604527 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/nsvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/nsvdec.c b/libavformat/nsvdec.c index 3b8f812aa5e..dd01765d7d2 100644 --- a/libavfor

[FFmpeg-devel] [PATCH 17/22] avformat/xmv: Check this_packet_size

Fixes: CID1604489 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/xmv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/xmv.c b/libavformat/xmv.c index e103b2368ea..ed59f7b85bd 100644 --- a/libavformat/xmv.c +++ b/libavfo

[FFmpeg-devel] [PATCH 18/22] avutil/avsscanf: Remove dead code

Fixes: CID1604498 Structurally dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/avsscanf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavutil/avsscanf.c b/libavutil/avsscanf.c index 7061e6d9651..94f7710043e 100644 --- a/libavutil/avsscanf.c +

[FFmpeg-devel] [PATCH 19/22] avutil/buffer: Check ff_mutex_init() for failure

Fixes: CID1604487 Unchecked return value Fixes: CID1604494 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/buffer.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavutil/buffer.c b/libavutil/buffer.c ind

[FFmpeg-devel] [PATCH 20/22] avutil/frame: Check log2_crop_align

Fixes: CID1604586 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/frame.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 0775e2abd9d..673a9afb3bf 100644 --- a/libavutil/frame.c

[FFmpeg-devel] [PATCH 21/22] avutil/slicethread: Check pthread_*_init() for failure

Fixes: CID1604383 Unchecked return value Fixes: CID1604439 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/slicethread.c | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/libavutil/sliceth

[FFmpeg-devel] [PATCH 22/22] avfilter/vf_xfade: Check ff_inlink_consume_frame() for failure

Fixes: CID1458043 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/vf_xfade.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_xfade.c b/libavfilter/vf_xfade.c index e67a917d14f..e971177

[FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags

Same as the framecrc muxer. This will allow callers to analize changes in these values between filters within a list. Signed-off-by: James Almer --- libavcodec/bsf/showinfo.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/

[FFmpeg-devel] [PATCH 2/2] avcodec/bsf/showinfo: print packet data checksum

Signed-off-by: James Almer --- libavcodec/bsf/showinfo.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/showinfo.c index 0899263545..57da3fc73c 100644 --- a/libavcodec/bsf/showinfo.c +++ b/libavcodec/bsf/showinfo.c @@ -23,6 +23,

[FFmpeg-devel] [PATCH] avcodec/hevc: compatible with mixed use of annexb and hvcc on bitstream like h264dec

Hi: I found it's different actions with h264 and hevc when decoded. I try to make it same as blow. But I have no idea about the code: *libavcode/h264dec.c:609 * *AV_RB32(buf+5) > (unsigned)buf_size* I tried to find the answer in specs, but I failed. So I am not sure that it is valid in he

Re: [FFmpeg-devel] [PATCH v4] avformat/dvdvideodec: Fix incorrect padding cell trim logic

Ping to apply on this set of 3, so I can send seeking and additional cleanup set (as a collection). Thank you! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or ema

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

I checked that the patch results in FFMPEG decoding without error the additional conformance codestreams at [1]. [1] https://ffmpeg.org/pipermail/ffmpeg-devel/2024-June/329727.html @Osamu, did you check if the decoded images fall within the tolerances specified in 15444-4? There is an errant spa

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

> +    if (s->in_tile_headers == 1 && s->isHT && (!s- > >Ccap15_b11)) > +    av_log(s->avctx, AV_LOG_WARNING, "COD marker is > found in HOMOGENEOUS HT set\n"); How bad is this and the other markers being present in this case? Should we perhaps error out? /Tomas ___