[FFmpeg-devel] [PATCH] avformat/hlsenc: refine error message when retry with new http session

2024-07-07 Thread Steven Liu
Fix CID: 1609624 The hlsenc should give error message when hlsenc_io_open error, release memory of filename and options, should return warning message when hlsenc_io_close error. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libav

[FFmpeg-devel] 0001-Fix-HLG-10bit-color-transfer

2024-07-07 Thread 激情澎湃 via ffmpeg-devel
12685...@qq.com   0001-Fix-HLG-10bit-color-transfer.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixed incorrect behaviour of default setting, , added autoselect and forced

2024-07-07 Thread Steven Liu
CoderVenkat 于2024年7月5日周五 21:27写道: > > In absence of default in var_stream_map, it was setting default=yes on > every stream, > but according to RFC8216 4.3.4.1 only one stream in a default group may > have that. > Additionally added support for autoselect=yes/no, whose presence > combined with def

[FFmpeg-devel] [PATCH 4/5] avcodec/videotoolboxenc: Fix concurrent access to CVPixelBufferRef

2024-07-07 Thread Zhao Zhili
From: Zhao Zhili For a frame comes from AV_HWDEVICE_TYPE_VIDEOTOOLBOX, it's CVPixelBufferRef is maintained by a pool. CVPixelBufferRef returned to the pool when frame buffer reference reached to zero. However, VTCompressionSessionEncodeFrame also hold a reference to the CVPixelBufferRef. So a new

[FFmpeg-devel] [PATCH 5/5] avcodec/videotoolboxenc: Put ExtraSEI inside BufNode directly

2024-07-07 Thread Zhao Zhili
From: Zhao Zhili Reduce error path and simplify the code. --- libavcodec/videotoolboxenc.c | 60 +--- 1 file changed, 21 insertions(+), 39 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 9bb9b0b457..bd0b55275f 100644 --

[FFmpeg-devel] [PATCH 3/5] avcodec/videotoolboxenc: Use BufNode as sourceFrameRefcon

2024-07-07 Thread Zhao Zhili
From: Zhao Zhili ExtraSEI is used as the sourceFrameRefcon of VTCompressionSessionEncodeFrame. It cannot hold other information which is necessary to fix another issue in the following patch. This patch also fixed leak of ExtraSEI on the error path of vtenc_output_callback. --- libavcodec/video

[FFmpeg-devel] [PATCH 2/5] avcodec/videotoolboxenc: Remove unused variable

2024-07-07 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/videotoolboxenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 91ee507050..03e3c9ad42 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c @@ -229,7 +229,6 @@ typedef s

[FFmpeg-devel] [PATCH 1/5] avcodec/videotoolboxenc: Don't ignore ENOMEM

2024-07-07 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/videotoolboxenc.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 42065cbcb3..91ee507050 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcode

[FFmpeg-devel] [PATCH v2 3/5] avcodec/videotoolboxenc: Use BufNode as sourceFrameRefcon

2024-07-07 Thread Zhao Zhili
From: Zhao Zhili ExtraSEI is used as the sourceFrameRefcon of VTCompressionSessionEncodeFrame. It cannot hold other information which is necessary to fix another issue in the following patch. This patch also fixed leak of ExtraSEI on the error path of vtenc_output_callback. --- v2: Fix inverted

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: fix vtctx reset condition

2024-07-07 Thread Zhao Zhili
> On Jun 21, 2024, at 14:08, Hao Guan wrote: > > In vtenc_populate_extradata, the cleanup function vtenc_reset should not > be used when no error occurs, otherwise some color information is lost > (#11036). > > This patch checks the status code and conducts the correct cleanup. LGTM, thanks!

Re: [FFmpeg-devel] 0001-Fix-HLG-10bit-color-transfer

2024-07-07 Thread Zhao Zhili
> On Jul 7, 2024, at 18:08, 激情澎湃 via ffmpeg-devel > wrote: Thanks for your contribution. There is a similar patch on the mailing list already https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240621060820.3215-1-hgua...@gmail.com/ > > 激情澎湃 > 12685...@qq.com > > > >  <0001-Fix-HLG-10bi

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself to the general developers list

2024-07-07 Thread Wang, Fei W
> -Original Message- > From: Wang, Fei W > Sent: Sunday, June 30, 2024 2:18 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Wang, Fei W > Subject: [FFmpeg-devel][PATCH] MAINTAINERS: add myself to the general > developers list > > From: Fei Wang > > Signed-off-by: Fei Wang > --- > It has been 4

[FFmpeg-devel] [PATCH 2/2] lavc/h264dsp: remove MMI 8-bit 4:2:2 chroma DC dequant

2024-07-07 Thread Rémi Denis-Courmont
The function is exactly identical to the C reference, only with the constant propagated and the loop unrolled manually. --- libavcodec/mips/h264dsp_init_mips.c | 4 libavcodec/mips/h264dsp_mips.h | 1 - libavcodec/mips/h264dsp_mmi.c | 33 - 3 files cha

[FFmpeg-devel] [PATCH 1/2] lavc/h264dsp: remove MMI 8-bit chroma DC dequant

2024-07-07 Thread Rémi Denis-Courmont
The function is exactly identical to the C reference, only with the constant propagated manually. It does not optimise anything. --- libavcodec/mips/h264dsp_init_mips.c | 5 + libavcodec/mips/h264dsp_mips.h | 1 - libavcodec/mips/h264dsp_mmi.c | 14 -- 3 files changed,

Re: [FFmpeg-devel] [PATCH 1/2] lavc/h264dsp: remove MMI 8-bit chroma DC dequant

2024-07-07 Thread Rémi Denis-Courmont
Le sunnuntaina 7. heinäkuuta 2024, 14.44.47 EEST Rémi Denis-Courmont a écrit : > The function is exactly identical to the C reference, only with the > constant propagated manually. It does not optimise anything. There are presently no (other) implementations for `H264DSPContext.h264_chroma_dc_deq

Re: [FFmpeg-devel] [PATCH] avformat/avisynth: remove atexit() handler

2024-07-07 Thread Andreas Rheinhardt
Stephen Hutchinson: > The atexit() handler in the avisynth demuxer was added because > there was a conflict in AvxSynth that arose due to their use > of C++ global objects, particularly in relation to having > added a logging function relying on log4cpp. > > This conflict was responsible for causi

Re: [FFmpeg-devel] [PATCH 01/11] avformat/mov: add support for lhvC box parsing

2024-07-07 Thread James Almer
On 7/3/2024 6:26 PM, James Almer wrote: Signed-off-by: James Almer --- libavformat/mov.c | 48 +++ 1 file changed, 48 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index a3951a6942..30e8086855 100644 --- a/libavformat/mov.c +++ b

Re: [FFmpeg-devel] [PATCH 01/11] avformat/mov: add support for lhvC box parsing

2024-07-07 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavformat/mov.c | 48 +++ > 1 file changed, 48 insertions(+) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index a3951a6942..30e8086855 100644 > --- a/libavformat/mov.c > +++ b/libavformat/

Re: [FFmpeg-devel] [PATCH 04/11] avformat/hevc: don't write NALUs with nuh_layer_id > 0 in hvcC boxes

2024-07-07 Thread Andreas Rheinhardt
James Almer: > hvcC should only contain nuh_layer_id == 0 NALUs. Support for a box meant to > contain higher layer NALUs will be added in a following patch. > To achieve this, all sources are parsed and filtered, including hvcC source > that until now were propagated untouched. This is reflected in

Re: [FFmpeg-devel] [PATCH 04/11] avformat/hevc: don't write NALUs with nuh_layer_id > 0 in hvcC boxes

2024-07-07 Thread James Almer
On 7/7/2024 12:46 PM, Andreas Rheinhardt wrote: James Almer: hvcC should only contain nuh_layer_id == 0 NALUs. Support for a box meant to contain higher layer NALUs will be added in a following patch. To achieve this, all sources are parsed and filtered, including hvcC source that until now were

Re: [FFmpeg-devel] [PATCH 01/11] avformat/mov: add support for lhvC box parsing

2024-07-07 Thread James Almer
On 7/7/2024 12:43 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavformat/mov.c | 48 +++ 1 file changed, 48 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index a3951a6942..30e8086855 100644 --- a/l

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-07-07 Thread Nicolas George
Stefano Sabatini (12024-07-06): > Can someone elaborate about why .activate is favoured in this case > (sorry I missed the activate discussion altogether and I cannot graps > it from the docs)? I do not know why Paul believes that source filters need to use activate. It should not be necessary, bu

Re: [FFmpeg-devel] [PATCH 2/2] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-07 Thread Sean McGovern
Hi, On Sat, Jul 6, 2024, 16:18 Rémi Denis-Courmont wrote: > Le lauantaina 6. heinäkuuta 2024, 23.00.47 EEST Sean McGovern a écrit : > > Does wasted32 (and I guess wasted33 by proxy) not have to worry about > loops > > tails? I noticed the other vectorized versions don't do anything special > in

Re: [FFmpeg-devel] [PATCH] avformat/avisynth: remove atexit() handler

2024-07-07 Thread Stephen Hutchinson
On 7/7/24 9:50 AM, Andreas Rheinhardt wrote: avisynth_context_destroy() is currently always called while holding the lock (i.e. avisynth_mutex). Is this even necessary? It is clear that avisynth_load_library() (and the check for whether it should be called) need the lock, but does anything else

[FFmpeg-devel] [PATCH] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-07 Thread Sean McGovern
RaptorCS POWER9 (8c4t) @ 2.2GHz: flac_wasted_32_c: 50.1 flac_wasted_32_vsx: 14.1 --- libavcodec/flacdsp.c | 2 ++ libavcodec/flacdsp.h | 1 + libavcodec/ppc/Makefile | 2 ++ libavcodec/ppc/flacdsp_init.c | 38 + libavcodec/ppc/flacdsp_vsx.c | 53

[FFmpeg-devel] [PATCH 1/6] avcodec/tiff: Check value on positive signed targets

2024-07-07 Thread Michael Niedermayer
Fixes: CID1604593 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index fd4116aec4d..37b56e9757e 100644 -

[FFmpeg-devel] [PATCH 2/6] avcodec/vaapi_h264: Do not store our error code in VASliceParameterBufferH264

2024-07-07 Thread Michael Niedermayer
I am not sure this is possible (thus this requires review) Fixes: CID1604570 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vaapi_h264.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_h264.c b/li

[FFmpeg-devel] [PATCH 3/6] avcodec/vvc/refs: Use unsigned mask

2024-07-07 Thread Michael Niedermayer
Not a bugfix, but might fix CID1604361 Overflowed constant Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vvc/refs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vvc/refs.c b/libavcodec/vvc/refs.c index 26a5b0b34cc..c1fc6132c

[FFmpeg-devel] [PATCH 4/6] avdevice/dshow_capture: Fix error handling in ff_dshow_##prefix##_Create()

2024-07-07 Thread Michael Niedermayer
Untested, needs review Fixes: CID1591856 Resource leak Fixes: CID1591887 Resource leak Fixes: CID1591874 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavdevice/dshow_capture.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[FFmpeg-devel] [PATCH 5/6] avfilter: Free out on error

2024-07-07 Thread Michael Niedermayer
CID1197065 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/af_aderivative.c | 1 + libavfilter/vf_deshake.c | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_aderivative.c b/libavfilter/af_aderivative.

[FFmpeg-devel] [PATCH 6/6] avfilter/af_surround: Check av_channel_layout_channel_from_index() stays within the fixed array used

2024-07-07 Thread Michael Niedermayer
Fixes: CID1516994 Out-of-bounds access Fixes: CID1516996 Out-of-bounds access Fixes: CID1516999 Out-of-bounds access Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/af_surround.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/af_surround.c

[FFmpeg-devel] [PATCH] lavc/h264dsp: R-V V 8-bit chroma_dc_dequant_idct

2024-07-07 Thread Rémi Denis-Courmont
Performance gains is around 0.5% on K230 cycle counter, and not measurable with the architecture timer, so probably no worth merging. --- libavcodec/riscv/h264dsp_init.c | 4 +++ libavcodec/riscv/h264idct_rvv.S | 57 + 2 files changed, 61 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH v2 3/8] swscale/options: relax src/dst_h/v_chr_pos value range

2024-07-07 Thread Michael Niedermayer
On Thu, Jul 04, 2024 at 04:30:59PM +0200, Niklas Haas wrote: > From: Niklas Haas > > When dealing with 4x subsampling ratios (log2 == 2), such as can arise > with 4:1:1 or 4:1:0, a value range of 512 is not enough to cover the > range of possible scenarios. > > For example, bottom-sited chroma i

Re: [FFmpeg-devel] [PATCH 6/6] avfilter/af_surround: Check av_channel_layout_channel_from_index() stays within the fixed array used

2024-07-07 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: CID1516994 Out-of-bounds access > Fixes: CID1516996 Out-of-bounds access > Fixes: CID1516999 Out-of-bounds access > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavfilter/af_surround.c | 3 +++ > 1 file changed, 3 insertions(+)

Re: [FFmpeg-devel] [PATCH 6/6] avfilter/af_surround: Check av_channel_layout_channel_from_index() stays within the fixed array used

2024-07-07 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Michael Niedermayer: >> Fixes: CID1516994 Out-of-bounds access >> Fixes: CID1516996 Out-of-bounds access >> Fixes: CID1516999 Out-of-bounds access >> >> Sponsored-by: Sovereign Tech Fund >> Signed-off-by: Michael Niedermayer >> --- >> libavfilter/af_surround.c | 3 +++ >> 1

Re: [FFmpeg-devel] [PATCH 04/17] avcodec/dxva2: initialize hr in ff_dxva2_common_end_frame()

2024-07-07 Thread Michael Niedermayer
On Sun, Jun 02, 2024 at 10:27:55PM +0200, Michael Niedermayer wrote: > On Sun, Jun 02, 2024 at 09:10:33PM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > Fixes: CID1591924 Uninitialized scalar variable > > > Fixes: CID1591938 Uninitialized scalar variable > > > > > > Sponsored-by:

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/af_aresample: Cleanup on av_channel_layout_copy() failure

2024-07-07 Thread Michael Niedermayer
On Tue, Jun 11, 2024 at 03:44:19PM +0200, Michael Niedermayer wrote: > Fixes: CID1503078 Resource leak > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavfilter/af_aresample.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) will apply patchset [

Re: [FFmpeg-devel] [PATCH] tools/coverity: Phase 1 study of anti-halicogenic for coverity av_rescale()

2024-07-07 Thread Michael Niedermayer
On Fri, Jul 05, 2024 at 02:50:41PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tools/coverity.c | 18 ++ > 1 file changed, 18 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When the t

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself to the general developers list

2024-07-07 Thread Michael Niedermayer
On Sun, Jun 30, 2024 at 02:17:42PM +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- > It has been 4.5 years since my 1st patch to FFmpeg. During the past > years, I have fully understand the rules of a committer. Because > sometimes, patch send

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/af_afftdn: Assert format

2024-07-07 Thread Michael Niedermayer
On Mon, Jun 10, 2024 at 09:09:54PM +0200, Michael Niedermayer wrote: > Maybe helps: CID1515514 Uninitialized scalar variable > Maybe helps: CID1515517 Uninitialized scalar variable > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavfilter/af_afftdn.c | 5

Re: [FFmpeg-devel] [PATCH 1/6] avutil/hwcontext_d3d11va: correct sizeof AVD3D11FrameDescriptor

2024-07-07 Thread Michael Niedermayer
Hi Steve you are listed as maintainer for d3d11va, there are some trivial patches in this patchset that i cannot easily test can you either apply/approve/reject/test/review them thx On Sun, Jun 09, 2024 at 05:47:41PM +0200, Michael Niedermayer wrote: > Fixes: CID1591909 Wrong sizeof argument >

Re: [FFmpeg-devel] [PATCH 5/6] swscale/swscale: Use ptrdiff_t for linesize computations

2024-07-07 Thread Michael Niedermayer
Hi will apply this and the next patch On Sun, Jun 09, 2024 at 05:47:45PM +0200, Michael Niedermayer wrote: > This is unlikely to make a difference > > Fixes: CID1591896 Unintentional integer overflow > Fixes: CID1591901 Unintentional integer overflow > > Sponsored-by: Sovereign Tech Fund > Sig

Re: [FFmpeg-devel] [PATCH 1/9] avformat/rtpenc_vc2hq: Check sizes

2024-07-07 Thread Michael Niedermayer
On Sun, Jun 09, 2024 at 01:10:38AM +0200, Michael Niedermayer wrote: > Fixes: CID1452585 Untrusted loop bound > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/rtpenc_vc2hq.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) wi

Re: [FFmpeg-devel] [PATCH 6/6] avfilter/af_surround: Check av_channel_layout_channel_from_index() stays within the fixed array used

2024-07-07 Thread Michael Niedermayer
On Sun, Jul 07, 2024 at 09:12:06PM +0200, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > Michael Niedermayer: > >> Fixes: CID1516994 Out-of-bounds access > >> Fixes: CID1516996 Out-of-bounds access > >> Fixes: CID1516999 Out-of-bounds access > >> > >> Sponsored-by: Sovereign Tech Fund > >> Sig

[FFmpeg-devel] [PATCH] avcodec/cbs_h265: fix range of sps_max_sub_layers_minus1

2024-07-07 Thread James Almer
The VPS referenced by the SPS must always be present as the max value for sps_max_sub_layers_minus1 is vps_max_sub_layers_minus1. This replaces a buggy custom range check for the aforementioned field. Also, add the missing conformance check for sps_temporal_id_nesting_flag while at it. Signed-off-

Re: [FFmpeg-devel] [PATCH 6/6] avfilter/af_surround: Check av_channel_layout_channel_from_index() stays within the fixed array used

2024-07-07 Thread James Almer
On 7/7/2024 6:59 PM, Michael Niedermayer wrote: On Sun, Jul 07, 2024 at 09:12:06PM +0200, Andreas Rheinhardt wrote: Andreas Rheinhardt: Michael Niedermayer: Fixes: CID1516994 Out-of-bounds access Fixes: CID1516996 Out-of-bounds access Fixes: CID1516999 Out-of-bounds access Sponsored-by: Sover

[FFmpeg-devel] [PATCHv2] swscale: prevent undefined behaviour in the PUTRGBA macro

2024-07-07 Thread Sean McGovern
--- libswscale/yuv2rgb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index 977eb3a7dd..ac0b811f61 100644 --- a/libswscale/yuv2rgb.c +++ b/libswscale/yuv2rgb.c @@ -100,9 +100,9 @@ const int *sws_getCoefficients(int colorspace)

[FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix version check

2024-07-07 Thread Zhao Zhili
From: Zhao Zhili --- libavutil/hwcontext_videotoolbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c index 953155ce32..dd89edfa08 100644 --- a/libavutil/hwcontext_videotoolbox.c +++ b/libavutil/hwcont