Re: [FFmpeg-devel] [PATCH 2/2] swscale/x86/input: add AVX2 optimized uyvytoyuv422

2024-06-06 Thread Christophe Gisquet
Le jeu. 6 juin 2024 à 08:11, Rémi Denis-Courmont a écrit : > >James Almer: > >> uyvytoyuv422_c: 23991.8 > >> uyvytoyuv422_sse2: 2817.8 > >> uyvytoyuv422_avx: 2819.3 > > > >Why don't you nuke the avx version in a follow-up patch? > > Same problem with the RGBA stuff as well. Are the AVX functions e

[FFmpeg-devel] [RFC] flac_wasted32 vector implementation for VSX on ppc64le

2024-06-06 Thread Sean McGovern
Hi, Attached inline is a _non-working_ implementation of flac_wasted32 for VSX developed on a POWER9 in little-endian mode but probably just as usable on POWER{8,10}. I'm not sure why probably one of the simplest DSP functions in lavc does not work for me, I imagine this is probably something end

Re: [FFmpeg-devel] [PATCH] lavu/opt: Mention that AVOptions is not reentrant

2024-06-06 Thread Andrew Sayers
On Thu, Jun 06, 2024 at 01:17:48AM +0200, Michael Niedermayer wrote: [...] > AVOption simply provides light weight access to the struct fields. > Calling AVOption non re-entrant in modifying a field you arent even allowed > to modify from 2 threads is confusing I think you're saying there's alread

Re: [FFmpeg-devel] [PATCH] avfilter/trim: flag trim filter as metadata only

2024-06-06 Thread Gyan Doshi
On 2024-06-05 12:47 am, Stefano Sabatini wrote: On date Tuesday 2024-06-04 23:41:05 +0530, Gyan Doshi wrote: Similar to select filter for video - it can only pass through or drop frames --- libavfilter/trim.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/trim.c b/libavfil

Re: [FFmpeg-devel] [RFC] flac_wasted32 vector implementation for VSX on ppc64le

2024-06-06 Thread Rémi Denis-Courmont
Le 6 juin 2024 10:43:05 GMT+03:00, Sean McGovern a écrit : >Hi, > >Attached inline is a _non-working_ implementation of flac_wasted32 for >VSX developed on a POWER9 in little-endian mode but probably just as >usable on POWER{8,10}. > >I'm not sure why probably one of the simplest DSP functions i

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-06 Thread Vittorio Giovara
On Thu, Jun 6, 2024 at 2:07 AM Michael Niedermayer wrote: > On Wed, Jun 05, 2024 at 12:31:28PM +0300, Rémi Denis-Courmont wrote: > > > > > > Le 5 juin 2024 12:18:57 GMT+03:00, "Rémi Denis-Courmont" < > r...@remlab.net> a écrit : > > >But by reacting *only* to Vittorio trying to defend himself and

[FFmpeg-devel] [PATCH v3] lavc/vvc: Prevent overflow in chroma QP derivation

2024-06-06 Thread Frank Plowman
On the top of p. 112 in VVC (09/2023): It is a requirement of bitstream conformance that the values of qpInVal[ i ][ j ] and qpOutVal[ i ][ j ] shall be in the range of −QpBdOffset to 63, inclusive for i in the range of 0 to numQpTables − 1, inclusive, and j in the range of 0 to sps_num_points_in_

Re: [FFmpeg-devel] [PATCH v2 2/2] lavc/vvc: Prevent overflow in chroma QP derivation

2024-06-06 Thread Frank Plowman
Hi, Thanks for your review. On 05/06/2024 14:50, Nuo Mi wrote: > Hi Frank, > Thank you for the patch > > On Wed, Jun 5, 2024 at 5:24 PM Frank Plowman wrote: > >> On the top of p. 112 in VVC (09/2023): >> >> It is a requirement of bitstream conformance that the values of >> qpInVal[ i ][ j ] an

Re: [FFmpeg-devel] [PATCH v8] avcodec: add farbfeld encoder, decoder and demuxer

2024-06-06 Thread Rémi Denis-Courmont
Same cast problem as previously. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display

2024-06-06 Thread Shiqi Zhu
Signed-off-by: Shiqi Zhu --- configure| 1 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vsink_sdlvsink.c | 142 +++ 4 files changed, 145 insertions(+) create mode 100644 libavfilter/vsink_sdlvsink.

Re: [FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display

2024-06-06 Thread Zhao Zhili
> On Jun 6, 2024, at 19:51, Shiqi Zhu wrote: I’m afraid this has the same issue as libavdevice/sdl[1]. [1] https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230918063728.198377-1-haihao.xi...@intel.com/ > > Signed-off-by: Shiqi Zhu > --- > configure| 1 + > libavfilt

Re: [FFmpeg-devel] [PATCH v13 15/15] avcodec/hw_base_encode: avoid getting FFHWBaseEncodeContext from avctx

2024-06-06 Thread Lynne via ffmpeg-devel
On 06/06/2024 08:46, Wu, Tong1 wrote: From: ffmpeg-devel On Behalf Of Lynne via ffmpeg-devel Sent: Thursday, June 6, 2024 2:11 PM To: ffmpeg-devel@ffmpeg.org Cc: Lynne Subject: Re: [FFmpeg-devel] [PATCH v13 15/15] avcodec/hw_base_encode: avoid getting FFHWBaseEncodeContext from avctx On 03/06/

Re: [FFmpeg-devel] [PATCH 4/7] avformat/vvc: Fix crash on allocation failure, avoid allocations

2024-06-06 Thread Nuo Mi
On Wed, Jun 5, 2024 at 7:53 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Andreas Rheinhardt: > > This is the VVC version of 8b5d15530127fea54e934043a64653859de07353. > > > > (Hint: This ensures that the order of NALU arrays is OPI-VPS-SPS-PPS- > > Prefix-SEI-Suffix-SEI, regardl

Re: [FFmpeg-devel] [PATCH v13 15/15] avcodec/hw_base_encode: avoid getting FFHWBaseEncodeContext from avctx

2024-06-06 Thread Wu, Tong1
>-Original Message- >From: ffmpeg-devel On Behalf Of Lynne >via ffmpeg-devel >Sent: Thursday, June 6, 2024 8:31 PM >To: FFmpeg development discussions and patches >Cc: Lynne >Subject: Re: [FFmpeg-devel] [PATCH v13 15/15] avcodec/hw_base_encode: >avoid getting FFHWBaseEncodeContext fro

Re: [FFmpeg-devel] [PATCH 4/7] avformat/vvc: Fix crash on allocation failure, avoid allocations

2024-06-06 Thread Nuo Mi
On Wed, Jun 5, 2024 at 7:41 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > This is the VVC version of 8b5d15530127fea54e934043a64653859de07353. > > (Hint: This ensures that the order of NALU arrays is OPI-VPS-SPS-PPS- > Prefix-SEI-Suffix-SEI, regardless of the order in the origin

[FFmpeg-devel] [PATCH] swscale/x86/rgb2rgb: add SSE2 shuffle_bytes functions

2024-06-06 Thread James Almer
And remove shuffle_bytes_2103_mmxext. shuffle_bytes_0321_c: 28.1 shuffle_bytes_0321_sse2: 13.6 shuffle_bytes_0321_ssse3: 9.6 shuffle_bytes_0321_avx2: 7.1 shuffle_bytes_1230_c: 52.6 shuffle_bytes_1230_sse2: 12.1 shuffle_bytes_1230_ssse3: 8.6 shuffle_bytes_1230_avx2: 6.6 shuffle_bytes_2103_c: 29.1 s

Re: [FFmpeg-devel] [PATCH] lavu/opt: Mention that AVOptions is not reentrant

2024-06-06 Thread Michael Niedermayer
On Thu, Jun 06, 2024 at 09:29:24AM +0100, Andrew Sayers wrote: > On Thu, Jun 06, 2024 at 01:17:48AM +0200, Michael Niedermayer wrote: > [...] > > AVOption simply provides light weight access to the struct fields. > > Calling AVOption non re-entrant in modifying a field you arent even allowed > > to

Re: [FFmpeg-devel] [PATCH] swscale/x86/rgb2rgb: add SSE2 shuffle_bytes functions

2024-06-06 Thread Andreas Rheinhardt
James Almer: > And remove shuffle_bytes_2103_mmxext. > > shuffle_bytes_0321_c: 28.1 > shuffle_bytes_0321_sse2: 13.6 > shuffle_bytes_0321_ssse3: 9.6 > shuffle_bytes_0321_avx2: 7.1 > shuffle_bytes_1230_c: 52.6 > shuffle_bytes_1230_sse2: 12.1 > shuffle_bytes_1230_ssse3: 8.6 > shuffle_bytes_1230_avx2:

Re: [FFmpeg-devel] [PATCH] lavu/opt: Mention that AVOptions is not reentrant

2024-06-06 Thread Andrew Sayers
On Thu, Jun 06, 2024 at 04:24:11PM +0200, Michael Niedermayer wrote: > On Thu, Jun 06, 2024 at 09:29:24AM +0100, Andrew Sayers wrote: > > On Thu, Jun 06, 2024 at 01:17:48AM +0200, Michael Niedermayer wrote: > > [...] > > > AVOption simply provides light weight access to the struct fields. > > > Cal

Re: [FFmpeg-devel] [PATCH] lavu/opt: Mention that AVOptions is not reentrant

2024-06-06 Thread Andreas Rheinhardt
Andrew Sayers: > On Thu, Jun 06, 2024 at 04:24:11PM +0200, Michael Niedermayer wrote: >> On Thu, Jun 06, 2024 at 09:29:24AM +0100, Andrew Sayers wrote: >>> On Thu, Jun 06, 2024 at 01:17:48AM +0200, Michael Niedermayer wrote: >>> [...] AVOption simply provides light weight access to the struct

Re: [FFmpeg-devel] [PATCH] lavu/opt: Mention that AVOptions is not reentrant

2024-06-06 Thread Andrew Sayers
On Thu, Jun 06, 2024 at 05:21:00PM +0200, Andreas Rheinhardt wrote: > Andrew Sayers: > > On Thu, Jun 06, 2024 at 04:24:11PM +0200, Michael Niedermayer wrote: > >> On Thu, Jun 06, 2024 at 09:29:24AM +0100, Andrew Sayers wrote: > >>> On Thu, Jun 06, 2024 at 01:17:48AM +0200, Michael Niedermayer wrote

Re: [FFmpeg-devel] [PATCH] swscale/x86/rgb2rgb: add SSE2 shuffle_bytes functions

2024-06-06 Thread James Almer
On 6/6/2024 11:48 AM, Andreas Rheinhardt wrote: James Almer: And remove shuffle_bytes_2103_mmxext. shuffle_bytes_0321_c: 28.1 shuffle_bytes_0321_sse2: 13.6 shuffle_bytes_0321_ssse3: 9.6 shuffle_bytes_0321_avx2: 7.1 shuffle_bytes_1230_c: 52.6 shuffle_bytes_1230_sse2: 12.1 shuffle_bytes_1230_ssse

Re: [FFmpeg-devel] [PATCH] aacdec_usac: correctly set and use the layout map

2024-06-06 Thread Paul B Mahol
On Wed, Jun 5, 2024 at 7:41 PM Lynne via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > --- > libavcodec/aac/aacdec_usac.c | 105 +-- > 1 file changed, 63 insertions(+), 42 deletions(-) > > diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c

[FFmpeg-devel] [PATCH v2] lavu/opt: Discuss AV_OPT_FLAG_RUNTIME_PARAM more explicitly

2024-06-06 Thread Andrew Sayers
After a struct is initialized, only options with the AV_OPT_FLAG_RUNTIME_PARAM flag can be modified. Make that clearer, for the sake of readers who would otherwise assume all options can be modified at any time. --- libavutil/opt.h | 26 +- 1 file changed, 25 insertions(+)

[FFmpeg-devel] [PATCH] lavc/flacdsp: R-V Zvbb wasted33

2024-06-06 Thread Rémi Denis-Courmont
--- libavcodec/riscv/Makefile | 1 + libavcodec/riscv/flacdsp_init.c | 8 +++- libavcodec/riscv/flacdsp_rvvb.S | 35 + 3 files changed, 43 insertions(+), 1 deletion(-) create mode 100644 libavcodec/riscv/flacdsp_rvvb.S diff --git a/libavcodec/riscv/Mak

Re: [FFmpeg-devel] [RFC] flac_wasted32 vector implementation for VSX on ppc64le

2024-06-06 Thread Sean McGovern
On Thu, Jun 6, 2024, 05:53 Rémi Denis-Courmont wrote: > > > Le 6 juin 2024 10:43:05 GMT+03:00, Sean McGovern a > écrit : > >Hi, > > > >Attached inline is a _non-working_ implementation of flac_wasted32 for > >VSX developed on a POWER9 in little-endian mode but probably just as > >usable on POWER

[FFmpeg-devel] [PATCH v2 1/4] avutil/aarch64: Skip define AV_READ_TIME for apple

2024-06-06 Thread Zhao Zhili
From: Zhao Zhili It will fallback to mach_absolute_time inside libavutil/timer.h --- libavutil/aarch64/timer.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/libavutil/aarch64/timer.h b/libavutil/aarch64/timer.h index 8b28fd354c..fadc9568f8 100644 --- a/libavutil/aarc

[FFmpeg-devel] [PATCH v2 2/4] avutil/timer: Add clock_gettime as a fallback of AV_READ_TIME

2024-06-06 Thread Zhao Zhili
From: Zhao Zhili --- libavutil/timer.h | 5 + 1 file changed, 5 insertions(+) diff --git a/libavutil/timer.h b/libavutil/timer.h index 2cd299eca3..74c4d84e69 100644 --- a/libavutil/timer.h +++ b/libavutil/timer.h @@ -46,6 +46,8 @@ #include "macos_kperf.h" #elif HAVE_MACH_ABSOLUTE_TIME #i

[FFmpeg-devel] [PATCH v2 3/4] tests/checkasm: Fix build error when enable linux perf on Android

2024-06-06 Thread Zhao Zhili
From: Zhao Zhili B0 is defined by system header. --- tests/checkasm/llviddsp.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/checkasm/llviddsp.c b/tests/checkasm/llviddsp.c index b75c0ea099..9f8de65df4 100644 --- a/tests/checkasm/llviddsp.c +++ b/te

[FFmpeg-devel] [PATCH v2 4/4] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-06 Thread Zhao Zhili
From: Zhao Zhili Test on Apple M1: rgb24_to_uv_8_c: 0.0 rgb24_to_uv_8_neon: 0.2 rgb24_to_uv_128_c: 1.0 rgb24_to_uv_128_neon: 0.5 rgb24_to_uv_1080_c: 7.0 rgb24_to_uv_1080_neon: 5.7 rgb24_to_uv_1920_c: 12.5 rgb24_to_uv_1920_neon: 9.5 rgb24_to_uv_half_8_c: 0.2 rgb24_to_uv_half_8_neon: 0.2 rgb24_to_

[FFmpeg-devel] 回复: [PATCH v2 3/3] tests/checkasm/vvc_alf: change alf step size to 8

2024-06-06 Thread Wu Jianhua
Bross, Benjamin: > 发件人: Bross, Benjamin > 发送时间: 2024年6月3日 3:42 > 收件人: FFmpeg development discussions and patches > 抄送: Wu Jianhua > 主题: Re: [FFmpeg-devel] [PATCH v2 3/3] tests/checkasm/vvc_alf: change alf step > size to 8 > >> From Benjamin Bross: >>> for ALF where functions are in increments of

[FFmpeg-devel] [PATCH 1/3] sws/input: R-V V 32-bit RGB to Y

2024-06-06 Thread Rémi Denis-Courmont
T-Head C908: abgr_to_y_8_c:2.5 abgr_to_y_8_rvv_i32: 2.2 abgr_to_y_128_c: 37.0 abgr_to_y_128_rvv_i32:8.5 abgr_to_y_1080_c: 327.0 abgr_to_y_1080_rvv_i32: 69.5 abgr_to_y_1920_c: 552.0 abgr_to_y_1920_rvv_i32: 122.2 bgra_to_y_8_c:2.5 bgra_to_y_8_rvv_

[FFmpeg-devel] [PATCH 2/3] sws/input: R-V V 32-bit RGB to UV

2024-06-06 Thread Rémi Denis-Courmont
--- libswscale/riscv/input.S | 52 ++ libswscale/riscv/swscale.c | 8 ++ 2 files changed, 60 insertions(+) diff --git a/libswscale/riscv/input.S b/libswscale/riscv/input.S index 8dfd012a9d..2d00a5a225 100644 --- a/libswscale/riscv/input.S +++ b/libswscal

[FFmpeg-devel] [PATCH 3/3] sws/input: R-V V 32-bit RGB to halved UV

2024-06-06 Thread Rémi Denis-Courmont
T-Head C908: abgr_to_uv_half_8_c:2.2 abgr_to_uv_half_8_rvv_i32: 3.5 abgr_to_uv_half_128_c: 44.0 abgr_to_uv_half_128_rvv_i32: 13.0 abgr_to_uv_half_1080_c: 245.0 abgr_to_uv_half_1080_rvv_i32: 107.2 abgr_to_uv_half_1920_c: 406.2 abgr_to_uv_half_1920_rvv_i32: 188.

[FFmpeg-devel] [PATCH] lavc/flacdsp: fix sign extension in R-V V wasted33

2024-06-06 Thread Rémi Denis-Courmont
We need to use either VWCVT.X.X.V or VSEXT.VF2. The later is preferable to avoid changing VTYPE. --- libavcodec/riscv/flacdsp_rvv.S | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/riscv/flacdsp_rvv.S b/libavcodec/riscv/flacdsp_rvv.S index ea42f8bea4..1724aee9d7

[FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: fix tilepart processing

2024-06-06 Thread Osamu Watanabe
From: Osamu Watanabe <65328111+osamu...@users.noreply.github.com> Fix http://trac.ffmpeg.org/ticket/10121 Signed-off-by: Osamu Watanabe --- libavcodec/jpeg2000dec.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.

[FFmpeg-devel] [PATCH 1/5] avformat/mov: Check requested_sample before using it

2024-06-06 Thread Michael Niedermayer
I am not sure the case described by coverity is possible but its more robust checking the argument first Fixes: CID1598441 Improper use of negative value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[FFmpeg-devel] [PATCH 2/5] avformat/mpeg: Check len in mpegps_probe()

2024-06-06 Thread Michael Niedermayer
Fixes: CID1473590 Untrusted loop bound Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/mpeg.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index 5556861e1c4..c3dff3e4ea2 100644 --- a/libavformat/mpeg.c +++ b/l

[FFmpeg-devel] [PATCH 3/5] avformat/mxfdec: Check container_ul->desc before use

2024-06-06 Thread Michael Niedermayer
Fixes: CID1592939 Dereference after null check Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e65cec74c23..820b03940aa 100644 --- a/libavformat/mxf

[FFmpeg-devel] [PATCH 4/5] avformat/mxfenc: Remove dead code

2024-06-06 Thread Michael Niedermayer
Fixes: CID1524681 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/mxfenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index f424858fc4e..b8e7bfe3018 100644 --- a/libavformat/mxfenc.c +

[FFmpeg-devel] [PATCH 5/5] avformat/rdt: Check pkt_len

2024-06-06 Thread Michael Niedermayer
Fixes: CID1473553 Untrusted loop bound Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/rdt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rdt.c b/libavformat/rdt.c index 60449d256a5..2fa53d34a8d 100644 --- a/libavformat/rdt.c +++ b/libavf

Re: [FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display

2024-06-06 Thread Hiccup Zhu
On Thu, 6 Jun 2024 at 20:20, Zhao Zhili wrote: > > > On Jun 6, 2024, at 19:51, Shiqi Zhu wrote: > > > I’m afraid this has the same issue as libavdevice/sdl[1]. > > [1] > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230918063728.198377-1-haihao.xi...@intel.com/ > Thank you for the reminde

Re: [FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display

2024-06-06 Thread Zhao Zhili
> On Jun 7, 2024, at 10:12, Hiccup Zhu wrote: > > On Thu, 6 Jun 2024 at 20:20, Zhao Zhili wrote: >> >> >> On Jun 6, 2024, at 19:51, Shiqi Zhu wrote: >> >> >> I’m afraid this has the same issue as libavdevice/sdl[1]. >> >> [1] >> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230918

Re: [FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display

2024-06-06 Thread Shiqi Zhu
On Fri, 7 Jun 2024 at 10:32, Zhao Zhili wrote: > > > > > On Jun 7, 2024, at 10:12, Hiccup Zhu wrote: > > > > On Thu, 6 Jun 2024 at 20:20, Zhao Zhili wrote: > >> > >> > >> On Jun 6, 2024, at 19:51, Shiqi Zhu wrote: > >> > >> > >> I’m afraid this has the same issue as libavdevice/sdl[1]. > >> > >

Re: [FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display

2024-06-06 Thread Rémi Denis-Courmont
Hi, Le 7 juin 2024 06:33:20 GMT+03:00, Shiqi Zhu a écrit : >> Initialization and render in the same thread is one of the issues. Another >> issue is SDL render should be run in main thread. Maybe it’s not the >> duty of this filter to control which thread to be called, but this wouldn’t >> work w