Re: [FFmpeg-devel] [PATCH] avcodec/jni: fix mixed declaration and code

2024-04-21 Thread Matthieu Bouron
On Mon, Apr 15, 2024 at 07:02:36PM +0200, Matthieu Bouron wrote: > On Thu, Apr 04, 2024 at 10:07:25PM +0200, Matthieu Bouron wrote: > > --- > > libavcodec/jni.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/jni.c b/libavcodec/jni.c > > index 1193c608

Re: [FFmpeg-devel] FFmpeg table at NAB

2024-04-21 Thread Rémi Denis-Courmont
Hi, I have been dragged privately into this issue so for the sake of transparency, I will just sum up my side here. Le 17 avril 2024 07:21:18 GMT+08:00, Devin Heitmueller a écrit : >Hello all, > >I wasn't looking to start trouble, but I didn't see any discussion of >this on the mailing list s

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-21 Thread Rémi Denis-Courmont
Le 17 avril 2024 21:58:32 GMT+08:00, Michael Niedermayer a écrit : >Hi all > >The pace of inovation in FFmpeg has been slowing down. >Most work is concentarted nowadays on code refactoring, and adding >support for new codecs and formats. OSS projects of age similar to FFmpeg are either mature

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-21 Thread Lynne
Apr 12, 2024, 11:12 by d...@lynne.ee: > Apr 12, 2024, 00:45 by mich...@niedermayer.cc: > >> On Thu, Apr 11, 2024 at 07:42:37AM +0200, Lynne wrote: >> >>> Apr 10, 2024, 23:57 by mich...@niedermayer.cc: >>> >>> > On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wrote: >>> > >>> >> On We

Re: [FFmpeg-devel] [PATCH 3/4] lavc/vvc_parser: Fixed the has_b_frames setting

2024-04-21 Thread Nuo Mi
On Sun, Apr 21, 2024 at 10:51 AM myp...@gmail.com wrote: > On Sat, Apr 20, 2024 at 11:50 AM Nuo Mi wrote: > > > > On Fri, Apr 19, 2024 at 9:55 PM Jun Zhao wrote: > > > > > From: Jun Zhao > > > > > > has_b_frames used in decoder for size of the frame reordering > > > buffer, setting this field

Re: [FFmpeg-devel] [PATCH 4/4] lavc/vvc/refs: Use dpb_max_num_reorder_pics to control output

2024-04-21 Thread Nuo Mi
Thank you for the clip. Applied all except the libxevd one On Sun, Apr 21, 2024 at 10:34 AM myp...@gmail.com wrote: > Send it privately via email > > > On Sat, Apr 20, 2024 at 11:55 AM Nuo Mi wrote: > > > > Hi Barry and Eliny, > > LGTM. > > Thank you for the patch. > > Is it possible to provide

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-21 Thread Ondřej Fiala
On Fri Apr 19, 2024 at 12:45 AM CEST, Michael Niedermayer wrote: > a small change to trac is easy to do and easy to undo, if it helps, > iam not sure a switch to GitLab/Gitea/Forgejo will happen, or even if it is a > good idea. > > we lack people with time and interrest to review and apply patches

[FFmpeg-devel] [PATCH] avcodec/vvcdec: ff_vvc_frame_submit, avoid initializing task twice.

2024-04-21 Thread Nuo Mi
For some error bitstreams, a CTU belongs to two slices/entry points. If the decoder initializes and submmits the CTU task twice, it may crash the program or cause it to enter an infinite loop. Reported-by: Frank Plowman --- libavcodec/vvc/dec.c| 7 +-- libavcodec/vvc/thread.c | 43

[FFmpeg-devel] [PATCH 2/2 v2] avformat/demux: extract extradata from packets when context update is requested

2024-04-21 Thread James Almer
If the demuxer doesn't set extradata in the stream's codecpar, a need_context_update request will delete the previously extracted extradata in the stream's internal AVCodecContext. As we can't ensure the old extradata is valid for the stream in its post context update request state, try to get extr

Re: [FFmpeg-devel] [PATCH 2/2 v2] avformat/demux: extract extradata from packets when context update is requested

2024-04-21 Thread Andreas Rheinhardt
James Almer: > If the demuxer doesn't set extradata in the stream's codecpar, a > need_context_update request will delete the previously extracted extradata in > the stream's internal AVCodecContext. > As we can't ensure the old extradata is valid for the stream in its post > context update request

Re: [FFmpeg-devel] [PATCH 2/2 v2] avformat/demux: extract extradata from packets when context update is requested

2024-04-21 Thread James Almer
On 4/21/2024 12:32 PM, Andreas Rheinhardt wrote: James Almer: If the demuxer doesn't set extradata in the stream's codecpar, a need_context_update request will delete the previously extracted extradata in the stream's internal AVCodecContext. As we can't ensure the old extradata is valid for the

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: ff_vvc_frame_submit, avoid initializing task twice.

2024-04-21 Thread Frank Plowman
On 21/04/2024 15:52, Nuo Mi wrote: > For some error bitstreams, a CTU belongs to two slices/entry points. > If the decoder initializes and submmits the CTU task twice, it may crash the > program > or cause it to enter an infinite loop. > > Reported-by: Frank Plowman > --- > libavcodec/vvc/dec.c

Re: [FFmpeg-devel] [PATCH 2/2 v2] avformat/demux: extract extradata from packets when context update is requested

2024-04-21 Thread Andreas Rheinhardt
James Almer: > On 4/21/2024 12:32 PM, Andreas Rheinhardt wrote: >> James Almer: >>> If the demuxer doesn't set extradata in the stream's codecpar, a >>> need_context_update request will delete the previously extracted >>> extradata in >>> the stream's internal AVCodecContext. >>> As we can't ensure

[FFmpeg-devel] [PATCH v2] tools: add target_enc_fuzzer.c

2024-04-21 Thread Michael Niedermayer
Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- Makefile | 3 + tools/Makefile| 3 + tools/target_enc_fuzzer.c | 201 ++ 3 files changed, 207 insertions(+) create mode 100644 tools/target_enc_fuzzer.c

Re: [FFmpeg-devel] [PATCH] tools: add target_enc_fuzzer.c

2024-04-21 Thread Michael Niedermayer
On Sat, Apr 20, 2024 at 09:50:19AM +0200, Stefano Sabatini wrote: > On date Saturday 2024-04-20 03:10:37 +0200, Michael Niedermayer wrote: [...] > > +static const FFCodec *AVCodecInitialize(enum AVCodecID codec_id) > > nit: snake_case, also the function is used once and the code can be > embedded

Re: [FFmpeg-devel] [PATCH] tools: add target_enc_fuzzer.c

2024-04-21 Thread Michael Niedermayer
On Fri, Apr 19, 2024 at 10:48:05PM -0300, James Almer wrote: > On 4/19/2024 10:10 PM, Michael Niedermayer wrote: > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > Makefile | 3 + > > tools/Makefile| 3 + > > tools/target_e

Re: [FFmpeg-devel] [PATCH v2] tools: add target_enc_fuzzer.c

2024-04-21 Thread James Almer
On 4/21/2024 2:05 PM, Michael Niedermayer wrote: Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- Makefile | 3 + tools/Makefile| 3 + tools/target_enc_fuzzer.c | 201 ++ 3 files changed, 207 insert

[FFmpeg-devel] [PATCH v3] tools: add target_enc_fuzzer.c

2024-04-21 Thread Michael Niedermayer
Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- Makefile | 3 + tools/Makefile| 3 + tools/target_enc_fuzzer.c | 203 ++ 3 files changed, 209 insertions(+) create mode 100644 tools/target_enc_fuzzer.c

Re: [FFmpeg-devel] FFmpeg table at NAB

2024-04-21 Thread Thilo Borgmann via ffmpeg-devel
Hi, On 21.04.24 10:47, Rémi Denis-Courmont wrote: > Hi, > > I have been dragged privately into this issue so for the sake of transparency, I will just sum up my side here. > > > Le 17 avril 2024 07:21:18 GMT+08:00, Devin Heitmueller a écrit : >> Hello all, >> >> I wasn't looking to start tro

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-21 Thread Michael Niedermayer
On Sun, Apr 21, 2024 at 05:11:36PM +0800, Rémi Denis-Courmont wrote: > > > Le 17 avril 2024 21:58:32 GMT+08:00, Michael Niedermayer > a écrit : > >Hi all > > > >The pace of inovation in FFmpeg has been slowing down. > >Most work is concentarted nowadays on code refactoring, and adding > >suppor

Re: [FFmpeg-devel] [PATCHSET] AAC decoder refactor

2024-04-21 Thread Michael Niedermayer
On Fri, Apr 12, 2024 at 11:11:53AM +0200, Lynne wrote: > Apr 12, 2024, 00:45 by mich...@niedermayer.cc: > > > On Thu, Apr 11, 2024 at 07:42:37AM +0200, Lynne wrote: > > > >> Apr 10, 2024, 23:57 by mich...@niedermayer.cc: > >> > >> > On Wed, Apr 10, 2024 at 08:18:11PM +0200, Michael Niedermayer wro

[FFmpeg-devel] [PATCH 1/3] avfilter/signature_lookup: Fix 2 differences to the refernce SW

2024-04-21 Thread Michael Niedermayer
Fixes: CID1403227 Division or modulo by float zero Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/signature_lookup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index

[FFmpeg-devel] [PATCH 2/3] avfilter/signature_lookup: Initialize bestmatch

2024-04-21 Thread Michael Niedermayer
Fixes: CID1500345 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/signature_lookup.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index a30

[FFmpeg-devel] [PATCH 3/3] avfilter/signature_lookup: Dont copy uninitialized stuff around

2024-04-21 Thread Michael Niedermayer
Fixes: CID1403238 Uninitialized pointer read Fixes: CID1403239 Uninitialized pointer read Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/signature_lookup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/signature_lookup.c

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/signature_lookup: Initialize bestmatch

2024-04-21 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: CID1500345 Uninitialized scalar variable > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavfilter/signature_lookup.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavfilter/signature_lookup.c b/l

[FFmpeg-devel] [PATCH] avfilter/avfiltergraph: Add comment about ignored return value

2024-04-21 Thread Michael Niedermayer
Fixes: CID1397741 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/avfiltergraph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index 0c569eb218e..4eeaa33d5

Re: [FFmpeg-devel] [PATCH v3] tools: add target_enc_fuzzer.c

2024-04-21 Thread James Almer
On 4/21/2024 4:14 PM, Michael Niedermayer wrote: Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- Makefile | 3 + tools/Makefile| 3 + tools/target_enc_fuzzer.c | 203 ++ 3 files changed, 209 insert

[FFmpeg-devel] [PATCH] avfilter/vf_thumbnail_cuda: Set ret before checking it

2024-04-21 Thread Michael Niedermayer
Fixes: CID1418336 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/vf_thumbnail_cuda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c index 0459070800a..

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-21 Thread James Almer
On 4/17/2024 10:58 AM, Michael Niedermayer wrote: Hi all The pace of inovation in FFmpeg has been slowing down. Most work is concentarted nowadays on code refactoring, and adding support for new codecs and formats. Should we * make a list of longer term goals * vote on them * and then together

[FFmpeg-devel] [PATCH] avcodec/cbs_h2645: Check NAL space

2024-04-21 Thread Michael Niedermayer
Found-by-reviewing: CID1419833 Untrusted loop bound Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/cbs_h2645.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index fe2e383ff33..1a45d424bae 100644 --- a/

Re: [FFmpeg-devel] FFmpeg table at NAB

2024-04-21 Thread Rémi Denis-Courmont
Hi, Thilo is calling Kieran, myself and presumably Derek and JB trolls. This seems to be a pattern against anyone who disagrees with him. Le 22 avril 2024 04:25:20 GMT+08:00, Thilo Borgmann via ffmpeg-devel a écrit : >Hi, > >On 21.04.24 10:47, Rémi Denis-Courmont wrote: >> Hi, >> >> I have bee

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/signature_lookup: Initialize bestmatch

2024-04-21 Thread Michael Niedermayer
On Mon, Apr 22, 2024 at 01:10:47AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1500345 Uninitialized scalar variable > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/signature_lookup.c | 4 +--- > > 1 file changed,

[FFmpeg-devel] [PATCH 2/2 v3] avformat/demux: extract extradata from packets when context update is requested

2024-04-21 Thread James Almer
If the demuxer doesn't set extradata in the stream's codecpar, a need_context_update request will delete the previously extracted extradata in the stream's internal AVCodecContext. As we can't ensure the old extradata is valid for the stream in its post context update request state, try to get extr