Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2024-03-05 Thread Michael Riedl
Ping.  Anything missing or wrong with this patch? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscri

[FFmpeg-devel] [PATCH v3 1/2] avcodec/vaapi_encode_h264: use is_reference to fill reference_pic_flag

2024-03-05 Thread tong1 . wu-at-intel . com
From: Tong Wu This codec supports FLAG_B_PICTURE_REFERENCES. We need to correctly fill the reference_pic_flag with is_reference variable instead of 0 for B frames. Signed-off-by: Tong Wu --- libavcodec/vaapi_encode_h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/liba

[FFmpeg-devel] [PATCH v3 2/2] avcodec/vaapi_encode_h265: use is_reference to fill reference_pic_flag

2024-03-05 Thread tong1 . wu-at-intel . com
From: Tong Wu This codec supports FLAG_B_PICTURE_REFERENCES. We need to fill reference_pic_flag with pic->is_reference. Signed-off-by: Tong Wu --- libavcodec/vaapi_encode_h265.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vaapi_encode_h265: use is_reference to fill reference_pic_flag

2024-03-05 Thread Wu, Tong1
>Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vaapi_encode_h265: use >is_reference to fill reference_pic_flag > >On Di, 2024-02-27 at 11:48 +0800, tong1.wu-at-intel@ffmpeg.org wrote: >> From: Tong Wu >> >> This codec supports FLAG_B_PICTURE_REFERENCES. We need to fill >> reference_pic_flag

Re: [FFmpeg-devel] [PATCH 06/29] lavu/opt: add array options

2024-03-05 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-04 14:29:59) >> Anton Khirnov: >>> --- >>> doc/APIchanges| 3 + >>> libavutil/opt.c | 362 +- >>> libavutil/opt.h | 62 +++- >>> libavutil/tests/opt.c | 51 ++ >>> tests/ref

Re: [FFmpeg-devel] [PATCH 05/29] lavu/opt: distinguish between native and foreign access for AVOption fields

2024-03-05 Thread Anton Khirnov
Quoting Marton Balint (2024-03-04 23:39:19) > On Mon, 4 Mar 2024, Anton Khirnov wrote: > > Native access is from the code that declared the options, foreign access > > is from code that is using the options. Forbid foreign access to > > AVOption.offset/default_val, for which there is no good reason

Re: [FFmpeg-devel] [PATCH 06/29] lavu/opt: add array options

2024-03-05 Thread Anton Khirnov
Quoting Marton Balint (2024-03-04 22:32:21) > > @@ -330,6 +380,14 @@ typedef struct AVOption { > > const char *str; > > /* TODO those are unused now */ > > AVRational q; > > + > > +/** > > + * Used for AV_OPT_TYPE_FLAG_ARRAY options. May be NULL. > > This co

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread Anton Khirnov
Quoting Derek Buitenhuis (2024-03-04 15:05:29) > On 3/4/2024 1:06 PM, Anton Khirnov wrote: > > +/** > > + * Decoding only. May be set by the caller before avcodec_open2() to an > > + * av_malloc()'ed array (or via AVOptions). Owned and freed by the > > decoder > > + * afterwards. >

Re: [FFmpeg-devel] [PATCH 23/29] avcodec/mpeg12dec: use ff_frame_new_side_data

2024-03-05 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-04 14:36:09) > Anton Khirnov: > > From: Niklas Haas > > > > For consistency, even though this cannot be overriden at the packet > > level. > > --- > > libavcodec/mpeg12dec.c | 18 ++ > > 1 file changed, 10 insertions(+), 8 deletions(-) > > > >

Re: [FFmpeg-devel] [PATCH 05/29] lavu/opt: distinguish between native and foreign access for AVOption fields

2024-03-05 Thread Diederick C. Niehorster
On Mon, Mar 4, 2024 at 11:39 PM Marton Balint wrote: > On Mon, 4 Mar 2024, Anton Khirnov wrote: > > > Native access is from the code that declared the options, foreign access > > is from code that is using the options. Forbid foreign access to > > AVOption.offset/default_val, for which there is n

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-05 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-03-05 03:36:14) > On Mon, Mar 04, 2024 at 10:15:31PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-03-04 00:36:21) > > > [words words] > > > > Again - why do you personally need so many choices? Just one should be > > enough. If someone else wa

[FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: Redo checking for strftime %s support to avoid warnings

2024-03-05 Thread Andreas Rheinhardt
This is intended to avoid -Wformat= warnings on systems where %s might not be supported (and also generally emitted by GCC with -pedantic). Signed-off-by: Andreas Rheinhardt --- libavformat/hlsenc.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/libavfor

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-05 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-03-05 03:50:01) > The STF opertunity had a deadline. > Also we can already start discussing what shall be done when the next grant > opertunity comes. How about some actual transparency instead of backroom deals, for a change. The application has apparently been

[FFmpeg-devel] [PATCH 2/2] avformat/dashenc, hlsenc: Return 0 on succes from write_header

2024-03-05 Thread Andreas Rheinhardt
Do not propagate the return value of avformat_write_header(), as it contains the information whether the output had already been initialized in avformat_init_output(), but this is set generically; the return value of FFOutputFormat.write_header is not documented at all (and is currently ignored if

[FFmpeg-devel] [PATCH] checkasm/hevc_deblock: Initialize buffer

2024-03-05 Thread Andreas Rheinhardt
Fixes the hevc_deblock checkasm test with Valgrind. Signed-off-by: Andreas Rheinhardt --- tests/checkasm/hevc_deblock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/checkasm/hevc_deblock.c b/tests/checkasm/hevc_deblock.c index 91e57f5cf5..04cf9d87ac 100644 --- a/tests/checkasm/hevc_

Re: [FFmpeg-devel] [PATCH] avformat/options: Deprecate av_fmt_ctx_get_duration_estimation_method()

2024-03-05 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Forgotten in b7785d10b00c88029d8af7dbddac09ab0d6f2b7f. > > Signed-off-by: Andreas Rheinhardt > --- > doc/APIchanges | 4 > libavformat/avformat.h | 4 > libavformat/options.c | 2 ++ > libavformat/version_major.h | 1 + > 4 files changed, 1

Re: [FFmpeg-devel] [PATCH v7 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-05 Thread Anton Khirnov
Quoting James Almer (2024-03-01 21:42:28) > On 3/1/2024 3:19 PM, Anton Khirnov wrote: > > Quoting Jan Ekström (2024-02-29 17:42:54) > >> diff --git a/libavutil/frame.h b/libavutil/frame.h > >> index 47d0096bc4..908fd4a90d 100644 > >> --- a/libavutil/frame.h > >> +++ b/libavutil/frame.h > >> @@ -108

Re: [FFmpeg-devel] [PATCH 1/1] avformat/demux: Add durationprobesize AVOption

2024-03-05 Thread Nicolas Gaullier
>De : Stefano Sabatini >Envoyé : mercredi 7 février 2024 00:52 > >> diff --git a/libavformat/avformat.h b/libavformat/avformat.h index >> + * stream durations. Used by avformat_find_stream_info() for MPEG-TS/PS. > >let's clarify this: is there any reason why this should not be used with othe

Re: [FFmpeg-devel] [PATCH v7 11/14] ffmpeg: pass first video AVFrame's side data to encoder

2024-03-05 Thread Anton Khirnov
Quoting Jan Ekström (2024-02-29 17:42:58) > This enables further configuration of output based on the results > of input decoding and filtering in a similar manner as the color > information. > --- > fftools/ffmpeg_enc.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/fftools

[FFmpeg-devel] [PATCH v2 1/1] avformat/demux: Add durationprobesize AVOption

2024-03-05 Thread Nicolas Gaullier
Yet another probesize used to get the durations when estimate_timings_from_pts is required. It is aimed at users interested in better durations probing for itself, or because using avformat_find_stream_info indirectly and requiring exact values: for concatdec for example, especially if streamcopyin

[FFmpeg-devel] [PATCH v2 0/1] avformat/demux: Add durationprobesize AVOption

2024-03-05 Thread Nicolas Gaullier
Thanks to Stefano for the review. So v2 updated with: - doc/APIchanges - doc/formats.texi - revised wording It remains a question about the naming: duration plural or not ? The avoption base name is currently durationprobesize / s->duration_probesize to mimic formatprobesize / s->format_probesize.

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread James Almer
On 3/4/2024 10:06 AM, Anton Khirnov wrote: This and the following commits fix #10857 --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 20 libavcodec/decode.c| 36 libavcodec/options_table.h | 13 ++

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-05 Thread Vittorio Giovara
On Tue, Mar 5, 2024 at 3:50 AM Michael Niedermayer wrote: > On Mon, Mar 04, 2024 at 10:45:02AM +0100, Vittorio Giovara wrote: > > On Mon, Mar 4, 2024 at 1:57 AM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Sun, Mar 03, 2024 at 03:49:33AM +0100, Michael Niedermayer wrote

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: Redo checking for strftime %s support to avoid warnings

2024-03-05 Thread Liu Steven
> On Mar 5, 2024, at 18:27, Andreas Rheinhardt > wrote: > > This is intended to avoid -Wformat= warnings on systems > where %s might not be supported (and also generally emitted > by GCC with -pedantic). > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hlsenc.c | 19

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread Anton Khirnov
Quoting James Almer (2024-03-05 13:30:58) > > +{"dynamic_hdr10_plus", .default_val.i64 = > > AV_PKT_DATA_DYNAMIC_HDR10_PLUS, .type = AV_OPT_TYPE_CONST, .flags > > = A|D, .unit = "side_data_pkt" }, > > This one packet/frame level only, not global. It is in sd_global_map >

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: fix printing side data components and pieces

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 15:56:46 -0300, James Almer wrote: > Components and pieces are side data specific fields and there's a variable > amount of them. > They also need to be identified in some form, so print a type too. > > Signed-off-by: James Almer > --- > You can see the difference with >

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread James Almer
On 3/5/2024 11:29 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-05 13:30:58) +{"dynamic_hdr10_plus", .default_val.i64 = AV_PKT_DATA_DYNAMIC_HDR10_PLUS, .type = AV_OPT_TYPE_CONST, .flags = A|D, .unit = "side_data_pkt" }, This one packet/frame level only, not globa

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: fix printing side data components and pieces

2024-03-05 Thread James Almer
On 3/5/2024 11:34 AM, Stefano Sabatini wrote: On date Monday 2024-03-04 15:56:46 -0300, James Almer wrote: Components and pieces are side data specific fields and there's a variable amount of them. They also need to be identified in some form, so print a type too. Signed-off-by: James Almer --

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: fix printing side data components and pieces

2024-03-05 Thread Stefano Sabatini
On date Tuesday 2024-03-05 11:38:20 -0300, James Almer wrote: > On 3/5/2024 11:34 AM, Stefano Sabatini wrote: > > On date Monday 2024-03-04 15:56:46 -0300, James Almer wrote: > > > Components and pieces are side data specific fields and there's a variable > > > amount of them. > > > They also need

[FFmpeg-devel] [PATCH] avcodec/decode: remove HDR10+ from the global side data array

2024-03-05 Thread James Almer
It's a per packet/frame side data type. Signed-off-by: James Almer --- libavcodec/decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 7c67b18bc4..cd483528c5 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -143

Re: [FFmpeg-devel] [PATCH 1/9 v2] fftools/ffprobe: fix printing side data components and pieces

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 21:00:21 -0300, James Almer wrote: > Components and pieces are side data specific fields and there's a variable > amount of them. > They also need to be identified in some form, so print a type too. > > Signed-off-by: James Almer > --- > fftools/ffprobe.c | 32 +

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: fix printing side data components and pieces

2024-03-05 Thread James Almer
On 3/5/2024 11:43 AM, Stefano Sabatini wrote: On date Tuesday 2024-03-05 11:38:20 -0300, James Almer wrote: On 3/5/2024 11:34 AM, Stefano Sabatini wrote: On date Monday 2024-03-04 15:56:46 -0300, James Almer wrote: Components and pieces are side data specific fields and there's a variable amou

Re: [FFmpeg-devel] [PATCH 2/9] avformat/avformat: add a function to return the name of stream groups

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 21:00:22 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > Missing version bump and APIChanges entry. > > libavformat/avformat.c | 10 ++ > libavformat/avformat.h | 5 + > 2 files changed, 15 insertions(+) > > diff --git a/libavformat/avformat

Re: [FFmpeg-devel] [PATCH 2/9] avformat/avformat: add a function to return the name of stream groups

2024-03-05 Thread Stefano Sabatini
On date Tuesday 2024-03-05 15:50:23 +0100, Stefano Sabatini wrote: > On date Monday 2024-03-04 21:00:22 -0300, James Almer wrote: > > Signed-off-by: James Almer > > --- > > Missing version bump and APIChanges entry. > > > > libavformat/avformat.c | 10 ++ > > libavformat/avformat.h | 5

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread Anton Khirnov
Quoting James Almer (2024-03-05 15:35:02) > On 3/5/2024 11:29 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-03-05 13:30:58) > >>> +{"dynamic_hdr10_plus", .default_val.i64 = > >>> AV_PKT_DATA_DYNAMIC_HDR10_PLUS, .type = AV_OPT_TYPE_CONST, > >>> .flags = A|D, .unit =

Re: [FFmpeg-devel] [PATCH 2/9] avformat/avformat: add a function to return the name of stream groups

2024-03-05 Thread James Almer
On 3/5/2024 11:52 AM, Stefano Sabatini wrote: On date Tuesday 2024-03-05 15:50:23 +0100, Stefano Sabatini wrote: On date Monday 2024-03-04 21:00:22 -0300, James Almer wrote: Signed-off-by: James Almer --- Missing version bump and APIChanges entry. libavformat/avformat.c | 10 ++ li

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat/demux: Add durationprobesize AVOption

2024-03-05 Thread Anton Khirnov
Quoting Nicolas Gaullier (2024-03-05 13:07:51) > diff --git a/doc/APIchanges b/doc/APIchanges > index 7d46ebb006..548c91effe 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2023-02-09 > > API changes, most recent first: >

Re: [FFmpeg-devel] [PATCH 3/9 v3] fftools/ffprobe: add support for Stream Groups

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 21:00:23 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > Changelog | 1 + > doc/ffprobe.xsd | 1 + > fftools/ffprobe.c | 147 -- > tests/ref/f

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread James Almer
On 3/5/2024 11:54 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-05 15:35:02) On 3/5/2024 11:29 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-05 13:30:58) +{"dynamic_hdr10_plus", .default_val.i64 = AV_PKT_DATA_DYNAMIC_HDR10_PLUS, .type = AV_OPT_TYPE_CONST,

Re: [FFmpeg-devel] [PATCH 3/9 v3] fftools/ffprobe: add support for Stream Groups

2024-03-05 Thread James Almer
On 3/5/2024 12:06 PM, Stefano Sabatini wrote: On date Monday 2024-03-04 21:00:23 -0300, James Almer wrote: Signed-off-by: James Almer --- Changelog | 1 + doc/ffprobe.xsd | 1 + fftools/ffprobe.c

Re: [FFmpeg-devel] [PATCH 4/9 v2] fate/iamf: print stream group information

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 21:00:24 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > tests/fate/iamf.mak | 8 ++-- > tests/ref/fate/iamf-5_1_4 | 60 + > tests/ref/fate/iamf-7_1_4 | 68 + > tests/ref/

Re: [FFmpeg-devel] [PATCH 5/9 v2] fate/mov: print stream group information for iamf tests

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 21:00:25 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > tests/fate/mov.mak | 12 +- > tests/ref/fate/mov-mp4-iamf-5_1_4 | 318 + > tests/ref/fate/mov-mp4-iamf-7_1_4 | 362 > te

Re: [FFmpeg-devel] [PATCH 6/9] fftools/ffprobe: export Tile Grid Stream Group parameters

2024-03-05 Thread James Almer
On 3/4/2024 9:00 PM, James Almer wrote: Signed-off-by: James Almer --- fftools/ffprobe.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index ff05c4c1db..e736023bcd 100644 --- a/fftools/ffpro

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread Anton Khirnov
Quoting James Almer (2024-03-05 16:07:05) > > > > One possible solution is to rename the option to something like > > side_data_prefer_external (better names welcome), and have it switch > > between user-supplied (i.e. global or per-packet) and in-bitstream side > > data. > > > > This adds an amb

Re: [FFmpeg-devel] [PATCH 6/9] fftools/ffprobe: export Tile Grid Stream Group parameters

2024-03-05 Thread Stefano Sabatini
On date Monday 2024-03-04 21:00:26 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/ffprobe.c | 41 - > 1 file changed, 36 insertions(+), 5 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index ff05c4c1db..e73602

Re: [FFmpeg-devel] [PATCH 6/9] fftools/ffprobe: export Tile Grid Stream Group parameters

2024-03-05 Thread Stefano Sabatini
On date Tuesday 2024-03-05 12:14:53 -0300, James Almer wrote: > On 3/4/2024 9:00 PM, James Almer wrote: > > Signed-off-by: James Almer > > --- > > fftools/ffprobe.c | 41 - > > 1 file changed, 36 insertions(+), 5 deletions(-) [...] > I think I'll withdr

Re: [FFmpeg-devel] [PATCH 6/9] fftools/ffprobe: export Tile Grid Stream Group parameters

2024-03-05 Thread James Almer
On 3/5/2024 12:24 PM, Stefano Sabatini wrote: On date Tuesday 2024-03-05 12:14:53 -0300, James Almer wrote: On 3/4/2024 9:00 PM, James Almer wrote: Signed-off-by: James Almer --- fftools/ffprobe.c | 41 - 1 file changed, 36 insertions(+), 5 deletion

[FFmpeg-devel] [PATCH] avutil/dict: Deduplicate freeing dictionary

2024-03-05 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/dict.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index 7f23d5336a..6fb09399ba 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -145,11 +145,8 @@ int av_dict_set(AVDictio

[FFmpeg-devel] [PATCH 1/2] avcodec/vdpau: Remove outdated comment

2024-03-05 Thread Andreas Rheinhardt
Forgotten in b773a8d8c1dfe4cfc6eabf509e26ab011270b9ed. Signed-off-by: Andreas Rheinhardt --- libavcodec/vdpau.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/vdpau.c b/libavcodec/vdpau.c index 2b9b78d8d0..c56ee1f44c 100644 --- a/libavcodec/vdpau.c +++ b/libavcodec/vdpau.c @@ -

[FFmpeg-devel] [PATCH 2/2] avcodec/vdpau: Deprecate redundandt allocators and getter/setter

2024-03-05 Thread Andreas Rheinhardt
The allocators have been superseded by av_vdpau_bind_context(). The latter have only been added "to allow multiple forks to add fields to the structure without breaking ABI" [1], but libav is no more, so this is not needed any longer. [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2013-August/1469

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vdpau: Deprecate redundandt allocators and getter/setter

2024-03-05 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The allocators have been superseded by av_vdpau_bind_context(). > The latter have only been added "to allow multiple forks to add > fields to the structure without breaking ABI" [1], but libav > is no more, so this is not needed any longer. > > [1]: https://ffmpeg.org/piperma

[FFmpeg-devel] [RFC]x264 avcc and related issue

2024-03-05 Thread Zhao Zhili
There are multiple encoders which can output bitstream in avcc/hvcc format, e.g, x264, x265 and videotoolbox. This can improve performance depends on container format (no more ff_avc_parse_nal_units_buf). The problem is these encoders output parameter sets directly, not contained in a complete AV

[FFmpeg-devel] [PATCH v3 0/1] avformat/demux: Add durationprobesize AVOption

2024-03-05 Thread Nicolas Gaullier
Thanks to Anton: - fixed APIchanges - reworded the nebulous "calculated using PTS" both for duration_probesize and older skip_estimate_duration_from_pts - documented avformat.h for the special 0 value meaning default behaviour Plus: Added "see also" cross links in apidoc between skip_estimate_dur

[FFmpeg-devel] [PATCH v3 1/1] avformat/demux: Add durationprobesize AVOption

2024-03-05 Thread Nicolas Gaullier
Yet another probesize used to get the durations when estimate_timings_from_pts is required. It is aimed at users interested in better durations probing for itself, or because using avformat_find_stream_info indirectly and requiring exact values: for concatdec for example, especially if streamcopyin

Re: [FFmpeg-devel] [RFC]x264 avcc and related issue

2024-03-05 Thread Andreas Rheinhardt
Zhao Zhili: > There are multiple encoders which can output bitstream in avcc/hvcc format, > e.g, x264, x265 and videotoolbox. This can improve performance depends on > container format (no more ff_avc_parse_nal_units_buf). > > The problem is these encoders output parameter sets directly, not conta

Re: [FFmpeg-devel] [RFC]x264 avcc and related issue

2024-03-05 Thread Zhao Zhili
> 在 2024年3月6日,上午1:58,Andreas Rheinhardt 写道: > > Zhao Zhili: >> There are multiple encoders which can output bitstream in avcc/hvcc format, >> e.g, x264, x265 and videotoolbox. This can improve performance depends on >> container format (no more ff_avc_parse_nal_units_buf). >> >> The problem is

Re: [FFmpeg-devel] [RFC]x264 avcc and related issue

2024-03-05 Thread Andreas Rheinhardt
Zhao Zhili: > >> 在 2024年3月6日,上午1:58,Andreas Rheinhardt 写道: >> >> Zhao Zhili: >>> There are multiple encoders which can output bitstream in avcc/hvcc format, >>> e.g, x264, x265 and videotoolbox. This can improve performance depends on >>> container format (no more ff_avc_parse_nal_units_buf). >>

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-05 Thread Niklas Haas
On Mon, 04 Mar 2024 00:56:02 +0100 Michael Niedermayer wrote: > On Mon, Mar 04, 2024 at 12:36:21AM +0100, Michael Niedermayer wrote: > > On Sun, Mar 03, 2024 at 10:57:43PM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-03-03 03:49:33) > [...] > > > > > > > Please add the vote

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-05 Thread Nicolas George
Michael Niedermayer (12024-03-04): > But if they are presented with a vote that tries to take away their choice > to funnel them into some other option, they should not accept this. A good point to note that the vote should obviously not be organized by somebody who has proposed and defended one o

[FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Avoid relocations for strings

2024-03-05 Thread Andreas Rheinhardt
The longest string here takes four bytes, so using an array of pointers is wasteful even when ignoring the cost of relocations; the lack of relocations also implies that this array will now be put into .rodata and not into .data.rel.ro. Static asserts are used to ensure that all strings are always

Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/parser: merge packets from the same frame

2024-03-05 Thread Michael Niedermayer
Hi On Mon, Mar 04, 2024 at 05:38:48PM +, Nicolas Gaullier wrote: > >De : ffmpeg-devel De la part de Michael > >Niedermayer > >Envoyé : dimanche 3 mars 2024 23:07 > >À : FFmpeg development discussions and patches > >Objet : Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/parser: merge packets from

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Avoid relocations for strings

2024-03-05 Thread Marth64
I did a quick validation with ATSC, DVD, and SCTE sources. Results were as expected. On Tue, Mar 5, 2024 at 2:30 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > The longest string here takes four bytes, so using an array > of pointers is wasteful even when ignoring the cost of re

[FFmpeg-devel] [PATCH 1/9] avcodec/bsf/pcm_rechunk: reorder supported codec list

2024-03-05 Thread Marton Balint
Should be easier to add new codecs by using the same order as in av_get_exact_bits_per_sample(). Signed-off-by: Marton Balint --- libavcodec/bsf/pcm_rechunk.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/libavcodec/bsf/pcm_rechunk.c b/libavcodec/bsf/

[FFmpeg-devel] [PATCH 2/9] avcodec/bsf/pcm_rechunk: add some more supported PCM formats

2024-03-05 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/bsf/pcm_rechunk.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/libavcodec/bsf/pcm_rechunk.c b/libavcodec/bsf/pcm_rechunk.c index 9bbc5a74d6..7198554c17 100644 --- a/libavcodec/bsf/pcm_rechunk.c +++ b/libavcode

[FFmpeg-devel] [PATCH 3/9] avformat/daudenc: force 2000 sample packet size with a bsf

2024-03-05 Thread Marton Balint
The samples I found all have 2000 sample packets, and by forcing the packet size with a bsf we could automagically make muxing work for packets containing more than 3640 samples. Signed-off-by: Marton Balint --- configure | 1 + libavformat/daudenc.c | 11 +--

[FFmpeg-devel] [PATCH 4/9] fate: make filter-channelsplit test use a fixed frame size

2024-03-05 Thread Marton Balint
Muxing multiple streams to raw files is allowed but the packets are interleaved, so the output is dependant of packet size. Signed-off-by: Marton Balint --- tests/fate/filter-audio.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/filter-audio.mak b/tests/fat

[FFmpeg-devel] [PATCH 5/9] fate: use a fixed wav demux packet size for amix tests

2024-03-05 Thread Marton Balint
The dropout transition feature of the amix filter depends on the incoming packet size. Signed-off-by: Marton Balint --- tests/fate/filter-audio.mak | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak index 5b5d741f06

[FFmpeg-devel] [PATCH 6/9] fate: use atrim filter instead of -frames:a 20 for fate-filter-tremolo

2024-03-05 Thread Marton Balint
To make it independent of incoming wav demuxer packet size. Signed-off-by: Marton Balint --- tests/fate/filter-audio.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak index 78fec28b04..6ddc0baf57 100644 --- a/tes

[FFmpeg-devel] [PATCH 7/9] avformat/pcm: use a common default packet size function for both wav and pcm

2024-03-05 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/pcm.c| 38 ++ libavformat/pcm.h| 1 + libavformat/wavdec.c | 11 ++- 3 files changed, 29 insertions(+), 21 deletions(-) diff --git a/libavformat/pcm.c b/libavformat/pcm.c index 9741f73667..b3d23110a

[FFmpeg-devel] [PATCH 8/9] avformat/pcm: remove max samples cap when calculating the default packet size

2024-03-05 Thread Marton Balint
For high sample rate audio it was suboptimal, calculate the low neighbour power of two for the number of samples instead. Signed-off-by: Marton Balint --- libavformat/pcm.c | 6 +- tests/ref/fate/dcinema-encode | 12 +- tests/ref/fate/filter-chorus

Re: [FFmpeg-devel] [PATCH 14/38] lavu/opt: factor per-type dispatch out of av_opt_set()

2024-03-05 Thread Michael Niedermayer
On Sat, Feb 24, 2024 at 07:41:24PM -0300, James Almer wrote: > On 2/23/2024 7:50 PM, Michael Niedermayer wrote: > > Hi Anton > > > > On Fri, Feb 23, 2024 at 02:58:36PM +0100, Anton Khirnov wrote: > > > Will be useful in following commits. > > > --- > > > > breaks: > > > > ./ffmpeg -y -request_ch

Re: [FFmpeg-devel] [PATCH 14/38] lavu/opt: factor per-type dispatch out of av_opt_set()

2024-03-05 Thread Michael Niedermayer
On Sun, Mar 03, 2024 at 01:17:57PM +0100, Anton Khirnov wrote: > Quoting Anton Khirnov (2024-03-01 17:07:22) > > Quoting Michael Niedermayer (2024-02-23 23:50:10) > > > Hi Anton > > > > > > On Fri, Feb 23, 2024 at 02:58:36PM +0100, Anton Khirnov wrote: > > > > Will be useful in following commits.

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: add h264_mp4toannexb bitstream filter if needed when muxing h264

2024-03-05 Thread Marton Balint
On Sat, 24 Feb 2024, Andreas Rheinhardt wrote: Tomas Härdin: +static int mxf_check_bitstream(AVFormatContext *s, AVStream *st, const AVPacket *pkt) +{ +    if (st->codecpar->codec_id == AV_CODEC_ID_H264) { +    if (pkt->size >= 5 && AV_RB32(pkt->data) != 0x001 && +

Re: [FFmpeg-devel] [PATCH 14/38] lavu/opt: factor per-type dispatch out of av_opt_set()

2024-03-05 Thread James Almer
On 3/5/2024 8:08 PM, Michael Niedermayer wrote: On Sat, Feb 24, 2024 at 07:41:24PM -0300, James Almer wrote: On 2/23/2024 7:50 PM, Michael Niedermayer wrote: Hi Anton On Fri, Feb 23, 2024 at 02:58:36PM +0100, Anton Khirnov wrote: Will be useful in following commits. --- breaks: ./ffmpeg -y

Re: [FFmpeg-devel] [PATCH 14/38] lavu/opt: factor per-type dispatch out of av_opt_set()

2024-03-05 Thread James Almer
On 3/5/2024 8:12 PM, Michael Niedermayer wrote: On Sun, Mar 03, 2024 at 01:17:57PM +0100, Anton Khirnov wrote: Quoting Anton Khirnov (2024-03-01 17:07:22) Quoting Michael Niedermayer (2024-02-23 23:50:10) Hi Anton On Fri, Feb 23, 2024 at 02:58:36PM +0100, Anton Khirnov wrote: Will be useful

Re: [FFmpeg-devel] [PATCH] avcodec/decode: remove HDR10+ from the global side data array

2024-03-05 Thread Derek Buitenhuis
On 3/5/2024 2:46 PM, James Almer wrote: > It's a per packet/frame side data type. > > Signed-off-by: James Almer > --- > libavcodec/decode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM - Derek ___ ffmpeg-devel mailing list ffmpeg-dev

Re: [FFmpeg-devel] [PATCH v4] avfilter: add vf_overlay_videotoolbox

2024-03-05 Thread Gnattu OC via ffmpeg-devel
A ping for this as it is already a week. > On Feb 28, 2024, at 00:35, gnattu via ffmpeg-devel > wrote: > > Overlay filter for VideoToolbox hwframes. Unlike most hardware > overlay filters, this filter does not require the two inputs to > have the same pixel format; instead, it will perform form

Re: [FFmpeg-devel] [PATCH] avcodec/decode: remove HDR10+ from the global side data array

2024-03-05 Thread James Almer
On 3/5/2024 8:25 PM, Derek Buitenhuis wrote: On 3/5/2024 2:46 PM, James Almer wrote: It's a per packet/frame side data type. Signed-off-by: James Almer --- libavcodec/decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) LGTM - Derek Applied, thanks. __

[FFmpeg-devel] [PATCH] avcodec/xpmdec: Avoid unnecessary size_t->int conversion

2024-03-05 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/xpmdec.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/xpmdec.c b/libavcodec/xpmdec.c index 5bc02378c8..e7f8a90fdc 100644 --- a/libavcodec/xpmdec.c +++ b/libavcodec/xpmdec.c @@ -233,14 +233,12 @@ static size_

[FFmpeg-devel] [PATCH] avcodec/xbmenc: Avoid snprintf() for data->hex conversion

2024-03-05 Thread Andreas Rheinhardt
Use a small LUT instead. Improves performance. Signed-off-by: Andreas Rheinhardt --- libavcodec/xbmenc.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/libavcodec/xbmenc.c b/libavcodec/xbmenc.c index cd8b73afa3..5231d4691d 100644 --- a/libavcodec/xbmen

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-05 Thread Michael Niedermayer
Hi Vittorio On Tue, Mar 05, 2024 at 01:44:52PM +0100, Vittorio Giovara wrote: > On Tue, Mar 5, 2024 at 3:50 AM Michael Niedermayer > wrote: > > > On Mon, Mar 04, 2024 at 10:45:02AM +0100, Vittorio Giovara wrote: > > > On Mon, Mar 4, 2024 at 1:57 AM Michael Niedermayer < > > mich...@niedermayer.c

Re: [FFmpeg-devel] [PATCH v1 1/2] lavc/vaapi_encode_h265: Map HEVC AV REXT profile to VA REXT profile

2024-03-05 Thread Xiang, Haihao
On Do, 2024-02-29 at 11:25 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- >  libavcodec/vaapi_encode_h265.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_

Re: [FFmpeg-devel] [PATCH v4] libavfi/dnn: add LibTorch as one of DNN backend

2024-03-05 Thread Chen, Wenbin
> > > On Feb 20, 2024, at 7:07 PM, wenbin.chen-at-intel@ffmpeg.org wrote: > > > > From: Wenbin Chen > > > > PyTorch is an open source machine learning framework that accelerates > > the path from research prototyping to production deployment. Official > > website: https://pytorch.org/. We cal

[FFmpeg-devel] [PATCH] lavfi/vulkan_filter: fix input format

2024-03-05 Thread Xiang, Haihao
From: Haihao Xiang Otherwise s->input_format is always yuv420p. This fixes invalid output format for hwframe download in the command below: ./ffmpeg -init_hw_device vulkan -f lavfi \ -i testsrc=duration=1,format=nv12 \ -vf 'hwupload,format=vulkan,scale_vulkan=1024:768,hwdownload

Re: [FFmpeg-devel] [PATCH] avfilter: update filter timeline state only on main link

2024-03-05 Thread Gyan Doshi
On 2024-03-01 07:41 pm, Gyan Doshi wrote: At present, consume_update evaluates timeline state on all links for a multi-input filter. This can lead to the filter being incorrectly en/dis-abled when evaluation on a frame on a secondary link leads to a different result than the frame on the curre

[FFmpeg-devel] [PATCH 2/3] avformat/dvdvideodec: add menu demuxing support

2024-03-05 Thread Marth64
Many DVDs have valuable assets in their menu structures, including background video or music. Some discs also abuse the menu feature to include actual feature footage that needs to change aspect ratio (in order to trick the DVD player). This patch allows extraction and archival of these assets, b

[FFmpeg-devel] [PATCH 1/3] avformat/dvdvideodec: add CLUT utilities and subtitle palette support

2024-03-05 Thread Marth64
Since last iteration: removes unused variable in dvdclut.c Signed-off-by: Marth64 --- doc/demuxers.texi | 5 +++ libavformat/Makefile | 2 +- libavformat/dvdclut.c | 75 +++ libavformat/dvdclut.h | 37 +++ libavformat/dvd

[FFmpeg-devel] [PATCH 3/3] avformat/dvdvideodec: assign mono channel layout explicitly

2024-03-05 Thread Marth64
Signed-off-by: Marth64 --- libavformat/dvdvideodec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index 2c7ffdd148..6136060288 100644 --- a/libavformat/dvdvideodec.c +++ b/libavformat/dvdvideodec.c @@ -1142,7 +1142,9