Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-17 Thread Gyan Doshi
On 2024-02-16 07:25 pm, Andreas Rheinhardt wrote: Gyan Doshi: On 2024-02-15 04:17 pm, Anton Khirnov wrote: Hi, sorry for the delay, I've been busy fixing things for the release Quoting Gyan Doshi via ffmpeg-devel (2024-01-29 05:00:33) On 2024-01-28 04:24 pm, Anton Khirnov wrote: a) it wou

[FFmpeg-devel] FFmpeg TC input needed

2024-02-17 Thread Gyan Doshi
Issue: Patch: avcodec/s302m: enable non-PCM decoding URL: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240127103854.9971-1-ffm...@gyani.pro/ The issue needing resolution is whether the patch should be added to the existing s302m decoder or should that decoder be removed and all old and

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-17 Thread Gyan Doshi
On 2024-02-16 02:33 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-02-15 17:47:49) This patch facilitates a certain productive use of ffmpeg with respect to processing of live inputs that wasn't possible earlier, and which currently is being used successfully by multiple people over the pas

Re: [FFmpeg-devel] FFmpeg TC input needed

2024-02-17 Thread Kieran Kunhya
On Sat, 17 Feb 2024, 11:46 Gyan Doshi, wrote: > Issue: > > Patch: avcodec/s302m: enable non-PCM decoding > URL: > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240127103854.9971-1-ffm...@gyani.pro/ > > The issue needing resolution is whether the patch should be added to the > existing s30

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-17 Thread Anton Khirnov
Quoting Gyan Doshi (2024-02-17 12:46:27) > As a TC member who is part of the disagreement, I believe your > participation is recused. No, I do not think "TC members who commented on a patch lose their right to vote" is a reasonable interpretation of that rule. -- Anton Khirnov _

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-17 Thread Rémi Denis-Courmont
Le lauantaina 17. helmikuuta 2024, 13.46.27 EET Gyan Doshi a écrit : > As a TC member who is part of the disagreement, I believe your > participation is recused. Obviously not. We don't want to get into a situation whence TC members have an incentive not to participate in regular code reviews jus

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-17 Thread Gyan Doshi
On 2024-02-17 05:52 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-02-17 12:46:27) As a TC member who is part of the disagreement, I believe your participation is recused. No, I do not think "TC members who commented on a patch lose their right to vote" is a reasonable interpretation of t

Re: [FFmpeg-devel] FFmpeg TC input needed

2024-02-17 Thread Gyan Doshi
On 2024-02-17 05:31 pm, Kieran Kunhya wrote: On Sat, 17 Feb 2024, 11:46 Gyan Doshi, wrote: Issue: Patch: avcodec/s302m: enable non-PCM decoding URL: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240127103854.9971-1-ffm...@gyani.pro/ The issue needing resolution is whether the patch

Re: [FFmpeg-devel] FFmpeg TC input needed

2024-02-17 Thread Niklas Haas
On Sat, 17 Feb 2024 18:45:57 +0530 Gyan Doshi wrote: > > Whilst s302m multiple substreams I haven't seen, Dolby E streams internally > > contain multiple programs, often 5.1 and a 2.0 downmix. > > That is downstream of the Dolby-E decoder and user will have to use a > filter like channelsplit to

[FFmpeg-devel] [PATCH] lavc/vvc: Fail inter prediction if using IBC

2024-02-17 Thread Frank Plowman
IBC is not yet implemented. Fail the inter prediction process with AVERROR_PATCHWELCOME if the bitstream uses IBC. Fixes crashes due to out-of-bounds reads when attempting to decode IBC bitstreams. Signed-off-by: Frank Plowman --- libavcodec/vvc/vvc_inter.c | 30 +++---

Re: [FFmpeg-devel] FFmpeg TC input needed

2024-02-17 Thread Gyan Doshi
On 2024-02-17 07:12 pm, Niklas Haas wrote: On Sat, 17 Feb 2024 18:45:57 +0530 Gyan Doshi wrote: Whilst s302m multiple substreams I haven't seen, Dolby E streams internally contain multiple programs, often 5.1 and a 2.0 downmix. That is downstream of the Dolby-E decoder and user will have to

Re: [FFmpeg-devel] FFmpeg TC input needed

2024-02-17 Thread Kieran Kunhya
On Sat, 17 Feb 2024 at 13:16, Gyan Doshi wrote: > > Whilst s302m multiple substreams I haven't seen, Dolby E streams > internally > > contain multiple programs, often 5.1 and a 2.0 downmix. > > That is downstream of the Dolby-E decoder and user will have to use a > filter like channelsplit to bif

[FFmpeg-devel] [PATCH 1/2] swscale/utils: Allocate more dithererror

2024-02-17 Thread Michael Niedermayer
Fixes: out of array read Signed-off-by: Michael Niedermayer --- libswscale/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index ec822ff5d92..4dc0fbfefbf 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -1885,7 +1885,7

[FFmpeg-devel] [PATCH 2/2] swscale/swscale: Check srcSliceH for bayer

2024-02-17 Thread Michael Niedermayer
Fixes: Assertion srcSliceH > 1 failed at libswscale/swscale_unscaled.c:1359 Signed-off-by: Michael Niedermayer --- libswscale/swscale.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index 46ba68fe6a6..7bea5147db1 100644 --- a/lib

Re: [FFmpeg-devel] FFmpeg TC input needed

2024-02-17 Thread Michael Niedermayer
On Sat, Feb 17, 2024 at 05:15:43PM +0530, Gyan Doshi wrote: > Issue: > > Patch: avcodec/s302m: enable non-PCM decoding > URL: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240127103854.9971-1-ffm...@gyani.pro/ > > The issue needing resolution is whether the patch should be added to the >

[FFmpeg-devel] [PATCH] avutil/intreadwrite: Remove obsolete warning

2024-02-17 Thread Andreas Rheinhardt
Obsolete since 7ec2354c38978b918dc079b611393becb6c80bf7. Signed-off-by: Andreas Rheinhardt --- libavutil/intreadwrite.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavutil/intreadwrite.h b/libavutil/intreadwrite.h index 21df7887f3..d0a5773b54 100644 --- a/libavutil/i

[FFmpeg-devel] [PATCH] avutil/tx: Use proper default scale for double MDCT/RDFT

2024-02-17 Thread Andreas Rheinhardt
Fixes a bug and a Clang warning: "use of logical '||' with constant operand [-Wconstant-logical-operand]" Signed-off-by: Andreas Rheinhardt --- libavutil/tx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/tx.c b/libavutil/tx.c index cc360cff31..f7aa409d72 100644

[FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000dec, j2kenc: Constify where appropriate

2024-02-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/j2kenc.c | 2 +- libavcodec/jpeg2000dec.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/j2kenc.c b/libavcodec/j2kenc.c index 789791f529..ebf21f6e7a 100644 --- a/libavcodec/j2kenc.c +++ b/libavc

[FFmpeg-devel] [PATCH] lavu/tx: correctly use a default scale parameter for all transform types

2024-02-17 Thread Lynne
This fixes the previous commit and adds more cases (DCT-I and DST-I). I am holding off on defining a scale parameter for FFTs as I'd like to use a complex value for them. Patch attached. >From 5b58ac6995cd52c3d61d46f5d4eca42a686752b7 Mon Sep 17 00:00:00 2001 From: Lynne Date: Sat, 17 Feb 2024 2

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-17 Thread Anton Khirnov
Quoting Gyan Doshi (2024-02-17 13:37:38) > On 2024-02-17 05:52 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2024-02-17 12:46:27) > >> As a TC member who is part of the disagreement, I believe your > >> participation is recused. > > No, I do not think "TC members who commented on a patch lose th

[FFmpeg-devel] [PATCH 2/4] avcodec/jpeg2000dec: Avoid using GetByteContext.buffer directly

2024-02-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/jpeg2000dec.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index 3d18d48e7c..1afc6b1e2d 100644 --- a/libavcodec/jpeg2000dec.c +++ b/libavcodec/jpeg2000dec.c @@ -886,

[FFmpeg-devel] [PATCH 3/4] avcodec/jpeg2000: Simplify exp2fi for numbers used here

2024-02-17 Thread Andreas Rheinhardt
The call to ff_exp2fi() here always uses arguments in the normal range, so that the branches in ff_exp2fi() are unnecessary. This is so because JPEG2000 itself only supports up to 128 bits per component per pixel (we only support far less); furthermore, expn is always 0..31 for the decoder and also

[FFmpeg-devel] [PATCH 4/4] avcodec/internal: Move ff_exp2fi() to aacsbr.c

2024-02-17 Thread Andreas Rheinhardt
Only used there. Signed-off-by: Andreas Rheinhardt --- libavcodec/aacsbr.c | 39 +-- libavcodec/internal.h | 22 -- 2 files changed, 29 insertions(+), 32 deletions(-) diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c index 683c079b9

[FFmpeg-devel] [PATCH] configure, libavutil/version: Remove unused HAVE_MMX2

2024-02-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- configure | 1 - libavutil/version.c | 1 - 2 files changed, 2 deletions(-) diff --git a/configure b/configure index f72533b7d2..c7defd9bf3 100755 --- a/configure +++ b/configure @@ -8091,7 +8091,6 @@ cat > $TMPH <= 100); -av_assert0(HAVE_MMX2

Re: [FFmpeg-devel] [PATCH 1/8] avfilter/avfilter: Avoid allocation for AVFilterInternal

2024-02-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > To do this, allocate AVFilterInternal jointly with AVFilterContext > and rename it to FFFilterContext in the process (similarly to > AVStream/FFStream). > The AVFilterInternal* will be removed from AVFilterContext > on the next major bump. > > Signed-off-by: Andreas Rheinhard

[FFmpeg-devel] [PATCH 1/8] avformat/demux: allow demuxers to output more than one packet per read_packet() call

2024-02-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/demux.c | 72 + libavformat/demux.h | 2 ++ 2 files changed, 56 insertions(+), 18 deletions(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index b70979c520..e0205f9dec 100644 --- a/libavformat/demu

[FFmpeg-devel] [PATCH 2/8] avformat/iamfdec: further split into shareable modules

2024-02-17 Thread James Almer
Signed-off-by: James Almer --- configure | 2 + libavformat/Makefile | 3 +- libavformat/iamf_reader.c | 366 ++ libavformat/iamf_reader.h | 49 + libavformat/iamfdec.c | 347 ++-- 5 files change

[FFmpeg-devel] [PATCH 3/8] avformat/mov: factorize out setting the output packet properties

2024-02-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 113 ++ 1 file changed, 64 insertions(+), 49 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 92304565df..e548f93f17 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -9192

[FFmpeg-devel] [PATCH 4/8] avformat/mov: make MOVStreamContext refcounted

2024-02-17 Thread James Almer
This will be useful in the next commit. Signed-off-by: James Almer --- libavformat/isom.h | 1 + libavformat/mov.c | 7 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index a4cca4c798..eee94d0449 100644 --- a/libavformat/isom.h +++

[FFmpeg-devel] [PATCH 5/8] avformat/mov: add support for Immersive Audio Model and Formats in ISOBMFF

2024-02-17 Thread James Almer
Signed-off-by: James Almer --- configure | 2 +- libavformat/isom.h | 3 + libavformat/mov.c | 291 ++--- 3 files changed, 279 insertions(+), 17 deletions(-) diff --git a/configure b/configure index 472de63276..968f1ad198 100755 --- a/configu

[FFmpeg-devel] [PATCH 6/8] avformat/iamfenc: further split into shareable modules

2024-02-17 Thread James Almer
Signed-off-by: James Almer --- configure | 4 +- libavformat/Makefile | 3 +- libavformat/iamf_writer.c | 239 ++ libavformat/iamf_writer.h | 7 ++ libavformat/iamfenc.c | 228 ++-- 5 files changed,

[FFmpeg-devel] [PATCH 7/8] avformat/movenc: add support for Immersive Audio Model and Formats in ISOBMFF

2024-02-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 349 +++ libavformat/movenc.h | 6 + 2 files changed, 293 insertions(+), 62 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index c71a9983ed..cd63b353b8 100644 --- a/libavformat/

[FFmpeg-devel] [PATCH 8/8] fate: add IAMF in mp4 tests

2024-02-17 Thread James Almer
Signed-off-by: James Almer --- tests/fate/mov.mak | 35 tests/ref/fate/mov-mp4-iamf-5_1_4 | 98 tests/ref/fate/mov-mp4-iamf-7_1_4 | 114 tests/ref/fate/mov-mp4-iamf-ambisonic_1 | 66 ++ tests/re

Re: [FFmpeg-devel] [PATCH 2/5] avutil/channel_layout: add AV_CHANNEL_ORDER_NB

2024-02-17 Thread Marton Balint
On Fri, 16 Feb 2024, James Almer wrote: On 2/16/2024 7:42 PM, Marton Balint wrote: On Thu, 15 Feb 2024, Anton Khirnov wrote: Quoting Marton Balint (2024-02-13 21:27:34) On Tue, 13 Feb 2024, James Almer wrote: On 2/12/2024 6:15 PM, Marton Balint wrote:  Signed-off-by: Marton Bal

[FFmpeg-devel] [PATCH] tools: Add target_sws_fuzzer.c

2024-02-17 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- Makefile | 3 + tools/Makefile| 3 + tools/target_sws_fuzzer.c | 168 ++ 3 files changed, 174 insertions(+) create mode 100644 tools/target_sws_fuzzer.c diff --git a/Makefile b/Makefile i

Re: [FFmpeg-devel] [PATCH] tools: Add target_sws_fuzzer.c

2024-02-17 Thread Sean McGovern
On Sat, Feb 17, 2024, 18:49 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > Makefile | 3 + > tools/Makefile| 3 + > tools/target_sws_fuzzer.c | 168 ++ > 3 files changed, 174 insertions(+) > create mo

Re: [FFmpeg-devel] [PATCH] tools: Add target_sws_fuzzer.c

2024-02-17 Thread James Almer
On 2/17/2024 8:48 PM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- Makefile | 3 + tools/Makefile| 3 + tools/target_sws_fuzzer.c | 168 ++ 3 files changed, 174 insertions(+) create mode 100644 to

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-17 Thread Michael Niedermayer
On Sat, Feb 17, 2024 at 08:55:43PM +0100, Anton Khirnov wrote: > Quoting Gyan Doshi (2024-02-17 13:37:38) > > On 2024-02-17 05:52 pm, Anton Khirnov wrote: > > > Quoting Gyan Doshi (2024-02-17 12:46:27) > > >> As a TC member who is part of the disagreement, I believe your > > >> participation is rec

Re: [FFmpeg-devel] [PATCH] tools: Add target_sws_fuzzer.c

2024-02-17 Thread Michael Niedermayer
On Sat, Feb 17, 2024 at 09:13:21PM -0300, James Almer wrote: > > > On 2/17/2024 8:48 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > Makefile | 3 + > > tools/Makefile| 3 + > > tools/target_sws_fuzzer.c | 168 +++

[FFmpeg-devel] [PATCH] avutil/common: Move includes to the beginning of the file

2024-02-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/common.h | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/libavutil/common.h b/libavutil/common.h index de2140a678..57c87f1919 100644 --- a/libavutil/common.h +++ b/libavutil/common.h @@ -42,6 +42,13 @@ #inc

Re: [FFmpeg-devel] [PATCH] tools: Add target_sws_fuzzer.c

2024-02-17 Thread Michael Niedermayer
On Sat, Feb 17, 2024 at 07:04:08PM -0500, Sean McGovern wrote: > On Sat, Feb 17, 2024, 18:49 Michael Niedermayer > wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > Makefile | 3 + > > tools/Makefile| 3 + > > tools/target_sws_fuzzer.c | 168 ++

[FFmpeg-devel] [PATCH] avcodec/avcodec: Deprecate AV_INPUT_BUFFER_MIN_SIZE

2024-02-17 Thread Andreas Rheinhardt
It used to be used with preallocated packet buffers with the old encode API, but said API is no more and therefore there is no reason for this to be public any more. So deprecate it and use an internal replacement for the encoders using it as an upper bound for the size of their headers. Signed-of

[FFmpeg-devel] [PATCH 1/7] avcodec/assenc: Use size_t for length of string

2024-02-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/assenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/assenc.c b/libavcodec/assenc.c index e548b9fd3b..e734522729 100644 --- a/libavcodec/assenc.c +++ b/libavcodec/assenc.c @@ -45,7 +45,7 @@ static int ass_enco

[FFmpeg-devel] [PATCH 2/7] avcodec/srtenc: Don't copy data around unnecessarily

2024-02-17 Thread Andreas Rheinhardt
Using av_bprint_init_for_buffer() avoids copying data into the internal AVBPrint buffer (or worse: to allocate a temporary buffer in case the internal buffer does not suffice). It also ensures that the data is always 0-terminated, whereas the current code never does this and returns success in case

[FFmpeg-devel] [PATCH 3/7] avcodec/webvttenc: Don't copy data around unnecessarily

2024-02-17 Thread Andreas Rheinhardt
Using av_bprint_init_for_buffer() avoids copying data into the internal AVBPrint buffer (or worse: to allocate a temporary buffer in case the internal buffer does not suffice). It also ensures that the data is always 0-terminated. Signed-off-by: Andreas Rheinhardt --- libavcodec/webvttenc.c | 10

[FFmpeg-devel] [PATCH 4/7] avcodec/ttmlenc: Don't copy data around unnecessarily

2024-02-17 Thread Andreas Rheinhardt
Using av_bprint_init_for_buffer() avoids copying data into the internal AVBPrint buffer (or worse: to allocate a temporary buffer in case the internal buffer does not suffice). Signed-off-by: Andreas Rheinhardt --- libavcodec/ttmlenc.c | 36 1 file changed, 1

[FFmpeg-devel] [PATCH 5/7] avcodec/ttmlenc: Remove always-true check

2024-02-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ttmlenc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/ttmlenc.c b/libavcodec/ttmlenc.c index f48274d2ea..779cb75199 100644 --- a/libavcodec/ttmlenc.c +++ b/libavcodec/ttmlenc.c @@ -351,9 +351,8 @@ static int

[FFmpeg-devel] [PATCH 6/7] avcodec/srtenc, webvttenc: Use av_printf_format

2024-02-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/srtenc.c| 5 + libavcodec/webvttenc.c | 5 + 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/libavcodec/srtenc.c b/libavcodec/srtenc.c index 9b6f61ebd1..a607beb990 100644 --- a/libavcodec/srtenc.c +++ b/libavcodec/srtenc.

[FFmpeg-devel] [PATCH 7/7] avcodec/movtextenc: Don't copy data around unnecessarily

2024-02-17 Thread Andreas Rheinhardt
Using av_bprint_init_for_buffer() avoids copying data into the internal AVBPrint buffer (or worse: to allocate a temporary buffer in case the internal buffer does not suffice). Signed-off-by: Andreas Rheinhardt --- libavcodec/movtextenc.c | 33 ++--- 1 file changed, 1

[FFmpeg-devel] [PATCH] avutil/version: Remove outdated checks

2024-02-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/version.c | 16 1 file changed, 16 deletions(-) diff --git a/libavutil/version.c b/libavutil/version.c index 75c5c0d1a8..baead7c4a0 100644 --- a/libavutil/version.c +++ b/libavutil/version.c @@ -18,14 +18,9 @@ * Foundation, Inc.,

Re: [FFmpeg-devel] [PATCH] tools: Add target_sws_fuzzer.c

2024-02-17 Thread James Almer
On 2/17/2024 10:03 PM, Michael Niedermayer wrote: On Sat, Feb 17, 2024 at 09:13:21PM -0300, James Almer wrote: On 2/17/2024 8:48 PM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- Makefile | 3 + tools/Makefile| 3 + tools/target_sws

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Fail inter prediction if using IBC

2024-02-17 Thread Nuo Mi
Hi Frank, Thank you for the patch. The IBC is working on my side. I will send out the patch in the following weeks. Could you send me the fuzz file? I want to ensure that it will not cause my patch to crash. On Sat, Feb 17, 2024 at 10:48 PM Frank Plowman wrote: > IBC is not yet implemented. Fai

[FFmpeg-devel] [PATCH 1/5] avcodec/bsf/(hevc|vvc)_mp4toannexb: Ensure extradata_size < INT_MAX

2024-02-17 Thread Andreas Rheinhardt
AVCodecParameters.extradata_size is an int. Signed-off-by: Andreas Rheinhardt --- libavcodec/bsf/hevc_mp4toannexb.c | 2 +- libavcodec/bsf/vvc_mp4toannexb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/bsf/hevc_mp4toannexb.c b/libavcodec/bsf/hevc_mp4toannex

[FFmpeg-devel] [PATCH 2/5] avcodec/bsf/hevc_mp4toannexb: Factor creating new extradata out

2024-02-17 Thread Andreas Rheinhardt
This is in preparation for the next commit. Signed-off-by: Andreas Rheinhardt --- libavcodec/bsf/hevc_mp4toannexb.c | 64 --- 1 file changed, 41 insertions(+), 23 deletions(-) diff --git a/libavcodec/bsf/hevc_mp4toannexb.c b/libavcodec/bsf/hevc_mp4toannexb.c index c

[FFmpeg-devel] [PATCH 3/5] avcodec/bsf/hevc_mp4toannexb: Don't realloc when creating new extradata

2024-02-17 Thread Andreas Rheinhardt
AVCodecParameters.extradata is supposed to be allocated with av_malloc(); av_realloc() and its wrappers do not guarantee the proper alignment. Therefore parse the extradata twice: Once to check its validity and to determine the eventual size and a second time to actually write the new extradata. (

[FFmpeg-devel] [PATCH 4/5] avcodec/bsf/vvc_mp4toannexb: Factor creating new extradata out

2024-02-17 Thread Andreas Rheinhardt
This is in preparation for the next commit. Signed-off-by: Andreas Rheinhardt --- libavcodec/bsf/vvc_mp4toannexb.c | 116 ++- 1 file changed, 67 insertions(+), 49 deletions(-) diff --git a/libavcodec/bsf/vvc_mp4toannexb.c b/libavcodec/bsf/vvc_mp4toannexb.c index 1b85

[FFmpeg-devel] [PATCH 5/5] avcodec/bsf/vvc_mp4toannexb: Don't realloc when creating new extradata

2024-02-17 Thread Andreas Rheinhardt
AVCodecParameters.extradata is supposed to be allocated with av_malloc(); av_realloc() and its wrappers do not guarantee the proper alignment. Therefore parse the extradata twice: Once to check its validity and to determine the eventual size and a second time to actually write the new extradata. (

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/vf_signature: Allocate arrays together

2024-02-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vf_signature.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c > index 4896e8f2c1..eb48bf773d 100644 > --- a/libavfilter/vf_signat

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/bsf/(hevc|vvc)_mp4toannexb: Ensure extradata_size < INT_MAX

2024-02-17 Thread James Almer
On 2/17/2024 11:41 PM, Andreas Rheinhardt wrote: AVCodecParameters.extradata_size is an int. Signed-off-by: Andreas Rheinhardt --- libavcodec/bsf/hevc_mp4toannexb.c | 2 +- libavcodec/bsf/vvc_mp4toannexb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/bs

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-17 Thread Gyan Doshi
On 2024-02-18 01:25 am, Anton Khirnov wrote: Quoting Gyan Doshi (2024-02-17 13:37:38) On 2024-02-17 05:52 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-02-17 12:46:27) As a TC member who is part of the disagreement, I believe your participation is recused. No, I do not think "TC member

Re: [FFmpeg-devel] [PATCH] avutil/tx: Use proper default scale for double MDCT/RDFT

2024-02-17 Thread Peter Ross
On Sat, Feb 17, 2024 at 08:44:47PM +0100, Andreas Rheinhardt wrote: > Fixes a bug and a Clang warning: > "use of logical '||' with constant operand [-Wconstant-logical-operand]" > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/tx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)