[FFmpeg-devel] [PATCH] Fixed nvenc release dump

2023-11-23 Thread GOOR, Jean-Noel
Signed-off-by: GOOR, Jean-Noël --- libavcodec/nvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 3c68ed3930..1f8c7e8c0e 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -1860,7 +1860,7 @@ av_cold int ff_nvenc_encode

[FFmpeg-devel] [PATCH 2/2] tools/general_assembly: restore printing HEAD

2023-11-23 Thread Anton Khirnov
--- tools/general_assembly.pl | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/general_assembly.pl b/tools/general_assembly.pl index 3bf65f3405..13c13bb28f 100755 --- a/tools/general_assembly.pl +++ b/tools/general_assembly.pl @@ -139,5 +139,7 @@ foreach my $name (so

[FFmpeg-devel] [PATCH 1/2] tools/general_assembly: implement extra GA members

2023-11-23 Thread Anton Khirnov
--- tools/general_assembly.pl | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/tools/general_assembly.pl b/tools/general_assembly.pl index 4c3208ccac..3bf65f3405 100755 --- a/tools/general_assembly.pl +++ b/tools/general_assembly.pl @@ -13,6 +13,12 @@ use u

[FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option

2023-11-23 Thread Evgeny Pavlov
This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SAV is an AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances. Signed-off-by: Evgeny Pavlov --- libavcodec/amfenc.h

[FFmpeg-devel] [PATCH v6 2/7] avcodec/webp: remove unused definitions

2023-11-23 Thread Thilo Borgmann via ffmpeg-devel
--- libavcodec/webp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 4994781a64..286e7c8b73 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -60,8 +60,6 @@ #define VP8X_FLAG_ALPHA 0x10 #define VP8X_FLAG_ICC

[FFmpeg-devel] [PATCH v6 3/7] avcodec/webp_parser: parse each frame into one packet

2023-11-23 Thread Thilo Borgmann via ffmpeg-devel
--- libavcodec/webp_parser.c | 130 +++ 1 file changed, 89 insertions(+), 41 deletions(-) diff --git a/libavcodec/webp_parser.c b/libavcodec/webp_parser.c index bd5f94dac5..da853bb1f5 100644 --- a/libavcodec/webp_parser.c +++ b/libavcodec/webp_parser.c @@ -25,1

[FFmpeg-devel] [PATCH v6 1/7] avcodec/webp: move definitions into header

2023-11-23 Thread Thilo Borgmann via ffmpeg-devel
--- libavcodec/webp.c | 1 + libavcodec/webp.h | 38 ++ 2 files changed, 39 insertions(+) create mode 100644 libavcodec/webp.h diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 54b3fde6dc..4994781a64 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp

[FFmpeg-devel] [PATCH v6 0/7] webp: add support for animated WebP decoding

2023-11-23 Thread Thilo Borgmann via ffmpeg-devel
Still images fixed, includes FATE tests, VP8 decoder decoupled so there are no more data races, fixed more asserts. Patch 5/7 is still there for making changes in lavc/webp reviewable but shall be stashed when pushing. -Thilo Josef Zlomek (2): libavcodec/webp: add support for animated WebP d

[FFmpeg-devel] [PATCH v6 6/7] libavformat/webp: add WebP demuxer

2023-11-23 Thread Thilo Borgmann via ffmpeg-devel
From: Josef Zlomek Adds the demuxer of animated WebP files. It supports non-animated, animated, truncated, and concatenated files. Reading from a pipe (and other non-seekable inputs) is also supported. The WebP demuxer splits the input stream into packets containing one frame. It also marks the

[FFmpeg-devel] [PATCH v6 4/7] libavcodec/webp: add support for animated WebP decoding

2023-11-23 Thread Thilo Borgmann via ffmpeg-devel
From: Josef Zlomek Fixes: 4907 Adds support for decoding of animated WebP. The WebP decoder adds the animation related features according to the specs: https://developers.google.com/speed/webp/docs/riff_container#animation The frames of the animation may be smaller than the image canvas. Theref

[FFmpeg-devel] [PATCH v6 7/7] fate: add test for animated WebP

2023-11-23 Thread Thilo Borgmann via ffmpeg-devel
--- tests/fate/image.mak | 3 +++ tests/ref/fate/webp-anim | 22 ++ 2 files changed, 25 insertions(+) create mode 100644 tests/ref/fate/webp-anim diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 400199c28a..2e0d1e8e3f 100644 --- a/tests/fate/image.mak +++ b

[FFmpeg-devel] [PATCH v6 5/7] avcodec/webp: make init_canvas_frame static

2023-11-23 Thread Thilo Borgmann via ffmpeg-devel
--- libavcodec/webp.c | 142 +++--- 1 file changed, 70 insertions(+), 72 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 5e77902128..7e79bd3212 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -1367,7 +1367,76 @@ static int vp

Re: [FFmpeg-devel] [PATCH 2/3] x86/ac3dsp: add ff_float_to_fixed24_avx2()

2023-11-23 Thread James Almer
On 11/23/2023 3:56 AM, Kieran Kunhya wrote: On Wed, 22 Nov 2023, 19:49 James Almer, wrote: Signed-off-by: James Almer --- libavcodec/ac3dsp.h | 4 ++-- libavcodec/ac3enc_template.c | 2 +- libavcodec/x86/ac3dsp.asm| 28 ++-- libavcodec/x86/ac3dsp_in

[FFmpeg-devel] [PATCH] fftools/ffplay_renderer: declare function argument as const

2023-11-23 Thread Leo Izen
Declaring the function argument as const fixes a warning down the line that the const parameter is stripped. We don't modify this argument. Signed-off-by: Leo Izen --- fftools/ffplay_renderer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffplay_renderer.c b/fftool

Re: [FFmpeg-devel] [PATCH 2/3] x86/ac3dsp: add ff_float_to_fixed24_avx2()

2023-11-23 Thread Henrik Gramner via ffmpeg-devel
On Thu, Nov 23, 2023 at 12:51 PM James Almer wrote: > movdqa wiht ymm is avx2. I could change it to movaps, but technically > the registers contain floats and i don't know if any old AVX cpu has > penalties for changing domains. Fwiw I believe what domain the result of fp <-> int conversion instr

[FFmpeg-devel] [PATCH v3] avformat/hls: use av_strlcopy instead of strncpy

2023-11-23 Thread Leo Izen
Avoids a -Wstringop-truncation warning by using av_strlcopy instead of strncpy. Additionally, prints a warning to the log context if this truncation occurred. Signed-off-by: Leo Izen --- libavformat/hls.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH] checkasm/ac3dsp: add float_to_fixed24 test

2023-11-23 Thread Rémi Denis-Courmont
Le torstaina 23. marraskuuta 2023, 9.08.16 EET flow gg a écrit : > You should probably add the test case to tests/fate/checkasm.mak -- レミ・デニ-クールモン http://www.remlab.net/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/

Re: [FFmpeg-devel] [PATCH] ac3dsp: RISC-V V float_to_fixed24

2023-11-23 Thread Rémi Denis-Courmont
Le torstaina 23. marraskuuta 2023, 1.17.03 EET flow gg a écrit : > Hello, I saw the new commit "avcodec/ac3dsp: make len a size_t in > float_to_fixed24." > > So I removed the part #if (__riscv_xlen == 64) and restored the patch. You're not checking for Zba. Also 'bnez' would be more logical than

Re: [FFmpeg-devel] [PATCH] checkasm/ac3dsp: add float_to_fixed24 test

2023-11-23 Thread James Almer
On 11/23/2023 4:08 AM, flow gg wrote: +static void check_float_to_fixed24(AC3DSPContext *c) { +#define BUF_SIZE 1024 +LOCAL_ALIGNED_32(int32_t, v1, [BUF_SIZE]); This one is not necessary. You can reuse dst or dst2 for the bench() as it's write only. +LOCAL_ALIGNED_32(float, v2, [BUF

[FFmpeg-devel] [PATCH 01/13] lavfi/buffersink: avoid leaking peeked_frame on uninit

2023-11-23 Thread Anton Khirnov
--- libavfilter/buffersink.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index ca2af1bc07..3da3331159 100644 --- a/libavfilter/buffersink.c +++ b/libavfilter/buffersink.c @@ -164,6 +164,13 @@ static av_cold int common_init(AVFilt

[FFmpeg-devel] [PATCH 04/13] fftools/ffmpeg: make sure FrameData is writable when we modify it

2023-11-23 Thread Anton Khirnov
Also, add a function that returns const FrameData* for cases that only read from it. --- fftools/ffmpeg.c| 21 + fftools/ffmpeg.h| 2 ++ fftools/ffmpeg_filter.c | 4 ++-- 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/fftools/ffmpeg.c b/fftool

[FFmpeg-devel] [PATCH 03/13] fftools/ffmpeg_filter: track input/output index in {Input, Output}FilterPriv

2023-11-23 Thread Anton Khirnov
Will be useful in following commits. --- fftools/ffmpeg_filter.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index b6fbc5b195..f942c97c40 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -74,6 +74,8 @@ static cons

[FFmpeg-devel] [PATCH 05/13] fftools/ffmpeg_filter: move filtering to a separate thread

2023-11-23 Thread Anton Khirnov
As previously for decoding, this is merely "scaffolding" for moving to a fully threaded architecture and does not yet make filtering truly parallel - the main thread will currently wait for the filtering thread to finish its work before continuing. That will change in future commits after encoders

[FFmpeg-devel] [PATCH 02/13] fftools/ffmpeg_filter: make sub2video heartbeat more robust

2023-11-23 Thread Anton Khirnov
Avoid making decisions based on current graph input state, which makes the output dependent on the order in which the frames from different inputs are interleaved. Makes the output of fate-filter-overlay-dvdsub-2397 more correct - the subtitle appears two frames later, which is closer to its PTS a

[FFmpeg-devel] [PATCH v2] ffmpeg CLI multithreading

2023-11-23 Thread Anton Khirnov
Hi, this is the updated version of the CLI multithreading set. All issues reported in the previous version should be fixed. The -fix_sub_duration_heartbeat option is enabled again, thanks to JEEB for testing. I've now merged the actual conversion patches into the last one, so every patch of the s

[FFmpeg-devel] [PATCH 07/13] fftools/ffmpeg_filter: reindent

2023-11-23 Thread Anton Khirnov
--- fftools/ffmpeg_filter.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 3bafef9717..cd4b55dd40 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -2526,17 +2526,17 @@ static int sub2

[FFmpeg-devel] [PATCH 08/13] fftools/ffmpeg_mux: add muxing thread private data

2023-11-23 Thread Anton Khirnov
To be used for data that never needs to be visible outside of the muxer thread. Start by moving the muxed AVPacket in there. --- fftools/ffmpeg_mux.c | 44 +++- 1 file changed, 35 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffm

[FFmpeg-devel] [PATCH 06/13] fftools/ffmpeg_filter: buffer sub2video heartbeat frames like other frames

2023-11-23 Thread Anton Khirnov
Otherwise they'd be silently ignored if received by the filtering thread before the filtergraph can be initialized, which would make the output dependent on the order in which frames from different inputs arrive. --- fftools/ffmpeg_filter.c | 43 - 1 file ch

[FFmpeg-devel] [PATCH 10/13] fftools/ffmpeg_demux: switch from AVThreadMessageQueue to ThreadQueue

2023-11-23 Thread Anton Khirnov
* the code is made shorter and simpler * avoids constantly allocating and freeing AVPackets, thanks to ThreadQueue integration with ObjPool * is consistent with decoding/filtering/muxing * reduces the diff in the future switch to thread-aware scheduling This makes ifile_get_packet() always block

[FFmpeg-devel] [PATCH 11/13] fftools/ffmpeg_enc: move encoding to a separate thread

2023-11-23 Thread Anton Khirnov
As for the analogous decoding change, this is only a preparatory step to a fully threaded architecture and does not yet make encoding truly parallel. The main thread will currently submit a frame and wait until it has been fully processed by the encoder before moving on. That will change in future

[FFmpeg-devel] [PATCH 09/13] fftools/ffmpeg_mux: move bitstream filtering to the muxer thread

2023-11-23 Thread Anton Khirnov
This will be the appropriate place for it after the rest of transcoding is switched to a threaded architecture. --- fftools/ffmpeg_mux.c | 112 ++- 1 file changed, 67 insertions(+), 45 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c in

[FFmpeg-devel] [PATCH 12/13] fftools/ffmpeg: add thread-aware transcode scheduling infrastructure

2023-11-23 Thread Anton Khirnov
See the comment block at the top of fftools/ffmpeg_sched.h for more details on what this scheduler is for. This commit adds the scheduling code itself, along with minimal integration with the rest of the program: * allocating and freeing the scheduler * passing it throughout the call stack in orde

[FFmpeg-devel] [PATCH 13/13] fftools/ffmpeg: convert to a threaded architecture

2023-11-23 Thread Anton Khirnov
Change the main loop and every component (demuxers, decoders, filters, encoders, muxers) to use the previously added transcode scheduler. Every instance of every such component was already running in a separate thread, but now they can actually run in parallel. Changes the results of ffmpeg-fix_su

Re: [FFmpeg-devel] [PATCH 01/13] lavfi/buffersink: avoid leaking peeked_frame on uninit

2023-11-23 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] ac3dsp: RISC-V V float_to_fixed24

2023-11-23 Thread flow gg
Okay, changed Rémi Denis-Courmont 于2023年11月24日周五 01:09写道: > Le torstaina 23. marraskuuta 2023, 1.17.03 EET flow gg a écrit : > > Hello, I saw the new commit "avcodec/ac3dsp: make len a size_t in > > float_to_fixed24." > > > > So I removed the part #if (__riscv_xlen == 64) and restored the patch.

Re: [FFmpeg-devel] [PATCH] checkasm/ac3dsp: add float_to_fixed24 test

2023-11-23 Thread flow gg
> You should probably add the test case to tests/fate/checkasm.mak > This one is not necessary. You can reuse dst or dst2 for the bench() as it's write only. > Changed BUF_SIZE instead of 10. Okay, changed. James Almer 于2023年11月24日周五 01:11写道: > On 11/23/2023 4:08 AM, flow gg wrote: > > +stati

[FFmpeg-devel] [PATCH 1/2] avcodec/jpegxl_parse{, r}: use correct ISOBMFF extended size location

2023-11-23 Thread Leo Izen
According to ISO/IEC 14996-12, size == 1 means a 64-bit extended-size field occurs *after* the 32-bit box type, not before. This fix should allow correct parsing of JXL files with extended-size boxes. Signed-off-by: Leo Izen --- libavcodec/jpegxl_parse.c | 6 +++--- libavcodec/jpegxl_parser.c |

[FFmpeg-devel] [PATCH 0/2] JPEG XL parser bug fixes

2023-11-23 Thread Leo Izen
Two bug fixes related to the JPEG XL parser. They're not exactly related and don't need to be applied in sequence. Leo Izen (2): avcodec/jpegxl_parse{,r}: use correct ISOBMFF extended size location avcodec/jpegxl_parser: fix parsing sequences of extremely small files libavcodec/jpegxl_parse.

[FFmpeg-devel] [PATCH 2/2] avcodec/jpegxl_parser: fix parsing sequences of extremely small files

2023-11-23 Thread Leo Izen
This patch allows the JXL parser to parse sequences of extremely small files concatenated together. (e.g. smaller than the parser buffer) Signed-off-by: Leo Izen --- libavcodec/jpegxl_parser.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavcodec/jpegxl_p

[FFmpeg-devel] [PATCH 1/3] lavu/hwcontext_d3d11va: Add option vendor_id

2023-11-23 Thread Xiang, Haihao
From: Artem Galin User may choose the hardware via option vendor_id when multiple hardware are available. Signed-off-by: Artem Galin Signed-off-by: Haihao Xiang --- libavutil/hwcontext_d3d11va.c | 67 ++- 1 file changed, 66 insertions(+), 1 deletion(-) diff --

[FFmpeg-devel] [PATCH 2/3] doc/ffmpeg: Update the description about d3d11va

2023-11-23 Thread Xiang, Haihao
From: Haihao Xiang Signed-off-by: Haihao Xiang --- doc/ffmpeg.texi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 68363ae045..5296b75a4e 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1165,6 +1165,21 @@ Choose the first devic

[FFmpeg-devel] [PATCH 3/3] lavu/hwcontext_qsv: Make sure hardware vendor is Intel for qsv on d3d11va

2023-11-23 Thread Xiang, Haihao
From: Haihao Xiang When multiple hardware are available, the default one might not be Intel Hareware. We can use option vendor_id to choose the required vendor. Tested-by: Artem Galin Signed-off-by: Haihao Xiang --- libavutil/hwcontext_qsv.c | 6 ++ 1 file changed, 6 insertions(+) diff -

Re: [FFmpeg-devel] [PATCH 2/3] doc/ffmpeg: Update the description about d3d11va

2023-11-23 Thread Gyan Doshi
On 2023-11-24 11:13 am, Xiang, Haihao wrote: From: Haihao Xiang Signed-off-by: Haihao Xiang --- doc/ffmpeg.texi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 68363ae045..5296b75a4e 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.t

[FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: ignore nonexistent device in default DRM device selection

2023-11-23 Thread Xiang, Haihao
From: Haihao Xiang It is possible that renderD128 doesn't exist but renderD129 is available in a system (see [1]). This change can make sure the default DRM device selection works even if renderD128 doesn't exist. [1] https://github.com/intel/intel-device-plugins-for-kubernetes/blob/main/cmd/gp

Re: [FFmpeg-devel] [PATCH 2/3] doc/ffmpeg: Update the description about d3d11va

2023-11-23 Thread Xiang, Haihao
On Vr, 2023-11-24 at 11:25 +0530, Gyan Doshi wrote: > > > On 2023-11-24 11:13 am, Xiang, Haihao wrote: > > From: Haihao Xiang > > > > Signed-off-by: Haihao Xiang > > --- > >   doc/ffmpeg.texi | 15 +++ > >   1 file changed, 15 insertions(+) > > > > diff --git a/doc/ffmpeg.texi b/doc/

[FFmpeg-devel] [PATCH] lavfi/vf_vpp_qsv: set the default value of async_depth to 4

2023-11-23 Thread Xiang, Haihao
From: Haihao Xiang Both qsv encoders and decoders use 4 as the default value of async_depth, let's use 4 as the default value for vpp_qsv filter too. Signed-off-by: Haihao Xiang --- libavfilter/vf_vpp_qsv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_vpp_

[FFmpeg-devel] [PATCH] Fixed nvenc release dump

2023-11-23 Thread GOOR, Jean-Noel
Signed-off-by: GOOR, Jean-Noël --- libavcodec/nvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 3c68ed3930..1f8c7e8c0e 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -1860,7 +1860,7 @@ av_cold int ff_nvenc_encode

Re: [FFmpeg-devel] [PATCH v4] lavu/hwcontext_vaapi: Use vaMapBuffer2 for mapping image buffers

2023-11-23 Thread Xiang, Haihao
On Vr, 2023-10-27 at 22:25 +0200, David Rosca wrote: > This allows some optimizations in driver, such as not having to read > back the data if write-only mapping is requested. > --- > v4: overwrite + note about vaMapBuffer libva fallback > >  libavutil/hwcontext_vaapi.c | 12 >  1 file

[FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: use mfxImplDescription instead of mfxExtendedDeviceId on Linux

2023-11-23 Thread Xiang, Haihao
From: Haihao Xiang This fixed the issue mentioned in [1] [1] http://ffmpeg.org/pipermail/ffmpeg-user/2023-October/056983.html Signed-off-by: Haihao Xiang --- libavutil/hwcontext_qsv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/hwcontext_qsv.c b/libav