Re: [FFmpeg-devel] [PATCH] vulkan_hevc: switch from a buffer pool to a simple malloc

2023-09-15 Thread Andreas Rheinhardt
Lynne: > Sep 15, 2023, 03:00 by andreas.rheinha...@outlook.com: > >> Lynne: >> >>> -static int get_data_set_buf(FFVulkanDecodeContext *s, AVBufferRef >>> **data_buf, >>> -int nb_vps, AVBufferRef * const >>> vps_list[HEVC_MAX_VPS_COUNT]) >>> +static int alloc_hevc_head

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp3: Move work after ff_thread_finish_setup

2023-09-15 Thread Andreas Rheinhardt
Andreas Rheinhardt: > all_fragments is not synced between threads; resetting it can wait. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c > index 5002800ef2..272dd89117 10

[FFmpeg-devel] [PATCH 1/4] avcodec/evc_ps: Check cpb_cnt_minus1 and propagate error

2023-09-15 Thread Michael Niedermayer
Fixes: out of array access Fixes: 60949/clusterfuzz-testcase-minimized-ffmpeg_dem_EVC_fuzzer-5959738853294080 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/evc_ps.c | 27

[FFmpeg-devel] [PATCH 2/4] avcodec/evc_ps: Check ref_pic_num and sps_max_dec_pic_buffering_minus1

2023-09-15 Thread Michael Niedermayer
Fixes: out of array write Found-by: dongsoo...@korea.ac.kr Signed-off-by: Michael Niedermayer --- libavcodec/evc_ps.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/libavcodec/evc_ps.c b/libavcodec/evc_ps.c index 7fe13fd32f0..96237ed2911 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 3/4] avutil/tx_template: Fix some signed integer overflows in DECL_FFT5()

2023-09-15 Thread Michael Niedermayer
Fixes: signed integer overflow: -1364715454 + -1468954671 cannot be represented in type 'int' Fixes: 62093/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5538774254485504 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Sign

[FFmpeg-devel] [PATCH 4/4] avcodec/osq: avoid using too large numbers for shifts and integers in update_residue_parameter()

2023-09-15 Thread Michael Niedermayer
The code should be changed to not use floats in the VLC parameters This patch merely fixes undefined behavior Fixes: 2.96539e+09 is outside the range of representable values of type 'int' Fixes: Assertion n>=0 && n<=32 failed at libavcodec/get_bits.h:423 Fixes: 62241/clusterfuzz-testcase-minimize

[FFmpeg-devel] [PATCH v2 0/3] Initial support for fragmented TTML muxing

2023-09-15 Thread Jan Ekström
Changes compared to v1: * General rebase. * A FATE test was added, together with the extension of the "transcode" test function to allow for dumping of packets' contents. * Simplified mov_write_ttml_document_from_queue's loop by getting rid of `stop_at_current_packet`. This enables pushing TT

[FFmpeg-devel] [PATCH v2 1/3] tests/fate-run: add support for specifying the final encode muxer in `transcode`

2023-09-15 Thread Jan Ekström
From: Jan Ekström This allows for direct dumping of the packets' contents (useful for text based formats), while getting the timestamps/sizes etc from ffprobe. If used via TRANSCODE, the actually utilized muxer should be added within the last argument as an additional dependency, as that is not

[FFmpeg-devel] [PATCH v2 2/3] avcodec/avpacket: add functionality to prepend to AVPacketLists

2023-09-15 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- libavcodec/avpacket.c| 20 +++- libavcodec/packet_internal.h | 2 ++ 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 9ec1feb068..21e80416de 100644 --- a/

[FFmpeg-devel] [PATCH v2 3/3] avformat/movenc: add support for fragmented TTML muxing

2023-09-15 Thread Jan Ekström
From: Jan Ekström Attempts to base the fragmentation timing on other streams as most receivers expect media fragments to be more or less aligned. Currently does not support fragmentation on subtitle track only, as the subtitle packet queue timings would have to be checked in addition to the curr

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/osq: avoid using too large numbers for shifts and integers in update_residue_parameter()

2023-09-15 Thread Paul B Mahol
On Fri, Sep 15, 2023 at 3:12 PM Michael Niedermayer wrote: > The code should be changed to not use floats in the VLC parameters > This patch merely fixes undefined behavior > > Fixes: 2.96539e+09 is outside the range of representable values of type > 'int' > Fixes: Assertion n>=0 && n<=32 failed

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/evc_ps: Check ref_pic_num and sps_max_dec_pic_buffering_minus1

2023-09-15 Thread James Almer
On 9/15/2023 10:11 AM, Michael Niedermayer wrote: Fixes: out of array write Found-by: dongsoo...@korea.ac.kr Signed-off-by: Michael Niedermayer --- libavcodec/evc_ps.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/libavcodec/evc_ps.c b/libavcodec/evc_ps.c

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/osq: avoid using too large numbers for shifts and integers in update_residue_parameter()

2023-09-15 Thread Michael Niedermayer
On Fri, Sep 15, 2023 at 03:54:19PM +0200, Paul B Mahol wrote: > On Fri, Sep 15, 2023 at 3:12 PM Michael Niedermayer > wrote: > > > The code should be changed to not use floats in the VLC parameters > > This patch merely fixes undefined behavior > > > > Fixes: 2.96539e+09 is outside the range of r

[FFmpeg-devel] [PATCH 4/6] avcodec/vp3: Fix undefined pointer arithmetic

2023-09-15 Thread Andreas Rheinhardt
When decoding a keyframe, last_frame and golden_frame are not used at all and (at least when starting decoding) are not set at all. But due to code sharing pointer arithmetic on the NULL data-pointers of these frames has nevertheless been performed. This is undefined behaviour and causes e.g. "runt

[FFmpeg-devel] [PATCH 5/6] avcodec/vp3: Simplify shuffling frames, fix crash on alloc error

2023-09-15 Thread Andreas Rheinhardt
When decoding non-keyframes, the decoding process expects there to be two reference frames, the last one and the golden one. The existence of the golden one is checked and in case it is there, it is presumed that the last one exists as well. This assumption is wrong in case of memory allocation fa

[FFmpeg-devel] [PATCH 6/6] avcodec/vp3: Don't truncate ptrdiff_t

2023-09-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/vp3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index f12bd497b9..98dabfc907 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -1954,7 +1954,7 @@ static void await_reference_row(Vp

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/evc_ps: Check ref_pic_num and sps_max_dec_pic_buffering_minus1

2023-09-15 Thread Michael Niedermayer
On Fri, Sep 15, 2023 at 10:57:29AM -0300, James Almer wrote: > On 9/15/2023 10:11 AM, Michael Niedermayer wrote: > > Fixes: out of array write > > > > Found-by: dongsoo...@korea.ac.kr > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/evc_ps.c | 13 + > > 1 file changed,

[FFmpeg-devel] [PATCH] avfilter/vf_smartblur: pass old context to sws_getCachedContext

2023-09-15 Thread Zhao Zhili
From: Zhao Zhili Otherwise it make no sense to use sws_getCachedContext. --- libavfilter/vf_smartblur.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_smartblur.c b/libavfilter/vf_smartblur.c index 85d8d502e1..ae0ec05b2d 100644 --- a/libavfilter/vf_smartblur.c

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/vp3: Don't truncate ptrdiff_t

2023-09-15 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] vulkan_hevc: switch from a buffer pool to a simple malloc

2023-09-15 Thread Lynne
Sep 15, 2023, 10:34 by andreas.rheinha...@outlook.com: > Lynne: > >> Sep 15, 2023, 03:00 by andreas.rheinha...@outlook.com: >> >>> Lynne: >>> -static int get_data_set_buf(FFVulkanDecodeContext *s, AVBufferRef **data_buf, -int nb_vps, AVBufferRef * const

Re: [FFmpeg-devel] [PATCH] [RFC]avformat: introduce AVStreamGroup

2023-09-15 Thread James Almer
On 9/13/2023 6:34 AM, Tomas Härdin wrote: ons 2023-09-06 klockan 16:16 -0300 skrev James Almer: On 9/6/2023 2:53 PM, Tomas Härdin wrote: ons 2023-09-06 klockan 11:38 -0300 skrev James Almer: Signed-off-by: James Almer --- This is an initial proof of concept for AVStream groups, something that

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-15 Thread Kyle Swanson
Hi, On Thu, Sep 14, 2023 at 12:10 PM Timo Rothenpieler wrote: > This looks more complicated than necessary to me. > > My idea would have been to change, in the previous original patch, > > > libvmaf_cuda_filter_deps="libvmaf ffnvcodec" > > to > > > libvmaf_cuda_filter_deps="libvmaf libvmaf_cuda

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-15 Thread Timo Rothenpieler
On 15.09.2023 22:31, Kyle Swanson wrote: Hi, On Thu, Sep 14, 2023 at 12:10 PM Timo Rothenpieler wrote: This looks more complicated than necessary to me. My idea would have been to change, in the previous original patch, > libvmaf_cuda_filter_deps="libvmaf ffnvcodec" to > libvmaf_cuda_f

[FFmpeg-devel] [PATCH] avcodec/dnxhddec: Use VLC symbol table to avoid lookup

2023-09-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/dnxhddec.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavcodec/dnxhddec.c b/libavcodec/dnxhddec.c index b5f4e053c0..703d0e341c 100644 --- a/libavcodec/dnxhddec.c +++ b/libavcodec/dnxhddec.c @@ -142,9 +142,10